From: Andrew Lunn <andrew@lunn.ch>
To: Fabio Estevam <festevam@gmail.com>
Cc: Abel Vesa <abel.vesa@nxp.com>,
Steve Twiss <stwiss.opensource@diasemi.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
DEVICETREE <devicetree@vger.kernel.org>,
LINUX-ARM-KERNEL <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Support Opensource <Support.Opensource@diasemi.com>
Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id
Date: Thu, 21 Mar 2019 12:45:44 +0100 [thread overview]
Message-ID: <20190321114544.GG2900@lunn.ch> (raw)
In-Reply-To: <CAOMZO5Cz0A19P9E61dy79BFF+V2WsAjobqQ1g9TeiJSCY2Nt4A@mail.gmail.com>
On Thu, Mar 21, 2019 at 08:17:01AM -0300, Fabio Estevam wrote:
> Hi Abel,
>
> On Thu, Mar 21, 2019 at 5:42 AM Abel Vesa <abel.vesa@nxp.com> wrote:
>
> > > It seems we have other boards that need to be fixed and we can not
> > > have an old dtb with functional Ethernet with a new kernel.
> > >
> > > Does anyone know if this issue is AR8031 specific?
> >
> > I can confirm the same fix is works on imx6sx too.
>
> imx6sx-sabresd also uses an AR8031 Ethernet PHY.
>
> I also tested that changing the phy-mode to "rgmii-id" fixes Ethernet
> on pico-imx7d with AR8035.
>
> So yes, we currently have lots of broken dtb's in mainline and I am
> wondering what is the proper fix here.
>
> Does anyone know what was the kernel commit that introduced such regressions?
Hi Fabio
The problem here is, all the DTs were broken since day 0. However,
because the PHY driver was also broken, nobody noticed and it
worked. Now that the PHY driver has been fixed, all the bugs in the
DTs now become an issue.
There is also a need to fix the PHY driver, because there is at least
one board which needs it fixed in order to work.
When we discussed fixing the PHY driver, we had no idea how many
boards would break. So we said, lets try it, and fix up whatever
breaks. We can however discuss this again. We can declare both the PHY
driver and the DTs terminally broken, and add a vendor proprietary
property for the phy-mode, which takes preference over the standard
phy-mode if present, and that does the correct thing.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Fabio Estevam <festevam@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
DEVICETREE <devicetree@vger.kernel.org>,
Abel Vesa <abel.vesa@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Steve Twiss <stwiss.opensource@diasemi.com>,
dl-linux-imx <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
LINUX-ARM-KERNEL <linux-arm-kernel@lists.infradead.org>,
Support Opensource <Support.Opensource@diasemi.com>
Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id
Date: Thu, 21 Mar 2019 12:45:44 +0100 [thread overview]
Message-ID: <20190321114544.GG2900@lunn.ch> (raw)
In-Reply-To: <CAOMZO5Cz0A19P9E61dy79BFF+V2WsAjobqQ1g9TeiJSCY2Nt4A@mail.gmail.com>
On Thu, Mar 21, 2019 at 08:17:01AM -0300, Fabio Estevam wrote:
> Hi Abel,
>
> On Thu, Mar 21, 2019 at 5:42 AM Abel Vesa <abel.vesa@nxp.com> wrote:
>
> > > It seems we have other boards that need to be fixed and we can not
> > > have an old dtb with functional Ethernet with a new kernel.
> > >
> > > Does anyone know if this issue is AR8031 specific?
> >
> > I can confirm the same fix is works on imx6sx too.
>
> imx6sx-sabresd also uses an AR8031 Ethernet PHY.
>
> I also tested that changing the phy-mode to "rgmii-id" fixes Ethernet
> on pico-imx7d with AR8035.
>
> So yes, we currently have lots of broken dtb's in mainline and I am
> wondering what is the proper fix here.
>
> Does anyone know what was the kernel commit that introduced such regressions?
Hi Fabio
The problem here is, all the DTs were broken since day 0. However,
because the PHY driver was also broken, nobody noticed and it
worked. Now that the PHY driver has been fixed, all the bugs in the
DTs now become an issue.
There is also a need to fix the PHY driver, because there is at least
one board which needs it fixed in order to work.
When we discussed fixing the PHY driver, we had no idea how many
boards would break. So we said, lets try it, and fix up whatever
breaks. We can however discuss this again. We can declare both the PHY
driver and the DTs terminally broken, and add a vendor proprietary
property for the phy-mode, which takes preference over the standard
phy-mode if present, and that does the correct thing.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-21 11:45 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 11:03 [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id Steve Twiss
2019-03-20 11:03 ` Steve Twiss
2019-03-20 12:16 ` Fabio Estevam
2019-03-20 12:16 ` Fabio Estevam
2019-03-20 16:03 ` Steve Twiss
2019-03-20 16:03 ` Steve Twiss
2019-03-20 17:04 ` Fabio Estevam
2019-03-20 17:04 ` Fabio Estevam
2019-03-21 8:42 ` Abel Vesa
2019-03-21 8:42 ` Abel Vesa
2019-03-21 11:17 ` Fabio Estevam
2019-03-21 11:17 ` Fabio Estevam
2019-03-21 11:32 ` Steve Twiss
2019-03-21 11:32 ` Steve Twiss
2019-03-21 11:50 ` Andrew Lunn
2019-03-21 11:50 ` Andrew Lunn
2019-03-21 11:45 ` Andrew Lunn [this message]
2019-03-21 11:45 ` Andrew Lunn
2019-03-21 12:43 ` Lucas Stach
2019-03-21 12:43 ` Lucas Stach
2019-03-22 1:11 ` Shawn Guo
2019-03-22 1:11 ` Shawn Guo
2019-03-22 2:00 ` Fabio Estevam
2019-03-22 2:00 ` Fabio Estevam
2019-03-22 2:15 ` Shawn Guo
2019-03-22 2:15 ` Shawn Guo
2019-03-22 2:24 ` Fabio Estevam
2019-03-22 2:24 ` Fabio Estevam
2019-03-22 10:20 ` Michal Vokáč
2019-03-22 10:20 ` Michal Vokáč
2019-03-22 10:50 ` Steve Twiss
2019-03-22 10:50 ` Steve Twiss
2019-03-22 10:50 ` Steve Twiss
2019-03-22 10:59 ` Andrew Lunn
2019-03-22 10:59 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321114544.GG2900@lunn.ch \
--to=andrew@lunn.ch \
--cc=Support.Opensource@diasemi.com \
--cc=abel.vesa@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stwiss.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.