All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michal Vokáč" <michal.vokac@ysoft.com>
To: Fabio Estevam <festevam@gmail.com>, Shawn Guo <shawnguo@kernel.org>
Cc: Abel Vesa <abel.vesa@nxp.com>,
	Steve Twiss <stwiss.opensource@diasemi.com>,
	Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	dl-linux-imx <linux-imx@nxp.com>,
	DEVICETREE <devicetree@vger.kernel.org>,
	LINUX-ARM-KERNEL <linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Support Opensource <Support.Opensource@diasemi.com>
Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id
Date: Fri, 22 Mar 2019 11:20:44 +0100	[thread overview]
Message-ID: <db0a3a96-d836-f7bd-4773-81fcb7984835@ysoft.com> (raw)
In-Reply-To: <CAOMZO5CRRg9XD9VovcO5+fdM1DBp12P33T9xgW=cEvTES8yDPA@mail.gmail.com>

On 22. 03. 19 3:24, Fabio Estevam wrote:
> On Thu, Mar 21, 2019 at 11:15 PM Shawn Guo <shawnguo@kernel.org> wrote:
> 
>>> Unfortunately, just by looking at the dts files we do not know if a
>>> board uses an AR803x PHY or not, so I am afraid we can not do an
>>> automatic conversion.
>>
>> At least for those we already know?
> 
> Yes, I can help preparing a patch that fixes the i.MX boards we know
> use AR8031 PHY.

AFACT this issue is not AR803x specific. I was hit by the same problem
with QCA833x switch on imx6dl-yapp4. Though, we are currently the only
platform in tree using this chip and Shawn already has the fix in his tree.

I am not aware of any other PHY drivers that my cause problems.

$ git log --oneline v5.0..v5.1-rc1 --grep=RGMII --author=Vinod -- drivers/net/
6d4cd041f0af net: phy: at803x: disable delay only for RGMII mode
a968b5e9d587 net: dsa: qca8k: Enable delay for RGMII_ID mode
5ecdd77c61c8 net: dsa: qca8k: disable delay for RGMII mode
cd28d1d6e52e net: phy: at803x: Disable phy delay for RGMII mode

Michal

WARNING: multiple messages have this Message-ID (diff)
From: "Michal Vokáč" <michal.vokac@ysoft.com>
To: Fabio Estevam <festevam@gmail.com>, Shawn Guo <shawnguo@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
	Abel Vesa <abel.vesa@nxp.com>,
	DEVICETREE <devicetree@vger.kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Steve Twiss <stwiss.opensource@diasemi.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	LINUX-ARM-KERNEL <linux-arm-kernel@lists.infradead.org>,
	Support Opensource <Support.Opensource@diasemi.com>
Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id
Date: Fri, 22 Mar 2019 11:20:44 +0100	[thread overview]
Message-ID: <db0a3a96-d836-f7bd-4773-81fcb7984835@ysoft.com> (raw)
In-Reply-To: <CAOMZO5CRRg9XD9VovcO5+fdM1DBp12P33T9xgW=cEvTES8yDPA@mail.gmail.com>

On 22. 03. 19 3:24, Fabio Estevam wrote:
> On Thu, Mar 21, 2019 at 11:15 PM Shawn Guo <shawnguo@kernel.org> wrote:
> 
>>> Unfortunately, just by looking at the dts files we do not know if a
>>> board uses an AR803x PHY or not, so I am afraid we can not do an
>>> automatic conversion.
>>
>> At least for those we already know?
> 
> Yes, I can help preparing a patch that fixes the i.MX boards we know
> use AR8031 PHY.

AFACT this issue is not AR803x specific. I was hit by the same problem
with QCA833x switch on imx6dl-yapp4. Though, we are currently the only
platform in tree using this chip and Shawn already has the fix in his tree.

I am not aware of any other PHY drivers that my cause problems.

$ git log --oneline v5.0..v5.1-rc1 --grep=RGMII --author=Vinod -- drivers/net/
6d4cd041f0af net: phy: at803x: disable delay only for RGMII mode
a968b5e9d587 net: dsa: qca8k: Enable delay for RGMII_ID mode
5ecdd77c61c8 net: dsa: qca8k: disable delay for RGMII mode
cd28d1d6e52e net: phy: at803x: Disable phy delay for RGMII mode

Michal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-03-22 10:20 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 11:03 [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id Steve Twiss
2019-03-20 11:03 ` Steve Twiss
2019-03-20 12:16 ` Fabio Estevam
2019-03-20 12:16   ` Fabio Estevam
2019-03-20 16:03   ` Steve Twiss
2019-03-20 16:03     ` Steve Twiss
2019-03-20 17:04     ` Fabio Estevam
2019-03-20 17:04       ` Fabio Estevam
2019-03-21  8:42       ` Abel Vesa
2019-03-21  8:42         ` Abel Vesa
2019-03-21 11:17         ` Fabio Estevam
2019-03-21 11:17           ` Fabio Estevam
2019-03-21 11:32           ` Steve Twiss
2019-03-21 11:32             ` Steve Twiss
2019-03-21 11:50             ` Andrew Lunn
2019-03-21 11:50               ` Andrew Lunn
2019-03-21 11:45           ` Andrew Lunn
2019-03-21 11:45             ` Andrew Lunn
2019-03-21 12:43           ` Lucas Stach
2019-03-21 12:43             ` Lucas Stach
2019-03-22  1:11           ` Shawn Guo
2019-03-22  1:11             ` Shawn Guo
2019-03-22  2:00             ` Fabio Estevam
2019-03-22  2:00               ` Fabio Estevam
2019-03-22  2:15               ` Shawn Guo
2019-03-22  2:15                 ` Shawn Guo
2019-03-22  2:24                 ` Fabio Estevam
2019-03-22  2:24                   ` Fabio Estevam
2019-03-22 10:20                   ` Michal Vokáč [this message]
2019-03-22 10:20                     ` Michal Vokáč
2019-03-22 10:50                     ` Steve Twiss
2019-03-22 10:50                       ` Steve Twiss
2019-03-22 10:50                       ` Steve Twiss
2019-03-22 10:59                       ` Andrew Lunn
2019-03-22 10:59                         ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db0a3a96-d836-f7bd-4773-81fcb7984835@ysoft.com \
    --to=michal.vokac@ysoft.com \
    --cc=Support.Opensource@diasemi.com \
    --cc=abel.vesa@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stwiss.opensource@diasemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.