All of lore.kernel.org
 help / color / mirror / Atom feed
* Commit for recipe detail view ready for review
@ 2014-01-17  2:26 Reyna, David
  2014-01-17 16:13 ` Barros Pena, Belen
  0 siblings, 1 reply; 4+ messages in thread
From: Reyna, David @ 2014-01-17  2:26 UTC (permalink / raw)
  To: Lerner, Dave, Damian, Alexandru (alexandru.damian@intel.com),
	Eggleton, Paul (paul.eggleton@intel.com),
	Barros Pena, Belen (belen.barros.pena@intel.com),
	Ravi Chintakunta (ravi.chintakunta@timesys.com)
  Cc: jessica.zhang, toaster

Hi all,

I have pushed my commit for the recipe details page for review. There are two separate commits for tracking purposes.

Branch: dreyna/recipe-detail-view

(a) Implementation of base build details page. This adds the proposed base page for details pages.

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/recipe-detail-view&id=95d3ebecbbf87af3a657bb7fcd7785700fb42c6c

(b) Implementation of recipe detail views. This adds the recipe details page with an updated view context, plus renames and links the recipe summary page.

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/recipe-detail-view&id=95d3ebecbbf87af3a657bb7fcd7785700fb42c6c

(c) I have implemeted Alex's review comments. The test plan remains the same as my previous submission. 


Development Notes
=================

* This commit uses and depends upon Ravi's 'task_color' template tag, as discussed.

* The recipe summary page is a placeholder to allow access to the recipe details page. The recipe summary page will be subsequently updated to the new design requirements in a separate commit.


Test Instructions
=================

1) Create a default Yocto project (qemux86), and start the Toaster.

  $ source poky/oe-init-build-env
  $ cd build
  $ source toaster start
  $ bitbake core-image-minimal
  $ xdg-open http://localhost:8000/

2) Select the "core-image-minimal" build link

3) Select the "Recipes" link in the left sidebar

Observe that the recipes are listed in a table, and that each recipe name is a live URL link.

4) Click on the "busybox" recipe name link

Observe:
  a) The "breadcrumbs" at the top include is in this form form, and that all but the last entry are live links.
  
	     All builds > core-image-sato atom-pc (<time>) > Recipes > busybox_1.21.1-r0
	 
  b) The informational sidebar on the right contains information pertinent to the "busybox" recipe, 
  
  c) Some 14 task entries, starting with "do_patch" and ending with "do_build" If you hover over a recipe name, you will see a question-mark icon appear, and if you hover over that a tooltip will appear for that task.
  
  d) Any task outcome of "Succeeded" should be in normal black. Any outcome of "Failed" (not likely) would be red, and all other tasks should be in grey.
  
  e) The layer description will indicate the layer "meta", and the recipe will point to "busybox_1.21.1.bb".

  f) The right-hand sidebar about busybox is still present.
  
5) Observe that "Packages" link. It should have an appended value like "(4)". Now click on this link.

Observe:
  a) The number of packages matches the previous number in parenthesis.
  
  b) Each package has a version and a size. The size may be zero.
  
  c) Note that if you hover on a package name, it will reveal a URL of the following form. This link should take you to the corresponding package detail page once you have the fix for 4328 pulled.
  
	localhost:8000/gui/build/<number>/package/<number>  

6) Observe that "Build Dependencies" link. It should have an appended value like "(0)". Now click on this link.

Observe:
  a) No dependencies appear, and you get a message of the form:
  
  "$RECIPE_NAME_VERSION has no build dependencies."
 
7) Observe that "Reverse build dependencies" link. It should have an appended value like "(1)". Now click on this link.

Observe:
  a) The number of packages matches the previous number in parenthesis.
  
  b) The recipe dependency should be "packagegroup-core-boot", 
  
  c) There should be a respective version displayed, for example "1.0-r11"
 
  d) If you hover on the recipe name, it will reveal a URL of the following form. This link should take you to the corresponding recipe detail page.
  
	localhost:8000/gui/build/<number>/recipe/<number>

8) Click the breadcrumb "Recipes" at the top, locate the "gdbm" recipe, and select it.

9) Observe that "Packages" link. It should have an appended value like "(0)". Now click on this link.

Observe:
  a) No packages appear, and you get a message of the form:
  
  "$PACKAGE_NAME_VERSION does not build any packages."
 
10) Observe that "Build dependencies" link. It should have an appended value like "(2)". Now click on this link.

Observe:
  a) The number of build dependencies matches the previous number in parenthesis.
  
  b) The recipe dependency should have values like "gettext-native" and "libtool-cross". 
  
  c) There should be a respective versions displayed for each dependency.
 
  d) If you hover on a recipe name, it will reveal a URL of the following form. This link should take you to the corresponding recipe detail page.
  
	localhost:8000/gui/build/<number>/recipe/<number>

11) Observe that "Reverse build dependencies" link. It should have an appended value like "(0)". Now click on this link.

Observe:
  a) No reverse dependencies appear, and you get a message of the form:
  
  "$RECIPE_NAME_VERSION does not build any packages."

12) Select the recipe "base-files". It my build it did not have any tasks, and in this case instead of the task table you will observe the message:

  "$PACKAGE_NAME_VERSION does not have any tasks executed yet."

13) NOTE: to simulate the "error" task entry coloring, make the following _temporary_ change to "projecttags.py", and select a new recipe. All of the task entries should now be highlighted in red.

toastergui/templatetags/projecttags.py:
     if not task_object.task_executed:
+        return 'class=muted'
-        return 'class=error'



David





^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Commit for recipe detail view ready for review
  2014-01-17  2:26 Commit for recipe detail view ready for review Reyna, David
@ 2014-01-17 16:13 ` Barros Pena, Belen
  2014-01-17 18:37   ` Reyna, David
  0 siblings, 1 reply; 4+ messages in thread
From: Barros Pena, Belen @ 2014-01-17 16:13 UTC (permalink / raw)
  To: Reyna, David L (Wind River); +Cc: toaster

[-- Attachment #1: Type: text/plain, Size: 7608 bytes --]

Hi David,

Thanks for pushing this: it¹s looking great :)

From a UI standpoint, the page seems to have a small layout issue that
makes the heading and the tabs not to align properly. To fix it, the body
structure should look like this:

<body>
    <div class=³navbar navbar-static-top²></div>
    <div class=³container-fluid²>
        <div class=³row-fluid²>
	    <div class=³section²></div>
	    <div class=³row span11²></div>
	    <div class=³row span7 tabbable²></div>
	    <div class=³row span4 well²></div>
        </div>
    </div>
</body>

You need to add the class row-fluid to the child of container-fluid, and
remove the div with class row-fluid that is a sibling of the div with
class section. That will align all content nicely.

Only 3 other things:

1. Next to the layer name you are showing the blue icon that links to the
layer index. We currently have an issue with this that we still don¹t know
how to solve (see 5192 in Bugzilla). Can we take the icon out for the
moment until we find the right solution?

2. I am finding recipes that report no tasks in their tasks table (see
attached image). This should not happen, and in fact when you go to the
tasks list there are tasks for those recipes.

3. The Bugtracker value seems to have a trailing / (see attached image).
So if there is no bugtracker specified for the recipe, the / shows. If any
of the variables used to populate the information about the recipe is not
specified in the recipe file, we simply don¹t show them. For example, if
there is no bugtracker, we show only summary, description, homepage,
section and license.

Any questions, let me know.

Cheers

Belén


On 17/01/2014 02:26, "Reyna, David" <david.reyna@windriver.com> wrote:

>Hi all,
>
>I have pushed my commit for the recipe details page for review. There are
>two separate commits for tracking purposes.
>
>Branch: dreyna/recipe-detail-view
>
>(a) Implementation of base build details page. This adds the proposed
>base page for details pages.
>
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/re
>cipe-detail-view&id=95d3ebecbbf87af3a657bb7fcd7785700fb42c6c
>
>(b) Implementation of recipe detail views. This adds the recipe details
>page with an updated view context, plus renames and links the recipe
>summary page.
>
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/re
>cipe-detail-view&id=95d3ebecbbf87af3a657bb7fcd7785700fb42c6c
>
>(c) I have implemeted Alex's review comments. The test plan remains the
>same as my previous submission.
>
>
>Development Notes
>=================
>
>* This commit uses and depends upon Ravi's 'task_color' template tag, as
>discussed.
>
>* The recipe summary page is a placeholder to allow access to the recipe
>details page. The recipe summary page will be subsequently updated to the
>new design requirements in a separate commit.
>
>
>Test Instructions
>=================
>
>1) Create a default Yocto project (qemux86), and start the Toaster.
>
>  $ source poky/oe-init-build-env
>  $ cd build
>  $ source toaster start
>  $ bitbake core-image-minimal
>  $ xdg-open http://localhost:8000/
>
>2) Select the "core-image-minimal" build link
>
>3) Select the "Recipes" link in the left sidebar
>
>Observe that the recipes are listed in a table, and that each recipe name
>is a live URL link.
>
>4) Click on the "busybox" recipe name link
>
>Observe:
>  a) The "breadcrumbs" at the top include is in this form form, and that
>all but the last entry are live links.
>  
>	     All builds > core-image-sato atom-pc (<time>) > Recipes >
>busybox_1.21.1-r0
>	 
>  b) The informational sidebar on the right contains information
>pertinent to the "busybox" recipe,
>  
>  c) Some 14 task entries, starting with "do_patch" and ending with
>"do_build" If you hover over a recipe name, you will see a question-mark
>icon appear, and if you hover over that a tooltip will appear for that
>task.
>  
>  d) Any task outcome of "Succeeded" should be in normal black. Any
>outcome of "Failed" (not likely) would be red, and all other tasks should
>be in grey.
>  
>  e) The layer description will indicate the layer "meta", and the recipe
>will point to "busybox_1.21.1.bb".
>
>  f) The right-hand sidebar about busybox is still present.
>  
>5) Observe that "Packages" link. It should have an appended value like
>"(4)". Now click on this link.
>
>Observe:
>  a) The number of packages matches the previous number in parenthesis.
>  
>  b) Each package has a version and a size. The size may be zero.
>  
>  c) Note that if you hover on a package name, it will reveal a URL of
>the following form. This link should take you to the corresponding
>package detail page once you have the fix for 4328 pulled.
>  
>	localhost:8000/gui/build/<number>/package/<number>
>
>6) Observe that "Build Dependencies" link. It should have an appended
>value like "(0)". Now click on this link.
>
>Observe:
>  a) No dependencies appear, and you get a message of the form:
>  
>  "$RECIPE_NAME_VERSION has no build dependencies."
> 
>7) Observe that "Reverse build dependencies" link. It should have an
>appended value like "(1)". Now click on this link.
>
>Observe:
>  a) The number of packages matches the previous number in parenthesis.
>  
>  b) The recipe dependency should be "packagegroup-core-boot",
>  
>  c) There should be a respective version displayed, for example "1.0-r11"
> 
>  d) If you hover on the recipe name, it will reveal a URL of the
>following form. This link should take you to the corresponding recipe
>detail page.
>  
>	localhost:8000/gui/build/<number>/recipe/<number>
>
>8) Click the breadcrumb "Recipes" at the top, locate the "gdbm" recipe,
>and select it.
>
>9) Observe that "Packages" link. It should have an appended value like
>"(0)". Now click on this link.
>
>Observe:
>  a) No packages appear, and you get a message of the form:
>  
>  "$PACKAGE_NAME_VERSION does not build any packages."
> 
>10) Observe that "Build dependencies" link. It should have an appended
>value like "(2)". Now click on this link.
>
>Observe:
>  a) The number of build dependencies matches the previous number in
>parenthesis.
>  
>  b) The recipe dependency should have values like "gettext-native" and
>"libtool-cross". 
>  
>  c) There should be a respective versions displayed for each dependency.
> 
>  d) If you hover on a recipe name, it will reveal a URL of the following
>form. This link should take you to the corresponding recipe detail page.
>  
>	localhost:8000/gui/build/<number>/recipe/<number>
>
>11) Observe that "Reverse build dependencies" link. It should have an
>appended value like "(0)". Now click on this link.
>
>Observe:
>  a) No reverse dependencies appear, and you get a message of the form:
>  
>  "$RECIPE_NAME_VERSION does not build any packages."
>
>12) Select the recipe "base-files". It my build it did not have any
>tasks, and in this case instead of the task table you will observe the
>message:
>
>  "$PACKAGE_NAME_VERSION does not have any tasks executed yet."
>
>13) NOTE: to simulate the "error" task entry coloring, make the following
>_temporary_ change to "projecttags.py", and select a new recipe. All of
>the task entries should now be highlighted in red.
>
>toastergui/templatetags/projecttags.py:
>     if not task_object.task_executed:
>+        return 'class=muted'
>-        return 'class=error'
>
>
>
>David
>
>
>


[-- Attachment #2: no-tasks-and-bugtracker.png --]
[-- Type: image/png, Size: 87356 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Commit for recipe detail view ready for review
  2014-01-17 16:13 ` Barros Pena, Belen
@ 2014-01-17 18:37   ` Reyna, David
  2014-01-20 10:11     ` Barros Pena, Belen
  0 siblings, 1 reply; 4+ messages in thread
From: Reyna, David @ 2014-01-17 18:37 UTC (permalink / raw)
  To: Barros Pena, Belen; +Cc: toaster

Hi Belen,

See inline...

> -----Original Message-----
> From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com]
> Sent: Friday, January 17, 2014 8:14 AM
> To: Reyna, David
> Cc: toaster@yoctoproject.org
> Subject: Re: Commit for recipe detail view ready for review
> 
> Hi David,
> 
> Thanks for pushing this: it¹s looking great :)
> 
> From a UI standpoint, the page seems to have a small layout issue that
> makes the heading and the tabs not to align properly. To fix it, the
> body
> structure should look like this:
> 
> <body>
>     <div class=³navbar navbar-static-top²></div>
>     <div class=³container-fluid²>
>         <div class=³row-fluid²>
> 	    <div class=³section²></div>
> 	    <div class=³row span11²></div>
> 	    <div class=³row span7 tabbable²></div>
> 	    <div class=³row span4 well²></div>
>         </div>
>     </div>
> </body>
> 
> You need to add the class row-fluid to the child of container-fluid,
> and
> remove the div with class row-fluid that is a sibling of the div with
> class section. That will align all content nicely.

Will do.

> Only 3 other things:
> 
> 1. Next to the layer name you are showing the blue icon that links to
> the
> layer index. We currently have an issue with this that we still don¹t
> know
> how to solve (see 5192 in Bugzilla). Can we take the icon out for the
> moment until we find the right solution?

Ok.

> 2. I am finding recipes that report no tasks in their tasks table (see
> attached image). This should not happen, and in fact when you go to the
> tasks list there are tasks for those recipes.

Hmm, I will investigate. 

I encountered empty task lists for some packages, so I added the new test and message, plus added an explicit step in my test instructions for this (step #12).

When you write "... when you go to the tasks list ...", what path did you take to get the alternate task list?

> 3. The Bugtracker value seems to have a trailing / (see attached
> image).
> So if there is no bugtracker specified for the recipe, the / shows. If
> any
> of the variables used to populate the information about the recipe is
> not
> specified in the recipe file, we simply don¹t show them. For example,
> if
> there is no bugtracker, we show only summary, description, homepage,
> section and license.

Ah, the "/" was a left over debugging marker.

But, you are also saying that for and only for "bugtracker" I should conditionally display it only if there is an actual value. I will double check the design document for any other such conditionals.

- David

> Any questions, let me know.
> 
> Cheers
> 
> Belén
> 
> 
> On 17/01/2014 02:26, "Reyna, David" <david.reyna@windriver.com> wrote:
> 
> >Hi all,
> >
> >I have pushed my commit for the recipe details page for review. There
> are
> >two separate commits for tracking purposes.
> >
> >Branch: dreyna/recipe-detail-view
> >
> >(a) Implementation of base build details page. This adds the proposed
> >base page for details pages.
> >
> >http://git.yoctoproject.org/cgit/cgit.cgi/poky-
> contrib/commit/?h=dreyna/re
> >cipe-detail-view&id=95d3ebecbbf87af3a657bb7fcd7785700fb42c6c
> >
> >(b) Implementation of recipe detail views. This adds the recipe
> details
> >page with an updated view context, plus renames and links the recipe
> >summary page.
> >
> >http://git.yoctoproject.org/cgit/cgit.cgi/poky-
> contrib/commit/?h=dreyna/re
> >cipe-detail-view&id=95d3ebecbbf87af3a657bb7fcd7785700fb42c6c
> >
> >(c) I have implemeted Alex's review comments. The test plan remains
> the
> >same as my previous submission.
> >
> >
> >Development Notes
> >=================
> >
> >* This commit uses and depends upon Ravi's 'task_color' template tag,
> as
> >discussed.
> >
> >* The recipe summary page is a placeholder to allow access to the
> recipe
> >details page. The recipe summary page will be subsequently updated to
> the
> >new design requirements in a separate commit.
> >
> >
> >Test Instructions
> >=================
> >
> >1) Create a default Yocto project (qemux86), and start the Toaster.
> >
> >  $ source poky/oe-init-build-env
> >  $ cd build
> >  $ source toaster start
> >  $ bitbake core-image-minimal
> >  $ xdg-open http://localhost:8000/
> >
> >2) Select the "core-image-minimal" build link
> >
> >3) Select the "Recipes" link in the left sidebar
> >
> >Observe that the recipes are listed in a table, and that each recipe
> name
> >is a live URL link.
> >
> >4) Click on the "busybox" recipe name link
> >
> >Observe:
> >  a) The "breadcrumbs" at the top include is in this form form, and
> that
> >all but the last entry are live links.
> >
> >	     All builds > core-image-sato atom-pc (<time>) > Recipes >
> >busybox_1.21.1-r0
> >
> >  b) The informational sidebar on the right contains information
> >pertinent to the "busybox" recipe,
> >
> >  c) Some 14 task entries, starting with "do_patch" and ending with
> >"do_build" If you hover over a recipe name, you will see a question-
> mark
> >icon appear, and if you hover over that a tooltip will appear for that
> >task.
> >
> >  d) Any task outcome of "Succeeded" should be in normal black. Any
> >outcome of "Failed" (not likely) would be red, and all other tasks
> should
> >be in grey.
> >
> >  e) The layer description will indicate the layer "meta", and the
> recipe
> >will point to "busybox_1.21.1.bb".
> >
> >  f) The right-hand sidebar about busybox is still present.
> >
> >5) Observe that "Packages" link. It should have an appended value like
> >"(4)". Now click on this link.
> >
> >Observe:
> >  a) The number of packages matches the previous number in
> parenthesis.
> >
> >  b) Each package has a version and a size. The size may be zero.
> >
> >  c) Note that if you hover on a package name, it will reveal a URL of
> >the following form. This link should take you to the corresponding
> >package detail page once you have the fix for 4328 pulled.
> >
> >	localhost:8000/gui/build/<number>/package/<number>
> >
> >6) Observe that "Build Dependencies" link. It should have an appended
> >value like "(0)". Now click on this link.
> >
> >Observe:
> >  a) No dependencies appear, and you get a message of the form:
> >
> >  "$RECIPE_NAME_VERSION has no build dependencies."
> >
> >7) Observe that "Reverse build dependencies" link. It should have an
> >appended value like "(1)". Now click on this link.
> >
> >Observe:
> >  a) The number of packages matches the previous number in
> parenthesis.
> >
> >  b) The recipe dependency should be "packagegroup-core-boot",
> >
> >  c) There should be a respective version displayed, for example "1.0-
> r11"
> >
> >  d) If you hover on the recipe name, it will reveal a URL of the
> >following form. This link should take you to the corresponding recipe
> >detail page.
> >
> >	localhost:8000/gui/build/<number>/recipe/<number>
> >
> >8) Click the breadcrumb "Recipes" at the top, locate the "gdbm"
> recipe,
> >and select it.
> >
> >9) Observe that "Packages" link. It should have an appended value like
> >"(0)". Now click on this link.
> >
> >Observe:
> >  a) No packages appear, and you get a message of the form:
> >
> >  "$PACKAGE_NAME_VERSION does not build any packages."
> >
> >10) Observe that "Build dependencies" link. It should have an appended
> >value like "(2)". Now click on this link.
> >
> >Observe:
> >  a) The number of build dependencies matches the previous number in
> >parenthesis.
> >
> >  b) The recipe dependency should have values like "gettext-native"
> and
> >"libtool-cross".
> >
> >  c) There should be a respective versions displayed for each
> dependency.
> >
> >  d) If you hover on a recipe name, it will reveal a URL of the
> following
> >form. This link should take you to the corresponding recipe detail
> page.
> >
> >	localhost:8000/gui/build/<number>/recipe/<number>
> >
> >11) Observe that "Reverse build dependencies" link. It should have an
> >appended value like "(0)". Now click on this link.
> >
> >Observe:
> >  a) No reverse dependencies appear, and you get a message of the
> form:
> >
> >  "$RECIPE_NAME_VERSION does not build any packages."
> >
> >12) Select the recipe "base-files". It my build it did not have any
> >tasks, and in this case instead of the task table you will observe the
> >message:
> >
> >  "$PACKAGE_NAME_VERSION does not have any tasks executed yet."
> >
> >13) NOTE: to simulate the "error" task entry coloring, make the
> following
> >_temporary_ change to "projecttags.py", and select a new recipe. All
> of
> >the task entries should now be highlighted in red.
> >
> >toastergui/templatetags/projecttags.py:
> >     if not task_object.task_executed:
> >+        return 'class=muted'
> >-        return 'class=error'
> >
> >
> >
> >David
> >
> >
> >
> 



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Commit for recipe detail view ready for review
  2014-01-17 18:37   ` Reyna, David
@ 2014-01-20 10:11     ` Barros Pena, Belen
  0 siblings, 0 replies; 4+ messages in thread
From: Barros Pena, Belen @ 2014-01-20 10:11 UTC (permalink / raw)
  To: Reyna, David L (Wind River); +Cc: toaster


On 17/01/2014 18:37, "Reyna, David" <david.reyna@windriver.com> wrote:

>Hi Belen,
>
>See inline...

Same :)

Let me know if you have any further questions.

>
>> -----Original Message-----
>> From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com]
>> Sent: Friday, January 17, 2014 8:14 AM
>> To: Reyna, David
>> Cc: toaster@yoctoproject.org
>> Subject: Re: Commit for recipe detail view ready for review
>> 
>> Hi David,
>> 
>> Thanks for pushing this: it¹s looking great :)
>> 
>> From a UI standpoint, the page seems to have a small layout issue that
>> makes the heading and the tabs not to align properly. To fix it, the
>> body
>> structure should look like this:
>> 
>> <body>
>>     <div class=³navbar navbar-static-top²></div>
>>     <div class=³container-fluid²>
>>         <div class=³row-fluid²>
>> 	    <div class=³section²></div>
>> 	    <div class=³row span11²></div>
>> 	    <div class=³row span7 tabbable²></div>
>> 	    <div class=³row span4 well²></div>
>>         </div>
>>     </div>
>> </body>
>> 
>> You need to add the class row-fluid to the child of container-fluid,
>> and
>> remove the div with class row-fluid that is a sibling of the div with
>> class section. That will align all content nicely.
>
>Will do.
>
>> Only 3 other things:
>> 
>> 1. Next to the layer name you are showing the blue icon that links to
>> the
>> layer index. We currently have an issue with this that we still don¹t
>> know
>> how to solve (see 5192 in Bugzilla). Can we take the icon out for the
>> moment until we find the right solution?
>
>Ok.
>
>> 2. I am finding recipes that report no tasks in their tasks table (see
>> attached image). This should not happen, and in fact when you go to the
>> tasks list there are tasks for those recipes.
>
>Hmm, I will investigate.
>
>I encountered empty task lists for some packages, so I added the new test
>and message, plus added an explicit step in my test instructions for this
>(step #12).
>
>When you write "... when you go to the tasks list ...", what path did you
>take to get the alternate task list?

I selected the Recipes link in the breadcrumb and then the Tasks link in
the left navigation.

>
>> 3. The Bugtracker value seems to have a trailing / (see attached
>> image).
>> So if there is no bugtracker specified for the recipe, the / shows. If
>> any
>> of the variables used to populate the information about the recipe is
>> not
>> specified in the recipe file, we simply don¹t show them. For example,
>> if
>> there is no bugtracker, we show only summary, description, homepage,
>> section and license.
>
>Ah, the "/" was a left over debugging marker.
>
>But, you are also saying that for and only for "bugtracker" I should
>conditionally display it only if there is an actual value. I will double
>check the design document for any other such conditionals.

Not only for bugtracker: this applies to all the information in the About
<recipe> section. If the variable does not exist in the recipe file, we
simply don't show it.

>
>- David
>
>> Any questions, let me know.
>> 
>> Cheers
>> 
>> Belén
>> 
>> 
>> On 17/01/2014 02:26, "Reyna, David" <david.reyna@windriver.com> wrote:
>> 
>> >Hi all,
>> >
>> >I have pushed my commit for the recipe details page for review. There
>> are
>> >two separate commits for tracking purposes.
>> >
>> >Branch: dreyna/recipe-detail-view
>> >
>> >(a) Implementation of base build details page. This adds the proposed
>> >base page for details pages.
>> >
>> >http://git.yoctoproject.org/cgit/cgit.cgi/poky-
>> contrib/commit/?h=dreyna/re
>> >cipe-detail-view&id=95d3ebecbbf87af3a657bb7fcd7785700fb42c6c
>> >
>> >(b) Implementation of recipe detail views. This adds the recipe
>> details
>> >page with an updated view context, plus renames and links the recipe
>> >summary page.
>> >
>> >http://git.yoctoproject.org/cgit/cgit.cgi/poky-
>> contrib/commit/?h=dreyna/re
>> >cipe-detail-view&id=95d3ebecbbf87af3a657bb7fcd7785700fb42c6c
>> >
>> >(c) I have implemeted Alex's review comments. The test plan remains
>> the
>> >same as my previous submission.
>> >
>> >
>> >Development Notes
>> >=================
>> >
>> >* This commit uses and depends upon Ravi's 'task_color' template tag,
>> as
>> >discussed.
>> >
>> >* The recipe summary page is a placeholder to allow access to the
>> recipe
>> >details page. The recipe summary page will be subsequently updated to
>> the
>> >new design requirements in a separate commit.
>> >
>> >
>> >Test Instructions
>> >=================
>> >
>> >1) Create a default Yocto project (qemux86), and start the Toaster.
>> >
>> >  $ source poky/oe-init-build-env
>> >  $ cd build
>> >  $ source toaster start
>> >  $ bitbake core-image-minimal
>> >  $ xdg-open http://localhost:8000/
>> >
>> >2) Select the "core-image-minimal" build link
>> >
>> >3) Select the "Recipes" link in the left sidebar
>> >
>> >Observe that the recipes are listed in a table, and that each recipe
>> name
>> >is a live URL link.
>> >
>> >4) Click on the "busybox" recipe name link
>> >
>> >Observe:
>> >  a) The "breadcrumbs" at the top include is in this form form, and
>> that
>> >all but the last entry are live links.
>> >
>> >	     All builds > core-image-sato atom-pc (<time>) > Recipes >
>> >busybox_1.21.1-r0
>> >
>> >  b) The informational sidebar on the right contains information
>> >pertinent to the "busybox" recipe,
>> >
>> >  c) Some 14 task entries, starting with "do_patch" and ending with
>> >"do_build" If you hover over a recipe name, you will see a question-
>> mark
>> >icon appear, and if you hover over that a tooltip will appear for that
>> >task.
>> >
>> >  d) Any task outcome of "Succeeded" should be in normal black. Any
>> >outcome of "Failed" (not likely) would be red, and all other tasks
>> should
>> >be in grey.
>> >
>> >  e) The layer description will indicate the layer "meta", and the
>> recipe
>> >will point to "busybox_1.21.1.bb".
>> >
>> >  f) The right-hand sidebar about busybox is still present.
>> >
>> >5) Observe that "Packages" link. It should have an appended value like
>> >"(4)". Now click on this link.
>> >
>> >Observe:
>> >  a) The number of packages matches the previous number in
>> parenthesis.
>> >
>> >  b) Each package has a version and a size. The size may be zero.
>> >
>> >  c) Note that if you hover on a package name, it will reveal a URL of
>> >the following form. This link should take you to the corresponding
>> >package detail page once you have the fix for 4328 pulled.
>> >
>> >	localhost:8000/gui/build/<number>/package/<number>
>> >
>> >6) Observe that "Build Dependencies" link. It should have an appended
>> >value like "(0)". Now click on this link.
>> >
>> >Observe:
>> >  a) No dependencies appear, and you get a message of the form:
>> >
>> >  "$RECIPE_NAME_VERSION has no build dependencies."
>> >
>> >7) Observe that "Reverse build dependencies" link. It should have an
>> >appended value like "(1)". Now click on this link.
>> >
>> >Observe:
>> >  a) The number of packages matches the previous number in
>> parenthesis.
>> >
>> >  b) The recipe dependency should be "packagegroup-core-boot",
>> >
>> >  c) There should be a respective version displayed, for example "1.0-
>> r11"
>> >
>> >  d) If you hover on the recipe name, it will reveal a URL of the
>> >following form. This link should take you to the corresponding recipe
>> >detail page.
>> >
>> >	localhost:8000/gui/build/<number>/recipe/<number>
>> >
>> >8) Click the breadcrumb "Recipes" at the top, locate the "gdbm"
>> recipe,
>> >and select it.
>> >
>> >9) Observe that "Packages" link. It should have an appended value like
>> >"(0)". Now click on this link.
>> >
>> >Observe:
>> >  a) No packages appear, and you get a message of the form:
>> >
>> >  "$PACKAGE_NAME_VERSION does not build any packages."
>> >
>> >10) Observe that "Build dependencies" link. It should have an appended
>> >value like "(2)". Now click on this link.
>> >
>> >Observe:
>> >  a) The number of build dependencies matches the previous number in
>> >parenthesis.
>> >
>> >  b) The recipe dependency should have values like "gettext-native"
>> and
>> >"libtool-cross".
>> >
>> >  c) There should be a respective versions displayed for each
>> dependency.
>> >
>> >  d) If you hover on a recipe name, it will reveal a URL of the
>> following
>> >form. This link should take you to the corresponding recipe detail
>> page.
>> >
>> >	localhost:8000/gui/build/<number>/recipe/<number>
>> >
>> >11) Observe that "Reverse build dependencies" link. It should have an
>> >appended value like "(0)". Now click on this link.
>> >
>> >Observe:
>> >  a) No reverse dependencies appear, and you get a message of the
>> form:
>> >
>> >  "$RECIPE_NAME_VERSION does not build any packages."
>> >
>> >12) Select the recipe "base-files". It my build it did not have any
>> >tasks, and in this case instead of the task table you will observe the
>> >message:
>> >
>> >  "$PACKAGE_NAME_VERSION does not have any tasks executed yet."
>> >
>> >13) NOTE: to simulate the "error" task entry coloring, make the
>> following
>> >_temporary_ change to "projecttags.py", and select a new recipe. All
>> of
>> >the task entries should now be highlighted in red.
>> >
>> >toastergui/templatetags/projecttags.py:
>> >     if not task_object.task_executed:
>> >+        return 'class=muted'
>> >-        return 'class=error'
>> >
>> >
>> >
>> >David
>> >
>> >
>> >
>> 
>



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-01-20 10:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-17  2:26 Commit for recipe detail view ready for review Reyna, David
2014-01-17 16:13 ` Barros Pena, Belen
2014-01-17 18:37   ` Reyna, David
2014-01-20 10:11     ` Barros Pena, Belen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.