* [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active
@ 2009-07-29 16:03 ashish kalra
2009-07-29 19:48 ` Robert Hancock
2009-09-09 1:25 ` Jeff Garzik
0 siblings, 2 replies; 11+ messages in thread
From: ashish kalra @ 2009-07-29 16:03 UTC (permalink / raw)
To: linux-ide; +Cc: linuxppc-dev
From: Ashish Kalra <Ashish.Kalra@freescale.com>
Date: Wed, 29 Jul 2009 21:15:49 +0530
Fix for non-ncq & ncq commands causing timeouts when both are issued
simultaneously to the same device.
Signed-off-by: Ashish Kalra <Ashish.Kalra@freescale.com>
---
drivers/ata/sata_fsl.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 5a88b44..a33f130 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -1262,6 +1262,7 @@ static struct scsi_host_template sata_fsl_sht = {
static struct ata_port_operations sata_fsl_ops = {
.inherits = &sata_pmp_port_ops,
+ .qc_defer = ata_std_qc_defer;
.qc_prep = sata_fsl_qc_prep,
.qc_issue = sata_fsl_qc_issue,
.qc_fill_rtf = sata_fsl_qc_fill_rtf,
--
1.6.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active
2009-07-29 16:03 [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active ashish kalra
@ 2009-07-29 19:48 ` Robert Hancock
2009-07-30 13:23 ` Kalra Ashish-B00888
2009-09-09 1:25 ` Jeff Garzik
1 sibling, 1 reply; 11+ messages in thread
From: Robert Hancock @ 2009-07-29 19:48 UTC (permalink / raw)
To: ashish kalra; +Cc: linux-ide, linuxppc-dev
On 07/29/2009 10:03 AM, ashish kalra wrote:
> From: Ashish Kalra <Ashish.Kalra@freescale.com>
> Date: Wed, 29 Jul 2009 21:15:49 +0530
>
> Fix for non-ncq & ncq commands causing timeouts when both are issued
> simultaneously to the same device.
>
> Signed-off-by: Ashish Kalra <Ashish.Kalra@freescale.com>
> ---
> drivers/ata/sata_fsl.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
> index 5a88b44..a33f130 100644
> --- a/drivers/ata/sata_fsl.c
> +++ b/drivers/ata/sata_fsl.c
> @@ -1262,6 +1262,7 @@ static struct scsi_host_template sata_fsl_sht = {
> static struct ata_port_operations sata_fsl_ops = {
> .inherits = &sata_pmp_port_ops,
>
> + .qc_defer = ata_std_qc_defer;
> .qc_prep = sata_fsl_qc_prep,
> .qc_issue = sata_fsl_qc_issue,
> .qc_fill_rtf = sata_fsl_qc_fill_rtf,
This doesn't look like it should change anything. sata_fsl_ops inherits
from sata_pmp_port_ops, which inherits from sata_port_ops, which already
sets qc_defer to ata_std_qc_defer.
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active
2009-07-29 19:48 ` Robert Hancock
@ 2009-07-30 13:23 ` Kalra Ashish-B00888
0 siblings, 0 replies; 11+ messages in thread
From: Kalra Ashish-B00888 @ 2009-07-30 13:23 UTC (permalink / raw)
To: Robert Hancock; +Cc: linux-ide, linuxppc-dev
[-- Attachment #1.1: Type: text/plain, Size: 1012 bytes --]
Hello,
>> Signed-off-by: Ashish Kalra <Ashish.Kalra@freescale.com>
>> ---
>> drivers/ata/sata_fsl.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
>> index 5a88b44..a33f130 100644
>> --- a/drivers/ata/sata_fsl.c
>> +++ b/drivers/ata/sata_fsl.c
>> @@ -1262,6 +1262,7 @@ static struct scsi_host_template sata_fsl_sht = {
>> static struct ata_port_operations sata_fsl_ops = {
>> .inherits = &sata_pmp_port_ops,
>>
>> + .qc_defer = ata_std_qc_defer;
>> .qc_prep = sata_fsl_qc_prep,
>> .qc_issue = sata_fsl_qc_issue,
>> .qc_fill_rtf = sata_fsl_qc_fill_rtf,
> This doesn't look like it should change anything. sata_fsl_ops inherits
> from sata_pmp_port_ops, which inherits from sata_port_ops, which already
> sets qc_defer to ata_std_qc_defer.
Oh, yes. Actually this patch was for older kernels where there inheritence was not there. As you mentioned, this patch is not required now.
Thanks,
Ashish
[-- Attachment #1.2: Type: text/html, Size: 1698 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active
@ 2009-07-30 13:23 ` Kalra Ashish-B00888
0 siblings, 0 replies; 11+ messages in thread
From: Kalra Ashish-B00888 @ 2009-07-30 13:23 UTC (permalink / raw)
To: Robert Hancock; +Cc: linux-ide, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
Hello,
>> Signed-off-by: Ashish Kalra <Ashish.Kalra@freescale.com>
>> ---
>> drivers/ata/sata_fsl.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
>> index 5a88b44..a33f130 100644
>> --- a/drivers/ata/sata_fsl.c
>> +++ b/drivers/ata/sata_fsl.c
>> @@ -1262,6 +1262,7 @@ static struct scsi_host_template sata_fsl_sht = {
>> static struct ata_port_operations sata_fsl_ops = {
>> .inherits = &sata_pmp_port_ops,
>>
>> + .qc_defer = ata_std_qc_defer;
>> .qc_prep = sata_fsl_qc_prep,
>> .qc_issue = sata_fsl_qc_issue,
>> .qc_fill_rtf = sata_fsl_qc_fill_rtf,
> This doesn't look like it should change anything. sata_fsl_ops inherits
> from sata_pmp_port_ops, which inherits from sata_port_ops, which already
> sets qc_defer to ata_std_qc_defer.
Oh, yes. Actually this patch was for older kernels where there inheritence was not there. As you mentioned, this patch is not required now.
Thanks,
Ashish
[-- Attachment #2: Type: text/html, Size: 1698 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active
2009-07-30 13:23 ` Kalra Ashish-B00888
@ 2009-07-30 13:43 ` Kumar Gala
-1 siblings, 0 replies; 11+ messages in thread
From: Kumar Gala @ 2009-07-30 13:43 UTC (permalink / raw)
To: Kalra Ashish-B00888; +Cc: Robert Hancock, linux-ide, linuxppc-dev
On Jul 30, 2009, at 8:23 AM, Kalra Ashish-B00888 wrote:
> Hello,
>
> >> Signed-off-by: Ashish Kalra <Ashish.Kalra@freescale.com>
> >> ---
> >> drivers/ata/sata_fsl.c | 1 +
> >> 1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
> >> index 5a88b44..a33f130 100644
> >> --- a/drivers/ata/sata_fsl.c
> >> +++ b/drivers/ata/sata_fsl.c
> >> @@ -1262,6 +1262,7 @@ static struct scsi_host_template
> sata_fsl_sht = {
> >> static struct ata_port_operations sata_fsl_ops = {
> >> .inherits = &sata_pmp_port_ops,
> >>
> >> + .qc_defer = ata_std_qc_defer;
> >> .qc_prep = sata_fsl_qc_prep,
> >> .qc_issue = sata_fsl_qc_issue,
> >> .qc_fill_rtf = sata_fsl_qc_fill_rtf,
>
> > This doesn't look like it should change anything. sata_fsl_ops
> inherits
> > from sata_pmp_port_ops, which inherits from sata_port_ops, which
> already
> > sets qc_defer to ata_std_qc_defer.
> Oh, yes. Actually this patch was for older kernels where there
> inheritence was not there. As you mentioned, this patch is not
> required now.
>
How old? Should we be asking for this to be applied to some of the
stable kernel series?
- k
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active
@ 2009-07-30 13:43 ` Kumar Gala
0 siblings, 0 replies; 11+ messages in thread
From: Kumar Gala @ 2009-07-30 13:43 UTC (permalink / raw)
To: Kalra Ashish-B00888; +Cc: linuxppc-dev, linux-ide, Robert Hancock
On Jul 30, 2009, at 8:23 AM, Kalra Ashish-B00888 wrote:
> Hello,
>
> >> Signed-off-by: Ashish Kalra <Ashish.Kalra@freescale.com>
> >> ---
> >> drivers/ata/sata_fsl.c | 1 +
> >> 1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
> >> index 5a88b44..a33f130 100644
> >> --- a/drivers/ata/sata_fsl.c
> >> +++ b/drivers/ata/sata_fsl.c
> >> @@ -1262,6 +1262,7 @@ static struct scsi_host_template
> sata_fsl_sht = {
> >> static struct ata_port_operations sata_fsl_ops = {
> >> .inherits = &sata_pmp_port_ops,
> >>
> >> + .qc_defer = ata_std_qc_defer;
> >> .qc_prep = sata_fsl_qc_prep,
> >> .qc_issue = sata_fsl_qc_issue,
> >> .qc_fill_rtf = sata_fsl_qc_fill_rtf,
>
> > This doesn't look like it should change anything. sata_fsl_ops
> inherits
> > from sata_pmp_port_ops, which inherits from sata_port_ops, which
> already
> > sets qc_defer to ata_std_qc_defer.
> Oh, yes. Actually this patch was for older kernels where there
> inheritence was not there. As you mentioned, this patch is not
> required now.
>
How old? Should we be asking for this to be applied to some of the
stable kernel series?
- k
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active
2009-07-30 13:43 ` Kumar Gala
@ 2009-07-30 13:58 ` Kalra Ashish-B00888
-1 siblings, 0 replies; 11+ messages in thread
From: Kalra Ashish-B00888 @ 2009-07-30 13:58 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, linux-ide, Robert Hancock
[-- Attachment #1.1: Type: text/plain, Size: 627 bytes --]
Hello Kumar,
>> > This doesn't look like it should change anything. sata_fsl_ops
>> inherits
>> > from sata_pmp_port_ops, which inherits from sata_port_ops, which
>> already
>> > sets qc_defer to ata_std_qc_defer.
>> Oh, yes. Actually this patch was for older kernels where there
>> inheritence was not there. As you mentioned, this patch is not
>> required now.
>>
>How old? Should we be asking for this to be applied to some of the
>stable kernel series?
I believe that the inheritence stuff was added in 2.6.26, thus, this patch is
required for quite old kernels ( < 2.6.26 ).
Thanks,
Ashish
[-- Attachment #1.2: Type: text/html, Size: 1246 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active
@ 2009-07-30 13:58 ` Kalra Ashish-B00888
0 siblings, 0 replies; 11+ messages in thread
From: Kalra Ashish-B00888 @ 2009-07-30 13:58 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, linux-ide, Robert Hancock
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
Hello Kumar,
>> > This doesn't look like it should change anything. sata_fsl_ops
>> inherits
>> > from sata_pmp_port_ops, which inherits from sata_port_ops, which
>> already
>> > sets qc_defer to ata_std_qc_defer.
>> Oh, yes. Actually this patch was for older kernels where there
>> inheritence was not there. As you mentioned, this patch is not
>> required now.
>>
>How old? Should we be asking for this to be applied to some of the
>stable kernel series?
I believe that the inheritence stuff was added in 2.6.26, thus, this patch is
required for quite old kernels ( < 2.6.26 ).
Thanks,
Ashish
[-- Attachment #2: Type: text/html, Size: 1246 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active
2009-07-30 13:58 ` Kalra Ashish-B00888
@ 2009-07-30 14:02 ` Kumar Gala
-1 siblings, 0 replies; 11+ messages in thread
From: Kumar Gala @ 2009-07-30 14:02 UTC (permalink / raw)
To: Kalra Ashish-B00888; +Cc: Robert Hancock, linux-ide, linuxppc-dev
On Jul 30, 2009, at 8:58 AM, Kalra Ashish-B00888 wrote:
> Hello Kumar,
>
> >> > This doesn't look like it should change anything. sata_fsl_ops
> >> inherits
> >> > from sata_pmp_port_ops, which inherits from sata_port_ops, which
> >> already
> >> > sets qc_defer to ata_std_qc_defer.
> >> Oh, yes. Actually this patch was for older kernels where there
> >> inheritence was not there. As you mentioned, this patch is not
> >> required now.
> >>
> >How old? Should we be asking for this to be applied to some of the
> >stable kernel series?
>
> I believe that the inheritence stuff was added in 2.6.26, thus, this
> patch is
> required for quite old kernels ( < 2.6.26 ).
Ok, than I'm not going to worry about it.
- k
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active
@ 2009-07-30 14:02 ` Kumar Gala
0 siblings, 0 replies; 11+ messages in thread
From: Kumar Gala @ 2009-07-30 14:02 UTC (permalink / raw)
To: Kalra Ashish-B00888; +Cc: linuxppc-dev, linux-ide, Robert Hancock
On Jul 30, 2009, at 8:58 AM, Kalra Ashish-B00888 wrote:
> Hello Kumar,
>
> >> > This doesn't look like it should change anything. sata_fsl_ops
> >> inherits
> >> > from sata_pmp_port_ops, which inherits from sata_port_ops, which
> >> already
> >> > sets qc_defer to ata_std_qc_defer.
> >> Oh, yes. Actually this patch was for older kernels where there
> >> inheritence was not there. As you mentioned, this patch is not
> >> required now.
> >>
> >How old? Should we be asking for this to be applied to some of the
> >stable kernel series?
>
> I believe that the inheritence stuff was added in 2.6.26, thus, this
> patch is
> required for quite old kernels ( < 2.6.26 ).
Ok, than I'm not going to worry about it.
- k
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active
2009-07-29 16:03 [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active ashish kalra
2009-07-29 19:48 ` Robert Hancock
@ 2009-09-09 1:25 ` Jeff Garzik
1 sibling, 0 replies; 11+ messages in thread
From: Jeff Garzik @ 2009-09-09 1:25 UTC (permalink / raw)
To: ashish kalra; +Cc: linux-ide, linuxppc-dev
On 07/29/2009 12:03 PM, ashish kalra wrote:
> From: Ashish Kalra <Ashish.Kalra@freescale.com>
> Date: Wed, 29 Jul 2009 21:15:49 +0530
>
> Fix for non-ncq & ncq commands causing timeouts when both are issued
> simultaneously to the same device.
>
> Signed-off-by: Ashish Kalra <Ashish.Kalra@freescale.com>
> ---
> drivers/ata/sata_fsl.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
> index 5a88b44..a33f130 100644
> --- a/drivers/ata/sata_fsl.c
> +++ b/drivers/ata/sata_fsl.c
> @@ -1262,6 +1262,7 @@ static struct scsi_host_template sata_fsl_sht = {
> static struct ata_port_operations sata_fsl_ops = {
> .inherits = &sata_pmp_port_ops,
>
> + .qc_defer = ata_std_qc_defer;
Applied version with obvious s/;/,/ fix...
Jeff
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2009-09-09 1:25 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-29 16:03 [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active ashish kalra
2009-07-29 19:48 ` Robert Hancock
2009-07-30 13:23 ` Kalra Ashish-B00888
2009-07-30 13:23 ` Kalra Ashish-B00888
2009-07-30 13:43 ` Kumar Gala
2009-07-30 13:43 ` Kumar Gala
2009-07-30 13:58 ` Kalra Ashish-B00888
2009-07-30 13:58 ` Kalra Ashish-B00888
2009-07-30 14:02 ` Kumar Gala
2009-07-30 14:02 ` Kumar Gala
2009-09-09 1:25 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.