From: "Lu, Brent" <brent.lu@intel.com> To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Takashi Iwai <tiwai@suse.de> Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, Kai Vehmanen <kai.vehmanen@linux.intel.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "yuhsuan@google.com" <yuhsuan@google.com>, Takashi Iwai <tiwai@suse.com>, Jie Yang <yang.jie@linux.intel.com>, "Rojewski, Cezary" <cezary.rojewski@intel.com>, Liam Girdwood <liam.r.girdwood@linux.intel.com>, Sam McNally <sammc@chromium.org>, "Mark Brown" <broonie@kernel.org>, Ranjani Sridharan <ranjani.sridharan@linux.intel.com>, Daniel Stuart <daniel.stuart14@gmail.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Yu-Hsuan Hsu <yuhsuan@chromium.org>, Damian van Soelen <dj.vsoelen@gmail.com> Subject: RE: [PATCH v3 2/2] ASoC: Intel: Add period size constraint on strago board Date: Thu, 6 Aug 2020 16:41:28 +0000 [thread overview] Message-ID: <DM6PR11MB364259049769F6EF3B84AABD97480@DM6PR11MB3642.namprd11.prod.outlook.com> (raw) In-Reply-To: <6466847a-8aae-24f7-d727-36ba75e95f98@linux.intel.com> > > I don't get this. If the platform driver already stated 240 and 960 samples why > would 432 be chosen? Doesn't this mean the constraint is not applied? Hi Pierre, Sorry for late reply. I used following constraints in V3 patch so any period which aligns 1ms would be accepted. + /* + * Make sure the period to be multiple of 1ms to align the + * design of firmware. Apply same rule to buffer size to make + * sure alsa could always find a value for period size + * regardless the buffer size given by user space. + */ + snd_pcm_hw_constraint_step(substream->runtime, 0, + SNDRV_PCM_HW_PARAM_PERIOD_SIZE, 48); + snd_pcm_hw_constraint_step(substream->runtime, 0, + SNDRV_PCM_HW_PARAM_BUFFER_SIZE, 48); Regards, Brent > > > [ 52.011146] sound pcmC1D0p: hw_param > > [ 52.011152] sound pcmC1D0p: ACCESS 0x1 > > [ 52.011155] sound pcmC1D0p: FORMAT 0x4 > > [ 52.011158] sound pcmC1D0p: SUBFORMAT 0x1 > > [ 52.011161] sound pcmC1D0p: SAMPLE_BITS [16:16] > > [ 52.011164] sound pcmC1D0p: FRAME_BITS [32:32] > > [ 52.011167] sound pcmC1D0p: CHANNELS [2:2] > > [ 52.011170] sound pcmC1D0p: RATE [48000:48000] > > [ 52.011173] sound pcmC1D0p: PERIOD_TIME [9000:9000] > > [ 52.011176] sound pcmC1D0p: PERIOD_SIZE [432:432] > > [ 52.011179] sound pcmC1D0p: PERIOD_BYTES [1728:1728] > > [ 52.011182] sound pcmC1D0p: PERIODS [474:474] > > [ 52.011185] sound pcmC1D0p: BUFFER_TIME [4266000:4266000] > > [ 52.011188] sound pcmC1D0p: BUFFER_SIZE [204768:204768] > > [ 52.011191] sound pcmC1D0p: BUFFER_BYTES [819072:819072] > > [ 52.011194] sound pcmC1D0p: TICK_TIME [0:0] > > > > Regards, > > Brent > > > >> > >> > >> Takashi > > > >
WARNING: multiple messages have this Message-ID (diff)
From: "Lu, Brent" <brent.lu@intel.com> To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Takashi Iwai <tiwai@suse.de> Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, Kai Vehmanen <kai.vehmanen@linux.intel.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, "Rojewski, Cezary" <cezary.rojewski@intel.com>, Takashi Iwai <tiwai@suse.com>, Jie Yang <yang.jie@linux.intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "yuhsuan@google.com" <yuhsuan@google.com>, Liam Girdwood <liam.r.girdwood@linux.intel.com>, Sam McNally <sammc@chromium.org>, Mark Brown <broonie@kernel.org>, Ranjani Sridharan <ranjani.sridharan@linux.intel.com>, Daniel Stuart <daniel.stuart14@gmail.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Yu-Hsuan Hsu <yuhsuan@chromium.org>, Damian van Soelen <dj.vsoelen@gmail.com> Subject: RE: [PATCH v3 2/2] ASoC: Intel: Add period size constraint on strago board Date: Thu, 6 Aug 2020 16:41:28 +0000 [thread overview] Message-ID: <DM6PR11MB364259049769F6EF3B84AABD97480@DM6PR11MB3642.namprd11.prod.outlook.com> (raw) In-Reply-To: <6466847a-8aae-24f7-d727-36ba75e95f98@linux.intel.com> > > I don't get this. If the platform driver already stated 240 and 960 samples why > would 432 be chosen? Doesn't this mean the constraint is not applied? Hi Pierre, Sorry for late reply. I used following constraints in V3 patch so any period which aligns 1ms would be accepted. + /* + * Make sure the period to be multiple of 1ms to align the + * design of firmware. Apply same rule to buffer size to make + * sure alsa could always find a value for period size + * regardless the buffer size given by user space. + */ + snd_pcm_hw_constraint_step(substream->runtime, 0, + SNDRV_PCM_HW_PARAM_PERIOD_SIZE, 48); + snd_pcm_hw_constraint_step(substream->runtime, 0, + SNDRV_PCM_HW_PARAM_BUFFER_SIZE, 48); Regards, Brent > > > [ 52.011146] sound pcmC1D0p: hw_param > > [ 52.011152] sound pcmC1D0p: ACCESS 0x1 > > [ 52.011155] sound pcmC1D0p: FORMAT 0x4 > > [ 52.011158] sound pcmC1D0p: SUBFORMAT 0x1 > > [ 52.011161] sound pcmC1D0p: SAMPLE_BITS [16:16] > > [ 52.011164] sound pcmC1D0p: FRAME_BITS [32:32] > > [ 52.011167] sound pcmC1D0p: CHANNELS [2:2] > > [ 52.011170] sound pcmC1D0p: RATE [48000:48000] > > [ 52.011173] sound pcmC1D0p: PERIOD_TIME [9000:9000] > > [ 52.011176] sound pcmC1D0p: PERIOD_SIZE [432:432] > > [ 52.011179] sound pcmC1D0p: PERIOD_BYTES [1728:1728] > > [ 52.011182] sound pcmC1D0p: PERIODS [474:474] > > [ 52.011185] sound pcmC1D0p: BUFFER_TIME [4266000:4266000] > > [ 52.011188] sound pcmC1D0p: BUFFER_SIZE [204768:204768] > > [ 52.011191] sound pcmC1D0p: BUFFER_BYTES [819072:819072] > > [ 52.011194] sound pcmC1D0p: TICK_TIME [0:0] > > > > Regards, > > Brent > > > >> > >> > >> Takashi > > > >
next prev parent reply other threads:[~2020-08-06 16:48 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-29 11:03 [PATCH 0/2] Add period size constraint for Atom Chromebook Brent Lu 2020-07-29 11:03 ` Brent Lu 2020-07-29 11:03 ` [PATCH 1/2] ASoC: intel: atom: Add period size constraint Brent Lu 2020-07-29 11:03 ` Brent Lu 2020-07-29 11:19 ` Andy Shevchenko 2020-07-29 11:19 ` Andy Shevchenko 2020-07-29 11:03 ` [PATCH 2/2] ASoC: Intel: Add period size constraint on strago board Brent Lu 2020-07-29 11:03 ` Brent Lu 2020-07-29 14:08 ` Pierre-Louis Bossart 2020-07-29 14:08 ` Pierre-Louis Bossart 2020-07-30 8:02 ` Lu, Brent 2020-07-30 8:02 ` Lu, Brent 2020-07-30 15:27 ` Pierre-Louis Bossart 2020-07-30 15:44 ` Pierre-Louis Bossart 2020-07-30 16:17 ` Lu, Brent 2020-07-30 16:17 ` Lu, Brent 2020-07-30 16:56 ` Takashi Iwai 2020-07-30 16:56 ` Takashi Iwai 2020-07-31 12:28 ` Lu, Brent 2020-07-31 12:28 ` Lu, Brent 2020-07-29 11:20 ` [PATCH 0/2] Add period size constraint for Atom Chromebook Andy Shevchenko 2020-07-29 11:20 ` Andy Shevchenko 2020-07-31 12:26 ` [PATCH v3 " Brent Lu 2020-07-31 12:26 ` Brent Lu 2020-07-31 12:26 ` [PATCH v3 1/2] ASoC: intel: atom: Add period size constraint Brent Lu 2020-07-31 12:26 ` Brent Lu 2020-07-31 12:26 ` [PATCH v3 2/2] ASoC: Intel: Add period size constraint on strago board Brent Lu 2020-07-31 12:26 ` Brent Lu 2020-07-31 13:34 ` Takashi Iwai 2020-07-31 13:34 ` Takashi Iwai 2020-08-01 8:58 ` Lu, Brent 2020-08-01 8:58 ` Lu, Brent 2020-08-01 9:26 ` Takashi Iwai 2020-08-01 9:26 ` Takashi Iwai 2020-08-03 13:00 ` Lu, Brent 2020-08-03 13:00 ` Lu, Brent 2020-08-03 15:13 ` Pierre-Louis Bossart 2020-08-03 15:13 ` Pierre-Louis Bossart 2020-08-03 16:45 ` Lu, Brent 2020-08-03 16:45 ` Lu, Brent 2020-08-03 16:56 ` Takashi Iwai 2020-08-03 16:56 ` Takashi Iwai 2020-08-04 4:33 ` Lu, Brent 2020-08-04 4:33 ` Lu, Brent 2020-08-04 14:24 ` Pierre-Louis Bossart 2020-08-04 14:24 ` Pierre-Louis Bossart 2020-08-06 16:41 ` Lu, Brent [this message] 2020-08-06 16:41 ` Lu, Brent 2020-08-10 15:03 ` Pierre-Louis Bossart 2020-08-10 15:03 ` Pierre-Louis Bossart 2020-08-10 17:38 ` Yu-Hsuan Hsu 2020-08-10 17:38 ` Yu-Hsuan Hsu 2020-08-11 2:16 ` Lu, Brent 2020-08-11 2:16 ` Lu, Brent 2020-08-11 2:29 ` Yu-Hsuan Hsu 2020-08-11 2:29 ` Yu-Hsuan Hsu 2020-08-11 7:43 ` Takashi Iwai 2020-08-11 7:43 ` Takashi Iwai 2020-08-11 8:25 ` Yu-Hsuan Hsu 2020-08-11 8:25 ` Yu-Hsuan Hsu 2020-08-11 8:39 ` Takashi Iwai 2020-08-11 8:39 ` Takashi Iwai 2020-08-11 9:35 ` Yu-Hsuan Hsu 2020-08-11 9:35 ` Yu-Hsuan Hsu 2020-08-11 14:53 ` Mark Brown 2020-08-11 14:53 ` Mark Brown 2020-08-11 16:54 ` Pierre-Louis Bossart 2020-08-11 16:54 ` Pierre-Louis Bossart 2020-08-11 17:22 ` Mark Brown 2020-08-11 17:22 ` Mark Brown 2020-08-12 3:09 ` Yu-Hsuan Hsu 2020-08-12 3:09 ` Yu-Hsuan Hsu 2020-08-12 6:13 ` Takashi Iwai 2020-08-12 6:13 ` Takashi Iwai 2020-08-12 6:53 ` Yu-Hsuan Hsu 2020-08-12 6:53 ` Yu-Hsuan Hsu 2020-08-12 6:58 ` Takashi Iwai 2020-08-12 6:58 ` Takashi Iwai 2020-08-12 7:43 ` Yu-Hsuan Hsu 2020-08-12 7:43 ` Yu-Hsuan Hsu 2020-08-12 7:47 ` Takashi Iwai 2020-08-12 7:47 ` Takashi Iwai 2020-08-12 14:46 ` Pierre-Louis Bossart 2020-08-12 14:46 ` Pierre-Louis Bossart 2020-08-12 14:55 ` Takashi Iwai 2020-08-12 14:55 ` Takashi Iwai 2020-08-12 15:54 ` Pierre-Louis Bossart 2020-08-12 15:54 ` Pierre-Louis Bossart 2020-08-12 16:08 ` Lu, Brent 2020-08-12 16:08 ` Lu, Brent 2020-08-12 16:38 ` Pierre-Louis Bossart 2020-08-12 16:38 ` Pierre-Louis Bossart 2020-08-13 6:24 ` Yu-Hsuan Hsu 2020-08-13 6:24 ` Yu-Hsuan Hsu 2020-08-13 7:55 ` Lu, Brent 2020-08-13 7:55 ` Lu, Brent 2020-08-13 8:36 ` Yu-Hsuan Hsu 2020-08-13 8:36 ` Yu-Hsuan Hsu 2020-08-13 8:45 ` Takashi Iwai 2020-08-13 8:45 ` Takashi Iwai 2020-08-13 12:57 ` Pierre-Louis Bossart 2020-08-13 12:57 ` Pierre-Louis Bossart 2020-08-13 17:15 ` Yu-Hsuan Hsu 2020-08-13 17:15 ` Yu-Hsuan Hsu 2020-08-21 16:40 ` [PATCH v3 0/2] Add period size constraint for Atom Chromebook Mark Brown 2020-08-21 16:40 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DM6PR11MB364259049769F6EF3B84AABD97480@DM6PR11MB3642.namprd11.prod.outlook.com \ --to=brent.lu@intel.com \ --cc=alsa-devel@alsa-project.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=broonie@kernel.org \ --cc=cezary.rojewski@intel.com \ --cc=daniel.stuart14@gmail.com \ --cc=dj.vsoelen@gmail.com \ --cc=guennadi.liakhovetski@linux.intel.com \ --cc=kai.vehmanen@linux.intel.com \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=liam.r.girdwood@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=ranjani.sridharan@linux.intel.com \ --cc=sammc@chromium.org \ --cc=tiwai@suse.com \ --cc=tiwai@suse.de \ --cc=yang.jie@linux.intel.com \ --cc=yuhsuan@chromium.org \ --cc=yuhsuan@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.