Re: [dpdk-dev] [PATCH v18 8/8] maintainers: add for dmadev

["Xia, Chenbo" <chenbo.xia@intel.com>]

Hi,

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Friday, September 3, 2021 8:59 PM
> To: fengchengwen <fengchengwen@huawei.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
> Cc: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>;
> jerinj@marvell.com; jerinjacobk@gmail.com; andrew.rybchenko@oktetlabs.ru;
> dev@dpdk.org; mb@smartsharesystems.com; nipun.gupta@nxp.com;
> hemant.agrawal@nxp.com; honnappa.nagarahalli@arm.com;
> david.marchand@redhat.com; sburla@marvell.com; pkapoor@marvell.com; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>; Walsh, Conor
> <conor.walsh@intel.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Subject: Re: [PATCH v18 8/8] maintainers: add for dmadev
> 
> Hi,
> 
> On 9/2/21 3:39 PM, fengchengwen wrote:
> > Fix in v19
> >
> > I think there many patches wait for dmadev framework upstream, so
> > could you help review unreviewd patches (like dma/skeleton and app/test)?
> 
> Thanks for all the work, it looks really promising!
> 
> > Also, we have developed the dma driver for hisilicon, and corresponding test
> > app (like examples/vhost and testpmd) is being developed.
> >
> > examples/vhost: will extend support dmadev type.
> 
> I think Sunil has posted RFC for Vhost lib and example, you might want
> to have a look to avoid duplicate work.
> 
> > testpmd: will introduces some dma control commands and the dma forwarding
> mode.
> >          the dma forwarding mode process:
> >               // 1st: call rte_eth_rx_burst
> >               // 2st: post received packet to dma, move data to another
> packet
> >               // 3st: set newcopyed rte_mbuf header
> >               // 4st: free received packet
> >               // 5st: get dma completed request and associate it rte_mbuf
> >               // 6st: send 5st's rte_mbuf to nic
> >
> > @Maxime @Chenbo @Xiaoyun Like to hear your opinion.
> 
> We might also think of adding async support to Vhost PMD, that would be
> another way to test dmadev with testpmd.

+1 for this. I would prefer support in vhost pmd so that it could be tested with
testpmd.

About the testpmd patches, if it's for testing dma device itself, usually we create a new
app (now testpmd only tests ethdev). If vhost pmd also needs some user input, just
make it a devarg. Make sense to you?

Thanks,
Chenbo

> 
> Thanks,
> Maxime
> 
> >
> > On 2021/9/2 19:51, Bruce Richardson wrote:
> >> On Thu, Sep 02, 2021 at 06:54:17PM +0800, Chengwen Feng wrote:
> >>> This patch add myself as dmadev's maintainer and update release notes.
> >>>
> >>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> ---
> >>
> >> Just in case you are doing any further revisions of this patchset, the
> >> maintainers entry, and RN entry, generally is added in the first patch, so
> >> squash this patch into patch #1.
> >> .
> >>
> >