* [Qemu-devel] [PATCH] Get sh right on OpenSolaris/SPARC
@ 2009-03-04 21:04 Palle Lyckegaard
2009-03-04 21:30 ` Stefan Weil
2009-03-04 22:08 ` Anthony Liguori
0 siblings, 2 replies; 4+ messages in thread
From: Palle Lyckegaard @ 2009-03-04 21:04 UTC (permalink / raw)
To: qemu-devel
The patch below solves a problem when building qemu on OpenSolaris/SPARC.
"feature_to_c.sh: test: argument expected"
There seemes to be a problem with how "features_to_c.sh" is started from
the makefile. On Solaris the shell in /bin/sh is not standards compliant
according to http://docs.sun.com/app/docs/doc/816-5165/sh-1?a=view
so the patch fixes the configure script so a proper sh in located in
/usr/xpg4/bin when building on OpenSolaris. Other platforms defaults to
whatever is in the path when configure is running.
Please consider this patch so qemu builds out-of-the-box for
OpenSolaris...
Best regards
Palle
------ start of patch
Index: configure
===================================================================
--- configure (revision 6657)
+++ configure (working copy)
@@ -34,6 +34,7 @@
make="make"
install="install"
strip="strip"
+shell="`which sh`"
# parse CC options first
for opt do
@@ -263,6 +264,7 @@
SunOS)
solaris="yes"
make="gmake"
+ shell="/usr/xpg4/bin/sh"
install="ginstall"
needs_libsunmath="no"
solarisrev=`uname -r | cut -f2 -d.`
@@ -1178,6 +1180,7 @@
echo "INSTALL=$install" >> $config_mak
echo "CC=$cc" >> $config_mak
echo "HOST_CC=$host_cc" >> $config_mak
+echo "SHELL=$shell" >> $config_mak
echo "AR=$ar" >> $config_mak
echo "STRIP=$strip -s -R .comment -R .note" >> $config_mak
# XXX: only use CFLAGS and LDFLAGS ?
------ end of patch
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] Get sh right on OpenSolaris/SPARC 2009-03-04 21:04 [Qemu-devel] [PATCH] Get sh right on OpenSolaris/SPARC Palle Lyckegaard @ 2009-03-04 21:30 ` Stefan Weil 2009-03-04 22:08 ` Anthony Liguori 1 sibling, 0 replies; 4+ messages in thread From: Stefan Weil @ 2009-03-04 21:30 UTC (permalink / raw) To: qemu-devel Palle Lyckegaard schrieb: > > The patch below solves a problem when building qemu on OpenSolaris/SPARC. > > "feature_to_c.sh: test: argument expected" > > There seemes to be a problem with how "features_to_c.sh" is started > from the makefile. On Solaris the shell in /bin/sh is not standards > compliant according to > http://docs.sun.com/app/docs/doc/816-5165/sh-1?a=view so the patch > fixes the configure script so a proper sh in located in /usr/xpg4/bin > when building on OpenSolaris. Other platforms defaults to whatever is > in the path when configure is running. > > Please consider this patch so qemu builds out-of-the-box for > OpenSolaris... > > Best regards > Palle > > ------ start of patch > > Index: configure > =================================================================== > --- configure (revision 6657) > +++ configure (working copy) > @@ -34,6 +34,7 @@ > make="make" > install="install" > strip="strip" > +shell="`which sh`" > > # parse CC options first > for opt do > @@ -263,6 +264,7 @@ > SunOS) > solaris="yes" > make="gmake" > + shell="/usr/xpg4/bin/sh" This shell is part of package SUNWxcu4. Is this a mandatory or optional package? If it is optional, many installations won't provide /usr/xpg4/bin/sh. Regards Stefan Weil ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Get sh right on OpenSolaris/SPARC 2009-03-04 21:04 [Qemu-devel] [PATCH] Get sh right on OpenSolaris/SPARC Palle Lyckegaard 2009-03-04 21:30 ` Stefan Weil @ 2009-03-04 22:08 ` Anthony Liguori 2009-03-17 19:37 ` Palle Lyckegaard 1 sibling, 1 reply; 4+ messages in thread From: Anthony Liguori @ 2009-03-04 22:08 UTC (permalink / raw) To: qemu-devel Palle Lyckegaard wrote: > > The patch below solves a problem when building qemu on OpenSolaris/SPARC. > > "feature_to_c.sh: test: argument expected" > > There seemes to be a problem with how "features_to_c.sh" is started > from the makefile. On Solaris the shell in /bin/sh is not standards > compliant according to > http://docs.sun.com/app/docs/doc/816-5165/sh-1?a=view so the patch > fixes the configure script so a proper sh in located in /usr/xpg4/bin > when building on OpenSolaris. Other platforms defaults to whatever is > in the path when configure is running. > > Please consider this patch so qemu builds out-of-the-box for > OpenSolaris... Why not change: test -z "$output" to test "x$output" = "x" Which I believe is a pretty common way to work around this problem. Regards, Anthony Liguori > Best regards > Palle > > ------ start of patch > > Index: configure > =================================================================== > --- configure (revision 6657) > +++ configure (working copy) > @@ -34,6 +34,7 @@ > make="make" > install="install" > strip="strip" > +shell="`which sh`" > > # parse CC options first > for opt do > @@ -263,6 +264,7 @@ > SunOS) > solaris="yes" > make="gmake" > + shell="/usr/xpg4/bin/sh" > install="ginstall" > needs_libsunmath="no" > solarisrev=`uname -r | cut -f2 -d.` > @@ -1178,6 +1180,7 @@ > echo "INSTALL=$install" >> $config_mak > echo "CC=$cc" >> $config_mak > echo "HOST_CC=$host_cc" >> $config_mak > +echo "SHELL=$shell" >> $config_mak > echo "AR=$ar" >> $config_mak > echo "STRIP=$strip -s -R .comment -R .note" >> $config_mak > # XXX: only use CFLAGS and LDFLAGS ? > > > ------ end of patch > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Get sh right on OpenSolaris/SPARC 2009-03-04 22:08 ` Anthony Liguori @ 2009-03-17 19:37 ` Palle Lyckegaard 0 siblings, 0 replies; 4+ messages in thread From: Palle Lyckegaard @ 2009-03-17 19:37 UTC (permalink / raw) To: qemu-devel On Wed, 4 Mar 2009, Anthony Liguori wrote: > Date: Wed, 04 Mar 2009 16:08:51 -0600 > From: Anthony Liguori <anthony@codemonkey.ws> > Reply-To: qemu-devel@nongnu.org > To: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH] Get sh right on OpenSolaris/SPARC > > Palle Lyckegaard wrote: >> >> The patch below solves a problem when building qemu on OpenSolaris/SPARC. >> >> "feature_to_c.sh: test: argument expected" >> >> There seemes to be a problem with how "features_to_c.sh" is started from >> the makefile. On Solaris the shell in /bin/sh is not standards compliant >> according to http://docs.sun.com/app/docs/doc/816-5165/sh-1?a=view so the >> patch fixes the configure script so a proper sh in located in /usr/xpg4/bin >> when building on OpenSolaris. Other platforms defaults to whatever is in >> the path when configure is running. >> >> Please consider this patch so qemu builds out-of-the-box for OpenSolaris... > > Why not change: > > test -z "$output" > > to > > test "x$output" = "x" > > Which I believe is a pretty common way to work around this problem. > > Regards, > > Anthony Liguori Hi, The following patch fixes the feature_to_c.sh problems encountered on Solaris. Tested on Ubuntu Linux as well... Please consider applying the patch... Regards Palle Index: feature_to_c.sh =================================================================== --- feature_to_c.sh (revision 6858) +++ feature_to_c.sh (working copy) @@ -24,17 +24,17 @@ output=$1 shift -if test -z "$output" || test -z "$1"; then +if test "x$output" = "x" || test "x$1" = "x"; then echo "Usage: $0 OUTPUTFILE INPUTFILE..." exit 1 fi -if test -e "$output"; then +if test -f "$output"; then echo "Output file \"$output\" already exists; refusing to overwrite." exit 1 fi -for input; do +for input do arrayname=xml_feature_`echo $input | sed 's,.*/,,; s/[-.]/_/g'` ${AWK:-awk} 'BEGIN { n = 0 @@ -68,7 +68,7 @@ echo "extern const char *const xml_builtin[][2];" >> $output echo "const char *const xml_builtin[][2] = {" >> $output -for input; do +for input do basename=`echo $input | sed 's,.*/,,'` arrayname=xml_feature_`echo $input | sed 's,.*/,,; s/[-.]/_/g'` echo " { \"$basename\", $arrayname }," >> $output > >> Best regards >> Palle >> >> ------ start of patch >> >> Index: configure >> =================================================================== >> --- configure (revision 6657) >> +++ configure (working copy) >> @@ -34,6 +34,7 @@ >> make="make" >> install="install" >> strip="strip" >> +shell="`which sh`" >> >> # parse CC options first >> for opt do >> @@ -263,6 +264,7 @@ >> SunOS) >> solaris="yes" >> make="gmake" >> + shell="/usr/xpg4/bin/sh" >> install="ginstall" >> needs_libsunmath="no" >> solarisrev=`uname -r | cut -f2 -d.` >> @@ -1178,6 +1180,7 @@ >> echo "INSTALL=$install" >> $config_mak >> echo "CC=$cc" >> $config_mak >> echo "HOST_CC=$host_cc" >> $config_mak >> +echo "SHELL=$shell" >> $config_mak >> echo "AR=$ar" >> $config_mak >> echo "STRIP=$strip -s -R .comment -R .note" >> $config_mak >> # XXX: only use CFLAGS and LDFLAGS ? >> >> >> ------ end of patch >> >> >> > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-03-17 19:50 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2009-03-04 21:04 [Qemu-devel] [PATCH] Get sh right on OpenSolaris/SPARC Palle Lyckegaard 2009-03-04 21:30 ` Stefan Weil 2009-03-04 22:08 ` Anthony Liguori 2009-03-17 19:37 ` Palle Lyckegaard
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.