From: Chester Lin <clin@suse.com> To: Rob Herring <robh@kernel.org> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Shawn Guo" <shawnguo@kernel.org>, "Krzysztof Kozlowski" <krzk@kernel.org>, "Oleksij Rempel" <linux@rempel-privat.de>, "Stefan Riedmueller" <s.riedmueller@phytec.de>, "Matthias Schiffer" <matthias.schiffer@ew.tq-group.com>, "Li Yang" <leoyang.li@nxp.com>, "Fabio Estevam" <festevam@gmail.com>, "Matteo Lisi" <matteo.lisi@engicam.com>, "Frieder Schrempf" <frieder.schrempf@kontron.de>, "Tim Harvey" <tharvey@gateworks.com>, "Jagan Teki" <jagan@amarulasolutions.com>, s32@nxp.com, catalin-dan.udma@nxp.com, bogdan.hamciuc@nxp.com, bogdan.folea@nxp.com, ciprianmarian.costea@nxp.com, radu-nicolae.pirea@nxp.com, ghennadi.procopciuc@nxp.com, "Matthias Brugger" <matthias.bgg@gmail.com>, "Andreas Färber" <afaerber@suse.de>, "Ivan T . Ivanov" <iivanov@suse.de>, "Lee, Chun-Yi" <jlee@suse.com> Subject: Re: [PATCH 1/8] dt-bindings: arm: fsl: add NXP S32G2 boards Date: Wed, 18 Aug 2021 22:34:57 +0800 [thread overview] Message-ID: <YR0akXYPYthDuvCh@linux-8mug> (raw) In-Reply-To: <YRaxt1LCF+hWaMJU@robh.at.kernel.org> On Fri, Aug 13, 2021 at 12:53:59PM -0500, Rob Herring wrote: > On Thu, Aug 05, 2021 at 02:54:22PM +0800, Chester Lin wrote: > > Add bindings for S32G2's evaluation board (S32G-VNP-EVB) and reference > > design 2 board ( S32G-VNP-RDB2). > > > > Signed-off-by: Chester Lin <clin@suse.com> > > --- > > Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index e2097011c4b0..3914aa09e503 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -983,6 +983,13 @@ properties: > > - const: solidrun,lx2160a-cex7 > > - const: fsl,lx2160a > > > > + - description: S32G2 based Boards > > + items: > > + - enum: > > + - fsl,s32g274a-evb > > + - fsl,s32g274a-rdb2 > > + - const: fsl,s32g2 > > Given this is an entirely different family from i.MX and new?, shouldn't > it use 'nxp' instead of 'fsl'? Either way, It sounds good and Radu from NXP has mentioned a similar idea for the compatible string of linflexuart. To keep the naming consistency, should we change all 'fsl' to 'nxp' as well? For example, we could rename the fsl.yaml to nxp.yaml. However, changing all of them would cause some impacts, which will need more verifications on new strings. Otherwise we would have to tolerate the naming differences only used by s32g2. Thanks, Chester > > Acked-by: Rob Herring <robh@kernel.org> > > Rob >
WARNING: multiple messages have this Message-ID (diff)
From: Chester Lin <clin@suse.com> To: Rob Herring <robh@kernel.org> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Shawn Guo" <shawnguo@kernel.org>, "Krzysztof Kozlowski" <krzk@kernel.org>, "Oleksij Rempel" <linux@rempel-privat.de>, "Stefan Riedmueller" <s.riedmueller@phytec.de>, "Matthias Schiffer" <matthias.schiffer@ew.tq-group.com>, "Li Yang" <leoyang.li@nxp.com>, "Fabio Estevam" <festevam@gmail.com>, "Matteo Lisi" <matteo.lisi@engicam.com>, "Frieder Schrempf" <frieder.schrempf@kontron.de>, "Tim Harvey" <tharvey@gateworks.com>, "Jagan Teki" <jagan@amarulasolutions.com>, s32@nxp.com, catalin-dan.udma@nxp.com, bogdan.hamciuc@nxp.com, bogdan.folea@nxp.com, ciprianmarian.costea@nxp.com, radu-nicolae.pirea@nxp.com, ghennadi.procopciuc@nxp.com, "Matthias Brugger" <matthias.bgg@gmail.com>, "Andreas Färber" <afaerber@suse.de>, "Ivan T . Ivanov" <iivanov@suse.de>, "Lee, Chun-Yi" <jlee@suse.com> Subject: Re: [PATCH 1/8] dt-bindings: arm: fsl: add NXP S32G2 boards Date: Wed, 18 Aug 2021 22:34:57 +0800 [thread overview] Message-ID: <YR0akXYPYthDuvCh@linux-8mug> (raw) In-Reply-To: <YRaxt1LCF+hWaMJU@robh.at.kernel.org> On Fri, Aug 13, 2021 at 12:53:59PM -0500, Rob Herring wrote: > On Thu, Aug 05, 2021 at 02:54:22PM +0800, Chester Lin wrote: > > Add bindings for S32G2's evaluation board (S32G-VNP-EVB) and reference > > design 2 board ( S32G-VNP-RDB2). > > > > Signed-off-by: Chester Lin <clin@suse.com> > > --- > > Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index e2097011c4b0..3914aa09e503 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -983,6 +983,13 @@ properties: > > - const: solidrun,lx2160a-cex7 > > - const: fsl,lx2160a > > > > + - description: S32G2 based Boards > > + items: > > + - enum: > > + - fsl,s32g274a-evb > > + - fsl,s32g274a-rdb2 > > + - const: fsl,s32g2 > > Given this is an entirely different family from i.MX and new?, shouldn't > it use 'nxp' instead of 'fsl'? Either way, It sounds good and Radu from NXP has mentioned a similar idea for the compatible string of linflexuart. To keep the naming consistency, should we change all 'fsl' to 'nxp' as well? For example, we could rename the fsl.yaml to nxp.yaml. However, changing all of them would cause some impacts, which will need more verifications on new strings. Otherwise we would have to tolerate the naming differences only used by s32g2. Thanks, Chester > > Acked-by: Rob Herring <robh@kernel.org> > > Rob > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-18 14:35 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-05 6:54 [PATCH 0/8] arm64: dts: initial NXP S32G2 support Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-05 6:54 ` [PATCH 1/8] dt-bindings: arm: fsl: add NXP S32G2 boards Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-12 15:46 ` Andreas Färber 2021-08-12 15:46 ` Andreas Färber 2021-08-13 17:49 ` Rob Herring 2021-08-13 17:49 ` Rob Herring 2021-08-13 17:53 ` Rob Herring 2021-08-13 17:53 ` Rob Herring 2021-08-18 14:34 ` Chester Lin [this message] 2021-08-18 14:34 ` Chester Lin 2021-09-06 20:38 ` Andreas Färber 2021-09-06 20:38 ` Andreas Färber 2021-09-07 6:59 ` Krzysztof Kozlowski 2021-09-07 6:59 ` Krzysztof Kozlowski 2021-09-07 8:59 ` Andreas Färber 2021-09-07 8:59 ` Andreas Färber 2021-09-06 19:35 ` Andreas Färber 2021-09-06 19:35 ` Andreas Färber 2021-08-05 6:54 ` [PATCH 2/8] dt-bindings: serial: fsl-linflexuart: convert to json-schema format Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-12 16:04 ` Andreas Färber 2021-08-12 16:04 ` Andreas Färber 2021-08-13 11:11 ` Chester Lin 2021-08-13 11:11 ` Chester Lin 2021-08-13 11:28 ` Krzysztof Kozlowski 2021-08-13 11:28 ` Krzysztof Kozlowski 2021-08-13 11:43 ` Chester Lin 2021-08-13 11:43 ` Chester Lin 2021-08-13 18:04 ` Rob Herring 2021-08-13 18:04 ` Rob Herring 2021-08-13 18:07 ` Rob Herring 2021-08-13 18:07 ` Rob Herring 2021-08-05 6:54 ` [PATCH 3/8] dt-bindings: serial: fsl-linflexuart: Add compatible for S32G2 Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-12 16:27 ` Andreas Färber 2021-08-12 16:27 ` Andreas Färber 2021-08-13 14:27 ` Radu Nicolae Pirea (NXP OSS) 2021-08-13 14:27 ` Radu Nicolae Pirea (NXP OSS) 2021-08-13 18:11 ` Rob Herring 2021-08-13 18:11 ` Rob Herring 2021-08-13 18:09 ` Rob Herring 2021-08-13 18:09 ` Rob Herring 2021-08-05 6:54 ` [PATCH 4/8] arm64: dts: add NXP S32G2 support Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-12 17:26 ` Andreas Färber 2021-08-12 17:26 ` Andreas Färber 2021-08-13 3:28 ` Chester Lin 2021-08-13 3:28 ` Chester Lin 2021-08-13 7:05 ` Andreas Färber 2021-08-13 7:05 ` Andreas Färber 2021-08-20 13:12 ` Marc Zyngier 2021-08-20 13:12 ` Marc Zyngier 2021-08-20 15:15 ` Chester Lin 2021-08-20 15:15 ` Chester Lin 2021-08-20 15:29 ` Marc Zyngier 2021-08-20 15:29 ` Marc Zyngier 2021-08-21 12:39 ` Chester Lin 2021-08-21 12:39 ` Chester Lin 2021-08-21 14:20 ` Marc Zyngier 2021-08-21 14:20 ` Marc Zyngier 2021-08-05 6:54 ` [PATCH 5/8] arm64: dts: s32g2: add serial/uart support Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-12 17:42 ` Andreas Färber 2021-08-12 17:42 ` Andreas Färber 2021-08-13 9:54 ` Radu Nicolae Pirea (NXP OSS) 2021-08-13 9:54 ` Radu Nicolae Pirea (NXP OSS) 2021-08-05 6:54 ` [PATCH 6/8] arm64: dts: s32g2: add VNP-EVB and VNP-RDB2 support Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-12 18:00 ` Andreas Färber 2021-08-12 18:00 ` Andreas Färber 2021-08-13 8:47 ` Chester Lin 2021-08-13 8:47 ` Chester Lin 2021-08-05 6:54 ` [PATCH 7/8] arm64: dts: s32g2: add memory nodes for evb and rdb2 Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-12 18:25 ` Andreas Färber 2021-08-12 18:25 ` Andreas Färber 2021-08-13 14:58 ` Chester Lin 2021-08-13 14:58 ` Chester Lin 2021-08-05 6:54 ` [PATCH 8/8] MAINTAINERS: Add an entry for NXP S32G2 boards Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-05 7:49 ` Krzysztof Kozlowski 2021-08-05 7:49 ` Krzysztof Kozlowski 2021-08-09 8:03 ` Shawn Guo 2021-08-09 8:03 ` Shawn Guo 2021-08-12 15:30 ` Andreas Färber 2021-08-12 15:30 ` Andreas Färber 2021-08-12 15:54 ` Krzysztof Kozlowski 2021-08-12 15:54 ` Krzysztof Kozlowski 2021-08-09 8:06 ` [PATCH 0/8] arm64: dts: initial NXP S32G2 support Shawn Guo 2021-08-09 8:06 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YR0akXYPYthDuvCh@linux-8mug \ --to=clin@suse.com \ --cc=afaerber@suse.de \ --cc=bogdan.folea@nxp.com \ --cc=bogdan.hamciuc@nxp.com \ --cc=catalin-dan.udma@nxp.com \ --cc=ciprianmarian.costea@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=frieder.schrempf@kontron.de \ --cc=ghennadi.procopciuc@nxp.com \ --cc=gregkh@linuxfoundation.org \ --cc=iivanov@suse.de \ --cc=jagan@amarulasolutions.com \ --cc=jlee@suse.com \ --cc=krzk@kernel.org \ --cc=leoyang.li@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux@rempel-privat.de \ --cc=matteo.lisi@engicam.com \ --cc=matthias.bgg@gmail.com \ --cc=matthias.schiffer@ew.tq-group.com \ --cc=radu-nicolae.pirea@nxp.com \ --cc=robh@kernel.org \ --cc=s.riedmueller@phytec.de \ --cc=s32@nxp.com \ --cc=shawnguo@kernel.org \ --cc=tharvey@gateworks.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.