From: Chester Lin <clin@suse.com> To: "Andreas Färber" <afaerber@suse.de> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>, Oleksij Rempel <linux@rempel-privat.de>, Stefan Riedmueller <s.riedmueller@phytec.de>, Matthias Schiffer <matthias.schiffer@ew.tq-group.com>, Li Yang <leoyang.li@nxp.com>, Fabio Estevam <festevam@gmail.com>, Matteo Lisi <matteo.lisi@engicam.com>, Frieder Schrempf <frieder.schrempf@kontron.de>, Tim Harvey <tharvey@gateworks.com>, Jagan Teki <jagan@amarulasolutions.com>, s32@nxp.com, catalin-dan.udma@nxp.com, bogdan.hamciuc@nxp.com, bogdan.folea@nxp.com, ciprianmarian.costea@nxp.com, radu-nicolae.pirea@nxp.com, ghennadi.procopciuc@nxp.com, Matthias Brugger <matthias.bgg@gmail.com>, "Ivan T . Ivanov" <iivanov@suse.de>, "Lee, Chun-Yi" <jlee@suse.com> Subject: Re: [PATCH 2/8] dt-bindings: serial: fsl-linflexuart: convert to json-schema format Date: Fri, 13 Aug 2021 19:11:04 +0800 [thread overview] Message-ID: <YRZTSJPFLFFIR+gx@linux-8mug> (raw) In-Reply-To: <1ff13837-e6ca-c476-376d-b4f80450a259@suse.de> Hi Andreas, On Thu, Aug 12, 2021 at 06:04:44PM +0200, Andreas Färber wrote: > On 05.08.21 08:54, Chester Lin wrote: > > Convert the FSL LINFlexD UART binding to json-schema. > > > > Signed-off-by: Chester Lin <clin@suse.com> > > --- > > .../bindings/serial/fsl,s32-linflexuart.txt | 22 --------- > > .../bindings/serial/fsl,s32-linflexuart.yaml | 48 +++++++++++++++++++ > > 2 files changed, 48 insertions(+), 22 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt > > create mode 100644 Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml > > Thanks for your effort, Chester. > > > diff --git a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt > > deleted file mode 100644 > > index f1bbe0826be5..000000000000 > > --- a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt > > +++ /dev/null > > @@ -1,22 +0,0 @@ > > -* Freescale LINFlexD UART > > - > > -The LINFlexD controller implements several LIN protocol versions, as well as > > -support for full-duplex UART communication through 8-bit and 9-bit frames. > > - > > -See chapter 47 ("LINFlexD") in the reference manual[1]. > > - > > -Required properties: > > -- compatible : > > - - "fsl,s32v234-linflexuart" for LINFlexD configured in UART mode, which > > - is compatible with the one integrated on S32V234 SoC > > -- reg : Address and length of the register set for the device > > -- interrupts : Should contain uart interrupt > > - > > -Example: > > -uart0: serial@40053000 { > > - compatible = "fsl,s32v234-linflexuart"; > > - reg = <0x0 0x40053000 0x0 0x1000>; > > - interrupts = <0 59 4>; > > -}; > > - > > -[1] https://www.nxp.com/webapp/Download?colCode=S32V234RM > > diff --git a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml > > new file mode 100644 > > index 000000000000..acfe34706ccb > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml > > @@ -0,0 +1,48 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > Since this is dual-licensed and BSD-2-Clause would seem compatible with > GPLv3, this could probably be s/GPL-2.0-only/GPL-2.0-or-later/ ? Not a > blocker. There's no license identifier in the original file so it's not a problem to choose "GPL-2.0-or-later". > > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/serial/fsl,s32-linflexuart.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Freescale LINFlexD UART > > + > > +description: | > > + The LINFlexD controller implements several LIN protocol versions, as well > > + as support for full-duplex UART communication through 8-bit and 9-bit > > + frames. See chapter 47 ("LINFlexD") in the reference manual > > + https://www.nxp.com/webapp/Download?colCode=S32V234RM. > > + > > +maintainers: > > + - Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > + - Rob Herring <robh@kernel.org> > > @Shawn: I assume we need both of them to ack this (or an S32V maintainer > to volunteer), since they were not named in the .txt file before? > > > + > > +allOf: > > + - $ref: "serial.yaml" > > + > > +properties: > > + compatible: > > + description: The LINFlexD controller on S32V234 SoC, which can be > > + configured in UART mode. > > + items: > > + - const: fsl,s32v234-linflexuart > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + serial@40053000 { > > + compatible = "fsl,s32v234-linflexuart"; > > + reg = <0x40053000 0x1000>; > > + interrupts = <0 59 4>; > > + }; > > Otherwise looking sane, > > Reviewed-by: Andreas Färber <afaerber@suse.de> > > Thanks, > Andreas > > -- > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer > HRB 36809 (AG Nürnberg) >
WARNING: multiple messages have this Message-ID (diff)
From: Chester Lin <clin@suse.com> To: "Andreas Färber" <afaerber@suse.de> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>, Oleksij Rempel <linux@rempel-privat.de>, Stefan Riedmueller <s.riedmueller@phytec.de>, Matthias Schiffer <matthias.schiffer@ew.tq-group.com>, Li Yang <leoyang.li@nxp.com>, Fabio Estevam <festevam@gmail.com>, Matteo Lisi <matteo.lisi@engicam.com>, Frieder Schrempf <frieder.schrempf@kontron.de>, Tim Harvey <tharvey@gateworks.com>, Jagan Teki <jagan@amarulasolutions.com>, s32@nxp.com, catalin-dan.udma@nxp.com, bogdan.hamciuc@nxp.com, bogdan.folea@nxp.com, ciprianmarian.costea@nxp.com, radu-nicolae.pirea@nxp.com, ghennadi.procopciuc@nxp.com, Matthias Brugger <matthias.bgg@gmail.com>, "Ivan T . Ivanov" <iivanov@suse.de>, "Lee, Chun-Yi" <jlee@suse.com> Subject: Re: [PATCH 2/8] dt-bindings: serial: fsl-linflexuart: convert to json-schema format Date: Fri, 13 Aug 2021 19:11:04 +0800 [thread overview] Message-ID: <YRZTSJPFLFFIR+gx@linux-8mug> (raw) In-Reply-To: <1ff13837-e6ca-c476-376d-b4f80450a259@suse.de> Hi Andreas, On Thu, Aug 12, 2021 at 06:04:44PM +0200, Andreas Färber wrote: > On 05.08.21 08:54, Chester Lin wrote: > > Convert the FSL LINFlexD UART binding to json-schema. > > > > Signed-off-by: Chester Lin <clin@suse.com> > > --- > > .../bindings/serial/fsl,s32-linflexuart.txt | 22 --------- > > .../bindings/serial/fsl,s32-linflexuart.yaml | 48 +++++++++++++++++++ > > 2 files changed, 48 insertions(+), 22 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt > > create mode 100644 Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml > > Thanks for your effort, Chester. > > > diff --git a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt > > deleted file mode 100644 > > index f1bbe0826be5..000000000000 > > --- a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt > > +++ /dev/null > > @@ -1,22 +0,0 @@ > > -* Freescale LINFlexD UART > > - > > -The LINFlexD controller implements several LIN protocol versions, as well as > > -support for full-duplex UART communication through 8-bit and 9-bit frames. > > - > > -See chapter 47 ("LINFlexD") in the reference manual[1]. > > - > > -Required properties: > > -- compatible : > > - - "fsl,s32v234-linflexuart" for LINFlexD configured in UART mode, which > > - is compatible with the one integrated on S32V234 SoC > > -- reg : Address and length of the register set for the device > > -- interrupts : Should contain uart interrupt > > - > > -Example: > > -uart0: serial@40053000 { > > - compatible = "fsl,s32v234-linflexuart"; > > - reg = <0x0 0x40053000 0x0 0x1000>; > > - interrupts = <0 59 4>; > > -}; > > - > > -[1] https://www.nxp.com/webapp/Download?colCode=S32V234RM > > diff --git a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml > > new file mode 100644 > > index 000000000000..acfe34706ccb > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml > > @@ -0,0 +1,48 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > Since this is dual-licensed and BSD-2-Clause would seem compatible with > GPLv3, this could probably be s/GPL-2.0-only/GPL-2.0-or-later/ ? Not a > blocker. There's no license identifier in the original file so it's not a problem to choose "GPL-2.0-or-later". > > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/serial/fsl,s32-linflexuart.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Freescale LINFlexD UART > > + > > +description: | > > + The LINFlexD controller implements several LIN protocol versions, as well > > + as support for full-duplex UART communication through 8-bit and 9-bit > > + frames. See chapter 47 ("LINFlexD") in the reference manual > > + https://www.nxp.com/webapp/Download?colCode=S32V234RM. > > + > > +maintainers: > > + - Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > + - Rob Herring <robh@kernel.org> > > @Shawn: I assume we need both of them to ack this (or an S32V maintainer > to volunteer), since they were not named in the .txt file before? > > > + > > +allOf: > > + - $ref: "serial.yaml" > > + > > +properties: > > + compatible: > > + description: The LINFlexD controller on S32V234 SoC, which can be > > + configured in UART mode. > > + items: > > + - const: fsl,s32v234-linflexuart > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + serial@40053000 { > > + compatible = "fsl,s32v234-linflexuart"; > > + reg = <0x40053000 0x1000>; > > + interrupts = <0 59 4>; > > + }; > > Otherwise looking sane, > > Reviewed-by: Andreas Färber <afaerber@suse.de> > > Thanks, > Andreas > > -- > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer > HRB 36809 (AG Nürnberg) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-13 11:11 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-05 6:54 [PATCH 0/8] arm64: dts: initial NXP S32G2 support Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-05 6:54 ` [PATCH 1/8] dt-bindings: arm: fsl: add NXP S32G2 boards Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-12 15:46 ` Andreas Färber 2021-08-12 15:46 ` Andreas Färber 2021-08-13 17:49 ` Rob Herring 2021-08-13 17:49 ` Rob Herring 2021-08-13 17:53 ` Rob Herring 2021-08-13 17:53 ` Rob Herring 2021-08-18 14:34 ` Chester Lin 2021-08-18 14:34 ` Chester Lin 2021-09-06 20:38 ` Andreas Färber 2021-09-06 20:38 ` Andreas Färber 2021-09-07 6:59 ` Krzysztof Kozlowski 2021-09-07 6:59 ` Krzysztof Kozlowski 2021-09-07 8:59 ` Andreas Färber 2021-09-07 8:59 ` Andreas Färber 2021-09-06 19:35 ` Andreas Färber 2021-09-06 19:35 ` Andreas Färber 2021-08-05 6:54 ` [PATCH 2/8] dt-bindings: serial: fsl-linflexuart: convert to json-schema format Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-12 16:04 ` Andreas Färber 2021-08-12 16:04 ` Andreas Färber 2021-08-13 11:11 ` Chester Lin [this message] 2021-08-13 11:11 ` Chester Lin 2021-08-13 11:28 ` Krzysztof Kozlowski 2021-08-13 11:28 ` Krzysztof Kozlowski 2021-08-13 11:43 ` Chester Lin 2021-08-13 11:43 ` Chester Lin 2021-08-13 18:04 ` Rob Herring 2021-08-13 18:04 ` Rob Herring 2021-08-13 18:07 ` Rob Herring 2021-08-13 18:07 ` Rob Herring 2021-08-05 6:54 ` [PATCH 3/8] dt-bindings: serial: fsl-linflexuart: Add compatible for S32G2 Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-12 16:27 ` Andreas Färber 2021-08-12 16:27 ` Andreas Färber 2021-08-13 14:27 ` Radu Nicolae Pirea (NXP OSS) 2021-08-13 14:27 ` Radu Nicolae Pirea (NXP OSS) 2021-08-13 18:11 ` Rob Herring 2021-08-13 18:11 ` Rob Herring 2021-08-13 18:09 ` Rob Herring 2021-08-13 18:09 ` Rob Herring 2021-08-05 6:54 ` [PATCH 4/8] arm64: dts: add NXP S32G2 support Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-12 17:26 ` Andreas Färber 2021-08-12 17:26 ` Andreas Färber 2021-08-13 3:28 ` Chester Lin 2021-08-13 3:28 ` Chester Lin 2021-08-13 7:05 ` Andreas Färber 2021-08-13 7:05 ` Andreas Färber 2021-08-20 13:12 ` Marc Zyngier 2021-08-20 13:12 ` Marc Zyngier 2021-08-20 15:15 ` Chester Lin 2021-08-20 15:15 ` Chester Lin 2021-08-20 15:29 ` Marc Zyngier 2021-08-20 15:29 ` Marc Zyngier 2021-08-21 12:39 ` Chester Lin 2021-08-21 12:39 ` Chester Lin 2021-08-21 14:20 ` Marc Zyngier 2021-08-21 14:20 ` Marc Zyngier 2021-08-05 6:54 ` [PATCH 5/8] arm64: dts: s32g2: add serial/uart support Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-12 17:42 ` Andreas Färber 2021-08-12 17:42 ` Andreas Färber 2021-08-13 9:54 ` Radu Nicolae Pirea (NXP OSS) 2021-08-13 9:54 ` Radu Nicolae Pirea (NXP OSS) 2021-08-05 6:54 ` [PATCH 6/8] arm64: dts: s32g2: add VNP-EVB and VNP-RDB2 support Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-12 18:00 ` Andreas Färber 2021-08-12 18:00 ` Andreas Färber 2021-08-13 8:47 ` Chester Lin 2021-08-13 8:47 ` Chester Lin 2021-08-05 6:54 ` [PATCH 7/8] arm64: dts: s32g2: add memory nodes for evb and rdb2 Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-12 18:25 ` Andreas Färber 2021-08-12 18:25 ` Andreas Färber 2021-08-13 14:58 ` Chester Lin 2021-08-13 14:58 ` Chester Lin 2021-08-05 6:54 ` [PATCH 8/8] MAINTAINERS: Add an entry for NXP S32G2 boards Chester Lin 2021-08-05 6:54 ` Chester Lin 2021-08-05 7:49 ` Krzysztof Kozlowski 2021-08-05 7:49 ` Krzysztof Kozlowski 2021-08-09 8:03 ` Shawn Guo 2021-08-09 8:03 ` Shawn Guo 2021-08-12 15:30 ` Andreas Färber 2021-08-12 15:30 ` Andreas Färber 2021-08-12 15:54 ` Krzysztof Kozlowski 2021-08-12 15:54 ` Krzysztof Kozlowski 2021-08-09 8:06 ` [PATCH 0/8] arm64: dts: initial NXP S32G2 support Shawn Guo 2021-08-09 8:06 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YRZTSJPFLFFIR+gx@linux-8mug \ --to=clin@suse.com \ --cc=afaerber@suse.de \ --cc=bogdan.folea@nxp.com \ --cc=bogdan.hamciuc@nxp.com \ --cc=catalin-dan.udma@nxp.com \ --cc=ciprianmarian.costea@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=frieder.schrempf@kontron.de \ --cc=ghennadi.procopciuc@nxp.com \ --cc=gregkh@linuxfoundation.org \ --cc=iivanov@suse.de \ --cc=jagan@amarulasolutions.com \ --cc=jlee@suse.com \ --cc=krzk@kernel.org \ --cc=leoyang.li@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux@rempel-privat.de \ --cc=matteo.lisi@engicam.com \ --cc=matthias.bgg@gmail.com \ --cc=matthias.schiffer@ew.tq-group.com \ --cc=radu-nicolae.pirea@nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.riedmueller@phytec.de \ --cc=s32@nxp.com \ --cc=shawnguo@kernel.org \ --cc=tharvey@gateworks.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.