From: Rob Herring <robh@kernel.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Chester Lin <clin@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
s32@nxp.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Oleksij Rempel <linux@rempel-privat.de>,
Stefan Riedmueller <s.riedmueller@phytec.de>,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Li Yang <leoyang.li@nxp.com>, Fabio Estevam <festevam@gmail.com>,
Matteo Lisi <matteo.lisi@engicam.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Tim Harvey <tharvey@gateworks.com>,
Jagan Teki <jagan@amarulasolutions.com>,
catalin-dan.udma@nxp.com, bogdan.hamciuc@nxp.com,
bogdan.folea@nxp.com, ciprianmarian.costea@nxp.com,
radu-nicolae.pirea@nxp.com, ghennadi.procopciuc@nxp.com,
Matthias Brugger <matthias.bgg@gmail.com>,
"Ivan T . Ivanov" <iivanov@suse.de>,
"Lee, Chun-Yi" <jlee@suse.com>
Subject: Re: [PATCH 3/8] dt-bindings: serial: fsl-linflexuart: Add compatible for S32G2
Date: Fri, 13 Aug 2021 13:11:13 -0500 [thread overview]
Message-ID: <YRa1wUW0Dp4GhZYx@robh.at.kernel.org> (raw)
In-Reply-To: <96c02ee6-cd3a-59df-0b3b-1632bb355019@suse.de>
On Thu, Aug 12, 2021 at 06:27:57PM +0200, Andreas Färber wrote:
> On 05.08.21 08:54, Chester Lin wrote:
> > Add a compatible string for the uart binding of NXP S32G2 platforms. Here
> > we use "s32v234-linflexuart" as fallback since the current linflexuart
> > driver still works on S32G2.
> >
> > Signed-off-by: Chester Lin <clin@suse.com>
> > ---
> > .../bindings/serial/fsl,s32-linflexuart.yaml | 26 ++++++++++++++++---
> > 1 file changed, 22 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml
> > index acfe34706ccb..e731f3f6cea4 100644
> > --- a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml
> > @@ -21,10 +21,20 @@ allOf:
> >
> > properties:
> > compatible:
> > - description: The LINFlexD controller on S32V234 SoC, which can be
> > - configured in UART mode.
> > - items:
> > - - const: fsl,s32v234-linflexuart
> > + minItems: 1
> > + maxItems: 2
>
> Are these necessary for oneOf?
>
> > + oneOf:
> > + - description: The LINFlexD controller on S32G2 SoC, which can be
> > + configured in UART mode.
> > + items:
> > + - enum:
> > + - fsl,s32g2-linflexuart
> > + - const: fsl,s32v234-linflexuart
>
> This reads inconsistent to me: Either this oneOf is for S32G2 only, then
> please turn the enum into a const. Or change the description to "on SoCs
> compatible with S32V234" if we expect the enum list to grow.
>
> I believe the idea here was to avoid unnecessary driver compatible and
> earlycon compatible additions, while preparing for eventual quirks
> specific to S32G2.
>
> @NXP: Should this be s32g2- like above or s32g274a- specifically? Do you
> agree this is a useful thing to prepare here, as opposed to using only
> s32v234- in the s32g2* DT?
>
> I assume the ordering is done alphabetically as S32G < S32V;
> alternatively we might order S32V234 first and then the compatible ones.
>
> > +
> > + - description: The LINFlexD controller on S32V234 SoC, which can be
> > + configured in UART mode.
> > + items:
> > + - const: fsl,s32v234-linflexuart
>
> To minimize this S32G2 patch, would it be valid to do oneOf for the
> single S32V in the preceding patch already? Then we would avoid the text
> movement and re-indentation above and more easily see the lines newly
> getting added for S32G2.
>
> >
> > reg:
> > maxItems: 1
> > @@ -41,8 +51,16 @@ unevaluatedProperties: false
> >
> > examples:
> > - |
> > + /* S32V234 */
>
> Could this be:
> - description: S32V234
> |
> ?
No, that would not be valid json-schema.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Chester Lin <clin@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
s32@nxp.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Oleksij Rempel <linux@rempel-privat.de>,
Stefan Riedmueller <s.riedmueller@phytec.de>,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Li Yang <leoyang.li@nxp.com>, Fabio Estevam <festevam@gmail.com>,
Matteo Lisi <matteo.lisi@engicam.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Tim Harvey <tharvey@gateworks.com>,
Jagan Teki <jagan@amarulasolutions.com>,
catalin-dan.udma@nxp.com, bogdan.hamciuc@nxp.com,
bogdan.folea@nxp.com, ciprianmarian.costea@nxp.com,
radu-nicolae.pirea@nxp.com, ghennadi.procopciuc@nxp.com,
Matthias Brugger <matthias.bgg@gmail.com>,
"Ivan T . Ivanov" <iivanov@suse.de>,
"Lee, Chun-Yi" <jlee@suse.com>
Subject: Re: [PATCH 3/8] dt-bindings: serial: fsl-linflexuart: Add compatible for S32G2
Date: Fri, 13 Aug 2021 13:11:13 -0500 [thread overview]
Message-ID: <YRa1wUW0Dp4GhZYx@robh.at.kernel.org> (raw)
In-Reply-To: <96c02ee6-cd3a-59df-0b3b-1632bb355019@suse.de>
On Thu, Aug 12, 2021 at 06:27:57PM +0200, Andreas Färber wrote:
> On 05.08.21 08:54, Chester Lin wrote:
> > Add a compatible string for the uart binding of NXP S32G2 platforms. Here
> > we use "s32v234-linflexuart" as fallback since the current linflexuart
> > driver still works on S32G2.
> >
> > Signed-off-by: Chester Lin <clin@suse.com>
> > ---
> > .../bindings/serial/fsl,s32-linflexuart.yaml | 26 ++++++++++++++++---
> > 1 file changed, 22 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml
> > index acfe34706ccb..e731f3f6cea4 100644
> > --- a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml
> > @@ -21,10 +21,20 @@ allOf:
> >
> > properties:
> > compatible:
> > - description: The LINFlexD controller on S32V234 SoC, which can be
> > - configured in UART mode.
> > - items:
> > - - const: fsl,s32v234-linflexuart
> > + minItems: 1
> > + maxItems: 2
>
> Are these necessary for oneOf?
>
> > + oneOf:
> > + - description: The LINFlexD controller on S32G2 SoC, which can be
> > + configured in UART mode.
> > + items:
> > + - enum:
> > + - fsl,s32g2-linflexuart
> > + - const: fsl,s32v234-linflexuart
>
> This reads inconsistent to me: Either this oneOf is for S32G2 only, then
> please turn the enum into a const. Or change the description to "on SoCs
> compatible with S32V234" if we expect the enum list to grow.
>
> I believe the idea here was to avoid unnecessary driver compatible and
> earlycon compatible additions, while preparing for eventual quirks
> specific to S32G2.
>
> @NXP: Should this be s32g2- like above or s32g274a- specifically? Do you
> agree this is a useful thing to prepare here, as opposed to using only
> s32v234- in the s32g2* DT?
>
> I assume the ordering is done alphabetically as S32G < S32V;
> alternatively we might order S32V234 first and then the compatible ones.
>
> > +
> > + - description: The LINFlexD controller on S32V234 SoC, which can be
> > + configured in UART mode.
> > + items:
> > + - const: fsl,s32v234-linflexuart
>
> To minimize this S32G2 patch, would it be valid to do oneOf for the
> single S32V in the preceding patch already? Then we would avoid the text
> movement and re-indentation above and more easily see the lines newly
> getting added for S32G2.
>
> >
> > reg:
> > maxItems: 1
> > @@ -41,8 +51,16 @@ unevaluatedProperties: false
> >
> > examples:
> > - |
> > + /* S32V234 */
>
> Could this be:
> - description: S32V234
> |
> ?
No, that would not be valid json-schema.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-13 18:11 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 6:54 [PATCH 0/8] arm64: dts: initial NXP S32G2 support Chester Lin
2021-08-05 6:54 ` Chester Lin
2021-08-05 6:54 ` [PATCH 1/8] dt-bindings: arm: fsl: add NXP S32G2 boards Chester Lin
2021-08-05 6:54 ` Chester Lin
2021-08-12 15:46 ` Andreas Färber
2021-08-12 15:46 ` Andreas Färber
2021-08-13 17:49 ` Rob Herring
2021-08-13 17:49 ` Rob Herring
2021-08-13 17:53 ` Rob Herring
2021-08-13 17:53 ` Rob Herring
2021-08-18 14:34 ` Chester Lin
2021-08-18 14:34 ` Chester Lin
2021-09-06 20:38 ` Andreas Färber
2021-09-06 20:38 ` Andreas Färber
2021-09-07 6:59 ` Krzysztof Kozlowski
2021-09-07 6:59 ` Krzysztof Kozlowski
2021-09-07 8:59 ` Andreas Färber
2021-09-07 8:59 ` Andreas Färber
2021-09-06 19:35 ` Andreas Färber
2021-09-06 19:35 ` Andreas Färber
2021-08-05 6:54 ` [PATCH 2/8] dt-bindings: serial: fsl-linflexuart: convert to json-schema format Chester Lin
2021-08-05 6:54 ` Chester Lin
2021-08-12 16:04 ` Andreas Färber
2021-08-12 16:04 ` Andreas Färber
2021-08-13 11:11 ` Chester Lin
2021-08-13 11:11 ` Chester Lin
2021-08-13 11:28 ` Krzysztof Kozlowski
2021-08-13 11:28 ` Krzysztof Kozlowski
2021-08-13 11:43 ` Chester Lin
2021-08-13 11:43 ` Chester Lin
2021-08-13 18:04 ` Rob Herring
2021-08-13 18:04 ` Rob Herring
2021-08-13 18:07 ` Rob Herring
2021-08-13 18:07 ` Rob Herring
2021-08-05 6:54 ` [PATCH 3/8] dt-bindings: serial: fsl-linflexuart: Add compatible for S32G2 Chester Lin
2021-08-05 6:54 ` Chester Lin
2021-08-12 16:27 ` Andreas Färber
2021-08-12 16:27 ` Andreas Färber
2021-08-13 14:27 ` Radu Nicolae Pirea (NXP OSS)
2021-08-13 14:27 ` Radu Nicolae Pirea (NXP OSS)
2021-08-13 18:11 ` Rob Herring [this message]
2021-08-13 18:11 ` Rob Herring
2021-08-13 18:09 ` Rob Herring
2021-08-13 18:09 ` Rob Herring
2021-08-05 6:54 ` [PATCH 4/8] arm64: dts: add NXP S32G2 support Chester Lin
2021-08-05 6:54 ` Chester Lin
2021-08-12 17:26 ` Andreas Färber
2021-08-12 17:26 ` Andreas Färber
2021-08-13 3:28 ` Chester Lin
2021-08-13 3:28 ` Chester Lin
2021-08-13 7:05 ` Andreas Färber
2021-08-13 7:05 ` Andreas Färber
2021-08-20 13:12 ` Marc Zyngier
2021-08-20 13:12 ` Marc Zyngier
2021-08-20 15:15 ` Chester Lin
2021-08-20 15:15 ` Chester Lin
2021-08-20 15:29 ` Marc Zyngier
2021-08-20 15:29 ` Marc Zyngier
2021-08-21 12:39 ` Chester Lin
2021-08-21 12:39 ` Chester Lin
2021-08-21 14:20 ` Marc Zyngier
2021-08-21 14:20 ` Marc Zyngier
2021-08-05 6:54 ` [PATCH 5/8] arm64: dts: s32g2: add serial/uart support Chester Lin
2021-08-05 6:54 ` Chester Lin
2021-08-12 17:42 ` Andreas Färber
2021-08-12 17:42 ` Andreas Färber
2021-08-13 9:54 ` Radu Nicolae Pirea (NXP OSS)
2021-08-13 9:54 ` Radu Nicolae Pirea (NXP OSS)
2021-08-05 6:54 ` [PATCH 6/8] arm64: dts: s32g2: add VNP-EVB and VNP-RDB2 support Chester Lin
2021-08-05 6:54 ` Chester Lin
2021-08-12 18:00 ` Andreas Färber
2021-08-12 18:00 ` Andreas Färber
2021-08-13 8:47 ` Chester Lin
2021-08-13 8:47 ` Chester Lin
2021-08-05 6:54 ` [PATCH 7/8] arm64: dts: s32g2: add memory nodes for evb and rdb2 Chester Lin
2021-08-05 6:54 ` Chester Lin
2021-08-12 18:25 ` Andreas Färber
2021-08-12 18:25 ` Andreas Färber
2021-08-13 14:58 ` Chester Lin
2021-08-13 14:58 ` Chester Lin
2021-08-05 6:54 ` [PATCH 8/8] MAINTAINERS: Add an entry for NXP S32G2 boards Chester Lin
2021-08-05 6:54 ` Chester Lin
2021-08-05 7:49 ` Krzysztof Kozlowski
2021-08-05 7:49 ` Krzysztof Kozlowski
2021-08-09 8:03 ` Shawn Guo
2021-08-09 8:03 ` Shawn Guo
2021-08-12 15:30 ` Andreas Färber
2021-08-12 15:30 ` Andreas Färber
2021-08-12 15:54 ` Krzysztof Kozlowski
2021-08-12 15:54 ` Krzysztof Kozlowski
2021-08-09 8:06 ` [PATCH 0/8] arm64: dts: initial NXP S32G2 support Shawn Guo
2021-08-09 8:06 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRa1wUW0Dp4GhZYx@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=afaerber@suse.de \
--cc=bogdan.folea@nxp.com \
--cc=bogdan.hamciuc@nxp.com \
--cc=catalin-dan.udma@nxp.com \
--cc=ciprianmarian.costea@nxp.com \
--cc=clin@suse.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=ghennadi.procopciuc@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=iivanov@suse.de \
--cc=jagan@amarulasolutions.com \
--cc=jlee@suse.com \
--cc=krzk@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=matteo.lisi@engicam.com \
--cc=matthias.bgg@gmail.com \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=radu-nicolae.pirea@nxp.com \
--cc=s.riedmueller@phytec.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.