All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Laurent Dufour <ldufour@linux.ibm.com>,
	akpm@linux-foundation.org, Oscar Salvador <osalvador@suse.de>,
	mhocko@kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-mm@kvack.org, "Rafael J . Wysocki" <rafael@kernel.org>,
	nathanl@linux.ibm.com, cheloha@linux.ibm.com,
	Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm: replace memmap_context by memplug_context
Date: Fri, 11 Sep 2020 19:34:25 +0200	[thread overview]
Message-ID: <a987f876-9d59-f998-b8ab-5f6b79b35ffb@redhat.com> (raw)
In-Reply-To: <6552ef9a-ac02-e79f-2eb6-08380ba4b478@linux.ibm.com>

On 11.09.20 18:23, Laurent Dufour wrote:
> Le 11/09/2020 à 16:59, David Hildenbrand a écrit :
>>>   		struct page *start;
>>>   		struct memmap_init_callback_data args;
>>> diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
>>> index 375515803cd8..cd2bd21d3a4d 100644
>>> --- a/include/linux/memory_hotplug.h
>>> +++ b/include/linux/memory_hotplug.h
>>> @@ -15,6 +15,15 @@ struct memory_block;
>>>   struct resource;
>>>   struct vmem_altmap;
>>>   
>>> +/*
>>> + * Memory plugin context, use to differentiate memory added at boot time and
>>
>> "Memory plugin context" sounds weird.
> 
> Any suggestion ?
> 

I'm not a native speaker, but "plugin" sounds weird in this context.
Maybe simply drop it and start right away with "Differentiate memory
added ..."

-- 
Thanks,

David / dhildenb


WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: Laurent Dufour <ldufour@linux.ibm.com>,
	akpm@linux-foundation.org, Oscar Salvador <osalvador@suse.de>,
	mhocko@kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-mm@kvack.org, "Rafael J . Wysocki" <rafael@kernel.org>,
	nathanl@linux.ibm.com, cheloha@linux.ibm.com,
	Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm: replace memmap_context by memplug_context
Date: Fri, 11 Sep 2020 17:34:25 +0000	[thread overview]
Message-ID: <a987f876-9d59-f998-b8ab-5f6b79b35ffb@redhat.com> (raw)
In-Reply-To: <6552ef9a-ac02-e79f-2eb6-08380ba4b478@linux.ibm.com>

On 11.09.20 18:23, Laurent Dufour wrote:
> Le 11/09/2020 à 16:59, David Hildenbrand a écrit :
>>>   		struct page *start;
>>>   		struct memmap_init_callback_data args;
>>> diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
>>> index 375515803cd8..cd2bd21d3a4d 100644
>>> --- a/include/linux/memory_hotplug.h
>>> +++ b/include/linux/memory_hotplug.h
>>> @@ -15,6 +15,15 @@ struct memory_block;
>>>   struct resource;
>>>   struct vmem_altmap;
>>>   
>>> +/*
>>> + * Memory plugin context, use to differentiate memory added at boot time and
>>
>> "Memory plugin context" sounds weird.
> 
> Any suggestion ?
> 

I'm not a native speaker, but "plugin" sounds weird in this context.
Maybe simply drop it and start right away with "Differentiate memory
added ..."

-- 
Thanks,

David / dhildenb

  reply	other threads:[~2020-09-11 17:34 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11 13:48 mm: fix memory to node bad links in sysfs Laurent Dufour
2020-09-11 13:48 ` Laurent Dufour
2020-09-11 13:48 ` [PATCH 1/3] mm: replace memmap_context by memplug_context Laurent Dufour
2020-09-11 13:48   ` Laurent Dufour
2020-09-11 14:59   ` David Hildenbrand
2020-09-11 14:59     ` David Hildenbrand
2020-09-11 16:23     ` Laurent Dufour
2020-09-11 16:23       ` Laurent Dufour
2020-09-11 17:34       ` David Hildenbrand [this message]
2020-09-11 17:34         ` David Hildenbrand
2020-09-14  8:49   ` Michal Hocko
2020-09-14  8:49     ` Michal Hocko
2020-09-14  8:51     ` Laurent Dufour
2020-09-14  8:51       ` Laurent Dufour
2020-09-14  8:59       ` Michal Hocko
2020-09-14  8:59         ` Michal Hocko
2020-09-11 13:48 ` [PATCH 2/3] mm: don't rely on system state to detect hot-plug operations Laurent Dufour
2020-09-11 13:48   ` Laurent Dufour
2020-09-14  7:57   ` David Hildenbrand
2020-09-14  7:57     ` David Hildenbrand
2020-09-14  8:05     ` Laurent Dufour
2020-09-14  8:05       ` Laurent Dufour
2020-09-14  8:19     ` Oscar Salvador
2020-09-14  8:19       ` Oscar Salvador
2020-09-14  8:31       ` David Hildenbrand
2020-09-14  8:31         ` David Hildenbrand
2020-09-14  9:16         ` Laurent Dufour
2020-09-14  9:16           ` Laurent Dufour
2020-09-14  9:19           ` David Hildenbrand
2020-09-14  9:19             ` David Hildenbrand
2020-09-14  8:39       ` Laurent Dufour
2020-09-14  8:39         ` Laurent Dufour
2020-09-14  8:55   ` Michal Hocko
2020-09-14  8:55     ` Michal Hocko
2020-09-11 13:48 ` [PATCH 3/3] mm: don't panic when links can't be created in sysfs Laurent Dufour
2020-09-11 13:48   ` Laurent Dufour
2020-09-11 14:01   ` Greg Kroah-Hartman
2020-09-11 14:01     ` Greg Kroah-Hartman
2020-09-11 16:27     ` Laurent Dufour
2020-09-11 16:27       ` Laurent Dufour
2020-09-14  8:59   ` Michal Hocko
2020-09-14  8:59     ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a987f876-9d59-f998-b8ab-5f6b79b35ffb@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cheloha@linux.ibm.com \
    --cc=fenghua.yu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ldufour@linux.ibm.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=nathanl@linux.ibm.com \
    --cc=osalvador@suse.de \
    --cc=rafael@kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.