* [PATCH] tools/libxl: Disable useless empty floppy drive with qemu-xen
@ 2013-02-05 16:15 Fabio Fantoni
2013-02-05 16:21 ` Ian Campbell
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabio Fantoni @ 2013-02-05 16:15 UTC (permalink / raw)
To: xen-devel, Stefano.Stabellini, Ian.Campbell
tools/libxl: Disable useless empty floppy drive with
qemu-xen
Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
---
tools/libxl/libxl_dm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index 51f9914..c265618 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -406,6 +406,9 @@ static char **
libxl__build_device_model_args_new(libxl__gc *gc,
if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
int ioemu_nics = 0;
+ /* Disable useless empty floppy drive */
+ flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL);
+
if (b_info->u.hvm.serial) {
flexarray_vappend(dm_args, "-serial",
b_info->u.hvm.serial, NULL);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] tools/libxl: Disable useless empty floppy drive with qemu-xen
2013-02-05 16:15 [PATCH] tools/libxl: Disable useless empty floppy drive with qemu-xen Fabio Fantoni
@ 2013-02-05 16:21 ` Ian Campbell
2013-02-08 12:39 ` Stefano Stabellini
2013-02-15 12:18 ` Ian Campbell
2 siblings, 0 replies; 5+ messages in thread
From: Ian Campbell @ 2013-02-05 16:21 UTC (permalink / raw)
To: Fabio Fantoni; +Cc: xen-devel, Stefano Stabellini
On Tue, 2013-02-05 at 16:15 +0000, Fabio Fantoni wrote:
> tools/libxl: Disable useless empty floppy drive with
> qemu-xen
We used to get occasional requests to enable the floppy disk image to be
selected, but perhaps that need has passed (was something to do with
Windows sysprep IIRC).
Unfortunately the patch is whitespace damaged. 'git send-email' is your
friend...
> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
> ---
> tools/libxl/libxl_dm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 51f9914..c265618 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -406,6 +406,9 @@ static char **
> libxl__build_device_model_args_new(libxl__gc *gc,
> if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
> int ioemu_nics = 0;
>
> + /* Disable useless empty floppy drive */
> + flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL);
> +
> if (b_info->u.hvm.serial) {
> flexarray_vappend(dm_args, "-serial",
> b_info->u.hvm.serial, NULL);
> }
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tools/libxl: Disable useless empty floppy drive with qemu-xen
2013-02-05 16:15 [PATCH] tools/libxl: Disable useless empty floppy drive with qemu-xen Fabio Fantoni
2013-02-05 16:21 ` Ian Campbell
@ 2013-02-08 12:39 ` Stefano Stabellini
2013-02-15 12:18 ` Ian Campbell
2 siblings, 0 replies; 5+ messages in thread
From: Stefano Stabellini @ 2013-02-08 12:39 UTC (permalink / raw)
To: Fabio Fantoni; +Cc: xen-devel, Ian Campbell, Stefano Stabellini
On Tue, 5 Feb 2013, Fabio Fantoni wrote:
> tools/libxl: Disable useless empty floppy drive with
> qemu-xen
>
> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> tools/libxl/libxl_dm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 51f9914..c265618 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -406,6 +406,9 @@ static char **
> libxl__build_device_model_args_new(libxl__gc *gc,
> if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
> int ioemu_nics = 0;
>
> + /* Disable useless empty floppy drive */
> + flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL);
> +
> if (b_info->u.hvm.serial) {
> flexarray_vappend(dm_args, "-serial",
> b_info->u.hvm.serial, NULL);
> }
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tools/libxl: Disable useless empty floppy drive with qemu-xen
2013-02-05 16:15 [PATCH] tools/libxl: Disable useless empty floppy drive with qemu-xen Fabio Fantoni
2013-02-05 16:21 ` Ian Campbell
2013-02-08 12:39 ` Stefano Stabellini
@ 2013-02-15 12:18 ` Ian Campbell
2013-02-15 13:14 ` Fabio Fantoni
2 siblings, 1 reply; 5+ messages in thread
From: Ian Campbell @ 2013-02-15 12:18 UTC (permalink / raw)
To: Fabio Fantoni; +Cc: xen-devel, Stefano Stabellini
On Tue, 2013-02-05 at 16:15 +0000, Fabio Fantoni wrote:
> tools/libxl: Disable useless empty floppy drive with
> qemu-xen
>
> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
> ---
> tools/libxl/libxl_dm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 51f9914..c265618 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -406,6 +406,9 @@ static char **
> libxl__build_device_model_args_new(libxl__gc *gc,
> if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
> int ioemu_nics = 0;
>
> + /* Disable useless empty floppy drive */
> + flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL);
> +
> if (b_info->u.hvm.serial) {
> flexarray_vappend(dm_args, "-serial",
> b_info->u.hvm.serial, NULL);
I'm afraid this patch is whitespace corrupted.
I strongly recommend that you investigate the use of git send-email.
Ian.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tools/libxl: Disable useless empty floppy drive with qemu-xen
2013-02-15 12:18 ` Ian Campbell
@ 2013-02-15 13:14 ` Fabio Fantoni
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Fantoni @ 2013-02-15 13:14 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel, Stefano Stabellini
Il 15/02/2013 13:18, Ian Campbell ha scritto:
> On Tue, 2013-02-05 at 16:15 +0000, Fabio Fantoni wrote:
>> tools/libxl: Disable useless empty floppy drive with
>> qemu-xen
>>
>> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
>> ---
>> tools/libxl/libxl_dm.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
>> index 51f9914..c265618 100644
>> --- a/tools/libxl/libxl_dm.c
>> +++ b/tools/libxl/libxl_dm.c
>> @@ -406,6 +406,9 @@ static char **
>> libxl__build_device_model_args_new(libxl__gc *gc,
>> if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
>> int ioemu_nics = 0;
>>
>> + /* Disable useless empty floppy drive */
>> + flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL);
>> +
>> if (b_info->u.hvm.serial) {
>> flexarray_vappend(dm_args, "-serial",
>> b_info->u.hvm.serial, NULL);
> I'm afraid this patch is whitespace corrupted.
>
> I strongly recommend that you investigate the use of git send-email.
>
> Ian.
>
I already resent with git send-email:
http://lists.xen.org/archives/html/xen-devel/2013-02/msg00391.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-02-15 13:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-05 16:15 [PATCH] tools/libxl: Disable useless empty floppy drive with qemu-xen Fabio Fantoni
2013-02-05 16:21 ` Ian Campbell
2013-02-08 12:39 ` Stefano Stabellini
2013-02-15 12:18 ` Ian Campbell
2013-02-15 13:14 ` Fabio Fantoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.