All of lore.kernel.org
 help / color / mirror / Atom feed
From: atull <atull@opensource.altera.com>
To: "Chen, Alvin" <alvin.chen@intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Ong, Boon Leong" <boon.leong.ong@intel.com>,
	"Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
	Darren Hart <dvhart@linux.intel.com>,
	Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
	"Westerberg, Mika" <mika.westerberg@intel.com>,
	"Shevchenko, Andriy" <andriy.shevchenko@intel.com>,
	Arnd Bergmann <arnd@arndb.de>
Subject: RE: [PATCH 4/4 v3] GPIO: gpio-dwapb: Suspend & Resume PM enabling
Date: Fri, 12 Sep 2014 10:46:54 -0500	[thread overview]
Message-ID: <alpine.DEB.2.02.1409121045070.373@atx-linux-37> (raw)
In-Reply-To: <4656BEB6164FC34F8171C6538F1A595B2E990CFF@SHSMSX101.ccr.corp.intel.com>

On Fri, 12 Sep 2014, Chen, Alvin wrote:

> > On Tue, 9 Sep 2014, Weike Chen wrote:
> > 
> > >
> > >  struct dwapb_gpio;
> > > +struct dwapb_context;
> > >
> > >  struct dwapb_gpio_port {
> > >  	struct bgpio_chip	bgc;
> > >  	bool			is_registered;
> > >  	struct dwapb_gpio	*gpio;
> > > +	struct dwapb_context	*ctx;
> > 
> > Alvin,
> > 
> > Will this build if CONFIG_PM_SLEEP is not defined?
> Actually, PM_SLEEP is always set as 'y' in 'kerne/power/Kconfig'. But I manually change it to 'n', this module can be compiled correctly.
> You may be concern with 'ctx', and you can see 'ctx' accessing is always in CONFIG_PM_SLEEP.

Yes and in the case of 'struct dwapb_context *ctx;' it is ok for struct 
dwapb_context to be an incomplete type since that's just a pointer.

Alan 

      reply	other threads:[~2014-09-12 15:46 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09 18:07 [PATCH 0/4 v3] The Designware GPIO Supporting Weike Chen
2014-09-09 18:07 ` Weike Chen
2014-09-09 18:07 ` [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Weike Chen
2014-09-09 17:05   ` Darren Hart
2014-09-09 17:05     ` Darren Hart
2014-09-10  0:34     ` Chen, Alvin
2014-09-10  0:34       ` Chen, Alvin
2014-09-10  3:26       ` Darren Hart
2014-09-10 10:32         ` Chen, Alvin
2014-09-10 10:32           ` Chen, Alvin
2014-09-10 19:11   ` atull
2014-09-10 19:11     ` atull
2014-09-11  0:32     ` Chen, Alvin
2014-09-11  0:46     ` Chen, Alvin
2014-09-11 15:40       ` atull
2014-09-11  7:59     ` Shevchenko, Andriy
2014-09-11  7:59       ` Shevchenko, Andriy
     [not found]       ` <1410422381.7023.15.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-11 15:26         ` atull
2014-09-11 15:26           ` atull
2014-09-15  1:18           ` Chen, Alvin
2014-09-15  1:18             ` Chen, Alvin
2014-09-16  1:07             ` Chen, Alvin
2014-09-16  1:07               ` Chen, Alvin
2014-09-09 18:07 ` [PATCH 2/4 v3] GPIO: gpio-dwapb: Change readl&writel to dwapb_read&dwapb_write Weike Chen
2014-09-09 18:08 ` [PATCH 3/4 v3] GPIO: gpio-dwapb: Support Debounce Weike Chen
2014-09-09 18:08 ` [PATCH 4/4 v3] GPIO: gpio-dwapb: Suspend & Resume PM enabling Weike Chen
2014-09-11 16:40   ` atull
2014-09-11 16:40     ` atull
2014-09-12  2:27     ` Chen, Alvin
2014-09-12 15:46       ` atull [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1409121045070.373@atx-linux-37 \
    --to=atull@opensource.altera.com \
    --cc=alvin.chen@intel.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=arnd@arndb.de \
    --cc=boon.leong.ong@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dvhart@linux.intel.com \
    --cc=gnurou@gmail.com \
    --cc=grant.likely@linaro.org \
    --cc=hock.leong.kweh@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian@breakpoint.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.