All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: Weike Chen <alvin.chen@intel.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	atull <atull@opensource.altera.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,
	Boon Leong Ong <boon.leong.ong@intel.com>,
	Hock Leong Kweh <hock.leong.kweh@intel.com>,
	Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
	Mika Westerberg <mika.westerberg@intel.com>,
	Andriy Shevchenko <andriy.shevchenko@intel.com>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver
Date: Tue, 09 Sep 2014 10:05:33 -0700	[thread overview]
Message-ID: <D034802C.A7BEE%dvhart@linux.intel.com> (raw)
In-Reply-To: <1410286081-16653-2-git-send-email-alvin.chen@intel.com>

On 9/9/14, 11:07, "Weike Chen" <alvin.chen@intel.com> wrote:

>The Synopsys DesignWare APB GPIO driver only supports open firmware
>devices.
>But, like Intel Quark X1000 SOC, which has a single PCI function exporting
>a GPIO and an I2C controller, it is a Multifunction device. This patch is
>to enable the current Synopsys DesignWare APB GPIO driver to support the
>Multifunction device which exports the designware GPIO controller.
>
>Reviewed-by: Hock Leong Kweh <hock.leong.kweh@intel.com>
>Signed-off-by: Weike Chen <alvin.chen@intel.com>
>---
> drivers/gpio/Kconfig                     |    1 -
> drivers/gpio/gpio-dwapb.c                |  226
>++++++++++++++++++++++--------
> include/linux/platform_data/gpio-dwapb.h |   32 +++++
> 3 files changed, 201 insertions(+), 58 deletions(-)
> create mode 100644 include/linux/platform_data/gpio-dwapb.h
>
>diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>index 9de1515..8250a44 100644
>--- a/drivers/gpio/Kconfig
>+++ b/drivers/gpio/Kconfig
>@@ -136,7 +136,6 @@ config GPIO_DWAPB
> 	tristate "Synopsys DesignWare APB GPIO driver"
> 	select GPIO_GENERIC
> 	select GENERIC_IRQ_CHIP
>-	depends on OF_GPIO

You cover this specific dependencies with inline ifdefs, but you lose the
CONFIG_OF depends by dropping it, and there are no such checks in the
probe routine. Assumptions of OF are not limited to probe in this driver.

While I would like to see this assumption properly abstracted, the most
expedient/immediate fix is probably to add a depends on OF above.

--
Darren
Intel Open Source Technology Center



WARNING: multiple messages have this Message-ID (diff)
From: Darren Hart <dvhart@infradead.org>
To: Weike Chen <alvin.chen@intel.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	atull <atull@opensource.altera.com>
Cc: <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	Boon Leong Ong <boon.leong.ong@intel.com>,
	Hock Leong Kweh <hock.leong.kweh@intel.com>,
	Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
	Mika Westerberg <mika.westerberg@intel.com>,
	Andriy Shevchenko <andriy.shevchenko@intel.com>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver
Date: Tue, 09 Sep 2014 10:05:33 -0700	[thread overview]
Message-ID: <D034802C.A7BEE%dvhart@linux.intel.com> (raw)
In-Reply-To: <1410286081-16653-2-git-send-email-alvin.chen@intel.com>

On 9/9/14, 11:07, "Weike Chen" <alvin.chen@intel.com> wrote:

>The Synopsys DesignWare APB GPIO driver only supports open firmware
>devices.
>But, like Intel Quark X1000 SOC, which has a single PCI function exporting
>a GPIO and an I2C controller, it is a Multifunction device. This patch is
>to enable the current Synopsys DesignWare APB GPIO driver to support the
>Multifunction device which exports the designware GPIO controller.
>
>Reviewed-by: Hock Leong Kweh <hock.leong.kweh@intel.com>
>Signed-off-by: Weike Chen <alvin.chen@intel.com>
>---
> drivers/gpio/Kconfig                     |    1 -
> drivers/gpio/gpio-dwapb.c                |  226
>++++++++++++++++++++++--------
> include/linux/platform_data/gpio-dwapb.h |   32 +++++
> 3 files changed, 201 insertions(+), 58 deletions(-)
> create mode 100644 include/linux/platform_data/gpio-dwapb.h
>
>diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>index 9de1515..8250a44 100644
>--- a/drivers/gpio/Kconfig
>+++ b/drivers/gpio/Kconfig
>@@ -136,7 +136,6 @@ config GPIO_DWAPB
> 	tristate "Synopsys DesignWare APB GPIO driver"
> 	select GPIO_GENERIC
> 	select GENERIC_IRQ_CHIP
>-	depends on OF_GPIO

You cover this specific dependencies with inline ifdefs, but you lose the
CONFIG_OF depends by dropping it, and there are no such checks in the
probe routine. Assumptions of OF are not limited to probe in this driver.

While I would like to see this assumption properly abstracted, the most
expedient/immediate fix is probably to add a depends on OF above.

--
Darren
Intel Open Source Technology Center



  reply	other threads:[~2014-09-09 17:06 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09 18:07 [PATCH 0/4 v3] The Designware GPIO Supporting Weike Chen
2014-09-09 18:07 ` Weike Chen
2014-09-09 18:07 ` [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Weike Chen
2014-09-09 17:05   ` Darren Hart [this message]
2014-09-09 17:05     ` Darren Hart
2014-09-10  0:34     ` Chen, Alvin
2014-09-10  0:34       ` Chen, Alvin
2014-09-10  3:26       ` Darren Hart
2014-09-10 10:32         ` Chen, Alvin
2014-09-10 10:32           ` Chen, Alvin
2014-09-10 19:11   ` atull
2014-09-10 19:11     ` atull
2014-09-11  0:32     ` Chen, Alvin
2014-09-11  0:46     ` Chen, Alvin
2014-09-11 15:40       ` atull
2014-09-11  7:59     ` Shevchenko, Andriy
2014-09-11  7:59       ` Shevchenko, Andriy
     [not found]       ` <1410422381.7023.15.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-11 15:26         ` atull
2014-09-11 15:26           ` atull
2014-09-15  1:18           ` Chen, Alvin
2014-09-15  1:18             ` Chen, Alvin
2014-09-16  1:07             ` Chen, Alvin
2014-09-16  1:07               ` Chen, Alvin
2014-09-09 18:07 ` [PATCH 2/4 v3] GPIO: gpio-dwapb: Change readl&writel to dwapb_read&dwapb_write Weike Chen
2014-09-09 18:08 ` [PATCH 3/4 v3] GPIO: gpio-dwapb: Support Debounce Weike Chen
2014-09-09 18:08 ` [PATCH 4/4 v3] GPIO: gpio-dwapb: Suspend & Resume PM enabling Weike Chen
2014-09-11 16:40   ` atull
2014-09-11 16:40     ` atull
2014-09-12  2:27     ` Chen, Alvin
2014-09-12 15:46       ` atull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D034802C.A7BEE%dvhart@linux.intel.com \
    --to=dvhart@infradead.org \
    --cc=alvin.chen@intel.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=arnd@arndb.de \
    --cc=atull@opensource.altera.com \
    --cc=boon.leong.ong@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gnurou@gmail.com \
    --cc=grant.likely@linaro.org \
    --cc=hock.leong.kweh@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian@breakpoint.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.