From: "Chen, Alvin" <alvin.chen@intel.com> To: Darren Hart <dvhart@infradead.org>, Linus Walleij <linus.walleij@linaro.org>, Alexandre Courbot <gnurou@gmail.com>, Grant Likely <grant.likely@linaro.org>, Rob Herring <robh+dt@kernel.org>, atull <atull@opensource.altera.com> Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "Ong, Boon Leong" <boon.leong.ong@intel.com>, "Kweh, Hock Leong" <hock.leong.kweh@intel.com>, Sebastian Andrzej Siewior <sebastian@breakpoint.cc>, "Westerberg, Mika" <mika.westerberg@intel.com>, "Shevchenko, Andriy" <andriy.shevchenko@intel.com>, Arnd Bergmann <arnd@arndb.de> Subject: RE: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Date: Wed, 10 Sep 2014 00:34:50 +0000 [thread overview] Message-ID: <4656BEB6164FC34F8171C6538F1A595B2E98854F@SHSMSX101.ccr.corp.intel.com> (raw) In-Reply-To: <D034802C.A7BEE%dvhart@linux.intel.com> > >@@ -136,7 +136,6 @@ config GPIO_DWAPB > > tristate "Synopsys DesignWare APB GPIO driver" > > select GPIO_GENERIC > > select GENERIC_IRQ_CHIP > >- depends on OF_GPIO > > You cover this specific dependencies with inline ifdefs, but you lose the > CONFIG_OF depends by dropping it, and there are no such checks in the probe > routine. Assumptions of OF are not limited to probe in this driver. > > While I would like to see this assumption properly abstracted, the most > expedient/immediate fix is probably to add a depends on OF above. Andriy, how do you think? How about depends on OF_GPIO || MFD_GPIO_DWAPB, or depends on OF_GPIO || MFD_INTEL_QUARK_I2C_GPIO? > -- > Darren > Intel Open Source Technology Center >
WARNING: multiple messages have this Message-ID (diff)
From: "Chen, Alvin" <alvin.chen@intel.com> To: Darren Hart <dvhart@infradead.org>, Linus Walleij <linus.walleij@linaro.org>, Alexandre Courbot <gnurou@gmail.com>, "Grant Likely" <grant.likely@linaro.org>, Rob Herring <robh+dt@kernel.org>, atull <atull@opensource.altera.com>, "Shevchenko, Andriy" <andriy.shevchenko@intel.com> Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "Ong, Boon Leong" <boon.leong.ong@intel.com>, "Kweh, Hock Leong" <hock.leong.kweh@intel.com>, Sebastian Andrzej Siewior <sebastian@breakpoint.cc>, "Westerberg, Mika" <mika.westerberg@intel.com>, "Shevchenko, Andriy" <andriy.shevchenko@intel.com>, Arnd Bergmann <arnd@arndb.de> Subject: RE: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Date: Wed, 10 Sep 2014 00:34:50 +0000 [thread overview] Message-ID: <4656BEB6164FC34F8171C6538F1A595B2E98854F@SHSMSX101.ccr.corp.intel.com> (raw) In-Reply-To: <D034802C.A7BEE%dvhart@linux.intel.com> > >@@ -136,7 +136,6 @@ config GPIO_DWAPB > > tristate "Synopsys DesignWare APB GPIO driver" > > select GPIO_GENERIC > > select GENERIC_IRQ_CHIP > >- depends on OF_GPIO > > You cover this specific dependencies with inline ifdefs, but you lose the > CONFIG_OF depends by dropping it, and there are no such checks in the probe > routine. Assumptions of OF are not limited to probe in this driver. > > While I would like to see this assumption properly abstracted, the most > expedient/immediate fix is probably to add a depends on OF above. Andriy, how do you think? How about depends on OF_GPIO || MFD_GPIO_DWAPB, or depends on OF_GPIO || MFD_INTEL_QUARK_I2C_GPIO? > -- > Darren > Intel Open Source Technology Center >
next prev parent reply other threads:[~2014-09-10 0:34 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-09 18:07 [PATCH 0/4 v3] The Designware GPIO Supporting Weike Chen 2014-09-09 18:07 ` Weike Chen 2014-09-09 18:07 ` [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Weike Chen 2014-09-09 17:05 ` Darren Hart 2014-09-09 17:05 ` Darren Hart 2014-09-10 0:34 ` Chen, Alvin [this message] 2014-09-10 0:34 ` Chen, Alvin 2014-09-10 3:26 ` Darren Hart 2014-09-10 10:32 ` Chen, Alvin 2014-09-10 10:32 ` Chen, Alvin 2014-09-10 19:11 ` atull 2014-09-10 19:11 ` atull 2014-09-11 0:32 ` Chen, Alvin 2014-09-11 0:46 ` Chen, Alvin 2014-09-11 15:40 ` atull 2014-09-11 7:59 ` Shevchenko, Andriy 2014-09-11 7:59 ` Shevchenko, Andriy [not found] ` <1410422381.7023.15.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2014-09-11 15:26 ` atull 2014-09-11 15:26 ` atull 2014-09-15 1:18 ` Chen, Alvin 2014-09-15 1:18 ` Chen, Alvin 2014-09-16 1:07 ` Chen, Alvin 2014-09-16 1:07 ` Chen, Alvin 2014-09-09 18:07 ` [PATCH 2/4 v3] GPIO: gpio-dwapb: Change readl&writel to dwapb_read&dwapb_write Weike Chen 2014-09-09 18:08 ` [PATCH 3/4 v3] GPIO: gpio-dwapb: Support Debounce Weike Chen 2014-09-09 18:08 ` [PATCH 4/4 v3] GPIO: gpio-dwapb: Suspend & Resume PM enabling Weike Chen 2014-09-11 16:40 ` atull 2014-09-11 16:40 ` atull 2014-09-12 2:27 ` Chen, Alvin 2014-09-12 15:46 ` atull
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4656BEB6164FC34F8171C6538F1A595B2E98854F@SHSMSX101.ccr.corp.intel.com \ --to=alvin.chen@intel.com \ --cc=andriy.shevchenko@intel.com \ --cc=arnd@arndb.de \ --cc=atull@opensource.altera.com \ --cc=boon.leong.ong@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=dvhart@infradead.org \ --cc=gnurou@gmail.com \ --cc=grant.likely@linaro.org \ --cc=hock.leong.kweh@intel.com \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mika.westerberg@intel.com \ --cc=robh+dt@kernel.org \ --cc=sebastian@breakpoint.cc \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.