From: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
To: "atull@opensource.altera.com" <atull@opensource.altera.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Chen, Alvin" <alvin.chen@intel.com>,
"Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>,
"gnurou@gmail.com" <gnurou@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"sebastian@breakpoint.cc" <sebastian@breakpoint.cc>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"Westerberg, Mika" <mika.westerberg@intel.com>,
"dvhart@linux.intel.com" <dvhart@linux.intel.com>,
"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver
Date: Thu, 11 Sep 2014 07:59:51 +0000 [thread overview]
Message-ID: <1410422381.7023.15.camel@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1409101353500.2790@atx-linux-37>
On Wed, 2014-09-10 at 14:11 -0500, atull wrote:
[]
> > static int dwapb_gpio_probe(struct platform_device *pdev)
> > {
> > + int i;
> > struct resource *res;
> > struct dwapb_gpio *gpio;
> > - struct device_node *np;
> > int err;
> > - unsigned int offs = 0;
> > + struct device *dev = &pdev->dev;
> > + struct dwapb_platform_data *pdata = dev_get_platdata(dev);
> > + bool is_pdata_alloc = !pdata;
>
> Please combine the int's in one line (int err, i;) and put them as
> the last one on this list. It looks the same to the compiler of
> course, but more uniform for human eyes :)
Do you think it's a good idea? In this case I, for example, would like
to see int err as a separate line at the end of definition block. It
would be better to distinguish counters and return code storage.
Moreover, often counters would be unsigned int.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
WARNING: multiple messages have this Message-ID (diff)
From: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
To: "atull@opensource.altera.com" <atull@opensource.altera.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Chen, Alvin" <alvin.chen@intel.com>,
"Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>,
"gnurou@gmail.com" <gnurou@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"sebastian@breakpoint.cc" <sebastian@breakpoint.cc>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"Westerberg, Mika" <mika.westerberg@intel.com>,
"dvhart@linux.intel.com" <dvhart@linux.intel.com>,
"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver
Date: Thu, 11 Sep 2014 07:59:51 +0000 [thread overview]
Message-ID: <1410422381.7023.15.camel@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1409101353500.2790@atx-linux-37>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1529 bytes --]
On Wed, 2014-09-10 at 14:11 -0500, atull wrote:
[]
> > static int dwapb_gpio_probe(struct platform_device *pdev)
> > {
> > + int i;
> > struct resource *res;
> > struct dwapb_gpio *gpio;
> > - struct device_node *np;
> > int err;
> > - unsigned int offs = 0;
> > + struct device *dev = &pdev->dev;
> > + struct dwapb_platform_data *pdata = dev_get_platdata(dev);
> > + bool is_pdata_alloc = !pdata;
>
> Please combine the int's in one line (int err, i;) and put them as
> the last one on this list. It looks the same to the compiler of
> course, but more uniform for human eyes :)
Do you think it's a good idea? In this case I, for example, would like
to see int err as a separate line at the end of definition block. It
would be better to distinguish counters and return code storage.
Moreover, often counters would be unsigned int.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
next prev parent reply other threads:[~2014-09-11 8:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 18:07 [PATCH 0/4 v3] The Designware GPIO Supporting Weike Chen
2014-09-09 18:07 ` Weike Chen
2014-09-09 18:07 ` [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Weike Chen
2014-09-09 17:05 ` Darren Hart
2014-09-09 17:05 ` Darren Hart
2014-09-10 0:34 ` Chen, Alvin
2014-09-10 0:34 ` Chen, Alvin
2014-09-10 3:26 ` Darren Hart
2014-09-10 10:32 ` Chen, Alvin
2014-09-10 10:32 ` Chen, Alvin
2014-09-10 19:11 ` atull
2014-09-10 19:11 ` atull
2014-09-11 0:32 ` Chen, Alvin
2014-09-11 0:46 ` Chen, Alvin
2014-09-11 15:40 ` atull
2014-09-11 7:59 ` Shevchenko, Andriy [this message]
2014-09-11 7:59 ` Shevchenko, Andriy
[not found] ` <1410422381.7023.15.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-11 15:26 ` atull
2014-09-11 15:26 ` atull
2014-09-15 1:18 ` Chen, Alvin
2014-09-15 1:18 ` Chen, Alvin
2014-09-16 1:07 ` Chen, Alvin
2014-09-16 1:07 ` Chen, Alvin
2014-09-09 18:07 ` [PATCH 2/4 v3] GPIO: gpio-dwapb: Change readl&writel to dwapb_read&dwapb_write Weike Chen
2014-09-09 18:08 ` [PATCH 3/4 v3] GPIO: gpio-dwapb: Support Debounce Weike Chen
2014-09-09 18:08 ` [PATCH 4/4 v3] GPIO: gpio-dwapb: Suspend & Resume PM enabling Weike Chen
2014-09-11 16:40 ` atull
2014-09-11 16:40 ` atull
2014-09-12 2:27 ` Chen, Alvin
2014-09-12 15:46 ` atull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410422381.7023.15.camel@intel.com \
--to=andriy.shevchenko@intel.com \
--cc=alvin.chen@intel.com \
--cc=arnd@arndb.de \
--cc=atull@opensource.altera.com \
--cc=boon.leong.ong@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dvhart@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=grant.likely@linaro.org \
--cc=hock.leong.kweh@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@intel.com \
--cc=robh+dt@kernel.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.