From: Ziji Hu <huziji@marvell.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>,
Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-mmc@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Andrew Lunn <andrew@lunn.ch>,
Yehuda Yitschak <yehuday@marvell.com>,
Marcin Wojtas <mw@semihalf.com>,
Jason Cooper <jason@lakedaemon.net>,
Hanna Hawa <hannah@marvell.com>,
Kostya Porotchkin <kostap@marvell.com>,
Nadav Haklai <nadavh@marvell.com>, Jimmy Xu <zmxu@marvell.com>,
Doug Jones <dougj@marvell.com>, Ryan Gao <ygao@marvell.com>,
Jisheng Zhang <jszhang@marvell.com>, Victor Gu <xigu@marvell.com>,
"Wei(SOCP) Liu" <liuw@marvell.com>,
Wilson Ding <dingwei@marvell.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v4 06/12] dt: bindings: Add bindings for Marvell Xenon SD Host Controller
Date: Thu, 22 Dec 2016 20:47:07 +0800 [thread overview]
Message-ID: <c7755b17-d1a8-b1eb-4750-9b57c35768f1@marvell.com> (raw)
In-Reply-To: <20161222111802.GX14217@n2100.armlinux.org.uk>
Hi Russell,
On 2016/12/22 19:18, Russell King - ARM Linux wrote:
> On Tue, Dec 13, 2016 at 06:48:35PM +0100, Gregory CLEMENT wrote:
>> +Optional Properties:
>> +- mmc-card:
>> + mmc-card child node must be provided when current SDHC is for eMMC.
>> + Xenon SDHC often can support both SD and eMMC. This child node indicates that
>> + current SDHC is for eMMC card. Thus Xenon eMMC specific configuration and
>> + operations can be enabled prior to eMMC init sequence.
>> + Please refer to Documentation/devicetree/bindings/mmc/mmc-card.txt.
>> + This child node should not be set if current Xenon SDHC is for SD/SDIO.
>
> This looks like a typo - shouldn't it be "mmccard" and not "mmc-card"?
> Your examples below use "mmccard" as does the documentation you point
> towards.
>
Thanks a lot for the review.
I might mix up it with compatible "mmc-card".
I will change it to sub-node name in next version soon.
Thank you.
Best regards,
Hu Ziji
WARNING: multiple messages have this Message-ID (diff)
From: huziji@marvell.com (Ziji Hu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 06/12] dt: bindings: Add bindings for Marvell Xenon SD Host Controller
Date: Thu, 22 Dec 2016 20:47:07 +0800 [thread overview]
Message-ID: <c7755b17-d1a8-b1eb-4750-9b57c35768f1@marvell.com> (raw)
In-Reply-To: <20161222111802.GX14217@n2100.armlinux.org.uk>
Hi Russell,
On 2016/12/22 19:18, Russell King - ARM Linux wrote:
> On Tue, Dec 13, 2016 at 06:48:35PM +0100, Gregory CLEMENT wrote:
>> +Optional Properties:
>> +- mmc-card:
>> + mmc-card child node must be provided when current SDHC is for eMMC.
>> + Xenon SDHC often can support both SD and eMMC. This child node indicates that
>> + current SDHC is for eMMC card. Thus Xenon eMMC specific configuration and
>> + operations can be enabled prior to eMMC init sequence.
>> + Please refer to Documentation/devicetree/bindings/mmc/mmc-card.txt.
>> + This child node should not be set if current Xenon SDHC is for SD/SDIO.
>
> This looks like a typo - shouldn't it be "mmccard" and not "mmc-card"?
> Your examples below use "mmccard" as does the documentation you point
> towards.
>
Thanks a lot for the review.
I might mix up it with compatible "mmc-card".
I will change it to sub-node name in next version soon.
Thank you.
Best regards,
Hu Ziji
next prev parent reply other threads:[~2016-12-22 12:47 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 17:48 [PATCH v4 00/12] mmc: Add support to Marvell Xenon SD Host Controller Gregory CLEMENT
2016-12-13 17:48 ` Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 01/12] mmc: sdhci: Export sdhci_set_ios() from sdhci.c Gregory CLEMENT
2016-12-13 17:48 ` Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 02/12] mmc: sdhci: Export sdhci_start_signal_voltage_switch() in sdhci.c Gregory CLEMENT
2016-12-13 17:48 ` Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 03/12] mmc: sdhci: Export sdhci_execute_tuning() " Gregory CLEMENT
2016-12-13 17:48 ` Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 04/12] mmc: sdhci: Export sdhci_enable_sdio_irq() from sdhci.c Gregory CLEMENT
2016-12-13 17:48 ` Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 05/12] MAINTAINERS: add entry for Marvell Xenon MMC Host Controller drivers Gregory CLEMENT
2016-12-13 17:48 ` Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 06/12] dt: bindings: Add bindings for Marvell Xenon SD Host Controller Gregory CLEMENT
2016-12-13 17:48 ` Gregory CLEMENT
2016-12-22 11:18 ` Russell King - ARM Linux
2016-12-22 11:18 ` Russell King - ARM Linux
2016-12-22 12:47 ` Ziji Hu [this message]
2016-12-22 12:47 ` Ziji Hu
2016-12-13 17:48 ` [PATCH v4 07/12] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality Gregory CLEMENT
2016-12-13 17:48 ` Gregory CLEMENT
2017-01-04 7:26 ` Adrian Hunter
2017-01-04 7:26 ` Adrian Hunter
2017-01-04 8:51 ` Ziji Hu
2017-01-04 8:51 ` Ziji Hu
2017-01-04 9:08 ` Adrian Hunter
2017-01-04 9:08 ` Adrian Hunter
2016-12-13 17:48 ` [PATCH v4 08/12] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC Gregory CLEMENT
2016-12-13 17:48 ` Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 09/12] mmc: sdhci-xenon: Add SOC PHY PAD voltage control Gregory CLEMENT
2016-12-13 17:48 ` Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 10/12] arm64: dts: marvell: add eMMC support for Armada 37xx Gregory CLEMENT
2016-12-13 17:48 ` Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 11/12] arm64: dts: marvell: add sdhci support for Armada 7K/8K Gregory CLEMENT
2016-12-13 17:48 ` Gregory CLEMENT
2016-12-22 10:45 ` Russell King - ARM Linux
2016-12-22 10:45 ` Russell King - ARM Linux
2016-12-22 10:47 ` Thomas Petazzoni
2016-12-22 10:47 ` Thomas Petazzoni
2016-12-22 10:47 ` Russell King - ARM Linux
2016-12-22 10:47 ` Russell King - ARM Linux
2016-12-22 11:21 ` Russell King - ARM Linux
2016-12-22 11:21 ` Russell King - ARM Linux
2016-12-13 17:48 ` [PATCH v4 12/12] arm64: configs: enable SDHCI driver for Xenon Gregory CLEMENT
2016-12-13 17:48 ` Gregory CLEMENT
[not found] ` <CAPv3WKeE_2gMn12MXraoUmDEJhi307mGuc4BgDYpethKNsMqRQ@mail.gmail.com>
2016-12-14 19:02 ` [PATCH v4 00/12] mmc: Add support to Marvell Xenon SD Host Controller Marcin Wojtas
2016-12-14 19:02 ` Marcin Wojtas
2016-12-22 11:25 ` Russell King - ARM Linux
2016-12-22 11:25 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7755b17-d1a8-b1eb-4750-9b57c35768f1@marvell.com \
--to=huziji@marvell.com \
--cc=adrian.hunter@intel.com \
--cc=andrew@lunn.ch \
--cc=dingwei@marvell.com \
--cc=dougj@marvell.com \
--cc=gregory.clement@free-electrons.com \
--cc=hannah@marvell.com \
--cc=jason@lakedaemon.net \
--cc=jszhang@marvell.com \
--cc=kostap@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liuw@marvell.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ulf.hansson@linaro.org \
--cc=xigu@marvell.com \
--cc=yehuday@marvell.com \
--cc=ygao@marvell.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.