* [PATCH] tbs2910: migrate to DM_VIDEO @ 2020-05-22 23:24 Anatolij Gustschin 2020-05-23 7:55 ` Soeren Moch 2020-05-24 15:46 ` Soeren Moch 0 siblings, 2 replies; 15+ messages in thread From: Anatolij Gustschin @ 2020-05-22 23:24 UTC (permalink / raw) To: u-boot Migration to DM_VIDEO driver is long overdue, configure it in board config files. To enable the display set stdout like: setenv stdout serial,vidconsole Signed-off-by: Anatolij Gustschin <agust@denx.de> --- This is only build tested. configs/tbs2910_defconfig | 7 ++++++- include/configs/tbs2910.h | 2 -- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig index 2ff0e160f7..b40641c17b 100644 --- a/configs/tbs2910_defconfig +++ b/configs/tbs2910_defconfig @@ -1,6 +1,7 @@ CONFIG_ARM=y CONFIG_ARCH_MX6=y CONFIG_SYS_TEXT_BASE=0x17800000 +CONFIG_SYS_MALLOC_F_LEN=0x4000 CONFIG_ENV_SIZE=0x2000 CONFIG_ENV_OFFSET=0x60000 CONFIG_TARGET_TBS2910=y @@ -84,7 +85,11 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 CONFIG_CI_UDC=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_I2C_EDID=y +CONFIG_DM_VIDEO=y +# CONFIG_VIDEO_BPP8 is not set +# CONFIG_VIDEO_BPP32 is not set +# CONFIG_VIDEO_ANSI is not set CONFIG_VIDEO_IPUV3=y -CONFIG_VIDEO=y +CONFIG_SYS_WHITE_ON_BLACK=y CONFIG_OF_LIBFDT_ASSUME_MASK=0xff # CONFIG_EFI_LOADER is not set diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h index 7376b91f55..8ab3fcfe3e 100644 --- a/include/configs/tbs2910.h +++ b/include/configs/tbs2910.h @@ -37,11 +37,9 @@ #define CONFIG_MXC_UART_BASE UART1_BASE /* select UART1/UART2 */ /* Framebuffer */ -#ifdef CONFIG_VIDEO #define CONFIG_VIDEO_BMP_RLE8 #define CONFIG_IMX_HDMI #define CONFIG_IMX_VIDEO_SKIP -#endif /* PCI */ #ifdef CONFIG_CMD_PCI -- 2.17.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] tbs2910: migrate to DM_VIDEO 2020-05-22 23:24 [PATCH] tbs2910: migrate to DM_VIDEO Anatolij Gustschin @ 2020-05-23 7:55 ` Soeren Moch 2020-05-23 15:11 ` [PATCH] video: extend stdout video console work-around for 'vga' Anatolij Gustschin 2020-05-23 15:17 ` [PATCH] tbs2910: migrate to DM_VIDEO Anatolij Gustschin 2020-05-24 15:46 ` Soeren Moch 1 sibling, 2 replies; 15+ messages in thread From: Soeren Moch @ 2020-05-23 7:55 UTC (permalink / raw) To: u-boot On 23.05.20 01:24, Anatolij Gustschin wrote: > Migration to DM_VIDEO driver is long overdue, configure it in > board config files. To enable the display set stdout like: > > setenv stdout serial,vidconsole And this exactly is the problem. There are some users of this board without serial console. They have no chance to set this after upgrading u-boot. What is the reason behind this incompatible change? In other words, why vga cannot be an alias for vidconsole, if this is the preferred name nowadays? Regards, Soeren > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > --- > This is only build tested. > > configs/tbs2910_defconfig | 7 ++++++- > include/configs/tbs2910.h | 2 -- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig > index 2ff0e160f7..b40641c17b 100644 > --- a/configs/tbs2910_defconfig > +++ b/configs/tbs2910_defconfig > @@ -1,6 +1,7 @@ > CONFIG_ARM=y > CONFIG_ARCH_MX6=y > CONFIG_SYS_TEXT_BASE=0x17800000 > +CONFIG_SYS_MALLOC_F_LEN=0x4000 > CONFIG_ENV_SIZE=0x2000 > CONFIG_ENV_OFFSET=0x60000 > CONFIG_TARGET_TBS2910=y > @@ -84,7 +85,11 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 > CONFIG_CI_UDC=y > CONFIG_USB_GADGET_DOWNLOAD=y > CONFIG_I2C_EDID=y > +CONFIG_DM_VIDEO=y > +# CONFIG_VIDEO_BPP8 is not set > +# CONFIG_VIDEO_BPP32 is not set > +# CONFIG_VIDEO_ANSI is not set > CONFIG_VIDEO_IPUV3=y > -CONFIG_VIDEO=y > +CONFIG_SYS_WHITE_ON_BLACK=y > CONFIG_OF_LIBFDT_ASSUME_MASK=0xff > # CONFIG_EFI_LOADER is not set > diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h > index 7376b91f55..8ab3fcfe3e 100644 > --- a/include/configs/tbs2910.h > +++ b/include/configs/tbs2910.h > @@ -37,11 +37,9 @@ > #define CONFIG_MXC_UART_BASE UART1_BASE /* select UART1/UART2 */ > > /* Framebuffer */ > -#ifdef CONFIG_VIDEO > #define CONFIG_VIDEO_BMP_RLE8 > #define CONFIG_IMX_HDMI > #define CONFIG_IMX_VIDEO_SKIP > -#endif > > /* PCI */ > #ifdef CONFIG_CMD_PCI ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] video: extend stdout video console work-around for 'vga' 2020-05-23 7:55 ` Soeren Moch @ 2020-05-23 15:11 ` Anatolij Gustschin 2020-05-24 15:21 ` Soeren Moch ` (3 more replies) 2020-05-23 15:17 ` [PATCH] tbs2910: migrate to DM_VIDEO Anatolij Gustschin 1 sibling, 4 replies; 15+ messages in thread From: Anatolij Gustschin @ 2020-05-23 15:11 UTC (permalink / raw) To: u-boot cfb_console driver use 'vga' console name and we still have board environments defining this name. Re-use existing DM_VIDEO work- around for console name to support 'vga' name in stdout environment. Signed-off-by: Anatolij Gustschin <agust@denx.de> --- arch/arm/mach-tegra/Kconfig | 1 - common/console.c | 7 ++++--- drivers/video/Kconfig | 16 +++++++++------- 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index 00facf492e..15e7684028 100644 --- a/arch/arm/mach-tegra/Kconfig +++ b/arch/arm/mach-tegra/Kconfig @@ -58,7 +58,6 @@ config TEGRA_COMMON select MISC select OF_CONTROL select SPI - select VIDCONSOLE_AS_LCD if DM_VIDEO imply CMD_DM imply CRC32_VERIFY diff --git a/common/console.c b/common/console.c index 1deca3cb78..f149624954 100644 --- a/common/console.c +++ b/common/console.c @@ -713,7 +713,7 @@ struct stdio_dev *search_device(int flags, const char *name) dev = stdio_get_by_name(name); #ifdef CONFIG_VIDCONSOLE_AS_LCD - if (!dev && !strcmp(name, "lcd")) + if (!dev && !strcmp(name, CONFIG_VIDCONSOLE_AS_LCD)) dev = stdio_get_by_name("vidconsole"); #endif @@ -897,8 +897,9 @@ done: stdio_print_current_devices(); #endif /* CONFIG_SYS_CONSOLE_INFO_QUIET */ #ifdef CONFIG_VIDCONSOLE_AS_LCD - if (strstr(stdoutname, "lcd")) - printf("Warning: Please change 'lcd' to 'vidconsole' in stdout/stderr environment vars\n"); + if (strstr(stdoutname, CONFIG_VIDCONSOLE_AS_LCD)) + printf("Warning: Please change '%s' to 'vidconsole' in stdout/stderr environment vars\n", + CONFIG_VIDCONSOLE_AS_LCD); #endif #ifdef CONFIG_SYS_CONSOLE_ENV_OVERWRITE diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 38123543a5..28c22fe525 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -146,14 +146,16 @@ config NO_FB_CLEAR source "drivers/video/fonts/Kconfig" config VIDCONSOLE_AS_LCD - bool "Use 'vidconsole' when 'lcd' is seen in stdout" + string "Use 'vidconsole' when string defined here is seen in stdout" depends on DM_VIDEO - help - This is a work-around for boards which have 'lcd' in their stdout - environment variable, but have moved to use driver model for video. - In this case the console will no-longer work. While it is possible - to update the environment, the breakage may be confusing for users. - This option will be removed around the end of 2016. + default "lcd" if LCD || TEGRA_COMMON + default "vga" if !LCD + help + This is a work-around for boards which have 'lcd' or 'vga' in their + stdout environment variable, but have moved to use driver model for + video. In this case the console will no-longer work. While it is + possible to update the environment, the breakage may be confusing for + users. This option will be removed around the end of 2020. config VIDEO_COREBOOT bool "Enable coreboot framebuffer driver support" -- 2.17.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] video: extend stdout video console work-around for 'vga' 2020-05-23 15:11 ` [PATCH] video: extend stdout video console work-around for 'vga' Anatolij Gustschin @ 2020-05-24 15:21 ` Soeren Moch 2020-05-25 2:14 ` Simon Glass ` (2 subsequent siblings) 3 siblings, 0 replies; 15+ messages in thread From: Soeren Moch @ 2020-05-24 15:21 UTC (permalink / raw) To: u-boot On 23.05.20 17:11, Anatolij Gustschin wrote: > cfb_console driver use 'vga' console name and we still have board > environments defining this name. Re-use existing DM_VIDEO work- > around for console name to support 'vga' name in stdout environment. > > Signed-off-by: Anatolij Gustschin <agust@denx.de> Tested on tbs2910, works as intended. Tested-by: Soeren Moch <smoch@web.de> Thanks, Soeren > --- > arch/arm/mach-tegra/Kconfig | 1 - > common/console.c | 7 ++++--- > drivers/video/Kconfig | 16 +++++++++------- > 3 files changed, 13 insertions(+), 11 deletions(-) > > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig > index 00facf492e..15e7684028 100644 > --- a/arch/arm/mach-tegra/Kconfig > +++ b/arch/arm/mach-tegra/Kconfig > @@ -58,7 +58,6 @@ config TEGRA_COMMON > select MISC > select OF_CONTROL > select SPI > - select VIDCONSOLE_AS_LCD if DM_VIDEO > imply CMD_DM > imply CRC32_VERIFY > > diff --git a/common/console.c b/common/console.c > index 1deca3cb78..f149624954 100644 > --- a/common/console.c > +++ b/common/console.c > @@ -713,7 +713,7 @@ struct stdio_dev *search_device(int flags, const char *name) > > dev = stdio_get_by_name(name); > #ifdef CONFIG_VIDCONSOLE_AS_LCD > - if (!dev && !strcmp(name, "lcd")) > + if (!dev && !strcmp(name, CONFIG_VIDCONSOLE_AS_LCD)) > dev = stdio_get_by_name("vidconsole"); > #endif > > @@ -897,8 +897,9 @@ done: > stdio_print_current_devices(); > #endif /* CONFIG_SYS_CONSOLE_INFO_QUIET */ > #ifdef CONFIG_VIDCONSOLE_AS_LCD > - if (strstr(stdoutname, "lcd")) > - printf("Warning: Please change 'lcd' to 'vidconsole' in stdout/stderr environment vars\n"); > + if (strstr(stdoutname, CONFIG_VIDCONSOLE_AS_LCD)) > + printf("Warning: Please change '%s' to 'vidconsole' in stdout/stderr environment vars\n", > + CONFIG_VIDCONSOLE_AS_LCD); > #endif > > #ifdef CONFIG_SYS_CONSOLE_ENV_OVERWRITE > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 38123543a5..28c22fe525 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -146,14 +146,16 @@ config NO_FB_CLEAR > source "drivers/video/fonts/Kconfig" > > config VIDCONSOLE_AS_LCD > - bool "Use 'vidconsole' when 'lcd' is seen in stdout" > + string "Use 'vidconsole' when string defined here is seen in stdout" > depends on DM_VIDEO > - help > - This is a work-around for boards which have 'lcd' in their stdout > - environment variable, but have moved to use driver model for video. > - In this case the console will no-longer work. While it is possible > - to update the environment, the breakage may be confusing for users. > - This option will be removed around the end of 2016. > + default "lcd" if LCD || TEGRA_COMMON > + default "vga" if !LCD > + help > + This is a work-around for boards which have 'lcd' or 'vga' in their > + stdout environment variable, but have moved to use driver model for > + video. In this case the console will no-longer work. While it is > + possible to update the environment, the breakage may be confusing for > + users. This option will be removed around the end of 2020. > > config VIDEO_COREBOOT > bool "Enable coreboot framebuffer driver support" ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] video: extend stdout video console work-around for 'vga' 2020-05-23 15:11 ` [PATCH] video: extend stdout video console work-around for 'vga' Anatolij Gustschin 2020-05-24 15:21 ` Soeren Moch @ 2020-05-25 2:14 ` Simon Glass 2020-05-26 18:08 ` Tom Rini 2020-06-19 13:55 ` Anatolij Gustschin 3 siblings, 0 replies; 15+ messages in thread From: Simon Glass @ 2020-05-25 2:14 UTC (permalink / raw) To: u-boot On Sat, 23 May 2020 at 09:11, Anatolij Gustschin <agust@denx.de> wrote: > > cfb_console driver use 'vga' console name and we still have board > environments defining this name. Re-use existing DM_VIDEO work- > around for console name to support 'vga' name in stdout environment. > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > --- > arch/arm/mach-tegra/Kconfig | 1 - > common/console.c | 7 ++++--- > drivers/video/Kconfig | 16 +++++++++------- > 3 files changed, 13 insertions(+), 11 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org> ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] video: extend stdout video console work-around for 'vga' 2020-05-23 15:11 ` [PATCH] video: extend stdout video console work-around for 'vga' Anatolij Gustschin 2020-05-24 15:21 ` Soeren Moch 2020-05-25 2:14 ` Simon Glass @ 2020-05-26 18:08 ` Tom Rini 2020-06-19 13:55 ` Anatolij Gustschin 3 siblings, 0 replies; 15+ messages in thread From: Tom Rini @ 2020-05-26 18:08 UTC (permalink / raw) To: u-boot On Sat, May 23, 2020 at 05:11:20PM +0200, Anatolij Gustschin wrote: > cfb_console driver use 'vga' console name and we still have board > environments defining this name. Re-use existing DM_VIDEO work- > around for console name to support 'vga' name in stdout environment. > > Signed-off-by: Anatolij Gustschin <agust@denx.de> Reviewed-by: Tom Rini <trini@konsulko.com> -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200526/eab167b1/attachment.sig> ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] video: extend stdout video console work-around for 'vga' 2020-05-23 15:11 ` [PATCH] video: extend stdout video console work-around for 'vga' Anatolij Gustschin ` (2 preceding siblings ...) 2020-05-26 18:08 ` Tom Rini @ 2020-06-19 13:55 ` Anatolij Gustschin 2020-07-01 13:01 ` Patrick DELAUNAY 3 siblings, 1 reply; 15+ messages in thread From: Anatolij Gustschin @ 2020-06-19 13:55 UTC (permalink / raw) To: u-boot On Sat, 23 May 2020 17:11:20 +0200 Anatolij Gustschin agust at denx.de wrote: > cfb_console driver use 'vga' console name and we still have board > environments defining this name. Re-use existing DM_VIDEO work- > around for console name to support 'vga' name in stdout environment. > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > --- > arch/arm/mach-tegra/Kconfig | 1 - > common/console.c | 7 ++++--- > drivers/video/Kconfig | 16 +++++++++------- > 3 files changed, 13 insertions(+), 11 deletions(-) Applied to u-boot-video/next, thanks! -- Anatolij ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] video: extend stdout video console work-around for 'vga' 2020-06-19 13:55 ` Anatolij Gustschin @ 2020-07-01 13:01 ` Patrick DELAUNAY 0 siblings, 0 replies; 15+ messages in thread From: Patrick DELAUNAY @ 2020-07-01 13:01 UTC (permalink / raw) To: u-boot Hi Anatolij > From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Anatolij Gustschin > Sent: vendredi 19 juin 2020 15:56 > > On Sat, 23 May 2020 17:11:20 +0200 > Anatolij Gustschin agust at denx.de wrote: > > > cfb_console driver use 'vga' console name and we still have board > > environments defining this name. Re-use existing DM_VIDEO work- around > > for console name to support 'vga' name in stdout environment. > > > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > > --- > > arch/arm/mach-tegra/Kconfig | 1 - > > common/console.c | 7 ++++--- > > drivers/video/Kconfig | 16 +++++++++------- > > 3 files changed, 13 insertions(+), 11 deletions(-) > > Applied to u-boot-video/next, thanks! This patch breaks the stm32mp15 boot in console_init_r.on the next branch. The board have with DM_VIDEO activated. In previous version the workaround was not activated for the board: CONFIG_VIDCONSOLE_AS_LCD=n (default) PS: the config is activated in few board but still as bolean but defined as sting in Kconfig configs/peach-pit_defconfig:76:CONFIG_VIDCONSOLE_AS_LCD=y configs/snow_defconfig:87:CONFIG_VIDCONSOLE_AS_LCD=y configs/peach-pi_defconfig:77:CONFIG_VIDCONSOLE_AS_LCD=y configs/spring_defconfig:88:CONFIG_VIDCONSOLE_AS_LCD=y Now it is a string, the CONFIG is always defined = value is "lcd" or "vga" or "" And the code in console.c under this compilation flags cause the crash. I push a patch [1] to fix up it this update: VIDCONSOLE_AS_LCD => Boolean used in defconfig as previously VIDCONSOLE_AS_NAME => name the the string to used.... NEW [1] "video: restore CONFIG_VIDCONSOLE_AS_LCD as Boolean" Regards Patrick ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] tbs2910: migrate to DM_VIDEO 2020-05-23 7:55 ` Soeren Moch 2020-05-23 15:11 ` [PATCH] video: extend stdout video console work-around for 'vga' Anatolij Gustschin @ 2020-05-23 15:17 ` Anatolij Gustschin 2020-05-23 15:31 ` Soeren Moch 1 sibling, 1 reply; 15+ messages in thread From: Anatolij Gustschin @ 2020-05-23 15:17 UTC (permalink / raw) To: u-boot On Sat, 23 May 2020 09:55:48 +0200 Soeren Moch smoch at web.de wrote: > On 23.05.20 01:24, Anatolij Gustschin wrote: > > Migration to DM_VIDEO driver is long overdue, configure it in > > board config files. To enable the display set stdout like: > > > > setenv stdout serial,vidconsole > And this exactly is the problem. > There are some users of this board without serial console. They have no > chance to set this after upgrading u-boot. > > What is the reason behind this incompatible change? In other words, why > vga cannot be an alias for vidconsole, if this is the preferred name > nowadays? DM video console driver uses more generic name for the video console. As a work-around, an alias exists for 'lcd' name. I've sent a patch to also use 'vga' as an alias. -- Anatolij ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] tbs2910: migrate to DM_VIDEO 2020-05-23 15:17 ` [PATCH] tbs2910: migrate to DM_VIDEO Anatolij Gustschin @ 2020-05-23 15:31 ` Soeren Moch 0 siblings, 0 replies; 15+ messages in thread From: Soeren Moch @ 2020-05-23 15:31 UTC (permalink / raw) To: u-boot On 23.05.20 17:17, Anatolij Gustschin wrote: > On Sat, 23 May 2020 09:55:48 +0200 > Soeren Moch smoch at web.de wrote: > >> On 23.05.20 01:24, Anatolij Gustschin wrote: >>> Migration to DM_VIDEO driver is long overdue, configure it in >>> board config files. To enable the display set stdout like: >>> >>> setenv stdout serial,vidconsole >> And this exactly is the problem. >> There are some users of this board without serial console. They have no >> chance to set this after upgrading u-boot. >> >> What is the reason behind this incompatible change? In other words, why >> vga cannot be an alias for vidconsole, if this is the preferred name >> nowadays? > DM video console driver uses more generic name for the video console. > As a work-around, an alias exists for 'lcd' name. I've sent a patch > to also use 'vga' as an alias. > Thanks. I will test both patches for tbs2910. Soeren ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] tbs2910: migrate to DM_VIDEO 2020-05-22 23:24 [PATCH] tbs2910: migrate to DM_VIDEO Anatolij Gustschin 2020-05-23 7:55 ` Soeren Moch @ 2020-05-24 15:46 ` Soeren Moch 2020-05-26 20:13 ` Anatolij Gustschin 1 sibling, 1 reply; 15+ messages in thread From: Soeren Moch @ 2020-05-24 15:46 UTC (permalink / raw) To: u-boot On 23.05.20 01:24, Anatolij Gustschin wrote: > Migration to DM_VIDEO driver is long overdue, configure it in > board config files. To enable the display set stdout like: > > setenv stdout serial,vidconsole > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > --- > This is only build tested. I tested this on top of v2020.07-rc2 and your patch "video: extend stdout video console work-around for 'vga'" Works great. However, some comments below. > > configs/tbs2910_defconfig | 7 ++++++- > include/configs/tbs2910.h | 2 -- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig > index 2ff0e160f7..b40641c17b 100644 > --- a/configs/tbs2910_defconfig > +++ b/configs/tbs2910_defconfig > @@ -1,6 +1,7 @@ > CONFIG_ARM=y > CONFIG_ARCH_MX6=y > CONFIG_SYS_TEXT_BASE=0x17800000 > +CONFIG_SYS_MALLOC_F_LEN=0x4000 This is not necessary. The default 0x2000 also works fine. > CONFIG_ENV_SIZE=0x2000 > CONFIG_ENV_OFFSET=0x60000 > CONFIG_TARGET_TBS2910=y > @@ -84,7 +85,11 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 > CONFIG_CI_UDC=y > CONFIG_USB_GADGET_DOWNLOAD=y > CONFIG_I2C_EDID=y > +CONFIG_DM_VIDEO=y > +# CONFIG_VIDEO_BPP8 is not set > +# CONFIG_VIDEO_BPP32 is not set > +# CONFIG_VIDEO_ANSI is not set > CONFIG_VIDEO_IPUV3=y > -CONFIG_VIDEO=y > +CONFIG_SYS_WHITE_ON_BLACK=y > CONFIG_OF_LIBFDT_ASSUME_MASK=0xff > # CONFIG_EFI_LOADER is not set > diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h > index 7376b91f55..8ab3fcfe3e 100644 > --- a/include/configs/tbs2910.h > +++ b/include/configs/tbs2910.h > @@ -37,11 +37,9 @@ > #define CONFIG_MXC_UART_BASE UART1_BASE /* select UART1/UART2 */ > > /* Framebuffer */ > -#ifdef CONFIG_VIDEO > #define CONFIG_VIDEO_BMP_RLE8 > #define CONFIG_IMX_HDMI > #define CONFIG_IMX_VIDEO_SKIP > -#endif > > /* PCI */ > #ifdef CONFIG_CMD_PCI Since DM_VIDEO requires vidconsole as output device, please also add ---8<--- diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h index 8ab3fcfe3e..82165a9ffe 100644 --- a/include/configs/tbs2910.h +++ b/include/configs/tbs2910.h @@ -92,11 +92,11 @@ ??????? "fan=gpio set 92\0" \ ??????? "set_con_serial=setenv stdout serial; " \ ??????????????????????? "setenv stderr serial\0" \ -?????? "set_con_hdmi=setenv stdout serial,vga; " \ -?????????????????????? "setenv stderr serial,vga\0" \ -?????? "stderr=serial,vga\0" \ +?????? "set_con_hdmi=setenv stdout serial,vidconsole; " \ +?????????????????????? "setenv stderr serial,vidconsole\0" \ +?????? "stderr=serial,vidconsole\0" \ ??????? "stdin=serial,usbkbd\0" \ -?????? "stdout=serial,vga\0" +?????? "stdout=serial,vidconsole\0" ? ?#define CONFIG_BOOTCOMMAND \ ??????? "mmc rescan; " \ ---8<--- to avoid warnings for users with default environment.(not sure if whitespace is still correct in this snippet) With this DM_VIDEO conversion the board comes very close to the size limit. While it works with my toolchain, there might be problems with others. So maybe not a good idea to merge this as fix immediately. Since this depends on your above mentioned patch, do you plan to merge this via u-boot-video, or should this go as usual through the imx tree? Thank you very much for finishing this DM_VIDEO migration, Soeren ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] tbs2910: migrate to DM_VIDEO 2020-05-24 15:46 ` Soeren Moch @ 2020-05-26 20:13 ` Anatolij Gustschin 2020-05-28 7:54 ` Soeren Moch 0 siblings, 1 reply; 15+ messages in thread From: Anatolij Gustschin @ 2020-05-26 20:13 UTC (permalink / raw) To: u-boot On Sun, 24 May 2020 17:46:22 +0200 Soeren Moch smoch at web.de wrote: > On 23.05.20 01:24, Anatolij Gustschin wrote: > > Migration to DM_VIDEO driver is long overdue, configure it in > > board config files. To enable the display set stdout like: > > > > setenv stdout serial,vidconsole > > > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > > --- > > This is only build tested. > I tested this on top of v2020.07-rc2 and your patch > "video: extend stdout video console work-around for 'vga'" > > Works great. However, some comments below. Thanks for testing! ... > > +CONFIG_SYS_MALLOC_F_LEN=0x4000 > This is not necessary. The default 0x2000 also works fine. Dropped in v2. ... > Since DM_VIDEO requires vidconsole as output device, please also add > > ---8<--- > diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h > index 8ab3fcfe3e..82165a9ffe 100644 > --- a/include/configs/tbs2910.h > +++ b/include/configs/tbs2910.h > @@ -92,11 +92,11 @@ > ??????? "fan=gpio set 92\0" \ > ??????? "set_con_serial=setenv stdout serial; " \ > ??????????????????????? "setenv stderr serial\0" \ > -?????? "set_con_hdmi=setenv stdout serial,vga; " \ > -?????????????????????? "setenv stderr serial,vga\0" \ > -?????? "stderr=serial,vga\0" \ > +?????? "set_con_hdmi=setenv stdout serial,vidconsole; " \ > +?????????????????????? "setenv stderr serial,vidconsole\0" \ > +?????? "stderr=serial,vidconsole\0" \ > ??????? "stdin=serial,usbkbd\0" \ > -?????? "stdout=serial,vga\0" > +?????? "stdout=serial,vidconsole\0" > ? > ?#define CONFIG_BOOTCOMMAND \ > ??????? "mmc rescan; " \ > ---8<--- > > to avoid warnings for users with default environment.(not sure if > whitespace is still correct in this snippet) Done in v2. > With this DM_VIDEO conversion the board comes very close to the size > limit. While it works with my toolchain, there might be problems with > others. So maybe not a good idea to merge this as fix immediately. Yes, with GCC 9.2 it didn't work any more. I've submitted some DM_VIDEO patches to disable more unused code to fix this. > Since this depends on your above mentioned patch, do you plan to merge > this via u-boot-video, or should this go as usual through the imx tree? I'll merge this via u-boot-video tree. v2 patch depends on a few more video patches which are under review/built-test currently. -- Anatolij ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] tbs2910: migrate to DM_VIDEO 2020-05-26 20:13 ` Anatolij Gustschin @ 2020-05-28 7:54 ` Soeren Moch 2020-05-28 8:07 ` Anatolij Gustschin 0 siblings, 1 reply; 15+ messages in thread From: Soeren Moch @ 2020-05-28 7:54 UTC (permalink / raw) To: u-boot On 26.05.20 22:13, Anatolij Gustschin wrote: > On Sun, 24 May 2020 17:46:22 +0200 > Soeren Moch smoch at web.de wrote: > >> On 23.05.20 01:24, Anatolij Gustschin wrote: >>> Migration to DM_VIDEO driver is long overdue, configure it in >>> board config files. To enable the display set stdout like: >>> >>> setenv stdout serial,vidconsole >>> >>> Signed-off-by: Anatolij Gustschin <agust@denx.de> >>> --- >>> This is only build tested. >> I tested this on top of v2020.07-rc2 and your patch >> "video: extend stdout video console work-around for 'vga'" >> >> Works great. However, some comments below. > Thanks for testing! > > ... >>> +CONFIG_SYS_MALLOC_F_LEN=0x4000 >> This is not necessary. The default 0x2000 also works fine. > Dropped in v2. > > ... >> Since DM_VIDEO requires vidconsole as output device, please also add >> >> ---8<--- >> diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h >> index 8ab3fcfe3e..82165a9ffe 100644 >> --- a/include/configs/tbs2910.h >> +++ b/include/configs/tbs2910.h >> @@ -92,11 +92,11 @@ >> ??????? "fan=gpio set 92\0" \ >> ??????? "set_con_serial=setenv stdout serial; " \ >> ??????????????????????? "setenv stderr serial\0" \ >> -?????? "set_con_hdmi=setenv stdout serial,vga; " \ >> -?????????????????????? "setenv stderr serial,vga\0" \ >> -?????? "stderr=serial,vga\0" \ >> +?????? "set_con_hdmi=setenv stdout serial,vidconsole; " \ >> +?????????????????????? "setenv stderr serial,vidconsole\0" \ >> +?????? "stderr=serial,vidconsole\0" \ >> ??????? "stdin=serial,usbkbd\0" \ >> -?????? "stdout=serial,vga\0" >> +?????? "stdout=serial,vidconsole\0" >> ? >> ?#define CONFIG_BOOTCOMMAND \ >> ??????? "mmc rescan; " \ >> ---8<--- >> >> to avoid warnings for users with default environment.(not sure if >> whitespace is still correct in this snippet) > Done in v2. > >> With this DM_VIDEO conversion the board comes very close to the size >> limit. While it works with my toolchain, there might be problems with >> others. So maybe not a good idea to merge this as fix immediately. > Yes, with GCC 9.2 it didn't work any more. I've submitted some DM_VIDEO > patches to disable more unused code to fix this. > >> Since this depends on your above mentioned patch, do you plan to merge >> this via u-boot-video, or should this go as usual through the imx tree? > I'll merge this via u-boot-video tree. v2 patch depends on a few more > video patches which are under review/built-test currently. OK, I will try to test this new version again on top of your other patches. Do you plan to merge this for v2020.07, or for -next? Soeren ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] tbs2910: migrate to DM_VIDEO 2020-05-28 7:54 ` Soeren Moch @ 2020-05-28 8:07 ` Anatolij Gustschin 2020-05-30 16:01 ` Soeren Moch 0 siblings, 1 reply; 15+ messages in thread From: Anatolij Gustschin @ 2020-05-28 8:07 UTC (permalink / raw) To: u-boot On Thu, 28 May 2020 09:54:42 +0200 Soeren Moch smoch at web.de wrote: ... > > I'll merge this via u-boot-video tree. v2 patch depends on a few more > > video patches which are under review/built-test currently. > OK, I will try to test this new version again on top of your other patches. OK, you could use 'dm_video-imx6' branch in my repo: https://gitlab.denx.de/u-boot/custodians/u-boot-video/-/commits/dm_video-imx6 All required patches are already integrated there. > Do you plan to merge this for v2020.07, or for -next? For v2020.07 it is too late, Tom suggested to merge this for -next. -- Anatolij ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] tbs2910: migrate to DM_VIDEO 2020-05-28 8:07 ` Anatolij Gustschin @ 2020-05-30 16:01 ` Soeren Moch 0 siblings, 0 replies; 15+ messages in thread From: Soeren Moch @ 2020-05-30 16:01 UTC (permalink / raw) To: u-boot On 28.05.20 10:07, Anatolij Gustschin wrote: > On Thu, 28 May 2020 09:54:42 +0200 > Soeren Moch smoch at web.de wrote: > ... >>> I'll merge this via u-boot-video tree. v2 patch depends on a few more >>> video patches which are under review/built-test currently. >> OK, I will try to test this new version again on top of your other patches. > OK, you could use 'dm_video-imx6' branch in my repo: > https://gitlab.denx.de/u-boot/custodians/u-boot-video/-/commits/dm_video-imx6 > > All required patches are already integrated there. Still works as expected. The tbs2910-patch already has my tested-by, I could not find this series as a whole to send a tag for this. >> Do you plan to merge this for v2020.07, or for -next? > For v2020.07 it is too late, Tom suggested to merge this for -next. OK, thanks, Soeren ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2020-07-01 13:01 UTC | newest] Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-05-22 23:24 [PATCH] tbs2910: migrate to DM_VIDEO Anatolij Gustschin 2020-05-23 7:55 ` Soeren Moch 2020-05-23 15:11 ` [PATCH] video: extend stdout video console work-around for 'vga' Anatolij Gustschin 2020-05-24 15:21 ` Soeren Moch 2020-05-25 2:14 ` Simon Glass 2020-05-26 18:08 ` Tom Rini 2020-06-19 13:55 ` Anatolij Gustschin 2020-07-01 13:01 ` Patrick DELAUNAY 2020-05-23 15:17 ` [PATCH] tbs2910: migrate to DM_VIDEO Anatolij Gustschin 2020-05-23 15:31 ` Soeren Moch 2020-05-24 15:46 ` Soeren Moch 2020-05-26 20:13 ` Anatolij Gustschin 2020-05-28 7:54 ` Soeren Moch 2020-05-28 8:07 ` Anatolij Gustschin 2020-05-30 16:01 ` Soeren Moch
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.