[PATCH 1/2] pmic: pca9450: add DM_I2C dependencies in Kconfig

[PATCH 1/2] pmic: pca9450: add DM_I2C dependencies in Kconfig

[Rasmus Villemoes]

The pca9450 driver uses dm_i2c_{read,write}, which
are (unsurprisingly) only available with DM_I2C. Make sure one can't
create an unbuildable .config by adding proper dependencies.

While here, append "in SPL" to the prompt for the SPL_ variant so it
doesn't read the same as the one for the non-SPL_ variant.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
 drivers/power/pmic/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/power/pmic/Kconfig b/drivers/power/pmic/Kconfig
index 953c92e212..6c534aead7 100644
--- a/drivers/power/pmic/Kconfig
+++ b/drivers/power/pmic/Kconfig
@@ -158,13 +158,15 @@ config SPL_DM_PMIC_MP5416
 
 config DM_PMIC_PCA9450
 	bool "Enable Driver Model for PMIC PCA9450"
+	depends on DM_I2C
 	help
 	  This config enables implementation of driver-model pmic uclass features
 	  for PMIC PCA9450. The driver implements read/write operations.
 
 config SPL_DM_PMIC_PCA9450
-	bool "Enable Driver Model for PMIC PCA9450"
+	bool "Enable Driver Model for PMIC PCA9450 in SPL"
 	depends on SPL_DM_PMIC
+	depends on SPL_DM_I2C
 	help
 	  This config enables implementation of driver-model pmic uclass features
 	  for PMIC PCA9450 in SPL. The driver implements read/write operations.
-- 
2.31.1

[PATCH 2/2] pmic: pca9450: drop pointless .data entries

[Rasmus Villemoes]

These are the i2c addresses of the chips, but that comes from device
tree. Having that information duplicated here just adds confusion.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
 drivers/power/pmic/pca9450.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/power/pmic/pca9450.c b/drivers/power/pmic/pca9450.c
index 2394b196c5..34cee34dba 100644
--- a/drivers/power/pmic/pca9450.c
+++ b/drivers/power/pmic/pca9450.c
@@ -81,9 +81,9 @@ static struct dm_pmic_ops pca9450_ops = {
 };
 
 static const struct udevice_id pca9450_ids[] = {
-	{ .compatible = "nxp,pca9450a", .data = 0x25, },
-	{ .compatible = "nxp,pca9450b", .data = 0x25, },
-	{ .compatible = "nxp,pca9450c", .data = 0x25, },
+	{ .compatible = "nxp,pca9450a" },
+	{ .compatible = "nxp,pca9450b" },
+	{ .compatible = "nxp,pca9450c" },
 	{ }
 };
 
-- 
2.31.1

Re: [PATCH 1/2] pmic: pca9450: add DM_I2C dependencies in Kconfig

[Jaehoon Chung]

On 5/3/22 17:58, Rasmus Villemoes wrote:
> The pca9450 driver uses dm_i2c_{read,write}, which
> are (unsurprisingly) only available with DM_I2C. Make sure one can't
> create an unbuildable .config by adding proper dependencies.
> 
> While here, append "in SPL" to the prompt for the SPL_ variant so it
> doesn't read the same as the one for the non-SPL_ variant.
> 
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> ---
>  drivers/power/pmic/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/power/pmic/Kconfig b/drivers/power/pmic/Kconfig
> index 953c92e212..6c534aead7 100644
> --- a/drivers/power/pmic/Kconfig
> +++ b/drivers/power/pmic/Kconfig
> @@ -158,13 +158,15 @@ config SPL_DM_PMIC_MP5416
>  
>  config DM_PMIC_PCA9450
>  	bool "Enable Driver Model for PMIC PCA9450"
> +	depends on DM_I2C
>  	help
>  	  This config enables implementation of driver-model pmic uclass features
>  	  for PMIC PCA9450. The driver implements read/write operations.
>  
>  config SPL_DM_PMIC_PCA9450
> -	bool "Enable Driver Model for PMIC PCA9450"
> +	bool "Enable Driver Model for PMIC PCA9450 in SPL"
>  	depends on SPL_DM_PMIC
> +	depends on SPL_DM_I2C
>  	help
>  	  This config enables implementation of driver-model pmic uclass features
>  	  for PMIC PCA9450 in SPL. The driver implements read/write operations.

Re: [PATCH 2/2] pmic: pca9450: drop pointless .data entries

[Jaehoon Chung]

On 5/3/22 17:58, Rasmus Villemoes wrote:
> These are the i2c addresses of the chips, but that comes from device
> tree. Having that information duplicated here just adds confusion.
> 
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>


Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> ---
>  drivers/power/pmic/pca9450.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/power/pmic/pca9450.c b/drivers/power/pmic/pca9450.c
> index 2394b196c5..34cee34dba 100644
> --- a/drivers/power/pmic/pca9450.c
> +++ b/drivers/power/pmic/pca9450.c
> @@ -81,9 +81,9 @@ static struct dm_pmic_ops pca9450_ops = {
>  };
>  
>  static const struct udevice_id pca9450_ids[] = {
> -	{ .compatible = "nxp,pca9450a", .data = 0x25, },
> -	{ .compatible = "nxp,pca9450b", .data = 0x25, },
> -	{ .compatible = "nxp,pca9450c", .data = 0x25, },
> +	{ .compatible = "nxp,pca9450a" },
> +	{ .compatible = "nxp,pca9450b" },
> +	{ .compatible = "nxp,pca9450c" },
>  	{ }
>  };
>  

Re: [PATCH 2/2] pmic: pca9450: drop pointless .data entries

[Jaehoon Chung]

Dear Rasums,

On 5/17/22 08:44, Jaehoon Chung wrote:
> On 5/3/22 17:58, Rasmus Villemoes wrote:
>> These are the i2c addresses of the chips, but that comes from device
>> tree. Having that information duplicated here just adds confusion.
>>
>> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>

There is a conflict with commit 326337fb005f968911d897867d09d1228b070d84.
Could you send the patch again? Sorry for too late.

Best Regards,
Jaehoon Chung

> 
> 
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
> 
> Best Regards,
> Jaehoon Chung
> 
>> ---
>>  drivers/power/pmic/pca9450.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/power/pmic/pca9450.c b/drivers/power/pmic/pca9450.c
>> index 2394b196c5..34cee34dba 100644
>> --- a/drivers/power/pmic/pca9450.c
>> +++ b/drivers/power/pmic/pca9450.c
>> @@ -81,9 +81,9 @@ static struct dm_pmic_ops pca9450_ops = {
>>  };
>>  
>>  static const struct udevice_id pca9450_ids[] = {
>> -	{ .compatible = "nxp,pca9450a", .data = 0x25, },
>> -	{ .compatible = "nxp,pca9450b", .data = 0x25, },
>> -	{ .compatible = "nxp,pca9450c", .data = 0x25, },
>> +	{ .compatible = "nxp,pca9450a" },
>> +	{ .compatible = "nxp,pca9450b" },
>> +	{ .compatible = "nxp,pca9450c" },
>>  	{ }
>>  };
>>  
> 
> 

Re: [PATCH 2/2] pmic: pca9450: drop pointless .data entries

[Rasmus Villemoes]

On 02/06/2022 02.30, Jaehoon Chung wrote:
> Dear Rasums,
> 
> On 5/17/22 08:44, Jaehoon Chung wrote:
>> On 5/3/22 17:58, Rasmus Villemoes wrote:
>>> These are the i2c addresses of the chips, but that comes from device
>>> tree. Having that information duplicated here just adds confusion.
>>>
>>> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> 
> There is a conflict with commit 326337fb005f968911d897867d09d1228b070d84.
> Could you send the patch again? Sorry for too late.

Oh, but that commit repurposes the .data member - or rather, "purposes",
but I don't think that's a real verb. Previously the driver_data wasn't
used for anything, but it is now.

So my patch should simply be dropped.

Rasmus

Re: [PATCH 2/2] pmic: pca9450: drop pointless .data entries

[Jaehoon Chung]

On 6/2/22 21:30, Rasmus Villemoes wrote:
> On 02/06/2022 02.30, Jaehoon Chung wrote:
>> Dear Rasums,
>>
>> On 5/17/22 08:44, Jaehoon Chung wrote:
>>> On 5/3/22 17:58, Rasmus Villemoes wrote:
>>>> These are the i2c addresses of the chips, but that comes from device
>>>> tree. Having that information duplicated here just adds confusion.
>>>>
>>>> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
>>
>> There is a conflict with commit 326337fb005f968911d897867d09d1228b070d84.
>> Could you send the patch again? Sorry for too late.
> 
> Oh, but that commit repurposes the .data member - or rather, "purposes",
> but I don't think that's a real verb. Previously the driver_data wasn't
> used for anything, but it is now.
> 
> So my patch should simply be dropped.

Okay. Thanks!

Best Regards,
Jaehoon Chung

> 
> Rasmus
>