* [PATCH] mmc: ftsdc010: make command timeout 250 ms as in the comment
@ 2022-09-02 7:40 Sergei Antonov
[not found] ` <HK0PR03MB299427578088D127EA94F428C17F9@HK0PR03MB2994.apcprd03.prod.outlook.com>
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sergei Antonov @ 2022-09-02 7:40 UTC (permalink / raw)
To: u-boot; +Cc: jh80.chung, peng.fan, yamada.masahiro, sjg, rick, Sergei Antonov
Get rid of discrepancy beween comment /* 250 ms */ and code
which shifts by 4 thus dividing by 16.
So change code to shift by 2 and make the timeout value 250 ms.
Signed-off-by: Sergei Antonov <saproj@gmail.com>
---
drivers/mmc/ftsdc010_mci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/ftsdc010_mci.c b/drivers/mmc/ftsdc010_mci.c
index 570d54cf9d8f..cabb747fbbdb 100644
--- a/drivers/mmc/ftsdc010_mci.c
+++ b/drivers/mmc/ftsdc010_mci.c
@@ -30,7 +30,7 @@
#include <syscon.h>
#include <linux/err.h>
-#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 4) /* 250 ms */
+#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 2) /* 250 ms */
#define CFG_RST_TIMEOUT CONFIG_SYS_HZ /* 1 sec reset timeout */
#if CONFIG_IS_ENABLED(OF_PLATDATA)
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <HK0PR03MB299427578088D127EA94F428C17F9@HK0PR03MB2994.apcprd03.prod.outlook.com>]
* Re: [PATCH] mmc: ftsdc010: make command timeout 250 ms as in the comment
[not found] ` <HK0PR03MB299427578088D127EA94F428C17F9@HK0PR03MB2994.apcprd03.prod.outlook.com>
@ 2022-09-05 0:53 ` Rick Chen
0 siblings, 0 replies; 4+ messages in thread
From: Rick Chen @ 2022-09-05 0:53 UTC (permalink / raw)
To: saproj
Cc: U-Boot Mailing List, jh80.chung, Peng Fan, Masahiro Yamada,
Simon Glass, Leo Liang, rick
> From: Sergei Antonov <saproj@gmail.com>
> Sent: Friday, September 02, 2022 3:40 PM
> To: u-boot@lists.denx.de
> Cc: jh80.chung@samsung.com; peng.fan@nxp.com; yamada.masahiro@socionext.com; sjg@chromium.org; Rick Jian-Zhi Chen(陳建志) <rick@andestech.com>; Sergei Antonov <saproj@gmail.com>
> Subject: [PATCH] mmc: ftsdc010: make command timeout 250 ms as in the comment
>
> Get rid of discrepancy beween comment /* 250 ms */ and code which shifts by 4 thus dividing by 16.
> So change code to shift by 2 and make the timeout value 250 ms.
>
> Signed-off-by: Sergei Antonov <saproj@gmail.com>
> ---
> drivers/mmc/ftsdc010_mci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/ftsdc010_mci.c b/drivers/mmc/ftsdc010_mci.c index 570d54cf9d8f..cabb747fbbdb 100644
> --- a/drivers/mmc/ftsdc010_mci.c
> +++ b/drivers/mmc/ftsdc010_mci.c
> @@ -30,7 +30,7 @@
> #include <syscon.h>
> #include <linux/err.h>
>
> -#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 4) /* 250 ms */
> +#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 2) /* 250 ms */
Reviewed-by: Rick Chen <rick@andestech.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: ftsdc010: make command timeout 250 ms as in the comment
2022-09-02 7:40 [PATCH] mmc: ftsdc010: make command timeout 250 ms as in the comment Sergei Antonov
[not found] ` <HK0PR03MB299427578088D127EA94F428C17F9@HK0PR03MB2994.apcprd03.prod.outlook.com>
@ 2022-09-08 11:20 ` Jaehoon Chung
[not found] ` <CGME20221025000026epcas1p148f488302b641e18797d7874962ca264@epcas1p1.samsung.com>
2 siblings, 0 replies; 4+ messages in thread
From: Jaehoon Chung @ 2022-09-08 11:20 UTC (permalink / raw)
To: Sergei Antonov, u-boot; +Cc: jh80.chung, peng.fan, yamada.masahiro, sjg, rick
Hi
On 9/2/22 16:40, Sergei Antonov wrote:
> Get rid of discrepancy beween comment /* 250 ms */ and code
> which shifts by 4 thus dividing by 16.
> So change code to shift by 2 and make the timeout value 250 ms.
>
> Signed-off-by: Sergei Antonov <saproj@gmail.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/ftsdc010_mci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/ftsdc010_mci.c b/drivers/mmc/ftsdc010_mci.c
> index 570d54cf9d8f..cabb747fbbdb 100644
> --- a/drivers/mmc/ftsdc010_mci.c
> +++ b/drivers/mmc/ftsdc010_mci.c
> @@ -30,7 +30,7 @@
> #include <syscon.h>
> #include <linux/err.h>
>
> -#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 4) /* 250 ms */
> +#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 2) /* 250 ms */
> #define CFG_RST_TIMEOUT CONFIG_SYS_HZ /* 1 sec reset timeout */
>
> #if CONFIG_IS_ENABLED(OF_PLATDATA)
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <CGME20221025000026epcas1p148f488302b641e18797d7874962ca264@epcas1p1.samsung.com>]
* Re: [PATCH] mmc: ftsdc010: make command timeout 250 ms as in the comment
[not found] ` <CGME20221025000026epcas1p148f488302b641e18797d7874962ca264@epcas1p1.samsung.com>
@ 2022-10-25 0:00 ` Jaehoon Chung
0 siblings, 0 replies; 4+ messages in thread
From: Jaehoon Chung @ 2022-10-25 0:00 UTC (permalink / raw)
To: Sergei Antonov, u-boot; +Cc: peng.fan, yamada.masahiro, sjg, rick
On 9/2/22 16:40, Sergei Antonov wrote:
> Get rid of discrepancy beween comment /* 250 ms */ and code
> which shifts by 4 thus dividing by 16.
> So change code to shift by 2 and make the timeout value 250 ms.
>
> Signed-off-by: Sergei Antonov <saproj@gmail.com>
> Reviewed-by: Rick Chen <rick@andestech.com>
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Applied to u-boot-mmc. Thanks!
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/ftsdc010_mci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/ftsdc010_mci.c b/drivers/mmc/ftsdc010_mci.c
> index 570d54cf9d8f..cabb747fbbdb 100644
> --- a/drivers/mmc/ftsdc010_mci.c
> +++ b/drivers/mmc/ftsdc010_mci.c
> @@ -30,7 +30,7 @@
> #include <syscon.h>
> #include <linux/err.h>
>
> -#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 4) /* 250 ms */
> +#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 2) /* 250 ms */
> #define CFG_RST_TIMEOUT CONFIG_SYS_HZ /* 1 sec reset timeout */
>
> #if CONFIG_IS_ENABLED(OF_PLATDATA)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-25 0:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-02 7:40 [PATCH] mmc: ftsdc010: make command timeout 250 ms as in the comment Sergei Antonov
[not found] ` <HK0PR03MB299427578088D127EA94F428C17F9@HK0PR03MB2994.apcprd03.prod.outlook.com>
2022-09-05 0:53 ` Rick Chen
2022-09-08 11:20 ` Jaehoon Chung
[not found] ` <CGME20221025000026epcas1p148f488302b641e18797d7874962ca264@epcas1p1.samsung.com>
2022-10-25 0:00 ` Jaehoon Chung
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.