From: Takashi Iwai <tiwai@suse.de> To: David Henningsson <david.henningsson@canonical.com> Cc: Thierry Reding <thierry.reding@avionic-design.de>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ALSA: hda - Deferred probing with request_firmware_nowait() Date: Thu, 09 Aug 2012 15:32:20 +0200 [thread overview] Message-ID: <s5h4noc2ntn.wl%tiwai@suse.de> (raw) In-Reply-To: <5023BAA0.1080304@canonical.com> At Thu, 09 Aug 2012 15:26:56 +0200, David Henningsson wrote: > > On 08/09/2012 03:11 PM, Takashi Iwai wrote: > > > @@ -3187,13 +3217,16 @@ static int __devinit azx_probe(struct pci_dev *pci, > > if (patch[dev] && *patch[dev]) { > > snd_printk(KERN_ERR SFX "Applying patch firmware '%s'\n", > > patch[dev]); > > - err = request_firmware(&chip->fw, patch[dev], &pci->dev); > > + err = request_firmware_nowait(THIS_MODULE, true, patch[dev], > > + &pci->dev, GFP_KERNEL, card, > > + azx_firmware_cb); > > if (err < 0) > > goto out_free; > > + chip->probe_deferred = 1; > > I might be out on deep water here, but isn't this racy? Or is > azx_firmware_cb somehow guaranteed not to execute before this function > has exited? chip->probe_deferred is used only at the line below. So basically it's not necessarily to be recorded in chip, but could be a local bool variable in azx_probe(). It remains in chip just because of my older patch had it. > > > } > > #endif /* CONFIG_SND_HDA_PATCH_LOADER */ > > > > - if (!chip->disabled) { > > + if (!chip->disabled && !chip->probe_deferred) { Here it's checked. Takashi > > err = azx_probe_continue(chip); > > if (err < 0) > > goto out_free; > > > > > > -- > David Henningsson, Canonical Ltd. > https://launchpad.net/~diwic >
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de> To: David Henningsson <david.henningsson@canonical.com> Cc: alsa-devel@alsa-project.org, Thierry Reding <thierry.reding@avionic-design.de>, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ALSA: hda - Deferred probing with request_firmware_nowait() Date: Thu, 09 Aug 2012 15:32:20 +0200 [thread overview] Message-ID: <s5h4noc2ntn.wl%tiwai@suse.de> (raw) In-Reply-To: <5023BAA0.1080304@canonical.com> At Thu, 09 Aug 2012 15:26:56 +0200, David Henningsson wrote: > > On 08/09/2012 03:11 PM, Takashi Iwai wrote: > > > @@ -3187,13 +3217,16 @@ static int __devinit azx_probe(struct pci_dev *pci, > > if (patch[dev] && *patch[dev]) { > > snd_printk(KERN_ERR SFX "Applying patch firmware '%s'\n", > > patch[dev]); > > - err = request_firmware(&chip->fw, patch[dev], &pci->dev); > > + err = request_firmware_nowait(THIS_MODULE, true, patch[dev], > > + &pci->dev, GFP_KERNEL, card, > > + azx_firmware_cb); > > if (err < 0) > > goto out_free; > > + chip->probe_deferred = 1; > > I might be out on deep water here, but isn't this racy? Or is > azx_firmware_cb somehow guaranteed not to execute before this function > has exited? chip->probe_deferred is used only at the line below. So basically it's not necessarily to be recorded in chip, but could be a local bool variable in azx_probe(). It remains in chip just because of my older patch had it. > > > } > > #endif /* CONFIG_SND_HDA_PATCH_LOADER */ > > > > - if (!chip->disabled) { > > + if (!chip->disabled && !chip->probe_deferred) { Here it's checked. Takashi > > err = azx_probe_continue(chip); > > if (err < 0) > > goto out_free; > > > > > > -- > David Henningsson, Canonical Ltd. > https://launchpad.net/~diwic >
next prev parent reply other threads:[~2012-08-09 13:32 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-09 6:45 [PATCH] ALSA: hda - Defer probe when loading patch firmware Thierry Reding 2012-08-09 6:45 ` Thierry Reding 2012-08-09 6:57 ` Takashi Iwai 2012-08-09 6:57 ` Takashi Iwai 2012-08-09 7:08 ` Thierry Reding 2012-08-09 7:08 ` Thierry Reding 2012-08-09 7:31 ` Takashi Iwai 2012-08-09 7:31 ` Takashi Iwai 2012-08-09 7:36 ` Thierry Reding 2012-08-09 7:36 ` Thierry Reding 2012-08-09 7:42 ` Takashi Iwai 2012-08-09 7:42 ` Takashi Iwai 2012-08-09 7:50 ` Takashi Iwai 2012-08-09 7:50 ` Takashi Iwai 2012-08-09 7:57 ` Thierry Reding 2012-08-09 7:57 ` Thierry Reding 2012-08-09 8:07 ` Thierry Reding 2012-08-09 8:07 ` Thierry Reding 2012-08-09 8:21 ` Takashi Iwai 2012-08-09 8:21 ` Takashi Iwai 2012-08-09 9:19 ` Takashi Iwai 2012-08-09 9:19 ` Takashi Iwai 2012-08-09 10:34 ` Thierry Reding 2012-08-09 10:34 ` Thierry Reding 2012-08-09 12:32 ` Takashi Iwai 2012-08-09 12:32 ` Takashi Iwai 2012-08-09 12:49 ` Thierry Reding 2012-08-09 12:49 ` Thierry Reding 2012-08-09 13:06 ` Takashi Iwai 2012-08-09 13:06 ` Takashi Iwai 2012-08-09 13:09 ` [PATCH 0/2] HD-audio firmware loading fixes Takashi Iwai 2012-08-09 13:10 ` [PATCH 1/2] ALSA: hda - Load firmware in hda_intel.c Takashi Iwai 2012-08-09 14:26 ` Thierry Reding 2012-08-09 14:26 ` Thierry Reding 2012-08-09 13:11 ` [PATCH 2/2] ALSA: hda - Deferred probing with request_firmware_nowait() Takashi Iwai 2012-08-09 13:26 ` David Henningsson 2012-08-09 13:32 ` Takashi Iwai [this message] 2012-08-09 13:32 ` Takashi Iwai 2012-08-09 13:36 ` [PATCH 2/2 v2] " Takashi Iwai 2012-08-09 13:36 ` Takashi Iwai 2012-08-09 13:54 ` David Henningsson 2012-08-09 13:54 ` David Henningsson 2012-08-09 14:04 ` Thierry Reding 2012-08-09 14:04 ` Thierry Reding 2012-08-09 14:04 ` Takashi Iwai 2012-08-09 14:04 ` Takashi Iwai 2012-08-09 14:10 ` [PATCH 2/2 v3] " Takashi Iwai 2012-08-09 14:10 ` Takashi Iwai 2012-08-09 14:19 ` David Henningsson 2012-08-09 14:19 ` David Henningsson 2012-08-09 14:25 ` Thierry Reding 2012-08-09 14:25 ` Thierry Reding 2012-08-09 14:34 ` Takashi Iwai 2012-08-09 14:34 ` Takashi Iwai 2012-08-09 14:38 ` Thierry Reding 2012-08-09 14:38 ` Thierry Reding
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=s5h4noc2ntn.wl%tiwai@suse.de \ --to=tiwai@suse.de \ --cc=alsa-devel@alsa-project.org \ --cc=david.henningsson@canonical.com \ --cc=linux-kernel@vger.kernel.org \ --cc=thierry.reding@avionic-design.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.