From: John Fastabend <firstname.lastname@example.org> To: Jakub Sitnicki <email@example.com>, firstname.lastname@example.org Cc: John Fastabend <email@example.com>, Martin KaFai Lau <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org Subject: RE: [RFC bpf-next 0/5] Extend SOCKMAP to store listening sockets Date: Thu, 24 Oct 2019 09:56:08 -0700 [thread overview] Message-ID: <5db1d7a810bdb_5c282ada047205c08f@john-XPS-13-9370.notmuch> (raw) In-Reply-To: <email@example.com> Jakub Sitnicki wrote: > This patch set is a follow up on a suggestion from LPC '19 discussions to > make SOCKMAP (or a new map type derived from it) a generic type for storing > established as well as listening sockets. > > We found ourselves in need of a map type that keeps references to listening > sockets when working on making the socket lookup programmable, aka BPF > inet_lookup . Initially we repurposed REUSEPORT_SOCKARRAY but found it > problematic to extend due to being tightly coupled with reuseport > logic (see slides ). So we've turned our attention to SOCKMAP instead. > > As it turns out the changes needed to make SOCKMAP suitable for storing > listening sockets are self-contained and have use outside of programming > the socket lookup. Hence this patch set. > > With these patches SOCKMAP can be used in SK_REUSEPORT BPF programs as a > drop-in replacement for REUSEPORT_SOCKARRAY for TCP. This can hopefully > lead to code consolidation between the two map types in the future. > > Having said that, the main intention here is to lay groundwork for using > SOCKMAP in the next iteration of programmable socket lookup patches. > > I'm looking for feedback if there's anything fundamentally wrong with > extending SOCKMAP map type like this that I might have missed. I think this looks good. The main reason I blocked it off before is mostly because I had no use-case for it and the complication with what to do with child sockets. Clearing the psock state seems OK to me if user wants to add it back to a map they can simply grab it again from a sockops event. By the way I would eventually like to see the lookup hook return the correct type (PTR_TO_SOCKET_OR_NULL) so that the verifier "knows" the type and the socket can be used the same as if it was pulled from a sk_lookup helper. > > Thanks, > Jakub > >  https://firstname.lastname@example.org/ >  https://linuxplumbersconf.org/event/4/contributions/487/attachments/238/417/Programmable_socket_lookup_LPC_19.pdf >
next prev parent reply other threads:[~2019-10-24 16:56 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-22 11:37 Jakub Sitnicki 2019-10-22 11:37 ` [RFC bpf-next 1/5] bpf, sockmap: Let BPF helpers use lookup operation on SOCKMAP Jakub Sitnicki 2019-10-24 16:59 ` John Fastabend 2019-10-22 11:37 ` [RFC bpf-next 2/5] bpf, sockmap: Allow inserting listening TCP sockets into SOCKMAP Jakub Sitnicki 2019-10-24 17:06 ` John Fastabend 2019-10-25 9:41 ` Jakub Sitnicki 2019-10-22 11:37 ` [RFC bpf-next 3/5] bpf, sockmap: Don't let child socket inherit psock or its ops on copy Jakub Sitnicki 2019-10-22 11:37 ` [RFC bpf-next 4/5] bpf: Allow selecting reuseport socket from a SOCKMAP Jakub Sitnicki 2019-10-22 11:37 ` [RFC bpf-next 5/5] selftests/bpf: Extend SK_REUSEPORT tests to cover SOCKMAP Jakub Sitnicki 2019-10-24 16:12 ` [RFC bpf-next 0/5] Extend SOCKMAP to store listening sockets Alexei Starovoitov 2019-10-24 16:56 ` John Fastabend [this message] 2019-10-25 9:26 ` Jakub Sitnicki 2019-10-25 14:18 ` John Fastabend 2019-10-28 5:52 ` Martin Lau 2019-10-28 12:35 ` Jakub Sitnicki 2019-10-28 19:04 ` John Fastabend 2019-10-29 8:56 ` Jakub Sitnicki 2019-10-28 20:42 ` Martin Lau 2019-10-28 21:05 ` John Fastabend 2019-10-28 21:38 ` Martin Lau 2019-10-29 8:52 ` Jakub Sitnicki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5db1d7a810bdb_5c282ada047205c08f@john-XPS-13-9370.notmuch \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='RE: [RFC bpf-next 0/5] Extend SOCKMAP to store listening sockets' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).