From: Larry Finger <Larry.Finger@lwfinger.net>
To: Aditya Jain <aditya.jainadityajain.jain@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, hdegoede@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: include: Fix coding style errors
Date: Sun, 26 Jul 2020 13:03:57 -0500 [thread overview]
Message-ID: <da3da8d5-7227-ad65-1449-de9fb46561c7@lwfinger.net> (raw)
In-Reply-To: <CAJAoDUjVBon2iiztdER82mHgJtVS6s5XYSajbCTne0KWAzoLvg@mail.gmail.com>
On 7/26/20 3:40 AM, Aditya Jain wrote:
> On Sun, Jul 26, 2020 at 1:56 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>>
>> On Sun, Jul 26, 2020 at 01:32:15PM +0530, Aditya Jain wrote:
>>> Fixing ERROR: "foo * bar" should be "foo *bar" in hal_phy_cfg.h
>>> as reported by checkpatch.pl
>>>
>>> Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
>>> ---
>>> .../staging/rtl8723bs/include/hal_phy_cfg.h | 18 +++++++++---------
>>> 1 file changed, 9 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
>>> index 419ddb0733aa..fd5f377bad4f 100644
>>> --- a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
>>> +++ b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
>>> @@ -42,7 +42,7 @@ u32 Data
>>>
>>> u32
>>> PHY_QueryRFReg_8723B(
>>> -struct adapter * Adapter,
>>> +struct adapter *Adapter,
>>> u8 eRFPath,
>>> u32 RegAddr,
>>> u32 BitMask
>>
>> Ick, these are all horrid. How about just making these all on a single
>> line like most functions have them instead of this one cleanup?
>>
>> Same for the other changes you made in this file.
>>
>> thanks,
>>
>> greg k-h
>
> Agreed. I'll clean it up.
While you are at it, drop the "include;" from the subject. For staging, the
usual subject is of the form "staging: driver: thing being done". In your case
"staging: rtl8723bs: Fix coding style errors". The directory of the files are
not relevant.
I am also not in favor of the large white space between the variable type and
the name, but that is probably the subject of separate patches.
Larry
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-07-26 18:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 8:02 [PATCH] staging: rtl8723bs: include: Fix coding style errors Aditya Jain
2020-07-26 8:26 ` Greg KH
2020-07-26 8:40 ` Aditya Jain
2020-07-26 10:53 ` [PATCH v2] staging: rtl8723bs: include: Fix coding style issues Aditya Jain
2020-07-26 10:59 ` Greg KH
2020-07-26 14:18 ` Fix code style issues in staging Aditya Jain
2020-07-26 14:20 ` [PATCH v3 1/4] staging: rtl8723bs: include: Fix coding style errors Aditya Jain
2020-07-26 14:20 ` [PATCH v3 2/4] staging: rtl8723bs: include: Clean up function declations Aditya Jain
2020-07-26 14:20 ` [PATCH v3 3/4] staging: rtl8723bs: include: Further clean up function declarations Aditya Jain
2020-07-26 15:02 ` Greg KH
2020-07-26 17:15 ` Joe Perches
2020-07-26 18:15 ` Aditya Jain
2020-07-28 20:03 ` Aditya Jain
2020-07-26 14:20 ` [PATCH v3 4/4] staging: rtl8723bs: include: Align macro definitions Aditya Jain
2020-07-26 18:03 ` Larry Finger [this message]
2020-07-26 18:29 ` [PATCH] staging: rtl8723bs: include: Fix coding style errors Aditya Jain
2020-07-29 19:21 ` [PATCH v4 0/3] Fix coding style issues in staging Aditya Jain
2020-07-29 19:21 ` [PATCH v4 1/3] staging: rtl8723bs: Fix coding style errors Aditya Jain
2020-07-29 19:21 ` [PATCH v4 2/3] staging: rtl8723bs: Clean up function declations Aditya Jain
2020-07-29 19:21 ` [PATCH v4 3/3] staging: rtl8723bs: Align macro definitions Aditya Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da3da8d5-7227-ad65-1449-de9fb46561c7@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=aditya.jainadityajain.jain@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).