From: Greg KH <gregkh@linuxfoundation.org>
To: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
Cc: devel@driverdev.osuosl.org, hdegoede@redhat.com,
linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net
Subject: Re: [PATCH v3 3/4] staging: rtl8723bs: include: Further clean up function declarations
Date: Sun, 26 Jul 2020 17:02:44 +0200 [thread overview]
Message-ID: <20200726150244.GD452766@kroah.com> (raw)
In-Reply-To: <20200726142013.2891-3-aditya.jainadityajain.jain@gmail.com>
On Sun, Jul 26, 2020 at 07:50:12PM +0530, Aditya Jain wrote:
> Cleaning up messy multiline function declarations in hal_phy_cfg.h
>
> This patch is a continuation of patch "Clean up function declarations"
This should be merged with that patch, no reason to make it separate.
>
> Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
> ---
> .../staging/rtl8723bs/include/hal_phy_cfg.h | 56 ++++++-------------
> 1 file changed, 16 insertions(+), 40 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
> index 3cec06e9f359..2b059c9c7851 100644
> --- a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
> +++ b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
> @@ -46,49 +46,25 @@ s32 PHY_MACConfig8723B(struct adapter *padapter);
> void PHY_SetTxPowerIndex(struct adapter *Adapter, u32 PowerIndex,
> u8 RFPath, u8 Rate);
>
> -u8
> -PHY_GetTxPowerIndex(
> -struct adapter *padapter,
> -u8 RFPath,
> -u8 Rate,
> -enum CHANNEL_WIDTH BandWidth,
> -u8 Channel
> - );
> -
> -void
> -PHY_GetTxPowerLevel8723B(
> -struct adapter *Adapter,
> - s32 *powerlevel
> - );
> -
> -void
> -PHY_SetTxPowerLevel8723B(
> -struct adapter *Adapter,
> -u8 channel
> - );
> -
> -void
> -PHY_SetBWMode8723B(
> -struct adapter *Adapter,
> -enum CHANNEL_WIDTH Bandwidth, /* 20M or 40M */
> -unsigned char Offset /* Upper, Lower, or Don't care */
> -);
> +u8 PHY_GetTxPowerIndex(struct adapter *padapter, u8 RFPath, u8 Rate,
> + enum CHANNEL_WIDTH BandWidth, u8 Channel);
> +
> +void PHY_GetTxPowerLevel8723B(struct adapter *Adapter, s32 *powerlevel);
> +
> +void PHY_SetTxPowerLevel8723B(struct adapter *Adapter, u8 channel);
>
> -void
> -PHY_SwChnl8723B(/* Call after initialization */
> -struct adapter *Adapter,
> -u8 channel
> - );
> -
> -void
> -PHY_SetSwChnlBWMode8723B(
> -struct adapter *Adapter,
> -u8 channel,
> -enum CHANNEL_WIDTH Bandwidth,
> -u8 Offset40,
> -u8 Offset80
> +void PHY_SetBWMode8723B(struct adapter *Adapter,
> + enum CHANNEL_WIDTH Bandwidth, /* 20M or 40M */
> + unsigned char Offset /* Upper, Lower, or Don't care */
Those comments should go at the top of the function declaration, in
kernel doc format.
thanks
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-07-26 15:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 8:02 [PATCH] staging: rtl8723bs: include: Fix coding style errors Aditya Jain
2020-07-26 8:26 ` Greg KH
2020-07-26 8:40 ` Aditya Jain
2020-07-26 10:53 ` [PATCH v2] staging: rtl8723bs: include: Fix coding style issues Aditya Jain
2020-07-26 10:59 ` Greg KH
2020-07-26 14:18 ` Fix code style issues in staging Aditya Jain
2020-07-26 14:20 ` [PATCH v3 1/4] staging: rtl8723bs: include: Fix coding style errors Aditya Jain
2020-07-26 14:20 ` [PATCH v3 2/4] staging: rtl8723bs: include: Clean up function declations Aditya Jain
2020-07-26 14:20 ` [PATCH v3 3/4] staging: rtl8723bs: include: Further clean up function declarations Aditya Jain
2020-07-26 15:02 ` Greg KH [this message]
2020-07-26 17:15 ` Joe Perches
2020-07-26 18:15 ` Aditya Jain
2020-07-28 20:03 ` Aditya Jain
2020-07-26 14:20 ` [PATCH v3 4/4] staging: rtl8723bs: include: Align macro definitions Aditya Jain
2020-07-26 18:03 ` [PATCH] staging: rtl8723bs: include: Fix coding style errors Larry Finger
2020-07-26 18:29 ` Aditya Jain
2020-07-29 19:21 ` [PATCH v4 0/3] Fix coding style issues in staging Aditya Jain
2020-07-29 19:21 ` [PATCH v4 1/3] staging: rtl8723bs: Fix coding style errors Aditya Jain
2020-07-29 19:21 ` [PATCH v4 2/3] staging: rtl8723bs: Clean up function declations Aditya Jain
2020-07-29 19:21 ` [PATCH v4 3/3] staging: rtl8723bs: Align macro definitions Aditya Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200726150244.GD452766@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=aditya.jainadityajain.jain@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).