git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Optimize the description of the configuration in packfile-uris doc
@ 2021-05-06  7:33 Teng Long
  2021-05-06 16:47 ` Jonathan Tan
  2021-05-13  7:15 ` Teng Long
  0 siblings, 2 replies; 13+ messages in thread
From: Teng Long @ 2021-05-06  7:33 UTC (permalink / raw)
  To: git; +Cc: jonathantanmy, Teng Long

There is a description problem in the document about packfile-uris. This
patch describes the configuration format of `uploadpack.blobPackfileUri`
more accurately.

Signed-off-by: Teng Long <dyroneteng@gmail.com>
---
 Documentation/technical/packfile-uri.txt | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/Documentation/technical/packfile-uri.txt b/Documentation/technical/packfile-uri.txt
index f7eabc6c76..1eb525fe76 100644
--- a/Documentation/technical/packfile-uri.txt
+++ b/Documentation/technical/packfile-uri.txt
@@ -35,13 +35,14 @@ include some sort of non-trivial implementation in the Minimum Viable Product,
 at least so that we can test the client.
 
 This is the implementation: a feature, marked experimental, that allows the
-server to be configured by one or more `uploadpack.blobPackfileUri=<sha1>
-<uri>` entries. Whenever the list of objects to be sent is assembled, all such
-blobs are excluded, replaced with URIs. As noted in "Future work" below, the
-server can evolve in the future to support excluding other objects (or other
-implementations of servers could be made that support excluding other objects)
-without needing a protocol change, so clients should not expect that packfiles
-downloaded in this way only contain single blobs.
+server to be configured by one or more `uploadpack.blobPackfileUri=
+<object-hash> <pack-hash> <uri>` entries. Whenever the list of objects to be
+sent is assembled, all such blobs are excluded, replaced with URIs. As noted
+in "Future work" below, the server can evolve in the future to support
+excluding other objects (or other implementations of servers could be made
+that support excluding other objects) without needing a protocol change, so
+clients should not expect that packfiles downloaded in this way only contain
+single blobs.
 
 Client design
 -------------
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* Re: [PATCH v2] packfile-uri.txt: fix blobPackfileUri description
@ 2021-05-13  6:44 Teng Long
  0 siblings, 0 replies; 13+ messages in thread
From: Teng Long @ 2021-05-13  6:44 UTC (permalink / raw)
  To: gitster; +Cc: dyroneteng, git, jonathantanmy

Junio C Hamano writes:

>Yes.  Some people seem to omit the final response to reviewer
>suggestions on the previous round and just send a revised patch, but
>it is much nicer to cleanly conclude the review cycle for the
>previous round with a separate response (it could just be "yes,
>you're right---I'll incorporate your suggestions in the next round,
>thanks") before starting a new cycle.

If I  send a new patch cycle, the "--thread"  argument seems
to be recommended. This may be the reason why it is easier
to understand when submitting a series of patches?

I may try to use "--thread", but it may make this whole
patch more confusing, sorry for that.

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2021-05-25  0:34 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-06  7:33 [PATCH] Optimize the description of the configuration in packfile-uris doc Teng Long
2021-05-06 16:47 ` Jonathan Tan
2021-05-06 21:39   ` Junio C Hamano
2021-05-11  6:45     ` [PATCH v2] packfile-uri.txt: fix blobPackfileUri description Teng Long
2021-05-11 20:50       ` Junio C Hamano
2021-05-12 14:10         ` Long Teng
2021-05-12 23:32           ` Junio C Hamano
2021-05-13  7:15 ` Teng Long
2021-05-13 21:33   ` Junio C Hamano
2021-05-18  0:44     ` Junio C Hamano
2021-05-24 15:43       ` Jonathan Tan
2021-05-25  0:34         ` Junio C Hamano
2021-05-13  6:44 [PATCH v2] " Teng Long

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).