* [PATCH v2 0/4] Reenable VFIO support on POWER systems
@ 2023-03-06 17:29 Timothy Pearson
2023-03-06 23:46 ` Alex Williamson
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Timothy Pearson @ 2023-03-06 17:29 UTC (permalink / raw)
To: kvm; +Cc: linuxppc-dev
This patch series reenables VFIO support on POWER systems. It
is based on Alexey Kardashevskiys's patch series, rebased and
successfully tested under QEMU with a Marvell PCIe SATA controller
on a POWER9 Blackbird host.
Alexey Kardashevskiy (3):
powerpc/iommu: Add "borrowing" iommu_table_group_ops
powerpc/pci_64: Init pcibios subsys a bit later
powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
domains
Timothy Pearson (1):
Add myself to MAINTAINERS for Power VFIO support
MAINTAINERS | 5 +
arch/powerpc/include/asm/iommu.h | 6 +-
arch/powerpc/include/asm/pci-bridge.h | 7 +
arch/powerpc/kernel/iommu.c | 246 +++++++++++++++++++++-
arch/powerpc/kernel/pci_64.c | 2 +-
arch/powerpc/platforms/powernv/pci-ioda.c | 36 +++-
arch/powerpc/platforms/pseries/iommu.c | 27 +++
arch/powerpc/platforms/pseries/pseries.h | 4 +
arch/powerpc/platforms/pseries/setup.c | 3 +
drivers/vfio/vfio_iommu_spapr_tce.c | 96 ++-------
10 files changed, 338 insertions(+), 94 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
2023-03-06 17:29 [PATCH v2 0/4] Reenable VFIO support on POWER systems Timothy Pearson
@ 2023-03-06 23:46 ` Alex Williamson
2023-03-07 0:35 ` Timothy Pearson
` (2 more replies)
2023-03-09 11:40 ` Michael Ellerman
2023-03-23 6:49 ` Narayana Murty
2 siblings, 3 replies; 14+ messages in thread
From: Alex Williamson @ 2023-03-06 23:46 UTC (permalink / raw)
To: Timothy Pearson; +Cc: kvm, linuxppc-dev
On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
Timothy Pearson <tpearson@raptorengineering.com> wrote:
> This patch series reenables VFIO support on POWER systems. It
> is based on Alexey Kardashevskiys's patch series, rebased and
> successfully tested under QEMU with a Marvell PCIe SATA controller
> on a POWER9 Blackbird host.
>
> Alexey Kardashevskiy (3):
> powerpc/iommu: Add "borrowing" iommu_table_group_ops
> powerpc/pci_64: Init pcibios subsys a bit later
> powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
> domains
>
> Timothy Pearson (1):
> Add myself to MAINTAINERS for Power VFIO support
>
> MAINTAINERS | 5 +
> arch/powerpc/include/asm/iommu.h | 6 +-
> arch/powerpc/include/asm/pci-bridge.h | 7 +
> arch/powerpc/kernel/iommu.c | 246 +++++++++++++++++++++-
> arch/powerpc/kernel/pci_64.c | 2 +-
> arch/powerpc/platforms/powernv/pci-ioda.c | 36 +++-
> arch/powerpc/platforms/pseries/iommu.c | 27 +++
> arch/powerpc/platforms/pseries/pseries.h | 4 +
> arch/powerpc/platforms/pseries/setup.c | 3 +
> drivers/vfio/vfio_iommu_spapr_tce.c | 96 ++-------
> 10 files changed, 338 insertions(+), 94 deletions(-)
>
For vfio and MAINTAINERS portions,
Acked-by: Alex Williamson <alex.williamson@redhat.com>
I'll note though that spapr_tce_take_ownership() looks like it copied a
bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map
are tested before calling iommu_take_ownership() but not in the unwind
loop, ie. tables we might have skipped on setup are unconditionally
released on unwind. Thanks,
Alex
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
2023-03-06 23:46 ` Alex Williamson
@ 2023-03-07 0:35 ` Timothy Pearson
2023-03-07 0:59 ` Alex Williamson
2023-03-07 0:51 ` Alexey Kardashevskiy
2023-03-09 11:38 ` Michael Ellerman
2 siblings, 1 reply; 14+ messages in thread
From: Timothy Pearson @ 2023-03-07 0:35 UTC (permalink / raw)
To: Alex Williamson; +Cc: Timothy Pearson, kvm, linuxppc-dev
----- Original Message -----
> From: "Alex Williamson" <alex.williamson@redhat.com>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>
> Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> Sent: Monday, March 6, 2023 5:46:07 PM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
> On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
> Timothy Pearson <tpearson@raptorengineering.com> wrote:
>
>> This patch series reenables VFIO support on POWER systems. It
>> is based on Alexey Kardashevskiys's patch series, rebased and
>> successfully tested under QEMU with a Marvell PCIe SATA controller
>> on a POWER9 Blackbird host.
>>
>> Alexey Kardashevskiy (3):
>> powerpc/iommu: Add "borrowing" iommu_table_group_ops
>> powerpc/pci_64: Init pcibios subsys a bit later
>> powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>> domains
>>
>> Timothy Pearson (1):
>> Add myself to MAINTAINERS for Power VFIO support
>>
>> MAINTAINERS | 5 +
>> arch/powerpc/include/asm/iommu.h | 6 +-
>> arch/powerpc/include/asm/pci-bridge.h | 7 +
>> arch/powerpc/kernel/iommu.c | 246 +++++++++++++++++++++-
>> arch/powerpc/kernel/pci_64.c | 2 +-
>> arch/powerpc/platforms/powernv/pci-ioda.c | 36 +++-
>> arch/powerpc/platforms/pseries/iommu.c | 27 +++
>> arch/powerpc/platforms/pseries/pseries.h | 4 +
>> arch/powerpc/platforms/pseries/setup.c | 3 +
>> drivers/vfio/vfio_iommu_spapr_tce.c | 96 ++-------
>> 10 files changed, 338 insertions(+), 94 deletions(-)
>>
>
> For vfio and MAINTAINERS portions,
>
> Acked-by: Alex Williamson <alex.williamson@redhat.com>
>
> I'll note though that spapr_tce_take_ownership() looks like it copied a
> bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map
> are tested before calling iommu_take_ownership() but not in the unwind
> loop, ie. tables we might have skipped on setup are unconditionally
> released on unwind. Thanks,
>
> Alex
Thanks for that. I'll put together a patch to get rid of that potential bug that can be applied after this series is merged, unless you'd rather I resubmit a v3 with the issue fixed?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
2023-03-06 23:46 ` Alex Williamson
2023-03-07 0:35 ` Timothy Pearson
@ 2023-03-07 0:51 ` Alexey Kardashevskiy
2023-03-09 11:38 ` Michael Ellerman
2 siblings, 0 replies; 14+ messages in thread
From: Alexey Kardashevskiy @ 2023-03-07 0:51 UTC (permalink / raw)
To: Alex Williamson, Timothy Pearson; +Cc: linuxppc-dev, kvm
On 07/03/2023 10:46, Alex Williamson wrote:
> On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
> Timothy Pearson <tpearson@raptorengineering.com> wrote:
>
>> This patch series reenables VFIO support on POWER systems. It
>> is based on Alexey Kardashevskiys's patch series, rebased and
>> successfully tested under QEMU with a Marvell PCIe SATA controller
>> on a POWER9 Blackbird host.
>>
>> Alexey Kardashevskiy (3):
>> powerpc/iommu: Add "borrowing" iommu_table_group_ops
>> powerpc/pci_64: Init pcibios subsys a bit later
>> powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>> domains
>>
>> Timothy Pearson (1):
>> Add myself to MAINTAINERS for Power VFIO support
>>
>> MAINTAINERS | 5 +
>> arch/powerpc/include/asm/iommu.h | 6 +-
>> arch/powerpc/include/asm/pci-bridge.h | 7 +
>> arch/powerpc/kernel/iommu.c | 246 +++++++++++++++++++++-
>> arch/powerpc/kernel/pci_64.c | 2 +-
>> arch/powerpc/platforms/powernv/pci-ioda.c | 36 +++-
>> arch/powerpc/platforms/pseries/iommu.c | 27 +++
>> arch/powerpc/platforms/pseries/pseries.h | 4 +
>> arch/powerpc/platforms/pseries/setup.c | 3 +
>> drivers/vfio/vfio_iommu_spapr_tce.c | 96 ++-------
>> 10 files changed, 338 insertions(+), 94 deletions(-)
>>
>
> For vfio and MAINTAINERS portions,
>
> Acked-by: Alex Williamson <alex.williamson@redhat.com>
>
> I'll note though that spapr_tce_take_ownership() looks like it copied a
> bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map
> are tested before calling iommu_take_ownership() but not in the unwind
> loop, ie. tables we might have skipped on setup are unconditionally
> released on unwind. Thanks,
Ah, true, a bug. Thanks for pointing out.
--
Alexey
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
2023-03-07 0:35 ` Timothy Pearson
@ 2023-03-07 0:59 ` Alex Williamson
2023-03-07 23:04 ` Timothy Pearson
0 siblings, 1 reply; 14+ messages in thread
From: Alex Williamson @ 2023-03-07 0:59 UTC (permalink / raw)
To: Timothy Pearson; +Cc: kvm, linuxppc-dev
On Mon, 6 Mar 2023 18:35:22 -0600 (CST)
Timothy Pearson <tpearson@raptorengineering.com> wrote:
> ----- Original Message -----
> > From: "Alex Williamson" <alex.williamson@redhat.com>
> > To: "Timothy Pearson" <tpearson@raptorengineering.com>
> > Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> > Sent: Monday, March 6, 2023 5:46:07 PM
> > Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>
> > On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
> > Timothy Pearson <tpearson@raptorengineering.com> wrote:
> >
> >> This patch series reenables VFIO support on POWER systems. It
> >> is based on Alexey Kardashevskiys's patch series, rebased and
> >> successfully tested under QEMU with a Marvell PCIe SATA controller
> >> on a POWER9 Blackbird host.
> >>
> >> Alexey Kardashevskiy (3):
> >> powerpc/iommu: Add "borrowing" iommu_table_group_ops
> >> powerpc/pci_64: Init pcibios subsys a bit later
> >> powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
> >> domains
> >>
> >> Timothy Pearson (1):
> >> Add myself to MAINTAINERS for Power VFIO support
> >>
> >> MAINTAINERS | 5 +
> >> arch/powerpc/include/asm/iommu.h | 6 +-
> >> arch/powerpc/include/asm/pci-bridge.h | 7 +
> >> arch/powerpc/kernel/iommu.c | 246 +++++++++++++++++++++-
> >> arch/powerpc/kernel/pci_64.c | 2 +-
> >> arch/powerpc/platforms/powernv/pci-ioda.c | 36 +++-
> >> arch/powerpc/platforms/pseries/iommu.c | 27 +++
> >> arch/powerpc/platforms/pseries/pseries.h | 4 +
> >> arch/powerpc/platforms/pseries/setup.c | 3 +
> >> drivers/vfio/vfio_iommu_spapr_tce.c | 96 ++-------
> >> 10 files changed, 338 insertions(+), 94 deletions(-)
> >>
> >
> > For vfio and MAINTAINERS portions,
> >
> > Acked-by: Alex Williamson <alex.williamson@redhat.com>
> >
> > I'll note though that spapr_tce_take_ownership() looks like it copied a
> > bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map
> > are tested before calling iommu_take_ownership() but not in the unwind
> > loop, ie. tables we might have skipped on setup are unconditionally
> > released on unwind. Thanks,
> >
> > Alex
>
> Thanks for that. I'll put together a patch to get rid of that
> potential bug that can be applied after this series is merged, unless
> you'd rather I resubmit a v3 with the issue fixed?
Follow-up fix is fine by me. Thanks,
Alex
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
2023-03-07 0:59 ` Alex Williamson
@ 2023-03-07 23:04 ` Timothy Pearson
0 siblings, 0 replies; 14+ messages in thread
From: Timothy Pearson @ 2023-03-07 23:04 UTC (permalink / raw)
To: Alex Williamson; +Cc: kvm, linuxppc-dev
----- Original Message -----
> From: "Alex Williamson" <alex.williamson@redhat.com>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>
> Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> Sent: Monday, March 6, 2023 6:59:41 PM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
> On Mon, 6 Mar 2023 18:35:22 -0600 (CST)
> Timothy Pearson <tpearson@raptorengineering.com> wrote:
>
>> ----- Original Message -----
>> > From: "Alex Williamson" <alex.williamson@redhat.com>
>> > To: "Timothy Pearson" <tpearson@raptorengineering.com>
>> > Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>> > Sent: Monday, March 6, 2023 5:46:07 PM
>> > Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>>
>> > On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
>> > Timothy Pearson <tpearson@raptorengineering.com> wrote:
>> >
>> >> This patch series reenables VFIO support on POWER systems. It
>> >> is based on Alexey Kardashevskiys's patch series, rebased and
>> >> successfully tested under QEMU with a Marvell PCIe SATA controller
>> >> on a POWER9 Blackbird host.
>> >>
>> >> Alexey Kardashevskiy (3):
>> >> powerpc/iommu: Add "borrowing" iommu_table_group_ops
>> >> powerpc/pci_64: Init pcibios subsys a bit later
>> >> powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>> >> domains
>> >>
>> >> Timothy Pearson (1):
>> >> Add myself to MAINTAINERS for Power VFIO support
>> >>
>> >> MAINTAINERS | 5 +
>> >> arch/powerpc/include/asm/iommu.h | 6 +-
>> >> arch/powerpc/include/asm/pci-bridge.h | 7 +
>> >> arch/powerpc/kernel/iommu.c | 246 +++++++++++++++++++++-
>> >> arch/powerpc/kernel/pci_64.c | 2 +-
>> >> arch/powerpc/platforms/powernv/pci-ioda.c | 36 +++-
>> >> arch/powerpc/platforms/pseries/iommu.c | 27 +++
>> >> arch/powerpc/platforms/pseries/pseries.h | 4 +
>> >> arch/powerpc/platforms/pseries/setup.c | 3 +
>> >> drivers/vfio/vfio_iommu_spapr_tce.c | 96 ++-------
>> >> 10 files changed, 338 insertions(+), 94 deletions(-)
>> >>
>> >
>> > For vfio and MAINTAINERS portions,
>> >
>> > Acked-by: Alex Williamson <alex.williamson@redhat.com>
>> >
>> > I'll note though that spapr_tce_take_ownership() looks like it copied a
>> > bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map
>> > are tested before calling iommu_take_ownership() but not in the unwind
>> > loop, ie. tables we might have skipped on setup are unconditionally
>> > released on unwind. Thanks,
>> >
>> > Alex
>>
>> Thanks for that. I'll put together a patch to get rid of that
>> potential bug that can be applied after this series is merged, unless
>> you'd rather I resubmit a v3 with the issue fixed?
>
> Follow-up fix is fine by me. Thanks,
>
> Alex
Just sent that patch in. Thanks!
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
2023-03-06 23:46 ` Alex Williamson
2023-03-07 0:35 ` Timothy Pearson
2023-03-07 0:51 ` Alexey Kardashevskiy
@ 2023-03-09 11:38 ` Michael Ellerman
2 siblings, 0 replies; 14+ messages in thread
From: Michael Ellerman @ 2023-03-09 11:38 UTC (permalink / raw)
To: Alex Williamson, Timothy Pearson; +Cc: linuxppc-dev, kvm
Alex Williamson <alex.williamson@redhat.com> writes:
> On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
> Timothy Pearson <tpearson@raptorengineering.com> wrote:
>
>> This patch series reenables VFIO support on POWER systems. It
>> is based on Alexey Kardashevskiys's patch series, rebased and
>> successfully tested under QEMU with a Marvell PCIe SATA controller
>> on a POWER9 Blackbird host.
>>
>> Alexey Kardashevskiy (3):
>> powerpc/iommu: Add "borrowing" iommu_table_group_ops
>> powerpc/pci_64: Init pcibios subsys a bit later
>> powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>> domains
>>
>> Timothy Pearson (1):
>> Add myself to MAINTAINERS for Power VFIO support
>>
>> MAINTAINERS | 5 +
>> arch/powerpc/include/asm/iommu.h | 6 +-
>> arch/powerpc/include/asm/pci-bridge.h | 7 +
>> arch/powerpc/kernel/iommu.c | 246 +++++++++++++++++++++-
>> arch/powerpc/kernel/pci_64.c | 2 +-
>> arch/powerpc/platforms/powernv/pci-ioda.c | 36 +++-
>> arch/powerpc/platforms/pseries/iommu.c | 27 +++
>> arch/powerpc/platforms/pseries/pseries.h | 4 +
>> arch/powerpc/platforms/pseries/setup.c | 3 +
>> drivers/vfio/vfio_iommu_spapr_tce.c | 96 ++-------
>> 10 files changed, 338 insertions(+), 94 deletions(-)
>>
>
> For vfio and MAINTAINERS portions,
>
> Acked-by: Alex Williamson <alex.williamson@redhat.com>
Thanks.
cheers
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
2023-03-06 17:29 [PATCH v2 0/4] Reenable VFIO support on POWER systems Timothy Pearson
2023-03-06 23:46 ` Alex Williamson
@ 2023-03-09 11:40 ` Michael Ellerman
2023-03-09 19:28 ` Timothy Pearson
2023-03-23 6:49 ` Narayana Murty
2 siblings, 1 reply; 14+ messages in thread
From: Michael Ellerman @ 2023-03-09 11:40 UTC (permalink / raw)
To: Timothy Pearson, kvm; +Cc: linuxppc-dev
Timothy Pearson <tpearson@raptorengineering.com> writes:
> This patch series reenables VFIO support on POWER systems. It
> is based on Alexey Kardashevskiys's patch series, rebased and
> successfully tested under QEMU with a Marvell PCIe SATA controller
> on a POWER9 Blackbird host.
>
> Alexey Kardashevskiy (3):
> powerpc/iommu: Add "borrowing" iommu_table_group_ops
> powerpc/pci_64: Init pcibios subsys a bit later
> powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
> domains
As sent the patches had lost Alexey's authorship (no From: line), I
fixed it up when applying so the first 3 are authored by Alexey.
cheers
> Timothy Pearson (1):
> Add myself to MAINTAINERS for Power VFIO support
>
> MAINTAINERS | 5 +
> arch/powerpc/include/asm/iommu.h | 6 +-
> arch/powerpc/include/asm/pci-bridge.h | 7 +
> arch/powerpc/kernel/iommu.c | 246 +++++++++++++++++++++-
> arch/powerpc/kernel/pci_64.c | 2 +-
> arch/powerpc/platforms/powernv/pci-ioda.c | 36 +++-
> arch/powerpc/platforms/pseries/iommu.c | 27 +++
> arch/powerpc/platforms/pseries/pseries.h | 4 +
> arch/powerpc/platforms/pseries/setup.c | 3 +
> drivers/vfio/vfio_iommu_spapr_tce.c | 96 ++-------
> 10 files changed, 338 insertions(+), 94 deletions(-)
>
> --
> 2.30.2
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
2023-03-09 11:40 ` Michael Ellerman
@ 2023-03-09 19:28 ` Timothy Pearson
2023-03-18 19:06 ` Timothy Pearson
0 siblings, 1 reply; 14+ messages in thread
From: Timothy Pearson @ 2023-03-09 19:28 UTC (permalink / raw)
To: Michael Ellerman; +Cc: Timothy Pearson, kvm, linuxppc-dev
----- Original Message -----
> From: "Michael Ellerman" <mpe@ellerman.id.au>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm" <kvm@vger.kernel.org>
> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> Sent: Thursday, March 9, 2023 5:40:01 AM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
> Timothy Pearson <tpearson@raptorengineering.com> writes:
>> This patch series reenables VFIO support on POWER systems. It
>> is based on Alexey Kardashevskiys's patch series, rebased and
>> successfully tested under QEMU with a Marvell PCIe SATA controller
>> on a POWER9 Blackbird host.
>>
>> Alexey Kardashevskiy (3):
>> powerpc/iommu: Add "borrowing" iommu_table_group_ops
>> powerpc/pci_64: Init pcibios subsys a bit later
>> powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>> domains
>
> As sent the patches had lost Alexey's authorship (no From: line), I
> fixed it up when applying so the first 3 are authored by Alexey.
>
> cheers
Thanks for catching that, it wasn't intentional. Probably used a wrong Git command...
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
2023-03-09 19:28 ` Timothy Pearson
@ 2023-03-18 19:06 ` Timothy Pearson
2023-03-21 10:33 ` Michael Ellerman
0 siblings, 1 reply; 14+ messages in thread
From: Timothy Pearson @ 2023-03-18 19:06 UTC (permalink / raw)
To: Timothy Pearson; +Cc: Michael Ellerman, kvm, linuxppc-dev
----- Original Message -----
> From: "Timothy Pearson" <tpearson@raptorengineering.com>
> To: "Michael Ellerman" <mpe@ellerman.id.au>
> Cc: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm" <kvm@vger.kernel.org>, "linuxppc-dev"
> <linuxppc-dev@lists.ozlabs.org>
> Sent: Thursday, March 9, 2023 1:28:20 PM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
> ----- Original Message -----
>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>> <kvm@vger.kernel.org>
>> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>> Sent: Thursday, March 9, 2023 5:40:01 AM
>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>
>> Timothy Pearson <tpearson@raptorengineering.com> writes:
>>> This patch series reenables VFIO support on POWER systems. It
>>> is based on Alexey Kardashevskiys's patch series, rebased and
>>> successfully tested under QEMU with a Marvell PCIe SATA controller
>>> on a POWER9 Blackbird host.
>>>
>>> Alexey Kardashevskiy (3):
>>> powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>> powerpc/pci_64: Init pcibios subsys a bit later
>>> powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>> domains
>>
>> As sent the patches had lost Alexey's authorship (no From: line), I
>> fixed it up when applying so the first 3 are authored by Alexey.
>>
>> cheers
>
> Thanks for catching that, it wasn't intentional. Probably used a wrong Git
> command...
Just wanted to touch base on the patches, since they're still listed as Under Review on patchwork. Are we good to go for the 6.4 merge window?
Thanks!
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
2023-03-18 19:06 ` Timothy Pearson
@ 2023-03-21 10:33 ` Michael Ellerman
2023-03-21 13:18 ` Timothy Pearson
0 siblings, 1 reply; 14+ messages in thread
From: Michael Ellerman @ 2023-03-21 10:33 UTC (permalink / raw)
To: Timothy Pearson, Timothy Pearson; +Cc: kvm, linuxppc-dev
Timothy Pearson <tpearson@raptorengineering.com> writes:
> ----- Original Message -----
>> From: "Timothy Pearson" <tpearson@raptorengineering.com>
>> To: "Michael Ellerman" <mpe@ellerman.id.au>
>> Cc: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm" <kvm@vger.kernel.org>, "linuxppc-dev"
>> <linuxppc-dev@lists.ozlabs.org>
>> Sent: Thursday, March 9, 2023 1:28:20 PM
>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>
>> ----- Original Message -----
>>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>>> <kvm@vger.kernel.org>
>>> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>>> Sent: Thursday, March 9, 2023 5:40:01 AM
>>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>>
>>> Timothy Pearson <tpearson@raptorengineering.com> writes:
>>>> This patch series reenables VFIO support on POWER systems. It
>>>> is based on Alexey Kardashevskiys's patch series, rebased and
>>>> successfully tested under QEMU with a Marvell PCIe SATA controller
>>>> on a POWER9 Blackbird host.
>>>>
>>>> Alexey Kardashevskiy (3):
>>>> powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>>> powerpc/pci_64: Init pcibios subsys a bit later
>>>> powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>>> domains
>>>
>>> As sent the patches had lost Alexey's authorship (no From: line), I
>>> fixed it up when applying so the first 3 are authored by Alexey.
>>>
>>> cheers
>>
>> Thanks for catching that, it wasn't intentional. Probably used a wrong Git
>> command...
>
> Just wanted to touch base on the patches, since they're still listed as Under Review on patchwork. Are we good to go for the 6.4 merge window?
They've been in my next (and so linux-next), since last week. I just
haven't updated patchwork yet.
So yeah they are on track to go into mainline during the v6.4 merge window.
cheers
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
2023-03-21 10:33 ` Michael Ellerman
@ 2023-03-21 13:18 ` Timothy Pearson
2023-03-21 21:43 ` Michael Ellerman
0 siblings, 1 reply; 14+ messages in thread
From: Timothy Pearson @ 2023-03-21 13:18 UTC (permalink / raw)
To: Michael Ellerman; +Cc: Timothy Pearson, kvm, linuxppc-dev
----- Original Message -----
> From: "Michael Ellerman" <mpe@ellerman.id.au>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "Timothy Pearson" <tpearson@raptorengineering.com>
> Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> Sent: Tuesday, March 21, 2023 5:33:57 AM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
> Timothy Pearson <tpearson@raptorengineering.com> writes:
>> ----- Original Message -----
>>> From: "Timothy Pearson" <tpearson@raptorengineering.com>
>>> To: "Michael Ellerman" <mpe@ellerman.id.au>
>>> Cc: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>>> <kvm@vger.kernel.org>, "linuxppc-dev"
>>> <linuxppc-dev@lists.ozlabs.org>
>>> Sent: Thursday, March 9, 2023 1:28:20 PM
>>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>>
>>> ----- Original Message -----
>>>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>>>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>>>> <kvm@vger.kernel.org>
>>>> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>>>> Sent: Thursday, March 9, 2023 5:40:01 AM
>>>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>>>
>>>> Timothy Pearson <tpearson@raptorengineering.com> writes:
>>>>> This patch series reenables VFIO support on POWER systems. It
>>>>> is based on Alexey Kardashevskiys's patch series, rebased and
>>>>> successfully tested under QEMU with a Marvell PCIe SATA controller
>>>>> on a POWER9 Blackbird host.
>>>>>
>>>>> Alexey Kardashevskiy (3):
>>>>> powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>>>> powerpc/pci_64: Init pcibios subsys a bit later
>>>>> powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>>>> domains
>>>>
>>>> As sent the patches had lost Alexey's authorship (no From: line), I
>>>> fixed it up when applying so the first 3 are authored by Alexey.
>>>>
>>>> cheers
>>>
>>> Thanks for catching that, it wasn't intentional. Probably used a wrong Git
>>> command...
>>
>> Just wanted to touch base on the patches, since they're still listed as Under
>> Review on patchwork. Are we good to go for the 6.4 merge window?
>
> They've been in my next (and so linux-next), since last week. I just
> haven't updated patchwork yet.
>
> So yeah they are on track to go into mainline during the v6.4 merge window.
>
> cheers
Sounds great, thanks! Saw them in the next tree but wasn't sure if the patchwork status was more reflective of overall status.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
2023-03-21 13:18 ` Timothy Pearson
@ 2023-03-21 21:43 ` Michael Ellerman
0 siblings, 0 replies; 14+ messages in thread
From: Michael Ellerman @ 2023-03-21 21:43 UTC (permalink / raw)
To: Timothy Pearson; +Cc: Timothy Pearson, kvm, linuxppc-dev
Timothy Pearson <tpearson@raptorengineering.com> writes:
> ----- Original Message -----
>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "Timothy Pearson" <tpearson@raptorengineering.com>
>> Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>> Sent: Tuesday, March 21, 2023 5:33:57 AM
>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>
>> Timothy Pearson <tpearson@raptorengineering.com> writes:
>>> ----- Original Message -----
>>>> From: "Timothy Pearson" <tpearson@raptorengineering.com>
>>>> To: "Michael Ellerman" <mpe@ellerman.id.au>
>>>> Cc: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>>>> <kvm@vger.kernel.org>, "linuxppc-dev"
>>>> <linuxppc-dev@lists.ozlabs.org>
>>>> Sent: Thursday, March 9, 2023 1:28:20 PM
>>>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>>>
>>>> ----- Original Message -----
>>>>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>>>>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>>>>> <kvm@vger.kernel.org>
>>>>> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>>>>> Sent: Thursday, March 9, 2023 5:40:01 AM
>>>>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>>>>
>>>>> Timothy Pearson <tpearson@raptorengineering.com> writes:
>>>>>> This patch series reenables VFIO support on POWER systems. It
>>>>>> is based on Alexey Kardashevskiys's patch series, rebased and
>>>>>> successfully tested under QEMU with a Marvell PCIe SATA controller
>>>>>> on a POWER9 Blackbird host.
>>>>>>
>>>>>> Alexey Kardashevskiy (3):
>>>>>> powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>>>>> powerpc/pci_64: Init pcibios subsys a bit later
>>>>>> powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>>>>> domains
>>>>>
>>>>> As sent the patches had lost Alexey's authorship (no From: line), I
>>>>> fixed it up when applying so the first 3 are authored by Alexey.
>>>>>
>>>>> cheers
>>>>
>>>> Thanks for catching that, it wasn't intentional. Probably used a wrong Git
>>>> command...
>>>
>>> Just wanted to touch base on the patches, since they're still listed as Under
>>> Review on patchwork. Are we good to go for the 6.4 merge window?
>>
>> They've been in my next (and so linux-next), since last week. I just
>> haven't updated patchwork yet.
>>
>> So yeah they are on track to go into mainline during the v6.4 merge window.
>>
>> cheers
>
> Sounds great, thanks! Saw them in the next tree but wasn't sure if the patchwork status was more reflective of overall status.
Yeah I guess patchwork is more reflective.
I sometimes put things in next for a few days to see if any issues shake
out, before I update patchwork. Mainly because it's a pain to un-update
patchwork if the patch needs to be backed out, but also as a signal that
the patch isn't quite locked into next yet.
cheers
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
2023-03-06 17:29 [PATCH v2 0/4] Reenable VFIO support on POWER systems Timothy Pearson
2023-03-06 23:46 ` Alex Williamson
2023-03-09 11:40 ` Michael Ellerman
@ 2023-03-23 6:49 ` Narayana Murty
2 siblings, 0 replies; 14+ messages in thread
From: Narayana Murty @ 2023-03-23 6:49 UTC (permalink / raw)
To: Timothy Pearson; +Cc: kvm, linuxppc-dev
On Mon, Mar 06, 2023 at 11:29:53AM -0600, Timothy Pearson wrote:
> This patch series reenables VFIO support on POWER systems. It
> is based on Alexey Kardashevskiys's patch series, rebased and
> successfully tested under QEMU with a Marvell PCIe SATA controller
> on a POWER9 Blackbird host.
>
> Alexey Kardashevskiy (3):
> powerpc/iommu: Add "borrowing" iommu_table_group_ops
> powerpc/pci_64: Init pcibios subsys a bit later
> powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
> domains
>
> Timothy Pearson (1):
> Add myself to MAINTAINERS for Power VFIO support
>
> MAINTAINERS | 5 +
> arch/powerpc/include/asm/iommu.h | 6 +-
> arch/powerpc/include/asm/pci-bridge.h | 7 +
> arch/powerpc/kernel/iommu.c | 246 +++++++++++++++++++++-
> arch/powerpc/kernel/pci_64.c | 2 +-
> arch/powerpc/platforms/powernv/pci-ioda.c | 36 +++-
> arch/powerpc/platforms/pseries/iommu.c | 27 +++
> arch/powerpc/platforms/pseries/pseries.h | 4 +
> arch/powerpc/platforms/pseries/setup.c | 3 +
> drivers/vfio/vfio_iommu_spapr_tce.c | 96 ++-------
> 10 files changed, 338 insertions(+), 94 deletions(-)
>
> --
> 2.30.2
The Alexey Kardashevskiy (3) patchs series tested on powerNV denali power9 system with
NetXtreme BCM5719 Gigabit Ethernet PCIe card.The vfio passthrough
is working fine
Tested-by : Narayana Murty <nnmlinux@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2023-03-23 6:50 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-06 17:29 [PATCH v2 0/4] Reenable VFIO support on POWER systems Timothy Pearson
2023-03-06 23:46 ` Alex Williamson
2023-03-07 0:35 ` Timothy Pearson
2023-03-07 0:59 ` Alex Williamson
2023-03-07 23:04 ` Timothy Pearson
2023-03-07 0:51 ` Alexey Kardashevskiy
2023-03-09 11:38 ` Michael Ellerman
2023-03-09 11:40 ` Michael Ellerman
2023-03-09 19:28 ` Timothy Pearson
2023-03-18 19:06 ` Timothy Pearson
2023-03-21 10:33 ` Michael Ellerman
2023-03-21 13:18 ` Timothy Pearson
2023-03-21 21:43 ` Michael Ellerman
2023-03-23 6:49 ` Narayana Murty
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).