* [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?
@ 2020-05-05 14:15 kbuild test robot
2020-05-05 14:50 ` David Hildenbrand
0 siblings, 1 reply; 9+ messages in thread
From: kbuild test robot @ 2020-05-05 14:15 UTC (permalink / raw)
To: David Hildenbrand
Cc: kbuild-all, kvm, virtualization, netdev, Michael S. Tsirkin,
Pankaj Gupta
[-- Attachment #1: Type: text/plain, Size: 3269 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head: da1742791d8c0c0a8e5471f181549c4726a5c5f9
commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug
config: x86_64-randconfig-b002-20200505 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe':
>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration]
vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
^~~~~~~
vzalloc
>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
^
>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
kfree(vm);
^~~~~
vfree
cc1: some warnings being treated as errors
vim +1375 drivers/virtio/virtio_mem.c
1369
1370 static int virtio_mem_probe(struct virtio_device *vdev)
1371 {
1372 struct virtio_mem *vm;
1373 int rc = -EINVAL;
1374
> 1375 vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
1376 if (!vm)
1377 return -ENOMEM;
1378
1379 init_waitqueue_head(&vm->host_resp);
1380 vm->vdev = vdev;
1381 INIT_WORK(&vm->wq, virtio_mem_run_wq);
1382 mutex_init(&vm->hotplug_mutex);
1383 INIT_LIST_HEAD(&vm->next);
1384 spin_lock_init(&vm->removal_lock);
1385 hrtimer_init(&vm->retry_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
1386 vm->retry_timer.function = virtio_mem_timer_expired;
1387
1388 /* register the virtqueue */
1389 rc = virtio_mem_init_vq(vm);
1390 if (rc)
1391 goto out_free_vm;
1392
1393 /* initialize the device by querying the config */
1394 rc = virtio_mem_init(vm);
1395 if (rc)
1396 goto out_del_vq;
1397
1398 /* register callbacks */
1399 vm->memory_notifier.notifier_call = virtio_mem_memory_notifier_cb;
1400 rc = register_memory_notifier(&vm->memory_notifier);
1401 if (rc)
1402 goto out_del_vq;
1403 rc = register_virtio_mem_device(vm);
1404 if (rc)
1405 goto out_unreg_mem;
1406
1407 virtio_device_ready(vdev);
1408
1409 /* trigger a config update to start processing the requested_size */
1410 atomic_set(&vm->config_changed, 1);
1411 queue_work(system_freezable_wq, &vm->wq);
1412
1413 return 0;
1414 out_unreg_mem:
1415 unregister_memory_notifier(&vm->memory_notifier);
1416 out_del_vq:
1417 vdev->config->del_vqs(vdev);
1418 out_free_vm:
> 1419 kfree(vm);
1420 vdev->priv = NULL;
1421
1422 return rc;
1423 }
1424
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29432 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?
2020-05-05 14:15 [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? kbuild test robot
@ 2020-05-05 14:50 ` David Hildenbrand
2020-05-05 15:44 ` Michael S. Tsirkin
0 siblings, 1 reply; 9+ messages in thread
From: David Hildenbrand @ 2020-05-05 14:50 UTC (permalink / raw)
To: kbuild test robot
Cc: kbuild-all, kvm, virtualization, netdev, Michael S. Tsirkin,
Pankaj Gupta
On 05.05.20 16:15, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
> head: da1742791d8c0c0a8e5471f181549c4726a5c5f9
> commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug
> config: x86_64-randconfig-b002-20200505 (attached as .config)
> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> reproduce:
> git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All error/warnings (new ones prefixed by >>):
>
> drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe':
>>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration]
> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
> ^~~~~~~
> vzalloc
>>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
> ^
>>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
> kfree(vm);
> ^~~~~
> vfree
> cc1: some warnings being treated as errors
>
> vim +1375 drivers/virtio/virtio_mem.c
Guess we simply need
#include <linux/slab.h>
to make it work for that config.
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?
2020-05-05 14:50 ` David Hildenbrand
@ 2020-05-05 15:44 ` Michael S. Tsirkin
2020-05-05 15:46 ` David Hildenbrand
0 siblings, 1 reply; 9+ messages in thread
From: Michael S. Tsirkin @ 2020-05-05 15:44 UTC (permalink / raw)
To: David Hildenbrand
Cc: kbuild test robot, kbuild-all, kvm, virtualization, netdev, Pankaj Gupta
On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote:
> On 05.05.20 16:15, kbuild test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
> > head: da1742791d8c0c0a8e5471f181549c4726a5c5f9
> > commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug
> > config: x86_64-randconfig-b002-20200505 (attached as .config)
> > compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> > reproduce:
> > git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0
> > # save the attached .config to linux build tree
> > make ARCH=x86_64
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kbuild test robot <lkp@intel.com>
> >
> > All error/warnings (new ones prefixed by >>):
> >
> > drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe':
> >>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration]
> > vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
> > ^~~~~~~
> > vzalloc
> >>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> > vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
> > ^
> >>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
> > kfree(vm);
> > ^~~~~
> > vfree
> > cc1: some warnings being treated as errors
> >
> > vim +1375 drivers/virtio/virtio_mem.c
>
> Guess we simply need
>
> #include <linux/slab.h>
>
> to make it work for that config.
OK I added that in the 1st commit that introduced virtio-mem.
> --
> Thanks,
>
> David / dhildenb
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?
2020-05-05 15:44 ` Michael S. Tsirkin
@ 2020-05-05 15:46 ` David Hildenbrand
2020-05-05 16:20 ` Michael S. Tsirkin
0 siblings, 1 reply; 9+ messages in thread
From: David Hildenbrand @ 2020-05-05 15:46 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: kbuild test robot, kbuild-all, kvm, virtualization, netdev, Pankaj Gupta
On 05.05.20 17:44, Michael S. Tsirkin wrote:
> On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote:
>> On 05.05.20 16:15, kbuild test robot wrote:
>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
>>> head: da1742791d8c0c0a8e5471f181549c4726a5c5f9
>>> commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug
>>> config: x86_64-randconfig-b002-20200505 (attached as .config)
>>> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
>>> reproduce:
>>> git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0
>>> # save the attached .config to linux build tree
>>> make ARCH=x86_64
>>>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kbuild test robot <lkp@intel.com>
>>>
>>> All error/warnings (new ones prefixed by >>):
>>>
>>> drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe':
>>>>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration]
>>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
>>> ^~~~~~~
>>> vzalloc
>>>>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
>>> ^
>>>>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
>>> kfree(vm);
>>> ^~~~~
>>> vfree
>>> cc1: some warnings being treated as errors
>>>
>>> vim +1375 drivers/virtio/virtio_mem.c
>>
>> Guess we simply need
>>
>> #include <linux/slab.h>
>>
>> to make it work for that config.
>
>
> OK I added that in the 1st commit that introduced virtio-mem.
Thanks. I have some addon-patches ready, what's the best way to continue
with these?
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?
2020-05-05 15:46 ` David Hildenbrand
@ 2020-05-05 16:20 ` Michael S. Tsirkin
2020-05-05 16:22 ` David Hildenbrand
0 siblings, 1 reply; 9+ messages in thread
From: Michael S. Tsirkin @ 2020-05-05 16:20 UTC (permalink / raw)
To: David Hildenbrand
Cc: kbuild test robot, kbuild-all, kvm, virtualization, netdev, Pankaj Gupta
On Tue, May 05, 2020 at 05:46:44PM +0200, David Hildenbrand wrote:
> On 05.05.20 17:44, Michael S. Tsirkin wrote:
> > On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote:
> >> On 05.05.20 16:15, kbuild test robot wrote:
> >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
> >>> head: da1742791d8c0c0a8e5471f181549c4726a5c5f9
> >>> commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug
> >>> config: x86_64-randconfig-b002-20200505 (attached as .config)
> >>> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> >>> reproduce:
> >>> git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0
> >>> # save the attached .config to linux build tree
> >>> make ARCH=x86_64
> >>>
> >>> If you fix the issue, kindly add following tag as appropriate
> >>> Reported-by: kbuild test robot <lkp@intel.com>
> >>>
> >>> All error/warnings (new ones prefixed by >>):
> >>>
> >>> drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe':
> >>>>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration]
> >>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
> >>> ^~~~~~~
> >>> vzalloc
> >>>>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> >>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
> >>> ^
> >>>>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
> >>> kfree(vm);
> >>> ^~~~~
> >>> vfree
> >>> cc1: some warnings being treated as errors
> >>>
> >>> vim +1375 drivers/virtio/virtio_mem.c
> >>
> >> Guess we simply need
> >>
> >> #include <linux/slab.h>
> >>
> >> to make it work for that config.
> >
> >
> > OK I added that in the 1st commit that introduced virtio-mem.
>
> Thanks. I have some addon-patches ready, what's the best way to continue
> with these?
If these are bugfixes, just respin the series (including this fix).
If these are more features, you can just post them on list noting "next" in
subject and saying "this is on top of vhost tree" after --.
I don't know how to make 0-day figure out where to apply such dependent
patches unfortunately.
>
> --
> Thanks,
>
> David / dhildenb
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?
2020-05-05 16:20 ` Michael S. Tsirkin
@ 2020-05-05 16:22 ` David Hildenbrand
2020-05-05 16:30 ` Michael S. Tsirkin
2020-05-06 20:28 ` Michael S. Tsirkin
0 siblings, 2 replies; 9+ messages in thread
From: David Hildenbrand @ 2020-05-05 16:22 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: kbuild test robot, kbuild-all, kvm, virtualization, netdev, Pankaj Gupta
On 05.05.20 18:20, Michael S. Tsirkin wrote:
> On Tue, May 05, 2020 at 05:46:44PM +0200, David Hildenbrand wrote:
>> On 05.05.20 17:44, Michael S. Tsirkin wrote:
>>> On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote:
>>>> On 05.05.20 16:15, kbuild test robot wrote:
>>>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
>>>>> head: da1742791d8c0c0a8e5471f181549c4726a5c5f9
>>>>> commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug
>>>>> config: x86_64-randconfig-b002-20200505 (attached as .config)
>>>>> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
>>>>> reproduce:
>>>>> git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0
>>>>> # save the attached .config to linux build tree
>>>>> make ARCH=x86_64
>>>>>
>>>>> If you fix the issue, kindly add following tag as appropriate
>>>>> Reported-by: kbuild test robot <lkp@intel.com>
>>>>>
>>>>> All error/warnings (new ones prefixed by >>):
>>>>>
>>>>> drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe':
>>>>>>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration]
>>>>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
>>>>> ^~~~~~~
>>>>> vzalloc
>>>>>>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>>>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
>>>>> ^
>>>>>>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
>>>>> kfree(vm);
>>>>> ^~~~~
>>>>> vfree
>>>>> cc1: some warnings being treated as errors
>>>>>
>>>>> vim +1375 drivers/virtio/virtio_mem.c
>>>>
>>>> Guess we simply need
>>>>
>>>> #include <linux/slab.h>
>>>>
>>>> to make it work for that config.
>>>
>>>
>>> OK I added that in the 1st commit that introduced virtio-mem.
>>
>> Thanks. I have some addon-patches ready, what's the best way to continue
>> with these?
>
> If these are bugfixes, just respin the series (including this fix).
There are two really minor bugfixes for corner-case error handling and
one simplification. I can squash them and resend, makes things easier.
The other stuff I have are extensions, I will send as add-on.
Thanks!
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?
2020-05-05 16:22 ` David Hildenbrand
@ 2020-05-05 16:30 ` Michael S. Tsirkin
2020-05-06 20:28 ` Michael S. Tsirkin
1 sibling, 0 replies; 9+ messages in thread
From: Michael S. Tsirkin @ 2020-05-05 16:30 UTC (permalink / raw)
To: David Hildenbrand
Cc: kbuild test robot, kbuild-all, kvm, virtualization, netdev, Pankaj Gupta
On Tue, May 05, 2020 at 06:22:51PM +0200, David Hildenbrand wrote:
> On 05.05.20 18:20, Michael S. Tsirkin wrote:
> > On Tue, May 05, 2020 at 05:46:44PM +0200, David Hildenbrand wrote:
> >> On 05.05.20 17:44, Michael S. Tsirkin wrote:
> >>> On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote:
> >>>> On 05.05.20 16:15, kbuild test robot wrote:
> >>>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
> >>>>> head: da1742791d8c0c0a8e5471f181549c4726a5c5f9
> >>>>> commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug
> >>>>> config: x86_64-randconfig-b002-20200505 (attached as .config)
> >>>>> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> >>>>> reproduce:
> >>>>> git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0
> >>>>> # save the attached .config to linux build tree
> >>>>> make ARCH=x86_64
> >>>>>
> >>>>> If you fix the issue, kindly add following tag as appropriate
> >>>>> Reported-by: kbuild test robot <lkp@intel.com>
> >>>>>
> >>>>> All error/warnings (new ones prefixed by >>):
> >>>>>
> >>>>> drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe':
> >>>>>>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration]
> >>>>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
> >>>>> ^~~~~~~
> >>>>> vzalloc
> >>>>>>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> >>>>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
> >>>>> ^
> >>>>>>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
> >>>>> kfree(vm);
> >>>>> ^~~~~
> >>>>> vfree
> >>>>> cc1: some warnings being treated as errors
> >>>>>
> >>>>> vim +1375 drivers/virtio/virtio_mem.c
> >>>>
> >>>> Guess we simply need
> >>>>
> >>>> #include <linux/slab.h>
> >>>>
> >>>> to make it work for that config.
> >>>
> >>>
> >>> OK I added that in the 1st commit that introduced virtio-mem.
> >>
> >> Thanks. I have some addon-patches ready, what's the best way to continue
> >> with these?
> >
> > If these are bugfixes, just respin the series (including this fix).
>
> There are two really minor bugfixes for corner-case error handling and
> one simplification. I can squash them and resend, makes things easier.
>
> The other stuff I have are extensions, I will send as add-on.
>
> Thanks!
So just send a giant patchbomb explaining what's what in the
cover letter. Thanks!
>
> --
> Thanks,
>
> David / dhildenb
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?
2020-05-05 16:22 ` David Hildenbrand
2020-05-05 16:30 ` Michael S. Tsirkin
@ 2020-05-06 20:28 ` Michael S. Tsirkin
2020-05-06 20:32 ` David Hildenbrand
1 sibling, 1 reply; 9+ messages in thread
From: Michael S. Tsirkin @ 2020-05-06 20:28 UTC (permalink / raw)
To: David Hildenbrand
Cc: kbuild test robot, kbuild-all, kvm, virtualization, netdev, Pankaj Gupta
On Tue, May 05, 2020 at 06:22:51PM +0200, David Hildenbrand wrote:
> On 05.05.20 18:20, Michael S. Tsirkin wrote:
> > On Tue, May 05, 2020 at 05:46:44PM +0200, David Hildenbrand wrote:
> >> On 05.05.20 17:44, Michael S. Tsirkin wrote:
> >>> On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote:
> >>>> On 05.05.20 16:15, kbuild test robot wrote:
> >>>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
> >>>>> head: da1742791d8c0c0a8e5471f181549c4726a5c5f9
> >>>>> commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug
> >>>>> config: x86_64-randconfig-b002-20200505 (attached as .config)
> >>>>> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> >>>>> reproduce:
> >>>>> git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0
> >>>>> # save the attached .config to linux build tree
> >>>>> make ARCH=x86_64
> >>>>>
> >>>>> If you fix the issue, kindly add following tag as appropriate
> >>>>> Reported-by: kbuild test robot <lkp@intel.com>
> >>>>>
> >>>>> All error/warnings (new ones prefixed by >>):
> >>>>>
> >>>>> drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe':
> >>>>>>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration]
> >>>>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
> >>>>> ^~~~~~~
> >>>>> vzalloc
> >>>>>>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> >>>>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
> >>>>> ^
> >>>>>>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
> >>>>> kfree(vm);
> >>>>> ^~~~~
> >>>>> vfree
> >>>>> cc1: some warnings being treated as errors
> >>>>>
> >>>>> vim +1375 drivers/virtio/virtio_mem.c
> >>>>
> >>>> Guess we simply need
> >>>>
> >>>> #include <linux/slab.h>
> >>>>
> >>>> to make it work for that config.
> >>>
> >>>
> >>> OK I added that in the 1st commit that introduced virtio-mem.
> >>
> >> Thanks. I have some addon-patches ready, what's the best way to continue
> >> with these?
> >
> > If these are bugfixes, just respin the series (including this fix).
>
> There are two really minor bugfixes for corner-case error handling and
> one simplification. I can squash them and resend, makes things easier.
OK try to do it ASAP, we don't want to repeat the drama we had with vdpa.
> The other stuff I have are extensions, I will send as add-on.
>
> Thanks!
>
>
> --
> Thanks,
>
> David / dhildenb
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?
2020-05-06 20:28 ` Michael S. Tsirkin
@ 2020-05-06 20:32 ` David Hildenbrand
0 siblings, 0 replies; 9+ messages in thread
From: David Hildenbrand @ 2020-05-06 20:32 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: David Hildenbrand, kbuild test robot, kbuild-all, kvm,
virtualization, netdev, Pankaj Gupta
> Am 06.05.2020 um 22:28 schrieb Michael S. Tsirkin <mst@redhat.com>:
>
> On Tue, May 05, 2020 at 06:22:51PM +0200, David Hildenbrand wrote:
>>> On 05.05.20 18:20, Michael S. Tsirkin wrote:
>>> On Tue, May 05, 2020 at 05:46:44PM +0200, David Hildenbrand wrote:
>>>> On 05.05.20 17:44, Michael S. Tsirkin wrote:
>>>>> On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote:
>>>>>> On 05.05.20 16:15, kbuild test robot wrote:
>>>>>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
>>>>>>> head: da1742791d8c0c0a8e5471f181549c4726a5c5f9
>>>>>>> commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug
>>>>>>> config: x86_64-randconfig-b002-20200505 (attached as .config)
>>>>>>> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
>>>>>>> reproduce:
>>>>>>> git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0
>>>>>>> # save the attached .config to linux build tree
>>>>>>> make ARCH=x86_64
>>>>>>>
>>>>>>> If you fix the issue, kindly add following tag as appropriate
>>>>>>> Reported-by: kbuild test robot <lkp@intel.com>
>>>>>>>
>>>>>>> All error/warnings (new ones prefixed by >>):
>>>>>>>
>>>>>>> drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe':
>>>>>>>>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration]
>>>>>>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
>>>>>>> ^~~~~~~
>>>>>>> vzalloc
>>>>>>>>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>>>>>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
>>>>>>> ^
>>>>>>>>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
>>>>>>> kfree(vm);
>>>>>>> ^~~~~
>>>>>>> vfree
>>>>>>> cc1: some warnings being treated as errors
>>>>>>>
>>>>>>> vim +1375 drivers/virtio/virtio_mem.c
>>>>>>
>>>>>> Guess we simply need
>>>>>>
>>>>>> #include <linux/slab.h>
>>>>>>
>>>>>> to make it work for that config.
>>>>>
>>>>>
>>>>> OK I added that in the 1st commit that introduced virtio-mem.
>>>>
>>>> Thanks. I have some addon-patches ready, what's the best way to continue
>>>> with these?
>>>
>>> If these are bugfixes, just respin the series (including this fix).
>>
>> There are two really minor bugfixes for corner-case error handling and
>> one simplification. I can squash them and resend, makes things easier.
>
> OK try to do it ASAP, we don't want to repeat the drama we had with vdpa.
>
Yeah, did some more testing today. Will send v3 out tomorrow.
Cheers!
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-05-06 20:32 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-05 14:15 [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? kbuild test robot
2020-05-05 14:50 ` David Hildenbrand
2020-05-05 15:44 ` Michael S. Tsirkin
2020-05-05 15:46 ` David Hildenbrand
2020-05-05 16:20 ` Michael S. Tsirkin
2020-05-05 16:22 ` David Hildenbrand
2020-05-05 16:30 ` Michael S. Tsirkin
2020-05-06 20:28 ` Michael S. Tsirkin
2020-05-06 20:32 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).