From: Yury Norov <ynorov@caviumnetworks.com> To: Chris Metcalf <cmetcalf@mellanox.com> Cc: linux-doc@vger.kernel.org, szabolcs.nagy@arm.com, catalin.marinas@arm.com, heiko.carstens@de.ibm.com, philipp.tomsich@theobroma-systems.com, joseph@codesourcery.com, linux-arch@vger.kernel.org, zhouchengming1@huawei.com, Prasun.Kapoor@caviumnetworks.com, agraf@suse.de, geert@linux-m68k.org, kilobyte@angband.pl, manuel.montezelo@gmail.com, arnd@arndb.de, pinskia@gmail.com, linyongting@huawei.com, klimov.linux@gmail.com, broonie@kernel.org, bamvor.zhangjian@huawei.com, linux-arm-kernel@lists.infradead.org, maxim.kuvyrkov@linaro.org, Nathan_Lynch@mentor.com, linux-kernel@vger.kernel.org, schwidefsky@de.ibm.com, davem@davemloft.net, christoph.muellner@theobroma-systems.com Subject: Re: [PATCH 02/18] arm64: ilp32: add documentation on the ILP32 ABI for ARM64 Date: Thu, 27 Oct 2016 12:40:07 +0300 [thread overview] Message-ID: <20161027094007.GB3666@yury-N73SV> (raw) In-Reply-To: <352ff60e-3975-8421-3274-3a904c0ac642@mellanox.com> Hi Chris, Thank you for comments On Mon, Oct 24, 2016 at 12:36:27PM -0400, Chris Metcalf wrote: > On 10/21/2016 4:33 PM, Yury Norov wrote: > >Based on Andrew Pinski's patch-series. > > > >Signed-off-by: Yury Norov <ynorov@caviumnetworks.com> > >--- > > Documentation/arm64/ilp32.txt | 46 +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 46 insertions(+) > > create mode 100644 Documentation/arm64/ilp32.txt > > > >diff --git a/Documentation/arm64/ilp32.txt b/Documentation/arm64/ilp32.txt > >new file mode 100644 > >index 0000000..b96c18f > >--- /dev/null > >+++ b/Documentation/arm64/ilp32.txt > >@@ -0,0 +1,46 @@ > >+ILP32 AARCH64 SYSCALL ABI > >+========================= > >+ > >+This document describes the ILP32 syscall ABI and where it differs > >+from the generic compat linux syscall interface. > >+ > >+AARCH64/ILP32 userspace can potentially access top halves of registers that > >+are passed as syscall arguments, so such registers (w0-w7) are deloused. > > I'm not sure what "potentially access" here means: I think what you want to say > is that userspace can pass garbage in the top half, but you should be clearer about > what you mean here. Yes. Will change. > Also, you shouldn't use "deloused" here, since it's not a term > that's defined elsewhere in the kernel, even though it's been used colloquially on LKML. > Provide an actual implementation definition, like "have their top 32 bits zeroed". Agree. In fact 'delouse' is used in the name of corresponding macro in include/linux/compat.h: 29 #ifndef __SC_DELOUSE 30 #define __SC_DELOUSE(t,v) ((t)(unsigned long)(v)) 31 #endif But it's not for documentation. > > >+AARCH64/ILP32 provides next types turned to 64-bit (comparing to AARCH32): > > What does "turned" mean here? And I "next types" isn't standard English; you want > to say something like "the following types". Likewise later with "next syscalls". Thanks, will change. Yury
WARNING: multiple messages have this Message-ID (diff)
From: Yury Norov <ynorov@caviumnetworks.com> To: Chris Metcalf <cmetcalf@mellanox.com> Cc: arnd@arndb.de, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, pinskia@gmail.com, broonie@kernel.org, joseph@codesourcery.com, christoph.muellner@theobroma-systems.com, bamvor.zhangjian@huawei.com, szabolcs.nagy@arm.com, klimov.linux@gmail.com, Nathan_Lynch@mentor.com, agraf@suse.de, Prasun.Kapoor@caviumnetworks.com, kilobyte@angband.pl, geert@linux-m68k.org, philipp.tomsich@theobroma-systems.com, manuel.montezelo@gmail.com, linyongting@huawei.com, maxim.kuvyrkov@linaro.org, davem@davemloft.net, zhouchengming1@huawei.com Subject: Re: [PATCH 02/18] arm64: ilp32: add documentation on the ILP32 ABI for ARM64 Date: Thu, 27 Oct 2016 12:40:07 +0300 [thread overview] Message-ID: <20161027094007.GB3666@yury-N73SV> (raw) Message-ID: <20161027094007.9jut7jHxgTZybnn2f8lBqmco00fP2Ow4IH4uLuNiAtc@z> (raw) In-Reply-To: <352ff60e-3975-8421-3274-3a904c0ac642@mellanox.com> Hi Chris, Thank you for comments On Mon, Oct 24, 2016 at 12:36:27PM -0400, Chris Metcalf wrote: > On 10/21/2016 4:33 PM, Yury Norov wrote: > >Based on Andrew Pinski's patch-series. > > > >Signed-off-by: Yury Norov <ynorov@caviumnetworks.com> > >--- > > Documentation/arm64/ilp32.txt | 46 +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 46 insertions(+) > > create mode 100644 Documentation/arm64/ilp32.txt > > > >diff --git a/Documentation/arm64/ilp32.txt b/Documentation/arm64/ilp32.txt > >new file mode 100644 > >index 0000000..b96c18f > >--- /dev/null > >+++ b/Documentation/arm64/ilp32.txt > >@@ -0,0 +1,46 @@ > >+ILP32 AARCH64 SYSCALL ABI > >+========================= > >+ > >+This document describes the ILP32 syscall ABI and where it differs > >+from the generic compat linux syscall interface. > >+ > >+AARCH64/ILP32 userspace can potentially access top halves of registers that > >+are passed as syscall arguments, so such registers (w0-w7) are deloused. > > I'm not sure what "potentially access" here means: I think what you want to say > is that userspace can pass garbage in the top half, but you should be clearer about > what you mean here. Yes. Will change. > Also, you shouldn't use "deloused" here, since it's not a term > that's defined elsewhere in the kernel, even though it's been used colloquially on LKML. > Provide an actual implementation definition, like "have their top 32 bits zeroed". Agree. In fact 'delouse' is used in the name of corresponding macro in include/linux/compat.h: 29 #ifndef __SC_DELOUSE 30 #define __SC_DELOUSE(t,v) ((t)(unsigned long)(v)) 31 #endif But it's not for documentation. > > >+AARCH64/ILP32 provides next types turned to 64-bit (comparing to AARCH32): > > What does "turned" mean here? And I "next types" isn't standard English; you want > to say something like "the following types". Likewise later with "next syscalls". Thanks, will change. Yury
next prev parent reply other threads:[~2016-10-27 9:40 UTC|newest] Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-21 20:32 [RFC3 nowrap: PATCH v7 00/18] ILP32 for ARM64 Yury Norov 2016-10-21 20:32 ` Yury Norov 2016-10-21 20:33 ` [PATCH 01/18] 32-bit ABI: introduce ARCH_32BIT_OFF_T config option Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-24 16:30 ` Chris Metcalf 2016-10-24 16:30 ` Chris Metcalf 2016-10-24 22:22 ` Arnd Bergmann 2016-10-27 9:29 ` Yury Norov 2016-10-27 9:29 ` Yury Norov 2016-10-21 20:33 ` [PATCH 02/18] arm64: ilp32: add documentation on the ILP32 ABI for ARM64 Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-24 16:36 ` Chris Metcalf 2016-10-24 16:36 ` Chris Metcalf 2016-10-27 9:40 ` Yury Norov [this message] 2016-10-27 9:40 ` Yury Norov 2016-10-21 20:33 ` [PATCH 03/18] arm64: rename COMPAT to AARCH32_EL0 in Kconfig Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 04/18] arm64: ensure the kernel is compiled for LP64 Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 05/18] arm64:uapi: set __BITS_PER_LONG correctly for ILP32 and LP64 Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 06/18] thread: move thread bits accessors to separated file Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 07/18] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 08/18] arm64: ilp32: add is_ilp32_compat_{task, thread} and TIF_32BIT_AARCH64 Yury Norov 2016-10-21 20:33 ` [PATCH 08/18] arm64: ilp32: add is_ilp32_compat_{task,thread} " Yury Norov 2016-10-21 20:33 ` [PATCH 09/18] arm64: introduce binfmt_elf32.c Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-12-05 15:10 ` Catalin Marinas 2016-12-14 9:39 ` Yury Norov 2016-12-14 9:39 ` Yury Norov 2016-10-21 20:33 ` [PATCH 10/18] arm64: ilp32: introduce binfmt_ilp32.c Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-12-05 15:38 ` Catalin Marinas 2016-12-05 15:38 ` Catalin Marinas 2016-12-21 18:56 ` Yury Norov 2016-12-21 18:56 ` Yury Norov 2017-01-06 14:48 ` Catalin Marinas 2017-01-06 14:48 ` Catalin Marinas 2016-10-21 20:33 ` [PATCH 11/18] arm64: ilp32: share aarch32 syscall handlers Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-12-05 17:12 ` Catalin Marinas 2016-12-06 7:32 ` Yury Norov 2016-12-06 7:32 ` Yury Norov 2016-10-21 20:33 ` [PATCH 12/18] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 13/18] arm64: signal: share lp64 signal routines to ilp32 Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 14/18] arm64: signal32: move ilp32 and aarch32 common code to separated file Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-12-05 16:18 ` Catalin Marinas 2016-12-05 16:18 ` Catalin Marinas 2016-12-06 9:36 ` Yury Norov 2016-12-06 9:36 ` Yury Norov 2016-10-21 20:33 ` [PATCH 15/18] arm64: ilp32: introduce ilp32-specific handlers for sigframe and ucontext Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 16/18] arm64: ptrace: handle ptrace_request differently for aarch32 and ilp32 Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-12-05 16:34 ` Catalin Marinas 2016-12-06 6:25 ` Yury Norov 2016-12-06 6:30 ` Yury Norov 2016-12-06 6:30 ` Yury Norov 2016-12-07 16:59 ` Catalin Marinas 2016-12-07 16:59 ` Catalin Marinas 2016-12-07 20:40 ` Arnd Bergmann 2016-12-07 20:40 ` Arnd Bergmann 2016-12-08 13:12 ` Catalin Marinas 2017-01-05 20:40 ` Yury Norov 2017-01-05 20:40 ` Yury Norov 2017-01-06 14:36 ` Catalin Marinas 2017-01-06 14:36 ` Catalin Marinas 2016-10-21 20:33 ` [PATCH 17/18] arm64:ilp32: add vdso-ilp32 and use for signal return Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 18/18] arm64:ilp32: add ARM64_ILP32 to Kconfig Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-28 12:46 ` ILP32 for ARM64 - testing with lmbench Yury Norov 2016-11-17 3:28 ` Zhangjian (Bamvor) 2016-11-17 3:28 ` Zhangjian (Bamvor) 2016-11-17 5:02 ` Maxim Kuvyrkov 2016-11-17 5:02 ` Maxim Kuvyrkov 2016-11-17 7:48 ` Zhangjian (Bamvor) 2016-11-17 7:48 ` Zhangjian (Bamvor) 2016-12-05 10:16 ` Zhangjian (Bamvor) 2016-12-05 10:16 ` Zhangjian (Bamvor) 2016-12-05 14:13 ` Catalin Marinas 2016-12-05 14:13 ` Catalin Marinas 2016-12-11 12:08 ` Yury Norov 2016-12-11 12:08 ` Yury Norov 2016-11-07 8:23 ` ILP32 for ARM64: testing with glibc testsuite Yury Norov 2016-11-07 8:23 ` Yury Norov 2016-11-09 9:56 ` Yury Norov 2016-11-09 9:56 ` Yury Norov 2016-11-16 11:22 ` Maxim Kuvyrkov 2016-11-16 11:22 ` Maxim Kuvyrkov 2016-11-17 15:50 ` Catalin Marinas 2016-11-17 15:50 ` Catalin Marinas 2016-11-17 21:45 ` Steve Ellcey 2016-11-17 21:45 ` Steve Ellcey 2016-12-05 9:58 ` Zhangjian (Bamvor) 2016-12-05 9:58 ` Zhangjian (Bamvor) 2016-12-05 10:07 ` Andreas Schwab 2016-12-05 10:07 ` Andreas Schwab 2016-12-05 10:24 ` Zhangjian (Bamvor) 2016-12-05 10:24 ` Zhangjian (Bamvor) 2016-12-06 5:29 ` Yury Norov 2016-12-06 5:29 ` Yury Norov 2016-12-05 19:33 ` Steve Ellcey 2016-12-05 19:33 ` Steve Ellcey 2016-12-06 8:31 ` Andreas Schwab 2016-12-06 8:31 ` Andreas Schwab 2016-11-30 5:02 ` [RFC3 nowrap: PATCH v7 00/18] ILP32 for ARM64 Yury Norov 2016-11-30 5:02 ` Yury Norov 2016-11-30 6:52 ` Adam Borowski 2016-11-30 6:52 ` Adam Borowski -- strict thread matches above, loose matches on Subject: below -- 2016-08-17 11:46 [RFC2 " Yury Norov 2016-08-17 11:46 ` [PATCH 02/18] arm64: ilp32: add documentation on the ILP32 ABI " Yury Norov 2016-08-17 11:46 ` Yury Norov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161027094007.GB3666@yury-N73SV \ --to=ynorov@caviumnetworks.com \ --cc=Nathan_Lynch@mentor.com \ --cc=Prasun.Kapoor@caviumnetworks.com \ --cc=agraf@suse.de \ --cc=arnd@arndb.de \ --cc=bamvor.zhangjian@huawei.com \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=christoph.muellner@theobroma-systems.com \ --cc=cmetcalf@mellanox.com \ --cc=davem@davemloft.net \ --cc=geert@linux-m68k.org \ --cc=heiko.carstens@de.ibm.com \ --cc=joseph@codesourcery.com \ --cc=kilobyte@angband.pl \ --cc=klimov.linux@gmail.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linyongting@huawei.com \ --cc=manuel.montezelo@gmail.com \ --cc=maxim.kuvyrkov@linaro.org \ --cc=philipp.tomsich@theobroma-systems.com \ --cc=pinskia@gmail.com \ --cc=schwidefsky@de.ibm.com \ --cc=szabolcs.nagy@arm.com \ --cc=zhouchengming1@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).