From: Yury Norov <ynorov@caviumnetworks.com> To: Catalin Marinas <catalin.marinas@arm.com> Cc: linux-doc@vger.kernel.org, szabolcs.nagy@arm.com, heiko.carstens@de.ibm.com, cmetcalf@ezchip.com, philipp.tomsich@theobroma-systems.com, joseph@codesourcery.com, linux-arch@vger.kernel.org, zhouchengming1@huawei.com, Prasun.Kapoor@caviumnetworks.com, agraf@suse.de, geert@linux-m68k.org, kilobyte@angband.pl, manuel.montezelo@gmail.com, arnd@arndb.de, pinskia@gmail.com, linyongting@huawei.com, klimov.linux@gmail.com, broonie@kernel.org, bamvor.zhangjian@huawei.com, linux-arm-kernel@lists.infradead.org, maxim.kuvyrkov@linaro.org, Nathan_Lynch@mentor.com, linux-kernel@vger.kernel.org, schwidefsky@de.ibm.com, davem@davemloft.net, christoph.muellner@theobroma-systems.com Subject: Re: [PATCH 09/18] arm64: introduce binfmt_elf32.c Date: Wed, 14 Dec 2016 15:09:22 +0530 [thread overview] Message-ID: <20161214093922.GA27720@yury-N73SV> (raw) In-Reply-To: <20161205151018.GD14429@e104818-lin.cambridge.arm.com> On Mon, Dec 05, 2016 at 03:10:19PM +0000, Catalin Marinas wrote: > On Fri, Oct 21, 2016 at 11:33:08PM +0300, Yury Norov wrote: > > As we support more than one compat formats, it looks more reasonable > > to not use fs/compat_binfmt.c. Custom binfmt_elf32.c allows to move aarch32 > > specific definitions there and make code more maintainable and readable. > > Can you remind me why we need this patch (rather than using the default > fs/compat_binfmt_elf.c which you include here anyway)? https://patchwork.kernel.org/patch/8756121/ This is mostly to avoid runtime checks and hide some re-definitions for aarch32 from ilp32, to avoid re-re-definition. > > > --- /dev/null > > +++ b/arch/arm64/kernel/binfmt_elf32.c > > @@ -0,0 +1,31 @@ > > +/* > > + * Support for AArch32 Linux ELF binaries. > > + */ > > + > > +/* AArch32 EABI. */ > > +#define EF_ARM_EABI_MASK 0xff000000 > > + > > +#define compat_start_thread compat_start_thread > > +#define COMPAT_SET_PERSONALITY(ex) \ > > +do { \ > > + clear_thread_flag(TIF_32BIT_AARCH64); \ > > + set_thread_flag(TIF_32BIT); \ > > +} while (0) > > You introduce this here but it seems to still be present in asm/elf.h. Hmm... Maybe chunk that delete it from asm/elf.h was dropped at some rebase. Thank you for the catch. I'll check it again. Yury
WARNING: multiple messages have this Message-ID (diff)
From: Yury Norov <ynorov@caviumnetworks.com> To: Catalin Marinas <catalin.marinas@arm.com> Cc: arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, szabolcs.nagy@arm.com, heiko.carstens@de.ibm.com, cmetcalf@ezchip.com, philipp.tomsich@theobroma-systems.com, joseph@codesourcery.com, zhouchengming1@huawei.com, Prasun.Kapoor@caviumnetworks.com, agraf@suse.de, geert@linux-m68k.org, kilobyte@angband.pl, manuel.montezelo@gmail.com, pinskia@gmail.com, linyongting@huawei.com, klimov.linux@gmail.com, broonie@kernel.org, bamvor.zhangjian@huawei.com, maxim.kuvyrkov@linaro.org, Nathan_Lynch@mentor.com, schwidefsky@de.ibm.com, davem@davemloft.net, christoph.muellner@theobroma-systems.com Subject: Re: [PATCH 09/18] arm64: introduce binfmt_elf32.c Date: Wed, 14 Dec 2016 15:09:22 +0530 [thread overview] Message-ID: <20161214093922.GA27720@yury-N73SV> (raw) Message-ID: <20161214093922.bSEObJnCbrHRSYyScmPn_sY9Jk5wE2qHV1LlBEKRUso@z> (raw) In-Reply-To: <20161205151018.GD14429@e104818-lin.cambridge.arm.com> On Mon, Dec 05, 2016 at 03:10:19PM +0000, Catalin Marinas wrote: > On Fri, Oct 21, 2016 at 11:33:08PM +0300, Yury Norov wrote: > > As we support more than one compat formats, it looks more reasonable > > to not use fs/compat_binfmt.c. Custom binfmt_elf32.c allows to move aarch32 > > specific definitions there and make code more maintainable and readable. > > Can you remind me why we need this patch (rather than using the default > fs/compat_binfmt_elf.c which you include here anyway)? https://patchwork.kernel.org/patch/8756121/ This is mostly to avoid runtime checks and hide some re-definitions for aarch32 from ilp32, to avoid re-re-definition. > > > --- /dev/null > > +++ b/arch/arm64/kernel/binfmt_elf32.c > > @@ -0,0 +1,31 @@ > > +/* > > + * Support for AArch32 Linux ELF binaries. > > + */ > > + > > +/* AArch32 EABI. */ > > +#define EF_ARM_EABI_MASK 0xff000000 > > + > > +#define compat_start_thread compat_start_thread > > +#define COMPAT_SET_PERSONALITY(ex) \ > > +do { \ > > + clear_thread_flag(TIF_32BIT_AARCH64); \ > > + set_thread_flag(TIF_32BIT); \ > > +} while (0) > > You introduce this here but it seems to still be present in asm/elf.h. Hmm... Maybe chunk that delete it from asm/elf.h was dropped at some rebase. Thank you for the catch. I'll check it again. Yury
next prev parent reply other threads:[~2016-12-14 9:39 UTC|newest] Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-21 20:32 [RFC3 nowrap: PATCH v7 00/18] ILP32 for ARM64 Yury Norov 2016-10-21 20:32 ` Yury Norov 2016-10-21 20:33 ` [PATCH 01/18] 32-bit ABI: introduce ARCH_32BIT_OFF_T config option Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-24 16:30 ` Chris Metcalf 2016-10-24 16:30 ` Chris Metcalf 2016-10-24 22:22 ` Arnd Bergmann 2016-10-27 9:29 ` Yury Norov 2016-10-27 9:29 ` Yury Norov 2016-10-21 20:33 ` [PATCH 02/18] arm64: ilp32: add documentation on the ILP32 ABI for ARM64 Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-24 16:36 ` Chris Metcalf 2016-10-24 16:36 ` Chris Metcalf 2016-10-27 9:40 ` Yury Norov 2016-10-27 9:40 ` Yury Norov 2016-10-21 20:33 ` [PATCH 03/18] arm64: rename COMPAT to AARCH32_EL0 in Kconfig Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 04/18] arm64: ensure the kernel is compiled for LP64 Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 05/18] arm64:uapi: set __BITS_PER_LONG correctly for ILP32 and LP64 Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 06/18] thread: move thread bits accessors to separated file Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 07/18] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 08/18] arm64: ilp32: add is_ilp32_compat_{task, thread} and TIF_32BIT_AARCH64 Yury Norov 2016-10-21 20:33 ` [PATCH 08/18] arm64: ilp32: add is_ilp32_compat_{task,thread} " Yury Norov 2016-10-21 20:33 ` [PATCH 09/18] arm64: introduce binfmt_elf32.c Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-12-05 15:10 ` Catalin Marinas 2016-12-14 9:39 ` Yury Norov [this message] 2016-12-14 9:39 ` Yury Norov 2016-10-21 20:33 ` [PATCH 10/18] arm64: ilp32: introduce binfmt_ilp32.c Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-12-05 15:38 ` Catalin Marinas 2016-12-05 15:38 ` Catalin Marinas 2016-12-21 18:56 ` Yury Norov 2016-12-21 18:56 ` Yury Norov 2017-01-06 14:48 ` Catalin Marinas 2017-01-06 14:48 ` Catalin Marinas 2016-10-21 20:33 ` [PATCH 11/18] arm64: ilp32: share aarch32 syscall handlers Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-12-05 17:12 ` Catalin Marinas 2016-12-06 7:32 ` Yury Norov 2016-12-06 7:32 ` Yury Norov 2016-10-21 20:33 ` [PATCH 12/18] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 13/18] arm64: signal: share lp64 signal routines to ilp32 Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 14/18] arm64: signal32: move ilp32 and aarch32 common code to separated file Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-12-05 16:18 ` Catalin Marinas 2016-12-05 16:18 ` Catalin Marinas 2016-12-06 9:36 ` Yury Norov 2016-12-06 9:36 ` Yury Norov 2016-10-21 20:33 ` [PATCH 15/18] arm64: ilp32: introduce ilp32-specific handlers for sigframe and ucontext Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 16/18] arm64: ptrace: handle ptrace_request differently for aarch32 and ilp32 Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-12-05 16:34 ` Catalin Marinas 2016-12-06 6:25 ` Yury Norov 2016-12-06 6:30 ` Yury Norov 2016-12-06 6:30 ` Yury Norov 2016-12-07 16:59 ` Catalin Marinas 2016-12-07 16:59 ` Catalin Marinas 2016-12-07 20:40 ` Arnd Bergmann 2016-12-07 20:40 ` Arnd Bergmann 2016-12-08 13:12 ` Catalin Marinas 2017-01-05 20:40 ` Yury Norov 2017-01-05 20:40 ` Yury Norov 2017-01-06 14:36 ` Catalin Marinas 2017-01-06 14:36 ` Catalin Marinas 2016-10-21 20:33 ` [PATCH 17/18] arm64:ilp32: add vdso-ilp32 and use for signal return Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-21 20:33 ` [PATCH 18/18] arm64:ilp32: add ARM64_ILP32 to Kconfig Yury Norov 2016-10-21 20:33 ` Yury Norov 2016-10-28 12:46 ` ILP32 for ARM64 - testing with lmbench Yury Norov 2016-11-17 3:28 ` Zhangjian (Bamvor) 2016-11-17 3:28 ` Zhangjian (Bamvor) 2016-11-17 5:02 ` Maxim Kuvyrkov 2016-11-17 5:02 ` Maxim Kuvyrkov 2016-11-17 7:48 ` Zhangjian (Bamvor) 2016-11-17 7:48 ` Zhangjian (Bamvor) 2016-12-05 10:16 ` Zhangjian (Bamvor) 2016-12-05 10:16 ` Zhangjian (Bamvor) 2016-12-05 14:13 ` Catalin Marinas 2016-12-05 14:13 ` Catalin Marinas 2016-12-11 12:08 ` Yury Norov 2016-12-11 12:08 ` Yury Norov 2016-11-07 8:23 ` ILP32 for ARM64: testing with glibc testsuite Yury Norov 2016-11-07 8:23 ` Yury Norov 2016-11-09 9:56 ` Yury Norov 2016-11-09 9:56 ` Yury Norov 2016-11-16 11:22 ` Maxim Kuvyrkov 2016-11-16 11:22 ` Maxim Kuvyrkov 2016-11-17 15:50 ` Catalin Marinas 2016-11-17 15:50 ` Catalin Marinas 2016-11-17 21:45 ` Steve Ellcey 2016-11-17 21:45 ` Steve Ellcey 2016-12-05 9:58 ` Zhangjian (Bamvor) 2016-12-05 9:58 ` Zhangjian (Bamvor) 2016-12-05 10:07 ` Andreas Schwab 2016-12-05 10:07 ` Andreas Schwab 2016-12-05 10:24 ` Zhangjian (Bamvor) 2016-12-05 10:24 ` Zhangjian (Bamvor) 2016-12-06 5:29 ` Yury Norov 2016-12-06 5:29 ` Yury Norov 2016-12-05 19:33 ` Steve Ellcey 2016-12-05 19:33 ` Steve Ellcey 2016-12-06 8:31 ` Andreas Schwab 2016-12-06 8:31 ` Andreas Schwab 2016-11-30 5:02 ` [RFC3 nowrap: PATCH v7 00/18] ILP32 for ARM64 Yury Norov 2016-11-30 5:02 ` Yury Norov 2016-11-30 6:52 ` Adam Borowski 2016-11-30 6:52 ` Adam Borowski -- strict thread matches above, loose matches on Subject: below -- 2016-08-17 11:46 [RFC2 " Yury Norov 2016-08-17 11:46 ` [PATCH 09/18] arm64: introduce binfmt_elf32.c Yury Norov 2016-08-17 11:46 ` Yury Norov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161214093922.GA27720@yury-N73SV \ --to=ynorov@caviumnetworks.com \ --cc=Nathan_Lynch@mentor.com \ --cc=Prasun.Kapoor@caviumnetworks.com \ --cc=agraf@suse.de \ --cc=arnd@arndb.de \ --cc=bamvor.zhangjian@huawei.com \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=christoph.muellner@theobroma-systems.com \ --cc=cmetcalf@ezchip.com \ --cc=davem@davemloft.net \ --cc=geert@linux-m68k.org \ --cc=heiko.carstens@de.ibm.com \ --cc=joseph@codesourcery.com \ --cc=kilobyte@angband.pl \ --cc=klimov.linux@gmail.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linyongting@huawei.com \ --cc=manuel.montezelo@gmail.com \ --cc=maxim.kuvyrkov@linaro.org \ --cc=philipp.tomsich@theobroma-systems.com \ --cc=pinskia@gmail.com \ --cc=schwidefsky@de.ibm.com \ --cc=szabolcs.nagy@arm.com \ --cc=zhouchengming1@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).