From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: linus.walleij@linaro.org, akpm@linux-foundation.org,
linux-gpio@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com
Subject: Re: [RESEND PATCH v4 3/8] gpio: 104-dio-48e: Utilize for_each_set_clump macro
Date: Wed, 17 Oct 2018 10:54:02 +0900 [thread overview]
Message-ID: <20181017015402.GA3307@icarus> (raw)
Message-ID: <20181017015402.G6D1GhGABfsjHAzcUpHqg8iEvJBF6dcdnOY17cnxizY@z> (raw)
In-Reply-To: <afbe5c62-f003-ca92-d185-8e6e9340c75d@rasmusvillemoes.dk>
On Mon, Oct 15, 2018 at 01:59:33PM +0200, Rasmus Villemoes wrote:
> On 2018-10-14 06:19, William Breathitt Gray wrote:
>
> > a bit value of 0 in the
> > bits array does not necessarily mean the input was not requested, but
> > may instead mean that the value at the input is 0;
>
> sure enough, but...
>
> > therefore, the caller
> > must keep track of the requested inputs rather than try to deduce them
> > from the values in the bits array.
>
> ...I don't agree that this logically follows. A caller might reasonably
> expect not to find any bits set in positions other than those in mask. A
> simple example would be caller that just tried to ask "are any of
> _these_ inputs set"; it would be reasonable to implement that using
> bitmap_empty() on the returned bitset, without first having to mask by
> the mask he passed in.
>
> Rasmus
I see your point. It would be good to keep the behavior consistent with
what would be expected by the user -- and adding an additional AND
operation at the end to mask away the unrequested bits should not really
affect the performance to a discernible degree -- so I'll submit a
patchset implementing the mask for these drivers some time this weekend.
William Breathitt Gray
next prev parent reply other threads:[~2018-10-17 9:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 1:12 [RESEND PATCH v4 0/8] Introduce the for_each_set_clump macro William Breathitt Gray
2018-10-02 1:12 ` William Breathitt Gray
2018-10-02 1:13 ` [RESEND PATCH v4 1/8] bitops: " William Breathitt Gray
2018-10-02 1:13 ` William Breathitt Gray
2018-10-02 7:42 ` Rasmus Villemoes
2018-10-02 7:42 ` Rasmus Villemoes
2018-10-02 8:21 ` Andy Shevchenko
2018-10-02 8:21 ` Andy Shevchenko
2018-10-03 11:48 ` Andy Shevchenko
2018-10-03 11:48 ` Andy Shevchenko
2018-10-04 10:36 ` William Breathitt Gray
2018-10-04 10:36 ` William Breathitt Gray
2018-10-04 12:10 ` Andy Shevchenko
2018-10-04 12:10 ` Andy Shevchenko
2018-10-04 10:30 ` William Breathitt Gray
2018-10-04 10:30 ` William Breathitt Gray
2018-10-04 10:03 ` William Breathitt Gray
2018-10-04 10:03 ` William Breathitt Gray
2018-10-02 1:14 ` [RESEND PATCH v4 2/8] lib/test_bitmap.c: Add for_each_set_clump test cases William Breathitt Gray
2018-10-02 1:14 ` William Breathitt Gray
2018-10-02 1:14 ` [RESEND PATCH v4 3/8] gpio: 104-dio-48e: Utilize for_each_set_clump macro William Breathitt Gray
2018-10-02 1:14 ` William Breathitt Gray
2018-10-02 7:00 ` Rasmus Villemoes
2018-10-02 7:00 ` Rasmus Villemoes
2018-10-14 4:19 ` William Breathitt Gray
2018-10-14 4:19 ` William Breathitt Gray
2018-10-15 11:59 ` Rasmus Villemoes
2018-10-15 11:59 ` Rasmus Villemoes
2018-10-17 1:54 ` William Breathitt Gray [this message]
2018-10-17 1:54 ` William Breathitt Gray
2018-10-02 1:15 ` [RESEND PATCH v4 4/8] gpio: 104-idi-48: " William Breathitt Gray
2018-10-02 1:15 ` William Breathitt Gray
2018-10-02 1:15 ` [RESEND PATCH v4 5/8] gpio: gpio-mm: " William Breathitt Gray
2018-10-02 1:15 ` William Breathitt Gray
2018-10-02 1:15 ` [RESEND PATCH v4 6/8] gpio: ws16c48: " William Breathitt Gray
2018-10-02 1:15 ` William Breathitt Gray
2018-10-02 1:16 ` [RESEND PATCH v4 7/8] gpio: pci-idio-16: " William Breathitt Gray
2018-10-02 1:16 ` William Breathitt Gray
2018-10-02 1:16 ` [RESEND PATCH v4 8/8] gpio: pcie-idio-24: " William Breathitt Gray
2018-10-02 1:16 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017015402.GA3307@icarus \
--to=vilhelm.gray@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).