* [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document pixel data sampling edge select
@ 2021-05-15 20:43 Marek Vasut
2021-05-15 20:43 ` [PATCH V4 2/2] drm/bridge: lvds-codec: Add support for " Marek Vasut
2021-05-18 13:21 ` [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document " Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2021-05-15 20:43 UTC (permalink / raw)
To: dri-devel
Cc: ch, Marek Vasut, Alexandre Torgue, Andrzej Hajda, Antonio Borneo,
Benjamin Gaignard, Biju Das, Laurent Pinchart, Maxime Coquelin,
Philippe Cornu, Rob Herring, Sam Ravnborg, Vincent Abriou,
Yannick Fertre, devicetree, linux-arm-kernel, linux-stm32
The OnSemi FIN3385 Parallel-to-LVDS encoder has a dedicated input line to
select input pixel data sampling edge. Add DT property "pclk-sample", not
the same as the one used by display timings but rather the same as used by
media, to define the pixel data sampling edge.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Antonio Borneo <antonio.borneo@st.com>
Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
Cc: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Philippe Cornu <philippe.cornu@st.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Cc: Yannick Fertre <yannick.fertre@st.com>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-stm32@st-md-mailman.stormreply.com
To: dri-devel@lists.freedesktop.org
---
V4: New patch split from combined V3
---
.../bindings/display/bridge/lvds-codec.yaml | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
index 304a1367faaa..f4dd16bd69d2 100644
--- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
@@ -64,6 +64,14 @@ properties:
- port@0
- port@1
+ pclk-sample:
+ description:
+ Data sampling on rising or falling edge.
+ enum:
+ - 0 # Falling edge
+ - 1 # Rising edge
+ default: 0
+
powerdown-gpios:
description:
The GPIO used to control the power down line of this device.
@@ -71,6 +79,16 @@ properties:
power-supply: true
+if:
+ not:
+ properties:
+ compatible:
+ contains:
+ const: lvds-encoder
+then:
+ properties:
+ pclk-sample: false
+
required:
- compatible
- ports
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH V4 2/2] drm/bridge: lvds-codec: Add support for pixel data sampling edge select
2021-05-15 20:43 [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document pixel data sampling edge select Marek Vasut
@ 2021-05-15 20:43 ` Marek Vasut
2021-05-18 13:21 ` [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document " Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2021-05-15 20:43 UTC (permalink / raw)
To: dri-devel
Cc: ch, Marek Vasut, Alexandre Torgue, Andrzej Hajda, Antonio Borneo,
Benjamin Gaignard, Biju Das, Laurent Pinchart, Maxime Coquelin,
Philippe Cornu, Sam Ravnborg, Vincent Abriou, Yannick Fertre,
linux-arm-kernel, linux-stm32
The OnSemi FIN3385 Parallel-to-LVDS encoder has a dedicated input line to
select input pixel data sampling edge. Add DT property "pclk-sample", not
the same as the one used by display timings but rather the same as used by
media, and configure bus flags based on this DT property.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Antonio Borneo <antonio.borneo@st.com>
Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
Cc: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Philippe Cornu <philippe.cornu@st.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Cc: Yannick Fertre <yannick.fertre@st.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-stm32@st-md-mailman.stormreply.com
To: dri-devel@lists.freedesktop.org
---
V2: - Limit the pixelclk-active to encoders only
- Update DT binding document
V3: - Determine whether this is encoder from connector, i.e.
lvds_codec->connector_type == DRM_MODE_CONNECTOR_LVDS
V4: - Switch to pclk-sample. Note that the value of this is inverted,
so all the existing users of pixelclk-active using previous
version of this patch must be reworked
---
drivers/gpu/drm/bridge/lvds-codec.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c
index dcf579a4cf83..8a7cb267ab14 100644
--- a/drivers/gpu/drm/bridge/lvds-codec.c
+++ b/drivers/gpu/drm/bridge/lvds-codec.c
@@ -19,6 +19,7 @@ struct lvds_codec {
struct device *dev;
struct drm_bridge bridge;
struct drm_bridge *panel_bridge;
+ struct drm_bridge_timings timings;
struct regulator *vcc;
struct gpio_desc *powerdown_gpio;
u32 connector_type;
@@ -80,6 +81,7 @@ static int lvds_codec_probe(struct platform_device *pdev)
struct device_node *panel_node;
struct drm_panel *panel;
struct lvds_codec *lvds_codec;
+ u32 val;
lvds_codec = devm_kzalloc(dev, sizeof(*lvds_codec), GFP_KERNEL);
if (!lvds_codec)
@@ -119,6 +121,18 @@ static int lvds_codec_probe(struct platform_device *pdev)
if (IS_ERR(lvds_codec->panel_bridge))
return PTR_ERR(lvds_codec->panel_bridge);
+ /*
+ * Encoder might sample data on different clock edge than the display,
+ * for example OnSemi FIN3385 has a dedicated strapping pin to select
+ * the sampling edge.
+ */
+ if (lvds_codec->connector_type == DRM_MODE_CONNECTOR_LVDS &&
+ !of_property_read_u32(dev->of_node, "pclk-sample", &val)) {
+ lvds_codec->timings.input_bus_flags = val ?
+ DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE :
+ DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE;
+ }
+
/*
* The panel_bridge bridge is attached to the panel's of_node,
* but we need a bridge attached to our of_node for our user
@@ -126,6 +140,7 @@ static int lvds_codec_probe(struct platform_device *pdev)
*/
lvds_codec->bridge.of_node = dev->of_node;
lvds_codec->bridge.funcs = &funcs;
+ lvds_codec->bridge.timings = &lvds_codec->timings;
drm_bridge_add(&lvds_codec->bridge);
platform_set_drvdata(pdev, lvds_codec);
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document pixel data sampling edge select
2021-05-15 20:43 [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document pixel data sampling edge select Marek Vasut
2021-05-15 20:43 ` [PATCH V4 2/2] drm/bridge: lvds-codec: Add support for " Marek Vasut
@ 2021-05-18 13:21 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-05-18 13:21 UTC (permalink / raw)
To: Marek Vasut
Cc: dri-devel, ch, Alexandre Torgue, Andrzej Hajda, Antonio Borneo,
Benjamin Gaignard, Biju Das, Laurent Pinchart, Maxime Coquelin,
Philippe Cornu, Sam Ravnborg, Vincent Abriou, Yannick Fertre,
devicetree, linux-arm-kernel, linux-stm32
On Sat, May 15, 2021 at 10:43:15PM +0200, Marek Vasut wrote:
> The OnSemi FIN3385 Parallel-to-LVDS encoder has a dedicated input line to
> select input pixel data sampling edge. Add DT property "pclk-sample", not
> the same as the one used by display timings but rather the same as used by
> media, to define the pixel data sampling edge.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Antonio Borneo <antonio.borneo@st.com>
> Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Philippe Cornu <philippe.cornu@st.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Vincent Abriou <vincent.abriou@st.com>
> Cc: Yannick Fertre <yannick.fertre@st.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> To: dri-devel@lists.freedesktop.org
> ---
> V4: New patch split from combined V3
> ---
> .../bindings/display/bridge/lvds-codec.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
> index 304a1367faaa..f4dd16bd69d2 100644
> --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
> @@ -64,6 +64,14 @@ properties:
> - port@0
> - port@1
>
> + pclk-sample:
> + description:
> + Data sampling on rising or falling edge.
> + enum:
> + - 0 # Falling edge
> + - 1 # Rising edge
> + default: 0
This is already defined in video-interfaces.yaml, why are you redefining
it here?
It's also defined to be an endpoint property, so move it there and
reference video-interfaces.yaml.
> +
> powerdown-gpios:
> description:
> The GPIO used to control the power down line of this device.
> @@ -71,6 +79,16 @@ properties:
>
> power-supply: true
>
> +if:
> + not:
> + properties:
> + compatible:
> + contains:
> + const: lvds-encoder
> +then:
> + properties:
> + pclk-sample: false
This constraint would be difficult to express with the property in an
endpoint. I'd just drop it.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-18 13:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-15 20:43 [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document pixel data sampling edge select Marek Vasut
2021-05-15 20:43 ` [PATCH V4 2/2] drm/bridge: lvds-codec: Add support for " Marek Vasut
2021-05-18 13:21 ` [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document " Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).