* [PATCH] USB: hcd: remove unused hcd_name variables
@ 2022-08-31 7:30 Greg Kroah-Hartman
2022-08-31 14:21 ` Alan Stern
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2022-08-31 7:30 UTC (permalink / raw)
To: linux-usb
Cc: Greg Kroah-Hartman, kernel test robot, Ard Biesheuvel,
Alan Stern, Krzysztof Kozlowski, Alim Akhtar, Rob Herring,
linux-arm-kernel, linux-samsung-soc, linux-kernel
In the commit 10174220f55a ("usb: reduce kernel log spam on driver
registration") a lot of unneeded kernel log messages were removed, but
that caused a few build warnings to show up where the variable
`hcd_name` was being set but never used anymore.
Resolve this by just removing these variables as they are not needed
anymore
Reported-by: kernel test robot <lkp@intel.com>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Rob Herring <robh@kernel.org>
Cc: linux-usb@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Fixes: 10174220f55a ("usb: reduce kernel log spam on driver registration")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/usb/host/ehci-exynos.c | 1 -
drivers/usb/host/ehci-platform.c | 2 --
drivers/usb/host/ohci-platform.c | 2 --
3 files changed, 5 deletions(-)
diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
index a65e365e3a04..c8e152c2e0ce 100644
--- a/drivers/usb/host/ehci-exynos.c
+++ b/drivers/usb/host/ehci-exynos.c
@@ -32,7 +32,6 @@
(EHCI_INSNREG00_ENA_INCR16 | EHCI_INSNREG00_ENA_INCR8 | \
EHCI_INSNREG00_ENA_INCR4 | EHCI_INSNREG00_ENA_INCRX_ALIGN)
-static const char hcd_name[] = "ehci-exynos";
static struct hc_driver __read_mostly exynos_ehci_hc_driver;
#define PHY_NUMBER 3
diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
index 50491eea9409..fe497c876d76 100644
--- a/drivers/usb/host/ehci-platform.c
+++ b/drivers/usb/host/ehci-platform.c
@@ -53,8 +53,6 @@ struct ehci_platform_priv {
struct delayed_work poll_work;
};
-static const char hcd_name[] = "ehci-platform";
-
static int ehci_platform_reset(struct usb_hcd *hcd)
{
struct platform_device *pdev = to_platform_device(hcd->self.controller);
diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
index 6d56b52966c7..4e7946024ce7 100644
--- a/drivers/usb/host/ohci-platform.c
+++ b/drivers/usb/host/ohci-platform.c
@@ -41,8 +41,6 @@ struct ohci_platform_priv {
struct reset_control *resets;
};
-static const char hcd_name[] = "ohci-platform";
-
static int ohci_platform_power_on(struct platform_device *dev)
{
struct usb_hcd *hcd = platform_get_drvdata(dev);
--
2.37.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] USB: hcd: remove unused hcd_name variables
2022-08-31 7:30 [PATCH] USB: hcd: remove unused hcd_name variables Greg Kroah-Hartman
@ 2022-08-31 14:21 ` Alan Stern
2022-09-01 13:53 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Alan Stern @ 2022-08-31 14:21 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-usb, kernel test robot, Ard Biesheuvel,
Krzysztof Kozlowski, Alim Akhtar, Rob Herring, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On Wed, Aug 31, 2022 at 09:30:32AM +0200, Greg Kroah-Hartman wrote:
> In the commit 10174220f55a ("usb: reduce kernel log spam on driver
> registration") a lot of unneeded kernel log messages were removed, but
> that caused a few build warnings to show up where the variable
> `hcd_name` was being set but never used anymore.
>
> Resolve this by just removing these variables as they are not needed
> anymore
>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: linux-usb@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Fixes: 10174220f55a ("usb: reduce kernel log spam on driver registration")
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/usb/host/ehci-exynos.c | 1 -
> drivers/usb/host/ehci-platform.c | 2 --
> drivers/usb/host/ohci-platform.c | 2 --
> 3 files changed, 5 deletions(-)
This isn't enough, as you can see from this kernel test robot excerpt:
clang_recent_errors
|-- arm-s5pv210_defconfig
| |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name
| `-- drivers-usb-host-ohci-exynos.c:warning:unused-variable-hcd_name
|-- hexagon-randconfig-r024-20220830
| |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ehci-orion.c:warning:unused-variable-hcd_name
| |--
drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ehci-spear.c:warning:unused-variable-hcd_name
| `--
drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name
|-- hexagon-randconfig-r036-20220830
| |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ehci-npcm7xx.c:warning:unused-variable-hcd_name
| |--
drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ehci-st.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ohci-at91.c:warning:unused-variable-hcd_name
| |--
drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ohci-s3c2410.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ohci-spear.c:warning:unused-variable-hcd_name
| `-- drivers-usb-host-ohci-st.c:warning:unused-variable-hcd_name
Yes, it has duplicates and your patch handles some of these. But there
are others that still need to be fixed. Also, this list is missing
ohci-pxa27x.c.
Alan Stern
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] USB: hcd: remove unused hcd_name variables
2022-08-31 14:21 ` Alan Stern
@ 2022-09-01 13:53 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2022-09-01 13:53 UTC (permalink / raw)
To: Alan Stern
Cc: linux-usb, kernel test robot, Ard Biesheuvel,
Krzysztof Kozlowski, Alim Akhtar, Rob Herring, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On Wed, Aug 31, 2022 at 10:21:36AM -0400, Alan Stern wrote:
> On Wed, Aug 31, 2022 at 09:30:32AM +0200, Greg Kroah-Hartman wrote:
> > In the commit 10174220f55a ("usb: reduce kernel log spam on driver
> > registration") a lot of unneeded kernel log messages were removed, but
> > that caused a few build warnings to show up where the variable
> > `hcd_name` was being set but never used anymore.
> >
> > Resolve this by just removing these variables as they are not needed
> > anymore
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Cc: Ard Biesheuvel <ardb@kernel.org>
> > Cc: Alan Stern <stern@rowland.harvard.edu>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Cc: Alim Akhtar <alim.akhtar@samsung.com>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: linux-usb@vger.kernel.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-samsung-soc@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Fixes: 10174220f55a ("usb: reduce kernel log spam on driver registration")
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > drivers/usb/host/ehci-exynos.c | 1 -
> > drivers/usb/host/ehci-platform.c | 2 --
> > drivers/usb/host/ohci-platform.c | 2 --
> > 3 files changed, 5 deletions(-)
>
> This isn't enough, as you can see from this kernel test robot excerpt:
>
> clang_recent_errors
> |-- arm-s5pv210_defconfig
> | |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name
> | `-- drivers-usb-host-ohci-exynos.c:warning:unused-variable-hcd_name
> |-- hexagon-randconfig-r024-20220830
> | |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ehci-orion.c:warning:unused-variable-hcd_name
> | |--
> drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ehci-spear.c:warning:unused-variable-hcd_name
> | `--
> drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name
> |-- hexagon-randconfig-r036-20220830
> | |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ehci-npcm7xx.c:warning:unused-variable-hcd_name
> | |--
> drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ehci-st.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ohci-at91.c:warning:unused-variable-hcd_name
> | |--
> drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ohci-s3c2410.c:warning:unused-variable-hcd_name
> | |-- drivers-usb-host-ohci-spear.c:warning:unused-variable-hcd_name
> | `-- drivers-usb-host-ohci-st.c:warning:unused-variable-hcd_name
>
> Yes, it has duplicates and your patch handles some of these. But there
> are others that still need to be fixed. Also, this list is missing
> ohci-pxa27x.c.
Ick, ok, I went off of a different kbuild report. Let me fix this up
later today...
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-01 13:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-31 7:30 [PATCH] USB: hcd: remove unused hcd_name variables Greg Kroah-Hartman
2022-08-31 14:21 ` Alan Stern
2022-09-01 13:53 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).