* [PATCH] ACPI/IORT: Handle device properties with software node API
@ 2021-05-11 12:55 Heikki Krogerus
2021-05-11 13:51 ` Rafael J. Wysocki
2021-05-14 10:39 ` Lorenzo Pieralisi
0 siblings, 2 replies; 6+ messages in thread
From: Heikki Krogerus @ 2021-05-11 12:55 UTC (permalink / raw)
To: Lorenzo Pieralisi, Hanjun Guo, Sudeep Holla, Rafael J. Wysocki
Cc: Jean-Philippe Brucker, Joerg Roedel, Eric Auger, Will Deacon,
linux-acpi, linux-arm-kernel, linux-kernel
The older device property API is going to be removed.
Replacing the device_add_properties() call with software
node API equivalent device_create_managed_software_node().
Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
drivers/acpi/arm64/iort.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index 3912a1f6058e5..e34937e11186a 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev,
FIELD_GET(ACPI_IORT_NC_PASID_BITS,
nc->node_flags));
- if (device_add_properties(dev, props))
+ if (device_create_managed_software_node(dev, props, NULL))
dev_warn(dev, "Could not add device properties\n");
}
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ACPI/IORT: Handle device properties with software node API
2021-05-11 12:55 [PATCH] ACPI/IORT: Handle device properties with software node API Heikki Krogerus
@ 2021-05-11 13:51 ` Rafael J. Wysocki
2021-05-14 0:42 ` Hanjun Guo
2021-05-14 10:39 ` Lorenzo Pieralisi
1 sibling, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2021-05-11 13:51 UTC (permalink / raw)
To: Heikki Krogerus
Cc: Lorenzo Pieralisi, Hanjun Guo, Sudeep Holla, Rafael J. Wysocki,
Jean-Philippe Brucker, Joerg Roedel, Eric Auger, Will Deacon,
ACPI Devel Maling List, Linux ARM, Linux Kernel Mailing List
On Tue, May 11, 2021 at 2:55 PM Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> The older device property API is going to be removed.
> Replacing the device_add_properties() call with software
> node API equivalent device_create_managed_software_node().
>
> Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/acpi/arm64/iort.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index 3912a1f6058e5..e34937e11186a 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev,
> FIELD_GET(ACPI_IORT_NC_PASID_BITS,
> nc->node_flags));
>
> - if (device_add_properties(dev, props))
> + if (device_create_managed_software_node(dev, props, NULL))
> dev_warn(dev, "Could not add device properties\n");
> }
>
> --
Thanks!
I can take this through the ACPI tree if there are no objections.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ACPI/IORT: Handle device properties with software node API
2021-05-11 13:51 ` Rafael J. Wysocki
@ 2021-05-14 0:42 ` Hanjun Guo
0 siblings, 0 replies; 6+ messages in thread
From: Hanjun Guo @ 2021-05-14 0:42 UTC (permalink / raw)
To: Rafael J. Wysocki, Heikki Krogerus
Cc: Lorenzo Pieralisi, Sudeep Holla, Rafael J. Wysocki,
Jean-Philippe Brucker, Joerg Roedel, Eric Auger, Will Deacon,
ACPI Devel Maling List, Linux ARM, Linux Kernel Mailing List
On 2021/5/11 21:51, Rafael J. Wysocki wrote:
> On Tue, May 11, 2021 at 2:55 PM Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
>> The older device property API is going to be removed.
>> Replacing the device_add_properties() call with software
>> node API equivalent device_create_managed_software_node().
>>
>> Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
>> Signed-off-by: Heikki Krogerus<heikki.krogerus@linux.intel.com>
>> ---
>> drivers/acpi/arm64/iort.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
>> index 3912a1f6058e5..e34937e11186a 100644
>> --- a/drivers/acpi/arm64/iort.c
>> +++ b/drivers/acpi/arm64/iort.c
>> @@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev,
>> FIELD_GET(ACPI_IORT_NC_PASID_BITS,
>> nc->node_flags));
>>
>> - if (device_add_properties(dev, props))
>> + if (device_create_managed_software_node(dev, props, NULL))
>> dev_warn(dev, "Could not add device properties\n");
>> }
>>
>> --
> Thanks!
>
> I can take this through the ACPI tree if there are no objections.
Since this is related to device property API refactor, I'm
fine with it.
Lorenzo, what's your position?
Thanks
Hanjun
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI/IORT: Handle device properties with software node API
2021-05-11 12:55 [PATCH] ACPI/IORT: Handle device properties with software node API Heikki Krogerus
2021-05-11 13:51 ` Rafael J. Wysocki
@ 2021-05-14 10:39 ` Lorenzo Pieralisi
2021-05-14 13:13 ` Heikki Krogerus
1 sibling, 1 reply; 6+ messages in thread
From: Lorenzo Pieralisi @ 2021-05-14 10:39 UTC (permalink / raw)
To: Heikki Krogerus
Cc: Hanjun Guo, Sudeep Holla, Rafael J. Wysocki,
Jean-Philippe Brucker, Joerg Roedel, Eric Auger, Will Deacon,
linux-acpi, linux-arm-kernel, linux-kernel
On Tue, May 11, 2021 at 03:55:28PM +0300, Heikki Krogerus wrote:
> The older device property API is going to be removed.
> Replacing the device_add_properties() call with software
> node API equivalent device_create_managed_software_node().
>
> Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
Is this really fixing anything ? I am not sure I understand what you
would like to achieve with this tag.
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/acpi/arm64/iort.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
With the above comment clarified:
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index 3912a1f6058e5..e34937e11186a 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev,
> FIELD_GET(ACPI_IORT_NC_PASID_BITS,
> nc->node_flags));
>
> - if (device_add_properties(dev, props))
> + if (device_create_managed_software_node(dev, props, NULL))
> dev_warn(dev, "Could not add device properties\n");
> }
>
> --
> 2.30.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ACPI/IORT: Handle device properties with software node API
2021-05-14 10:39 ` Lorenzo Pieralisi
@ 2021-05-14 13:13 ` Heikki Krogerus
2021-05-17 14:36 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Heikki Krogerus @ 2021-05-14 13:13 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: Hanjun Guo, Sudeep Holla, Rafael J. Wysocki,
Jean-Philippe Brucker, Joerg Roedel, Eric Auger, Will Deacon,
linux-acpi, linux-arm-kernel, linux-kernel
On Fri, May 14, 2021 at 11:39:12AM +0100, Lorenzo Pieralisi wrote:
> On Tue, May 11, 2021 at 03:55:28PM +0300, Heikki Krogerus wrote:
> > The older device property API is going to be removed.
> > Replacing the device_add_properties() call with software
> > node API equivalent device_create_managed_software_node().
> >
> > Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
>
> Is this really fixing anything ? I am not sure I understand what you
> would like to achieve with this tag.
Right now it's not possible to simply remove the old API because some
of the maintainers want to take care of the conversion themselves, but
at the same time I also do not want to see any new releases of the
kernel that introduce more users for it. That's why it's a fix.
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > ---
> > drivers/acpi/arm64/iort.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> With the above comment clarified:
>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>
> > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> > index 3912a1f6058e5..e34937e11186a 100644
> > --- a/drivers/acpi/arm64/iort.c
> > +++ b/drivers/acpi/arm64/iort.c
> > @@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev,
> > FIELD_GET(ACPI_IORT_NC_PASID_BITS,
> > nc->node_flags));
> >
> > - if (device_add_properties(dev, props))
> > + if (device_create_managed_software_node(dev, props, NULL))
> > dev_warn(dev, "Could not add device properties\n");
> > }
> >
> > --
> > 2.30.2
> >
thanks,
--
heikki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ACPI/IORT: Handle device properties with software node API
2021-05-14 13:13 ` Heikki Krogerus
@ 2021-05-17 14:36 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2021-05-17 14:36 UTC (permalink / raw)
To: Heikki Krogerus, Lorenzo Pieralisi
Cc: Hanjun Guo, Sudeep Holla, Rafael J. Wysocki,
Jean-Philippe Brucker, Joerg Roedel, Eric Auger, Will Deacon,
ACPI Devel Maling List, Linux ARM, Linux Kernel Mailing List
On Fri, May 14, 2021 at 3:13 PM Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> On Fri, May 14, 2021 at 11:39:12AM +0100, Lorenzo Pieralisi wrote:
> > On Tue, May 11, 2021 at 03:55:28PM +0300, Heikki Krogerus wrote:
> > > The older device property API is going to be removed.
> > > Replacing the device_add_properties() call with software
> > > node API equivalent device_create_managed_software_node().
> > >
> > > Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
> >
> > Is this really fixing anything ? I am not sure I understand what you
> > would like to achieve with this tag.
>
> Right now it's not possible to simply remove the old API because some
> of the maintainers want to take care of the conversion themselves, but
> at the same time I also do not want to see any new releases of the
> kernel that introduce more users for it. That's why it's a fix.
With the assumption that the above clarification is sufficient,
applied as 5.14 material, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-17 14:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 12:55 [PATCH] ACPI/IORT: Handle device properties with software node API Heikki Krogerus
2021-05-11 13:51 ` Rafael J. Wysocki
2021-05-14 0:42 ` Hanjun Guo
2021-05-14 10:39 ` Lorenzo Pieralisi
2021-05-14 13:13 ` Heikki Krogerus
2021-05-17 14:36 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).