From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Stephen Boyd <sboyd@kernel.org> Cc: Andy Gross <agross@kernel.org>, Vinod Koul <vkoul@kernel.org>, linux-arm-msm@vger.kernel.org, sibis@codeaurora.org, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/22] arm64: dts: qcom: sm8150: add base dts file Date: Wed, 14 Aug 2019 12:02:57 -0700 Message-ID: <20190814190257.GI6167@minitux> (raw) In-Reply-To: <20190814183552.5FF062133F@mail.kernel.org> On Wed 14 Aug 11:35 PDT 2019, Stephen Boyd wrote: > Quoting Bjorn Andersson (2019-08-14 10:44:39) > > On Wed 14 Aug 09:58 PDT 2019, Stephen Boyd wrote: > > > > > Quoting Vinod Koul (2019-08-14 05:49:51) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi > > [..] > > > > + clocks { > > > > + xo_board: xo-board { > > > > + compatible = "fixed-clock"; > > > > + #clock-cells = <0>; > > > > + clock-frequency = <19200000>; > > > > > > Is it 19.2 or 38.4 MHz? It seems like lately there are dividers, but I > > > guess it doesn't really matter in the end. > > > > > > > As with previous platforms, the board's XO feeds the PMIC at 38.4MHz and > > the SoC's CXO_IN pin (i.e. bi_tcxo) is fed from the PMIC's LNBBCLK1, > > which is ticking at 19.2MHz. > > > > [..] > > > > + gcc: clock-controller@100000 { > > > > + compatible = "qcom,gcc-sm8150"; > > > > + reg = <0x00100000 0x1f0000>; > > > > + #clock-cells = <1>; > > > > + #reset-cells = <1>; > > > > + #power-domain-cells = <1>; > > > > + clock-names = "bi_tcxo", "sleep_clk"; > > > > + clocks = <&xo_board>, <&sleep_clk>; > > > > So this first one should actually be <&rpmhcc LNBBCLK1>. > > Hrmm LNBBCLK1 doesn't make any sense to me. That's a buffer that is > technically the net connected to the XO pin on the Soc, but it isn't > really supposed to be used by anything from what I recall. Last time I > tried to use the buffers the RPM team told me I was using the wrong > resource and I should just use the XO resource instead. Doesn't RPMh > expose the other "XO" resource that is supposed to prevent XO shutdown? So while it's the LNBBCLK1 pin we're referring to, it's the RPMH_CXO_CLK which has some level of magic involved that we should actually use in the software. > Just mark it critical for now so that XO isn't turned off at runtime. > > > > > But while we now should handle this gracefully in the clock driver I > > think we still have problems with the cascading probe deferral that > > follows - last time I tried to do this the serial driver probe deferred > > past user space initialization and the system crashed as we didn't have > > a /dev/console. > > Does the serial driver probe eventually? Maybe you can run agetty when > the device appears based on some uevent for /dev/console. Or we have a > bug where /dev/console is created by devtmpfs when there isn't actually > a console? > I don't remember the exact outcome, but presume it would depend on the implementation details of early user space (e.g. my regression test suite would not deal with this). > > > > > > So, I think we should s/xo_board/lnbbclk1/ (at 19.2MHz) to make it > > represent the schematics and then once we have rpmhcc and validated that > > the system handles this gracefully we can switch it out. > > > > Sure, some sort of approach that switches it later on is fine, just want > to make sure that the board clk frequency is accurately reflected in the > DT. > We introduced the xo_board fixed clock to have a parent of gcc, but given that there is a clock named "XO" and it is not the clock being connected to gcc, nor is it ticking at the right frequency I think it should at least have a different name. Regards, Bjorn
next prev parent reply index Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-14 12:49 [PATCH 00/22] arm64: dts: qcom: sm8150: Add SM8150 DTS Vinod Koul 2019-08-14 12:49 ` [PATCH 01/22] arm64: dts: qcom: sm8150: add base dts file Vinod Koul 2019-08-14 16:58 ` Stephen Boyd 2019-08-14 17:44 ` Bjorn Andersson 2019-08-14 18:35 ` Stephen Boyd 2019-08-14 19:02 ` Bjorn Andersson [this message] 2019-08-14 17:50 ` Bjorn Andersson 2019-08-14 12:49 ` [PATCH 02/22] arm64: dts: qcom: sm8150-mtp: " Vinod Koul 2019-08-14 17:53 ` Bjorn Andersson 2019-08-14 12:49 ` [PATCH 03/22] arm64: dts: qcom: sm8150: add tlmm node Vinod Koul 2019-08-14 17:01 ` Stephen Boyd 2019-08-19 17:09 ` Vinod Koul 2019-08-14 12:49 ` [PATCH 04/22] arm64: dts: qcom: sm8150-mtp: add tlmm reserved range Vinod Koul 2019-08-14 17:01 ` Stephen Boyd 2019-08-14 12:49 ` [PATCH 05/22] arm64: dts: qcom: sm8150: Add spmi node Vinod Koul 2019-08-14 17:01 ` Stephen Boyd 2019-08-14 12:49 ` [PATCH 06/22] arm64: dts: qcom: pm8150: Add Base DTS file Vinod Koul 2019-08-14 17:03 ` Stephen Boyd 2019-08-19 17:28 ` Vinod Koul 2019-08-14 12:49 ` [PATCH 07/22] arm64: dts: qcom: pm8150: Add pon and rtc nodes Vinod Koul 2019-08-14 17:03 ` Stephen Boyd 2019-08-19 17:32 ` Vinod Koul 2019-08-14 12:49 ` [PATCH 08/22] arm64: dts: qcom: pm8150: Add vadc node Vinod Koul 2019-08-14 17:05 ` Stephen Boyd 2019-08-14 12:49 ` [PATCH 09/22] arm64: dts: qcom: pm8150b: Add Base DTS file Vinod Koul 2019-08-14 17:05 ` Stephen Boyd 2019-08-14 12:50 ` [PATCH 10/22] arm64: dts: qcom: pm8150b: Add pon and adc nodes Vinod Koul 2019-08-14 17:08 ` Stephen Boyd 2019-08-19 17:43 ` Vinod Koul 2019-08-19 17:56 ` Stephen Boyd 2019-08-20 3:46 ` Vinod Koul 2019-08-14 18:00 ` Bjorn Andersson 2019-08-14 12:50 ` [PATCH 11/22] arm64: dts: qcom: pm8150b: Add gpio node Vinod Koul 2019-08-14 17:08 ` Stephen Boyd 2019-08-14 12:50 ` [PATCH 12/22] arm64: dts: qcom: pm8150l: Add Base DTS file Vinod Koul 2019-08-14 17:10 ` Stephen Boyd 2019-08-14 12:50 ` [PATCH 13/22] arm64: dts: qcom: pm8150l: Add pon and adc nodes Vinod Koul 2019-08-14 17:10 ` Stephen Boyd 2019-08-14 12:50 ` [PATCH 14/22] arm64: dts: qcom: pm8150l: Add gpio node Vinod Koul 2019-08-14 12:50 ` [PATCH 15/22] arm64: dts: qcom: sm8150-mtp: Include pmics Vinod Koul 2019-08-14 12:50 ` [PATCH 16/22] arm64: dts: qcom: sm8150-mtp: Add resin node Vinod Koul 2019-08-14 12:50 ` [PATCH 17/22] arm64: dts: qcom: sm8150: Add apss_shared and apps_rsc nodes Vinod Koul 2019-08-14 17:12 ` Stephen Boyd 2019-08-19 17:35 ` Vinod Koul 2019-08-14 12:50 ` [PATCH 18/22] arm64: dts: qcom: sm8150: Add reserved-memory regions Vinod Koul 2019-08-14 17:13 ` Stephen Boyd 2019-08-19 17:36 ` Vinod Koul 2019-08-14 12:50 ` [PATCH 19/22] arm64: dts: qcom: sm8150-mtp: Add regulators Vinod Koul 2019-08-14 12:50 ` [PATCH 20/22] arm64: dts: qcom: sm8150: Add pmu node to SM8150 SoC Vinod Koul 2019-08-14 17:15 ` Stephen Boyd 2019-08-14 12:50 ` [PATCH 21/22] arm64: dts: qcom: sm8150: Add SMEM nodes Vinod Koul 2019-08-14 17:16 ` Stephen Boyd 2019-08-14 12:50 ` [PATCH 22/22] arm64: dts: qcom: sm8150: Add APSS shared mailbox Vinod Koul 2019-08-14 17:17 ` Stephen Boyd 2019-08-19 17:41 ` Vinod Koul 2019-08-20 6:20 ` Sibi Sankar 2019-08-20 6:37 ` Vinod Koul
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190814190257.GI6167@minitux \ --to=bjorn.andersson@linaro.org \ --cc=agross@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=sibis@codeaurora.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-MSM Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \ linux-arm-msm@vger.kernel.org public-inbox-index linux-arm-msm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git