From: Vinod Koul <vkoul@kernel.org> To: Stephen Boyd <sboyd@kernel.org> Cc: Andy Gross <agross@kernel.org>, linux-arm-msm@vger.kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>, sibis@codeaurora.org, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 17/22] arm64: dts: qcom: sm8150: Add apss_shared and apps_rsc nodes Date: Mon, 19 Aug 2019 23:05:14 +0530 Message-ID: <20190819173513.GK12733@vkoul-mobl.Dlink> (raw) In-Reply-To: <20190814171235.6BE1721721@mail.kernel.org> On 14-08-19, 10:12, Stephen Boyd wrote: > Quoting Vinod Koul (2019-08-14 05:50:07) > > Add apss_shared and apps_rsc node including the rpmhcc child node > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > --- > > Can't this be squashed with the original dtsi file? That makes it a huge blob, imo hard to review. I will still go ahead and squash things in v2, but will still keep logical chunks.. (this can go in original though) > > > arch/arm64/boot/dts/qcom/sm8150.dtsi | 30 ++++++++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi > > index 5c6b103b042b..5258b79676f6 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > > @@ -4,6 +4,7 @@ > > > > #include <dt-bindings/interrupt-controller/arm-gic.h> > > #include <dt-bindings/clock/qcom,gcc-sm8150.h> > > +#include <dt-bindings/soc/qcom,rpmh-rsc.h> > > But not the rpmh clk bindings? Thats missing will add > > > @@ -272,6 +279,29 @@ > > }; > > }; > > > > + apps_rsc: rsc@18200000 { > > + label = "apps_rsc"; > > + compatible = "qcom,rpmh-rsc"; > > + reg = <0x18200000 0x10000>, > > + <0x18210000 0x10000>, > > + <0x18220000 0x10000>; > > + reg-names = "drv-0", "drv-1", "drv-2"; > > + interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>; > > + qcom,tcs-offset = <0xd00>; > > + qcom,drv-id = <2>; > > + qcom,tcs-config = <ACTIVE_TCS 2>, > > + <SLEEP_TCS 1>, > > + <WAKE_TCS 1>, > > + <CONTROL_TCS 0>; > > + > > + rpmhcc: clock-controller { > > + compatible = "qcom,sm8150-rpmh-clk"; > > + #clock-cells = <1>; > > Should take some sort of clocks property to get the board clock for XO? Yes after conversion, I have updated this now -- ~Vinod
next prev parent reply index Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-14 12:49 [PATCH 00/22] arm64: dts: qcom: sm8150: Add SM8150 DTS Vinod Koul 2019-08-14 12:49 ` [PATCH 01/22] arm64: dts: qcom: sm8150: add base dts file Vinod Koul 2019-08-14 16:58 ` Stephen Boyd 2019-08-14 17:44 ` Bjorn Andersson 2019-08-14 18:35 ` Stephen Boyd 2019-08-14 19:02 ` Bjorn Andersson 2019-08-14 17:50 ` Bjorn Andersson 2019-08-14 12:49 ` [PATCH 02/22] arm64: dts: qcom: sm8150-mtp: " Vinod Koul 2019-08-14 17:53 ` Bjorn Andersson 2019-08-14 12:49 ` [PATCH 03/22] arm64: dts: qcom: sm8150: add tlmm node Vinod Koul 2019-08-14 17:01 ` Stephen Boyd 2019-08-19 17:09 ` Vinod Koul 2019-08-14 12:49 ` [PATCH 04/22] arm64: dts: qcom: sm8150-mtp: add tlmm reserved range Vinod Koul 2019-08-14 17:01 ` Stephen Boyd 2019-08-14 12:49 ` [PATCH 05/22] arm64: dts: qcom: sm8150: Add spmi node Vinod Koul 2019-08-14 17:01 ` Stephen Boyd 2019-08-14 12:49 ` [PATCH 06/22] arm64: dts: qcom: pm8150: Add Base DTS file Vinod Koul 2019-08-14 17:03 ` Stephen Boyd 2019-08-19 17:28 ` Vinod Koul 2019-08-14 12:49 ` [PATCH 07/22] arm64: dts: qcom: pm8150: Add pon and rtc nodes Vinod Koul 2019-08-14 17:03 ` Stephen Boyd 2019-08-19 17:32 ` Vinod Koul 2019-08-14 12:49 ` [PATCH 08/22] arm64: dts: qcom: pm8150: Add vadc node Vinod Koul 2019-08-14 17:05 ` Stephen Boyd 2019-08-14 12:49 ` [PATCH 09/22] arm64: dts: qcom: pm8150b: Add Base DTS file Vinod Koul 2019-08-14 17:05 ` Stephen Boyd 2019-08-14 12:50 ` [PATCH 10/22] arm64: dts: qcom: pm8150b: Add pon and adc nodes Vinod Koul 2019-08-14 17:08 ` Stephen Boyd 2019-08-19 17:43 ` Vinod Koul 2019-08-19 17:56 ` Stephen Boyd 2019-08-20 3:46 ` Vinod Koul 2019-08-14 18:00 ` Bjorn Andersson 2019-08-14 12:50 ` [PATCH 11/22] arm64: dts: qcom: pm8150b: Add gpio node Vinod Koul 2019-08-14 17:08 ` Stephen Boyd 2019-08-14 12:50 ` [PATCH 12/22] arm64: dts: qcom: pm8150l: Add Base DTS file Vinod Koul 2019-08-14 17:10 ` Stephen Boyd 2019-08-14 12:50 ` [PATCH 13/22] arm64: dts: qcom: pm8150l: Add pon and adc nodes Vinod Koul 2019-08-14 17:10 ` Stephen Boyd 2019-08-14 12:50 ` [PATCH 14/22] arm64: dts: qcom: pm8150l: Add gpio node Vinod Koul 2019-08-14 12:50 ` [PATCH 15/22] arm64: dts: qcom: sm8150-mtp: Include pmics Vinod Koul 2019-08-14 12:50 ` [PATCH 16/22] arm64: dts: qcom: sm8150-mtp: Add resin node Vinod Koul 2019-08-14 12:50 ` [PATCH 17/22] arm64: dts: qcom: sm8150: Add apss_shared and apps_rsc nodes Vinod Koul 2019-08-14 17:12 ` Stephen Boyd 2019-08-19 17:35 ` Vinod Koul [this message] 2019-08-14 12:50 ` [PATCH 18/22] arm64: dts: qcom: sm8150: Add reserved-memory regions Vinod Koul 2019-08-14 17:13 ` Stephen Boyd 2019-08-19 17:36 ` Vinod Koul 2019-08-14 12:50 ` [PATCH 19/22] arm64: dts: qcom: sm8150-mtp: Add regulators Vinod Koul 2019-08-14 12:50 ` [PATCH 20/22] arm64: dts: qcom: sm8150: Add pmu node to SM8150 SoC Vinod Koul 2019-08-14 17:15 ` Stephen Boyd 2019-08-14 12:50 ` [PATCH 21/22] arm64: dts: qcom: sm8150: Add SMEM nodes Vinod Koul 2019-08-14 17:16 ` Stephen Boyd 2019-08-14 12:50 ` [PATCH 22/22] arm64: dts: qcom: sm8150: Add APSS shared mailbox Vinod Koul 2019-08-14 17:17 ` Stephen Boyd 2019-08-19 17:41 ` Vinod Koul 2019-08-20 6:20 ` Sibi Sankar 2019-08-20 6:37 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190819173513.GK12733@vkoul-mobl.Dlink \ --to=vkoul@kernel.org \ --cc=agross@kernel.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=sibis@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-MSM Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \ linux-arm-msm@vger.kernel.org public-inbox-index linux-arm-msm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git