From: Peter De Schrijver <pdeschrijver@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
"Michael Turquette" <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
"Peter Geis" <pgwipeout@gmail.com>,
Nicolas Chauvet <kwizart@gmail.com>,
"Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
<linux-pm@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 00/12] NVIDIA Tegra20 CPUFreq driver major update
Date: Tue, 14 Jan 2020 17:53:06 +0200 [thread overview]
Message-ID: <20200114155306.GI28289@pdeschrijver-desktop.Nvidia.com> (raw)
In-Reply-To: <20191218202142.11717-1-digetx@gmail.com>
Acked-By: Peter De Schrijver <pdeschrijver@nvidia.com>
On Wed, Dec 18, 2019 at 11:21:30PM +0300, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> Hello,
>
> This series moves intermediate-clk handling from tegra20-cpufreq into
> tegra-clk driver. This allows us to switch to generic cpufreq-dt driver
> which brings voltage scaling, per-hardware OPPs and Tegra30 support out
> of the box. All boards need to adopt CPU OPPs in their device-trees in
> order to get cpufreq support.
>
> Changelog:
>
> v6: - Dropped "cpufreq: dt-platdev: Blacklist NVIDIA Tegra20 and Tegra30 SoCs"
> patch from the series since Viresh picked up that patch separately.
>
> - Added two new patches to this series:
>
> ARM: tegra: Switch CPU to PLLP on resume from LP1 on Tegra30/114/124
> ARM: tegra: Don't enable PLLX while resuming from LP1 on Tegra30
>
> Previously these patches were sent out separately from this series,
> but it should be more consistent to include them into the series since
> they directly relate to enabling of the cpufreq driver on Tegra30.
>
> v5: - The "Use generic cpufreq-dt driver (Tegra30 supported now)" patch
> is separated now into two patches by factoring out the blacklisting
> of cpufreq-dt-platdev into a standalone patch. This is done in a
> response to request from Jon Hunter to fix the warning splats during
> boot that are coming from OPP core because OPPs are unavailable. The
> OPPs will become available once tegra20-cpufreq driver will be updated
> to support the cpufreq-dt.
>
> v4: - Updated CCLK diagram in the "Add custom CCLK implementation" patch.
>
> - <linux/cpu.h> is now included in the "Use generic cpufreq-dt driver"
> patch, for consistency.
>
> - Returned value of get_cpu_device() is now checked in the "Use generic
> cpufreq-dt driver" patch, for consistency as well.
>
> v3: - The "Add custom CCLK implementation" patch was updated in accordance
> to the comments from Peter De Schrijver. We will not use the clock
> skipper.
>
> - Re added OPPs for T30 Beaver board because Thierry has that board ;)
>
> - Added r-b for the "DT binding" patch from Rob Herring.
>
> v2: - Kept modularity of the tegra20-cpufreq as was requested by Viresh Kumar
> in a review comment to v1.
>
> - Added acks from Viresh Kumar.
>
> - Added tested-by from Nicolas Chauvet to the "trimslice" patch.
> Nicolas told me on IRC that it works fine.
>
> - Fixed compilation of the "Add custom CCLK implementation" patch. The
> error happened because v1 was based on top of yet unreviewed/unapplied
> patch "clk: tegra: divider: Support enable-bit for Super clocks".
> Thanks to Peter Geis for reporting the problem.
>
> - Replaced Tegra30 "beaver" board with "cardhu-a04" because turned out
> that's what NVIDIA uses in the testing farm.
>
> Dmitry Osipenko (12):
> clk: tegra: Add custom CCLK implementation
> clk: tegra: pll: Add pre/post rate-change hooks
> clk: tegra: cclk: Add helpers for handling PLLX rate changes
> clk: tegra20: Use custom CCLK implementation
> clk: tegra30: Use custom CCLK implementation
> ARM: tegra: Switch CPU to PLLP on resume from LP1 on Tegra30/114/124
> ARM: tegra: Don't enable PLLX while resuming from LP1 on Tegra30
> dt-bindings: cpufreq: Add binding for NVIDIA Tegra20/30
> cpufreq: tegra20: Use generic cpufreq-dt driver (Tegra30 supported
> now)
> ARM: tegra: Create tegra20-cpufreq platform device on Tegra30
> ARM: dts: tegra30: beaver: Set up voltage regulators for DVFS
> ARM: dts: tegra30: beaver: Add CPU Operating Performance Points
>
> .../cpufreq/nvidia,tegra20-cpufreq.txt | 56 +++++
> arch/arm/boot/dts/tegra30-beaver.dts | 40 +++-
> arch/arm/mach-tegra/sleep-tegra30.S | 18 +-
> arch/arm/mach-tegra/tegra.c | 4 +
> drivers/clk/tegra/Makefile | 1 +
> drivers/clk/tegra/clk-pll.c | 12 +-
> drivers/clk/tegra/clk-tegra-super-cclk.c | 212 +++++++++++++++++
> drivers/clk/tegra/clk-tegra20.c | 7 +-
> drivers/clk/tegra/clk-tegra30.c | 6 +-
> drivers/clk/tegra/clk.h | 19 +-
> drivers/cpufreq/Kconfig.arm | 6 +-
> drivers/cpufreq/tegra20-cpufreq.c | 217 +++++-------------
> 12 files changed, 418 insertions(+), 180 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/cpufreq/nvidia,tegra20-cpufreq.txt
> create mode 100644 drivers/clk/tegra/clk-tegra-super-cclk.c
>
> --
> 2.24.0
>
next prev parent reply other threads:[~2020-01-14 15:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 20:21 [PATCH v6 00/12] NVIDIA Tegra20 CPUFreq driver major update Dmitry Osipenko
2019-12-18 20:21 ` [PATCH v6 01/12] clk: tegra: Add custom CCLK implementation Dmitry Osipenko
2019-12-18 20:21 ` [PATCH v6 02/12] clk: tegra: pll: Add pre/post rate-change hooks Dmitry Osipenko
2019-12-18 20:21 ` [PATCH v6 03/12] clk: tegra: cclk: Add helpers for handling PLLX rate changes Dmitry Osipenko
2019-12-18 20:21 ` [PATCH v6 04/12] clk: tegra20: Use custom CCLK implementation Dmitry Osipenko
2019-12-18 20:21 ` [PATCH v6 05/12] clk: tegra30: " Dmitry Osipenko
2019-12-18 20:21 ` [PATCH v6 06/12] ARM: tegra: Switch CPU to PLLP on resume from LP1 on Tegra30/114/124 Dmitry Osipenko
2019-12-18 20:21 ` [PATCH v6 07/12] ARM: tegra: Don't enable PLLX while resuming from LP1 on Tegra30 Dmitry Osipenko
2020-02-01 22:57 ` Marcel Ziswiler
2020-02-02 1:08 ` Dmitry Osipenko
2019-12-18 20:21 ` [PATCH v6 08/12] dt-bindings: cpufreq: Add binding for NVIDIA Tegra20/30 Dmitry Osipenko
2019-12-18 20:21 ` [PATCH v6 09/12] cpufreq: tegra20: Use generic cpufreq-dt driver (Tegra30 supported now) Dmitry Osipenko
2019-12-18 20:21 ` [PATCH v6 10/12] ARM: tegra: Create tegra20-cpufreq platform device on Tegra30 Dmitry Osipenko
2019-12-18 20:21 ` [PATCH v6 11/12] ARM: dts: tegra30: beaver: Set up voltage regulators for DVFS Dmitry Osipenko
2019-12-18 20:21 ` [PATCH v6 12/12] ARM: dts: tegra30: beaver: Add CPU Operating Performance Points Dmitry Osipenko
2020-01-07 23:17 ` [PATCH v6 00/12] NVIDIA Tegra20 CPUFreq driver major update Dmitry Osipenko
2020-01-14 15:53 ` Peter De Schrijver [this message]
2020-01-14 20:36 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114155306.GI28289@pdeschrijver-desktop.Nvidia.com \
--to=pdeschrijver@nvidia.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=mturquette@baylibre.com \
--cc=pgaikwad@nvidia.com \
--cc=pgwipeout@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).