* [PATCH 1/4] dt-bindings: net: fec: simplify yaml
2021-11-20 11:58 [PATCH 0/4] dt-bindings/dts: add i.MX8ULP FEC Peng Fan (OSS)
@ 2021-11-20 11:58 ` Peng Fan (OSS)
2021-11-22 2:07 ` Joakim Zhang
2021-11-30 2:03 ` Rob Herring
2021-11-20 11:58 ` [PATCH 2/4] dt-bindings: net: fec: Add imx8ulp compatible string Peng Fan (OSS)
` (2 subsequent siblings)
3 siblings, 2 replies; 14+ messages in thread
From: Peng Fan (OSS) @ 2021-11-20 11:58 UTC (permalink / raw)
To: robh+dt, aisheng.dong, qiangqing.zhang, davem, kuba, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, netdev, devicetree, linux-kernel,
linux-arm-kernel, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
i.MX7D, i.MX8MQ and i.MX8QM are compatible with i.MX6SX, so no need
to split them into three items.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Documentation/devicetree/bindings/net/fsl,fec.yaml | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
index eca41443fcce..dbf63a9c2a46 100644
--- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
@@ -39,9 +39,8 @@ properties:
- items:
- enum:
- fsl,imx7d-fec
- - const: fsl,imx6sx-fec
- - items:
- - const: fsl,imx8mq-fec
+ - fsl,imx8mq-fec
+ - fsl,imx8qm-fec
- const: fsl,imx6sx-fec
- items:
- enum:
@@ -50,9 +49,6 @@ properties:
- fsl,imx8mp-fec
- const: fsl,imx8mq-fec
- const: fsl,imx6sx-fec
- - items:
- - const: fsl,imx8qm-fec
- - const: fsl,imx6sx-fec
- items:
- enum:
- fsl,imx8qxp-fec
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
2021-11-20 11:58 ` [PATCH 1/4] dt-bindings: net: fec: simplify yaml Peng Fan (OSS)
@ 2021-11-22 2:07 ` Joakim Zhang
2021-11-23 9:29 ` Peng Fan
2021-11-30 2:03 ` Rob Herring
1 sibling, 1 reply; 14+ messages in thread
From: Joakim Zhang @ 2021-11-22 2:07 UTC (permalink / raw)
To: Peng Fan (OSS), robh+dt, Aisheng Dong, davem, kuba, shawnguo, s.hauer
Cc: kernel, festevam, dl-linux-imx, netdev, devicetree, linux-kernel,
linux-arm-kernel, Peng Fan
Hi Peng,
Thanks a lot for helping upstream this patch set.
For this change, have you run 'make dtbs_check'? I remember that split them to pass dtbs_check when convert it into yaml.
Best Regards,
Joakim Zhang
> -----Original Message-----
> From: Peng Fan (OSS) <peng.fan@oss.nxp.com>
> Sent: 2021年11月20日 19:58
> To: robh+dt@kernel.org; Aisheng Dong <aisheng.dong@nxp.com>; Joakim
> Zhang <qiangqing.zhang@nxp.com>; davem@davemloft.net;
> kuba@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de
> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> <linux-imx@nxp.com>; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; Peng Fan <peng.fan@nxp.com>
> Subject: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
>
> From: Peng Fan <peng.fan@nxp.com>
>
> i.MX7D, i.MX8MQ and i.MX8QM are compatible with i.MX6SX, so no need to
> split them into three items.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> Documentation/devicetree/bindings/net/fsl,fec.yaml | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> index eca41443fcce..dbf63a9c2a46 100644
> --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> @@ -39,9 +39,8 @@ properties:
> - items:
> - enum:
> - fsl,imx7d-fec
> - - const: fsl,imx6sx-fec
> - - items:
> - - const: fsl,imx8mq-fec
> + - fsl,imx8mq-fec
> + - fsl,imx8qm-fec
> - const: fsl,imx6sx-fec
> - items:
> - enum:
> @@ -50,9 +49,6 @@ properties:
> - fsl,imx8mp-fec
> - const: fsl,imx8mq-fec
> - const: fsl,imx6sx-fec
> - - items:
> - - const: fsl,imx8qm-fec
> - - const: fsl,imx6sx-fec
> - items:
> - enum:
> - fsl,imx8qxp-fec
> --
> 2.25.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
2021-11-22 2:07 ` Joakim Zhang
@ 2021-11-23 9:29 ` Peng Fan
2021-11-23 10:39 ` Joakim Zhang
0 siblings, 1 reply; 14+ messages in thread
From: Peng Fan @ 2021-11-23 9:29 UTC (permalink / raw)
To: Joakim Zhang, Peng Fan (OSS),
robh+dt, Aisheng Dong, davem, kuba, shawnguo, s.hauer
Cc: kernel, festevam, dl-linux-imx, netdev, devicetree, linux-kernel,
linux-arm-kernel
> Subject: RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
>
>
> Hi Peng,
>
> Thanks a lot for helping upstream this patch set.
>
> For this change, have you run 'make dtbs_check'? I remember that split them
> to pass dtbs_check when convert it into yaml.
" arch/arm/boot/dts/imx6dl-nitrogen6x.dt.yaml:
ethernet@2188000: More than one condition true in oneOf schema: "
But this is not introduced by my patch, it already there even drop my
patch.
I not see other issues.
Thanks,
Peng.
>
> Best Regards,
> Joakim Zhang
> > -----Original Message-----
> > From: Peng Fan (OSS) <peng.fan@oss.nxp.com>
> > Sent: 2021年11月20日 19:58
> > To: robh+dt@kernel.org; Aisheng Dong <aisheng.dong@nxp.com>; Joakim
> > Zhang <qiangqing.zhang@nxp.com>; davem@davemloft.net;
> kuba@kernel.org;
> > shawnguo@kernel.org; s.hauer@pengutronix.de
> > Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> > <linux-imx@nxp.com>; netdev@vger.kernel.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org; Peng Fan <peng.fan@nxp.com>
> > Subject: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > i.MX7D, i.MX8MQ and i.MX8QM are compatible with i.MX6SX, so no need
> to
> > split them into three items.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > Documentation/devicetree/bindings/net/fsl,fec.yaml | 8 ++------
> > 1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > index eca41443fcce..dbf63a9c2a46 100644
> > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > @@ -39,9 +39,8 @@ properties:
> > - items:
> > - enum:
> > - fsl,imx7d-fec
> > - - const: fsl,imx6sx-fec
> > - - items:
> > - - const: fsl,imx8mq-fec
> > + - fsl,imx8mq-fec
> > + - fsl,imx8qm-fec
> > - const: fsl,imx6sx-fec
> > - items:
> > - enum:
> > @@ -50,9 +49,6 @@ properties:
> > - fsl,imx8mp-fec
> > - const: fsl,imx8mq-fec
> > - const: fsl,imx6sx-fec
> > - - items:
> > - - const: fsl,imx8qm-fec
> > - - const: fsl,imx6sx-fec
> > - items:
> > - enum:
> > - fsl,imx8qxp-fec
> > --
> > 2.25.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
2021-11-23 9:29 ` Peng Fan
@ 2021-11-23 10:39 ` Joakim Zhang
0 siblings, 0 replies; 14+ messages in thread
From: Joakim Zhang @ 2021-11-23 10:39 UTC (permalink / raw)
To: Peng Fan, Peng Fan (OSS),
robh+dt, Aisheng Dong, davem, kuba, shawnguo, s.hauer
Cc: kernel, festevam, dl-linux-imx, netdev, devicetree, linux-kernel,
linux-arm-kernel
Hi Peng,
> -----Original Message-----
> From: Peng Fan <peng.fan@nxp.com>
> Sent: 2021年11月23日 17:29
> To: Joakim Zhang <qiangqing.zhang@nxp.com>; Peng Fan (OSS)
> <peng.fan@oss.nxp.com>; robh+dt@kernel.org; Aisheng Dong
> <aisheng.dong@nxp.com>; davem@davemloft.net; kuba@kernel.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de
> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> <linux-imx@nxp.com>; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org
> Subject: RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
>
> > Subject: RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
> >
> >
> > Hi Peng,
> >
> > Thanks a lot for helping upstream this patch set.
> >
> > For this change, have you run 'make dtbs_check'? I remember that split
> > them to pass dtbs_check when convert it into yaml.
>
> " arch/arm/boot/dts/imx6dl-nitrogen6x.dt.yaml:
> ethernet@2188000: More than one condition true in oneOf schema: "
>
> But this is not introduced by my patch, it already there even drop my patch.
>
> I not see other issues.
For this error: ethernet@2188000: More than one condition true in oneOf schema:
This is caused by ['interrupts'] and ['interrupts-extended'], this should be a common limitation, this is a known warning.
'oneOf': [{'required': ['interrupts']},
{'required': ['interrupts-extended']}],
After applying this patch, I verified on both arm and arm64 platforms, indeed there is no regression targets to ['compatible']. I am okay with this patch, sorry for this inconvenience.
Best Regards,
Joakim Zhang
> Thanks,
> Peng.
>
> >
> > Best Regards,
> > Joakim Zhang
> > > -----Original Message-----
> > > From: Peng Fan (OSS) <peng.fan@oss.nxp.com>
> > > Sent: 2021年11月20日 19:58
> > > To: robh+dt@kernel.org; Aisheng Dong <aisheng.dong@nxp.com>;
> Joakim
> > > Zhang <qiangqing.zhang@nxp.com>; davem@davemloft.net;
> > kuba@kernel.org;
> > > shawnguo@kernel.org; s.hauer@pengutronix.de
> > > Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> > > <linux-imx@nxp.com>; netdev@vger.kernel.org;
> > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > linux-arm-kernel@lists.infradead.org; Peng Fan <peng.fan@nxp.com>
> > > Subject: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
> > >
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > i.MX7D, i.MX8MQ and i.MX8QM are compatible with i.MX6SX, so no need
> > to
> > > split them into three items.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > > Documentation/devicetree/bindings/net/fsl,fec.yaml | 8 ++------
> > > 1 file changed, 2 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > > b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > > index eca41443fcce..dbf63a9c2a46 100644
> > > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > > @@ -39,9 +39,8 @@ properties:
> > > - items:
> > > - enum:
> > > - fsl,imx7d-fec
> > > - - const: fsl,imx6sx-fec
> > > - - items:
> > > - - const: fsl,imx8mq-fec
> > > + - fsl,imx8mq-fec
> > > + - fsl,imx8qm-fec
> > > - const: fsl,imx6sx-fec
> > > - items:
> > > - enum:
> > > @@ -50,9 +49,6 @@ properties:
> > > - fsl,imx8mp-fec
> > > - const: fsl,imx8mq-fec
> > > - const: fsl,imx6sx-fec
> > > - - items:
> > > - - const: fsl,imx8qm-fec
> > > - - const: fsl,imx6sx-fec
> > > - items:
> > > - enum:
> > > - fsl,imx8qxp-fec
> > > --
> > > 2.25.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
2021-11-20 11:58 ` [PATCH 1/4] dt-bindings: net: fec: simplify yaml Peng Fan (OSS)
2021-11-22 2:07 ` Joakim Zhang
@ 2021-11-30 2:03 ` Rob Herring
1 sibling, 0 replies; 14+ messages in thread
From: Rob Herring @ 2021-11-30 2:03 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: linux-kernel, s.hauer, shawnguo, devicetree, aisheng.dong,
linux-imx, robh+dt, kuba, Peng Fan, davem, netdev,
linux-arm-kernel, festevam, kernel, qiangqing.zhang
On Sat, 20 Nov 2021 19:58:22 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> i.MX7D, i.MX8MQ and i.MX8QM are compatible with i.MX6SX, so no need
> to split them into three items.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> Documentation/devicetree/bindings/net/fsl,fec.yaml | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/4] dt-bindings: net: fec: Add imx8ulp compatible string
2021-11-20 11:58 [PATCH 0/4] dt-bindings/dts: add i.MX8ULP FEC Peng Fan (OSS)
2021-11-20 11:58 ` [PATCH 1/4] dt-bindings: net: fec: simplify yaml Peng Fan (OSS)
@ 2021-11-20 11:58 ` Peng Fan (OSS)
2021-11-30 2:04 ` Rob Herring
2021-11-20 11:58 ` [PATCH 3/4] arm64: dts: imx8ulp: add fec node Peng Fan (OSS)
2021-11-20 11:58 ` [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec Peng Fan (OSS)
3 siblings, 1 reply; 14+ messages in thread
From: Peng Fan (OSS) @ 2021-11-20 11:58 UTC (permalink / raw)
To: robh+dt, aisheng.dong, qiangqing.zhang, davem, kuba, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, netdev, devicetree, linux-kernel,
linux-arm-kernel, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
The fec on i.MX8ULP is derived from i.MX6UL, it uses two compatible
strings, so update the compatible string for i.MX8ULP.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Documentation/devicetree/bindings/net/fsl,fec.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
index dbf63a9c2a46..979fbc73f0b6 100644
--- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
@@ -55,6 +55,10 @@ properties:
- const: fsl,imx8qm-fec
- const: fsl,imx6sx-fec
+ - items:
+ - const: fsl,imx8ulp-fec
+ - const: fsl,imx6ul-fec
+
reg:
maxItems: 1
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 2/4] dt-bindings: net: fec: Add imx8ulp compatible string
2021-11-20 11:58 ` [PATCH 2/4] dt-bindings: net: fec: Add imx8ulp compatible string Peng Fan (OSS)
@ 2021-11-30 2:04 ` Rob Herring
0 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2021-11-30 2:04 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: qiangqing.zhang, festevam, linux-kernel, davem, shawnguo,
s.hauer, linux-imx, robh+dt, kernel, linux-arm-kernel, Peng Fan,
aisheng.dong, netdev, kuba, devicetree
On Sat, 20 Nov 2021 19:58:23 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> The fec on i.MX8ULP is derived from i.MX6UL, it uses two compatible
> strings, so update the compatible string for i.MX8ULP.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> Documentation/devicetree/bindings/net/fsl,fec.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/4] arm64: dts: imx8ulp: add fec node
2021-11-20 11:58 [PATCH 0/4] dt-bindings/dts: add i.MX8ULP FEC Peng Fan (OSS)
2021-11-20 11:58 ` [PATCH 1/4] dt-bindings: net: fec: simplify yaml Peng Fan (OSS)
2021-11-20 11:58 ` [PATCH 2/4] dt-bindings: net: fec: Add imx8ulp compatible string Peng Fan (OSS)
@ 2021-11-20 11:58 ` Peng Fan (OSS)
2021-11-22 2:07 ` Joakim Zhang
2021-11-20 11:58 ` [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec Peng Fan (OSS)
3 siblings, 1 reply; 14+ messages in thread
From: Peng Fan (OSS) @ 2021-11-20 11:58 UTC (permalink / raw)
To: robh+dt, aisheng.dong, qiangqing.zhang, davem, kuba, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, netdev, devicetree, linux-kernel,
linux-arm-kernel, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Add ethernet node and its alias
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
index edac63cf3668..e3c658b45ae6 100644
--- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
@@ -16,6 +16,7 @@ / {
#size-cells = <2>;
aliases {
+ ethernet0 = &fec;
gpio0 = &gpiod;
gpio1 = &gpioe;
gpio2 = &gpiof;
@@ -365,6 +366,23 @@ usdhc2: mmc@298f0000 {
bus-width = <4>;
status = "disabled";
};
+
+ fec: ethernet@29950000 {
+ compatible = "fsl,imx8ulp-fec", "fsl,imx6ul-fec";
+ reg = <0x29950000 0x10000>;
+ interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "int0";
+ clocks = <&pcc4 IMX8ULP_CLK_ENET>,
+ <&pcc4 IMX8ULP_CLK_ENET>,
+ <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>;
+ clock-names = "ipg", "ahb", "ptp";
+ assigned-clocks = <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>;
+ assigned-clock-parents = <&sosc>;
+ assigned-clock-rates = <24000000>;
+ fsl,num-tx-queues = <1>;
+ fsl,num-rx-queues = <1>;
+ status = "disabled";
+ };
};
gpioe: gpio@2d000000 {
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* RE: [PATCH 3/4] arm64: dts: imx8ulp: add fec node
2021-11-20 11:58 ` [PATCH 3/4] arm64: dts: imx8ulp: add fec node Peng Fan (OSS)
@ 2021-11-22 2:07 ` Joakim Zhang
0 siblings, 0 replies; 14+ messages in thread
From: Joakim Zhang @ 2021-11-22 2:07 UTC (permalink / raw)
To: Peng Fan (OSS), robh+dt, Aisheng Dong, davem, kuba, shawnguo, s.hauer
Cc: kernel, festevam, dl-linux-imx, netdev, devicetree, linux-kernel,
linux-arm-kernel, Peng Fan
Hi Peng,
I saw it's not the latest version(clock setting) compared to our local implementation, could you help update it or need a follow up later?
Best Regards,
Joakim Zhang
> -----Original Message-----
> From: Peng Fan (OSS) <peng.fan@oss.nxp.com>
> Sent: 2021年11月20日 19:58
> To: robh+dt@kernel.org; Aisheng Dong <aisheng.dong@nxp.com>; Joakim
> Zhang <qiangqing.zhang@nxp.com>; davem@davemloft.net;
> kuba@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de
> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> <linux-imx@nxp.com>; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; Peng Fan <peng.fan@nxp.com>
> Subject: [PATCH 3/4] arm64: dts: imx8ulp: add fec node
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Add ethernet node and its alias
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index edac63cf3668..e3c658b45ae6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> @@ -16,6 +16,7 @@ / {
> #size-cells = <2>;
>
> aliases {
> + ethernet0 = &fec;
> gpio0 = &gpiod;
> gpio1 = &gpioe;
> gpio2 = &gpiof;
> @@ -365,6 +366,23 @@ usdhc2: mmc@298f0000 {
> bus-width = <4>;
> status = "disabled";
> };
> +
> + fec: ethernet@29950000 {
> + compatible = "fsl,imx8ulp-fec", "fsl,imx6ul-fec";
> + reg = <0x29950000 0x10000>;
> + interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "int0";
> + clocks = <&pcc4 IMX8ULP_CLK_ENET>,
> + <&pcc4 IMX8ULP_CLK_ENET>,
> + <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>;
> + clock-names = "ipg", "ahb", "ptp";
> + assigned-clocks = <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>;
> + assigned-clock-parents = <&sosc>;
> + assigned-clock-rates = <24000000>;
> + fsl,num-tx-queues = <1>;
> + fsl,num-rx-queues = <1>;
> + status = "disabled";
> + };
> };
>
> gpioe: gpio@2d000000 {
> --
> 2.25.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
2021-11-20 11:58 [PATCH 0/4] dt-bindings/dts: add i.MX8ULP FEC Peng Fan (OSS)
` (2 preceding siblings ...)
2021-11-20 11:58 ` [PATCH 3/4] arm64: dts: imx8ulp: add fec node Peng Fan (OSS)
@ 2021-11-20 11:58 ` Peng Fan (OSS)
2021-11-20 15:26 ` Andrew Lunn
3 siblings, 1 reply; 14+ messages in thread
From: Peng Fan (OSS) @ 2021-11-20 11:58 UTC (permalink / raw)
To: robh+dt, aisheng.dong, qiangqing.zhang, davem, kuba, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, netdev, devicetree, linux-kernel,
linux-arm-kernel, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Enable fec, add pinctrl for fec
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 34 +++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
index 33e84c4e9ed8..7103fed3a6cc 100644
--- a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
@@ -21,6 +21,24 @@ memory@80000000 {
};
};
+&fec {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_enet>;
+ phy-mode = "rmii";
+ phy-handle = <ðphy>;
+ status = "okay";
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethphy: ethernet-phy {
+ reg = <1>;
+ micrel,led-mode = <1>;
+ };
+ };
+};
+
&lpuart5 {
/* console */
pinctrl-names = "default", "sleep";
@@ -39,6 +57,22 @@ &usdhc0 {
};
&iomuxc1 {
+ pinctrl_enet: enetgrp {
+ fsl,pins = <
+ MX8ULP_PAD_PTE15__ENET0_MDC 0x43
+ MX8ULP_PAD_PTE14__ENET0_MDIO 0x43
+ MX8ULP_PAD_PTE17__ENET0_RXER 0x43
+ MX8ULP_PAD_PTE18__ENET0_CRS_DV 0x43
+ MX8ULP_PAD_PTF1__ENET0_RXD0 0x43
+ MX8ULP_PAD_PTE20__ENET0_RXD1 0x43
+ MX8ULP_PAD_PTE16__ENET0_TXEN 0x43
+ MX8ULP_PAD_PTE23__ENET0_TXD0 0x43
+ MX8ULP_PAD_PTE22__ENET0_TXD1 0x43
+ MX8ULP_PAD_PTE19__ENET0_REFCLK 0x43
+ MX8ULP_PAD_PTF10__ENET0_1588_CLKIN 0x43
+ >;
+ };
+
pinctrl_lpuart5: lpuart5grp {
fsl,pins = <
MX8ULP_PAD_PTF14__LPUART5_TX 0x3
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
2021-11-20 11:58 ` [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec Peng Fan (OSS)
@ 2021-11-20 15:26 ` Andrew Lunn
2021-11-22 1:04 ` Peng Fan
0 siblings, 1 reply; 14+ messages in thread
From: Andrew Lunn @ 2021-11-20 15:26 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: robh+dt, aisheng.dong, qiangqing.zhang, davem, kuba, shawnguo,
s.hauer, kernel, festevam, linux-imx, netdev, devicetree,
linux-kernel, linux-arm-kernel, Peng Fan
> +&fec {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_enet>;
> + phy-mode = "rmii";
Is this really a Fast Ethernet? Not 1G?
> + phy-handle = <ðphy>;
> + status = "okay";
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethphy: ethernet-phy {
> + reg = <1>;
I'm surprised this does not give warnings from the DTS tools. There is
a reg value, so it should be ethernet-phy@1
Andrew
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
2021-11-20 15:26 ` Andrew Lunn
@ 2021-11-22 1:04 ` Peng Fan
2021-11-22 2:08 ` Joakim Zhang
0 siblings, 1 reply; 14+ messages in thread
From: Peng Fan @ 2021-11-22 1:04 UTC (permalink / raw)
To: Andrew Lunn, Peng Fan (OSS)
Cc: robh+dt, Aisheng Dong, Joakim Zhang, davem, kuba, shawnguo,
s.hauer, kernel, festevam, dl-linux-imx, netdev, devicetree,
linux-kernel, linux-arm-kernel
> Subject: Re: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
>
> > +&fec {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_enet>;
> > + phy-mode = "rmii";
>
> Is this really a Fast Ethernet? Not 1G?
Not 1G. it only support 10M/100M ethernet.
>
> > + phy-handle = <ðphy>;
> > + status = "okay";
> > +
> > + mdio {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + ethphy: ethernet-phy {
> > + reg = <1>;
>
> I'm surprised this does not give warnings from the DTS tools. There is a reg
> value, so it should be ethernet-phy@1
I not see warning per my build:
"
*** Default configuration is based on 'defconfig'
#
# No change to .config
#
CALL scripts/atomic/check-atomics.sh
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
DTC arch/arm64/boot/dts/freescale/imx8ulp-evk.dtb
"
Anyway I will check and fix if the node needs a fix.
Thanks,
Peng
>
> Andrew
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
2021-11-22 1:04 ` Peng Fan
@ 2021-11-22 2:08 ` Joakim Zhang
0 siblings, 0 replies; 14+ messages in thread
From: Joakim Zhang @ 2021-11-22 2:08 UTC (permalink / raw)
To: Peng Fan, Andrew Lunn, Peng Fan (OSS)
Cc: robh+dt, Aisheng Dong, davem, kuba, shawnguo, s.hauer, kernel,
festevam, dl-linux-imx, netdev, devicetree, linux-kernel,
linux-arm-kernel
Hi Peng,
> -----Original Message-----
> From: Peng Fan <peng.fan@nxp.com>
> Sent: 2021年11月22日 9:04
> To: Andrew Lunn <andrew@lunn.ch>; Peng Fan (OSS)
> <peng.fan@oss.nxp.com>
> Cc: robh+dt@kernel.org; Aisheng Dong <aisheng.dong@nxp.com>; Joakim
> Zhang <qiangqing.zhang@nxp.com>; davem@davemloft.net;
> kuba@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> <linux-imx@nxp.com>; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org
> Subject: RE: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
>
> > Subject: Re: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
> >
> > > +&fec {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_enet>;
> > > + phy-mode = "rmii";
> >
> > Is this really a Fast Ethernet? Not 1G?
>
> Not 1G. it only support 10M/100M ethernet.
>
> >
> > > + phy-handle = <ðphy>;
> > > + status = "okay";
> > > +
> > > + mdio {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > + ethphy: ethernet-phy {
> > > + reg = <1>;
> >
> > I'm surprised this does not give warnings from the DTS tools. There is
> > a reg value, so it should be ethernet-phy@1
>
> I not see warning per my build:
> "
> *** Default configuration is based on 'defconfig'
> #
> # No change to .config
> #
> CALL scripts/atomic/check-atomics.sh
> CALL scripts/checksyscalls.sh
> CHK include/generated/compile.h
> DTC arch/arm64/boot/dts/freescale/imx8ulp-evk.dtb
> "
> Anyway I will check and fix if the node needs a fix.
According to PHY guide, Documentation/devicetree/bindings/net/ethernet-phy.yaml, yes, we need write to ' ethernet-phy@1'.
DTS tool may not complain it, I guess 'make dtbs_check' could give a warning...
Best Regards,
Joakim Zhang
> Thanks,
> Peng
>
> >
> > Andrew
^ permalink raw reply [flat|nested] 14+ messages in thread