* [PATCH] i3c: master: dw-i3c-master: mark expected switch fall-through
@ 2019-02-11 22:14 Gustavo A. R. Silva
2019-02-27 3:53 ` Gustavo A. R. Silva
0 siblings, 1 reply; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-11 22:14 UTC (permalink / raw)
To: Vitor Soares, Boris Brezillon
Cc: linux-i3c, linux-kernel, Kees Cook, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/i3c/master/dw-i3c-master.c: In function ‘dw_i3c_master_bus_init’:
drivers/i3c/master/dw-i3c-master.c:603:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (ret)
^
drivers/i3c/master/dw-i3c-master.c:605:2: note: here
case I3C_BUS_MODE_PURE:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/i3c/master/dw-i3c-master.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
index bb03079fbade..59279224e07f 100644
--- a/drivers/i3c/master/dw-i3c-master.c
+++ b/drivers/i3c/master/dw-i3c-master.c
@@ -602,6 +602,7 @@ static int dw_i3c_master_bus_init(struct i3c_master_controller *m)
ret = dw_i2c_clk_cfg(master);
if (ret)
return ret;
+ /* fall through */
case I3C_BUS_MODE_PURE:
ret = dw_i3c_clk_cfg(master);
if (ret)
--
2.20.1
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] i3c: master: dw-i3c-master: mark expected switch fall-through
2019-02-11 22:14 [PATCH] i3c: master: dw-i3c-master: mark expected switch fall-through Gustavo A. R. Silva
@ 2019-02-27 3:53 ` Gustavo A. R. Silva
2019-02-27 8:13 ` Boris Brezillon
2019-02-27 10:33 ` vitor
0 siblings, 2 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-27 3:53 UTC (permalink / raw)
To: Vitor Soares, Boris Brezillon; +Cc: linux-i3c, linux-kernel, Kees Cook
Hi all,
Friendly ping:
Who can ack or review this, please?
Thanks
--
Gustavo
On 2/11/19 4:14 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/i3c/master/dw-i3c-master.c: In function ‘dw_i3c_master_bus_init’:
> drivers/i3c/master/dw-i3c-master.c:603:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (ret)
> ^
> drivers/i3c/master/dw-i3c-master.c:605:2: note: here
> case I3C_BUS_MODE_PURE:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/i3c/master/dw-i3c-master.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index bb03079fbade..59279224e07f 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -602,6 +602,7 @@ static int dw_i3c_master_bus_init(struct i3c_master_controller *m)
> ret = dw_i2c_clk_cfg(master);
> if (ret)
> return ret;
> + /* fall through */
> case I3C_BUS_MODE_PURE:
> ret = dw_i3c_clk_cfg(master);
> if (ret)
>
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i3c: master: dw-i3c-master: mark expected switch fall-through
2019-02-27 3:53 ` Gustavo A. R. Silva
@ 2019-02-27 8:13 ` Boris Brezillon
2019-02-27 20:13 ` Gustavo A. R. Silva
2019-02-27 10:33 ` vitor
1 sibling, 1 reply; 5+ messages in thread
From: Boris Brezillon @ 2019-02-27 8:13 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: linux-i3c, linux-kernel, Kees Cook, Vitor Soares
On Tue, 26 Feb 2019 21:53:16 -0600
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> Hi all,
>
> Friendly ping:
>
> Who can ack or review this, please?
Will be queued for the next release. Please be patient.
>
> Thanks
> --
> Gustavo
>
> On 2/11/19 4:14 PM, Gustavo A. R. Silva wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch
> > cases where we are expecting to fall through.
> >
> > This patch fixes the following warning:
> >
> > drivers/i3c/master/dw-i3c-master.c: In function ‘dw_i3c_master_bus_init’:
> > drivers/i3c/master/dw-i3c-master.c:603:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> > if (ret)
> > ^
> > drivers/i3c/master/dw-i3c-master.c:605:2: note: here
> > case I3C_BUS_MODE_PURE:
> > ^~~~
> >
> > Warning level 3 was used: -Wimplicit-fallthrough=3
> >
> > This patch is part of the ongoing efforts to enable
> > -Wimplicit-fallthrough.
> >
> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> > ---
> > drivers/i3c/master/dw-i3c-master.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> > index bb03079fbade..59279224e07f 100644
> > --- a/drivers/i3c/master/dw-i3c-master.c
> > +++ b/drivers/i3c/master/dw-i3c-master.c
> > @@ -602,6 +602,7 @@ static int dw_i3c_master_bus_init(struct i3c_master_controller *m)
> > ret = dw_i2c_clk_cfg(master);
> > if (ret)
> > return ret;
> > + /* fall through */
> > case I3C_BUS_MODE_PURE:
> > ret = dw_i3c_clk_cfg(master);
> > if (ret)
> >
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i3c: master: dw-i3c-master: mark expected switch fall-through
2019-02-27 8:13 ` Boris Brezillon
@ 2019-02-27 20:13 ` Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-27 20:13 UTC (permalink / raw)
To: Boris Brezillon; +Cc: linux-i3c, linux-kernel, Kees Cook, Vitor Soares
Hi Boris,
On 2/27/19 2:13 AM, Boris Brezillon wrote:
> On Tue, 26 Feb 2019 21:53:16 -0600
> "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
>
>> Hi all,
>>
>> Friendly ping:
>>
>> Who can ack or review this, please?
>
> Will be queued for the next release. Please be patient.
>
Great. Good to know. :)
Sure thing. I waited for two weeks before pinging.
Thanks
--
Gustavo
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i3c: master: dw-i3c-master: mark expected switch fall-through
2019-02-27 3:53 ` Gustavo A. R. Silva
2019-02-27 8:13 ` Boris Brezillon
@ 2019-02-27 10:33 ` vitor
1 sibling, 0 replies; 5+ messages in thread
From: vitor @ 2019-02-27 10:33 UTC (permalink / raw)
To: Gustavo A. R. Silva, Vitor Soares, Boris Brezillon
Cc: linux-i3c, linux-kernel, Kees Cook
Hi Gustavo,
Sorry for the delay.
On 27/02/19 03:53, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping:
>
> Who can ack or review this, please?
>
> Thanks
> --
> Gustavo
>
> On 2/11/19 4:14 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/i3c/master/dw-i3c-master.c: In function ‘dw_i3c_master_bus_init’:
>> drivers/i3c/master/dw-i3c-master.c:603:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (ret)
>> ^
>> drivers/i3c/master/dw-i3c-master.c:605:2: note: here
>> case I3C_BUS_MODE_PURE:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/i3c/master/dw-i3c-master.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
>> index bb03079fbade..59279224e07f 100644
>> --- a/drivers/i3c/master/dw-i3c-master.c
>> +++ b/drivers/i3c/master/dw-i3c-master.c
>> @@ -602,6 +602,7 @@ static int dw_i3c_master_bus_init(struct i3c_master_controller *m)
>> ret = dw_i2c_clk_cfg(master);
>> if (ret)
>> return ret;
>> + /* fall through */
>> case I3C_BUS_MODE_PURE:
>> ret = dw_i3c_clk_cfg(master);
>> if (ret)
>>
Acked-by: Vitor Soares <vitor.soares@synopsys.com>
Best regards,
Vitor Soares
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-28 19:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-11 22:14 [PATCH] i3c: master: dw-i3c-master: mark expected switch fall-through Gustavo A. R. Silva
2019-02-27 3:53 ` Gustavo A. R. Silva
2019-02-27 8:13 ` Boris Brezillon
2019-02-27 20:13 ` Gustavo A. R. Silva
2019-02-27 10:33 ` vitor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).