* [PATCH 0/2] iio: adc: stm32-dfsdm: manage error cases in probe @ 2019-04-24 12:51 Fabien Dessenne 2019-04-24 12:51 ` [PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case Fabien Dessenne 2019-04-24 12:51 ` [PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe Fabien Dessenne 0 siblings, 2 replies; 7+ messages in thread From: Fabien Dessenne @ 2019-04-24 12:51 UTC (permalink / raw) To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler, Maxime Coquelin, Alexandre Torgue, Fabrice Gasnier, linux-iio, linux-stm32, linux-arm-kernel, linux-kernel Cc: Fabien Dessenne This patchset adds some check of the returned error code in probe. Fabien Dessenne (2): iio: adc: stm32-dfsdm: manage the get_irq error case iio: adc: stm32-dfsdm: missing error case during probe drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++++++ drivers/iio/adc/stm32-dfsdm-core.c | 8 ++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case 2019-04-24 12:51 [PATCH 0/2] iio: adc: stm32-dfsdm: manage error cases in probe Fabien Dessenne @ 2019-04-24 12:51 ` Fabien Dessenne 2019-04-24 12:55 ` Fabrice Gasnier 2019-04-24 12:51 ` [PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe Fabien Dessenne 1 sibling, 1 reply; 7+ messages in thread From: Fabien Dessenne @ 2019-04-24 12:51 UTC (permalink / raw) To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler, Maxime Coquelin, Alexandre Torgue, Fabrice Gasnier, linux-iio, linux-stm32, linux-arm-kernel, linux-kernel Cc: Fabien Dessenne During probe, check the "get_irq" error value. Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com> --- drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c index 19adc2b..588907c 100644 --- a/drivers/iio/adc/stm32-dfsdm-adc.c +++ b/drivers/iio/adc/stm32-dfsdm-adc.c @@ -1456,6 +1456,12 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev) * So IRQ associated to filter instance 0 is dedicated to the Filter 0. */ irq = platform_get_irq(pdev, 0); + if (irq < 0) { + if (irq != -EPROBE_DEFER) + dev_err(dev, "Failed to get IRQ: %d\n", irq); + return irq; + } + ret = devm_request_irq(dev, irq, stm32_dfsdm_irq, 0, pdev->name, adc); if (ret < 0) { -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case 2019-04-24 12:51 ` [PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case Fabien Dessenne @ 2019-04-24 12:55 ` Fabrice Gasnier 2019-04-27 13:08 ` Jonathan Cameron 0 siblings, 1 reply; 7+ messages in thread From: Fabrice Gasnier @ 2019-04-24 12:55 UTC (permalink / raw) To: Fabien Dessenne, Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler, Maxime Coquelin, Alexandre Torgue, linux-iio, linux-stm32, linux-arm-kernel, linux-kernel On 4/24/19 2:51 PM, Fabien Dessenne wrote: > During probe, check the "get_irq" error value. > > Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com> > --- Hi Fabien, Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com> Thanks, Fabrice > drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > index 19adc2b..588907c 100644 > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > @@ -1456,6 +1456,12 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev) > * So IRQ associated to filter instance 0 is dedicated to the Filter 0. > */ > irq = platform_get_irq(pdev, 0); > + if (irq < 0) { > + if (irq != -EPROBE_DEFER) > + dev_err(dev, "Failed to get IRQ: %d\n", irq); > + return irq; > + } > + > ret = devm_request_irq(dev, irq, stm32_dfsdm_irq, > 0, pdev->name, adc); > if (ret < 0) { > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case 2019-04-24 12:55 ` Fabrice Gasnier @ 2019-04-27 13:08 ` Jonathan Cameron 0 siblings, 0 replies; 7+ messages in thread From: Jonathan Cameron @ 2019-04-27 13:08 UTC (permalink / raw) To: Fabrice Gasnier Cc: Fabien Dessenne, Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler, Maxime Coquelin, Alexandre Torgue, linux-iio, linux-stm32, linux-arm-kernel, linux-kernel On Wed, 24 Apr 2019 14:55:09 +0200 Fabrice Gasnier <fabrice.gasnier@st.com> wrote: > On 4/24/19 2:51 PM, Fabien Dessenne wrote: > > During probe, check the "get_irq" error value. > > > > Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com> > > --- > > Hi Fabien, > > Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > > Thanks, > Fabrice > > > drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > > index 19adc2b..588907c 100644 > > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > > @@ -1456,6 +1456,12 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev) > > * So IRQ associated to filter instance 0 is dedicated to the Filter 0. > > */ > > irq = platform_get_irq(pdev, 0); > > + if (irq < 0) { > > + if (irq != -EPROBE_DEFER) > > + dev_err(dev, "Failed to get IRQ: %d\n", irq); > > + return irq; > > + } > > + > > ret = devm_request_irq(dev, irq, stm32_dfsdm_irq, > > 0, pdev->name, adc); > > if (ret < 0) { > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe 2019-04-24 12:51 [PATCH 0/2] iio: adc: stm32-dfsdm: manage error cases in probe Fabien Dessenne 2019-04-24 12:51 ` [PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case Fabien Dessenne @ 2019-04-24 12:51 ` Fabien Dessenne 2019-04-24 12:55 ` Fabrice Gasnier 1 sibling, 1 reply; 7+ messages in thread From: Fabien Dessenne @ 2019-04-24 12:51 UTC (permalink / raw) To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler, Maxime Coquelin, Alexandre Torgue, Fabrice Gasnier, linux-iio, linux-stm32, linux-arm-kernel, linux-kernel Cc: Fabien Dessenne During probe, check the devm_ioremap_resource() error value. Also return the devm_clk_get() error value instead of -EINVAL. Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com> --- drivers/iio/adc/stm32-dfsdm-core.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c index 0a4d374..26e2011 100644 --- a/drivers/iio/adc/stm32-dfsdm-core.c +++ b/drivers/iio/adc/stm32-dfsdm-core.c @@ -233,6 +233,8 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev, } priv->dfsdm.phys_base = res->start; priv->dfsdm.base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(priv->dfsdm.base)) + return PTR_ERR(priv->dfsdm.base); /* * "dfsdm" clock is mandatory for DFSDM peripheral clocking. @@ -242,8 +244,10 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev, */ priv->clk = devm_clk_get(&pdev->dev, "dfsdm"); if (IS_ERR(priv->clk)) { - dev_err(&pdev->dev, "No stm32_dfsdm_clk clock found\n"); - return -EINVAL; + ret = PTR_ERR(priv->clk); + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, "Failed to get clock (%d)\n", ret); + return ret; } priv->aclk = devm_clk_get(&pdev->dev, "audio"); -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe 2019-04-24 12:51 ` [PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe Fabien Dessenne @ 2019-04-24 12:55 ` Fabrice Gasnier 2019-04-27 13:10 ` Jonathan Cameron 0 siblings, 1 reply; 7+ messages in thread From: Fabrice Gasnier @ 2019-04-24 12:55 UTC (permalink / raw) To: Fabien Dessenne, Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler, Maxime Coquelin, Alexandre Torgue, linux-iio, linux-stm32, linux-arm-kernel, linux-kernel On 4/24/19 2:51 PM, Fabien Dessenne wrote: > During probe, check the devm_ioremap_resource() error value. > Also return the devm_clk_get() error value instead of -EINVAL. > > Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com> > --- Hi Fabien, Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com> Thanks, Fabrice > drivers/iio/adc/stm32-dfsdm-core.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c > index 0a4d374..26e2011 100644 > --- a/drivers/iio/adc/stm32-dfsdm-core.c > +++ b/drivers/iio/adc/stm32-dfsdm-core.c > @@ -233,6 +233,8 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev, > } > priv->dfsdm.phys_base = res->start; > priv->dfsdm.base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(priv->dfsdm.base)) > + return PTR_ERR(priv->dfsdm.base); > > /* > * "dfsdm" clock is mandatory for DFSDM peripheral clocking. > @@ -242,8 +244,10 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev, > */ > priv->clk = devm_clk_get(&pdev->dev, "dfsdm"); > if (IS_ERR(priv->clk)) { > - dev_err(&pdev->dev, "No stm32_dfsdm_clk clock found\n"); > - return -EINVAL; > + ret = PTR_ERR(priv->clk); > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, "Failed to get clock (%d)\n", ret); > + return ret; > } > > priv->aclk = devm_clk_get(&pdev->dev, "audio"); > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe 2019-04-24 12:55 ` Fabrice Gasnier @ 2019-04-27 13:10 ` Jonathan Cameron 0 siblings, 0 replies; 7+ messages in thread From: Jonathan Cameron @ 2019-04-27 13:10 UTC (permalink / raw) To: Fabrice Gasnier Cc: Fabien Dessenne, Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler, Maxime Coquelin, Alexandre Torgue, linux-iio, linux-stm32, linux-arm-kernel, linux-kernel On Wed, 24 Apr 2019 14:55:28 +0200 Fabrice Gasnier <fabrice.gasnier@st.com> wrote: > On 4/24/19 2:51 PM, Fabien Dessenne wrote: > > During probe, check the devm_ioremap_resource() error value. > > Also return the devm_clk_get() error value instead of -EINVAL. > > > > Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com> > > --- > > > Hi Fabien, > > Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > > Thanks, > Fabrice > > > drivers/iio/adc/stm32-dfsdm-core.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c > > index 0a4d374..26e2011 100644 > > --- a/drivers/iio/adc/stm32-dfsdm-core.c > > +++ b/drivers/iio/adc/stm32-dfsdm-core.c > > @@ -233,6 +233,8 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev, > > } > > priv->dfsdm.phys_base = res->start; > > priv->dfsdm.base = devm_ioremap_resource(&pdev->dev, res); > > + if (IS_ERR(priv->dfsdm.base)) > > + return PTR_ERR(priv->dfsdm.base); > > > > /* > > * "dfsdm" clock is mandatory for DFSDM peripheral clocking. > > @@ -242,8 +244,10 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev, > > */ > > priv->clk = devm_clk_get(&pdev->dev, "dfsdm"); > > if (IS_ERR(priv->clk)) { > > - dev_err(&pdev->dev, "No stm32_dfsdm_clk clock found\n"); > > - return -EINVAL; > > + ret = PTR_ERR(priv->clk); > > + if (ret != -EPROBE_DEFER) > > + dev_err(&pdev->dev, "Failed to get clock (%d)\n", ret); > > + return ret; > > } > > > > priv->aclk = devm_clk_get(&pdev->dev, "audio"); > > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-04-27 13:10 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-04-24 12:51 [PATCH 0/2] iio: adc: stm32-dfsdm: manage error cases in probe Fabien Dessenne 2019-04-24 12:51 ` [PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case Fabien Dessenne 2019-04-24 12:55 ` Fabrice Gasnier 2019-04-27 13:08 ` Jonathan Cameron 2019-04-24 12:51 ` [PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe Fabien Dessenne 2019-04-24 12:55 ` Fabrice Gasnier 2019-04-27 13:10 ` Jonathan Cameron
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).