[PATCH 0/2] iio: adc: stm32-dfsdm: manage error cases in probe

[PATCH 0/2] iio: adc: stm32-dfsdm: manage error cases in probe

[Fabien Dessenne]

This patchset adds some check of the returned error code in probe.

Fabien Dessenne (2):
  iio: adc: stm32-dfsdm: manage the get_irq error case
  iio: adc: stm32-dfsdm: missing error case during probe

 drivers/iio/adc/stm32-dfsdm-adc.c  | 6 ++++++
 drivers/iio/adc/stm32-dfsdm-core.c | 8 ++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)

-- 
2.7.4

[PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case

[Fabien Dessenne]

During probe, check the "get_irq" error value.

Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
---
 drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
index 19adc2b..588907c 100644
--- a/drivers/iio/adc/stm32-dfsdm-adc.c
+++ b/drivers/iio/adc/stm32-dfsdm-adc.c
@@ -1456,6 +1456,12 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev)
 	 * So IRQ associated to filter instance 0 is dedicated to the Filter 0.
 	 */
 	irq = platform_get_irq(pdev, 0);
+	if (irq < 0) {
+		if (irq != -EPROBE_DEFER)
+			dev_err(dev, "Failed to get IRQ: %d\n", irq);
+		return irq;
+	}
+
 	ret = devm_request_irq(dev, irq, stm32_dfsdm_irq,
 			       0, pdev->name, adc);
 	if (ret < 0) {
-- 
2.7.4

[PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe

[Fabien Dessenne]

During probe, check the devm_ioremap_resource() error value.
Also return the devm_clk_get() error value instead of -EINVAL.

Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
---
 drivers/iio/adc/stm32-dfsdm-core.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
index 0a4d374..26e2011 100644
--- a/drivers/iio/adc/stm32-dfsdm-core.c
+++ b/drivers/iio/adc/stm32-dfsdm-core.c
@@ -233,6 +233,8 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
 	}
 	priv->dfsdm.phys_base = res->start;
 	priv->dfsdm.base = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(priv->dfsdm.base))
+		return PTR_ERR(priv->dfsdm.base);
 
 	/*
 	 * "dfsdm" clock is mandatory for DFSDM peripheral clocking.
@@ -242,8 +244,10 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
 	 */
 	priv->clk = devm_clk_get(&pdev->dev, "dfsdm");
 	if (IS_ERR(priv->clk)) {
-		dev_err(&pdev->dev, "No stm32_dfsdm_clk clock found\n");
-		return -EINVAL;
+		ret = PTR_ERR(priv->clk);
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev, "Failed to get clock (%d)\n", ret);
+		return ret;
 	}
 
 	priv->aclk = devm_clk_get(&pdev->dev, "audio");
-- 
2.7.4

Re: [PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case

[Fabrice Gasnier]

On 4/24/19 2:51 PM, Fabien Dessenne wrote:
> During probe, check the "get_irq" error value.
> 
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> ---

Hi Fabien,

Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com>

Thanks,
Fabrice

>  drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index 19adc2b..588907c 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -1456,6 +1456,12 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev)
>  	 * So IRQ associated to filter instance 0 is dedicated to the Filter 0.
>  	 */
>  	irq = platform_get_irq(pdev, 0);
> +	if (irq < 0) {
> +		if (irq != -EPROBE_DEFER)
> +			dev_err(dev, "Failed to get IRQ: %d\n", irq);
> +		return irq;
> +	}
> +
>  	ret = devm_request_irq(dev, irq, stm32_dfsdm_irq,
>  			       0, pdev->name, adc);
>  	if (ret < 0) {
> 

Re: [PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe

[Fabrice Gasnier]

On 4/24/19 2:51 PM, Fabien Dessenne wrote:
> During probe, check the devm_ioremap_resource() error value.
> Also return the devm_clk_get() error value instead of -EINVAL.
> 
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> ---


Hi Fabien,

Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com>

Thanks,
Fabrice

>  drivers/iio/adc/stm32-dfsdm-core.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> index 0a4d374..26e2011 100644
> --- a/drivers/iio/adc/stm32-dfsdm-core.c
> +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> @@ -233,6 +233,8 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
>  	}
>  	priv->dfsdm.phys_base = res->start;
>  	priv->dfsdm.base = devm_ioremap_resource(&pdev->dev, res);
> +	if (IS_ERR(priv->dfsdm.base))
> +		return PTR_ERR(priv->dfsdm.base);
>  
>  	/*
>  	 * "dfsdm" clock is mandatory for DFSDM peripheral clocking.
> @@ -242,8 +244,10 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
>  	 */
>  	priv->clk = devm_clk_get(&pdev->dev, "dfsdm");
>  	if (IS_ERR(priv->clk)) {
> -		dev_err(&pdev->dev, "No stm32_dfsdm_clk clock found\n");
> -		return -EINVAL;
> +		ret = PTR_ERR(priv->clk);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "Failed to get clock (%d)\n", ret);
> +		return ret;
>  	}
>  
>  	priv->aclk = devm_clk_get(&pdev->dev, "audio");
> 

Re: [PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case

[Jonathan Cameron]

On Wed, 24 Apr 2019 14:55:09 +0200
Fabrice Gasnier <fabrice.gasnier@st.com> wrote:

> On 4/24/19 2:51 PM, Fabien Dessenne wrote:
> > During probe, check the "get_irq" error value.
> > 
> > Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> > ---  
> 
> Hi Fabien,
> 
> Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> 
> Thanks,
> Fabrice
> 
> >  drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> > index 19adc2b..588907c 100644
> > --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> > @@ -1456,6 +1456,12 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev)
> >  	 * So IRQ associated to filter instance 0 is dedicated to the Filter 0.
> >  	 */
> >  	irq = platform_get_irq(pdev, 0);
> > +	if (irq < 0) {
> > +		if (irq != -EPROBE_DEFER)
> > +			dev_err(dev, "Failed to get IRQ: %d\n", irq);
> > +		return irq;
> > +	}
> > +
> >  	ret = devm_request_irq(dev, irq, stm32_dfsdm_irq,
> >  			       0, pdev->name, adc);
> >  	if (ret < 0) {
> >   

Re: [PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe

[Jonathan Cameron]

On Wed, 24 Apr 2019 14:55:28 +0200
Fabrice Gasnier <fabrice.gasnier@st.com> wrote:

> On 4/24/19 2:51 PM, Fabien Dessenne wrote:
> > During probe, check the devm_ioremap_resource() error value.
> > Also return the devm_clk_get() error value instead of -EINVAL.
> > 
> > Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> > ---  
> 
> 
> Hi Fabien,
> 
> Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> 
> Thanks,
> Fabrice
> 
> >  drivers/iio/adc/stm32-dfsdm-core.c | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> > index 0a4d374..26e2011 100644
> > --- a/drivers/iio/adc/stm32-dfsdm-core.c
> > +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> > @@ -233,6 +233,8 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
> >  	}
> >  	priv->dfsdm.phys_base = res->start;
> >  	priv->dfsdm.base = devm_ioremap_resource(&pdev->dev, res);
> > +	if (IS_ERR(priv->dfsdm.base))
> > +		return PTR_ERR(priv->dfsdm.base);
> >  
> >  	/*
> >  	 * "dfsdm" clock is mandatory for DFSDM peripheral clocking.
> > @@ -242,8 +244,10 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
> >  	 */
> >  	priv->clk = devm_clk_get(&pdev->dev, "dfsdm");
> >  	if (IS_ERR(priv->clk)) {
> > -		dev_err(&pdev->dev, "No stm32_dfsdm_clk clock found\n");
> > -		return -EINVAL;
> > +		ret = PTR_ERR(priv->clk);
> > +		if (ret != -EPROBE_DEFER)
> > +			dev_err(&pdev->dev, "Failed to get clock (%d)\n", ret);
> > +		return ret;
> >  	}
> >  
> >  	priv->aclk = devm_clk_get(&pdev->dev, "audio");
> >