Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] iio: atlas-ph-sensor: Drop GPIO include
@ 2019-12-02  9:18 Linus Walleij
  2019-12-07 10:16 ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2019-12-02  9:18 UTC (permalink / raw)
  To: Jonathan Cameron, linux-iio
  Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
	Linus Walleij

The driver includes <linux/gpio.h> yet fails to use symbols
from any the header so drop the include.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/iio/chemical/atlas-ph-sensor.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
index 6c175eb1c7a7..b7c20c74239b 100644
--- a/drivers/iio/chemical/atlas-ph-sensor.c
+++ b/drivers/iio/chemical/atlas-ph-sensor.c
@@ -14,7 +14,6 @@
 #include <linux/err.h>
 #include <linux/irq.h>
 #include <linux/irq_work.h>
-#include <linux/gpio.h>
 #include <linux/i2c.h>
 #include <linux/of_device.h>
 #include <linux/regmap.h>
-- 
2.23.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: atlas-ph-sensor: Drop GPIO include
  2019-12-02  9:18 [PATCH] iio: atlas-ph-sensor: Drop GPIO include Linus Walleij
@ 2019-12-07 10:16 ` Jonathan Cameron
  2019-12-07 22:05   ` Matt Ranostay
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2019-12-07 10:16 UTC (permalink / raw)
  To: Linus Walleij
  Cc: linux-iio, Hartmut Knaack, Lars-Peter Clausen,
	Peter Meerwald-Stadler, Matt Ranostay

On Mon,  2 Dec 2019 10:18:37 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:

> The driver includes <linux/gpio.h> yet fails to use symbols
> from any the header so drop the include.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
+CC Matt

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to do something or other.

Thanks,

Jonathan

> ---
>  drivers/iio/chemical/atlas-ph-sensor.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
> index 6c175eb1c7a7..b7c20c74239b 100644
> --- a/drivers/iio/chemical/atlas-ph-sensor.c
> +++ b/drivers/iio/chemical/atlas-ph-sensor.c
> @@ -14,7 +14,6 @@
>  #include <linux/err.h>
>  #include <linux/irq.h>
>  #include <linux/irq_work.h>
> -#include <linux/gpio.h>
>  #include <linux/i2c.h>
>  #include <linux/of_device.h>
>  #include <linux/regmap.h>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: atlas-ph-sensor: Drop GPIO include
  2019-12-07 10:16 ` Jonathan Cameron
@ 2019-12-07 22:05   ` Matt Ranostay
  0 siblings, 0 replies; 3+ messages in thread
From: Matt Ranostay @ 2019-12-07 22:05 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Linus Walleij, open list:IIO SUBSYSTEM AND DRIVERS,
	Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler

On Sat, Dec 7, 2019 at 2:16 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Mon,  2 Dec 2019 10:18:37 +0100
> Linus Walleij <linus.walleij@linaro.org> wrote:
>
> > The driver includes <linux/gpio.h> yet fails to use symbols
> > from any the header so drop the include.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> +CC Matt
>
> Applied to the togreg branch of iio.git and pushed out as testing for
> the autobuilders to do something or other.
>

Looks good to me. Probably too late for a Reviewed-by, but here it is anyway

Reviewed-by: Matt Ranostay <matt.ranostay@konsulko.com>

> Thanks,
>
> Jonathan
>
> > ---
> >  drivers/iio/chemical/atlas-ph-sensor.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
> > index 6c175eb1c7a7..b7c20c74239b 100644
> > --- a/drivers/iio/chemical/atlas-ph-sensor.c
> > +++ b/drivers/iio/chemical/atlas-ph-sensor.c
> > @@ -14,7 +14,6 @@
> >  #include <linux/err.h>
> >  #include <linux/irq.h>
> >  #include <linux/irq_work.h>
> > -#include <linux/gpio.h>
> >  #include <linux/i2c.h>
> >  #include <linux/of_device.h>
> >  #include <linux/regmap.h>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-02  9:18 [PATCH] iio: atlas-ph-sensor: Drop GPIO include Linus Walleij
2019-12-07 10:16 ` Jonathan Cameron
2019-12-07 22:05   ` Matt Ranostay

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git