[PATCH v4 0/3] adc-joystick: Add polled support

[PATCH v4 0/3] adc-joystick: Add polled support

[Chris Morgan]

Add support to the existing adc-joystick driver to support polling
rather than relying on triggered buffers. This is useful for devices
that do not offer triggered buffers in hardware. Code adapted from
changes made by Maya Matuszczyk <maccraft123mc@gmail.com>.

Changes from V3:
 - After lengthy discussion decided to support with existing attribute
   of "poll-interval". If present, the driver will use polling and if
   not present, it will use triggered buffers (as the driver does
   today).
 - Corrected some lines to honor the 80 character line-limit.
 - Check return value from polling method and return early if there
   is an error reading the data.

Changes from V2:
 - Changed parameter from "adc-joystick,polled" to
   "adc-joystick,no-hardware-trigger" as it is more representative of
   what the driver and hardware are doing.

Changes from V1:
 - Removed driver compatible string of "adc-joystick-polled".
 - Added new optional boolean value of "adc-joystick,polled".
 - Cleaned up if statements regarding polling behavior.

Chris Morgan (3):
  dt-bindings: adc-joystick: add poll-interval
  Input: adc-joystick - Add polled input device support
  arm64: dts: rockchip: Update joystick to polled for Odroid-Go2

 .../bindings/input/adc-joystick.yaml          |  6 +++
 .../boot/dts/rockchip/rk3326-odroid-go2.dts   |  1 +
 drivers/input/joystick/adc-joystick.c         | 49 ++++++++++++++-----
 3 files changed, 45 insertions(+), 11 deletions(-)

-- 
2.34.1

[PATCH v4 1/3] dt-bindings: adc-joystick: add poll-interval

[Chris Morgan]

Add poll-interval support for the adc-joystick documentation. This is
an optional value and if not provided the adc-joystick works as it
does today (with triggered buffers). If this value is provided, the
adc-joystick driver is polled at the specified interval.

Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 Documentation/devicetree/bindings/input/adc-joystick.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/adc-joystick.yaml b/Documentation/devicetree/bindings/input/adc-joystick.yaml
index 2ee04e03bc22..2d755091e46d 100644
--- a/Documentation/devicetree/bindings/input/adc-joystick.yaml
+++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml
@@ -18,6 +18,12 @@ properties:
   compatible:
     const: adc-joystick
 
+  poll-interval:
+    description:
+      Poll interval time in milliseconds. If not specified, device will use
+      triggered buffer.
+    $ref: /schemas/types.yaml#/definitions/uint32
+
   io-channels:
     minItems: 1
     maxItems: 1024
-- 
2.34.1

Re: [PATCH v4 1/3] dt-bindings: adc-joystick: add poll-interval

[Paul Cercueil]

Hi Chris,

Le lun., juin 27 2022 at 17:14:42 -0500, Chris Morgan 
<macroalpha82@gmail.com> a écrit :
> Add poll-interval support for the adc-joystick documentation. This is
> an optional value and if not provided the adc-joystick works as it
> does today (with triggered buffers). If this value is provided, the
> adc-joystick driver is polled at the specified interval.
> 
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  Documentation/devicetree/bindings/input/adc-joystick.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git 
> a/Documentation/devicetree/bindings/input/adc-joystick.yaml 
> b/Documentation/devicetree/bindings/input/adc-joystick.yaml
> index 2ee04e03bc22..2d755091e46d 100644
> --- a/Documentation/devicetree/bindings/input/adc-joystick.yaml
> +++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml
> @@ -18,6 +18,12 @@ properties:
>    compatible:
>      const: adc-joystick
> 
> +  poll-interval:
> +    description:
> +      Poll interval time in milliseconds. If not specified, device 
> will use
> +      triggered buffer.

It doesn't have to use *triggered* buffer - it can use regular buffer 
as well.

The property should use a unit suffix, as explained here:
https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml

So it should be named poll-interval-ms.

Cheers,
-Paul

> +    $ref: /schemas/types.yaml#/definitions/uint32
> +
>    io-channels:
>      minItems: 1
>      maxItems: 1024
> --
> 2.34.1
> 

Re: [PATCH v4 1/3] dt-bindings: adc-joystick: add poll-interval

[Chris Morgan]

On Mon, Jun 27, 2022 at 11:33:28PM +0100, Paul Cercueil wrote:
> Hi Chris,
> 
> Le lun., juin 27 2022 at 17:14:42 -0500, Chris Morgan
> <macroalpha82@gmail.com> a écrit :
> > Add poll-interval support for the adc-joystick documentation. This is
> > an optional value and if not provided the adc-joystick works as it
> > does today (with triggered buffers). If this value is provided, the
> > adc-joystick driver is polled at the specified interval.
> > 
> > Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > ---
> >  Documentation/devicetree/bindings/input/adc-joystick.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/input/adc-joystick.yaml
> > b/Documentation/devicetree/bindings/input/adc-joystick.yaml
> > index 2ee04e03bc22..2d755091e46d 100644
> > --- a/Documentation/devicetree/bindings/input/adc-joystick.yaml
> > +++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml
> > @@ -18,6 +18,12 @@ properties:
> >    compatible:
> >      const: adc-joystick
> > 
> > +  poll-interval:
> > +    description:
> > +      Poll interval time in milliseconds. If not specified, device will
> > use
> > +      triggered buffer.
> 
> It doesn't have to use *triggered* buffer - it can use regular buffer as
> well.
> 
> The property should use a unit suffix, as explained here:
> https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdevicetree-org%2Fdt-schema%2Fblob%2Fmain%2Fdtschema%2Fschemas%2Fproperty-units.yaml&amp;data=05%7C01%7C%7Cf6306210eda84b58f7f408da588d1627%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637919660856597552%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=NVqhWKdycQsv0ksiILD8aH%2BnZ6aji%2BhNxSEwBkQlZC0%3D&amp;reserved=0
> 
> So it should be named poll-interval-ms.
> 
> Cheers,
> -Paul

Understood, though the logic here was to be consistent with existing
implementations (such as adc-keys and gpio-keys-polled) which all
use poll-interval (no ms). Honest question, would it be better to be
right (poll-interval-ms) or consistent (poll-interval) in this case?

Thank you.

> 
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +
> >    io-channels:
> >      minItems: 1
> >      maxItems: 1024
> > --
> > 2.34.1
> > 
> 
> 

Re: [PATCH v4 1/3] dt-bindings: adc-joystick: add poll-interval

[Paul Cercueil]

Le lun., juin 27 2022 at 17:41:37 -0500, Chris Morgan 
<macromorgan@hotmail.com> a écrit :
> On Mon, Jun 27, 2022 at 11:33:28PM +0100, Paul Cercueil wrote:
>>  Hi Chris,
>> 
>>  Le lun., juin 27 2022 at 17:14:42 -0500, Chris Morgan
>>  <macroalpha82@gmail.com> a écrit :
>>  > Add poll-interval support for the adc-joystick documentation. 
>> This is
>>  > an optional value and if not provided the adc-joystick works as it
>>  > does today (with triggered buffers). If this value is provided, 
>> the
>>  > adc-joystick driver is polled at the specified interval.
>>  >
>>  > Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
>>  > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
>>  > ---
>>  >  Documentation/devicetree/bindings/input/adc-joystick.yaml | 6 
>> ++++++
>>  >  1 file changed, 6 insertions(+)
>>  >
>>  > diff --git 
>> a/Documentation/devicetree/bindings/input/adc-joystick.yaml
>>  > b/Documentation/devicetree/bindings/input/adc-joystick.yaml
>>  > index 2ee04e03bc22..2d755091e46d 100644
>>  > --- a/Documentation/devicetree/bindings/input/adc-joystick.yaml
>>  > +++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml
>>  > @@ -18,6 +18,12 @@ properties:
>>  >    compatible:
>>  >      const: adc-joystick
>>  >
>>  > +  poll-interval:
>>  > +    description:
>>  > +      Poll interval time in milliseconds. If not specified, 
>> device will
>>  > use
>>  > +      triggered buffer.
>> 
>>  It doesn't have to use *triggered* buffer - it can use regular 
>> buffer as
>>  well.
>> 
>>  The property should use a unit suffix, as explained here:
>>  
>> https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdevicetree-org%2Fdt-schema%2Fblob%2Fmain%2Fdtschema%2Fschemas%2Fproperty-units.yaml&data=05%7C01%7C%7Cf6306210eda84b58f7f408da588d1627%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637919660856597552%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NVqhWKdycQsv0ksiILD8aH%2BnZ6aji%2BhNxSEwBkQlZC0%3D&reserved=0
>> 
>>  So it should be named poll-interval-ms.
>> 
>>  Cheers,
>>  -Paul
> 
> Understood, though the logic here was to be consistent with existing
> implementations (such as adc-keys and gpio-keys-polled) which all
> use poll-interval (no ms). Honest question, would it be better to be
> right (poll-interval-ms) or consistent (poll-interval) in this case?

I guess those don't have a suffix for legacy reasons, and newly 
introduced properties should follow the standard.

But I guess that's a question for DT maintainers.

Cheers,
-Paul

> 
> Thank you.
> 
>> 
>>  > +    $ref: /schemas/types.yaml#/definitions/uint32
>>  > +
>>  >    io-channels:
>>  >      minItems: 1
>>  >      maxItems: 1024
>>  > --
>>  > 2.34.1
>>  >
>> 
>> 

Re: [PATCH v4 1/3] dt-bindings: adc-joystick: add poll-interval

[Rob Herring]

On Mon, Jun 27, 2022 at 4:48 PM Paul Cercueil <paul@crapouillou.net> wrote:
>
>
>
> Le lun., juin 27 2022 at 17:41:37 -0500, Chris Morgan
> <macromorgan@hotmail.com> a écrit :
> > On Mon, Jun 27, 2022 at 11:33:28PM +0100, Paul Cercueil wrote:
> >>  Hi Chris,
> >>
> >>  Le lun., juin 27 2022 at 17:14:42 -0500, Chris Morgan
> >>  <macroalpha82@gmail.com> a écrit :
> >>  > Add poll-interval support for the adc-joystick documentation.
> >> This is
> >>  > an optional value and if not provided the adc-joystick works as it
> >>  > does today (with triggered buffers). If this value is provided,
> >> the
> >>  > adc-joystick driver is polled at the specified interval.
> >>  >
> >>  > Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> >>  > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> >>  > ---
> >>  >  Documentation/devicetree/bindings/input/adc-joystick.yaml | 6
> >> ++++++
> >>  >  1 file changed, 6 insertions(+)
> >>  >
> >>  > diff --git
> >> a/Documentation/devicetree/bindings/input/adc-joystick.yaml
> >>  > b/Documentation/devicetree/bindings/input/adc-joystick.yaml
> >>  > index 2ee04e03bc22..2d755091e46d 100644
> >>  > --- a/Documentation/devicetree/bindings/input/adc-joystick.yaml
> >>  > +++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml
> >>  > @@ -18,6 +18,12 @@ properties:
> >>  >    compatible:
> >>  >      const: adc-joystick
> >>  >
> >>  > +  poll-interval:
> >>  > +    description:
> >>  > +      Poll interval time in milliseconds. If not specified,
> >> device will
> >>  > use
> >>  > +      triggered buffer.
> >>
> >>  It doesn't have to use *triggered* buffer - it can use regular
> >> buffer as
> >>  well.
> >>
> >>  The property should use a unit suffix, as explained here:
> >>
> >> https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdevicetree-org%2Fdt-schema%2Fblob%2Fmain%2Fdtschema%2Fschemas%2Fproperty-units.yaml&data=05%7C01%7C%7Cf6306210eda84b58f7f408da588d1627%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637919660856597552%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NVqhWKdycQsv0ksiILD8aH%2BnZ6aji%2BhNxSEwBkQlZC0%3D&reserved=0
> >>
> >>  So it should be named poll-interval-ms.
> >>
> >>  Cheers,
> >>  -Paul
> >
> > Understood, though the logic here was to be consistent with existing
> > implementations (such as adc-keys and gpio-keys-polled) which all
> > use poll-interval (no ms). Honest question, would it be better to be
> > right (poll-interval-ms) or consistent (poll-interval) in this case?
>
> I guess those don't have a suffix for legacy reasons, and newly
> introduced properties should follow the standard.
>
> But I guess that's a question for DT maintainers.

It should be consistent with the rest of the input bindings.

Rob

Re: [PATCH v4 1/3] dt-bindings: adc-joystick: add poll-interval

[Rob Herring]

On Mon, Jun 27, 2022 at 4:14 PM Chris Morgan <macroalpha82@gmail.com> wrote:
>
> Add poll-interval support for the adc-joystick documentation. This is
> an optional value and if not provided the adc-joystick works as it
> does today (with triggered buffers). If this value is provided, the
> adc-joystick driver is polled at the specified interval.
>
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  Documentation/devicetree/bindings/input/adc-joystick.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/adc-joystick.yaml b/Documentation/devicetree/bindings/input/adc-joystick.yaml
> index 2ee04e03bc22..2d755091e46d 100644
> --- a/Documentation/devicetree/bindings/input/adc-joystick.yaml
> +++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml
> @@ -18,6 +18,12 @@ properties:
>    compatible:
>      const: adc-joystick
>
> +  poll-interval:
> +    description:
> +      Poll interval time in milliseconds. If not specified, device will use
> +      triggered buffer.
> +    $ref: /schemas/types.yaml#/definitions/uint32

Already defined in input.yaml, so add a $ref to it and here you just
need 'poll-interval: true'.

Rob

[PATCH v4 2/3] Input: adc-joystick - Add polled input device support

[Chris Morgan]

Add polled input device support to the adc-joystick driver. This is
useful for devices which do not have hardware capable triggers on
their SARADC. Code modified from adc-joystick.c changes made by Maya
Matuszczyk.

Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 drivers/input/joystick/adc-joystick.c | 49 +++++++++++++++++++++------
 1 file changed, 38 insertions(+), 11 deletions(-)

diff --git a/drivers/input/joystick/adc-joystick.c b/drivers/input/joystick/adc-joystick.c
index 78ebca7d400a..7e3c5083ec3c 100644
--- a/drivers/input/joystick/adc-joystick.c
+++ b/drivers/input/joystick/adc-joystick.c
@@ -26,8 +26,23 @@ struct adc_joystick {
 	struct adc_joystick_axis *axes;
 	struct iio_channel *chans;
 	int num_chans;
+	bool polled;
 };
 
+static void adc_joystick_poll(struct input_dev *input)
+{
+	struct adc_joystick *joy = input_get_drvdata(input);
+	int i, val, ret;
+
+	for (i = 0; i < joy->num_chans; i++) {
+		ret = iio_read_channel_raw(&joy->chans[i], &val);
+		if (ret < 0)
+			return;
+		input_report_abs(input, joy->axes[i].code, val);
+	}
+	input_sync(input);
+}
+
 static int adc_joystick_handle(const void *data, void *private)
 {
 	struct adc_joystick *joy = private;
@@ -179,6 +194,7 @@ static int adc_joystick_probe(struct platform_device *pdev)
 	int error;
 	int bits;
 	int i;
+	int value;
 
 	joy = devm_kzalloc(dev, sizeof(*joy), GFP_KERNEL);
 	if (!joy)
@@ -215,8 +231,15 @@ static int adc_joystick_probe(struct platform_device *pdev)
 	joy->input = input;
 	input->name = pdev->name;
 	input->id.bustype = BUS_HOST;
-	input->open = adc_joystick_open;
-	input->close = adc_joystick_close;
+
+	if (!device_property_read_u32(dev, "poll-interval", &value)) {
+		joy->polled = 1;
+		input_setup_polling(input, adc_joystick_poll);
+		input_set_poll_interval(input, value);
+	} else {
+		input->open = adc_joystick_open;
+		input->close = adc_joystick_close;
+	}
 
 	error = adc_joystick_set_axes(dev, joy);
 	if (error)
@@ -229,16 +252,20 @@ static int adc_joystick_probe(struct platform_device *pdev)
 		return error;
 	}
 
-	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
-	if (IS_ERR(joy->buffer)) {
-		dev_err(dev, "Unable to allocate callback buffer\n");
-		return PTR_ERR(joy->buffer);
-	}
+	if (!joy->polled) {
+		joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle,
+						     joy);
+		if (IS_ERR(joy->buffer)) {
+			dev_err(dev, "Unable to allocate callback buffer\n");
+			return PTR_ERR(joy->buffer);
+		}
 
-	error = devm_add_action_or_reset(dev, adc_joystick_cleanup, joy->buffer);
-	if (error)  {
-		dev_err(dev, "Unable to add action\n");
-		return error;
+		error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
+						 joy->buffer);
+		if (error)  {
+			dev_err(dev, "Unable to add action\n");
+			return error;
+		}
 	}
 
 	return 0;
-- 
2.34.1

Re: [PATCH v4 2/3] Input: adc-joystick - Add polled input device support

[Artur Rojek]

On 2022-06-28 00:14, Chris Morgan wrote:
> Add polled input device support to the adc-joystick driver. This is
> useful for devices which do not have hardware capable triggers on
> their SARADC. Code modified from adc-joystick.c changes made by Maya
> Matuszczyk.
> 
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
Hey Chris,

comments inline.
>  drivers/input/joystick/adc-joystick.c | 49 +++++++++++++++++++++------
>  1 file changed, 38 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/input/joystick/adc-joystick.c
> b/drivers/input/joystick/adc-joystick.c
> index 78ebca7d400a..7e3c5083ec3c 100644
> --- a/drivers/input/joystick/adc-joystick.c
> +++ b/drivers/input/joystick/adc-joystick.c
> @@ -26,8 +26,23 @@ struct adc_joystick {
>  	struct adc_joystick_axis *axes;
>  	struct iio_channel *chans;
>  	int num_chans;
> +	bool polled;
>  };
> 
> +static void adc_joystick_poll(struct input_dev *input)
> +{
> +	struct adc_joystick *joy = input_get_drvdata(input);
> +	int i, val, ret;
> +
> +	for (i = 0; i < joy->num_chans; i++) {
> +		ret = iio_read_channel_raw(&joy->chans[i], &val);
> +		if (ret < 0)
> +			return;
> +		input_report_abs(input, joy->axes[i].code, val);
> +	}
> +	input_sync(input);
> +}
> +
>  static int adc_joystick_handle(const void *data, void *private)
>  {
>  	struct adc_joystick *joy = private;
> @@ -179,6 +194,7 @@ static int adc_joystick_probe(struct 
> platform_device *pdev)
>  	int error;
>  	int bits;
>  	int i;
> +	int value;
This name is not self-describing. How about `poll_interval` instead?
> 
>  	joy = devm_kzalloc(dev, sizeof(*joy), GFP_KERNEL);
>  	if (!joy)
> @@ -215,8 +231,15 @@ static int adc_joystick_probe(struct 
> platform_device *pdev)
>  	joy->input = input;
>  	input->name = pdev->name;
>  	input->id.bustype = BUS_HOST;
> -	input->open = adc_joystick_open;
> -	input->close = adc_joystick_close;
> +
> +	if (!device_property_read_u32(dev, "poll-interval", &value)) {
> +		joy->polled = 1;
> +		input_setup_polling(input, adc_joystick_poll);
> +		input_set_poll_interval(input, value);
> +	} else {
> +		input->open = adc_joystick_open;
> +		input->close = adc_joystick_close;
> +	}
Let's move the polling setup logic for after you establish the value of 
`joy->polled`:
```
	joy->polled = !device_property_read_u32(dev, "poll-interval",
						&poll_interval);
	if (joy->polled) {
		input_setup_polling(input, adc_joystick_poll);
		input_set_poll_interval(input, poll_interval);
	} else {
		input->open = adc_joystick_open;
		input->close = adc_joystick_close;
	}
```
This makes the intention more clear and is consistent with the `if 
(!joy->polled)` check later on.

Cheers,
Artur
> 
>  	error = adc_joystick_set_axes(dev, joy);
>  	if (error)
> @@ -229,16 +252,20 @@ static int adc_joystick_probe(struct
> platform_device *pdev)
>  		return error;
>  	}
> 
> -	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
> -	if (IS_ERR(joy->buffer)) {
> -		dev_err(dev, "Unable to allocate callback buffer\n");
> -		return PTR_ERR(joy->buffer);
> -	}
> +	if (!joy->polled) {
> +		joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle,
> +						     joy);
> +		if (IS_ERR(joy->buffer)) {
> +			dev_err(dev, "Unable to allocate callback buffer\n");
> +			return PTR_ERR(joy->buffer);
> +		}
> 
> -	error = devm_add_action_or_reset(dev, adc_joystick_cleanup, 
> joy->buffer);
> -	if (error)  {
> -		dev_err(dev, "Unable to add action\n");
> -		return error;
> +		error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
> +						 joy->buffer);
> +		if (error)  {
> +			dev_err(dev, "Unable to add action\n");
> +			return error;
> +		}
>  	}
> 
>  	return 0;

[PATCH v4 3/3] arm64: dts: rockchip: Update joystick to polled for Odroid-Go2

[Chris Morgan]

Update the Odroid Go Advance to use "poll-interval" from the
adc-joystick driver.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
index ea0695b51ecd..61583c3f24e6 100644
--- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
@@ -26,6 +26,7 @@ adc-joystick {
 		compatible = "adc-joystick";
 		io-channels = <&saradc 1>,
 			      <&saradc 2>;
+		poll-interval = <60>;
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-- 
2.34.1