linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
	Paul Moore <paul@paul-moore.com>, Sasha Levin <sashal@kernel.org>
Cc: Tushar Sugandhi <tusharsu@linux.microsoft.com>,
	Stephen Smalley <stephen.smalley.work@gmail.com>,
	casey@schaufler-ca.com, agk@redhat.com, snitzer@redhat.com,
	gmazyland@gmail.com, tyhicks@linux.microsoft.com,
	sashal@kernel.org, James Morris <jmorris@namei.org>,
	linux-integrity@vger.kernel.org, selinux@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [PATCH v10 8/8] selinux: include a consumer of the new IMA critical data hook
Date: Thu, 14 Jan 2021 11:44:27 -0500	[thread overview]
Message-ID: <99be76345f375bb2f485f08a53dcb8ed806dc538.camel@linux.ibm.com> (raw)
In-Reply-To: <fc80b1a1-ff4d-3bf2-59bd-2cb56135bf0f@linux.microsoft.com>

[Cc'ing Sasha]

Hi Lakshmi,

On Thu, 2021-01-14 at 08:22 -0800, Lakshmi Ramasubramanian wrote:
> On 1/13/21 6:49 PM, Mimi Zohar wrote:

> >>> Lakshmi is trying to address the situation where an event changes a
> >>> value, but then is restored to the original value.  The original and
> >>> subsequent events are measured, but restoring to the original value
> >>> isn't re-measured.  This isn't any different than when a file is
> >>> modified and then reverted.
> >>>
> >>> Instead of changing the name like this, which doesn't work for files,
> >>> allowing duplicate measurements should be generic, based on policy.
> >>
> >> Perhaps it is just the end of the day and I'm a bit tired, but I just
> >> read all of the above and I have no idea what your current thoughts
> >> are regarding this patch.
> > 
> > Other than appending the timestamp, which is a hack, the patch is fine.
> > Support for re-measuring an event can be upstreamed independently.
> > 
> 
> Thanks for clarifying the details related to duplicate measurement 
> detection and re-measuring.
> 
> I will keep the timestamp for the time being, even though its a hack, as 
> it helps with re-measuring state changes in SELinux. We will add support 
> for "policy driven" re-measurement as a subsequent patch series.

Once including the timestamp is upstreamed, removing it will be
difficult, especially if different userspace applications are dependent
on it.  Unless everyone is on board that removing the timestamp
wouldn't be considered a regression, it cannot be upstreamed.

thanks,

Mimi


  reply	other threads:[~2021-01-14 16:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08  4:07 [PATCH v10 0/8] IMA: support for measuring kernel integrity critical data Tushar Sugandhi
2021-01-08  4:07 ` [PATCH v10 1/8] IMA: generalize keyring specific measurement constructs Tushar Sugandhi
2021-01-08  4:07 ` [PATCH v10 2/8] IMA: add support to measure buffer data hash Tushar Sugandhi
2021-01-08  4:07 ` [PATCH v10 3/8] IMA: define a hook to measure kernel integrity critical data Tushar Sugandhi
2021-01-08  4:07 ` [PATCH v10 4/8] IMA: add policy rule to measure " Tushar Sugandhi
2021-01-08  4:07 ` [PATCH v10 5/8] IMA: limit critical data measurement based on a label Tushar Sugandhi
2021-01-14  2:09   ` Mimi Zohar
2021-01-14 17:57     ` Tushar Sugandhi
2021-01-08  4:07 ` [PATCH v10 6/8] IMA: extend critical data hook to limit the " Tushar Sugandhi
2021-01-08  4:07 ` [PATCH v10 7/8] IMA: define a builtin critical data measurement policy Tushar Sugandhi
2021-01-08  4:07 ` [PATCH v10 8/8] selinux: include a consumer of the new IMA critical data hook Tushar Sugandhi
2021-01-12 16:27   ` Paul Moore
2021-01-12 18:25     ` Lakshmi Ramasubramanian
2021-01-13 19:13     ` Mimi Zohar
2021-01-13 19:19       ` Paul Moore
2021-01-13 21:11         ` Mimi Zohar
2021-01-13 22:10           ` Paul Moore
2021-01-13 23:10             ` Mimi Zohar
2021-01-14  2:40               ` Paul Moore
2021-01-14  2:49                 ` Mimi Zohar
2021-01-14 16:22                   ` Lakshmi Ramasubramanian
2021-01-14 16:44                     ` Mimi Zohar [this message]
2021-01-14 16:50                       ` Mimi Zohar
2021-01-14 17:48                         ` Lakshmi Ramasubramanian
2021-01-14 19:21                           ` Lakshmi Ramasubramanian
2021-01-14 16:51                       ` Paul Moore
2021-01-15 12:54 ` [PATCH v10 0/8] IMA: support for measuring kernel integrity critical data Mimi Zohar
2021-01-15 17:26   ` Tushar Sugandhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99be76345f375bb2f485f08a53dcb8ed806dc538.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=agk@redhat.com \
    --cc=casey@schaufler-ca.com \
    --cc=dm-devel@redhat.com \
    --cc=gmazyland@gmail.com \
    --cc=jmorris@namei.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=nramas@linux.microsoft.com \
    --cc=paul@paul-moore.com \
    --cc=sashal@kernel.org \
    --cc=selinux@vger.kernel.org \
    --cc=snitzer@redhat.com \
    --cc=stephen.smalley.work@gmail.com \
    --cc=tusharsu@linux.microsoft.com \
    --cc=tyhicks@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).