archive mirror
 help / color / mirror / Atom feed
From: Dwaipayan Ray <>
To: Lukas Bulwahn <>
Subject: Re: [Linux-kernel-mentees] investigation: NO_AUTHOR_SIGN_OFF issues
Date: Wed, 23 Sep 2020 00:38:38 +0530	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <alpine.DEB.2.21.2009222028250.20644@felia>

> Generally, I think it is a good first proof of concept.
> I believe you that functionality 'basically' works; again, we might
> already want to run a full-scale evaluation on that. Just to see
> if there are some impacts we might not be aware of yet.
> As you already wrote, we, Joe, you and me, need to figure out
> now all the further details:
> - how can we avoid the duplicate code in and
> - what is performance impact, especially as AUTHOR_SIGN_OFF check is not
> triggered often, and there are many other rules in
> - further details, such as why do we need the lk_path is the first place?
> and many more questions of that kind.
> Feel free to sketch a first commit message and create a PATCH RFC for the
> discussion with Joe.
> Lukas

As for the lk_path, it can be removed easily. To me too, it didn't make much
sense since it was just a duplicate, as $root should contain the same.

But again due to some reason,
$root in checkpatch had the value ".",
while $lk_path in get_maintainer had the value "./"

I have no idea yet if this was a design decision or just different handling.

So, I can change the part where I referenced the mailmap file by adding
a trailing / with $root rather than $lk_path. That should do it.

And for the duplicate code part, Joe did mention that either I could copy
or place the read_mailmap code in a separate file and reference both
checkpatch and get_maintainers from there.

To me, copying seems much feasible because the referenced part of the
mailmap handling code here is very small as there are some minor

Linux-kernel-mentees mailing list

  reply	other threads:[~2020-09-22 19:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 10:06 [Linux-kernel-mentees] investigation: NO_AUTHOR_SIGN_OFF issues Lukas Bulwahn
2020-09-18 10:29 ` Dwaipayan Ray
2020-09-18 10:44   ` Lukas Bulwahn
2020-09-21  9:07     ` Dwaipayan Ray
2020-09-21  9:12       ` Lukas Bulwahn
2020-09-21  9:15       ` Lukas Bulwahn
2020-09-22 13:21         ` Dwaipayan Ray
2020-09-22 18:38           ` Lukas Bulwahn
2020-09-22 19:08             ` Dwaipayan Ray [this message]
2020-09-23  7:32               ` Lukas Bulwahn
2020-09-23  7:38                 ` Dwaipayan Ray
2020-09-23  7:42                   ` Lukas Bulwahn
2020-09-25  4:18                     ` Dwaipayan Ray
2020-09-25  7:20                       ` Lukas Bulwahn
2020-09-25  7:29                         ` Dwaipayan Ray
2020-09-25  7:35                           ` Lukas Bulwahn
2020-09-26 11:31                             ` Dwaipayan Ray
2020-09-28 13:30                               ` Dwaipayan Ray
2020-09-28 14:09                                 ` Lukas Bulwahn
2020-09-28 14:20                                   ` Dwaipayan Ray
2020-09-28 15:09                                     ` Lukas Bulwahn
2020-09-28 15:06                               ` Lukas Bulwahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).