From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] checkpatch.pl investigation: NO_AUTHOR_SIGN_OFF issues
Date: Mon, 28 Sep 2020 16:09:18 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2009281608130.4154@felia> (raw)
In-Reply-To: <CABJPP5A46fh=Eth7RwXYHarcS11kyHMCUMrRfvvJ3_8oafAkJA@mail.gmail.com>
On Mon, 28 Sep 2020, Dwaipayan Ray wrote:
> Hi,
> I am continuing this thread, but am writing about another issue
> separate from author sign off. While checking checkpatch
> output, I was checking the commits with the warnings:
>
How about just starting a new thread instead?
I will answer on the new thread.
Lukas
> WARNING:UNNECESSARY_ELSE: else is not generally
> useful after a break or return
>
> Looking into the referenced section, I found some
> sections with a redundant else.
>
> For example: (revision 196273fffc1c),
> arch/powerpc/kernel/security.c , line 360:
>
> static int ssb_prctl_get(struct task_struct *task)
> {
> if (stf_enabled_flush_types == STF_BARRIER_NONE)
> /*
> * We don't have an explicit signal from firmware that we're
> * vulnerable or not, we only have certain CPU revisions that
> * are known to be vulnerable.
> *
> * We assume that if we're on another CPU, where the barrier is
> * NONE, then we are not vulnerable.
> */
> return PR_SPEC_NOT_AFFECTED;
> else
> /*
> * If we do have a barrier type then we are vulnerable. The
> * barrier is not a global or per-process mitigation, so the
> * only value we can report here is PR_SPEC_ENABLE, which
> * appears as "vulnerable" in /proc.
> */
> return PR_SPEC_ENABLE;
>
> return -EINVAL;
> }
>
> The else is pretty much redundant and the control flow
> never reaches to return -EINVAL.
>
> Is it possible to clean up all these redundant code?
>
> Thanks,
> Dwaipayan.
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-28 14:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 10:06 [Linux-kernel-mentees] checkpatch.pl investigation: NO_AUTHOR_SIGN_OFF issues Lukas Bulwahn
2020-09-18 10:29 ` Dwaipayan Ray
2020-09-18 10:44 ` Lukas Bulwahn
2020-09-21 9:07 ` Dwaipayan Ray
2020-09-21 9:12 ` Lukas Bulwahn
2020-09-21 9:15 ` Lukas Bulwahn
2020-09-22 13:21 ` Dwaipayan Ray
2020-09-22 18:38 ` Lukas Bulwahn
2020-09-22 19:08 ` Dwaipayan Ray
2020-09-23 7:32 ` Lukas Bulwahn
2020-09-23 7:38 ` Dwaipayan Ray
2020-09-23 7:42 ` Lukas Bulwahn
2020-09-25 4:18 ` Dwaipayan Ray
2020-09-25 7:20 ` Lukas Bulwahn
2020-09-25 7:29 ` Dwaipayan Ray
2020-09-25 7:35 ` Lukas Bulwahn
2020-09-26 11:31 ` Dwaipayan Ray
2020-09-28 13:30 ` Dwaipayan Ray
2020-09-28 14:09 ` Lukas Bulwahn [this message]
2020-09-28 14:20 ` Dwaipayan Ray
2020-09-28 15:09 ` Lukas Bulwahn
2020-09-28 15:06 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2009281608130.4154@felia \
--to=lukas.bulwahn@gmail.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).