From: Philipp Zabel <p.zabel@pengutronix.de>
To: Steve Longerbeam <slongerbeam@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org,
kernel@pengutronix.de, fabio.estevam@nxp.com,
linux@armlinux.org.uk, mchehab@kernel.org, hverkuil@xs4all.nl,
nick@shmanahar.org, markus.heiser@darmarIT.de,
laurent.pinchart+renesas@ideasonboard.com, bparrot@ti.com,
geert@linux-m68k.org, arnd@arndb.de, sudipm.mukherjee@gmail.com,
minghsiu.tsai@mediatek.com, tiffany.lin@mediatek.com,
jean-christophe.trotin@st.com, horms+renesas@verge.net.au,
niklas.soderlund+renesas@ragnatech.se, robert.jarzmik@free.fr,
songjun.wu@microchip.com, andrew-ct.chen@mediatek.com,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
Steve Longerbeam <steve_longerbeam@mentor.com>
Subject: Re: [PATCH v3 01/24] [media] dt-bindings: Add bindings for i.MX media driver
Date: Mon, 16 Jan 2017 13:09:39 +0100 [thread overview]
Message-ID: <1484568579.8415.91.camel@pengutronix.de> (raw)
In-Reply-To: <e609fd03-a546-330c-ec89-de1844d1b46f@gmail.com>
On Fri, 2017-01-13 at 11:03 -0800, Steve Longerbeam wrote:
>
> On 01/13/2017 03:55 AM, Philipp Zabel wrote:
> > Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam:
> >> Add bindings documentation for the i.MX media driver.
> >>
> >> Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
> >> ---
> >> Documentation/devicetree/bindings/media/imx.txt | 57 +++++++++++++++++++++++++
> >> 1 file changed, 57 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/media/imx.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/media/imx.txt b/Documentation/devicetree/bindings/media/imx.txt
> >> new file mode 100644
> >> index 0000000..254b64a
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/media/imx.txt
> >> @@ -0,0 +1,57 @@
> >> +Freescale i.MX Media Video Devices
> >> +
> >> +Video Media Controller node
> >> +---------------------------
> >> +
> >> +This is the parent media controller node for video capture support.
> >> +
> >> +Required properties:
> >> +- compatible : "fsl,imx-media";
> > Would you be opposed to calling this "capture-subsystem" instead of
> > "imx-media"? We already use "fsl,imx-display-subsystem" and
> > "fsl,imx-gpu-subsystem" for the display and GPU compound devices.
>
> sure. Some pie-in-the-sky day when DRM and media are unified,
> there could be a single device that handles them all,
Indeed :)
> but for now
> I'm fine with "fsl,capture-subsystem".
Actually, I meant fsl,imx-capture-subsystem. fsl,imx-media-subsystem
would be fine, too. Either way, I'll be happy if it looks similar to the
other two.
[...]
> > This is a clever method to get better frame timestamps. Too bad about
> > the routing requirements. Can this be used on Nitrogen6X?
>
> Absolutely, this support just needs use of the input-capture channels in the
> imx GPT. I still need to submit the patch to the imx-gpt driver that adds an
> input capture API, so at this point fsl,input-capture-channel has no effect,
> but it does work (tested on SabreAuto).
Nice.
[...]
> >> +Required properties:
> >> +- compatible : "fsl,imx6-mipi-csi2";
> > I think this should get an additional "snps,dw-mipi-csi2" compatible,
> > since the only i.MX6 specific part is the bolted-on IPU2CSI gasket.
>
> right, minus the gasket it's a Synopsys core. I'll add that compatible flag.
> Or should wait until the day this subdev is exported for general use, after
> pulling out the gasket specifics?
It can be added right away.
> >> +- reg : physical base address and length of the register set;
> >> +- clocks : the MIPI CSI-2 receiver requires three clocks: hsi_tx
> >> + (the DPHY clock), video_27m, and eim_sel;
> > Note that hsi_tx is incorrectly named. CCGR3[CG8] just happens to be the
> > shared gate bit that gates the HSI clocks as well as the MIPI
> > "ac_clk_125m", "cfg_clk", "ips_clk", and "pll_refclk" inputs to the mipi
> > csi-2 core, but we are missing shared gate clocks in the clock tree for
> > these.
>
> Yes, so many clocks for the MIPI core. Why so many? I would think
> there would need to be at most three: a clock for the MIPI CSI-2 core
> and HSI core, and a clock for the D-PHY (oh and maybe a clock for an
> M-PHY if there is one). I have no clue what all these other clocks are.
> But anyway, a single gating bit, CCGR3[CG8], seems to enable them all.
I would imagine the CSI-2 core has a high-speed clock input from the
D-PHY for serial input, an APB clock for register access (ips_clk), and
a pixel clock input for the parallel output (pixel_clk), at least.
The D-PHY will have a PLL reference input (pll_refclk?) and probably its
own register clock (cfg_clk?).
I've looked at the MIPI DSI chapter, and it looks like ac_clk_125m is
used for DSI only.
> > Both cfg_clk and pll_refclk are sourced from video_27m, so "cfg" ->
> > video_27m seems fine.
> > But I don't get "dphy".
>
> I presume it's the clock for the D-PHY.
>
> > Which input clock would that correspond to?
> > "pll_refclk?"
>
> the mux at CDCDR says it comes from PLL3_120M, or PLL2_PFD2.
I think that makes sense.
regards
Philipp
next prev parent reply other threads:[~2017-01-16 12:11 UTC|newest]
Thread overview: 190+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 2:11 [PATCH v3 00/24] i.MX Media Driver Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 01/24] [media] dt-bindings: Add bindings for i.MX media driver Steve Longerbeam
2017-01-13 11:55 ` Philipp Zabel
2017-01-13 19:03 ` Steve Longerbeam
2017-01-16 12:09 ` Philipp Zabel [this message]
2017-01-16 17:13 ` Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 02/24] ARM: dts: imx6qdl: Add compatible, clocks, irqs to MIPI CSI-2 node Steve Longerbeam
2017-01-13 11:57 ` Philipp Zabel
2017-01-13 22:40 ` Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 03/24] ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and their connections Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 04/24] ARM: dts: imx6qdl: add media device Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 05/24] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround Steve Longerbeam
2017-01-13 11:59 ` Philipp Zabel
2017-01-07 2:11 ` [PATCH v3 06/24] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors Steve Longerbeam
2017-01-13 12:03 ` Philipp Zabel
2017-01-13 23:04 ` Steve Longerbeam
2017-01-16 12:55 ` Philipp Zabel
2017-01-16 17:15 ` Steve Longerbeam
2017-02-05 15:17 ` Laurent Pinchart
2017-01-30 22:28 ` Russell King - ARM Linux
2017-01-30 22:51 ` Russell King - ARM Linux
2017-02-05 15:24 ` Laurent Pinchart
2017-02-05 15:37 ` Russell King - ARM Linux
2017-01-07 2:11 ` [PATCH v3 07/24] ARM: dts: imx6-sabresd: " Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 08/24] ARM: dts: imx6-sabreauto: create i2cmux for i2c3 Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 09/24] ARM: dts: imx6-sabreauto: add reset-gpios property for max7310_b Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 10/24] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture Steve Longerbeam
2017-01-12 19:37 ` Tim Harvey
2017-01-12 23:40 ` Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 11/24] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 12/24] add mux and video interface bridge entity functions Steve Longerbeam
2017-01-20 13:56 ` Hans Verkuil
2017-02-05 15:36 ` Laurent Pinchart
2017-02-06 10:27 ` Philipp Zabel
2017-01-07 2:11 ` [PATCH v3 13/24] platform: add video-multiplexer subdevice driver Steve Longerbeam
2017-01-10 5:35 ` Rob Herring
2017-01-20 14:03 ` Hans Verkuil
2017-01-24 12:02 ` Philipp Zabel
2017-01-25 2:07 ` Steve Longerbeam
2017-02-05 15:48 ` Laurent Pinchart
2017-02-06 9:50 ` Hans Verkuil
2017-02-06 22:33 ` Laurent Pinchart
2017-02-06 23:10 ` Steve Longerbeam
2017-02-07 10:26 ` Laurent Pinchart
2017-02-07 10:41 ` Philipp Zabel
2017-02-07 14:11 ` Laurent Pinchart
2017-02-07 13:36 ` Benoit Parrot
2017-02-07 20:50 ` Sakari Ailus
2017-02-07 23:04 ` Laurent Pinchart
2017-01-24 12:44 ` Javier Martinez Canillas
2017-01-26 1:22 ` Steve Longerbeam
2017-02-07 20:46 ` Sakari Ailus
2017-02-08 9:47 ` Philipp Zabel
2017-02-08 10:05 ` Laurent Pinchart
2017-01-07 2:11 ` [PATCH v3 14/24] UAPI: Add media UAPI Kbuild file Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 15/24] media: Add userspace header file for i.MX Steve Longerbeam
2017-01-13 12:05 ` Philipp Zabel
2017-01-13 23:13 ` Steve Longerbeam
2017-02-05 15:50 ` Laurent Pinchart
2017-01-07 2:11 ` [PATCH v3 16/24] media: Add i.MX media core driver Steve Longerbeam
2017-01-13 15:20 ` Philipp Zabel
2017-01-14 22:46 ` Steve Longerbeam
2017-01-16 13:47 ` Philipp Zabel
2017-01-23 2:31 ` Steve Longerbeam
2017-01-23 11:13 ` Philipp Zabel
2017-01-24 1:38 ` Steve Longerbeam
2017-01-24 1:45 ` Steve Longerbeam
2017-01-24 11:37 ` Philipp Zabel
2017-01-30 15:28 ` Russell King - ARM Linux
[not found] ` <2b1d2418-1ad4-6373-cb07-c3aeab48187f@gmail.com>
2017-01-19 1:44 ` Steve Longerbeam
2017-01-24 11:39 ` Philipp Zabel
2017-01-30 22:29 ` Russell King - ARM Linux
2017-02-02 22:44 ` Russell King - ARM Linux
2017-02-02 22:50 ` Russell King - ARM Linux
2017-02-07 1:54 ` Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 17/24] media: imx: Add CSI subdev driver Steve Longerbeam
2017-01-16 15:03 ` Philipp Zabel
2017-01-16 21:15 ` Steve Longerbeam
2017-01-30 22:29 ` Russell King - ARM Linux
2017-01-31 10:30 ` Russell King - ARM Linux
2017-01-31 11:20 ` Russell King - ARM Linux
2017-02-01 0:31 ` Steve Longerbeam
2017-02-01 0:58 ` Russell King - ARM Linux
2017-01-31 15:51 ` Philipp Zabel
2017-01-31 16:48 ` Philipp Zabel
2017-02-01 1:40 ` Steve Longerbeam
2017-02-07 16:18 ` [PATCH] media: imx: csi: fix crop rectangle reset in sink set_fmt Philipp Zabel
2017-01-07 2:11 ` [PATCH v3 18/24] media: imx: Add SMFC subdev driver Steve Longerbeam
2017-02-01 18:39 ` Russell King - ARM Linux
2017-02-01 18:52 ` Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 19/24] media: imx: Add IC subdev drivers Steve Longerbeam
2017-01-20 14:29 ` Hans Verkuil
2017-01-25 2:39 ` Steve Longerbeam
2017-01-30 22:29 ` Russell King - ARM Linux
2017-01-07 2:11 ` [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver Steve Longerbeam
2017-01-20 14:38 ` Hans Verkuil
2017-01-24 2:15 ` Steve Longerbeam
2017-01-31 13:42 ` Russell King - ARM Linux
2017-01-31 18:21 ` Steve Longerbeam
2017-01-31 20:33 ` Russell King - ARM Linux
2017-01-31 21:55 ` Ian Arkver
2017-01-31 22:04 ` Russell King - ARM Linux
2017-01-31 22:33 ` Ian Arkver
2017-01-31 22:36 ` Steve Longerbeam
2017-01-31 23:30 ` Russell King - ARM Linux
2017-01-31 23:41 ` Steve Longerbeam
2017-02-02 22:35 ` Russell King - ARM Linux
2017-02-07 1:52 ` Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver " Steve Longerbeam
2017-01-30 22:30 ` Russell King - ARM Linux
2017-01-31 0:01 ` Russell King - ARM Linux
2017-01-31 9:49 ` Philipp Zabel
2017-02-01 1:02 ` Steve Longerbeam
2017-02-01 1:13 ` Russell King - ARM Linux
2017-01-31 0:31 ` Russell King - ARM Linux
2017-01-31 2:11 ` Steve Longerbeam
2017-02-01 23:44 ` Russell King - ARM Linux
2017-02-02 0:04 ` Steve Longerbeam
2017-02-02 11:50 ` Philipp Zabel
2017-02-08 23:23 ` Steve Longerbeam
2017-02-08 23:42 ` Russell King - ARM Linux
2017-02-09 23:49 ` Steve Longerbeam
2017-02-09 23:51 ` Steve Longerbeam
2017-02-13 9:20 ` Philipp Zabel
2017-02-13 23:20 ` Steve Longerbeam
2017-02-14 16:59 ` Philipp Zabel
2017-02-09 9:43 ` Philipp Zabel
2017-01-07 2:11 ` [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor " Steve Longerbeam
2017-01-20 14:48 ` Hans Verkuil
2017-01-25 19:10 ` Steve Longerbeam
2017-01-30 23:29 ` Russell King - ARM Linux
2017-01-31 3:31 ` Steve Longerbeam
2017-02-02 10:36 ` Laurent Pinchart
2017-02-12 22:53 ` Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 23/24] media: imx: Add Parallel OV5642 " Steve Longerbeam
2017-01-07 2:11 ` [PATCH v3 24/24] ARM: imx_v6_v7_defconfig: Enable staging video4linux drivers Steve Longerbeam
2017-01-11 23:14 ` [PATCH v3 00/24] i.MX Media Driver Tim Harvey
2017-01-12 3:22 ` Steve Longerbeam
2017-01-12 21:13 ` Tim Harvey
2017-01-12 22:32 ` Steve Longerbeam
2017-01-13 21:04 ` Tim Harvey
2017-01-20 13:52 ` Hans Verkuil
2017-01-20 16:31 ` Philipp Zabel
2017-01-20 18:40 ` Steve Longerbeam
2017-01-20 20:39 ` Hans Verkuil
2017-01-23 11:00 ` Philipp Zabel
2017-01-23 11:08 ` Hans Verkuil
2017-01-24 11:28 ` Philipp Zabel
2017-01-23 23:08 ` Steve Longerbeam
2017-01-24 11:27 ` Philipp Zabel
2017-01-28 19:27 ` Steve Longerbeam
2017-01-30 13:06 ` Russell King - ARM Linux
2017-01-31 10:09 ` Philipp Zabel
2017-01-31 13:14 ` Russell King - ARM Linux
2017-01-31 13:35 ` Philipp Zabel
2017-01-31 14:04 ` Russell King - ARM Linux
2017-01-31 0:45 ` Russell King - ARM Linux
2017-01-31 1:06 ` Russell King - ARM Linux
2017-01-31 2:06 ` Steve Longerbeam
2017-01-31 1:22 ` Steve Longerbeam
2017-01-31 9:49 ` Philipp Zabel
2017-01-31 10:21 ` Russell King - ARM Linux
2017-01-31 11:00 ` Russell King - ARM Linux
2017-01-31 23:43 ` Steve Longerbeam
2017-02-01 0:23 ` Russell King - ARM Linux
2017-02-01 1:54 ` Steve Longerbeam
2017-02-01 9:20 ` Russell King - ARM Linux
2017-01-31 13:54 ` Philipp Zabel
2017-01-31 14:25 ` Philipp Zabel
2017-01-31 15:03 ` Russell King - ARM Linux
2017-02-01 1:26 ` Steve Longerbeam
2017-02-01 9:30 ` Philipp Zabel
2017-02-01 10:11 ` Russell King - ARM Linux
2017-02-01 10:42 ` Philipp Zabel
2017-02-01 10:53 ` Russell King - ARM Linux
2017-02-02 0:19 ` Steve Longerbeam
2017-02-03 14:41 ` Laurent Pinchart
2017-02-03 17:56 ` Steve Longerbeam
2017-02-15 2:27 ` Steve Longerbeam
2017-02-15 9:33 ` Philipp Zabel
2017-02-02 17:22 ` Russell King - ARM Linux
2017-02-02 17:31 ` Steve Longerbeam
2017-02-02 17:56 ` Russell King - ARM Linux
2017-02-02 18:26 ` Steve Longerbeam
2017-02-02 18:58 ` Russell King - ARM Linux
2017-02-02 19:12 ` Steve Longerbeam
2017-02-02 22:29 ` Russell King - ARM Linux
2017-02-03 18:49 ` Steve Longerbeam
2017-02-03 14:21 ` vb2 queue_setup documentation clarification (was "Re: [PATCH v3 00/24] i.MX Media Driver") Laurent Pinchart
2017-02-03 14:31 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484568579.8415.91.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=andrew-ct.chen@mediatek.com \
--cc=arnd@arndb.de \
--cc=bparrot@ti.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=horms+renesas@verge.net.au \
--cc=hverkuil@xs4all.nl \
--cc=jean-christophe.trotin@st.com \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=markus.heiser@darmarIT.de \
--cc=mchehab@kernel.org \
--cc=minghsiu.tsai@mediatek.com \
--cc=nick@shmanahar.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
--cc=songjun.wu@microchip.com \
--cc=steve_longerbeam@mentor.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=tiffany.lin@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).