Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build failure after merge of the crypto tree
@ 2019-08-05  4:57 Stephen Rothwell
  2019-08-05  5:37 ` Chuhong Yuan
  2019-08-08  1:52 ` Stephen Rothwell
  0 siblings, 2 replies; 48+ messages in thread
From: Stephen Rothwell @ 2019-08-05  4:57 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Chuhong Yuan

[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (sparc64
defconfig) failed like this:

drivers/char/hw_random/n2-drv.c: In function 'n2rng_probe':
drivers/char/hw_random/n2-drv.c:771:29: error: 'pdev' undeclared (first use in this function); did you mean 'cdev'?
  err = devm_hwrng_register(&pdev->dev, &np->hwrng);
                             ^~~~
                             cdev
drivers/char/hw_random/n2-drv.c:771:29: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit

  3e75241be808 ("hwrng: drivers - Use device-managed registration API")

I applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 5 Aug 2019 14:49:59 +1000
Subject: [PATCH] hwrng: fix typo in n2-drv.c

Fixes: 3e75241be808 ("hwrng: drivers - Use device-managed registration API")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/char/hw_random/n2-drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
index 2d256b3470db..73e408146420 100644
--- a/drivers/char/hw_random/n2-drv.c
+++ b/drivers/char/hw_random/n2-drv.c
@@ -768,7 +768,7 @@ static int n2rng_probe(struct platform_device *op)
 	np->hwrng.data_read = n2rng_data_read;
 	np->hwrng.priv = (unsigned long) np;
 
-	err = devm_hwrng_register(&pdev->dev, &np->hwrng);
+	err = devm_hwrng_register(&op->dev, &np->hwrng);
 	if (err)
 		goto out_hvapi_unregister;
 
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2019-08-05  4:57 linux-next: build failure after merge of the crypto tree Stephen Rothwell
@ 2019-08-05  5:37 ` Chuhong Yuan
  2019-08-08  1:52 ` Stephen Rothwell
  1 sibling, 0 replies; 48+ messages in thread
From: Chuhong Yuan @ 2019-08-05  5:37 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Herbert Xu, Linux Next Mailing List, Linux Kernel Mailing List

On Mon, Aug 5, 2019 at 12:57 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the crypto tree, today's linux-next build (sparc64
> defconfig) failed like this:
>
> drivers/char/hw_random/n2-drv.c: In function 'n2rng_probe':
> drivers/char/hw_random/n2-drv.c:771:29: error: 'pdev' undeclared (first use in this function); did you mean 'cdev'?
>   err = devm_hwrng_register(&pdev->dev, &np->hwrng);
>                              ^~~~
>                              cdev
> drivers/char/hw_random/n2-drv.c:771:29: note: each undeclared identifier is reported only once for each function it appears in
>
> Caused by commit
>
>   3e75241be808 ("hwrng: drivers - Use device-managed registration API")
>

It is my typo, thanks for your fix!

Regards,
Chuhong

> I applied the following patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 5 Aug 2019 14:49:59 +1000
> Subject: [PATCH] hwrng: fix typo in n2-drv.c
>
> Fixes: 3e75241be808 ("hwrng: drivers - Use device-managed registration API")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/char/hw_random/n2-drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
> index 2d256b3470db..73e408146420 100644
> --- a/drivers/char/hw_random/n2-drv.c
> +++ b/drivers/char/hw_random/n2-drv.c
> @@ -768,7 +768,7 @@ static int n2rng_probe(struct platform_device *op)
>         np->hwrng.data_read = n2rng_data_read;
>         np->hwrng.priv = (unsigned long) np;
>
> -       err = devm_hwrng_register(&pdev->dev, &np->hwrng);
> +       err = devm_hwrng_register(&op->dev, &np->hwrng);
>         if (err)
>                 goto out_hvapi_unregister;
>
> --
> 2.20.1
>
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2019-08-05  4:57 linux-next: build failure after merge of the crypto tree Stephen Rothwell
  2019-08-05  5:37 ` Chuhong Yuan
@ 2019-08-08  1:52 ` Stephen Rothwell
  2019-08-08  3:01   ` Herbert Xu
  1 sibling, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2019-08-08  1:52 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Chuhong Yuan

[-- Attachment #1: Type: text/plain, Size: 1818 bytes --]

Hi all,

On Mon, 5 Aug 2019 14:57:36 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> After merging the crypto tree, today's linux-next build (sparc64
> defconfig) failed like this:
> 
> drivers/char/hw_random/n2-drv.c: In function 'n2rng_probe':
> drivers/char/hw_random/n2-drv.c:771:29: error: 'pdev' undeclared (first use in this function); did you mean 'cdev'?
>   err = devm_hwrng_register(&pdev->dev, &np->hwrng);
>                              ^~~~
>                              cdev
> drivers/char/hw_random/n2-drv.c:771:29: note: each undeclared identifier is reported only once for each function it appears in
> 
> Caused by commit
> 
>   3e75241be808 ("hwrng: drivers - Use device-managed registration API")
> 
> I applied the following patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 5 Aug 2019 14:49:59 +1000
> Subject: [PATCH] hwrng: fix typo in n2-drv.c
> 
> Fixes: 3e75241be808 ("hwrng: drivers - Use device-managed registration API")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/char/hw_random/n2-drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
> index 2d256b3470db..73e408146420 100644
> --- a/drivers/char/hw_random/n2-drv.c
> +++ b/drivers/char/hw_random/n2-drv.c
> @@ -768,7 +768,7 @@ static int n2rng_probe(struct platform_device *op)
>  	np->hwrng.data_read = n2rng_data_read;
>  	np->hwrng.priv = (unsigned long) np;
>  
> -	err = devm_hwrng_register(&pdev->dev, &np->hwrng);
> +	err = devm_hwrng_register(&op->dev, &np->hwrng);
>  	if (err)
>  		goto out_hvapi_unregister;
>  
> -- 
> 2.20.1

I am still applying that patch ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2019-08-08  1:52 ` Stephen Rothwell
@ 2019-08-08  3:01   ` Herbert Xu
  2019-08-08  3:17     ` Stephen Rothwell
  0 siblings, 1 reply; 48+ messages in thread
From: Herbert Xu @ 2019-08-08  3:01 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Chuhong Yuan

On Thu, Aug 08, 2019 at 11:52:45AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 5 Aug 2019 14:57:36 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> > 
> > After merging the crypto tree, today's linux-next build (sparc64
> > defconfig) failed like this:
> > 
> > drivers/char/hw_random/n2-drv.c: In function 'n2rng_probe':
> > drivers/char/hw_random/n2-drv.c:771:29: error: 'pdev' undeclared (first use in this function); did you mean 'cdev'?
> >   err = devm_hwrng_register(&pdev->dev, &np->hwrng);
> >                              ^~~~
> >                              cdev
> > drivers/char/hw_random/n2-drv.c:771:29: note: each undeclared identifier is reported only once for each function it appears in
> > 
> > Caused by commit
> > 
> >   3e75241be808 ("hwrng: drivers - Use device-managed registration API")
> > 
> > I applied the following patch for today:
> > 
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Mon, 5 Aug 2019 14:49:59 +1000
> > Subject: [PATCH] hwrng: fix typo in n2-drv.c
> > 
> > Fixes: 3e75241be808 ("hwrng: drivers - Use device-managed registration API")
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  drivers/char/hw_random/n2-drv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
> > index 2d256b3470db..73e408146420 100644
> > --- a/drivers/char/hw_random/n2-drv.c
> > +++ b/drivers/char/hw_random/n2-drv.c
> > @@ -768,7 +768,7 @@ static int n2rng_probe(struct platform_device *op)
> >  	np->hwrng.data_read = n2rng_data_read;
> >  	np->hwrng.priv = (unsigned long) np;
> >  
> > -	err = devm_hwrng_register(&pdev->dev, &np->hwrng);
> > +	err = devm_hwrng_register(&op->dev, &np->hwrng);
> >  	if (err)
> >  		goto out_hvapi_unregister;
> >  
> > -- 
> > 2.20.1
> 
> I am still applying that patch ...

Sorry, I forgot about your patch as it wasn't cced to the crypto
mailing list.  It should be out there now.

I've also added a compile test for this driver so at least it should
fail for me on x86 too.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2019-08-08  3:01   ` Herbert Xu
@ 2019-08-08  3:17     ` Stephen Rothwell
  2019-08-08  5:00       ` Herbert Xu
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2019-08-08  3:17 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Chuhong Yuan

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

Hi Herbert,

On Thu, 8 Aug 2019 13:01:57 +1000 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> Sorry, I forgot about your patch as it wasn't cced to the crypto
> mailing list.  It should be out there now.

Excellent, thanks.  Should I add the crypto mailing list as a contact
for problems?  Mostly the emails are just reporting conflicts and only
very occasionally do I actually send a useful patch.  If so, what is
its address?

> I've also added a compile test for this driver so at least it should
> fail for me on x86 too.

Even better! ;-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2019-08-08  3:17     ` Stephen Rothwell
@ 2019-08-08  5:00       ` Herbert Xu
  2019-08-08  5:04         ` Stephen Rothwell
  0 siblings, 1 reply; 48+ messages in thread
From: Herbert Xu @ 2019-08-08  5:00 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Chuhong Yuan

On Thu, Aug 08, 2019 at 01:17:10PM +1000, Stephen Rothwell wrote:
>
> Excellent, thanks.  Should I add the crypto mailing list as a contact
> for problems?  Mostly the emails are just reporting conflicts and only
> very occasionally do I actually send a useful patch.  If so, what is
> its address?

Yes please.  The address is

	linux-crypto@vger.kernel.org

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2019-08-08  5:00       ` Herbert Xu
@ 2019-08-08  5:04         ` Stephen Rothwell
  0 siblings, 0 replies; 48+ messages in thread
From: Stephen Rothwell @ 2019-08-08  5:04 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Chuhong Yuan

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

Hi Herbert,

On Thu, 8 Aug 2019 15:00:04 +1000 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Thu, Aug 08, 2019 at 01:17:10PM +1000, Stephen Rothwell wrote:
> >
> > Excellent, thanks.  Should I add the crypto mailing list as a contact
> > for problems?  Mostly the emails are just reporting conflicts and only
> > very occasionally do I actually send a useful patch.  If so, what is
> > its address?  
> 
> Yes please.  The address is
> 
> 	linux-crypto@vger.kernel.org

Done.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2019-08-12  3:21 Stephen Rothwell
@ 2019-08-12  6:53 ` Zhou Wang
  0 siblings, 0 replies; 48+ messages in thread
From: Zhou Wang @ 2019-08-12  6:53 UTC (permalink / raw)
  To: Stephen Rothwell, Herbert Xu, Linux Crypto List
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Shiju Jose,
	Kenneth Lee, Hao Fang, Jonathan Cameron, John Garry

On 2019/8/12 11:21, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the crypto tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/crypto/hisilicon/qm.c: Assembler messages:
> drivers/crypto/hisilicon/qm.c:334: Error: no such instruction: `ldp %rdx,%rcx,%bl'
> drivers/crypto/hisilicon/qm.c:335: Error: no such instruction: `stp %rdx,%rcx,%al'
> drivers/crypto/hisilicon/qm.c:336: Error: number of operands mismatch for `ds'
> 
> Caused by commit
> 
>   62c455ca853e ("crypto: hisilicon - add HiSilicon ZIP accelerator support")
> 
> I also got the following warnings:

Sorry for this. Will add dependency on ARM64 for CRYPTO_DEV_HISI_ZIP

> 
> WARNING: unmet direct dependencies detected for CRYPTO_DEV_HISI_QM
>   Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64 && PCI [=y] && PCI_MSI [=y]
>   Selected by [m]:
>   - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]
> 
> WARNING: unmet direct dependencies detected for CRYPTO_HISI_SGL
>   Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64
>   Selected by [m]:
>   - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]
> 
> WARNING: unmet direct dependencies detected for CRYPTO_DEV_HISI_QM
>   Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64 && PCI [=y] && PCI_MSI [=y]
>   Selected by [m]:
>   - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]
> 
> WARNING: unmet direct dependencies detected for CRYPTO_HISI_SGL
>   Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64
>   Selected by [m]:
>   - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]
> 
> WARNING: unmet direct dependencies detected for CRYPTO_DEV_HISI_QM
>   Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64 && PCI [=y] && PCI_MSI [=y]
>   Selected by [m]:
>   - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]
> 
> WARNING: unmet direct dependencies detected for CRYPTO_HISI_SGL
>   Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64
>   Selected by [m]:
>   - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]
> drivers/crypto/hisilicon/sgl.c: In function 'hisi_acc_sg_buf_map_to_hw_sgl':
> drivers/crypto/hisilicon/sgl.c:181:14: warning: 'curr_sgl_dma' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   *hw_sgl_dma = curr_sgl_dma;
>   ~~~~~~~~~~~~^~~~~~~~~~~~~~

I will fix this.

> 
> This latter from commit
> 
>   dfed0098ab91 ("crypto: hisilicon - add hardware SGL support")
> 
> I have disabled CRYPTO_DEV_HISI_ZIP for now.  You should not select
> CONFIG options that have dependencies (without also depending on the
> same things and being very careful).
> 


^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2019-08-12  3:21 Stephen Rothwell
  2019-08-12  6:53 ` Zhou Wang
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2019-08-12  3:21 UTC (permalink / raw)
  To: Herbert Xu, Linux Crypto List
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Zhou Wang,
	Shiju Jose, Kenneth Lee, Hao Fang, Jonathan Cameron, John Garry

[-- Attachment #1: Type: text/plain, Size: 2467 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/crypto/hisilicon/qm.c: Assembler messages:
drivers/crypto/hisilicon/qm.c:334: Error: no such instruction: `ldp %rdx,%rcx,%bl'
drivers/crypto/hisilicon/qm.c:335: Error: no such instruction: `stp %rdx,%rcx,%al'
drivers/crypto/hisilicon/qm.c:336: Error: number of operands mismatch for `ds'

Caused by commit

  62c455ca853e ("crypto: hisilicon - add HiSilicon ZIP accelerator support")

I also got the following warnings:

WARNING: unmet direct dependencies detected for CRYPTO_DEV_HISI_QM
  Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64 && PCI [=y] && PCI_MSI [=y]
  Selected by [m]:
  - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]

WARNING: unmet direct dependencies detected for CRYPTO_HISI_SGL
  Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64
  Selected by [m]:
  - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]

WARNING: unmet direct dependencies detected for CRYPTO_DEV_HISI_QM
  Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64 && PCI [=y] && PCI_MSI [=y]
  Selected by [m]:
  - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]

WARNING: unmet direct dependencies detected for CRYPTO_HISI_SGL
  Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64
  Selected by [m]:
  - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]

WARNING: unmet direct dependencies detected for CRYPTO_DEV_HISI_QM
  Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64 && PCI [=y] && PCI_MSI [=y]
  Selected by [m]:
  - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]

WARNING: unmet direct dependencies detected for CRYPTO_HISI_SGL
  Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64
  Selected by [m]:
  - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]
drivers/crypto/hisilicon/sgl.c: In function 'hisi_acc_sg_buf_map_to_hw_sgl':
drivers/crypto/hisilicon/sgl.c:181:14: warning: 'curr_sgl_dma' may be used uninitialized in this function [-Wmaybe-uninitialized]
  *hw_sgl_dma = curr_sgl_dma;
  ~~~~~~~~~~~~^~~~~~~~~~~~~~

This latter from commit

  dfed0098ab91 ("crypto: hisilicon - add hardware SGL support")

I have disabled CRYPTO_DEV_HISI_ZIP for now.  You should not select
CONFIG options that have dependencies (without also depending on the
same things and being very careful).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2018-10-08  1:03 Stephen Rothwell
@ 2018-10-08  5:54 ` Herbert Xu
  0 siblings, 0 replies; 48+ messages in thread
From: Herbert Xu @ 2018-10-08  5:54 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Ard Biesheuvel

On Mon, Oct 08, 2018 at 12:03:30PM +1100, Stephen Rothwell wrote:
> Hi Herbert,
> 
> After merging the crypto tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "crypto_fpu_exit" [arch/x86/crypto/aesni-intel.ko] undefined!
> ERROR: "crypto_fpu_init" [arch/x86/crypto/aesni-intel.ko] undefined!
> 
> Caused by commit
> 
>   944585a64f5e ("crypto: x86/aes-ni - remove special handling of AES in PCBC mode")
> 
> I have used the version of the crypto tree from next-20181005 for today.

Thanks Stephen.  It should be fixed in cryptodev now by:

	https://patchwork.kernel.org/patch/10628511/

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2018-10-08  1:03 Stephen Rothwell
  2018-10-08  5:54 ` Herbert Xu
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2018-10-08  1:03 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Ard Biesheuvel

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "crypto_fpu_exit" [arch/x86/crypto/aesni-intel.ko] undefined!
ERROR: "crypto_fpu_init" [arch/x86/crypto/aesni-intel.ko] undefined!

Caused by commit

  944585a64f5e ("crypto: x86/aes-ni - remove special handling of AES in PCBC mode")

I have used the version of the crypto tree from next-20181005 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2018-05-29 10:16 ` Ondrej Mosnáček
@ 2018-05-29 10:22   ` Stephen Rothwell
  0 siblings, 0 replies; 48+ messages in thread
From: Stephen Rothwell @ 2018-05-29 10:22 UTC (permalink / raw)
  To: Ondrej Mosnáček
  Cc: Herbert Xu, Linux-Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

Hi Ondrej,

On Tue, 29 May 2018 12:16:59 +0200 Ondrej Mosnáček <omosnacek@gmail.com> wrote:
>
> there is already a patch pending that fixes the issue:
> 
> https://patchwork.kernel.org/patch/10416245/

Great, hopefully it will be merged soon.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2018-05-29  9:08 Stephen Rothwell
@ 2018-05-29 10:16 ` Ondrej Mosnáček
  2018-05-29 10:22   ` Stephen Rothwell
  0 siblings, 1 reply; 48+ messages in thread
From: Ondrej Mosnáček @ 2018-05-29 10:16 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Herbert Xu, Linux-Next Mailing List, Linux Kernel Mailing List

Hi Stephen,

there is already a patch pending that fixes the issue:

https://patchwork.kernel.org/patch/10416245/

Cheers,
Ondrej

2018-05-29 11:08 GMT+02:00 Stephen Rothwell <sfr@canb.auug.org.au>:
> Hi Herbert,
>
> After merging the crypto tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> /home/sfr/next/next/crypto/morus640_glue.c:24:10: fatal error: asm/fpu/api.h: No such file or directory
>  #include <asm/fpu/api.h>
>           ^~~~~~~~~~~~~~~
> /home/sfr/next/next/crypto/morus1280_glue.c:24:10: fatal error: asm/fpu/api.h: No such file or directory
>  #include <asm/fpu/api.h>
>           ^~~~~~~~~~~~~~~
>
> Caused by commit
>
>   56e8e57fc3a7 ("crypto: morus - Add common SIMD glue code for MORUS")
>
> I have marked them as broken for now:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 29 May 2018 18:59:17 +1000
> Subject: [PATCH] crypto: make common SIMD glue code for MORUS as BROKEN for
>  now
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  crypto/Kconfig | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 75f5efde9aa3..ad69785dc9d3 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -342,6 +342,7 @@ config CRYPTO_MORUS640
>
>  config CRYPTO_MORUS640_GLUE
>         tristate "MORUS-640 AEAD algorithm (glue for SIMD optimizations)"
> +       depends on BROKEN
>         select CRYPTO_AEAD
>         select CRYPTO_CRYPTD
>         help
> @@ -351,6 +352,7 @@ config CRYPTO_MORUS640_GLUE
>  config CRYPTO_MORUS640_SSE2
>         tristate "MORUS-640 AEAD algorithm (x86_64 SSE2 implementation)"
>         depends on X86 && 64BIT
> +       depends on BROKEN
>         select CRYPTO_AEAD
>         select CRYPTO_MORUS640_GLUE
>         help
> @@ -364,6 +366,7 @@ config CRYPTO_MORUS1280
>
>  config CRYPTO_MORUS1280_GLUE
>         tristate "MORUS-1280 AEAD algorithm (glue for SIMD optimizations)"
> +       depends on BROKEN
>         select CRYPTO_AEAD
>         select CRYPTO_CRYPTD
>         help
> @@ -373,6 +376,7 @@ config CRYPTO_MORUS1280_GLUE
>  config CRYPTO_MORUS1280_SSE2
>         tristate "MORUS-1280 AEAD algorithm (x86_64 SSE2 implementation)"
>         depends on X86 && 64BIT
> +       depends on BROKEN
>         select CRYPTO_AEAD
>         select CRYPTO_MORUS1280_GLUE
>         help
> @@ -382,6 +386,7 @@ config CRYPTO_MORUS1280_SSE2
>  config CRYPTO_MORUS1280_AVX2
>         tristate "MORUS-1280 AEAD algorithm (x86_64 AVX2 implementation)"
>         depends on X86 && 64BIT
> +       depends on BROKEN
>         select CRYPTO_AEAD
>         select CRYPTO_MORUS1280_GLUE
>         help
> --
> 2.17.0
>
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2018-05-29  9:08 Stephen Rothwell
  2018-05-29 10:16 ` Ondrej Mosnáček
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2018-05-29  9:08 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Ondrej Mosnacek

[-- Attachment #1: Type: text/plain, Size: 2266 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (powerpc
allyesconfig) failed like this:

/home/sfr/next/next/crypto/morus640_glue.c:24:10: fatal error: asm/fpu/api.h: No such file or directory
 #include <asm/fpu/api.h>
          ^~~~~~~~~~~~~~~
/home/sfr/next/next/crypto/morus1280_glue.c:24:10: fatal error: asm/fpu/api.h: No such file or directory
 #include <asm/fpu/api.h>
          ^~~~~~~~~~~~~~~

Caused by commit

  56e8e57fc3a7 ("crypto: morus - Add common SIMD glue code for MORUS")

I have marked them as broken for now:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 29 May 2018 18:59:17 +1000
Subject: [PATCH] crypto: make common SIMD glue code for MORUS as BROKEN for
 now

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 crypto/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 75f5efde9aa3..ad69785dc9d3 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -342,6 +342,7 @@ config CRYPTO_MORUS640
 
 config CRYPTO_MORUS640_GLUE
 	tristate "MORUS-640 AEAD algorithm (glue for SIMD optimizations)"
+	depends on BROKEN
 	select CRYPTO_AEAD
 	select CRYPTO_CRYPTD
 	help
@@ -351,6 +352,7 @@ config CRYPTO_MORUS640_GLUE
 config CRYPTO_MORUS640_SSE2
 	tristate "MORUS-640 AEAD algorithm (x86_64 SSE2 implementation)"
 	depends on X86 && 64BIT
+	depends on BROKEN
 	select CRYPTO_AEAD
 	select CRYPTO_MORUS640_GLUE
 	help
@@ -364,6 +366,7 @@ config CRYPTO_MORUS1280
 
 config CRYPTO_MORUS1280_GLUE
 	tristate "MORUS-1280 AEAD algorithm (glue for SIMD optimizations)"
+	depends on BROKEN
 	select CRYPTO_AEAD
 	select CRYPTO_CRYPTD
 	help
@@ -373,6 +376,7 @@ config CRYPTO_MORUS1280_GLUE
 config CRYPTO_MORUS1280_SSE2
 	tristate "MORUS-1280 AEAD algorithm (x86_64 SSE2 implementation)"
 	depends on X86 && 64BIT
+	depends on BROKEN
 	select CRYPTO_AEAD
 	select CRYPTO_MORUS1280_GLUE
 	help
@@ -382,6 +386,7 @@ config CRYPTO_MORUS1280_SSE2
 config CRYPTO_MORUS1280_AVX2
 	tristate "MORUS-1280 AEAD algorithm (x86_64 AVX2 implementation)"
 	depends on X86 && 64BIT
+	depends on BROKEN
 	select CRYPTO_AEAD
 	select CRYPTO_MORUS1280_GLUE
 	help
-- 
2.17.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2017-11-06  0:25 Stephen Rothwell
@ 2017-11-06  5:40 ` Herbert Xu
  0 siblings, 0 replies; 48+ messages in thread
From: Herbert Xu @ 2017-11-06  5:40 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Boris BREZILLON

On Mon, Nov 06, 2017 at 11:25:21AM +1100, Stephen Rothwell wrote:
> Hi Herbert,
> 
> After merging the crypto tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/crypto/marvell/marvell-cesa: struct platform_device_id is 24 bytes.  The last of 1 is:
> 0x6d 0x76 0x5f 0x63 0x72 0x79 0x70 0x74 0x6f 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 
> FATAL: drivers/crypto/marvell/marvell-cesa: struct platform_device_id is not terminated with a NULL entry!
> 
> Caused by commit
> 
>   7b0c3d693ce6 ("crypto: marvell - Add a platform_device_id table")
> 
> I have used the crypto tree from next-20171103 for today.

Thanks Stephen.  I've got a patch that should fix this.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2017-11-06  0:25 Stephen Rothwell
  2017-11-06  5:40 ` Herbert Xu
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2017-11-06  0:25 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Boris BREZILLON

Hi Herbert,

After merging the crypto tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/crypto/marvell/marvell-cesa: struct platform_device_id is 24 bytes.  The last of 1 is:
0x6d 0x76 0x5f 0x63 0x72 0x79 0x70 0x74 0x6f 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 
FATAL: drivers/crypto/marvell/marvell-cesa: struct platform_device_id is not terminated with a NULL entry!

Caused by commit

  7b0c3d693ce6 ("crypto: marvell - Add a platform_device_id table")

I have used the crypto tree from next-20171103 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2016-11-29  8:34   ` Horia Geantă
@ 2016-11-29  8:43     ` Herbert Xu
  0 siblings, 0 replies; 48+ messages in thread
From: Herbert Xu @ 2016-11-29  8:43 UTC (permalink / raw)
  To: Horia Geantă
  Cc: Stephen Rothwell, linux-next, linux-kernel, Linux Crypto Mailing List

On Tue, Nov 29, 2016 at 08:34:08AM +0000, Horia Geantă wrote:
>
> > Fixes: da40e7a4ba4d ("crypto: aes-ce - Convert to skcipher")
> > Fixes: 211f41af534a ("crypto: aesbs - Convert to skcipher")
> The fix for this commit is missing.
> CRYPTO_AES_ARM_BS also needs to select CRYPTO_SIMD.

Thanks.  I'll add this patch on top:

---8<---
Subject: crypto: arm/aes - Add missing SIMD select for aesbs

This patch adds one more missing SIMD select for AES_ARM_BS.  It
also changes selects on ALGAPI to BLKCIPHER.

Fixes: 211f41af534a ("crypto: aesbs - Convert to skcipher")
Reported-by: Horia Geantă <horia.geanta@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/arch/arm/crypto/Kconfig b/arch/arm/crypto/Kconfig
index 8134888..dd90e38 100644
--- a/arch/arm/crypto/Kconfig
+++ b/arch/arm/crypto/Kconfig
@@ -88,9 +88,9 @@ config CRYPTO_AES_ARM
 config CRYPTO_AES_ARM_BS
 	tristate "Bit sliced AES using NEON instructions"
 	depends on KERNEL_MODE_NEON
-	select CRYPTO_ALGAPI
 	select CRYPTO_AES_ARM
-	select CRYPTO_ABLK_HELPER
+	select CRYPTO_BLKCIPHER
+	select CRYPTO_SIMD
 	help
 	  Use a faster and more secure NEON based implementation of AES in CBC,
 	  CTR and XTS modes
@@ -104,7 +104,7 @@ config CRYPTO_AES_ARM_BS
 config CRYPTO_AES_ARM_CE
 	tristate "Accelerated AES using ARMv8 Crypto Extensions"
 	depends on KERNEL_MODE_NEON
-	select CRYPTO_ALGAPI
+	select CRYPTO_BLKCIPHER
 	select CRYPTO_SIMD
 	help
 	  Use an implementation of AES in CBC, CTR and XTS modes that uses
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2016-11-29  7:08 ` Herbert Xu
@ 2016-11-29  8:34   ` Horia Geantă
  2016-11-29  8:43     ` Herbert Xu
  0 siblings, 1 reply; 48+ messages in thread
From: Horia Geantă @ 2016-11-29  8:34 UTC (permalink / raw)
  To: Herbert Xu, Stephen Rothwell; +Cc: linux-next, linux-kernel

On 11/29/2016 10:09 AM, Herbert Xu wrote:
> On Tue, Nov 29, 2016 at 11:55:29AM +1100, Stephen Rothwell wrote:
>> Hi Herbert,
>>
>> After merging the crypto tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>>
>> ERROR: "simd_skcipher_free" [arch/arm/crypto/aes-arm-ce.ko] undefined!
>> ERROR: "simd_skcipher_create_compat" [arch/arm/crypto/aes-arm-ce.ko] undefined!
>> ERROR: "simd_skcipher_free" [arch/arm/crypto/aes-arm-bs.ko] undefined!
>> ERROR: "simd_skcipher_create_compat" [arch/arm/crypto/aes-arm-bs.ko] undefined!
>>
>> Caused by commits
>>
>>   da40e7a4ba4d ("crypto: aes-ce - Convert to skcipher")
>>   211f41af534a ("crypto: aesbs - Convert to skcipher")
>>
>> Missing dependencies?
>>
>> I have used the crypto tree from next-20161128 for today.
> 
> Indeed.  This patch should fix the problem.
> 
> ---8<---
> Subject: crypto: arm/aes - Select SIMD in Kconfig
> 
> The skcipher conversion for ARM missed the select on CRYPTO_SIMD,
> causing build failures if SIMD was not otherwise enabled.
> 
> Fixes: da40e7a4ba4d ("crypto: aes-ce - Convert to skcipher")
> Fixes: 211f41af534a ("crypto: aesbs - Convert to skcipher")
The fix for this commit is missing.
CRYPTO_AES_ARM_BS also needs to select CRYPTO_SIMD.

> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> 
> diff --git a/arch/arm/crypto/Kconfig b/arch/arm/crypto/Kconfig
> index 27ed1b1..8134888 100644
> --- a/arch/arm/crypto/Kconfig
> +++ b/arch/arm/crypto/Kconfig
> @@ -105,7 +105,7 @@ config CRYPTO_AES_ARM_CE
>  	tristate "Accelerated AES using ARMv8 Crypto Extensions"
>  	depends on KERNEL_MODE_NEON
>  	select CRYPTO_ALGAPI
> -	select CRYPTO_ABLK_HELPER
> +	select CRYPTO_SIMD
>  	help
>  	  Use an implementation of AES in CBC, CTR and XTS modes that uses
>  	  ARMv8 Crypto Extensions
> diff --git a/arch/arm64/crypto/Kconfig b/arch/arm64/crypto/Kconfig
> index 5f4a617..c5ce39c 100644
> --- a/arch/arm64/crypto/Kconfig
> +++ b/arch/arm64/crypto/Kconfig
> @@ -48,14 +48,14 @@ config CRYPTO_AES_ARM64_CE_BLK
>  	depends on ARM64 && KERNEL_MODE_NEON
>  	select CRYPTO_BLKCIPHER
>  	select CRYPTO_AES_ARM64_CE
> -	select CRYPTO_ABLK_HELPER
> +	select CRYPTO_SIMD
>  
>  config CRYPTO_AES_ARM64_NEON_BLK
>  	tristate "AES in ECB/CBC/CTR/XTS modes using NEON instructions"
>  	depends on ARM64 && KERNEL_MODE_NEON
>  	select CRYPTO_BLKCIPHER
>  	select CRYPTO_AES
> -	select CRYPTO_ABLK_HELPER
> +	select CRYPTO_SIMD
The commit message should also refer to:
Fixes: d0ed0db149fce ("crypto: arm64/aes - Convert to skcipher")

Horia


^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2016-11-29  0:55 Stephen Rothwell
@ 2016-11-29  7:08 ` Herbert Xu
  2016-11-29  8:34   ` Horia Geantă
  0 siblings, 1 reply; 48+ messages in thread
From: Herbert Xu @ 2016-11-29  7:08 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

On Tue, Nov 29, 2016 at 11:55:29AM +1100, Stephen Rothwell wrote:
> Hi Herbert,
> 
> After merging the crypto tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> ERROR: "simd_skcipher_free" [arch/arm/crypto/aes-arm-ce.ko] undefined!
> ERROR: "simd_skcipher_create_compat" [arch/arm/crypto/aes-arm-ce.ko] undefined!
> ERROR: "simd_skcipher_free" [arch/arm/crypto/aes-arm-bs.ko] undefined!
> ERROR: "simd_skcipher_create_compat" [arch/arm/crypto/aes-arm-bs.ko] undefined!
> 
> Caused by commits
> 
>   da40e7a4ba4d ("crypto: aes-ce - Convert to skcipher")
>   211f41af534a ("crypto: aesbs - Convert to skcipher")
> 
> Missing dependencies?
> 
> I have used the crypto tree from next-20161128 for today.

Indeed.  This patch should fix the problem.

---8<---
Subject: crypto: arm/aes - Select SIMD in Kconfig

The skcipher conversion for ARM missed the select on CRYPTO_SIMD,
causing build failures if SIMD was not otherwise enabled.

Fixes: da40e7a4ba4d ("crypto: aes-ce - Convert to skcipher")
Fixes: 211f41af534a ("crypto: aesbs - Convert to skcipher")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/arch/arm/crypto/Kconfig b/arch/arm/crypto/Kconfig
index 27ed1b1..8134888 100644
--- a/arch/arm/crypto/Kconfig
+++ b/arch/arm/crypto/Kconfig
@@ -105,7 +105,7 @@ config CRYPTO_AES_ARM_CE
 	tristate "Accelerated AES using ARMv8 Crypto Extensions"
 	depends on KERNEL_MODE_NEON
 	select CRYPTO_ALGAPI
-	select CRYPTO_ABLK_HELPER
+	select CRYPTO_SIMD
 	help
 	  Use an implementation of AES in CBC, CTR and XTS modes that uses
 	  ARMv8 Crypto Extensions
diff --git a/arch/arm64/crypto/Kconfig b/arch/arm64/crypto/Kconfig
index 5f4a617..c5ce39c 100644
--- a/arch/arm64/crypto/Kconfig
+++ b/arch/arm64/crypto/Kconfig
@@ -48,14 +48,14 @@ config CRYPTO_AES_ARM64_CE_BLK
 	depends on ARM64 && KERNEL_MODE_NEON
 	select CRYPTO_BLKCIPHER
 	select CRYPTO_AES_ARM64_CE
-	select CRYPTO_ABLK_HELPER
+	select CRYPTO_SIMD
 
 config CRYPTO_AES_ARM64_NEON_BLK
 	tristate "AES in ECB/CBC/CTR/XTS modes using NEON instructions"
 	depends on ARM64 && KERNEL_MODE_NEON
 	select CRYPTO_BLKCIPHER
 	select CRYPTO_AES
-	select CRYPTO_ABLK_HELPER
+	select CRYPTO_SIMD
 
 config CRYPTO_CRC32_ARM64
 	tristate "CRC32 and CRC32C using optional ARMv8 instructions"
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2016-11-29  0:55 Stephen Rothwell
  2016-11-29  7:08 ` Herbert Xu
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2016-11-29  0:55 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel

Hi Herbert,

After merging the crypto tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

ERROR: "simd_skcipher_free" [arch/arm/crypto/aes-arm-ce.ko] undefined!
ERROR: "simd_skcipher_create_compat" [arch/arm/crypto/aes-arm-ce.ko] undefined!
ERROR: "simd_skcipher_free" [arch/arm/crypto/aes-arm-bs.ko] undefined!
ERROR: "simd_skcipher_create_compat" [arch/arm/crypto/aes-arm-bs.ko] undefined!

Caused by commits

  da40e7a4ba4d ("crypto: aes-ce - Convert to skcipher")
  211f41af534a ("crypto: aesbs - Convert to skcipher")

Missing dependencies?

I have used the crypto tree from next-20161128 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2016-07-20  7:46 Stephen Rothwell
@ 2016-07-20 14:32 ` Herbert Xu
  0 siblings, 0 replies; 48+ messages in thread
From: Herbert Xu @ 2016-07-20 14:32 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Paulo Flabiano Smorigo,
	Leonidas S. Barbosa, Linux Crypto Mailing List

On Wed, Jul 20, 2016 at 05:46:34PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the dax-misc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/crypto/vmx/aesp8-ppc.S: Assembler messages:
> drivers/crypto/vmx/aesp8-ppc.S:2036: Error: symbol `.aes_p8_xts_decrypt' is already defined
> 
> Caused by commit
> 
>   11c6e16ee13a ("crypto: vmx - Adding asm subroutines for XTS")
> 
> I have reverted that commit (and commit c07f5d3da643 ("crypto: vmx -
> Adding support for XTS")) for today.

Thanks Stephen.  I think this patch should fix it.

---8<---
Subject: crypto: vmx - Fix aes_p8_xts_decrypt build failure

We use _GLOBAL so there is no need to do the manual alignment,
in fact it causes a build failure.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/vmx/aesp8-ppc.pl b/drivers/crypto/vmx/aesp8-ppc.pl
index 813ffcc..0b4a293 100644
--- a/drivers/crypto/vmx/aesp8-ppc.pl
+++ b/drivers/crypto/vmx/aesp8-ppc.pl
@@ -2125,8 +2125,6 @@ Lxts_enc_ret:
 .size	.${prefix}_xts_encrypt,.-.${prefix}_xts_encrypt
 
 .globl	.${prefix}_xts_decrypt
-.align	5
-.${prefix}_xts_decrypt:
 	mr		$inp,r3				# reassign
 	li		r3,-1
 	${UCMP}i	$len,16
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2016-07-20  7:46 Stephen Rothwell
  2016-07-20 14:32 ` Herbert Xu
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2016-07-20  7:46 UTC (permalink / raw)
  To: Herbert Xu
  Cc: linux-next, linux-kernel, Paulo Flabiano Smorigo, Leonidas S. Barbosa

Hi all,

After merging the dax-misc tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/crypto/vmx/aesp8-ppc.S: Assembler messages:
drivers/crypto/vmx/aesp8-ppc.S:2036: Error: symbol `.aes_p8_xts_decrypt' is already defined

Caused by commit

  11c6e16ee13a ("crypto: vmx - Adding asm subroutines for XTS")

I have reverted that commit (and commit c07f5d3da643 ("crypto: vmx -
Adding support for XTS")) for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 48+ messages in thread

* RE: linux-next: build failure after merge of the crypto tree
  2016-06-24 13:33 ` Herbert Xu
@ 2016-06-24 13:36   ` Benedetto, Salvatore
  0 siblings, 0 replies; 48+ messages in thread
From: Benedetto, Salvatore @ 2016-06-24 13:36 UTC (permalink / raw)
  To: Herbert Xu, Stephen Rothwell
  Cc: linux-next, linux-kernel, Benedetto, Salvatore



> -----Original Message-----
> From: Herbert Xu [mailto:herbert@gondor.apana.org.au]
> Sent: Friday, June 24, 2016 2:33 PM
> To: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Benedetto,
> Salvatore <salvatore.benedetto@intel.com>
> Subject: Re: linux-next: build failure after merge of the crypto tree
> 
> On Fri, Jun 24, 2016 at 04:20:22PM +1000, Stephen Rothwell wrote:
> > Hi Herbert,
> >
> > After merging the crypto tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > net/built-in.o: In function `.ecdh_shared_secret':
> > (.text+0x4ad8d0): multiple definition of `.ecdh_shared_secret'
> > crypto/built-in.o:(.text+0x113f0): first defined here
> > net/built-in.o:(.opd+0x430e0): multiple definition of `ecdh_shared_secret'
> > crypto/built-in.o:(.opd+0x1d40): first defined here
> >
> > Caused by commit
> >
> >   3c4b23901a0c ("crypto: ecdh - Add ECDH software support")
> >
> > The other definition is in net/bluetooth/ecc.c
> >
> > I added the following patch for today (probably a better name could be
> > chosen):
> 
> I think the intention is that net/bluetooth/ecc.c will be deleted in favour of
> the implementation in crypto.  But for now I have applied your patch so we
> can progress.  Thanks Stephen.

Thanks Stephen, Herbert.

I already submitted the patch to the Bluetooth subsystem that removes
the net/Bluetooth/ecc.c module

Apologies for the inconvenience.

Regards,
Salvatore

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2016-06-24  6:20 Stephen Rothwell
@ 2016-06-24 13:33 ` Herbert Xu
  2016-06-24 13:36   ` Benedetto, Salvatore
  0 siblings, 1 reply; 48+ messages in thread
From: Herbert Xu @ 2016-06-24 13:33 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Salvatore Benedetto

On Fri, Jun 24, 2016 at 04:20:22PM +1000, Stephen Rothwell wrote:
> Hi Herbert,
> 
> After merging the crypto tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> net/built-in.o: In function `.ecdh_shared_secret':
> (.text+0x4ad8d0): multiple definition of `.ecdh_shared_secret'
> crypto/built-in.o:(.text+0x113f0): first defined here
> net/built-in.o:(.opd+0x430e0): multiple definition of `ecdh_shared_secret'
> crypto/built-in.o:(.opd+0x1d40): first defined here
> 
> Caused by commit
> 
>   3c4b23901a0c ("crypto: ecdh - Add ECDH software support")
> 
> The other definition is in net/bluetooth/ecc.c
> 
> I added the following patch for today (probably a better name could
> be chosen):

I think the intention is that net/bluetooth/ecc.c will be deleted
in favour of the implementation in crypto.  But for now I have
applied your patch so we can progress.  Thanks Stephen.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2016-06-24  6:20 Stephen Rothwell
  2016-06-24 13:33 ` Herbert Xu
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2016-06-24  6:20 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Salvatore Benedetto

Hi Herbert,

After merging the crypto tree, today's linux-next build (powerpc
allyesconfig) failed like this:

net/built-in.o: In function `.ecdh_shared_secret':
(.text+0x4ad8d0): multiple definition of `.ecdh_shared_secret'
crypto/built-in.o:(.text+0x113f0): first defined here
net/built-in.o:(.opd+0x430e0): multiple definition of `ecdh_shared_secret'
crypto/built-in.o:(.opd+0x1d40): first defined here

Caused by commit

  3c4b23901a0c ("crypto: ecdh - Add ECDH software support")

The other definition is in net/bluetooth/ecc.c

I added the following patch for today (probably a better name could
be chosen):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 24 Jun 2016 16:13:37 +1000
Subject: [PATCH] crypto: make ecdh_shared_secret unique

There is another ecdh_shared_secret in net/bluetooth/ecc.c

Fixes: 3c4b23901a0c ("crypto: ecdh - Add ECDH software support")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 crypto/ecc.c  | 2 +-
 crypto/ecc.h  | 6 +++---
 crypto/ecdh.c | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/crypto/ecc.c b/crypto/ecc.c
index 9aedec6bbe72..414c78a9c214 100644
--- a/crypto/ecc.c
+++ b/crypto/ecc.c
@@ -966,7 +966,7 @@ out:
 	return ret;
 }
 
-int ecdh_shared_secret(unsigned int curve_id, unsigned int ndigits,
+int crypto_ecdh_shared_secret(unsigned int curve_id, unsigned int ndigits,
 		       const u8 *private_key, unsigned int private_key_len,
 		       const u8 *public_key, unsigned int public_key_len,
 		       u8 *secret, unsigned int secret_len)
diff --git a/crypto/ecc.h b/crypto/ecc.h
index b5db4b989f3c..663d598c7406 100644
--- a/crypto/ecc.h
+++ b/crypto/ecc.h
@@ -60,7 +60,7 @@ int ecdh_make_pub_key(const unsigned int curve_id, unsigned int ndigits,
 		      u8 *public_key, unsigned int public_key_len);
 
 /**
- * ecdh_shared_secret() - Compute a shared secret
+ * crypto_ecdh_shared_secret() - Compute a shared secret
  *
  * @curve_id:		id representing the curve to use
  * @private_key:	private key of part A
@@ -70,13 +70,13 @@ int ecdh_make_pub_key(const unsigned int curve_id, unsigned int ndigits,
  * @secret:		buffer for storing the calculated shared secret
  * @secret_len:		length of the secret buffer
  *
- * Note: It is recommended that you hash the result of ecdh_shared_secret
+ * Note: It is recommended that you hash the result of crypto_ecdh_shared_secret
  * before using it for symmetric encryption or HMAC.
  *
  * Returns 0 if the shared secret was generated successfully, a negative value
  * if an error occurred.
  */
-int ecdh_shared_secret(unsigned int curve_id, unsigned int ndigits,
+int crypto_ecdh_shared_secret(unsigned int curve_id, unsigned int ndigits,
 		       const u8 *private_key, unsigned int private_key_len,
 		       const u8 *public_key, unsigned int public_key_len,
 		       u8 *secret, unsigned int secret_len);
diff --git a/crypto/ecdh.c b/crypto/ecdh.c
index d3a9eeca4b32..3de289806d67 100644
--- a/crypto/ecdh.c
+++ b/crypto/ecdh.c
@@ -79,7 +79,7 @@ static int ecdh_compute_value(struct kpp_request *req)
 		if (copied != 2 * nbytes)
 			return -EINVAL;
 
-		ret = ecdh_shared_secret(ctx->curve_id, ctx->ndigits,
+		ret = crypto_ecdh_shared_secret(ctx->curve_id, ctx->ndigits,
 					 (const u8 *)ctx->private_key, nbytes,
 					 (const u8 *)ctx->public_key, 2 * nbytes,
 					 (u8 *)ctx->shared_secret, nbytes);
-- 
2.8.1

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2016-02-17  1:26 Stephen Rothwell
  0 siblings, 0 replies; 48+ messages in thread
From: Stephen Rothwell @ 2016-02-17  1:26 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Stephan Mueller

Hi Herbert,

After merging the crypto tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

arch/arm/crypto/aesbs-glue.c: In function 'aesbs_xts_set_key':
arch/arm/crypto/aesbs-glue.c:94:8: error: implicit declaration of function 'xts_check_key' [-Werror=implicit-function-declaration]
  err = xts_check_key(tfm, in_key, key_len);
        ^
arch/arm/crypto/aes-ce-glue.c: In function 'xts_set_key':
arch/arm/crypto/aes-ce-glue.c:155:8: error: implicit declaration of function 'xts_check_key' [-Werror=implicit-function-declaration]
  ret = xts_check_key(tfm, in_key, key_len);
        ^

Caused by commit

  28856a9e52c7 ("crypto: xts - consolidate sanity check for keys")

Presumably a missing include.

I have used the crypto tree from next-20160216 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2015-10-15  1:37 Stephen Rothwell
@ 2015-10-15  2:01 ` Herbert Xu
  0 siblings, 0 replies; 48+ messages in thread
From: Herbert Xu @ 2015-10-15  2:01 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Daniel Thompson, Linus Walleij

On Thu, Oct 15, 2015 at 12:37:00PM +1100, Stephen Rothwell wrote:
> Hi Herbert,
> 
> After merging the crypto tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_runtime_suspend':
> drivers/char/hw_random/stm32-rng.c:163:51: error: 'pdev' undeclared (first use in this function)
>   struct stm32_rng_private *priv = dev_get_drvdata(pdev);
>                                                    ^
> drivers/char/hw_random/stm32-rng.c:163:51: note: each undeclared identifier is reported only once for each function it appears in
> drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_runtime_resume':
> drivers/char/hw_random/stm32-rng.c:172:51: error: 'pdev' undeclared (first use in this function)
>   struct stm32_rng_private *priv = dev_get_drvdata(pdev);
>                                                    ^
> 
> Caused by commit
> 
>   c6a97c42e399 ("Add support for STMicroelectronics STM32 random number generator.")
> 
> I have used the crypto tree from next-20151013 for today.

Thanks Stephen!  I've just pushed out a fix for this.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2015-10-15  1:37 Stephen Rothwell
  2015-10-15  2:01 ` Herbert Xu
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2015-10-15  1:37 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Daniel Thompson, Linus Walleij

Hi Herbert,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_runtime_suspend':
drivers/char/hw_random/stm32-rng.c:163:51: error: 'pdev' undeclared (first use in this function)
  struct stm32_rng_private *priv = dev_get_drvdata(pdev);
                                                   ^
drivers/char/hw_random/stm32-rng.c:163:51: note: each undeclared identifier is reported only once for each function it appears in
drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_runtime_resume':
drivers/char/hw_random/stm32-rng.c:172:51: error: 'pdev' undeclared (first use in this function)
  struct stm32_rng_private *priv = dev_get_drvdata(pdev);
                                                   ^

Caused by commit

  c6a97c42e399 ("Add support for STMicroelectronics STM32 random number generator.")

I have used the crypto tree from next-20151013 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2015-08-05  6:49 Stephen Rothwell
@ 2015-08-05  7:28 ` Herbert Xu
  0 siblings, 0 replies; 48+ messages in thread
From: Herbert Xu @ 2015-08-05  7:28 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

On Wed, Aug 05, 2015 at 04:49:31PM +1000, Stephen Rothwell wrote:
> Hi Herbert,
> 
> After merging the crypto tree, today's linux-next build (sparc64
> defconfig) failed like this:
> 
> crypto/built-in.o: In function `crypto_authenc_exit_tfm':
> authenc.c:(.text+0x11d1c): undefined reference to `crypto_put_default_null_skcipher'
> crypto/built-in.o: In function `crypto_authenc_init_tfm':
> authenc.c:(.text+0x11d7c): undefined reference to `crypto_get_default_null_skcipher'
> 
> Caused by commit
> 
>   92d95ba91772 ("crypto: authenc - Convert to new AEAD interface")
> 
> Those symbols depend on CONFIG_CRYPTO_NULL which is set to 'm' for
> this build.

Thanks Stephen.  I already have a similar patch in my tree which
I will push out soon.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2015-08-05  6:49 Stephen Rothwell
  2015-08-05  7:28 ` Herbert Xu
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2015-08-05  6:49 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel

Hi Herbert,

After merging the crypto tree, today's linux-next build (sparc64
defconfig) failed like this:

crypto/built-in.o: In function `crypto_authenc_exit_tfm':
authenc.c:(.text+0x11d1c): undefined reference to `crypto_put_default_null_skcipher'
crypto/built-in.o: In function `crypto_authenc_init_tfm':
authenc.c:(.text+0x11d7c): undefined reference to `crypto_get_default_null_skcipher'

Caused by commit

  92d95ba91772 ("crypto: authenc - Convert to new AEAD interface")

Those symbols depend on CONFIG_CRYPTO_NULL which is set to 'm' for
this build.

I have added this fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 5 Aug 2015 16:41:48 +1000
Subject: [PATCH] crypto: authenc - select CRYPTO_NULL

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 354bb692c964..ac7cc6226e61 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -200,6 +200,7 @@ config CRYPTO_AUTHENC
 	select CRYPTO_BLKCIPHER
 	select CRYPTO_MANAGER
 	select CRYPTO_HASH
+	select CRYPTO_NULL
 	help
 	  Authenc: Combined mode wrapper for IPsec.
 	  This is required for IPSec.
-- 
2.5.0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2015-06-20  6:35 Stephen Rothwell
  0 siblings, 0 replies; 48+ messages in thread
From: Stephen Rothwell @ 2015-06-20  6:35 UTC (permalink / raw)
  To: Herbert Xu, Gustavo Padovan
  Cc: linux-next, linux-kernel, Simon Vincent, Marcel Holtmann

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/mac802154/llsec.c: In function 'llsec_do_encrypt_auth':
/scratch/sfr/next/net/mac802154/llsec.c:675:15: error: 'dst' undeclared (first use in this function)
   sg_init_one(dst, skb_put(skb, authlen), authlen);
               ^

Caused by commit:

  7df416952e1e ("Merge remote-tracking branch 'crypto/master'")

I made a small mistake by leaving that line in when I resolved the
conflict.  I have now removed that line.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2015-05-28 11:40 Stephen Rothwell
@ 2015-05-28 13:08 ` Stephan Mueller
  0 siblings, 0 replies; 48+ messages in thread
From: Stephan Mueller @ 2015-05-28 13:08 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Herbert Xu, linux-next, linux-kernel

Am Donnerstag, 28. Mai 2015, 21:40:49 schrieb Stephen Rothwell:

Hi Stephen,

>Hi Herbert,
>
>After merging the crypto tree, today's linux-next build (powerpc
>allyesconfig) failed like this:
>
>crypto/jitterentropy.c: In function 'jent_get_nstime':
>crypto/jitterentropy.c:135:5: error: implicit declaration of function
>'timekeeping_valid_for_hres' [-Werror=implicit-function-declaration] (0 ==
>timekeeping_valid_for_hres()) &&
>     ^
>
>Caused by commit bb5530e40824 ("crypto: jitterentropy - add
>jitterentropy RNG").
>
>I have reverted that commit for today.

The fix has been added to the cryptodev-2.6 this morning: 
cf58fcb1bea9e0fcf3447bdb959ef5bcd22cfbcb


Ciao
Stephan

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2015-05-28 11:40 Stephen Rothwell
  2015-05-28 13:08 ` Stephan Mueller
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2015-05-28 11:40 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Stephan Mueller

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (powerpc allyesconfig)
failed like this:

crypto/jitterentropy.c: In function 'jent_get_nstime':
crypto/jitterentropy.c:135:5: error: implicit declaration of function 'timekeeping_valid_for_hres' [-Werror=implicit-function-declaration]
     (0 == timekeeping_valid_for_hres()) &&
     ^

Caused by commit bb5530e40824 ("crypto: jitterentropy - add
jitterentropy RNG").

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2015-03-17  2:01 Stephen Rothwell
@ 2015-03-17 11:11 ` Herbert Xu
  0 siblings, 0 replies; 48+ messages in thread
From: Herbert Xu @ 2015-03-17 11:11 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, James Hartley, Andrew Bresticker,
	Linux Crypto Mailing List

On Tue, Mar 17, 2015 at 01:01:04PM +1100, Stephen Rothwell wrote:
> 
> After merging the crypto tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/crypto/img-hash.c: At top level:
> drivers/crypto/img-hash.c:878:1: error: expected ',' or ';' before 'static'
>  static int img_hash_probe(struct platform_device *pdev)
>  ^
> 
> Caused by commit d358f1abbf71 ("crypto: img-hash - Add Imagination
> Technologies hw hash accelerator").

Thanks for the report Stephen, I'll merge this patch to fix it.

---8<---
imghash: Add missing semicolon to fix build error
    
There is a missing semicolon after MODULE_DEVICE_TABLE.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/img-hash.c b/drivers/crypto/img-hash.c
index 0274172..fec61fc 100644
--- a/drivers/crypto/img-hash.c
+++ b/drivers/crypto/img-hash.c
@@ -873,7 +873,7 @@ static const struct of_device_id img_hash_match[] = {
 	{ .compatible = "img,hash-accelerator" },
 	{}
 };
-MODULE_DEVICE_TABLE(of, img_hash_match)
+MODULE_DEVICE_TABLE(of, img_hash_match);
 
 static int img_hash_probe(struct platform_device *pdev)
 {

-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2015-03-17  2:01 Stephen Rothwell
  2015-03-17 11:11 ` Herbert Xu
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2015-03-17  2:01 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, James Hartley, Andrew Bresticker

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/crypto/img-hash.c: At top level:
drivers/crypto/img-hash.c:878:1: error: expected ',' or ';' before 'static'
 static int img_hash_probe(struct platform_device *pdev)
 ^

Caused by commit d358f1abbf71 ("crypto: img-hash - Add Imagination
Technologies hw hash accelerator").

I have used the crypto tree from next-20150316 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2014-07-24  7:04 ` Randy Dunlap
@ 2014-07-24 13:37   ` Tom Lendacky
  0 siblings, 0 replies; 48+ messages in thread
From: Tom Lendacky @ 2014-07-24 13:37 UTC (permalink / raw)
  To: Randy Dunlap, Stephen Rothwell, Herbert Xu; +Cc: linux-next, linux-kernel

On 07/24/2014 02:04 AM, Randy Dunlap wrote:
> On 07/23/2014 08:08 PM, Stephen Rothwell wrote:
>> Hi Herbert,
>>
>> After merging the crypto tree, today's linux-next build (powerpc
>> ppc64_defconfig) produced these messages:
>>
>> fs/sysfs/Kconfig:1:error: recursive dependency detected!
>> fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
>> drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
>> drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
>> drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
>> drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB
>> drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH
>
> Don't know if it will help, but we
> aren't supposed to use 'select' for subsystems, like USB above.
>
>> drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
>> drivers/input/Kconfig:8:	symbol INPUT is selected by VT
>
> That one ^^^ is also questionable.
>
>> drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
>> drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
>> drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
>> drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
>> drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
>> drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
>> drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
>> drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO
>> crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP
>
> That one ^^^ could be questionable...
>
>> net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
>> fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS
>>
>> The x86_64 allmodconfig build produced these:
>>
>> scripts/kconfig/conf --allmodconfig Kconfig
>> drivers/usb/Kconfig:41:error: recursive dependency detected!
>> drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH
>> drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
>> drivers/input/Kconfig:8:	symbol INPUT is selected by VT
>> drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
>> drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
>> drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
>> drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
>> drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
>> drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
>> drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
>> drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO

I submitted a patch to Herbert to remove the "select OF if ARM64" that
caused this.  He applied it early this morning.  OF is selected by
ARM64 so it wasn't really needed. I'm surprised that this error occurs
when the select is protected by an "if ARM64" and none of these builds
is ARCH=arm64.

Thanks,
Tom

>> crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP
>> net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
>> fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS
>> fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
>> drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
>> drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
>> drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
>> drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB
>>
>> And then the arm multi_v7_defconfig build produced these:
>>
>> drivers/usb/Kconfig:41:error: recursive dependency detected!
>> drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH
>> drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
>> drivers/input/Kconfig:8:	symbol INPUT is selected by VT
>> drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
>> drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
>> drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
>> drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
>> drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
>> drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
>> drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
>> drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO
>> crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP
>> net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
>> fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS
>> fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
>> drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
>> drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
>> drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
>> drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB
>> #
>> # configuration written to .config
>> #
>> WITHOUT_CCACHE:
>> WITHOUT_DISTCC:
>> ARCH=arm
>> CCVER=4.9.0
>> drivers/usb/Kconfig:41:error: recursive dependency detected!
>> drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH
>> drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
>> drivers/input/Kconfig:8:	symbol INPUT is selected by VT
>> drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
>> drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
>> drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
>> drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
>> drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
>> drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
>> drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
>> drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO
>> crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP
>> net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
>> fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS
>> fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
>> drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
>> drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
>> drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
>> drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB
>> *
>> * Restart config...
>> *
>> *
>> * USB HID Boot Protocol drivers
>> *
>> USB HIDBP Keyboard (simple Boot) support (USB_KBD) [N/m/y/?] (NEW) aborted!
>>
>> Console input/output is redirected. Run 'make oldconfig' to update configuration.
>>
>>
>> I am not sure exactly what caused all this, but it is probably commit
>> 126ae9adc1ec ("crypto: ccp - Base AXI DMA cache settings on device
>> tree").
>>
>> I have used the version of the crypto tree from next-20140723 for today.
>>
>
>

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2014-07-24  3:08 Stephen Rothwell
@ 2014-07-24  7:04 ` Randy Dunlap
  2014-07-24 13:37   ` Tom Lendacky
  0 siblings, 1 reply; 48+ messages in thread
From: Randy Dunlap @ 2014-07-24  7:04 UTC (permalink / raw)
  To: Stephen Rothwell, Herbert Xu; +Cc: linux-next, linux-kernel, Tom Lendacky

On 07/23/2014 08:08 PM, Stephen Rothwell wrote:
> Hi Herbert,
> 
> After merging the crypto tree, today's linux-next build (powerpc
> ppc64_defconfig) produced these messages:
> 
> fs/sysfs/Kconfig:1:error: recursive dependency detected!
> fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
> drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
> drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
> drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
> drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB
> drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH

Don't know if it will help, but we
aren't supposed to use 'select' for subsystems, like USB above.

> drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
> drivers/input/Kconfig:8:	symbol INPUT is selected by VT

That one ^^^ is also questionable.

> drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
> drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
> drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
> drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
> drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
> drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
> drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
> drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO
> crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP

That one ^^^ could be questionable...

> net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
> fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS
> 
> The x86_64 allmodconfig build produced these:
> 
> scripts/kconfig/conf --allmodconfig Kconfig
> drivers/usb/Kconfig:41:error: recursive dependency detected!
> drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH
> drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
> drivers/input/Kconfig:8:	symbol INPUT is selected by VT
> drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
> drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
> drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
> drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
> drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
> drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
> drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
> drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO
> crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP
> net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
> fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS
> fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
> drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
> drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
> drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
> drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB
> 
> And then the arm multi_v7_defconfig build produced these:
> 
> drivers/usb/Kconfig:41:error: recursive dependency detected!
> drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH
> drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
> drivers/input/Kconfig:8:	symbol INPUT is selected by VT
> drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
> drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
> drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
> drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
> drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
> drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
> drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
> drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO
> crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP
> net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
> fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS
> fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
> drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
> drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
> drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
> drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB
> #
> # configuration written to .config
> #
> WITHOUT_CCACHE: 
> WITHOUT_DISTCC: 
> ARCH=arm
> CCVER=4.9.0
> drivers/usb/Kconfig:41:error: recursive dependency detected!
> drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH
> drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
> drivers/input/Kconfig:8:	symbol INPUT is selected by VT
> drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
> drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
> drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
> drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
> drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
> drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
> drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
> drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO
> crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP
> net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
> fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS
> fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
> drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
> drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
> drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
> drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB
> *
> * Restart config...
> *
> *
> * USB HID Boot Protocol drivers
> *
> USB HIDBP Keyboard (simple Boot) support (USB_KBD) [N/m/y/?] (NEW) aborted!
> 
> Console input/output is redirected. Run 'make oldconfig' to update configuration.
> 
> 
> I am not sure exactly what caused all this, but it is probably commit
> 126ae9adc1ec ("crypto: ccp - Base AXI DMA cache settings on device
> tree").
> 
> I have used the version of the crypto tree from next-20140723 for today.
> 


-- 
~Randy

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2014-07-24  3:08 Stephen Rothwell
  2014-07-24  7:04 ` Randy Dunlap
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2014-07-24  3:08 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Tom Lendacky

[-- Attachment #1: Type: text/plain, Size: 6200 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (powerpc
ppc64_defconfig) produced these messages:

fs/sysfs/Kconfig:1:error: recursive dependency detected!
fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB
drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH
drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
drivers/input/Kconfig:8:	symbol INPUT is selected by VT
drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO
crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP
net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS

The x86_64 allmodconfig build produced these:

scripts/kconfig/conf --allmodconfig Kconfig
drivers/usb/Kconfig:41:error: recursive dependency detected!
drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH
drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
drivers/input/Kconfig:8:	symbol INPUT is selected by VT
drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO
crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP
net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS
fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB

And then the arm multi_v7_defconfig build produced these:

drivers/usb/Kconfig:41:error: recursive dependency detected!
drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH
drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
drivers/input/Kconfig:8:	symbol INPUT is selected by VT
drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO
crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP
net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS
fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB
#
# configuration written to .config
#
WITHOUT_CCACHE: 
WITHOUT_DISTCC: 
ARCH=arm
CCVER=4.9.0
drivers/usb/Kconfig:41:error: recursive dependency detected!
drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH
drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
drivers/input/Kconfig:8:	symbol INPUT is selected by VT
drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO
crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP
net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS
fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB
*
* Restart config...
*
*
* USB HID Boot Protocol drivers
*
USB HIDBP Keyboard (simple Boot) support (USB_KBD) [N/m/y/?] (NEW) aborted!

Console input/output is redirected. Run 'make oldconfig' to update configuration.


I am not sure exactly what caused all this, but it is probably commit
126ae9adc1ec ("crypto: ccp - Base AXI DMA cache settings on device
tree").

I have used the version of the crypto tree from next-20140723 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2014-06-23 13:15   ` Stephen Rothwell
@ 2014-06-23 13:40     ` Herbert Xu
  0 siblings, 0 replies; 48+ messages in thread
From: Herbert Xu @ 2014-06-23 13:40 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Tadeusz Struk

On Mon, Jun 23, 2014 at 11:15:31PM +1000, Stephen Rothwell wrote:
> Hi Herbert,
> 
> On Mon, 23 Jun 2014 20:27:47 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
> >
> > That's weird as it built correctly here.  This looks like a
> > make/gcc issue as the missing header file is meant to be found
> > with an additional -I.
> > 
> > Could you do a make V=1 for me and show me what the gcc command-line
> > looks like?
> 
> Not until tomorrow.  In the mean time, could you try it with an
> external object dir i.e. "make O=..."
> 
> If that breaks, I think you need to change CURDIR to srcdir or some
> such ...

Thanks for the hint Stephen.  I've added the following fix which
hopefully should fix the problem.

commit e60b244281cfe03ddd7c5c15c4e6b6d6316bb530
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date:   Mon Jun 23 21:37:53 2014 +0800

    crypto: qat - Fix build problem with O=
    
    qat adds -I to the ccflags.  Unfortunately it uses CURDIR which
    breaks when make is invoked with O=.  This patch replaces CURDIR
    with $(src) which should work with/without O=.
    
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/qat/qat_dh895xcc/Makefile b/drivers/crypto/qat/qat_dh895xcc/Makefile
index 8e4924d..25171c5 100644
--- a/drivers/crypto/qat/qat_dh895xcc/Makefile
+++ b/drivers/crypto/qat/qat_dh895xcc/Makefile
@@ -1,4 +1,4 @@
-ccflags-y := -I$(CURDIR)/drivers/crypto/qat/qat_common
+ccflags-y := -I$(src)/../qat_common
 obj-$(CONFIG_CRYPTO_DEV_QAT_DH895xCC) += qat_dh895xcc.o
 qat_dh895xcc-objs := adf_drv.o \
 		adf_isr.o \

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2014-06-23 12:27 ` Herbert Xu
@ 2014-06-23 13:15   ` Stephen Rothwell
  2014-06-23 13:40     ` Herbert Xu
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2014-06-23 13:15 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Tadeusz Struk

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

Hi Herbert,

On Mon, 23 Jun 2014 20:27:47 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> That's weird as it built correctly here.  This looks like a
> make/gcc issue as the missing header file is meant to be found
> with an additional -I.
> 
> Could you do a make V=1 for me and show me what the gcc command-line
> looks like?

Not until tomorrow.  In the mean time, could you try it with an
external object dir i.e. "make O=..."

If that breaks, I think you need to change CURDIR to srcdir or some
such ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2014-06-23  1:49 Stephen Rothwell
@ 2014-06-23 12:27 ` Herbert Xu
  2014-06-23 13:15   ` Stephen Rothwell
  0 siblings, 1 reply; 48+ messages in thread
From: Herbert Xu @ 2014-06-23 12:27 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Tadeusz Struk

Hi Stephen:

On Mon, Jun 23, 2014 at 11:49:42AM +1000, Stephen Rothwell wrote:
> 
> After merging the crypto tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> 
> drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.c:47:31: fatal error: adf_accel_devices.h: No such file or directory
>  #include <adf_accel_devices.h>
>                                ^
> drivers/crypto/qat/qat_dh895xcc/adf_isr.c:54:31: fatal error: adf_accel_devices.h: No such file or directory
>  #include <adf_accel_devices.h>
>                                ^
> drivers/crypto/qat/qat_dh895xcc/adf_drv.c:60:31: fatal error: adf_accel_devices.h: No such file or directory
>  #include <adf_accel_devices.h>
>                                ^
> 
> Caused by commit 7afa232e76ce ("crypto: qat - Intel(R) QAT DH895xcc
> accelerator").
> 
> I have used the crypto tree from next-20140620 for today.

That's weird as it built correctly here.  This looks like a
make/gcc issue as the missing header file is meant to be found
with an additional -I.

Could you do a make V=1 for me and show me what the gcc command-line
looks like?

FWIW mine is:

  gcc -Wp,-MD,drivers/crypto/qat/qat_dh895xcc/.adf_dh895xcc_hw_data.o.d  -nostdinc -isystem /usr/lib/gcc/x86_64-linux-gnu/4.7/include -I./arch/x86/include -Iarch/x86/include/generated  -Iinclude -I./arch/x86/include/uapi -Iarch/x86/include/generated/uapi -I./include/uapi -Iinclude/generated/uapi -include ./include/linux/kconfig.h -D__KERNEL__ -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -m64 -mno-mmx -mno-sse -mno-80387 -mno-fp-ret-in-387 -march=core2 -mno-red-zone -mcmodel=kernel -funit-at-a-time -maccumulate-outgoing-args -DCONFIG_AS_CFI=1 -DCONFIG_AS_CFI_SIGNAL_FRAME=1 -DCONFIG_AS_CFI_SECTIONS=1 -DCONFIG_AS_FXSAVEQ=1 -DCONFIG_AS_CRC32=1 -DCONFIG_AS_AVX=1 -DCONFIG_AS_AVX2=1 -pipe -Wno-sign-com
 pare -fno-asynchronous-unwind-tables -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx -fno-delete-null-pointer-checks -O2 -Wframe-larger-than=1024 -fno-stack-protector -Wno-unused-but-set-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fconserve-stack -Werror=implicit-int -Werror=strict-prototypes -DCC_HAVE_ASM_GOTO -I/home/gondost/herbert/src/build/kernel/test-64/drivers/crypto/qat/qat_common  -DMODULE  -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(adf_dh895xcc_hw_data)"  -D"KBUILD_MODNAME=KBUILD_STR(qat_dh895xcc)" -c -o drivers/crypto/qat/qat_dh895xcc/.tmp_adf_dh895xcc_hw_data.o drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.c

Note the -I for qat_common which is where that header file is.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2014-06-23  1:49 Stephen Rothwell
  2014-06-23 12:27 ` Herbert Xu
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2014-06-23  1:49 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Tadeusz Struk

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:


drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.c:47:31: fatal error: adf_accel_devices.h: No such file or directory
 #include <adf_accel_devices.h>
                               ^
drivers/crypto/qat/qat_dh895xcc/adf_isr.c:54:31: fatal error: adf_accel_devices.h: No such file or directory
 #include <adf_accel_devices.h>
                               ^
drivers/crypto/qat/qat_dh895xcc/adf_drv.c:60:31: fatal error: adf_accel_devices.h: No such file or directory
 #include <adf_accel_devices.h>
                               ^

Caused by commit 7afa232e76ce ("crypto: qat - Intel(R) QAT DH895xcc
accelerator").

I have used the crypto tree from next-20140620 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2013-12-06  0:45 Stephen Rothwell
  0 siblings, 0 replies; 48+ messages in thread
From: Stephen Rothwell @ 2013-12-06  0:45 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Cesar Eduardo Barros

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

crypto/memneq.c: In function '__crypto_memneq_16':
crypto/memneq.c:145:2: warning: no return statement in function returning non-void [-Wreturn-type]
crypto/memneq.c: At top level:
crypto/memneq.c:147:2: error: expected identifier or '(' before 'return'
crypto/memneq.c:148:1: error: expected identifier or '(' before '}' token

Caused by commit fe8c8a126806 ("crypto: more robust crypto_memneq").

I have used the crypto tree from next-20131205 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2013-05-27  3:43     ` Stephen Rothwell
@ 2013-05-27  3:44       ` Herbert Xu
  0 siblings, 0 replies; 48+ messages in thread
From: Herbert Xu @ 2013-05-27  3:44 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Tim Chen

On Mon, May 27, 2013 at 01:43:01PM +1000, Stephen Rothwell wrote:
> Hi Herbert,
> 
> On Mon, 27 May 2013 10:19:18 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
> >
> > Hi Stephen, did you get a chance to switch back to the current
> > cryptodev tree?
> 
> Not quite sure what you mean?  I fetch your tree every morning (that I
> build linux-next) so I got an update from you this morning.  I haven't
> got to merging and building it yet, but it looks good.

Great!

The reason I asked is because I got a build failure from the
kbuild robot over the weekend that was using a two-week old
version of cryptodev.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2013-05-27  2:19   ` Herbert Xu
@ 2013-05-27  3:43     ` Stephen Rothwell
  2013-05-27  3:44       ` Herbert Xu
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2013-05-27  3:43 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Tim Chen

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

Hi Herbert,

On Mon, 27 May 2013 10:19:18 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> Hi Stephen, did you get a chance to switch back to the current
> cryptodev tree?

Not quite sure what you mean?  I fetch your tree every morning (that I
build linux-next) so I got an update from you this morning.  I haven't
got to merging and building it yet, but it looks good.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2013-05-24  9:57 ` Herbert Xu
@ 2013-05-27  2:19   ` Herbert Xu
  2013-05-27  3:43     ` Stephen Rothwell
  0 siblings, 1 reply; 48+ messages in thread
From: Herbert Xu @ 2013-05-27  2:19 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Tim Chen

On Fri, May 24, 2013 at 05:57:15PM +0800, Herbert Xu wrote:
> On Tue, May 21, 2013 at 11:45:48AM +1000, Stephen Rothwell wrote:
> > Hi Herbert,
> > 
> > After merging the crypto tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > arch/x86/crypto/crct10dif-pclmul_glue.c: In function 'crct10dif_intel_mod_init':
> > arch/x86/crypto/crct10dif-pclmul_glue.c:140:3: error: implicit declaration of function 'crc_t10dif_update_lib' [-Werror=implicit-function-declaration]
> >    crc_t10dif_update_lib();
> >    ^
> > cc1: some warnings being treated as errors
> > 
> > Caused by commit b85ed9f056ee ("crypto: crct10dif - Glue code to cast
> > accelerated CRCT10DIF assembly as a crypto transform").
> > 
> > I have used the version of the crypto tree from next-20130520 for today.
> 
> Sorry for the late response, it should be fixed now.

Hi Stephen, did you get a chance to switch back to the current
cryptodev tree?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* Re: linux-next: build failure after merge of the crypto tree
  2013-05-21  1:45 Stephen Rothwell
@ 2013-05-24  9:57 ` Herbert Xu
  2013-05-27  2:19   ` Herbert Xu
  0 siblings, 1 reply; 48+ messages in thread
From: Herbert Xu @ 2013-05-24  9:57 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Tim Chen

On Tue, May 21, 2013 at 11:45:48AM +1000, Stephen Rothwell wrote:
> Hi Herbert,
> 
> After merging the crypto tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> arch/x86/crypto/crct10dif-pclmul_glue.c: In function 'crct10dif_intel_mod_init':
> arch/x86/crypto/crct10dif-pclmul_glue.c:140:3: error: implicit declaration of function 'crc_t10dif_update_lib' [-Werror=implicit-function-declaration]
>    crc_t10dif_update_lib();
>    ^
> cc1: some warnings being treated as errors
> 
> Caused by commit b85ed9f056ee ("crypto: crct10dif - Glue code to cast
> accelerated CRCT10DIF assembly as a crypto transform").
> 
> I have used the version of the crypto tree from next-20130520 for today.

Sorry for the late response, it should be fixed now.

Thanks!
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 48+ messages in thread

* linux-next: build failure after merge of the crypto tree
@ 2013-05-21  1:45 Stephen Rothwell
  2013-05-24  9:57 ` Herbert Xu
  0 siblings, 1 reply; 48+ messages in thread
From: Stephen Rothwell @ 2013-05-21  1:45 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Tim Chen

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:

arch/x86/crypto/crct10dif-pclmul_glue.c: In function 'crct10dif_intel_mod_init':
arch/x86/crypto/crct10dif-pclmul_glue.c:140:3: error: implicit declaration of function 'crc_t10dif_update_lib' [-Werror=implicit-function-declaration]
   crc_t10dif_update_lib();
   ^
cc1: some warnings being treated as errors

Caused by commit b85ed9f056ee ("crypto: crct10dif - Glue code to cast
accelerated CRCT10DIF assembly as a crypto transform").

I have used the version of the crypto tree from next-20130520 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 48+ messages in thread

end of thread, back to index

Thread overview: 48+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05  4:57 linux-next: build failure after merge of the crypto tree Stephen Rothwell
2019-08-05  5:37 ` Chuhong Yuan
2019-08-08  1:52 ` Stephen Rothwell
2019-08-08  3:01   ` Herbert Xu
2019-08-08  3:17     ` Stephen Rothwell
2019-08-08  5:00       ` Herbert Xu
2019-08-08  5:04         ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2019-08-12  3:21 Stephen Rothwell
2019-08-12  6:53 ` Zhou Wang
2018-10-08  1:03 Stephen Rothwell
2018-10-08  5:54 ` Herbert Xu
2018-05-29  9:08 Stephen Rothwell
2018-05-29 10:16 ` Ondrej Mosnáček
2018-05-29 10:22   ` Stephen Rothwell
2017-11-06  0:25 Stephen Rothwell
2017-11-06  5:40 ` Herbert Xu
2016-11-29  0:55 Stephen Rothwell
2016-11-29  7:08 ` Herbert Xu
2016-11-29  8:34   ` Horia Geantă
2016-11-29  8:43     ` Herbert Xu
2016-07-20  7:46 Stephen Rothwell
2016-07-20 14:32 ` Herbert Xu
2016-06-24  6:20 Stephen Rothwell
2016-06-24 13:33 ` Herbert Xu
2016-06-24 13:36   ` Benedetto, Salvatore
2016-02-17  1:26 Stephen Rothwell
2015-10-15  1:37 Stephen Rothwell
2015-10-15  2:01 ` Herbert Xu
2015-08-05  6:49 Stephen Rothwell
2015-08-05  7:28 ` Herbert Xu
2015-06-20  6:35 Stephen Rothwell
2015-05-28 11:40 Stephen Rothwell
2015-05-28 13:08 ` Stephan Mueller
2015-03-17  2:01 Stephen Rothwell
2015-03-17 11:11 ` Herbert Xu
2014-07-24  3:08 Stephen Rothwell
2014-07-24  7:04 ` Randy Dunlap
2014-07-24 13:37   ` Tom Lendacky
2014-06-23  1:49 Stephen Rothwell
2014-06-23 12:27 ` Herbert Xu
2014-06-23 13:15   ` Stephen Rothwell
2014-06-23 13:40     ` Herbert Xu
2013-12-06  0:45 Stephen Rothwell
2013-05-21  1:45 Stephen Rothwell
2013-05-24  9:57 ` Herbert Xu
2013-05-27  2:19   ` Herbert Xu
2013-05-27  3:43     ` Stephen Rothwell
2013-05-27  3:44       ` Herbert Xu

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org linux-next@archiver.kernel.org
	public-inbox-index linux-next


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/ public-inbox