* [PATCH v3 0/5] Add support for Axis, ARTPEC-8 PCIe driver [not found] <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p7> @ 2022-06-14 1:16 ` Wangseok Lee [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p3> ` (3 more replies) 2022-06-21 7:56 ` [PATCH v3 3/5] PCI: axis: Add ARTPEC-8 PCIe controller driver Wangseok Lee 2022-07-06 5:20 ` [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy Wangseok Lee 2 siblings, 4 replies; 30+ messages in thread From: Wangseok Lee @ 2022-06-14 1:16 UTC (permalink / raw) To: robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim, Wangseok Lee This v3 patchset is improvement several review comments received from patchset v2. Main changes since v2 [2]: dt-bindings: pci: Add ARTPEC-8 PCIe controller -modify version history to fit the linux commit rule -remove 'Device Tree Bindings' on title -remove the interrupt-names, phy-names entries -remove '_clk' suffix -add the compatible entries on required -change node name to soc from artpec8 on examples dt-bindings: phy: Add ARTPEC-8 PCIe phy -modify version history to fit the linux commit rule -remove 'Device Tree Bindings' on title -remove clock-names entries -change node name to soc from artpec8 on excamples PCI: axis: Add ARTPEC-8 PCIe controller driver -add 'COMPILE_TEST' and improvement help on kconfig -reorder obj on makefile -use clk_bulk_api -remove unnecessary comment -redefine the ELBI register to distinguish between offset and bit definition -improvement order local variable of function -remove unnecessary local return variable phy: Add ARTPEC-8 PCIe PHY driver -remove unnecessary indentation -redefine local struct to statis const -add static const to struct that requires static const definition -remove wrappers on writel and readl Main changes since v1 [1]: -'make dt_binding_check' result improvement -Add the missing property list -improvement review comment of Krzysztof on driver code -change folder name of phy driver to axis from artpec [2] https://lore.kernel.org/lkml/20220613015023epcms2p70e6700a99042d4deb560e40ab5397001@epcms2p7/T/ [1] https://lore.kernel.org/lkml/20220328014430epcms2p7063834feb0abdf2f38a62723c96c9ff1@epcms2p7/ -------------------------------------------------------------- This series patches include newly PCIe support for Axis ARTPEC-8 SoC. ARTPEC-8 is the SoC platform of Axis Communications. PCIe controller driver and phy driver have been newly added. There is also a new MAINTAINER in the addition of phy driver. PCIe controller is designed based on Design-Ware PCIe controller IP and PCIe phy is desinged based on SAMSUNG PHY IP. It also includes modifications to the Design-Ware controller driver to run the 64bit-based ARTPEC-8 PCIe controller driver. It consists of 6 patches in total. This series has been tested on AXIS SW bring-up board with ARTPEC-8 chipset. -------------------------------------------------------------- Wangseok Lee (5): dt-bindings: pci: Add ARTPEC-8 PCIe controller dt-bindings: phy: Add ARTPEC-8 PCIe phy PCI: axis: Add ARTPEC-8 PCIe controller driver phy: Add ARTPEC-8 PCIe PHY driver MAINTAINERS: Add Axis ARTPEC-8 PCIe PHY maintainers .../bindings/pci/axis,artpec8-pcie-ep.yaml | 109 +++ .../devicetree/bindings/pci/axis,artpec8-pcie.yaml | 120 ++++ .../bindings/phy/axis,artpec8-pcie-phy.yaml | 73 ++ MAINTAINERS | 2 + drivers/pci/controller/dwc/Kconfig | 31 + drivers/pci/controller/dwc/Makefile | 1 + drivers/pci/controller/dwc/pcie-artpec8.c | 797 +++++++++++++++++++++ drivers/phy/Kconfig | 1 + drivers/phy/Makefile | 1 + drivers/phy/axis/Kconfig | 9 + drivers/phy/axis/Makefile | 2 + drivers/phy/axis/phy-artpec8-pcie.c | 776 ++++++++++++++++++++ 12 files changed, 1922 insertions(+) create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml create mode 100644 Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml create mode 100644 drivers/pci/controller/dwc/pcie-artpec8.c create mode 100644 drivers/phy/axis/Kconfig create mode 100644 drivers/phy/axis/Makefile create mode 100644 drivers/phy/axis/phy-artpec8-pcie.c -- 2.9.5 ^ permalink raw reply [flat|nested] 30+ messages in thread
[parent not found: <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p3>]
* [PATCH v3 3/5] PCI: axis: Add ARTPEC-8 PCIe controller driver [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p3> @ 2022-06-14 1:30 ` Wangseok Lee 2022-06-20 8:35 ` Krzysztof Kozlowski 0 siblings, 1 reply; 30+ messages in thread From: Wangseok Lee @ 2022-06-14 1:30 UTC (permalink / raw) To: robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim Add support Axis, ARTPEC-8 SoC. ARTPEC-8 is the SoC platform of Axis Communications. This is based on arm64 and support GEN4 & 2lane. This PCIe controller is based on DesignWare Hardware core and uses DesignWa re core functions to implement the driver. "pcie-artpec6. c" supports artpec6 and artpec7 H/W. artpec8 can not be expanded because H/W configuration is completely differe nt from artpec6/7. phy and sub controller are different. Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> Signed-off-by: Jaeho Cho <jaeho79.cho@samsung.com> --- v2->v3 : -add 'COMPILE_TEST' and improvement help on kconfig -reorder obj on makefile -use clk_bulk_api -remove unnecessary comment -redefine the ELBI register to distinguish between offset and bit definition -improvement order local variable of function -remove unnecessary local return variable v1->v2 : improvement review comment of Krzysztof on driver code. -debug messages for probe or other functions. -Inconsistent coding style (different indentation in structure members). -Inconsistent code (artpec8_pcie_get_subsystem_resources() gets device from pdev and from pci so you have two same pointers; or artpec8_pcie_get_ep_mem_resources() stores dev as local variable but uses instead pdev->dev). -Not using devm_platform_ioremap_resource(). -Printing messages in interrupt handlers. -Several local/static structures or array are not const. --- drivers/pci/controller/dwc/Kconfig | 31 ++ drivers/pci/controller/dwc/Makefile | 1 + drivers/pci/controller/dwc/pcie-artpec8.c | 797 ++++++++++++++++++++++++++++++ 3 files changed, 829 insertions(+) create mode 100644 drivers/pci/controller/dwc/pcie-artpec8.c diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig index 62ce3ab..2b16637 100644 --- a/drivers/pci/controller/dwc/Kconfig +++ b/drivers/pci/controller/dwc/Kconfig @@ -222,6 +222,37 @@ config PCIE_ARTPEC6_EP Enables support for the PCIe controller in the ARTPEC-6 SoC to work in endpoint mode. This uses the DesignWare core. +config PCIE_ARTPEC8 + bool "Axis ARTPEC-8 PCIe controller" + +config PCIE_ARTPEC8_HOST + bool "Axis ARTPEC-8 PCIe controller Host Mode" + depends on ARCH_ARTPEC || COMPILE_TEST + depends on PCI_MSI_IRQ_DOMAIN + depends on PCI_ENDPOINT + select PCI_EPF_TEST + select PCIE_DW_HOST + select PCIE_ARTPEC8 + help + Say 'Y' here to enable support for the PCIe controller in the + ARTPEC-8 SoC to work in host mode. + This PCIe controller is based on DesignWare hardware core and + uses DesignWare core functions to implement the driver. + +config PCIE_ARTPEC8_EP + bool "Axis ARTPEC-8 PCIe controller Endpoint Mode" + depends on ARCH_ARTPEC || COMPILE_TEST + depends on PCI_ENDPOINT + depends on PCI_ENDPOINT_CONFIGFS + select PCI_EPF_TEST + select PCIE_DW_EP + select PCIE_ARTPEC8 + help + Say 'Y' here to enable support for the PCIe controller in the + ARTPEC-8 SoC to work in endpoint mode. + This PCIe controller is based on DesignWare hardware core and + uses DesignWare core functions to implement the driver. + config PCIE_ROCKCHIP_DW_HOST bool "Rockchip DesignWare PCIe controller" select PCIE_DW diff --git a/drivers/pci/controller/dwc/Makefile b/drivers/pci/controller/dwc/Makefile index 8ba7b67..95f5877 100644 --- a/drivers/pci/controller/dwc/Makefile +++ b/drivers/pci/controller/dwc/Makefile @@ -15,6 +15,7 @@ obj-$(CONFIG_PCIE_QCOM) += pcie-qcom.o obj-$(CONFIG_PCIE_QCOM_EP) += pcie-qcom-ep.o obj-$(CONFIG_PCIE_ARMADA_8K) += pcie-armada8k.o obj-$(CONFIG_PCIE_ARTPEC6) += pcie-artpec6.o +obj-$(CONFIG_PCIE_ARTPEC8) += pcie-artpec8.o obj-$(CONFIG_PCIE_ROCKCHIP_DW_HOST) += pcie-dw-rockchip.o obj-$(CONFIG_PCIE_INTEL_GW) += pcie-intel-gw.o obj-$(CONFIG_PCIE_KEEMBAY) += pcie-keembay.o diff --git a/drivers/pci/controller/dwc/pcie-artpec8.c b/drivers/pci/controller/dwc/pcie-artpec8.c new file mode 100644 index 0000000..996fcfc --- /dev/null +++ b/drivers/pci/controller/dwc/pcie-artpec8.c @@ -0,0 +1,797 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * PCIe controller driver for Axis ARTPEC-8 SoC + * + * Copyright (C) 2019 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * Author: Jaeho Cho <jaeho79.cho@samsung.com> + * This file is based on driver/pci/controller/dwc/pci-exynos.c + */ + +#include <linux/clk.h> +#include <linux/module.h> +#include <linux/mfd/syscon.h> +#include <linux/of_device.h> +#include <linux/regmap.h> +#include <linux/resource.h> +#include <linux/types.h> +#include <linux/phy/phy.h> + +#include "pcie-designware.h" + +#define to_artpec8_pcie(x) dev_get_drvdata((x)->dev) + +/* Gen3 Control Register */ +#define PCIE_GEN3_RELATED_OFF 0x890 +#define PCIE_GEN3_EQUALIZATION_DISABLE (0x1 << 16) +#define PCIE_GEN3_EQ_PHASE_2_3 (0x1 << 9) +#define PCIE_GEN3_RXEQ_PH01_EN (0x1 << 12) +#define PCIE_GEN3_RXEQ_RGRDLESS_RXTS (0x1 << 13) + +#define FAST_LINK_MODE (7) + +/* PCIe ELBI registers */ +#define PCIE_IRQ0_STS 0x000 +#define PCIE_IRQ1_STS 0x004 +#define PCIE_IRQ2_STS 0x008 +#define IRQ2_STS_IRQ_MSI_ST BIT(20) +#define PCIE_IRQ5_STS 0x00C +#define PCIE_IRQ0_EN 0x010 +#define PCIE_IRQ1_EN 0x014 +#define PCIE_IRQ2_EN 0x018 +#define IRQ2_EN_IRQ_MSI BIT(20) +#define PCIE_IRQ5_EN 0x01C +#define PCIE_APP_LTSSM_ENABLE 0x054 +#define APP_LTSSM_ENABLE_EN_BIT BIT(0) +#define PCIE_ELBI_CXPL_DEBUG_00_31 0x2C8 +#define PCIE_ELBI_CXPL_DEBUG_32_63 0x2CC +#define PCIE_ARTPEC8_DEVICE_TYPE 0x080 +#define DEVICE_TYPE_EP 0x0 +#define DEVICE_TYPE_LEG_EP BIT(0) +#define DEVICE_TYPE_RC BIT(2) +#define LTSSM_STATE_MASK 0x3F +#define LTSSM_STATE_L0 0x11 + +/* FSYS glue logic system registers */ +#define FSYS_PCIE_CON 0x424 +#define PCIE_PERSTN BIT(5) +#define FSYS_PCIE_DBI_ADDR_CON 0x428 +#define FSYS_PCIE_DBI_ADDR_OVR_CDM 0x00 +#define FSYS_PCIE_DBI_ADDR_OVR_SHADOW 0x12 +#define FSYS_PCIE_DBI_ADDR_OVR_ATU 0x36 + +/* PMU SYSCON Offsets */ +#define PMU_SYSCON_PCIE_ISOLATION 0x3200 + +/* BUS P/S SYSCON Offsets */ +#define BUS_SYSCON_BUS_PATH_ENABLE 0x0 + +struct artpec8_pcie { + struct dw_pcie *pci; + const struct artpec8_pcie_pdata *pdata; + void __iomem *elbi_base; + struct regmap *sysreg; + struct regmap *pmu_syscon; + struct regmap *bus_s_syscon; + struct regmap *bus_p_syscon; + enum dw_pcie_device_mode mode; + int link_id; + struct phy *phy; +}; + +struct artpec8_pcie_res_ops { + int (*get_mem_resources)(struct platform_device *pdev, + struct artpec8_pcie *artpec8_ctrl); + int (*get_clk_resources)(struct platform_device *pdev); + int (*init_clk_resources)(void); + void (*deinit_clk_resources)(void); +}; + +struct artpec8_pcie_pdata { + const struct dw_pcie_ops *dwc_ops; + const struct dw_pcie_host_ops *host_ops; + const struct artpec8_pcie_res_ops *res_ops; + enum dw_pcie_device_mode mode; +}; + +enum artpec8_pcie_isolation { + PCIE_CLEAR_ISOLATION = 0, + PCIE_SET_ISOLATION = 1 +}; + +enum artpec8_pcie_reg_bit { + PCIE_REG_BIT_LOW = 0, + PCIE_REG_BIT_HIGH = 1 +}; + +static const int artpec8_pcie_dbi_addr_con[] = { + FSYS_PCIE_DBI_ADDR_CON +}; + +static struct clk_bulk_data artpec8_pcie_clks[] = { + { .id = "pipe" }, + { .id = "dbi" }, + { .id = "mstr" }, + { .id = "slv" }, +}; + +static u32 artpec8_pcie_read_dbi(struct dw_pcie *pci, void __iomem *base, + u32 reg, size_t size) +{ + struct artpec8_pcie *artpec8_ctrl = to_artpec8_pcie(pci); + u32 val; + bool is_atu = false; + + if (base == pci->atu_base) { + is_atu = true; + base = pci->dbi_base; + regmap_write(artpec8_ctrl->sysreg, + artpec8_pcie_dbi_addr_con[artpec8_ctrl->link_id], + FSYS_PCIE_DBI_ADDR_OVR_ATU); + } + + dw_pcie_read(base + reg, size, &val); + + if (is_atu) + regmap_write(artpec8_ctrl->sysreg, + artpec8_pcie_dbi_addr_con[artpec8_ctrl->link_id], + FSYS_PCIE_DBI_ADDR_OVR_CDM); + + return val; +} + +static void artpec8_pcie_write_dbi(struct dw_pcie *pci, void __iomem *base, + u32 reg, size_t size, u32 val) +{ + struct artpec8_pcie *artpec8_ctrl = to_artpec8_pcie(pci); + bool is_atu = false; + + if (base == pci->atu_base) { + is_atu = true; + base = pci->dbi_base; + regmap_write(artpec8_ctrl->sysreg, + artpec8_pcie_dbi_addr_con[artpec8_ctrl->link_id], + FSYS_PCIE_DBI_ADDR_OVR_ATU); + } + + dw_pcie_write(base + reg, size, val); + + if (is_atu) + regmap_write(artpec8_ctrl->sysreg, + artpec8_pcie_dbi_addr_con[artpec8_ctrl->link_id], + FSYS_PCIE_DBI_ADDR_OVR_CDM); +} + +static void artpec8_pcie_write_dbi2(struct dw_pcie *pci, void __iomem *base, + u32 reg, size_t size, u32 val) +{ + struct artpec8_pcie *artpec8_ctrl = to_artpec8_pcie(pci); + + regmap_write(artpec8_ctrl->sysreg, + artpec8_pcie_dbi_addr_con[artpec8_ctrl->link_id], + FSYS_PCIE_DBI_ADDR_OVR_SHADOW); + + dw_pcie_write(base + reg, size, val); + + regmap_write(artpec8_ctrl->sysreg, + artpec8_pcie_dbi_addr_con[artpec8_ctrl->link_id], + FSYS_PCIE_DBI_ADDR_OVR_CDM); +} + +static int artpec8_pcie_get_subsystem_resources(struct platform_device *pdev, + struct artpec8_pcie *artpec8_ctrl) +{ + struct device *dev = &pdev->dev; + + /* External Local Bus interface(ELBI) Register */ + artpec8_ctrl->elbi_base = + devm_platform_ioremap_resource_byname(pdev, "elbi"); + if (IS_ERR(artpec8_ctrl->elbi_base)) { + dev_err(dev, "failed to map elbi_base\n"); + return PTR_ERR(artpec8_ctrl->elbi_base); + } + + artpec8_ctrl->sysreg = syscon_regmap_lookup_by_phandle(dev->of_node, + "samsung,fsys-sysreg"); + if (IS_ERR(artpec8_ctrl->sysreg)) { + dev_err(dev, "fsys sysreg regmap lookup failed.\n"); + return PTR_ERR(artpec8_ctrl->sysreg); + } + + artpec8_ctrl->pmu_syscon = syscon_regmap_lookup_by_phandle(dev->of_node, + "samsung,syscon-phandle"); + if (IS_ERR(artpec8_ctrl->pmu_syscon)) { + dev_err(dev, "pmu syscon regmap lookup failed.\n"); + return PTR_ERR(artpec8_ctrl->pmu_syscon); + } + + artpec8_ctrl->bus_s_syscon = + syscon_regmap_lookup_by_phandle(dev->of_node, + "samsung,syscon-bus-s-fsys"); + if (IS_ERR(artpec8_ctrl->bus_s_syscon)) { + dev_err(dev, "bus_s_syscon regmap lookup failed.\n"); + return PTR_ERR(artpec8_ctrl->bus_s_syscon); + } + + artpec8_ctrl->bus_p_syscon = + syscon_regmap_lookup_by_phandle(dev->of_node, + "samsung,syscon-bus-p-fsys"); + if (IS_ERR(artpec8_ctrl->bus_p_syscon)) { + dev_err(dev, "bus_p_syscon regmap lookup failed.\n"); + return PTR_ERR(artpec8_ctrl->bus_p_syscon); + } + + return 0; +} + +static int artpec8_pcie_get_rc_mem_resources(struct platform_device *pdev, + struct artpec8_pcie *artpec8_ctrl) +{ + struct dw_pcie *pci = artpec8_ctrl->pci; + + /* Data Bus Interface(DBI) Register */ + pci->dbi_base = devm_platform_ioremap_resource_byname(pdev, "dbi"); + if (IS_ERR(pci->dbi_base)) + return PTR_ERR(pci->dbi_base); + + return 0; +} + +static int artpec8_pcie_get_ep_mem_resources(struct platform_device *pdev, + struct artpec8_pcie *artpec8_ctrl) +{ + struct dw_pcie *pci = artpec8_ctrl->pci; + struct device *dev = &pdev->dev; + struct dw_pcie_ep *ep = &pci->ep; + struct resource *res; + + pci->dbi_base = devm_platform_ioremap_resource_byname(pdev, "dbi"); + if (IS_ERR(pci->dbi_base)) { + dev_err(dev, "failed to map ep_dbics\n"); + return -ENOMEM; + } + + pci->dbi_base2 = devm_platform_ioremap_resource_byname(pdev, "dbi2"); + if (IS_ERR(pci->dbi_base2)) { + dev_err(dev, "failed to map ep_dbics2\n"); + return -ENOMEM; + } + + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space"); + if (!res) + return -EINVAL; + ep->phys_base = res->start; + ep->addr_size = resource_size(res); + + return 0; +} + +static int artpec8_pcie_get_clk_resources(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + int ret; + + ret = devm_clk_bulk_get(dev, ARRAY_SIZE(artpec8_pcie_clks), + artpec8_pcie_clks); + if (ret) + return ret; + + return 0; +} + +static int artpec8_pcie_init_clk_resources(void) +{ + int ret; + + ret = clk_bulk_prepare_enable(ARRAY_SIZE(artpec8_pcie_clks), + artpec8_pcie_clks); + if (ret) + return ret; + + return 0; +} + +static void artpec8_pcie_deinit_clk_resources(void) +{ + clk_bulk_disable_unprepare(ARRAY_SIZE(artpec8_pcie_clks), + artpec8_pcie_clks); +} + +static const struct artpec8_pcie_res_ops artpec8_pcie_rc_res_ops = { + .get_mem_resources = artpec8_pcie_get_rc_mem_resources, + .get_clk_resources = artpec8_pcie_get_clk_resources, + .init_clk_resources = artpec8_pcie_init_clk_resources, + .deinit_clk_resources = artpec8_pcie_deinit_clk_resources, +}; + +static const struct artpec8_pcie_res_ops artpec8_pcie_ep_res_ops = { + .get_mem_resources = artpec8_pcie_get_ep_mem_resources, + .get_clk_resources = artpec8_pcie_get_clk_resources, + .init_clk_resources = artpec8_pcie_init_clk_resources, + .deinit_clk_resources = artpec8_pcie_deinit_clk_resources, +}; + +static int artpec8_pcie_config_phy_power_isolation(struct dw_pcie *pci, + enum artpec8_pcie_reg_bit val) +{ + struct artpec8_pcie *artpec8_ctrl = to_artpec8_pcie(pci); + + return regmap_write(artpec8_ctrl->pmu_syscon, PMU_SYSCON_PCIE_ISOLATION, + val); + +} + +static int artpec8_pcie_config_bus_enable(struct dw_pcie *pci, + enum artpec8_pcie_reg_bit val) +{ + struct artpec8_pcie *artpec8_ctrl = to_artpec8_pcie(pci); + int ret; + + ret = regmap_write(artpec8_ctrl->bus_p_syscon, + BUS_SYSCON_BUS_PATH_ENABLE, val); + if (ret) + return ret; + + return regmap_write(artpec8_ctrl->bus_s_syscon, + BUS_SYSCON_BUS_PATH_ENABLE, val); +} + +static int artpec8_pcie_config_isolation(struct dw_pcie *pci, + enum artpec8_pcie_isolation val) +{ + int ret; + /* reg_val[0] : for phy power isolation */ + /* reg_val[1] : for bus enable */ + enum artpec8_pcie_reg_bit reg_val[2]; + + switch (val) { + case PCIE_CLEAR_ISOLATION: + reg_val[0] = PCIE_REG_BIT_LOW; + reg_val[1] = PCIE_REG_BIT_HIGH; + break; + case PCIE_SET_ISOLATION: + reg_val[0] = PCIE_REG_BIT_HIGH; + reg_val[1] = PCIE_REG_BIT_LOW; + break; + default: + return -EINVAL; + } + + ret = artpec8_pcie_config_phy_power_isolation(pci, reg_val[0]); + if (ret) + return ret; + + return artpec8_pcie_config_bus_enable(pci, reg_val[1]); +} + +static int artpec8_pcie_config_perstn(struct dw_pcie *pci, + enum artpec8_pcie_reg_bit val) +{ + struct artpec8_pcie *artpec8_ctrl = to_artpec8_pcie(pci); + unsigned int bits; + + if (val == PCIE_REG_BIT_HIGH) + bits = PCIE_PERSTN; + else + bits = 0; + + return regmap_update_bits(artpec8_ctrl->sysreg, FSYS_PCIE_CON, + PCIE_PERSTN, bits); +} + +static void artpec8_pcie_stop_link(struct dw_pcie *pci) +{ + struct artpec8_pcie *artpec8_ctrl = to_artpec8_pcie(pci); + u32 val; + + val = readl(artpec8_ctrl->elbi_base + PCIE_APP_LTSSM_ENABLE); + + val &= ~APP_LTSSM_ENABLE_EN_BIT; + writel(val, artpec8_ctrl->elbi_base + PCIE_APP_LTSSM_ENABLE); +} + +static int artpec8_pcie_start_link(struct dw_pcie *pci) +{ + struct artpec8_pcie *artpec8_ctrl = to_artpec8_pcie(pci); + u32 val; + + dw_pcie_dbi_ro_wr_en(pci); + + /* Equalization disable */ + val = artpec8_pcie_read_dbi(pci, pci->dbi_base, PCIE_GEN3_RELATED_OFF, + 4); + artpec8_pcie_write_dbi(pci, pci->dbi_base, PCIE_GEN3_RELATED_OFF, 4, + val | PCIE_GEN3_EQUALIZATION_DISABLE); + + dw_pcie_dbi_ro_wr_dis(pci); + + /* assert LTSSM enable */ + val = readl(artpec8_ctrl->elbi_base + PCIE_APP_LTSSM_ENABLE); + + val |= APP_LTSSM_ENABLE_EN_BIT; + writel(val, artpec8_ctrl->elbi_base + PCIE_APP_LTSSM_ENABLE); + + return 0; +} + +static irqreturn_t artpec8_pcie_msi_irq_handler(int irq, void *arg) +{ + struct artpec8_pcie *artpec8_ctrl = arg; + struct dw_pcie *pci = artpec8_ctrl->pci; + struct pcie_port *pp = &pci->pp; + u32 val; + + val = readl(artpec8_ctrl->elbi_base + PCIE_IRQ2_STS); + + if ((val & IRQ2_STS_IRQ_MSI_ST) == IRQ2_STS_IRQ_MSI_ST) { + val &= IRQ2_STS_IRQ_MSI_ST; + writel(val, artpec8_ctrl->elbi_base + PCIE_IRQ2_STS); + dw_handle_msi_irq(pp); + } + + return IRQ_HANDLED; +} + +static void artpec8_pcie_msi_init(struct artpec8_pcie *artpec8_ctrl) +{ + u32 val; + + /* enable MSI interrupt */ + val = readl(artpec8_ctrl->elbi_base + PCIE_IRQ2_EN); + val |= IRQ2_EN_IRQ_MSI; + writel(val, artpec8_ctrl->elbi_base + PCIE_IRQ2_EN); +} + +static void artpec8_pcie_enable_interrupts(struct artpec8_pcie *artpec8_ctrl) +{ + if (IS_ENABLED(CONFIG_PCI_MSI)) + artpec8_pcie_msi_init(artpec8_ctrl); +} + +static int artpec8_pcie_rd_own_conf(struct pci_bus *bus, unsigned int devfn, + int where, int size, u32 *val) +{ + struct dw_pcie *pci = to_dw_pcie_from_pp(bus->sysdata); + + if (PCI_SLOT(devfn)) { + PCI_SET_ERROR_RESPONSE(val); + return PCIBIOS_DEVICE_NOT_FOUND; + } + + *val = dw_pcie_read_dbi(pci, where, size); + return PCIBIOS_SUCCESSFUL; +} + +static int artpec8_pcie_wr_own_conf(struct pci_bus *bus, unsigned int devfn, + int where, int size, u32 val) +{ + struct dw_pcie *pci = to_dw_pcie_from_pp(bus->sysdata); + + if (PCI_SLOT(devfn)) + return PCIBIOS_DEVICE_NOT_FOUND; + + dw_pcie_write_dbi(pci, where, size, val); + return PCIBIOS_SUCCESSFUL; +} + +static struct pci_ops artpec8_pci_ops = { + .read = artpec8_pcie_rd_own_conf, + .write = artpec8_pcie_wr_own_conf, +}; + +static int artpec8_pcie_link_up(struct dw_pcie *pci) +{ + struct artpec8_pcie *artpec8_ctrl = to_artpec8_pcie(pci); + u32 val; + + val = readl(artpec8_ctrl->elbi_base + PCIE_ELBI_CXPL_DEBUG_00_31); + + return (val & LTSSM_STATE_MASK) == LTSSM_STATE_L0; +} + +static int artpec8_pcie_host_init(struct pcie_port *pp) +{ + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); + struct artpec8_pcie *artpec8_ctrl = to_artpec8_pcie(pci); + + pp->bridge->ops = &artpec8_pci_ops; + + dw_pcie_writel_dbi(pci, PCIE_GEN3_RELATED_OFF, + (PCIE_GEN3_EQ_PHASE_2_3 | + PCIE_GEN3_RXEQ_PH01_EN | + PCIE_GEN3_RXEQ_RGRDLESS_RXTS)); + + artpec8_pcie_enable_interrupts(artpec8_ctrl); + + return 0; +} + +static const struct dw_pcie_host_ops artpec8_pcie_host_ops = { + .host_init = artpec8_pcie_host_init, +}; + +static u8 artpec8_pcie_iatu_unroll_enabled(struct dw_pcie *pci) +{ + u32 val; + + val = dw_pcie_readl_dbi(pci, PCIE_ATU_VIEWPORT); + pci->atu_base = pci->dbi_base + DEFAULT_DBI_ATU_OFFSET; + + if (val == 0xffffffff) + return 1; + + return 0; +} + +static void artpec8_pcie_ep_init(struct dw_pcie_ep *ep) +{ + struct dw_pcie *pci = to_dw_pcie_from_ep(ep); + enum pci_barno bar; + /* + * Currently PCIe EP core is not setting iatu_unroll_enabled + * so let's handle it here. We need to find proper place to + * initialize this so that it can be used for other EP + * controllers as well. + */ + pci->iatu_unroll_enabled = artpec8_pcie_iatu_unroll_enabled(pci); + + for (bar = BAR_0; bar <= BAR_5; bar++) + dw_pcie_ep_reset_bar(pci, bar); +} + +static int artpec8_pcie_raise_irq(struct dw_pcie_ep *ep, u8 func_no, + enum pci_epc_irq_type type, u16 interrupt_num) +{ + struct dw_pcie *pci = to_dw_pcie_from_ep(ep); + + switch (type) { + case PCI_EPC_IRQ_LEGACY: + return -EINVAL; + case PCI_EPC_IRQ_MSI: + return dw_pcie_ep_raise_msi_irq(ep, func_no, interrupt_num); + default: + dev_err(pci->dev, "UNKNOWN IRQ type\n"); + } + + return 0; +} + +static const struct pci_epc_features artpec8_pcie_epc_features = { + .linkup_notifier = false, + .msi_capable = true, + .msix_capable = false, +}; + +static const struct pci_epc_features* +artpec8_pcie_ep_get_features(struct dw_pcie_ep *ep) +{ + return &artpec8_pcie_epc_features; +} + +static const struct dw_pcie_ep_ops artpec8_dw_pcie_ep_ops = { + .ep_init = artpec8_pcie_ep_init, + .raise_irq = artpec8_pcie_raise_irq, + .get_features = artpec8_pcie_ep_get_features, +}; + +static int __init artpec8_add_pcie_ep(struct artpec8_pcie *artpec8_ctrl, + struct platform_device *pdev) +{ + struct dw_pcie *pci = artpec8_ctrl->pci; + struct dw_pcie_ep *ep = &pci->ep; + int ret; + + ep->ops = &artpec8_dw_pcie_ep_ops; + + dw_pcie_writel_dbi(pci, PCIE_GEN3_RELATED_OFF, + (PCIE_GEN3_EQ_PHASE_2_3 | + PCIE_GEN3_RXEQ_PH01_EN | + PCIE_GEN3_RXEQ_RGRDLESS_RXTS)); + + ret = dw_pcie_ep_init(ep); + if (ret) + return ret; + + return 0; +} + +static int __init artpec8_add_pcie_port(struct artpec8_pcie *artpec8_ctrl, + struct platform_device *pdev) +{ + struct dw_pcie *pci = artpec8_ctrl->pci; + struct pcie_port *pp = &pci->pp; + struct device *dev = &pdev->dev; + int irq; + int irq_flags; + int ret; + + if (IS_ENABLED(CONFIG_PCI_MSI)) { + irq = platform_get_irq_byname(pdev, "intr"); + if (!irq) + return -ENODEV; + + irq_flags = IRQF_SHARED | IRQF_NO_THREAD; + + ret = devm_request_irq(dev, irq, artpec8_pcie_msi_irq_handler, + irq_flags, "artpec8-pcie", artpec8_ctrl); + if (ret) + return ret; + } + + /* Prevent core from messing with the IRQ, since it's muxed */ + pp->msi_irq = -ENODEV; + + return dw_pcie_host_init(pp); +} + +static const struct dw_pcie_ops artpec8_dw_pcie_ops = { + .read_dbi = artpec8_pcie_read_dbi, + .write_dbi = artpec8_pcie_write_dbi, + .write_dbi2 = artpec8_pcie_write_dbi2, + .start_link = artpec8_pcie_start_link, + .stop_link = artpec8_pcie_stop_link, + .link_up = artpec8_pcie_link_up, +}; + +static int artpec8_pcie_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct artpec8_pcie *artpec8_ctrl; + struct dw_pcie *pci; + const struct artpec8_pcie_pdata *pdata; + enum dw_pcie_device_mode mode; + struct pcie_port *pp; + struct device_node *np = dev->of_node; + int ret; + + artpec8_ctrl = devm_kzalloc(dev, sizeof(*artpec8_ctrl), GFP_KERNEL); + if (!artpec8_ctrl) + return -ENOMEM; + + pci = devm_kzalloc(dev, sizeof(*pci), GFP_KERNEL); + if (!pci) + return -ENOMEM; + + pdata = of_device_get_match_data(dev); + + if (!pdata) + return -ENODEV; + + mode = (enum dw_pcie_device_mode)pdata->mode; + + artpec8_ctrl->pci = pci; + artpec8_ctrl->pdata = pdata; + artpec8_ctrl->mode = mode; + + pci->dev = dev; + pci->ops = pdata->dwc_ops; + pci->dbi_base2 = NULL; + pci->dbi_base = NULL; + pp = &pci->pp; + pp->ops = artpec8_ctrl->pdata->host_ops; + + if (mode == DW_PCIE_RC_TYPE) + artpec8_ctrl->link_id = of_alias_get_id(np, "pcierc"); + else + artpec8_ctrl->link_id = of_alias_get_id(np, "pcieep"); + + ret = artpec8_pcie_get_subsystem_resources(pdev, artpec8_ctrl); + if (ret) + return ret; + + if (pdata->res_ops && pdata->res_ops->get_mem_resources) { + ret = pdata->res_ops->get_mem_resources(pdev, artpec8_ctrl); + if (ret) + return ret; + } + + if (pdata->res_ops && pdata->res_ops->get_clk_resources) { + ret = pdata->res_ops->get_clk_resources(pdev); + if (ret) + return ret; + + ret = pdata->res_ops->init_clk_resources(); + if (ret) + return ret; + } + + platform_set_drvdata(pdev, artpec8_ctrl); + + ret = artpec8_pcie_config_isolation(pci, PCIE_CLEAR_ISOLATION); + if (ret) + return ret; + + ret = artpec8_pcie_config_perstn(pci, PCIE_REG_BIT_HIGH); + if (ret) + return ret; + + artpec8_ctrl->phy = devm_of_phy_get(dev, np, NULL); + if (IS_ERR(artpec8_ctrl->phy)) + return PTR_ERR(artpec8_ctrl->phy); + + phy_init(artpec8_ctrl->phy); + phy_reset(artpec8_ctrl->phy); + + switch (mode) { + case DW_PCIE_RC_TYPE: + writel(DEVICE_TYPE_RC, artpec8_ctrl->elbi_base + + PCIE_ARTPEC8_DEVICE_TYPE); + ret = artpec8_add_pcie_port(artpec8_ctrl, pdev); + if (ret < 0) + goto fail_probe; + break; + case DW_PCIE_EP_TYPE: + writel(DEVICE_TYPE_EP, artpec8_ctrl->elbi_base + + PCIE_ARTPEC8_DEVICE_TYPE); + + ret = artpec8_add_pcie_ep(artpec8_ctrl, pdev); + if (ret < 0) + goto fail_probe; + break; + default: + ret = -EINVAL; + goto fail_probe; + } + + return 0; + +fail_probe: + phy_exit(artpec8_ctrl->phy); + if (pdata->res_ops && pdata->res_ops->deinit_clk_resources) + pdata->res_ops->deinit_clk_resources(); + + return ret; +} + +static int __exit artpec8_pcie_remove(struct platform_device *pdev) +{ + struct artpec8_pcie *artpec8_ctrl = platform_get_drvdata(pdev); + const struct artpec8_pcie_pdata *pdata = artpec8_ctrl->pdata; + + if (pdata->res_ops && pdata->res_ops->deinit_clk_resources) + pdata->res_ops->deinit_clk_resources(); + + return 0; +} + +static const struct artpec8_pcie_pdata artpec8_pcie_rc_pdata = { + .dwc_ops = &artpec8_dw_pcie_ops, + .host_ops = &artpec8_pcie_host_ops, + .res_ops = &artpec8_pcie_rc_res_ops, + .mode = DW_PCIE_RC_TYPE, +}; + +static const struct artpec8_pcie_pdata artpec8_pcie_ep_pdata = { + .dwc_ops = &artpec8_dw_pcie_ops, + .host_ops = &artpec8_pcie_host_ops, + .res_ops = &artpec8_pcie_ep_res_ops, + .mode = DW_PCIE_EP_TYPE, +}; + +static const struct of_device_id artpec8_pcie_of_match[] = { + { + .compatible = "axis,artpec8-pcie", + .data = &artpec8_pcie_rc_pdata, + }, + { + .compatible = "axis,artpec8-pcie-ep", + .data = &artpec8_pcie_ep_pdata, + }, + {}, +}; +MODULE_DEVICE_TABLE(of, artpec8_pcie_of_match); + +static struct platform_driver artpec8_pcie_driver = { + .probe = artpec8_pcie_probe, + .remove = __exit_p(artpec8_pcie_remove), + .driver = { + .name = "artpec8-pcie", + .of_match_table = artpec8_pcie_of_match, + }, +}; + +module_platform_driver(artpec8_pcie_driver); + +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Jaeho Cho <jaeho79.cho@samsung.com>"); -- 2.9.5 ^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [PATCH v3 3/5] PCI: axis: Add ARTPEC-8 PCIe controller driver 2022-06-14 1:30 ` [PATCH v3 3/5] PCI: axis: Add ARTPEC-8 PCIe controller driver Wangseok Lee @ 2022-06-20 8:35 ` Krzysztof Kozlowski 0 siblings, 0 replies; 30+ messages in thread From: Krzysztof Kozlowski @ 2022-06-20 8:35 UTC (permalink / raw) To: wangseok.lee, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 14/06/2022 03:30, Wangseok Lee wrote: > Add support Axis, ARTPEC-8 SoC. > ARTPEC-8 is the SoC platform of Axis Communications. > (...) > + > +enum artpec8_pcie_isolation { > + PCIE_CLEAR_ISOLATION = 0, > + PCIE_SET_ISOLATION = 1 > +}; > + > +enum artpec8_pcie_reg_bit { > + PCIE_REG_BIT_LOW = 0, > + PCIE_REG_BIT_HIGH = 1 > +}; Remove this enum. This is redefinition of true/false or 1/0. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 30+ messages in thread
[parent not found: <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p8>]
* [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p8> @ 2022-06-14 1:27 ` Wangseok Lee 2022-06-16 22:54 ` Krzysztof Kozlowski 2022-06-14 1:34 ` [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver Wangseok Lee 1 sibling, 1 reply; 30+ messages in thread From: Wangseok Lee @ 2022-06-14 1:27 UTC (permalink / raw) To: robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim Add description to support Axis, ARTPEC-8 SoC. ARTPEC-8 is the SoC platform of Axis Communications and PCIe controller is designed based on Design-Ware PCIe controller. Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> --- v2->v3 : - modify version history to fit the linux commit rule - remove 'Device Tree Bindings' on title - remove the interrupt-names, phy-names entries - remove '_clk' suffix - add the compatible entries on required - change node name to soc from artpec8 on examples v1->v2 : -'make dt_binding_check' result improvement -Add the missing property list -Align the indentation of continued lines/entries --- .../bindings/pci/axis,artpec8-pcie-ep.yaml | 109 +++++++++++++++++++ .../devicetree/bindings/pci/axis,artpec8-pcie.yaml | 120 +++++++++++++++++++++ 2 files changed, 229 insertions(+) create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml diff --git a/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml new file mode 100644 index 0000000..d802bba --- /dev/null +++ b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml @@ -0,0 +1,109 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pci/axis,artpec8-pcie-ep.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ARTPEC-8 SoC PCIe Controller + +maintainers: + - Jesper Nilsson <jesper.nilsson@axis.com> + +description: |+ + This PCIe end-point controller is based on the Synopsys DesignWare PCIe IP + and thus inherits all the common properties defined in snps,dw-pcie-ep.yaml. + +allOf: + - $ref: /schemas/pci/snps,dw-pcie-ep.yaml# + +properties: + compatible: + const: axis,artpec8-pcie-ep + + reg: + items: + - description: Data Bus Interface (DBI) registers. + - description: Data Bus Interface (DBI2) registers. + - description: PCIe address space region. + + reg-names: + items: + - const: dbi + - const: dbi2 + - const: addr_space + + interrupts: + maxItems: 1 + + clocks: + items: + - description: PIPE clock, used by the controller to clock the PIPE + - description: PCIe dbi clock, ungated version + - description: PCIe master clock, ungated version + - description: PCIe slave clock, ungated version + + clock-names: + items: + - const: pipe + - const: dbi + - const: mstr + - const: slv + + phys: + maxItems: 1 + + num-lanes: + const: 2 + +required: + - compatible + - reg + - reg-names + - interrupts + - interrupt-names + - clocks + - clock-names + - samsung,fsys-sysreg + - samsung,syscon-phandle + - samsung,syscon-bus-s-fsys + - samsung,syscon-bus-p-fsys + - phys + - num-lanes + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + pcie_ep: pcie-ep@17200000 { + compatible = "axis,artpec8-pcie-ep"; + reg = <0x0 0x17200000 0x0 0x1000>, + <0x0 0x17201000 0x0 0x1000>, + <0x2 0x00000000 0x6 0x00000000>; + reg-names = "dbi", "dbi2", "addr_space"; + #interrupt-cells = <1>; + interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "intr"; + clocks = <&clock_cmu_fsys 39>, + <&clock_cmu_fsys 38>, + <&clock_cmu_fsys 37>, + <&clock_cmu_fsys 36>; + clock-names = "pipe", "dbi", "mstr", "slv"; + samsung,fsys-sysreg = <&syscon_fsys>; + samsung,syscon-phandle = <&pmu_system_controller>; + samsung,syscon-bus-s-fsys = <&syscon_bus_s_fsys>; + samsung,syscon-bus-p-fsys = <&syscon_bus_p_fsys>; + phys = <&pcie_phy>; + phy-names = "pcie_phy"; + num-lanes = <2>; + bus-range = <0x00 0xff>; + num-ib-windows = <16>; + num-ob-windows = <16>; + }; + }; +... diff --git a/Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml new file mode 100644 index 0000000..dbbe1fd --- /dev/null +++ b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml @@ -0,0 +1,120 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pci/axis,artpec8-pcie.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Artpec-8 SoC PCIe Controller + +maintainers: + - Jesper Nilsson <jesper.nilsson@axis.com> + +description: |+ + This PCIe host controller is based on the Synopsys DesignWare PCIe IP + and thus inherits all the common properties defined in snps,dw-pcie.yaml. + +allOf: + - $ref: /schemas/pci/snps,dw-pcie.yaml# + +properties: + compatible: + const: axis,artpec8-pcie + + reg: + items: + - description: Data Bus Interface (DBI) registers. + - description: External Local Bus interface (ELBI) registers. + - description: PCIe configuration space region. + + reg-names: + items: + - const: dbi + - const: elbi + - const: config + + ranges: + maxItems: 2 + + num-lanes: + const: 2 + + interrupts: + maxItems: 1 + + clocks: + items: + - description: PIPE clock, used by the controller to clock the PIPE + - description: PCIe dbi clock, ungated version + - description: PCIe master clock, ungated version + - description: PCIe slave clock, ungated version + + clock-names: + items: + - const: pipe + - const: dbi + - const: mstr + - const: slv + + phys: + maxItems: 1 + +required: + - compatible + - reg + - reg-names + - device_type + - ranges + - num-lanes + - interrupts + - interrupt-names + - clocks + - clock-names + - samsung,fsys-sysreg + - samsung,syscon-phandle + - samsung,syscon-bus-s-fsys + - samsung,syscon-bus-p-fsys + - phys + - phy-names + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + pcie: pcie@17200000 { + compatible = "axis,artpec8-pcie"; + reg = <0x0 0x17200000 0x0 0x1000>, + <0x0 0x16ca0000 0x0 0x2000>, + <0x7 0x0001e000 0x0 0x2000>; + reg-names = "dbi", "elbi", "config"; + #address-cells = <3>; + #size-cells = <2>; + device_type = "pci"; + ranges = </* non-prefetchable memory */ + 0x83000000 0x0 0x0000000 0x2 0x00000000 0x5 0x00000000 + /* downstream I/O */ + 0x81000000 0x0 0x0000000 0x7 0x00000000 0x0 0x00010000>; + num-lanes = <2>; + bus-range = <0x00 0xff>; + interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "intr"; + #interrupt-cells = <1>; + clocks = <&cmu_fsys 39>, + <&cmu_fsys 38>, + <&cmu_fsys 37>, + <&cmu_fsys 36>; + clock-names = "pipe", "dbi", "mstr", "slv"; + samsung,fsys-sysreg = <&syscon_fsys>; + samsung,syscon-phandle = <&pmu_system_controller>; + samsung,syscon-bus-s-fsys = <&syscon_bus_s_fsys>; + samsung,syscon-bus-p-fsys = <&syscon_bus_p_fsys>; + phys = <&pcie_phy>; + phy-names = "pcie_phy"; + }; + }; +... -- 2.9.5 ^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller 2022-06-14 1:27 ` [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller Wangseok Lee @ 2022-06-16 22:54 ` Krzysztof Kozlowski 0 siblings, 0 replies; 30+ messages in thread From: Krzysztof Kozlowski @ 2022-06-16 22:54 UTC (permalink / raw) To: wangseok.lee, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 13/06/2022 18:27, Wangseok Lee wrote: > Add description to support Axis, ARTPEC-8 SoC. > ARTPEC-8 is the SoC platform of Axis Communications > and PCIe controller is designed based on Design-Ware PCIe controller. > > Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> > --- > v2->v3 : > - modify version history to fit the linux commit rule > - remove 'Device Tree Bindings' on title > - remove the interrupt-names, phy-names entries > - remove '_clk' suffix > - add the compatible entries on required > - change node name to soc from artpec8 on examples > > v1->v2 : > -'make dt_binding_check' result improvement > -Add the missing property list > -Align the indentation of continued lines/entries > --- > .../bindings/pci/axis,artpec8-pcie-ep.yaml | 109 +++++++++++++++++++ > .../devicetree/bindings/pci/axis,artpec8-pcie.yaml | 120 +++++++++++++++++++++ > 2 files changed, 229 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml > create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml > > diff --git a/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml > new file mode 100644 > index 0000000..d802bba > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml > @@ -0,0 +1,109 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/axis,artpec8-pcie-ep.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ARTPEC-8 SoC PCIe Controller > + > +maintainers: > + - Jesper Nilsson <jesper.nilsson@axis.com> > + > +description: |+ > + This PCIe end-point controller is based on the Synopsys DesignWare PCIe IP > + and thus inherits all the common properties defined in snps,dw-pcie-ep.yaml. > + > +allOf: > + - $ref: /schemas/pci/snps,dw-pcie-ep.yaml# > + > +properties: > + compatible: > + const: axis,artpec8-pcie-ep > + > + reg: > + items: > + - description: Data Bus Interface (DBI) registers. > + - description: Data Bus Interface (DBI2) registers. > + - description: PCIe address space region. > + > + reg-names: > + items: > + - const: dbi > + - const: dbi2 > + - const: addr_space > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: PIPE clock, used by the controller to clock the PIPE > + - description: PCIe dbi clock, ungated version > + - description: PCIe master clock, ungated version > + - description: PCIe slave clock, ungated version > + > + clock-names: > + items: > + - const: pipe > + - const: dbi > + - const: mstr > + - const: slv > + > + phys: > + maxItems: 1 > + > + num-lanes: > + const: 2 > + > +required: > + - compatible > + - reg > + - reg-names > + - interrupts > + - interrupt-names > + - clocks > + - clock-names > + - samsung,fsys-sysreg > + - samsung,syscon-phandle > + - samsung,syscon-bus-s-fsys > + - samsung,syscon-bus-p-fsys We are making circles... This was before and I commented already it is wrong. You cannot have some unknown/random properties in "required:" without describing them in "properties:". Please list all your properties in "properties:", except the ones coming from snps bindings/schema. > + - phys > + - num-lanes > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + pcie_ep: pcie-ep@17200000 { > + compatible = "axis,artpec8-pcie-ep"; > + reg = <0x0 0x17200000 0x0 0x1000>, > + <0x0 0x17201000 0x0 0x1000>, > + <0x2 0x00000000 0x6 0x00000000>; > + reg-names = "dbi", "dbi2", "addr_space"; > + #interrupt-cells = <1>; > + interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "intr"; > + clocks = <&clock_cmu_fsys 39>, > + <&clock_cmu_fsys 38>, > + <&clock_cmu_fsys 37>, > + <&clock_cmu_fsys 36>; > + clock-names = "pipe", "dbi", "mstr", "slv"; > + samsung,fsys-sysreg = <&syscon_fsys>; > + samsung,syscon-phandle = <&pmu_system_controller>; > + samsung,syscon-bus-s-fsys = <&syscon_bus_s_fsys>; > + samsung,syscon-bus-p-fsys = <&syscon_bus_p_fsys>; > + phys = <&pcie_phy>; > + phy-names = "pcie_phy"; > + num-lanes = <2>; > + bus-range = <0x00 0xff>; > + num-ib-windows = <16>; > + num-ob-windows = <16>; > + }; > + }; > +... > diff --git a/Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml > new file mode 100644 > index 0000000..dbbe1fd > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml > @@ -0,0 +1,120 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/axis,artpec8-pcie.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Artpec-8 SoC PCIe Controller > + > +maintainers: > + - Jesper Nilsson <jesper.nilsson@axis.com> > + > +description: |+ > + This PCIe host controller is based on the Synopsys DesignWare PCIe IP > + and thus inherits all the common properties defined in snps,dw-pcie.yaml. > + > +allOf: > + - $ref: /schemas/pci/snps,dw-pcie.yaml# > + > +properties: > + compatible: > + const: axis,artpec8-pcie > + > + reg: > + items: > + - description: Data Bus Interface (DBI) registers. > + - description: External Local Bus interface (ELBI) registers. > + - description: PCIe configuration space region. > + > + reg-names: > + items: > + - const: dbi > + - const: elbi > + - const: config > + > + ranges: > + maxItems: 2 > + > + num-lanes: > + const: 2 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: PIPE clock, used by the controller to clock the PIPE > + - description: PCIe dbi clock, ungated version > + - description: PCIe master clock, ungated version > + - description: PCIe slave clock, ungated version > + > + clock-names: > + items: > + - const: pipe > + - const: dbi > + - const: mstr > + - const: slv > + > + phys: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - reg-names > + - device_type > + - ranges > + - num-lanes > + - interrupts > + - interrupt-names > + - clocks > + - clock-names > + - samsung,fsys-sysreg > + - samsung,syscon-phandle > + - samsung,syscon-bus-s-fsys > + - samsung,syscon-bus-p-fsys Same problem. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p8> 2022-06-14 1:27 ` [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller Wangseok Lee @ 2022-06-14 1:34 ` Wangseok Lee 2022-07-05 6:21 ` Vinod Koul 1 sibling, 1 reply; 30+ messages in thread From: Wangseok Lee @ 2022-06-14 1:34 UTC (permalink / raw) To: robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim Add support Axis, ARTPEC-8 SoC. ARTPEC-8 is the SoC platform of Axis Communications. This is based on arm64 and support GEN4 & 2lane. This driver provides PHY interface for ARTPEC-8 SoC PCIe controller, based on Samsung PCIe PHY IP. Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> Signed-off-by: Jaeho Cho <jaeho79.cho@samsung.com> --- v2->v3 : -remove unnecessary indentation -redefine local struct to statis const -add static const to struct that requires static const definition -remove wrappers on writel and readl v1->v2 : -change folder name of phy driver to axis from artpec --- drivers/phy/Kconfig | 1 + drivers/phy/Makefile | 1 + drivers/phy/axis/Kconfig | 9 + drivers/phy/axis/Makefile | 2 + drivers/phy/axis/phy-artpec8-pcie.c | 776 ++++++++++++++++++++++++++++++++++++ 5 files changed, 789 insertions(+) create mode 100644 drivers/phy/axis/Kconfig create mode 100644 drivers/phy/axis/Makefile create mode 100644 drivers/phy/axis/phy-artpec8-pcie.c diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 300b0f2..92b8232 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -73,6 +73,7 @@ config PHY_CAN_TRANSCEIVER source "drivers/phy/allwinner/Kconfig" source "drivers/phy/amlogic/Kconfig" +source "drivers/phy/axis/Kconfig" source "drivers/phy/broadcom/Kconfig" source "drivers/phy/cadence/Kconfig" source "drivers/phy/freescale/Kconfig" diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile index 01e9eff..808c055e 100644 --- a/drivers/phy/Makefile +++ b/drivers/phy/Makefile @@ -12,6 +12,7 @@ obj-$(CONFIG_PHY_PISTACHIO_USB) += phy-pistachio-usb.o obj-$(CONFIG_USB_LGM_PHY) += phy-lgm-usb.o obj-y += allwinner/ \ amlogic/ \ + axis/ \ broadcom/ \ cadence/ \ freescale/ \ diff --git a/drivers/phy/axis/Kconfig b/drivers/phy/axis/Kconfig new file mode 100644 index 0000000..7198b93 --- /dev/null +++ b/drivers/phy/axis/Kconfig @@ -0,0 +1,9 @@ +config PHY_ARTPEC8_PCIE + bool "ARTPEC-8 PCIe PHY driver" + depends on OF && (ARCH_ARTPEC8 || COMPILE_TEST) + select GENERIC_PHY + help + Enable PCIe PHY support for ARTPEC-8 SoC. + This driver provides PHY interface for ARTPEC-8 SoC + PCIe controller. + This is based on Samsung PCIe PHY IP. diff --git a/drivers/phy/axis/Makefile b/drivers/phy/axis/Makefile new file mode 100644 index 0000000..45d853c --- /dev/null +++ b/drivers/phy/axis/Makefile @@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2.0 +obj-$(CONFIG_PHY_ARTPEC8_PCIE) += phy-artpec8-pcie.o diff --git a/drivers/phy/axis/phy-artpec8-pcie.c b/drivers/phy/axis/phy-artpec8-pcie.c new file mode 100644 index 0000000..d21867b --- /dev/null +++ b/drivers/phy/axis/phy-artpec8-pcie.c @@ -0,0 +1,776 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * PHY provider for ARTPEC-8 PCIe controller + * + * Copyright (C) 2019 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * Author: Jaeho Cho <jaeho79.cho@samsung.com> + */ + +#include <linux/clk.h> +#include <linux/io.h> +#include <linux/init.h> +#include <linux/mfd/syscon.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/of_address.h> +#include <linux/of_platform.h> +#include <linux/platform_device.h> +#include <linux/phy/phy.h> +#include <linux/regmap.h> +#include <linux/debugfs.h> + +/* ARTPEC-8 PCIe PHY registers */ +/* CMN registers */ +#define PCIE_PHY_CMN_REG004 0x10 +#define PCIE_PHY_CMN_REG00B 0x2C +#define PCIE_PHY_CMN_REG016 0x58 +#define PCIE_PHY_CMN_REG01C 0x70 +#define PCIE_PHY_CMN_REG021 0x84 +#define PCIE_PHY_CMN_REG024 0x90 +#define PCIE_PHY_CMN_REG025 0x94 +#define PCIE_PHY_CMN_REG0E6 0x398 +#define PCIE_PHY_CMN_REG0E7 0x39C +#define PCIE_PHY_CMN_REG0E8 0x3A0 +#define PCIE_PHY_CMN_REG0E9 0x3A4 +#define PCIE_PHY_CMN_REG0EA 0x3A8 +#define PCIE_PHY_CMN_REG0EB 0x3AC +#define PCIE_PHY_CMN_REG0EC 0x3B0 +#define PCIE_PHY_CMN_REG0EE 0x3B8 +#define PCIE_PHY_CMN_REG0EF 0x3BC +#define PCIE_PHY_CMN_REG0F1 0x3C4 +#define PCIE_PHY_CMN_REG0F3 0x3CC +#define PCIE_PHY_CMN_REG0F4 0x3D0 + +#define PCIE_PHY_CMN_REG101 0x404 +#define OV_I_CMN_RSTN BIT(4) +#define OV_I_INIT_RSTN BIT(6) + +#define PCIE_PHY_CMN_REG131 0x4C4 +#define PCIE_PHY_CMN_REG17B 0x5EC +#define PCIE_PHY_CMN_REG17D 0x5F4 +#define PCIE_PHY_CMN_REG190 0x640 +#define PCIE_PHY_CMN_REG191 0x644 +#define PCIE_PHY_CMN_REG192 0x648 +#define PCIE_PHY_CMN_REG1C7 0x71C +#define PCIE_PHY_CMN_REG1DF 0x77C +#define PCIE_PHY_CMN_REG1E0 0x780 + +#define PCIE_PHY_CMN_REG0B1 0x2C4 +#define ANA_ROPLL_REF_DIG_CLK_SEL BIT(2) + +/* External clock */ +#define PCIE_PHY_CMN_REG14D 0x534 +#define PCIE_AUX_RX_MODE_EXTEND BIT(7) + +#define PCIE_PHY_CMN_REG0D9 0x364 +#define ANA_AUX_EXT_REF_CLK_SEL BIT(4) + +#define PCIE_PHY_CMN_REG10F 0x43C +#define AUX_PLL_EN_EXTEND BIT(4) + +#define PCIE_PHY_CMN_REG11E 0x478 +#define AUX2_PLL_EN_EXTEND BIT(3) + +#define PCIE_PHY_CMN_REG0D4 0x350 +#define OV_S_ANA_AUX_EN BIT(3) +#define OV_I_ANA_AUX_EN BIT(2) + +/* LANE registers */ +#define PCIE_PHY_TRSV_REG22D 0x8B4 +#define PCIE_PHY_TRSV_REG23E 0x8F8 +#define PCIE_PHY_TRSV_REG2A5 0xA94 +#define PCIE_PHY_TRSV_REG3E3 0xF8C +#define PCIE_PHY_TRSV_REG3ED 0xFB4 +#define PCIE_PHY_TRSV_REG20B 0x82C +#define PCIE_PHY_TRSV_REG20C 0x830 +#define PCIE_PHY_TRSV_REG234 0x8D0 +#define PCIE_PHY_TRSV_REG235 0x8D4 +#define PCIE_PHY_TRSV_REG237 0x8DC +#define PCIE_PHY_TRSV_REG239 0x8E4 +#define PCIE_PHY_TRSV_REG23A 0x8E8 +#define PCIE_PHY_TRSV_REG23B 0x8EC +#define PCIE_PHY_TRSV_REG24B 0x92C +#define PCIE_PHY_TRSV_REG25D 0x974 +#define PCIE_PHY_TRSV_REG262 0x988 +#define PCIE_PHY_TRSV_REG271 0x9C4 +#define PCIE_PHY_TRSV_REG272 0x9C8 +#define PCIE_PHY_TRSV_REG27C 0x9F0 +#define PCIE_PHY_TRSV_REG27D 0x9F4 +#define PCIE_PHY_TRSV_REG27E 0x9F8 +#define PCIE_PHY_TRSV_REG284 0xA10 +#define PCIE_PHY_TRSV_REG289 0xA24 +#define PCIE_PHY_TRSV_REG28A 0xA28 +#define PCIE_PHY_TRSV_REG28B 0xA2C +#define PCIE_PHY_TRSV_REG28C 0xA30 +#define PCIE_PHY_TRSV_REG28E 0xA38 +#define PCIE_PHY_TRSV_REG28F 0xA3C +#define PCIE_PHY_TRSV_REG290 0xA40 +#define PCIE_PHY_TRSV_REG291 0xA44 +#define PCIE_PHY_TRSV_REG292 0xA48 +#define PCIE_PHY_TRSV_REG294 0xA50 +#define PCIE_PHY_TRSV_REG295 0xA54 +#define PCIE_PHY_TRSV_REG296 0xA58 +#define PCIE_PHY_TRSV_REG297 0xA5C +#define PCIE_PHY_TRSV_REG298 0xA60 +#define PCIE_PHY_TRSV_REG29B 0xA6C +#define PCIE_PHY_TRSV_REG29C 0xA70 +#define PCIE_PHY_TRSV_REG29D 0xA74 +#define PCIE_PHY_TRSV_REG29E 0xA78 +#define PCIE_PHY_TRSV_REG2AA 0xAA8 +#define PCIE_PHY_TRSV_REG2AE 0xAB8 +#define PCIE_PHY_TRSV_REG2C2 0xB08 +#define PCIE_PHY_TRSV_REG2C6 0xB18 +#define PCIE_PHY_TRSV_REG2C7 0xB1C +#define PCIE_PHY_TRSV_REG2CB 0xB2C +#define PCIE_PHY_TRSV_REG2CC 0xB30 +#define PCIE_PHY_TRSV_REG2CD 0xB34 +#define PCIE_PHY_TRSV_REG2CE 0xB38 +#define PCIE_PHY_TRSV_REG2D0 0xB40 +#define PCIE_PHY_TRSV_REG2CF 0xB3C +#define PCIE_PHY_TRSV_REG2E0 0xB80 +#define PCIE_PHY_TRSV_REG2E9 0xBA4 +#define PCIE_PHY_TRSV_REG2EA 0xBA8 +#define PCIE_PHY_TRSV_REG2EB 0xBAC +#define PCIE_PHY_TRSV_REG315 0xC54 +#define PCIE_PHY_TRSV_REG317 0xC5C +#define PCIE_PHY_TRSV_REG319 0xC64 +#define PCIE_PHY_TRSV_REG364 0xD90 +#define PCIE_PHY_TRSV_REG36C 0xDB0 +#define PCIE_PHY_TRSV_REG36D 0xDB4 +#define PCIE_PHY_TRSV_REG37E 0xDF8 +#define PCIE_PHY_TRSV_REG37F 0xDFC +#define PCIE_PHY_TRSV_REG38F 0xE3C +#define PCIE_PHY_TRSV_REG391 0xE44 +#define PCIE_PHY_TRSV_REG39C 0xE70 +#define PCIE_PHY_TRSV_REG3A8 0xEA0 +#define PCIE_PHY_TRSV_REG3E0 0xF80 +#define PCIE_PHY_TRSV_REG3E1 0xF84 +#define PCIE_PHY_TRSV_REG3E7 0xF9C +#define PCIE_PHY_TRSV_REG3E9 0xFA4 +#define PCIE_PHY_TRSV_REG3EA 0xFA8 +#define PCIE_PHY_TRSV_REG3EE 0xFB8 +#define PCIE_PHY_TRSV_REG3EF 0xFBC +#define PCIE_PHY_TRSV_REG3F0 0xFC0 + +#define PCIE_PHY_TRSV_REG2C0 0xB00 +#define LN_EQ_CTRL_RX_DATA_HOLD BIT(5) + +/* RX Preset registers */ +#define PCIE_PHY_CMN_REG17E 0x5F8 +#define PCIE_PHY_CMN_REG180 0x600 +#define PCIE_PHY_CMN_REG181 0x604 +#define PCIE_PHY_CMN_REG182 0x608 +#define PCIE_PHY_CMN_REG183 0x60C +#define PCIE_PHY_CMN_REG184 0x610 +#define PCIE_PHY_CMN_REG185 0x614 +#define PCIE_PHY_CMN_REG186 0x618 +#define PCIE_PHY_CMN_REG187 0x61C + + +/* ARTPEC-8 PCIe PCS registers */ +#define PCIE_PCS_OUT_VEC_4 0x154 +#define B1_DYNAMIC BIT(3) + +/* ARTPEC-8 SYS REG registers */ +#define FSYS_PCIE_CON 0x424 +#define PCIE_PHY_LCPLL_REFCLK_SEL 0x3 +#define PCIE_PHY_ROPLL_REFCLK_SEL (0x3UL << 2) +#define ROPLL_REFCLK_NOT_AVAILABLE (0x2UL << 2) +#define PCIE_PHY_LN0_REFCLK_PAD_EN BIT(10) +#define PCIE_PHY_LN1_REFCLK_PAD_EN BIT(11) +#define PCIE_PHY_PWR_OFF BIT(7) + +/* ARTPEC-8 Sub Controller registers */ +#define SFR_INIT_RSTN 0x1404 +#define SFR_CMN_RSTN 0x1408 + +#define PCIE_PHY_LN0_REG_START 0x800 +#define PCIE_PHY_LN0_REG_END 0xFCC +#define OFFSET_PER_LANE 0x800 + +enum artpec8_pcie_phy_num_lanes { + LANE0 = 0, + LANE1, + LANE_MAX +}; + +struct artpec8_pcie_phy_data { + const struct phy_ops *ops; +}; + +struct artpec8_pcie_phy { + const struct artpec8_pcie_phy_data *drv_data; + void __iomem *phy_base; + void __iomem *pcs_base; + void __iomem *elbi_base; + struct clk *soc_pll_clk; + struct regmap *sysreg; + u32 lcpll_ref_clk; + const char *mode; + u32 num_lanes; +}; + +enum artpec8_pcie_ref_clk { + REF_CLK_FROM_XO = 0, + REF_CLK_FROM_IO, + REF_CLK_RESERVED, + REF_CLK_FROM_SOC_PLL, + REF_CLK_MAX +}; + +struct artpec8_pcie_phy_tune_reg { + u32 offset; + u32 val; +}; + +/* ARTPEC-8 PCIe Gen4 x2 PHY CMN register settings */ +static const struct artpec8_pcie_phy_tune_reg cmn_regs[] = { + {PCIE_PHY_CMN_REG004, 0x65}, + {PCIE_PHY_CMN_REG00B, 0x18}, + {PCIE_PHY_CMN_REG016, 0x0E}, + {PCIE_PHY_CMN_REG01C, 0x4F}, + {PCIE_PHY_CMN_REG021, 0x01}, + {PCIE_PHY_CMN_REG024, 0x58}, + {PCIE_PHY_CMN_REG025, 0x98}, + {PCIE_PHY_CMN_REG0E6, 0x00}, + {PCIE_PHY_CMN_REG0E7, 0x00}, + {PCIE_PHY_CMN_REG0E8, 0x3F}, + {PCIE_PHY_CMN_REG0E9, 0x3F}, + {PCIE_PHY_CMN_REG0EA, 0xFF}, + {PCIE_PHY_CMN_REG0EB, 0xFF}, + {PCIE_PHY_CMN_REG0EC, 0x42}, + {PCIE_PHY_CMN_REG0EE, 0x3F}, + {PCIE_PHY_CMN_REG0EF, 0x7F}, + {PCIE_PHY_CMN_REG0F1, 0x02}, + {PCIE_PHY_CMN_REG0F3, 0xFF}, + {PCIE_PHY_CMN_REG0F4, 0xFF}, + {PCIE_PHY_CMN_REG131, 0x01}, + {PCIE_PHY_CMN_REG17B, 0xC0}, + {PCIE_PHY_CMN_REG17D, 0xAF}, + {PCIE_PHY_CMN_REG190, 0x27}, + {PCIE_PHY_CMN_REG191, 0x0F}, + {PCIE_PHY_CMN_REG192, 0x3F}, + {PCIE_PHY_CMN_REG1C7, 0x05}, + {PCIE_PHY_CMN_REG1DF, 0x28}, + {PCIE_PHY_CMN_REG1E0, 0x28}, +}; + +/* ARTPEC-8 PCIe Gen4 x2 PHY lane register settings */ +static const struct artpec8_pcie_phy_tune_reg lane_regs[] = { + {PCIE_PHY_TRSV_REG22D, 0x00}, + {PCIE_PHY_TRSV_REG23E, 0x00}, + {PCIE_PHY_TRSV_REG2A5, 0x73}, + {PCIE_PHY_TRSV_REG3E3, 0x7B}, + {PCIE_PHY_TRSV_REG3ED, 0x4B}, + {PCIE_PHY_TRSV_REG20B, 0x02}, + {PCIE_PHY_TRSV_REG20C, 0xEA}, + {PCIE_PHY_TRSV_REG234, 0x7A}, + {PCIE_PHY_TRSV_REG235, 0x1C}, + {PCIE_PHY_TRSV_REG237, 0x10}, + {PCIE_PHY_TRSV_REG239, 0x68}, + {PCIE_PHY_TRSV_REG23A, 0xC0}, + {PCIE_PHY_TRSV_REG23B, 0x0B}, + {PCIE_PHY_TRSV_REG24B, 0x00}, + {PCIE_PHY_TRSV_REG25D, 0x07}, + {PCIE_PHY_TRSV_REG262, 0x07}, + {PCIE_PHY_TRSV_REG271, 0x23}, + {PCIE_PHY_TRSV_REG272, 0x5E}, + {PCIE_PHY_TRSV_REG27C, 0x8C}, + {PCIE_PHY_TRSV_REG27D, 0x5B}, + {PCIE_PHY_TRSV_REG27E, 0x2C}, + {PCIE_PHY_TRSV_REG284, 0x33}, + {PCIE_PHY_TRSV_REG289, 0xD4}, + {PCIE_PHY_TRSV_REG28A, 0xCC}, + {PCIE_PHY_TRSV_REG28B, 0xD9}, + {PCIE_PHY_TRSV_REG28C, 0xDC}, + {PCIE_PHY_TRSV_REG28E, 0xC6}, + {PCIE_PHY_TRSV_REG28F, 0x90}, + {PCIE_PHY_TRSV_REG290, 0x4D}, + {PCIE_PHY_TRSV_REG291, 0x19}, + {PCIE_PHY_TRSV_REG292, 0x1C}, + {PCIE_PHY_TRSV_REG294, 0x05}, + {PCIE_PHY_TRSV_REG295, 0x10}, + {PCIE_PHY_TRSV_REG296, 0x0C}, + {PCIE_PHY_TRSV_REG297, 0x19}, + {PCIE_PHY_TRSV_REG298, 0x04}, + {PCIE_PHY_TRSV_REG29B, 0x03}, + {PCIE_PHY_TRSV_REG29C, 0x1B}, + {PCIE_PHY_TRSV_REG29D, 0x1B}, + {PCIE_PHY_TRSV_REG29E, 0x1F}, + {PCIE_PHY_TRSV_REG2AA, 0x00}, + {PCIE_PHY_TRSV_REG2AE, 0x1F}, + {PCIE_PHY_TRSV_REG2C2, 0x25}, + {PCIE_PHY_TRSV_REG2C6, 0x10}, + {PCIE_PHY_TRSV_REG2C7, 0x06}, + {PCIE_PHY_TRSV_REG2CB, 0x10}, + {PCIE_PHY_TRSV_REG2CC, 0x06}, + {PCIE_PHY_TRSV_REG2CD, 0x20}, + {PCIE_PHY_TRSV_REG2CE, 0x27}, + {PCIE_PHY_TRSV_REG2D0, 0x10}, + {PCIE_PHY_TRSV_REG2CF, 0x0A}, + {PCIE_PHY_TRSV_REG2E0, 0x01}, + {PCIE_PHY_TRSV_REG2E9, 0x11}, + {PCIE_PHY_TRSV_REG2EA, 0x05}, + {PCIE_PHY_TRSV_REG2EB, 0x4C}, + {PCIE_PHY_TRSV_REG315, 0x18}, + {PCIE_PHY_TRSV_REG317, 0x86}, + {PCIE_PHY_TRSV_REG319, 0x8E}, + {PCIE_PHY_TRSV_REG364, 0x00}, + {PCIE_PHY_TRSV_REG36C, 0x03}, + {PCIE_PHY_TRSV_REG36D, 0x04}, + {PCIE_PHY_TRSV_REG37E, 0x06}, + {PCIE_PHY_TRSV_REG37F, 0x04}, + {PCIE_PHY_TRSV_REG38F, 0x40}, + {PCIE_PHY_TRSV_REG391, 0x8B}, + {PCIE_PHY_TRSV_REG39C, 0xFF}, + {PCIE_PHY_TRSV_REG3A8, 0x02}, + {PCIE_PHY_TRSV_REG3E0, 0x93}, + {PCIE_PHY_TRSV_REG3E1, 0x79}, + {PCIE_PHY_TRSV_REG3E7, 0xF5}, + {PCIE_PHY_TRSV_REG3E9, 0x75}, + {PCIE_PHY_TRSV_REG3EA, 0x0D}, + {PCIE_PHY_TRSV_REG3EE, 0xE2}, + {PCIE_PHY_TRSV_REG3EF, 0x6F}, + {PCIE_PHY_TRSV_REG3F0, 0x3D} +}; + +static const struct artpec8_pcie_phy_tune_reg rx_preset_regs[] = { + /* 0 */ + {PCIE_PHY_CMN_REG17E, 0x00}, + {PCIE_PHY_CMN_REG180, 0x23}, + {PCIE_PHY_CMN_REG181, 0x44}, + {PCIE_PHY_CMN_REG182, 0x61}, + {PCIE_PHY_CMN_REG183, 0x55}, + {PCIE_PHY_CMN_REG184, 0x14}, + {PCIE_PHY_CMN_REG185, 0x23}, + {PCIE_PHY_CMN_REG186, 0x1A}, + {PCIE_PHY_CMN_REG187, 0x04}, + {PCIE_PHY_CMN_REG17E, 0x04}, + {PCIE_PHY_CMN_REG17E, 0x00}, + /* 1 */ + {PCIE_PHY_CMN_REG17E, 0x08}, + {PCIE_PHY_CMN_REG181, 0x42}, + {PCIE_PHY_CMN_REG17E, 0x0C}, + {PCIE_PHY_CMN_REG17E, 0x08}, + /* 2 */ + {PCIE_PHY_CMN_REG17E, 0x10}, + {PCIE_PHY_CMN_REG181, 0x40}, + {PCIE_PHY_CMN_REG17E, 0x14}, + {PCIE_PHY_CMN_REG17E, 0x10}, + /* 3 */ + {PCIE_PHY_CMN_REG17E, 0x18}, + {PCIE_PHY_CMN_REG181, 0x45}, + {PCIE_PHY_CMN_REG17E, 0x1C}, + {PCIE_PHY_CMN_REG17E, 0x18}, + /* 4 */ + {PCIE_PHY_CMN_REG17E, 0x20}, + {PCIE_PHY_CMN_REG181, 0x46}, + {PCIE_PHY_CMN_REG17E, 0x24}, + {PCIE_PHY_CMN_REG17E, 0x20}, + /* 5 */ + {PCIE_PHY_CMN_REG17E, 0x28}, + {PCIE_PHY_CMN_REG181, 0x48}, + {PCIE_PHY_CMN_REG17E, 0x2C}, + {PCIE_PHY_CMN_REG17E, 0x28}, + /* 6 */ + {PCIE_PHY_CMN_REG17E, 0x30}, + {PCIE_PHY_CMN_REG181, 0x4A}, + {PCIE_PHY_CMN_REG17E, 0x34}, + {PCIE_PHY_CMN_REG17E, 0x30}, + /* 7 */ + {PCIE_PHY_CMN_REG17E, 0x38}, + {PCIE_PHY_CMN_REG181, 0x4C}, + {PCIE_PHY_CMN_REG17E, 0x3C}, + {PCIE_PHY_CMN_REG17E, 0x38}, + /* 8 */ + {PCIE_PHY_CMN_REG17E, 0x40}, + {PCIE_PHY_CMN_REG180, 0x20}, + {PCIE_PHY_CMN_REG181, 0x20}, + {PCIE_PHY_CMN_REG182, 0x01}, + {PCIE_PHY_CMN_REG17E, 0x44}, + {PCIE_PHY_CMN_REG17E, 0x40}, + /* 9 */ + {PCIE_PHY_CMN_REG17E, 0x48}, + {PCIE_PHY_CMN_REG180, 0x20}, + {PCIE_PHY_CMN_REG181, 0x21}, + {PCIE_PHY_CMN_REG182, 0x01}, + {PCIE_PHY_CMN_REG17E, 0x4C}, + {PCIE_PHY_CMN_REG17E, 0x48}, + /* 10 */ + {PCIE_PHY_CMN_REG17E, 0x50}, + {PCIE_PHY_CMN_REG180, 0x24}, + {PCIE_PHY_CMN_REG181, 0x80}, + {PCIE_PHY_CMN_REG182, 0x41}, + {PCIE_PHY_CMN_REG183, 0xAF}, + {PCIE_PHY_CMN_REG184, 0x26}, + {PCIE_PHY_CMN_REG185, 0x34}, + {PCIE_PHY_CMN_REG186, 0x24}, + {PCIE_PHY_CMN_REG187, 0x06}, + {PCIE_PHY_CMN_REG17E, 0x54}, + {PCIE_PHY_CMN_REG17E, 0x50}, + /* 11 */ + {PCIE_PHY_CMN_REG17E, 0x58}, + {PCIE_PHY_CMN_REG181, 0x81}, + {PCIE_PHY_CMN_REG17E, 0x5C}, + {PCIE_PHY_CMN_REG17E, 0x58}, + /* 12 */ + {PCIE_PHY_CMN_REG17E, 0x60}, + {PCIE_PHY_CMN_REG181, 0x82}, + {PCIE_PHY_CMN_REG17E, 0x64}, + {PCIE_PHY_CMN_REG17E, 0x60}, + /* 13 */ + {PCIE_PHY_CMN_REG17E, 0x68}, + {PCIE_PHY_CMN_REG181, 0x83}, + {PCIE_PHY_CMN_REG17E, 0x6C}, + {PCIE_PHY_CMN_REG17E, 0x68}, + /* 14 */ + {PCIE_PHY_CMN_REG17E, 0x70}, + {PCIE_PHY_CMN_REG181, 0x84}, + {PCIE_PHY_CMN_REG17E, 0x74}, + {PCIE_PHY_CMN_REG17E, 0x70}, + /* 15 */ + {PCIE_PHY_CMN_REG17E, 0x78}, + {PCIE_PHY_CMN_REG180, 0x24}, + {PCIE_PHY_CMN_REG181, 0x85}, + {PCIE_PHY_CMN_REG182, 0x80}, + {PCIE_PHY_CMN_REG183, 0x7F}, + {PCIE_PHY_CMN_REG184, 0x2D}, + {PCIE_PHY_CMN_REG185, 0x34}, + {PCIE_PHY_CMN_REG186, 0x24}, + {PCIE_PHY_CMN_REG187, 0x05}, + {PCIE_PHY_CMN_REG17E, 0x7C}, + {PCIE_PHY_CMN_REG17E, 0x78}, + /* 16 */ + {PCIE_PHY_CMN_REG17E, 0x80}, + {PCIE_PHY_CMN_REG181, 0x86}, + {PCIE_PHY_CMN_REG17E, 0x84}, + {PCIE_PHY_CMN_REG17E, 0x80}, + /* 17 */ + {PCIE_PHY_CMN_REG17E, 0x88}, + {PCIE_PHY_CMN_REG181, 0x87}, + {PCIE_PHY_CMN_REG17E, 0x8C}, + {PCIE_PHY_CMN_REG17E, 0x88}, + /* 18 */ + {PCIE_PHY_CMN_REG17E, 0x90}, + {PCIE_PHY_CMN_REG181, 0x88}, + {PCIE_PHY_CMN_REG17E, 0x94}, + {PCIE_PHY_CMN_REG17E, 0x90}, + /* 19 */ + {PCIE_PHY_CMN_REG17E, 0x98}, + {PCIE_PHY_CMN_REG181, 0x89}, + {PCIE_PHY_CMN_REG17E, 0x9C}, + {PCIE_PHY_CMN_REG17E, 0x98}, +}; + +static void artpec8_pcie_phy_reg_update(void __iomem *base, u32 mask, + u32 update, u32 reg) +{ + u32 val; + + val = readl(base + reg); + val &= ~(mask); + val |= update; + writel(val, base + reg); +}; + +static void artpec8_pcie_enable_ref_clk_from_xo(struct artpec8_pcie_phy + *pciephy) +{ + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, + PCIE_PHY_LCPLL_REFCLK_SEL, + REF_CLK_FROM_XO); + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, + PCIE_PHY_ROPLL_REFCLK_SEL, + ROPLL_REFCLK_NOT_AVAILABLE); +}; + +static void artpec8_pcie_enable_ref_clk_from_io(struct artpec8_pcie_phy + *pciephy) +{ + artpec8_pcie_phy_reg_update(pciephy->phy_base, + PCIE_AUX_RX_MODE_EXTEND, 0, + PCIE_PHY_CMN_REG14D); + artpec8_pcie_phy_reg_update(pciephy->phy_base, + ANA_AUX_EXT_REF_CLK_SEL, 0, + PCIE_PHY_CMN_REG0D9); + artpec8_pcie_phy_reg_update(pciephy->phy_base, + AUX_PLL_EN_EXTEND, 0, + PCIE_PHY_CMN_REG10F); + artpec8_pcie_phy_reg_update(pciephy->phy_base, + AUX2_PLL_EN_EXTEND, 0, + PCIE_PHY_CMN_REG11E); + artpec8_pcie_phy_reg_update(pciephy->phy_base, + OV_S_ANA_AUX_EN, OV_S_ANA_AUX_EN, + PCIE_PHY_CMN_REG0D4); + artpec8_pcie_phy_reg_update(pciephy->phy_base, + OV_I_ANA_AUX_EN, OV_I_ANA_AUX_EN, + PCIE_PHY_CMN_REG0D4); + + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, + PCIE_PHY_LCPLL_REFCLK_SEL, + REF_CLK_FROM_IO); + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, + PCIE_PHY_ROPLL_REFCLK_SEL, + ROPLL_REFCLK_NOT_AVAILABLE); + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, + PCIE_PHY_LN0_REFCLK_PAD_EN, + PCIE_PHY_LN0_REFCLK_PAD_EN); + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, + PCIE_PHY_LN1_REFCLK_PAD_EN, + PCIE_PHY_LN1_REFCLK_PAD_EN); +} + +static void artpec8_pcie_enable_ref_clk_from_soc_pll(struct artpec8_pcie_phy + *pciephy) +{ + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, + PCIE_PHY_LCPLL_REFCLK_SEL, + REF_CLK_FROM_SOC_PLL); + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, + PCIE_PHY_ROPLL_REFCLK_SEL, + ROPLL_REFCLK_NOT_AVAILABLE); +} + +static void artpec8_pcie_lane_control(struct phy *phy, u32 lane0_reg, u32 mask, + u32 val) +{ + struct artpec8_pcie_phy *pciephy = phy_get_drvdata(phy); + u32 lanex_reg = lane0_reg; + int i; + + if (lane0_reg < PCIE_PHY_LN0_REG_START || + lane0_reg > PCIE_PHY_LN0_REG_END) { + return; + } + + for (i = 0; i < pciephy->num_lanes; i++) { + lanex_reg += OFFSET_PER_LANE * i; + artpec8_pcie_phy_reg_update(pciephy->phy_base, mask, val, + lanex_reg); + } +} + +static void artpec8_pcie_phy_tune(struct artpec8_pcie_phy *pciephy) +{ + int i, count; + + /* init cmn registers */ + count = ARRAY_SIZE(cmn_regs); + for (i = 0; i < count; i++) + writel(cmn_regs[i].val, pciephy->phy_base + cmn_regs[i].offset); + + /* init lane registers */ + count = ARRAY_SIZE(lane_regs); + for (i = 0; i < count; i++) { + writel(lane_regs[i].val, pciephy->phy_base + lane_regs[i].offset); + writel(lane_regs[i].val, pciephy->phy_base + lane_regs[i].offset + + OFFSET_PER_LANE); + } + + /* rx preset registers */ + count = ARRAY_SIZE(rx_preset_regs); + for (i = 0; i < count; i++) + writel(rx_preset_regs[i].val, pciephy->phy_base + rx_preset_regs[i].offset); +} + +static int artpec8_pcie_phy_init(struct phy *phy) +{ + struct artpec8_pcie_phy *pciephy = phy_get_drvdata(phy); + + /* reset init_rstn and cmn_rstn */ + artpec8_pcie_phy_reg_update(pciephy->phy_base, + OV_I_CMN_RSTN | OV_I_INIT_RSTN, 0, PCIE_PHY_CMN_REG101); + + /* reference clock selection */ + switch (pciephy->lcpll_ref_clk) { + case REF_CLK_FROM_XO: + artpec8_pcie_enable_ref_clk_from_xo(pciephy); + break; + case REF_CLK_FROM_IO: + artpec8_pcie_enable_ref_clk_from_io(pciephy); + break; + case REF_CLK_FROM_SOC_PLL: + artpec8_pcie_enable_ref_clk_from_soc_pll(pciephy); + break; + default: + break; + } + + /* release i_init_rstn */ + artpec8_pcie_phy_reg_update(pciephy->phy_base, OV_I_INIT_RSTN, + OV_I_INIT_RSTN, PCIE_PHY_CMN_REG101); + + /* phy initial settings */ + artpec8_pcie_phy_tune(pciephy); + + /* pll_en should be set to off when PM_STATE is P1.CPM */ + if (!strncmp(pciephy->mode, "pcie_ep", strlen("pcie_ep"))) { + artpec8_pcie_phy_reg_update(pciephy->pcs_base, B1_DYNAMIC, + B1_DYNAMIC, PCIE_PCS_OUT_VEC_4); + } + + /* disable lane eq ctrl rx data hold */ + artpec8_pcie_lane_control(phy, PCIE_PHY_TRSV_REG2C0, + LN_EQ_CTRL_RX_DATA_HOLD, 0); + + return 0; +} + +static int artpec8_pcie_phy_exit(struct phy *phy) +{ + return 0; +} + +static int artpec8_pcie_phy_reset(struct phy *phy) +{ + struct artpec8_pcie_phy *pciephy = phy_get_drvdata(phy); + + artpec8_pcie_phy_reg_update(pciephy->phy_base, OV_I_CMN_RSTN, + 0, PCIE_PHY_CMN_REG101); + udelay(10); + artpec8_pcie_phy_reg_update(pciephy->phy_base, OV_I_CMN_RSTN, + OV_I_CMN_RSTN, PCIE_PHY_CMN_REG101); + + return 0; +} + +static int artpec8_pcie_phy_power_on(struct phy *phy) +{ + struct artpec8_pcie_phy *pciephy = phy_get_drvdata(phy); + + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, + PCIE_PHY_PWR_OFF, 0); + + return 0; +} + +static int artpec8_pcie_phy_power_off(struct phy *phy) +{ + struct artpec8_pcie_phy *pciephy = phy_get_drvdata(phy); + + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, + PCIE_PHY_PWR_OFF, PCIE_PHY_PWR_OFF); + + return 0; +} + +static int artpec8_pcie_phy_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct artpec8_pcie_phy *artpec8_phy; + struct phy *generic_phy; + struct phy_provider *phy_provider; + const struct artpec8_pcie_phy_data *drv_data; + + drv_data = of_device_get_match_data(dev); + if (!drv_data) + return -ENODEV; + + artpec8_phy = devm_kzalloc(dev, sizeof(*artpec8_phy), GFP_KERNEL); + if (!artpec8_phy) + return -ENOMEM; + + /* reference clock */ + if (of_property_read_u32(dev->of_node, "lcpll-ref-clk", + &artpec8_phy->lcpll_ref_clk)) { + return -EINVAL; + } + /* PLL SOC reference clock */ + if (artpec8_phy->lcpll_ref_clk == REF_CLK_FROM_SOC_PLL) { + artpec8_phy->soc_pll_clk = devm_clk_get(dev, "ref_clk"); + if (IS_ERR(artpec8_phy->soc_pll_clk)) + return -EINVAL; + clk_prepare_enable(artpec8_phy->soc_pll_clk); + } + + /* link mode */ + if (of_property_read_string(dev->of_node, "mode", &artpec8_phy->mode)) + return -EINVAL; + + /* number of lanes */ + if (of_property_read_u32(dev->of_node, "num-lanes", + &artpec8_phy->num_lanes)) + return -EINVAL; + + if (artpec8_phy->num_lanes > LANE_MAX) + return -EINVAL; + + /* PHY base register */ + artpec8_phy->phy_base = devm_platform_ioremap_resource_byname(pdev, "phy"); + if (IS_ERR(artpec8_phy->phy_base)) + return PTR_ERR(artpec8_phy->phy_base); + + /* PCS base register */ + artpec8_phy->pcs_base = devm_platform_ioremap_resource_byname(pdev, "pcs"); + if (IS_ERR(artpec8_phy->pcs_base)) + return PTR_ERR(artpec8_phy->pcs_base); + + /* sysreg regmap handle, need to change using smc */ + artpec8_phy->sysreg = + syscon_regmap_lookup_by_phandle(dev->of_node, + "samsung,fsys-sysreg"); + if (IS_ERR(artpec8_phy->sysreg)) + return PTR_ERR(artpec8_phy->sysreg); + + artpec8_phy->drv_data = drv_data; + + generic_phy = devm_phy_create(dev, dev->of_node, drv_data->ops); + if (IS_ERR(generic_phy)) + return PTR_ERR(generic_phy); + + phy_set_drvdata(generic_phy, artpec8_phy); + phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); + + if (IS_ERR(phy_provider)) + return PTR_ERR(phy_provider); + + return 0; +} + +static int __exit artpec8_pcie_remove(struct platform_device *pdev) +{ + struct artpec8_pcie_phy *artpec8_phy = platform_get_drvdata(pdev); + + if (artpec8_phy->soc_pll_clk) + clk_disable_unprepare(artpec8_phy->soc_pll_clk); + + return 0; +} + +static const struct phy_ops artpec8_phy_ops = { + .init = artpec8_pcie_phy_init, + .exit = artpec8_pcie_phy_exit, + .reset = artpec8_pcie_phy_reset, + .power_on = artpec8_pcie_phy_power_on, + .power_off = artpec8_pcie_phy_power_off, + .owner = THIS_MODULE, +}; + +static const struct artpec8_pcie_phy_data artpec8_pcie_phy_data = { + .ops = &artpec8_phy_ops, +}; + +static const struct of_device_id artpec8_pcie_phy_match[] = { + { + .compatible = "axis,artpec8-pcie-phy", + .data = &artpec8_pcie_phy_data, + }, + {}, +}; +MODULE_DEVICE_TABLE(of, artpec8_pcie_phy_match); + +static struct platform_driver artpec8_pcie_phy_driver = { + .probe = artpec8_pcie_phy_probe, + .remove = __exit_p(artpec8_pcie_phy_remove), + .driver = { + .of_match_table = artpec8_pcie_phy_match, + .name = "artpec8_pcie_phy", + } +}; + +module_platform_driver(artpec8_pcie_phy_driver); + +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Jaeho Cho <jaeho79.cho@samsung.com>"); -- 2.9.5 ^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver 2022-06-14 1:34 ` [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver Wangseok Lee @ 2022-07-05 6:21 ` Vinod Koul 0 siblings, 0 replies; 30+ messages in thread From: Vinod Koul @ 2022-07-05 6:21 UTC (permalink / raw) To: Wangseok Lee Cc: robh+dt, krzk+dt, kishon, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel, Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 14-06-22, 10:34, Wangseok Lee wrote: > Add support Axis, ARTPEC-8 SoC. > ARTPEC-8 is the SoC platform of Axis Communications. > This is based on arm64 and support GEN4 & 2lane. > This driver provides PHY interface for ARTPEC-8 SoC PCIe controller, > based on Samsung PCIe PHY IP. > > Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> > Signed-off-by: Jaeho Cho <jaeho79.cho@samsung.com> > --- > v2->v3 : > -remove unnecessary indentation > -redefine local struct to statis const > -add static const to struct that requires static const definition > -remove wrappers on writel and readl > > v1->v2 : > -change folder name of phy driver to axis from artpec > --- > drivers/phy/Kconfig | 1 + > drivers/phy/Makefile | 1 + > drivers/phy/axis/Kconfig | 9 + > drivers/phy/axis/Makefile | 2 + > drivers/phy/axis/phy-artpec8-pcie.c | 776 ++++++++++++++++++++++++++++++++++++ > 5 files changed, 789 insertions(+) > create mode 100644 drivers/phy/axis/Kconfig > create mode 100644 drivers/phy/axis/Makefile > create mode 100644 drivers/phy/axis/phy-artpec8-pcie.c > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index 300b0f2..92b8232 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -73,6 +73,7 @@ config PHY_CAN_TRANSCEIVER > > source "drivers/phy/allwinner/Kconfig" > source "drivers/phy/amlogic/Kconfig" > +source "drivers/phy/axis/Kconfig" > source "drivers/phy/broadcom/Kconfig" > source "drivers/phy/cadence/Kconfig" > source "drivers/phy/freescale/Kconfig" > diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile > index 01e9eff..808c055e 100644 > --- a/drivers/phy/Makefile > +++ b/drivers/phy/Makefile > @@ -12,6 +12,7 @@ obj-$(CONFIG_PHY_PISTACHIO_USB) += phy-pistachio-usb.o > obj-$(CONFIG_USB_LGM_PHY) += phy-lgm-usb.o > obj-y += allwinner/ \ > amlogic/ \ > + axis/ \ > broadcom/ \ > cadence/ \ > freescale/ \ > diff --git a/drivers/phy/axis/Kconfig b/drivers/phy/axis/Kconfig > new file mode 100644 > index 0000000..7198b93 > --- /dev/null > +++ b/drivers/phy/axis/Kconfig > @@ -0,0 +1,9 @@ > +config PHY_ARTPEC8_PCIE > + bool "ARTPEC-8 PCIe PHY driver" > + depends on OF && (ARCH_ARTPEC8 || COMPILE_TEST) > + select GENERIC_PHY > + help > + Enable PCIe PHY support for ARTPEC-8 SoC. > + This driver provides PHY interface for ARTPEC-8 SoC > + PCIe controller. > + This is based on Samsung PCIe PHY IP. How different is it from SS IP and why should it not be under phy/samsung/ then? > diff --git a/drivers/phy/axis/Makefile b/drivers/phy/axis/Makefile > new file mode 100644 > index 0000000..45d853c > --- /dev/null > +++ b/drivers/phy/axis/Makefile > @@ -0,0 +1,2 @@ > +# SPDX-License-Identifier: GPL-2.0 > +obj-$(CONFIG_PHY_ARTPEC8_PCIE) += phy-artpec8-pcie.o > diff --git a/drivers/phy/axis/phy-artpec8-pcie.c b/drivers/phy/axis/phy-artpec8-pcie.c > new file mode 100644 > index 0000000..d21867b > --- /dev/null > +++ b/drivers/phy/axis/phy-artpec8-pcie.c > @@ -0,0 +1,776 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * PHY provider for ARTPEC-8 PCIe controller > + * > + * Copyright (C) 2019 Samsung Electronics Co., Ltd. > + * http://www.samsung.com > + * > + * Author: Jaeho Cho <jaeho79.cho@samsung.com> > + */ > + > +#include <linux/clk.h> > +#include <linux/io.h> > +#include <linux/init.h> > +#include <linux/mfd/syscon.h> > +#include <linux/module.h> > +#include <linux/of.h> > +#include <linux/of_address.h> > +#include <linux/of_platform.h> > +#include <linux/platform_device.h> > +#include <linux/phy/phy.h> > +#include <linux/regmap.h> > +#include <linux/debugfs.h> > + > +/* ARTPEC-8 PCIe PHY registers */ > +/* CMN registers */ > +#define PCIE_PHY_CMN_REG004 0x10 > +#define PCIE_PHY_CMN_REG00B 0x2C > +#define PCIE_PHY_CMN_REG016 0x58 > +#define PCIE_PHY_CMN_REG01C 0x70 > +#define PCIE_PHY_CMN_REG021 0x84 > +#define PCIE_PHY_CMN_REG024 0x90 > +#define PCIE_PHY_CMN_REG025 0x94 > +#define PCIE_PHY_CMN_REG0E6 0x398 > +#define PCIE_PHY_CMN_REG0E7 0x39C > +#define PCIE_PHY_CMN_REG0E8 0x3A0 > +#define PCIE_PHY_CMN_REG0E9 0x3A4 > +#define PCIE_PHY_CMN_REG0EA 0x3A8 > +#define PCIE_PHY_CMN_REG0EB 0x3AC > +#define PCIE_PHY_CMN_REG0EC 0x3B0 > +#define PCIE_PHY_CMN_REG0EE 0x3B8 > +#define PCIE_PHY_CMN_REG0EF 0x3BC > +#define PCIE_PHY_CMN_REG0F1 0x3C4 > +#define PCIE_PHY_CMN_REG0F3 0x3CC > +#define PCIE_PHY_CMN_REG0F4 0x3D0 > + > +#define PCIE_PHY_CMN_REG101 0x404 > +#define OV_I_CMN_RSTN BIT(4) > +#define OV_I_INIT_RSTN BIT(6) > + > +#define PCIE_PHY_CMN_REG131 0x4C4 > +#define PCIE_PHY_CMN_REG17B 0x5EC > +#define PCIE_PHY_CMN_REG17D 0x5F4 > +#define PCIE_PHY_CMN_REG190 0x640 > +#define PCIE_PHY_CMN_REG191 0x644 > +#define PCIE_PHY_CMN_REG192 0x648 > +#define PCIE_PHY_CMN_REG1C7 0x71C > +#define PCIE_PHY_CMN_REG1DF 0x77C > +#define PCIE_PHY_CMN_REG1E0 0x780 > + > +#define PCIE_PHY_CMN_REG0B1 0x2C4 > +#define ANA_ROPLL_REF_DIG_CLK_SEL BIT(2) > + > +/* External clock */ > +#define PCIE_PHY_CMN_REG14D 0x534 > +#define PCIE_AUX_RX_MODE_EXTEND BIT(7) > + > +#define PCIE_PHY_CMN_REG0D9 0x364 > +#define ANA_AUX_EXT_REF_CLK_SEL BIT(4) > + > +#define PCIE_PHY_CMN_REG10F 0x43C > +#define AUX_PLL_EN_EXTEND BIT(4) > + > +#define PCIE_PHY_CMN_REG11E 0x478 > +#define AUX2_PLL_EN_EXTEND BIT(3) > + > +#define PCIE_PHY_CMN_REG0D4 0x350 > +#define OV_S_ANA_AUX_EN BIT(3) > +#define OV_I_ANA_AUX_EN BIT(2) > + > +/* LANE registers */ > +#define PCIE_PHY_TRSV_REG22D 0x8B4 > +#define PCIE_PHY_TRSV_REG23E 0x8F8 > +#define PCIE_PHY_TRSV_REG2A5 0xA94 > +#define PCIE_PHY_TRSV_REG3E3 0xF8C > +#define PCIE_PHY_TRSV_REG3ED 0xFB4 > +#define PCIE_PHY_TRSV_REG20B 0x82C > +#define PCIE_PHY_TRSV_REG20C 0x830 > +#define PCIE_PHY_TRSV_REG234 0x8D0 > +#define PCIE_PHY_TRSV_REG235 0x8D4 > +#define PCIE_PHY_TRSV_REG237 0x8DC > +#define PCIE_PHY_TRSV_REG239 0x8E4 > +#define PCIE_PHY_TRSV_REG23A 0x8E8 > +#define PCIE_PHY_TRSV_REG23B 0x8EC > +#define PCIE_PHY_TRSV_REG24B 0x92C > +#define PCIE_PHY_TRSV_REG25D 0x974 > +#define PCIE_PHY_TRSV_REG262 0x988 > +#define PCIE_PHY_TRSV_REG271 0x9C4 > +#define PCIE_PHY_TRSV_REG272 0x9C8 > +#define PCIE_PHY_TRSV_REG27C 0x9F0 > +#define PCIE_PHY_TRSV_REG27D 0x9F4 > +#define PCIE_PHY_TRSV_REG27E 0x9F8 > +#define PCIE_PHY_TRSV_REG284 0xA10 > +#define PCIE_PHY_TRSV_REG289 0xA24 > +#define PCIE_PHY_TRSV_REG28A 0xA28 > +#define PCIE_PHY_TRSV_REG28B 0xA2C > +#define PCIE_PHY_TRSV_REG28C 0xA30 > +#define PCIE_PHY_TRSV_REG28E 0xA38 > +#define PCIE_PHY_TRSV_REG28F 0xA3C > +#define PCIE_PHY_TRSV_REG290 0xA40 > +#define PCIE_PHY_TRSV_REG291 0xA44 > +#define PCIE_PHY_TRSV_REG292 0xA48 > +#define PCIE_PHY_TRSV_REG294 0xA50 > +#define PCIE_PHY_TRSV_REG295 0xA54 > +#define PCIE_PHY_TRSV_REG296 0xA58 > +#define PCIE_PHY_TRSV_REG297 0xA5C > +#define PCIE_PHY_TRSV_REG298 0xA60 > +#define PCIE_PHY_TRSV_REG29B 0xA6C > +#define PCIE_PHY_TRSV_REG29C 0xA70 > +#define PCIE_PHY_TRSV_REG29D 0xA74 > +#define PCIE_PHY_TRSV_REG29E 0xA78 > +#define PCIE_PHY_TRSV_REG2AA 0xAA8 > +#define PCIE_PHY_TRSV_REG2AE 0xAB8 > +#define PCIE_PHY_TRSV_REG2C2 0xB08 > +#define PCIE_PHY_TRSV_REG2C6 0xB18 > +#define PCIE_PHY_TRSV_REG2C7 0xB1C > +#define PCIE_PHY_TRSV_REG2CB 0xB2C > +#define PCIE_PHY_TRSV_REG2CC 0xB30 > +#define PCIE_PHY_TRSV_REG2CD 0xB34 > +#define PCIE_PHY_TRSV_REG2CE 0xB38 > +#define PCIE_PHY_TRSV_REG2D0 0xB40 > +#define PCIE_PHY_TRSV_REG2CF 0xB3C > +#define PCIE_PHY_TRSV_REG2E0 0xB80 > +#define PCIE_PHY_TRSV_REG2E9 0xBA4 > +#define PCIE_PHY_TRSV_REG2EA 0xBA8 > +#define PCIE_PHY_TRSV_REG2EB 0xBAC > +#define PCIE_PHY_TRSV_REG315 0xC54 > +#define PCIE_PHY_TRSV_REG317 0xC5C > +#define PCIE_PHY_TRSV_REG319 0xC64 > +#define PCIE_PHY_TRSV_REG364 0xD90 > +#define PCIE_PHY_TRSV_REG36C 0xDB0 > +#define PCIE_PHY_TRSV_REG36D 0xDB4 > +#define PCIE_PHY_TRSV_REG37E 0xDF8 > +#define PCIE_PHY_TRSV_REG37F 0xDFC > +#define PCIE_PHY_TRSV_REG38F 0xE3C > +#define PCIE_PHY_TRSV_REG391 0xE44 > +#define PCIE_PHY_TRSV_REG39C 0xE70 > +#define PCIE_PHY_TRSV_REG3A8 0xEA0 > +#define PCIE_PHY_TRSV_REG3E0 0xF80 > +#define PCIE_PHY_TRSV_REG3E1 0xF84 > +#define PCIE_PHY_TRSV_REG3E7 0xF9C > +#define PCIE_PHY_TRSV_REG3E9 0xFA4 > +#define PCIE_PHY_TRSV_REG3EA 0xFA8 > +#define PCIE_PHY_TRSV_REG3EE 0xFB8 > +#define PCIE_PHY_TRSV_REG3EF 0xFBC > +#define PCIE_PHY_TRSV_REG3F0 0xFC0 > + > +#define PCIE_PHY_TRSV_REG2C0 0xB00 > +#define LN_EQ_CTRL_RX_DATA_HOLD BIT(5) > + > +/* RX Preset registers */ > +#define PCIE_PHY_CMN_REG17E 0x5F8 > +#define PCIE_PHY_CMN_REG180 0x600 > +#define PCIE_PHY_CMN_REG181 0x604 > +#define PCIE_PHY_CMN_REG182 0x608 > +#define PCIE_PHY_CMN_REG183 0x60C > +#define PCIE_PHY_CMN_REG184 0x610 > +#define PCIE_PHY_CMN_REG185 0x614 > +#define PCIE_PHY_CMN_REG186 0x618 > +#define PCIE_PHY_CMN_REG187 0x61C > + > + > +/* ARTPEC-8 PCIe PCS registers */ > +#define PCIE_PCS_OUT_VEC_4 0x154 > +#define B1_DYNAMIC BIT(3) > + > +/* ARTPEC-8 SYS REG registers */ > +#define FSYS_PCIE_CON 0x424 > +#define PCIE_PHY_LCPLL_REFCLK_SEL 0x3 > +#define PCIE_PHY_ROPLL_REFCLK_SEL (0x3UL << 2) > +#define ROPLL_REFCLK_NOT_AVAILABLE (0x2UL << 2) Pls use GENMASK for this > +#define PCIE_PHY_LN0_REFCLK_PAD_EN BIT(10) > +#define PCIE_PHY_LN1_REFCLK_PAD_EN BIT(11) > +#define PCIE_PHY_PWR_OFF BIT(7) > + > +/* ARTPEC-8 Sub Controller registers */ > +#define SFR_INIT_RSTN 0x1404 > +#define SFR_CMN_RSTN 0x1408 > + > +#define PCIE_PHY_LN0_REG_START 0x800 > +#define PCIE_PHY_LN0_REG_END 0xFCC > +#define OFFSET_PER_LANE 0x800 > + > +enum artpec8_pcie_phy_num_lanes { > + LANE0 = 0, > + LANE1, > + LANE_MAX > +}; > + > +struct artpec8_pcie_phy_data { > + const struct phy_ops *ops; > +}; > + > +struct artpec8_pcie_phy { > + const struct artpec8_pcie_phy_data *drv_data; > + void __iomem *phy_base; > + void __iomem *pcs_base; > + void __iomem *elbi_base; > + struct clk *soc_pll_clk; > + struct regmap *sysreg; > + u32 lcpll_ref_clk; > + const char *mode; > + u32 num_lanes; > +}; > + > +enum artpec8_pcie_ref_clk { > + REF_CLK_FROM_XO = 0, > + REF_CLK_FROM_IO, > + REF_CLK_RESERVED, > + REF_CLK_FROM_SOC_PLL, > + REF_CLK_MAX > +}; > + > +struct artpec8_pcie_phy_tune_reg { > + u32 offset; > + u32 val; > +}; > + > +/* ARTPEC-8 PCIe Gen4 x2 PHY CMN register settings */ > +static const struct artpec8_pcie_phy_tune_reg cmn_regs[] = { > + {PCIE_PHY_CMN_REG004, 0x65}, > + {PCIE_PHY_CMN_REG00B, 0x18}, > + {PCIE_PHY_CMN_REG016, 0x0E}, > + {PCIE_PHY_CMN_REG01C, 0x4F}, > + {PCIE_PHY_CMN_REG021, 0x01}, > + {PCIE_PHY_CMN_REG024, 0x58}, > + {PCIE_PHY_CMN_REG025, 0x98}, > + {PCIE_PHY_CMN_REG0E6, 0x00}, > + {PCIE_PHY_CMN_REG0E7, 0x00}, > + {PCIE_PHY_CMN_REG0E8, 0x3F}, > + {PCIE_PHY_CMN_REG0E9, 0x3F}, > + {PCIE_PHY_CMN_REG0EA, 0xFF}, > + {PCIE_PHY_CMN_REG0EB, 0xFF}, > + {PCIE_PHY_CMN_REG0EC, 0x42}, > + {PCIE_PHY_CMN_REG0EE, 0x3F}, > + {PCIE_PHY_CMN_REG0EF, 0x7F}, > + {PCIE_PHY_CMN_REG0F1, 0x02}, > + {PCIE_PHY_CMN_REG0F3, 0xFF}, > + {PCIE_PHY_CMN_REG0F4, 0xFF}, > + {PCIE_PHY_CMN_REG131, 0x01}, > + {PCIE_PHY_CMN_REG17B, 0xC0}, > + {PCIE_PHY_CMN_REG17D, 0xAF}, > + {PCIE_PHY_CMN_REG190, 0x27}, > + {PCIE_PHY_CMN_REG191, 0x0F}, > + {PCIE_PHY_CMN_REG192, 0x3F}, > + {PCIE_PHY_CMN_REG1C7, 0x05}, > + {PCIE_PHY_CMN_REG1DF, 0x28}, > + {PCIE_PHY_CMN_REG1E0, 0x28}, > +}; > + > +/* ARTPEC-8 PCIe Gen4 x2 PHY lane register settings */ > +static const struct artpec8_pcie_phy_tune_reg lane_regs[] = { > + {PCIE_PHY_TRSV_REG22D, 0x00}, > + {PCIE_PHY_TRSV_REG23E, 0x00}, > + {PCIE_PHY_TRSV_REG2A5, 0x73}, > + {PCIE_PHY_TRSV_REG3E3, 0x7B}, > + {PCIE_PHY_TRSV_REG3ED, 0x4B}, > + {PCIE_PHY_TRSV_REG20B, 0x02}, > + {PCIE_PHY_TRSV_REG20C, 0xEA}, > + {PCIE_PHY_TRSV_REG234, 0x7A}, > + {PCIE_PHY_TRSV_REG235, 0x1C}, > + {PCIE_PHY_TRSV_REG237, 0x10}, > + {PCIE_PHY_TRSV_REG239, 0x68}, > + {PCIE_PHY_TRSV_REG23A, 0xC0}, > + {PCIE_PHY_TRSV_REG23B, 0x0B}, > + {PCIE_PHY_TRSV_REG24B, 0x00}, > + {PCIE_PHY_TRSV_REG25D, 0x07}, > + {PCIE_PHY_TRSV_REG262, 0x07}, > + {PCIE_PHY_TRSV_REG271, 0x23}, > + {PCIE_PHY_TRSV_REG272, 0x5E}, > + {PCIE_PHY_TRSV_REG27C, 0x8C}, > + {PCIE_PHY_TRSV_REG27D, 0x5B}, > + {PCIE_PHY_TRSV_REG27E, 0x2C}, > + {PCIE_PHY_TRSV_REG284, 0x33}, > + {PCIE_PHY_TRSV_REG289, 0xD4}, > + {PCIE_PHY_TRSV_REG28A, 0xCC}, > + {PCIE_PHY_TRSV_REG28B, 0xD9}, > + {PCIE_PHY_TRSV_REG28C, 0xDC}, > + {PCIE_PHY_TRSV_REG28E, 0xC6}, > + {PCIE_PHY_TRSV_REG28F, 0x90}, > + {PCIE_PHY_TRSV_REG290, 0x4D}, > + {PCIE_PHY_TRSV_REG291, 0x19}, > + {PCIE_PHY_TRSV_REG292, 0x1C}, > + {PCIE_PHY_TRSV_REG294, 0x05}, > + {PCIE_PHY_TRSV_REG295, 0x10}, > + {PCIE_PHY_TRSV_REG296, 0x0C}, > + {PCIE_PHY_TRSV_REG297, 0x19}, > + {PCIE_PHY_TRSV_REG298, 0x04}, > + {PCIE_PHY_TRSV_REG29B, 0x03}, > + {PCIE_PHY_TRSV_REG29C, 0x1B}, > + {PCIE_PHY_TRSV_REG29D, 0x1B}, > + {PCIE_PHY_TRSV_REG29E, 0x1F}, > + {PCIE_PHY_TRSV_REG2AA, 0x00}, > + {PCIE_PHY_TRSV_REG2AE, 0x1F}, > + {PCIE_PHY_TRSV_REG2C2, 0x25}, > + {PCIE_PHY_TRSV_REG2C6, 0x10}, > + {PCIE_PHY_TRSV_REG2C7, 0x06}, > + {PCIE_PHY_TRSV_REG2CB, 0x10}, > + {PCIE_PHY_TRSV_REG2CC, 0x06}, > + {PCIE_PHY_TRSV_REG2CD, 0x20}, > + {PCIE_PHY_TRSV_REG2CE, 0x27}, > + {PCIE_PHY_TRSV_REG2D0, 0x10}, > + {PCIE_PHY_TRSV_REG2CF, 0x0A}, > + {PCIE_PHY_TRSV_REG2E0, 0x01}, > + {PCIE_PHY_TRSV_REG2E9, 0x11}, > + {PCIE_PHY_TRSV_REG2EA, 0x05}, > + {PCIE_PHY_TRSV_REG2EB, 0x4C}, > + {PCIE_PHY_TRSV_REG315, 0x18}, > + {PCIE_PHY_TRSV_REG317, 0x86}, > + {PCIE_PHY_TRSV_REG319, 0x8E}, > + {PCIE_PHY_TRSV_REG364, 0x00}, > + {PCIE_PHY_TRSV_REG36C, 0x03}, > + {PCIE_PHY_TRSV_REG36D, 0x04}, > + {PCIE_PHY_TRSV_REG37E, 0x06}, > + {PCIE_PHY_TRSV_REG37F, 0x04}, > + {PCIE_PHY_TRSV_REG38F, 0x40}, > + {PCIE_PHY_TRSV_REG391, 0x8B}, > + {PCIE_PHY_TRSV_REG39C, 0xFF}, > + {PCIE_PHY_TRSV_REG3A8, 0x02}, > + {PCIE_PHY_TRSV_REG3E0, 0x93}, > + {PCIE_PHY_TRSV_REG3E1, 0x79}, > + {PCIE_PHY_TRSV_REG3E7, 0xF5}, > + {PCIE_PHY_TRSV_REG3E9, 0x75}, > + {PCIE_PHY_TRSV_REG3EA, 0x0D}, > + {PCIE_PHY_TRSV_REG3EE, 0xE2}, > + {PCIE_PHY_TRSV_REG3EF, 0x6F}, > + {PCIE_PHY_TRSV_REG3F0, 0x3D} > +}; > + > +static const struct artpec8_pcie_phy_tune_reg rx_preset_regs[] = { > + /* 0 */ > + {PCIE_PHY_CMN_REG17E, 0x00}, > + {PCIE_PHY_CMN_REG180, 0x23}, > + {PCIE_PHY_CMN_REG181, 0x44}, > + {PCIE_PHY_CMN_REG182, 0x61}, > + {PCIE_PHY_CMN_REG183, 0x55}, > + {PCIE_PHY_CMN_REG184, 0x14}, > + {PCIE_PHY_CMN_REG185, 0x23}, > + {PCIE_PHY_CMN_REG186, 0x1A}, > + {PCIE_PHY_CMN_REG187, 0x04}, > + {PCIE_PHY_CMN_REG17E, 0x04}, > + {PCIE_PHY_CMN_REG17E, 0x00}, > + /* 1 */ > + {PCIE_PHY_CMN_REG17E, 0x08}, > + {PCIE_PHY_CMN_REG181, 0x42}, > + {PCIE_PHY_CMN_REG17E, 0x0C}, > + {PCIE_PHY_CMN_REG17E, 0x08}, > + /* 2 */ > + {PCIE_PHY_CMN_REG17E, 0x10}, > + {PCIE_PHY_CMN_REG181, 0x40}, > + {PCIE_PHY_CMN_REG17E, 0x14}, > + {PCIE_PHY_CMN_REG17E, 0x10}, > + /* 3 */ > + {PCIE_PHY_CMN_REG17E, 0x18}, > + {PCIE_PHY_CMN_REG181, 0x45}, > + {PCIE_PHY_CMN_REG17E, 0x1C}, > + {PCIE_PHY_CMN_REG17E, 0x18}, > + /* 4 */ > + {PCIE_PHY_CMN_REG17E, 0x20}, > + {PCIE_PHY_CMN_REG181, 0x46}, > + {PCIE_PHY_CMN_REG17E, 0x24}, > + {PCIE_PHY_CMN_REG17E, 0x20}, > + /* 5 */ > + {PCIE_PHY_CMN_REG17E, 0x28}, > + {PCIE_PHY_CMN_REG181, 0x48}, > + {PCIE_PHY_CMN_REG17E, 0x2C}, > + {PCIE_PHY_CMN_REG17E, 0x28}, > + /* 6 */ > + {PCIE_PHY_CMN_REG17E, 0x30}, > + {PCIE_PHY_CMN_REG181, 0x4A}, > + {PCIE_PHY_CMN_REG17E, 0x34}, > + {PCIE_PHY_CMN_REG17E, 0x30}, > + /* 7 */ > + {PCIE_PHY_CMN_REG17E, 0x38}, > + {PCIE_PHY_CMN_REG181, 0x4C}, > + {PCIE_PHY_CMN_REG17E, 0x3C}, > + {PCIE_PHY_CMN_REG17E, 0x38}, > + /* 8 */ > + {PCIE_PHY_CMN_REG17E, 0x40}, > + {PCIE_PHY_CMN_REG180, 0x20}, > + {PCIE_PHY_CMN_REG181, 0x20}, > + {PCIE_PHY_CMN_REG182, 0x01}, > + {PCIE_PHY_CMN_REG17E, 0x44}, > + {PCIE_PHY_CMN_REG17E, 0x40}, > + /* 9 */ > + {PCIE_PHY_CMN_REG17E, 0x48}, > + {PCIE_PHY_CMN_REG180, 0x20}, > + {PCIE_PHY_CMN_REG181, 0x21}, > + {PCIE_PHY_CMN_REG182, 0x01}, > + {PCIE_PHY_CMN_REG17E, 0x4C}, > + {PCIE_PHY_CMN_REG17E, 0x48}, > + /* 10 */ > + {PCIE_PHY_CMN_REG17E, 0x50}, > + {PCIE_PHY_CMN_REG180, 0x24}, > + {PCIE_PHY_CMN_REG181, 0x80}, > + {PCIE_PHY_CMN_REG182, 0x41}, > + {PCIE_PHY_CMN_REG183, 0xAF}, > + {PCIE_PHY_CMN_REG184, 0x26}, > + {PCIE_PHY_CMN_REG185, 0x34}, > + {PCIE_PHY_CMN_REG186, 0x24}, > + {PCIE_PHY_CMN_REG187, 0x06}, > + {PCIE_PHY_CMN_REG17E, 0x54}, > + {PCIE_PHY_CMN_REG17E, 0x50}, > + /* 11 */ > + {PCIE_PHY_CMN_REG17E, 0x58}, > + {PCIE_PHY_CMN_REG181, 0x81}, > + {PCIE_PHY_CMN_REG17E, 0x5C}, > + {PCIE_PHY_CMN_REG17E, 0x58}, > + /* 12 */ > + {PCIE_PHY_CMN_REG17E, 0x60}, > + {PCIE_PHY_CMN_REG181, 0x82}, > + {PCIE_PHY_CMN_REG17E, 0x64}, > + {PCIE_PHY_CMN_REG17E, 0x60}, > + /* 13 */ > + {PCIE_PHY_CMN_REG17E, 0x68}, > + {PCIE_PHY_CMN_REG181, 0x83}, > + {PCIE_PHY_CMN_REG17E, 0x6C}, > + {PCIE_PHY_CMN_REG17E, 0x68}, > + /* 14 */ > + {PCIE_PHY_CMN_REG17E, 0x70}, > + {PCIE_PHY_CMN_REG181, 0x84}, > + {PCIE_PHY_CMN_REG17E, 0x74}, > + {PCIE_PHY_CMN_REG17E, 0x70}, > + /* 15 */ > + {PCIE_PHY_CMN_REG17E, 0x78}, > + {PCIE_PHY_CMN_REG180, 0x24}, > + {PCIE_PHY_CMN_REG181, 0x85}, > + {PCIE_PHY_CMN_REG182, 0x80}, > + {PCIE_PHY_CMN_REG183, 0x7F}, > + {PCIE_PHY_CMN_REG184, 0x2D}, > + {PCIE_PHY_CMN_REG185, 0x34}, > + {PCIE_PHY_CMN_REG186, 0x24}, > + {PCIE_PHY_CMN_REG187, 0x05}, > + {PCIE_PHY_CMN_REG17E, 0x7C}, > + {PCIE_PHY_CMN_REG17E, 0x78}, > + /* 16 */ > + {PCIE_PHY_CMN_REG17E, 0x80}, > + {PCIE_PHY_CMN_REG181, 0x86}, > + {PCIE_PHY_CMN_REG17E, 0x84}, > + {PCIE_PHY_CMN_REG17E, 0x80}, > + /* 17 */ > + {PCIE_PHY_CMN_REG17E, 0x88}, > + {PCIE_PHY_CMN_REG181, 0x87}, > + {PCIE_PHY_CMN_REG17E, 0x8C}, > + {PCIE_PHY_CMN_REG17E, 0x88}, > + /* 18 */ > + {PCIE_PHY_CMN_REG17E, 0x90}, > + {PCIE_PHY_CMN_REG181, 0x88}, > + {PCIE_PHY_CMN_REG17E, 0x94}, > + {PCIE_PHY_CMN_REG17E, 0x90}, > + /* 19 */ > + {PCIE_PHY_CMN_REG17E, 0x98}, > + {PCIE_PHY_CMN_REG181, 0x89}, > + {PCIE_PHY_CMN_REG17E, 0x9C}, > + {PCIE_PHY_CMN_REG17E, 0x98}, > +}; > + > +static void artpec8_pcie_phy_reg_update(void __iomem *base, u32 mask, > + u32 update, u32 reg) > +{ > + u32 val; > + > + val = readl(base + reg); > + val &= ~(mask); > + val |= update; > + writel(val, base + reg); > +}; > + > +static void artpec8_pcie_enable_ref_clk_from_xo(struct artpec8_pcie_phy > + *pciephy) pls use consistent formatting for second lines, this and previous function _do_not_ match. Hint, checkpatch recommends aligning to previous line open brace (--strict option will check that for you) > +{ > + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, > + PCIE_PHY_LCPLL_REFCLK_SEL, > + REF_CLK_FROM_XO); > + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, > + PCIE_PHY_ROPLL_REFCLK_SEL, > + ROPLL_REFCLK_NOT_AVAILABLE); > +}; > + > +static void artpec8_pcie_enable_ref_clk_from_io(struct artpec8_pcie_phy > + *pciephy) > +{ > + artpec8_pcie_phy_reg_update(pciephy->phy_base, > + PCIE_AUX_RX_MODE_EXTEND, 0, > + PCIE_PHY_CMN_REG14D); > + artpec8_pcie_phy_reg_update(pciephy->phy_base, > + ANA_AUX_EXT_REF_CLK_SEL, 0, > + PCIE_PHY_CMN_REG0D9); > + artpec8_pcie_phy_reg_update(pciephy->phy_base, > + AUX_PLL_EN_EXTEND, 0, > + PCIE_PHY_CMN_REG10F); > + artpec8_pcie_phy_reg_update(pciephy->phy_base, > + AUX2_PLL_EN_EXTEND, 0, > + PCIE_PHY_CMN_REG11E); > + artpec8_pcie_phy_reg_update(pciephy->phy_base, > + OV_S_ANA_AUX_EN, OV_S_ANA_AUX_EN, > + PCIE_PHY_CMN_REG0D4); > + artpec8_pcie_phy_reg_update(pciephy->phy_base, > + OV_I_ANA_AUX_EN, OV_I_ANA_AUX_EN, > + PCIE_PHY_CMN_REG0D4); > + > + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, > + PCIE_PHY_LCPLL_REFCLK_SEL, > + REF_CLK_FROM_IO); > + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, > + PCIE_PHY_ROPLL_REFCLK_SEL, > + ROPLL_REFCLK_NOT_AVAILABLE); > + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, > + PCIE_PHY_LN0_REFCLK_PAD_EN, > + PCIE_PHY_LN0_REFCLK_PAD_EN); > + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, > + PCIE_PHY_LN1_REFCLK_PAD_EN, > + PCIE_PHY_LN1_REFCLK_PAD_EN); > +} > + > +static void artpec8_pcie_enable_ref_clk_from_soc_pll(struct artpec8_pcie_phy > + *pciephy) > +{ > + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, > + PCIE_PHY_LCPLL_REFCLK_SEL, > + REF_CLK_FROM_SOC_PLL); > + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, > + PCIE_PHY_ROPLL_REFCLK_SEL, > + ROPLL_REFCLK_NOT_AVAILABLE); > +} > + > +static void artpec8_pcie_lane_control(struct phy *phy, u32 lane0_reg, u32 mask, > + u32 val) > +{ > + struct artpec8_pcie_phy *pciephy = phy_get_drvdata(phy); > + u32 lanex_reg = lane0_reg; > + int i; > + > + if (lane0_reg < PCIE_PHY_LN0_REG_START || > + lane0_reg > PCIE_PHY_LN0_REG_END) { > + return; > + } > + > + for (i = 0; i < pciephy->num_lanes; i++) { > + lanex_reg += OFFSET_PER_LANE * i; > + artpec8_pcie_phy_reg_update(pciephy->phy_base, mask, val, > + lanex_reg); > + } > +} > + > +static void artpec8_pcie_phy_tune(struct artpec8_pcie_phy *pciephy) > +{ > + int i, count; > + > + /* init cmn registers */ > + count = ARRAY_SIZE(cmn_regs); > + for (i = 0; i < count; i++) > + writel(cmn_regs[i].val, pciephy->phy_base + cmn_regs[i].offset); > + > + /* init lane registers */ > + count = ARRAY_SIZE(lane_regs); > + for (i = 0; i < count; i++) { > + writel(lane_regs[i].val, pciephy->phy_base + lane_regs[i].offset); > + writel(lane_regs[i].val, pciephy->phy_base + lane_regs[i].offset + > + OFFSET_PER_LANE); > + } > + > + /* rx preset registers */ > + count = ARRAY_SIZE(rx_preset_regs); > + for (i = 0; i < count; i++) > + writel(rx_preset_regs[i].val, pciephy->phy_base + rx_preset_regs[i].offset); > +} > + > +static int artpec8_pcie_phy_init(struct phy *phy) > +{ > + struct artpec8_pcie_phy *pciephy = phy_get_drvdata(phy); > + > + /* reset init_rstn and cmn_rstn */ > + artpec8_pcie_phy_reg_update(pciephy->phy_base, > + OV_I_CMN_RSTN | OV_I_INIT_RSTN, 0, PCIE_PHY_CMN_REG101); > + > + /* reference clock selection */ > + switch (pciephy->lcpll_ref_clk) { > + case REF_CLK_FROM_XO: > + artpec8_pcie_enable_ref_clk_from_xo(pciephy); > + break; > + case REF_CLK_FROM_IO: > + artpec8_pcie_enable_ref_clk_from_io(pciephy); > + break; > + case REF_CLK_FROM_SOC_PLL: > + artpec8_pcie_enable_ref_clk_from_soc_pll(pciephy); > + break; > + default: > + break; > + } > + > + /* release i_init_rstn */ > + artpec8_pcie_phy_reg_update(pciephy->phy_base, OV_I_INIT_RSTN, > + OV_I_INIT_RSTN, PCIE_PHY_CMN_REG101); > + > + /* phy initial settings */ > + artpec8_pcie_phy_tune(pciephy); > + > + /* pll_en should be set to off when PM_STATE is P1.CPM */ > + if (!strncmp(pciephy->mode, "pcie_ep", strlen("pcie_ep"))) { > + artpec8_pcie_phy_reg_update(pciephy->pcs_base, B1_DYNAMIC, > + B1_DYNAMIC, PCIE_PCS_OUT_VEC_4); > + } > + > + /* disable lane eq ctrl rx data hold */ > + artpec8_pcie_lane_control(phy, PCIE_PHY_TRSV_REG2C0, > + LN_EQ_CTRL_RX_DATA_HOLD, 0); > + > + return 0; > +} > + > +static int artpec8_pcie_phy_exit(struct phy *phy) > +{ > + return 0; > +} > + > +static int artpec8_pcie_phy_reset(struct phy *phy) > +{ > + struct artpec8_pcie_phy *pciephy = phy_get_drvdata(phy); > + > + artpec8_pcie_phy_reg_update(pciephy->phy_base, OV_I_CMN_RSTN, > + 0, PCIE_PHY_CMN_REG101); > + udelay(10); > + artpec8_pcie_phy_reg_update(pciephy->phy_base, OV_I_CMN_RSTN, > + OV_I_CMN_RSTN, PCIE_PHY_CMN_REG101); > + > + return 0; > +} > + > +static int artpec8_pcie_phy_power_on(struct phy *phy) > +{ > + struct artpec8_pcie_phy *pciephy = phy_get_drvdata(phy); > + > + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, > + PCIE_PHY_PWR_OFF, 0); > + > + return 0; > +} > + > +static int artpec8_pcie_phy_power_off(struct phy *phy) > +{ > + struct artpec8_pcie_phy *pciephy = phy_get_drvdata(phy); > + > + regmap_update_bits(pciephy->sysreg, FSYS_PCIE_CON, > + PCIE_PHY_PWR_OFF, PCIE_PHY_PWR_OFF); > + > + return 0; > +} > + > +static int artpec8_pcie_phy_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct artpec8_pcie_phy *artpec8_phy; > + struct phy *generic_phy; > + struct phy_provider *phy_provider; > + const struct artpec8_pcie_phy_data *drv_data; > + > + drv_data = of_device_get_match_data(dev); > + if (!drv_data) > + return -ENODEV; > + > + artpec8_phy = devm_kzalloc(dev, sizeof(*artpec8_phy), GFP_KERNEL); > + if (!artpec8_phy) > + return -ENOMEM; > + > + /* reference clock */ > + if (of_property_read_u32(dev->of_node, "lcpll-ref-clk", > + &artpec8_phy->lcpll_ref_clk)) { > + return -EINVAL; > + } > + /* PLL SOC reference clock */ > + if (artpec8_phy->lcpll_ref_clk == REF_CLK_FROM_SOC_PLL) { > + artpec8_phy->soc_pll_clk = devm_clk_get(dev, "ref_clk"); > + if (IS_ERR(artpec8_phy->soc_pll_clk)) > + return -EINVAL; > + clk_prepare_enable(artpec8_phy->soc_pll_clk); > + } > + > + /* link mode */ > + if (of_property_read_string(dev->of_node, "mode", &artpec8_phy->mode)) > + return -EINVAL; > + > + /* number of lanes */ > + if (of_property_read_u32(dev->of_node, "num-lanes", > + &artpec8_phy->num_lanes)) > + return -EINVAL; > + > + if (artpec8_phy->num_lanes > LANE_MAX) > + return -EINVAL; > + > + /* PHY base register */ > + artpec8_phy->phy_base = devm_platform_ioremap_resource_byname(pdev, "phy"); > + if (IS_ERR(artpec8_phy->phy_base)) > + return PTR_ERR(artpec8_phy->phy_base); > + > + /* PCS base register */ > + artpec8_phy->pcs_base = devm_platform_ioremap_resource_byname(pdev, "pcs"); > + if (IS_ERR(artpec8_phy->pcs_base)) > + return PTR_ERR(artpec8_phy->pcs_base); > + > + /* sysreg regmap handle, need to change using smc */ > + artpec8_phy->sysreg = > + syscon_regmap_lookup_by_phandle(dev->of_node, > + "samsung,fsys-sysreg"); > + if (IS_ERR(artpec8_phy->sysreg)) > + return PTR_ERR(artpec8_phy->sysreg); > + > + artpec8_phy->drv_data = drv_data; > + > + generic_phy = devm_phy_create(dev, dev->of_node, drv_data->ops); > + if (IS_ERR(generic_phy)) > + return PTR_ERR(generic_phy); > + > + phy_set_drvdata(generic_phy, artpec8_phy); > + phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); > + > + if (IS_ERR(phy_provider)) > + return PTR_ERR(phy_provider); > + > + return 0; > +} > + > +static int __exit artpec8_pcie_remove(struct platform_device *pdev) > +{ > + struct artpec8_pcie_phy *artpec8_phy = platform_get_drvdata(pdev); > + > + if (artpec8_phy->soc_pll_clk) > + clk_disable_unprepare(artpec8_phy->soc_pll_clk); > + > + return 0; > +} > + > +static const struct phy_ops artpec8_phy_ops = { > + .init = artpec8_pcie_phy_init, > + .exit = artpec8_pcie_phy_exit, > + .reset = artpec8_pcie_phy_reset, > + .power_on = artpec8_pcie_phy_power_on, > + .power_off = artpec8_pcie_phy_power_off, > + .owner = THIS_MODULE, > +}; > + > +static const struct artpec8_pcie_phy_data artpec8_pcie_phy_data = { > + .ops = &artpec8_phy_ops, > +}; you have only _one_ ops, so why add driver data for this? > + > +static const struct of_device_id artpec8_pcie_phy_match[] = { > + { > + .compatible = "axis,artpec8-pcie-phy", > + .data = &artpec8_pcie_phy_data, > + }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, artpec8_pcie_phy_match); > + > +static struct platform_driver artpec8_pcie_phy_driver = { > + .probe = artpec8_pcie_phy_probe, > + .remove = __exit_p(artpec8_pcie_phy_remove), > + .driver = { > + .of_match_table = artpec8_pcie_phy_match, > + .name = "artpec8_pcie_phy", > + } > +}; > + > +module_platform_driver(artpec8_pcie_phy_driver); > + > +MODULE_LICENSE("GPL"); > +MODULE_AUTHOR("Jaeho Cho <jaeho79.cho@samsung.com>"); > -- > 2.9.5 -- ~Vinod ^ permalink raw reply [flat|nested] 30+ messages in thread
[parent not found: <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p6>]
* [PATCH v3 5/5] MAINTAINERS: Add Axis ARTPEC-8 PCIe PHY maintainers [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p6> @ 2022-06-14 1:36 ` Wangseok Lee 2022-06-20 7:55 ` [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller Wangseok Lee ` (2 subsequent siblings) 3 siblings, 0 replies; 30+ messages in thread From: Wangseok Lee @ 2022-06-14 1:36 UTC (permalink / raw) To: Wangseok Lee, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim Add maintainer for Axis ARTPEC-8 PCIe PHY. Add Jesper Nilsson <jesper.nilsson@axis.com> and Lars Persson <lars.persson@axis.com> as maintainer for these files. ARTPEC-8 is the SoC platform of Axis Communications and PCIe PHY is designe d based on Samsung PHY. Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 475e2836..5ad377f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1876,12 +1876,14 @@ M: Jesper Nilsson <jesper.nilsson@axis.com> M: Lars Persson <lars.persson@axis.com> L: linux-arm-kernel@axis.com S: Maintained +F: Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml F: Documentation/devicetree/bindings/pinctrl/axis,artpec6-pinctrl.txt F: arch/arm/boot/dts/artpec6* F: arch/arm/mach-artpec F: drivers/clk/axis F: drivers/crypto/axis F: drivers/mmc/host/usdhi6rol0.c +F: drivers/phy/artpec/phy-artpec* F: drivers/pinctrl/pinctrl-artpec* ARM/ASPEED I2C DRIVER -- 2.9.5 ^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p6> 2022-06-14 1:36 ` [PATCH v3 5/5] MAINTAINERS: Add Axis ARTPEC-8 PCIe PHY maintainers Wangseok Lee @ 2022-06-20 7:55 ` Wangseok Lee 2022-06-20 8:42 ` Krzysztof Kozlowski [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p2> 2022-06-29 7:18 ` Wangseok Lee 2022-07-06 8:10 ` [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver Wangseok Lee 3 siblings, 2 replies; 30+ messages in thread From: Wangseok Lee @ 2022-06-20 7:55 UTC (permalink / raw) To: Krzysztof Kozlowski, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 17/06/2022 07:54, Krzysztof Kozlowski wrote: > On 13/06/2022 18:27, Wangseok Lee wrote: >> Add description to support Axis, ARTPEC-8 SoC. >> ARTPEC-8 is the SoC platform of Axis Communications >> and PCIe controller is designed based on Design-Ware PCIe controller. >> >> Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> >> --- >> v2->v3 : >> - modify version history to fit the linux commit rule >> - remove 'Device Tree Bindings' on title >> - remove the interrupt-names, phy-names entries >> - remove '_clk' suffix >> - add the compatible entries on required >> - change node name to soc from artpec8 on examples >> >> v1->v2 : >> -'make dt_binding_check' result improvement >> -Add the missing property list >> -Align the indentation of continued lines/entries >> --- >> .../bindings/pci/axis,artpec8-pcie-ep.yaml | 109 +++++++++++++++++++ >> .../devicetree/bindings/pci/axis,artpec8-pcie.yaml | 120 +++++++++++++++++++++ >> 2 files changed, 229 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml >> create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml >> >> diff --git a/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml >> new file mode 100644 >> index 0000000..d802bba >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml >> @@ -0,0 +1,109 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: https://protect2.fireeye.com/v1/url?k=87636683-e61e8c00-8762edcc-74fe48600158-e7a1c3794076f0b9&q=1&e=35e09b7f-4fb1-4c8f-83ac-7ec33e124d44&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fpci%2Faxis%2Cartpec8-pcie-ep.yaml%23 >> +$schema: https://protect2.fireeye.com/v1/url?k=36f56c4e-578886cd-36f4e701-74fe48600158-afd7270f84937054&q=1&e=35e09b7f-4fb1-4c8f-83ac-7ec33e124d44&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 >> + >> +title: ARTPEC-8 SoC PCIe Controller >> + >> +maintainers: >> + - Jesper Nilsson <jesper.nilsson@axis.com> >> + >> +description: |+ >> + This PCIe end-point controller is based on the Synopsys DesignWare PCIe IP >> + and thus inherits all the common properties defined in snps,dw-pcie-ep.yaml. >> + >> +allOf: >> + - $ref: /schemas/pci/snps,dw-pcie-ep.yaml# >> + >> +properties: >> + compatible: >> + const: axis,artpec8-pcie-ep >> + >> + reg: >> + items: >> + - description: Data Bus Interface (DBI) registers. >> + - description: Data Bus Interface (DBI2) registers. >> + - description: PCIe address space region. >> + >> + reg-names: >> + items: >> + - const: dbi >> + - const: dbi2 >> + - const: addr_space >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + items: >> + - description: PIPE clock, used by the controller to clock the PIPE >> + - description: PCIe dbi clock, ungated version >> + - description: PCIe master clock, ungated version >> + - description: PCIe slave clock, ungated version >> + >> + clock-names: >> + items: >> + - const: pipe >> + - const: dbi >> + - const: mstr >> + - const: slv >> + >> + phys: >> + maxItems: 1 >> + >> + num-lanes: >> + const: 2 >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - interrupts >> + - interrupt-names >> + - clocks >> + - clock-names >> + - samsung,fsys-sysreg >> + - samsung,syscon-phandle >> + - samsung,syscon-bus-s-fsys >> + - samsung,syscon-bus-p-fsys > > > We are making circles... This was before and I commented already it is > wrong. You cannot have some unknown/random properties in "required:" > without describing them in "properties:". Please list all your > properties in "properties:", except the ones coming from snps > bindings/schema. > I missed that when adding new items to "required", it should also be added to "properties". I will add the following items to the property. samsung,fsys-sysreg: description: Phandle to system register of fsys block. $ref: /schemas/types.yaml#/definitions/phandle samsung,syscon-phandle: description: Phandle to the PMU system controller node. $ref: /schemas/types.yaml#/definitions/phandle samsung,syscon-bus-s-fsys: description: Phandle to bus-s path of fsys block, this register are used for enabling bus-s. $ref: /schemas/types.yaml#/definitions/phandle samsung,syscon-bus-p-fsys: description: Phandle to bus-p path of fsys block, this register are used for enabling bus-p. $ref: /schemas/types.yaml#/definitions/phandle >> + - phys >> + - num-lanes >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/interrupt-controller/irq.h> >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + pcie_ep: pcie-ep@17200000 { >> + compatible = "axis,artpec8-pcie-ep"; >> + reg = <0x0 0x17200000 0x0 0x1000>, >> + <0x0 0x17201000 0x0 0x1000>, >> + <0x2 0x00000000 0x6 0x00000000>; >> + reg-names = "dbi", "dbi2", "addr_space"; >> + #interrupt-cells = <1>; >> + interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>; >> + interrupt-names = "intr"; >> + clocks = <&clock_cmu_fsys 39>, >> + <&clock_cmu_fsys 38>, >> + <&clock_cmu_fsys 37>, >> + <&clock_cmu_fsys 36>; >> + clock-names = "pipe", "dbi", "mstr", "slv"; >> + samsung,fsys-sysreg = <&syscon_fsys>; >> + samsung,syscon-phandle = <&pmu_system_controller>; >> + samsung,syscon-bus-s-fsys = <&syscon_bus_s_fsys>; >> + samsung,syscon-bus-p-fsys = <&syscon_bus_p_fsys>; >> + phys = <&pcie_phy>; >> + phy-names = "pcie_phy"; >> + num-lanes = <2>; >> + bus-range = <0x00 0xff>; >> + num-ib-windows = <16>; >> + num-ob-windows = <16>; >> + }; >> + }; >> +... >> diff --git a/Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml >> new file mode 100644 >> index 0000000..dbbe1fd >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml >> @@ -0,0 +1,120 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: https://protect2.fireeye.com/v1/url?k=8f17d1f3-ee6a3b70-8f165abc-74fe48600158-c1db309737e1575c&q=1&e=35e09b7f-4fb1-4c8f-83ac-7ec33e124d44&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fpci%2Faxis%2Cartpec8-pcie.yaml%23 >> +$schema: https://protect2.fireeye.com/v1/url?k=50e0873f-319d6dbc-50e10c70-74fe48600158-c376ff145b3e096a&q=1&e=35e09b7f-4fb1-4c8f-83ac-7ec33e124d44&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 >> + >> +title: Artpec-8 SoC PCIe Controller >> + >> +maintainers: >> + - Jesper Nilsson <jesper.nilsson@axis.com> >> + >> +description: |+ >> + This PCIe host controller is based on the Synopsys DesignWare PCIe IP >> + and thus inherits all the common properties defined in snps,dw-pcie.yaml. >> + >> +allOf: >> + - $ref: /schemas/pci/snps,dw-pcie.yaml# >> + >> +properties: >> + compatible: >> + const: axis,artpec8-pcie >> + >> + reg: >> + items: >> + - description: Data Bus Interface (DBI) registers. >> + - description: External Local Bus interface (ELBI) registers. >> + - description: PCIe configuration space region. >> + >> + reg-names: >> + items: >> + - const: dbi >> + - const: elbi >> + - const: config >> + >> + ranges: >> + maxItems: 2 >> + >> + num-lanes: >> + const: 2 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + items: >> + - description: PIPE clock, used by the controller to clock the PIPE >> + - description: PCIe dbi clock, ungated version >> + - description: PCIe master clock, ungated version >> + - description: PCIe slave clock, ungated version >> + >> + clock-names: >> + items: >> + - const: pipe >> + - const: dbi >> + - const: mstr >> + - const: slv >> + >> + phys: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - device_type >> + - ranges >> + - num-lanes >> + - interrupts >> + - interrupt-names >> + - clocks >> + - clock-names >> + - samsung,fsys-sysreg >> + - samsung,syscon-phandle >> + - samsung,syscon-bus-s-fsys >> + - samsung,syscon-bus-p-fsys > > Same problem. > > Best regards, > Krzysztof Thank you for kindness reivew. Best regards, Wangseok Lee ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller 2022-06-20 7:55 ` [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller Wangseok Lee @ 2022-06-20 8:42 ` Krzysztof Kozlowski [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p2> 1 sibling, 0 replies; 30+ messages in thread From: Krzysztof Kozlowski @ 2022-06-20 8:42 UTC (permalink / raw) To: wangseok.lee, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 20/06/2022 09:55, Wangseok Lee wrote: > On 17/06/2022 07:54, Krzysztof Kozlowski wrote: >> On 13/06/2022 18:27, Wangseok Lee wrote: >>> Add description to support Axis, ARTPEC-8 SoC. >>> ARTPEC-8 is the SoC platform of Axis Communications >>> and PCIe controller is designed based on Design-Ware PCIe controller. >>> >>> Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> >>> --- >>> v2->v3 : >>> - modify version history to fit the linux commit rule >>> - remove 'Device Tree Bindings' on title >>> - remove the interrupt-names, phy-names entries >>> - remove '_clk' suffix >>> - add the compatible entries on required >>> - change node name to soc from artpec8 on examples >>> >>> v1->v2 : >>> -'make dt_binding_check' result improvement >>> -Add the missing property list >>> -Align the indentation of continued lines/entries >>> --- >>> .../bindings/pci/axis,artpec8-pcie-ep.yaml | 109 +++++++++++++++++++ >>> .../devicetree/bindings/pci/axis,artpec8-pcie.yaml | 120 +++++++++++++++++++++ >>> 2 files changed, 229 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml >>> create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml >>> new file mode 100644 >>> index 0000000..d802bba >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml >>> @@ -0,0 +1,109 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: https://protect2.fireeye.com/v1/url?k=87636683-e61e8c00-8762edcc-74fe48600158-e7a1c3794076f0b9&q=1&e=35e09b7f-4fb1-4c8f-83ac-7ec33e124d44&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fpci%2Faxis%2Cartpec8-pcie-ep.yaml%23 >>> +$schema: https://protect2.fireeye.com/v1/url?k=36f56c4e-578886cd-36f4e701-74fe48600158-afd7270f84937054&q=1&e=35e09b7f-4fb1-4c8f-83ac-7ec33e124d44&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 >>> + >>> +title: ARTPEC-8 SoC PCIe Controller >>> + >>> +maintainers: >>> + - Jesper Nilsson <jesper.nilsson@axis.com> >>> + >>> +description: |+ >>> + This PCIe end-point controller is based on the Synopsys DesignWare PCIe IP >>> + and thus inherits all the common properties defined in snps,dw-pcie-ep.yaml. >>> + >>> +allOf: >>> + - $ref: /schemas/pci/snps,dw-pcie-ep.yaml# >>> + >>> +properties: >>> + compatible: >>> + const: axis,artpec8-pcie-ep >>> + >>> + reg: >>> + items: >>> + - description: Data Bus Interface (DBI) registers. >>> + - description: Data Bus Interface (DBI2) registers. >>> + - description: PCIe address space region. >>> + >>> + reg-names: >>> + items: >>> + - const: dbi >>> + - const: dbi2 >>> + - const: addr_space >>> + >>> + interrupts: >>> + maxItems: 1 >>> + >>> + clocks: >>> + items: >>> + - description: PIPE clock, used by the controller to clock the PIPE >>> + - description: PCIe dbi clock, ungated version >>> + - description: PCIe master clock, ungated version >>> + - description: PCIe slave clock, ungated version >>> + >>> + clock-names: >>> + items: >>> + - const: pipe >>> + - const: dbi >>> + - const: mstr >>> + - const: slv >>> + >>> + phys: >>> + maxItems: 1 >>> + >>> + num-lanes: >>> + const: 2 >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - reg-names >>> + - interrupts >>> + - interrupt-names >>> + - clocks >>> + - clock-names >>> + - samsung,fsys-sysreg >>> + - samsung,syscon-phandle >>> + - samsung,syscon-bus-s-fsys >>> + - samsung,syscon-bus-p-fsys >> >> >> We are making circles... This was before and I commented already it is >> wrong. You cannot have some unknown/random properties in "required:" >> without describing them in "properties:". Please list all your >> properties in "properties:", except the ones coming from snps >> bindings/schema. >> > > I missed that when adding new items to "required", > it should also be added to "properties". > I will add the following items to the property. > > samsung,fsys-sysreg: > description: > Phandle to system register of fsys block. > $ref: /schemas/types.yaml#/definitions/phandle This is ok. > > samsung,syscon-phandle: > description: > Phandle to the PMU system controller node. > $ref: /schemas/types.yaml#/definitions/phandle This is ok. > > samsung,syscon-bus-s-fsys: > description: > Phandle to bus-s path of fsys block, this register > are used for enabling bus-s. > $ref: /schemas/types.yaml#/definitions/phandle > > samsung,syscon-bus-p-fsys: > description: > Phandle to bus-p path of fsys block, this register > are used for enabling bus-p. > $ref: /schemas/types.yaml#/definitions/phandle This two look unspecific and hacky workaround for missing drivers. Looks like instead of implementing interconnect or clock driver, you decided to poke some other registers. Why this cannot be an interconnect driver? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 30+ messages in thread
[parent not found: <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p2>]
* Re: [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p2> @ 2022-06-21 7:42 ` Wangseok Lee 2022-06-21 12:44 ` Krzysztof Kozlowski [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p4> 0 siblings, 2 replies; 30+ messages in thread From: Wangseok Lee @ 2022-06-21 7:42 UTC (permalink / raw) To: Krzysztof Kozlowski, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 20/06/2022 17:42, Krzysztof Kozlowski wrote: > On 20/06/2022 09:55, Wangseok Lee wrote: >> On 17/06/2022 07:54, Krzysztof Kozlowski wrote: >>> On 13/06/2022 18:27, Wangseok Lee wrote: >>>> Add description to support Axis, ARTPEC-8 SoC. >>>> ARTPEC-8 is the SoC platform of Axis Communications >>>> and PCIe controller is designed based on Design-Ware PCIe controller. >>>> >>>> Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> >>>> --- >>>> v2->v3 : >>>> - modify version history to fit the linux commit rule >>>> - remove 'Device Tree Bindings' on title >>>> - remove the interrupt-names, phy-names entries >>>> - remove '_clk' suffix >>>> - add the compatible entries on required >>>> - change node name to soc from artpec8 on examples >>>> >>>> v1->v2 : >>>> -'make dt_binding_check' result improvement >>>> -Add the missing property list >>>> -Align the indentation of continued lines/entries >>>> --- >>>> .../bindings/pci/axis,artpec8-pcie-ep.yaml | 109 +++++++++++++++++++ >>>> .../devicetree/bindings/pci/axis,artpec8-pcie.yaml | 120 +++++++++++++++++++++ >>>> 2 files changed, 229 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml >>>> create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml >>>> new file mode 100644 >>>> index 0000000..d802bba >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml >>>> @@ -0,0 +1,109 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: https://protect2.fireeye.com/v1/url?k=87636683-e61e8c00-8762edcc-74fe48600158-e7a1c3794076f0b9&q=1&e=35e09b7f-4fb1-4c8f-83ac-7ec33e124d44&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fpci%2Faxis%2Cartpec8-pcie-ep.yaml%23 >>>> +$schema: https://protect2.fireeye.com/v1/url?k=36f56c4e-578886cd-36f4e701-74fe48600158-afd7270f84937054&q=1&e=35e09b7f-4fb1-4c8f-83ac-7ec33e124d44&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 >>>> + >>>> +title: ARTPEC-8 SoC PCIe Controller >>>> + >>>> +maintainers: >>>> + - Jesper Nilsson <jesper.nilsson@axis.com> >>>> + >>>> +description: |+ >>>> + This PCIe end-point controller is based on the Synopsys DesignWare PCIe IP >>>> + and thus inherits all the common properties defined in snps,dw-pcie-ep.yaml. >>>> + >>>> +allOf: >>>> + - $ref: /schemas/pci/snps,dw-pcie-ep.yaml# >>>> + >>>> +properties: >>>> + compatible: >>>> + const: axis,artpec8-pcie-ep >>>> + >>>> + reg: >>>> + items: >>>> + - description: Data Bus Interface (DBI) registers. >>>> + - description: Data Bus Interface (DBI2) registers. >>>> + - description: PCIe address space region. >>>> + >>>> + reg-names: >>>> + items: >>>> + - const: dbi >>>> + - const: dbi2 >>>> + - const: addr_space >>>> + >>>> + interrupts: >>>> + maxItems: 1 >>>> + >>>> + clocks: >>>> + items: >>>> + - description: PIPE clock, used by the controller to clock the PIPE >>>> + - description: PCIe dbi clock, ungated version >>>> + - description: PCIe master clock, ungated version >>>> + - description: PCIe slave clock, ungated version >>>> + >>>> + clock-names: >>>> + items: >>>> + - const: pipe >>>> + - const: dbi >>>> + - const: mstr >>>> + - const: slv >>>> + >>>> + phys: >>>> + maxItems: 1 >>>> + >>>> + num-lanes: >>>> + const: 2 >>>> + >>>> +required: >>>> + - compatible >>>> + - reg >>>> + - reg-names >>>> + - interrupts >>>> + - interrupt-names >>>> + - clocks >>>> + - clock-names >>>> + - samsung,fsys-sysreg >>>> + - samsung,syscon-phandle >>>> + - samsung,syscon-bus-s-fsys >>>> + - samsung,syscon-bus-p-fsys >>> >>> >>> We are making circles... This was before and I commented already it is >>> wrong. You cannot have some unknown/random properties in "required:" >>> without describing them in "properties:". Please list all your >>> properties in "properties:", except the ones coming from snps >>> bindings/schema. >>> >> >> I missed that when adding new items to "required", >> it should also be added to "properties". >> I will add the following items to the property. >> >> samsung,fsys-sysreg: >> description: >> Phandle to system register of fsys block. >> $ref: /schemas/types.yaml#/definitions/phandle > > This is ok. > >> >> samsung,syscon-phandle: >> description: >> Phandle to the PMU system controller node. >> $ref: /schemas/types.yaml#/definitions/phandle > > This is ok. > >> >> samsung,syscon-bus-s-fsys: >> description: >> Phandle to bus-s path of fsys block, this register >> are used for enabling bus-s. >> $ref: /schemas/types.yaml#/definitions/phandle >> >> samsung,syscon-bus-p-fsys: >> description: >> Phandle to bus-p path of fsys block, this register >> are used for enabling bus-p. >> $ref: /schemas/types.yaml#/definitions/phandle > > This two look unspecific and hacky workaround for missing drivers. Looks > like instead of implementing interconnect or clock driver, you decided > to poke some other registers. Why this cannot be an interconnect driver? > > bus-s, bus-p is a register that exists in the sysreg of the fsys block. It is the same block as "fsys-sysreg" but is separated separately in hardware. So, get resource is performed separately from "fsys-sysreg". They set pcie slave, dbi related control settings, naming "bus-x" seems to be interconnect. I will add this description to property. I don't think it need to use the interconnect driver, so please let me know your opinion. > Best regards, > Krzysztof Thank you for kindness reivew. Best regards, Wangseok Lee ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller 2022-06-21 7:42 ` Wangseok Lee @ 2022-06-21 12:44 ` Krzysztof Kozlowski [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p4> 1 sibling, 0 replies; 30+ messages in thread From: Krzysztof Kozlowski @ 2022-06-21 12:44 UTC (permalink / raw) To: wangseok.lee, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 21/06/2022 09:42, Wangseok Lee wrote: >>> >>> samsung,syscon-bus-s-fsys: >>> description: >>> Phandle to bus-s path of fsys block, this register >>> are used for enabling bus-s. >>> $ref: /schemas/types.yaml#/definitions/phandle >>> >>> samsung,syscon-bus-p-fsys: >>> description: >>> Phandle to bus-p path of fsys block, this register >>> are used for enabling bus-p. >>> $ref: /schemas/types.yaml#/definitions/phandle >> >> This two look unspecific and hacky workaround for missing drivers. Looks >> like instead of implementing interconnect or clock driver, you decided >> to poke some other registers. Why this cannot be an interconnect driver? >> >> > > bus-s, bus-p is a register that exists in the sysreg of the fsys block. > It is the same block as "fsys-sysreg" but is separated separately in > hardware. Two points here: 1. If it is in FSYS, why it cannot be accessed with samsung,fsys-sysreg? 2. If it is only register, shuld be described like this. You must describe item: https://elixir.bootlin.com/linux/v5.18-rc1/source/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml#L42 > So, get resource is performed separately from "fsys-sysreg". > They set pcie slave, dbi related control settings, > naming "bus-x" seems to be interconnect. > I will add this description to property. > I don't think it need to use the interconnect driver, > so please let me know your opinion. Please document both in the bindings and in the driver usage of this register. Writing there "0" or "1" is not enough. If the documentation is good, I am fine with it. If the explanation is obfuscated/not sufficient, it will look like avoiding to implement a driver, which I don't want to accept. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 30+ messages in thread
[parent not found: <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p4>]
* Re: [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p4> @ 2022-06-22 7:20 ` Wangseok Lee 2022-07-06 5:22 ` [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy Wangseok Lee 1 sibling, 0 replies; 30+ messages in thread From: Wangseok Lee @ 2022-06-22 7:20 UTC (permalink / raw) To: Krzysztof Kozlowski, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 21/06/2022 21:44, Krzysztof Kozlowski wrote: > On 21/06/2022 09:42, Wangseok Lee wrote: >>>> >>>> samsung,syscon-bus-s-fsys: >>>> description: >>>> Phandle to bus-s path of fsys block, this register >>>> are used for enabling bus-s. >>>> $ref: /schemas/types.yaml#/definitions/phandle >>>> >>>> samsung,syscon-bus-p-fsys: >>>> description: >>>> Phandle to bus-p path of fsys block, this register >>>> are used for enabling bus-p. >>>> $ref: /schemas/types.yaml#/definitions/phandle >>> >>> This two look unspecific and hacky workaround for missing drivers. Looks >>> like instead of implementing interconnect or clock driver, you decided >>> to poke some other registers. Why this cannot be an interconnect driver? >>> >>> >> >> bus-s, bus-p is a register that exists in the sysreg of the fsys block. >> It is the same block as "fsys-sysreg" but is separated separately in >> hardware. > > Two points here: > 1. If it is in FSYS, why it cannot be accessed with samsung,fsys-sysreg? > 2. If it is only register, shuld be described like this. You must > describe item: > https://protect2.fireeye.com/v1/url?k=0f529a57-50c9a332-0f531118-000babff32e3-50938d8198077d59&q=1&e=32284e69-bbed-4d09-b6d6-0a43428aebf5&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv5.18-rc1%2Fsource%2FDocumentation%2Fdevicetree%2Fbindings%2Fsoc%2Fsamsung%2Fexynos-usi.yaml%23L42 > It would be better to access with fsys-sysreg, but their h/w address are far from each other. The fsys block consists of a system register and an additional control system register. "bus-s-fsys" and "bus-p-fsys" are additional control system register. sysreg and additional control sysreg addresses are far from each other and there are h/w registers that perform different functions between them. >> So, get resource is performed separately from "fsys-sysreg". >> They set pcie slave, dbi related control settings, >> naming "bus-x" seems to be interconnect. >> I will add this description to property. >> I don't think it need to use the interconnect driver, >> so please let me know your opinion. > > Please document both in the bindings and in the driver usage of this > register. Writing there "0" or "1" is not enough. If the documentation > is good, I am fine with it. If the explanation is obfuscated/not > sufficient, it will look like avoiding to implement a driver, which I > don't want to accept. > I think i should add enough description. Is it sufficient to modify the name and description of property like this? samsung,fsys-bus-s: description: Phandle to bus-s of fsys block, this register is additional control sysreg in fsys block and this is used for pcie slave control setting. $ref: /schemas/types.yaml#/definitions/phandle samsung,fsys-bus-p: description: Phandle to bus-p of fsys block, this register is additional control sysreg in fsys block and this is used for pcie dbi control setting. $ref: /schemas/types.yaml#/definitions/phandle > Best regards, > Krzysztof Thank you for kindness reivew. Best regards, Wangseok Lee ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p4> 2022-06-22 7:20 ` Wangseok Lee @ 2022-07-06 5:22 ` Wangseok Lee 2022-07-06 6:28 ` Krzysztof Kozlowski 1 sibling, 1 reply; 30+ messages in thread From: Wangseok Lee @ 2022-07-06 5:22 UTC (permalink / raw) To: Krzysztof Kozlowski, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 05/07/2022 19:59, Krzysztof Kozlowski wrote: > On 29/06/2022 09:18, Wangseok Lee wrote: >> Just a gentle ping for this patch, if any concern on this patch please let me know. >> > > You received comments to fix in this patch. Exactly four. Four important > points to fix. Therefore what is this ping about? > > Without fixing these items, your patch cannot be accepted. What is more > to ping here? > > Best regards, > Krzysztof I tried to receive your opinion about the fix point . I will request a review again after modifying it in the next patch. Thank you. >>> + >>> + clocks: >>> + items: >>> + - description: PCIe PHY reference clock > > refer to sample-schema.yaml, even if the clock item is single, > it seems to be used as follows. > > clocks: > maxItems: 1 > > clock-names: > items: > - const: ref > > If only "clocks:" are define and clock-names are not define, > the following warning occurs. > "'clock-names' does not match any of the regexes" > >>> + >>> + lcpll-ref-clk: >>> + const: 1 >> >> Unknown field... custom properties need vendor (axis,), type (boolean) >> and description. >> > > "lcpl-ref-clk" has an enum type value, so i will modify it as below. > > > axis,lcpll-ref-clk: > description: > select the reference clock of phy and initialization is performed > with the reference clock according to the selected value. > $ref: /schemas/types.yaml#/definitions/uint32 > enum: [ 0, 1, 2, 3, 4 ] > ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy 2022-07-06 5:22 ` [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy Wangseok Lee @ 2022-07-06 6:28 ` Krzysztof Kozlowski 0 siblings, 0 replies; 30+ messages in thread From: Krzysztof Kozlowski @ 2022-07-06 6:28 UTC (permalink / raw) To: wangseok.lee Cc: robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel, Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On Wed, 6 Jul 2022 at 07:22, Wangseok Lee <wangseok.lee@samsung.com> wrote: > > On 05/07/2022 19:59, Krzysztof Kozlowski wrote: > > On 29/06/2022 09:18, Wangseok Lee wrote: > >> Just a gentle ping for this patch, if any concern on this patch please let me know. > >> > > > > You received comments to fix in this patch. Exactly four. Four important > > points to fix. Therefore what is this ping about? > > > > Without fixing these items, your patch cannot be accepted. What is more > > to ping here? > > > > Best regards, > > Krzysztof > > I tried to receive your opinion about the fix point . > I will request a review again after modifying it in the next patch. But there was no quote about any fix point in your message. You replied on top of it so there was no reference to any previous topic. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p6> 2022-06-14 1:36 ` [PATCH v3 5/5] MAINTAINERS: Add Axis ARTPEC-8 PCIe PHY maintainers Wangseok Lee 2022-06-20 7:55 ` [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller Wangseok Lee @ 2022-06-29 7:18 ` Wangseok Lee 2022-07-05 10:56 ` Krzysztof Kozlowski 2022-07-06 8:10 ` [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver Wangseok Lee 3 siblings, 1 reply; 30+ messages in thread From: Wangseok Lee @ 2022-06-29 7:18 UTC (permalink / raw) To: Krzysztof Kozlowski, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim Just a gentle ping for this patch, if any concern on this patch please let me know. On 20/06/2022 17:38, Wangseok Lee wrote: > On 17/06/2022 07:59, Krzysztof Kozlowski wrote: >> On 13/06/2022 18:29, Wangseok Lee wrote: >>> Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> >>> --- >>> v2->v3 : >>> -modify version history to fit the linux commit rule >>> -remove 'Device Tree Bindings' on title >>> -remove clock-names entries >>> -change node name to soc from artpec8 on excamples >>> >>> v1->v2 : >>> -'make dt_binding_check' result improvement >>> -Add the missing property list >>> -Align the indentation of continued lines/entries >>> --- >>> .../bindings/phy/axis,artpec8-pcie-phy.yaml | 73 ++++++++++++++++++++++ >>> 1 file changed, 73 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml >>> new file mode 100644 >>> index 0000000..316b774 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml >>> @@ -0,0 +1,73 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id: https://protect2.fireeye.com/v1/url?k=84f6a8c0-e57dbdd9-84f7238f-74fe485cbfec-e81bd79bfd1ff442&q=1&e=6739af06-730c-48db-aef8-026a9aaee1b4&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fphy%2Faxis%2Cartpec8-pcie-phy.yaml%23 >>> +$schema: https://protect2.fireeye.com/v1/url?k=b4f1a4ba-d57ab1a3-b4f02ff5-74fe485cbfec-7f885cbe82dc7860&q=1&e=6739af06-730c-48db-aef8-026a9aaee1b4&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 >>> + >>> +title: ARTPEC-8 SoC PCIe PHY >>> + >>> +maintainers: >>> + - Jesper Nilsson <jesper.nilsson@axis.com> >>> + >>> +properties: >>> + compatible: >>> + const: axis,artpec8-pcie-phy >>> + >>> + reg: >>> + items: >>> + - description: PHY registers. >>> + - description: PHY coding sublayer registers. >>> + >>> + reg-names: >>> + items: >>> + - const: phy >>> + - const: pcs >>> + >>> + "#phy-cells": >>> + const: 0 >>> + >>> + clocks: >>> + items: >>> + - description: PCIe PHY reference clock > > refer to sample-schema.yaml, even if the clock item is single, > it seems to be used as follows. > > clocks: > maxItems: 1 > > clock-names: > items: > - const: ref > > If only "clocks:" are define and clock-names are not define, > the following warning occurs. > "'clock-names' does not match any of the regexes" > >>> + >>> + num-lanes: >>> + const: 2 >>> + >>> + lcpll-ref-clk: >>> + const: 1 >> >> Unknown field... custom properties need vendor (axis,), type (boolean) >> and description. >> > > "lcpl-ref-clk" has an enum type value, so i will modify it as below. > > > axis,lcpll-ref-clk: > description: > select the reference clock of phy and initialization is performed > with the reference clock according to the selected value. > $ref: /schemas/types.yaml#/definitions/uint32 > enum: [ 0, 1, 2, 3, 4 ] > >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - reg-names >>> + - "#phy-cells" >>> + - clocks >>> + - clock-names >>> + - samsung,fsys-sysreg >> >> Same problem as in patch #1. >> > > I will add the following items to the property. > > samsung,fsys-sysreg: > description: > Phandle to system register of fsys block. > $ref: /schemas/types.yaml#/definitions/phandle > >>> + - num-lanes >>> + - lcpll-ref-clk >>> + >>> +additionalProperties: true >> >> No, this must be false. >> > > yes, i miss it. I will fix this. > >> Best regards, >> Krzysztof > > Thank you for kindness reivew. > > Best regards, > Wangseok Lee ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy 2022-06-29 7:18 ` Wangseok Lee @ 2022-07-05 10:56 ` Krzysztof Kozlowski 0 siblings, 0 replies; 30+ messages in thread From: Krzysztof Kozlowski @ 2022-07-05 10:56 UTC (permalink / raw) To: wangseok.lee, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 29/06/2022 09:18, Wangseok Lee wrote: > Just a gentle ping for this patch, if any concern on this patch please let me know. > You received comments to fix in this patch. Exactly four. Four important points to fix. Therefore what is this ping about? Without fixing these items, your patch cannot be accepted. What is more to ping here? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p6> ` (2 preceding siblings ...) 2022-06-29 7:18 ` Wangseok Lee @ 2022-07-06 8:10 ` Wangseok Lee 2022-07-06 16:51 ` Vinod Koul 3 siblings, 1 reply; 30+ messages in thread From: Wangseok Lee @ 2022-07-06 8:10 UTC (permalink / raw) To: Vinod Koul Cc: robh+dt, krzk+dt, kishon, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel, Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 05-07-22, 15:30, Vinod Koul wrote: > On 14-06-22, 10:34, Wangseok Lee wrote: >> Add support Axis, ARTPEC-8 SoC. >> ARTPEC-8 is the SoC platform of Axis Communications. >> This is based on arm64 and support GEN4 & 2lane. >> This driver provides PHY interface for ARTPEC-8 SoC PCIe controller, >> based on Samsung PCIe PHY IP. >> >> Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> >> Signed-off-by: Jaeho Cho <jaeho79.cho@samsung.com> >> --- >> v2->v3 : >> -remove unnecessary indentation >> -redefine local struct to statis const >> -add static const to struct that requires static const definition >> -remove wrappers on writel and readl >> >> v1->v2 : >> -change folder name of phy driver to axis from artpec >> --- >> drivers/phy/Kconfig | 1 + >> drivers/phy/Makefile | 1 + >> drivers/phy/axis/Kconfig | 9 + >> drivers/phy/axis/Makefile | 2 + >> drivers/phy/axis/phy-artpec8-pcie.c | 776 ++++++++++++++++++++++++++++++++++++ >> 5 files changed, 789 insertions(+) >> create mode 100644 drivers/phy/axis/Kconfig >> create mode 100644 drivers/phy/axis/Makefile >> create mode 100644 drivers/phy/axis/phy-artpec8-pcie.c >> >> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >> index 300b0f2..92b8232 100644 >> --- a/drivers/phy/Kconfig >> +++ b/drivers/phy/Kconfig >> @@ -73,6 +73,7 @@ config PHY_CAN_TRANSCEIVER >> >> source "drivers/phy/allwinner/Kconfig" >> source "drivers/phy/amlogic/Kconfig" >> +source "drivers/phy/axis/Kconfig" >> source "drivers/phy/broadcom/Kconfig" >> source "drivers/phy/cadence/Kconfig" >> source "drivers/phy/freescale/Kconfig" >> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile >> index 01e9eff..808c055e 100644 >> --- a/drivers/phy/Makefile >> +++ b/drivers/phy/Makefile >> @@ -12,6 +12,7 @@ obj-$(CONFIG_PHY_PISTACHIO_USB) += phy-pistachio-usb.o >> obj-$(CONFIG_USB_LGM_PHY) += phy-lgm-usb.o >> obj-y += allwinner/ \ >> amlogic/ \ >> + axis/ \ >> broadcom/ \ >> cadence/ \ >> freescale/ \ >> diff --git a/drivers/phy/axis/Kconfig b/drivers/phy/axis/Kconfig >> new file mode 100644 >> index 0000000..7198b93 >> --- /dev/null >> +++ b/drivers/phy/axis/Kconfig >> @@ -0,0 +1,9 @@ >> +config PHY_ARTPEC8_PCIE >> + bool "ARTPEC-8 PCIe PHY driver" >> + depends on OF && (ARCH_ARTPEC8 || COMPILE_TEST) >> + select GENERIC_PHY >> + help >> + Enable PCIe PHY support for ARTPEC-8 SoC. >> + This driver provides PHY interface for ARTPEC-8 SoC >> + PCIe controller. >> + This is based on Samsung PCIe PHY IP. > > How different is it from SS IP and why should it not be under > phy/samsung/ then? > SoC platform is completely different from exynos platform and different from exynos PCIe PHY. So the overall sysreg configuration is different and register map is also different. The reset method and type of PHY for initialization are different. This is not a driver that supports Samsung SoC platform, but this PHY driver that supports only Axis, Artpec-8 platforms, so it is not added to phy/samsung. >> diff --git a/drivers/phy/axis/Makefile b/drivers/phy/axis/Makefile >> new file mode 100644 >> index 0000000..45d853c >> --- /dev/null >> +++ b/drivers/phy/axis/Makefile >> @@ -0,0 +1,2 @@ >> +# SPDX-License-Identifier: GPL-2.0 >> +obj-$(CONFIG_PHY_ARTPEC8_PCIE) += phy-artpec8-pcie.o >> diff --git a/drivers/phy/axis/phy-artpec8-pcie.c b/drivers/phy/axis/phy-artpec8-pcie.c >> new file mode 100644 >> index 0000000..d21867b >> --- /dev/null >> +++ b/drivers/phy/axis/phy-artpec8-pcie.c >> @@ -0,0 +1,776 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * PHY provider for ARTPEC-8 PCIe controller >> + * >> + * Copyright (C) 2019 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * Author: Jaeho Cho <jaeho79.cho@samsung.com> >> + */ >> + >> +#include <linux/clk.h> >> +#include <linux/io.h> >> +#include <linux/init.h> >> +#include <linux/mfd/syscon.h> >> +#include <linux/module.h> >> +#include <linux/of.h> >> +#include <linux/of_address.h> >> +#include <linux/of_platform.h> >> +#include <linux/platform_device.h> >> +#include <linux/phy/phy.h> >> +#include <linux/regmap.h> >> +#include <linux/debugfs.h> >> + >> +/* ARTPEC-8 PCIe PHY registers */ >> +/* CMN registers */ >> +#define PCIE_PHY_CMN_REG004 0x10 >> +#define PCIE_PHY_CMN_REG00B 0x2C >> +#define PCIE_PHY_CMN_REG016 0x58 >> +#define PCIE_PHY_CMN_REG01C 0x70 >> +#define PCIE_PHY_CMN_REG021 0x84 >> +#define PCIE_PHY_CMN_REG024 0x90 >> +#define PCIE_PHY_CMN_REG025 0x94 >> +#define PCIE_PHY_CMN_REG0E6 0x398 >> +#define PCIE_PHY_CMN_REG0E7 0x39C >> +#define PCIE_PHY_CMN_REG0E8 0x3A0 >> +#define PCIE_PHY_CMN_REG0E9 0x3A4 >> +#define PCIE_PHY_CMN_REG0EA 0x3A8 >> +#define PCIE_PHY_CMN_REG0EB 0x3AC >> +#define PCIE_PHY_CMN_REG0EC 0x3B0 >> +#define PCIE_PHY_CMN_REG0EE 0x3B8 >> +#define PCIE_PHY_CMN_REG0EF 0x3BC >> +#define PCIE_PHY_CMN_REG0F1 0x3C4 >> +#define PCIE_PHY_CMN_REG0F3 0x3CC >> +#define PCIE_PHY_CMN_REG0F4 0x3D0 >> + >> +#define PCIE_PHY_CMN_REG101 0x404 >> +#define OV_I_CMN_RSTN BIT(4) >> +#define OV_I_INIT_RSTN BIT(6) >> + >> +#define PCIE_PHY_CMN_REG131 0x4C4 >> +#define PCIE_PHY_CMN_REG17B 0x5EC >> +#define PCIE_PHY_CMN_REG17D 0x5F4 >> +#define PCIE_PHY_CMN_REG190 0x640 >> +#define PCIE_PHY_CMN_REG191 0x644 >> +#define PCIE_PHY_CMN_REG192 0x648 >> +#define PCIE_PHY_CMN_REG1C7 0x71C >> +#define PCIE_PHY_CMN_REG1DF 0x77C >> +#define PCIE_PHY_CMN_REG1E0 0x780 >> + >> +#define PCIE_PHY_CMN_REG0B1 0x2C4 >> +#define ANA_ROPLL_REF_DIG_CLK_SEL BIT(2) >> + >> +/* External clock */ >> +#define PCIE_PHY_CMN_REG14D 0x534 >> +#define PCIE_AUX_RX_MODE_EXTEND BIT(7) >> + >> +#define PCIE_PHY_CMN_REG0D9 0x364 >> +#define ANA_AUX_EXT_REF_CLK_SEL BIT(4) >> + >> +#define PCIE_PHY_CMN_REG10F 0x43C >> +#define AUX_PLL_EN_EXTEND BIT(4) >> + >> +#define PCIE_PHY_CMN_REG11E 0x478 >> +#define AUX2_PLL_EN_EXTEND BIT(3) >> + >> +#define PCIE_PHY_CMN_REG0D4 0x350 >> +#define OV_S_ANA_AUX_EN BIT(3) >> +#define OV_I_ANA_AUX_EN BIT(2) >> + >> +/* LANE registers */ >> +#define PCIE_PHY_TRSV_REG22D 0x8B4 >> +#define PCIE_PHY_TRSV_REG23E 0x8F8 >> +#define PCIE_PHY_TRSV_REG2A5 0xA94 >> +#define PCIE_PHY_TRSV_REG3E3 0xF8C >> +#define PCIE_PHY_TRSV_REG3ED 0xFB4 >> +#define PCIE_PHY_TRSV_REG20B 0x82C >> +#define PCIE_PHY_TRSV_REG20C 0x830 >> +#define PCIE_PHY_TRSV_REG234 0x8D0 >> +#define PCIE_PHY_TRSV_REG235 0x8D4 >> +#define PCIE_PHY_TRSV_REG237 0x8DC >> +#define PCIE_PHY_TRSV_REG239 0x8E4 >> +#define PCIE_PHY_TRSV_REG23A 0x8E8 >> +#define PCIE_PHY_TRSV_REG23B 0x8EC >> +#define PCIE_PHY_TRSV_REG24B 0x92C >> +#define PCIE_PHY_TRSV_REG25D 0x974 >> +#define PCIE_PHY_TRSV_REG262 0x988 >> +#define PCIE_PHY_TRSV_REG271 0x9C4 >> +#define PCIE_PHY_TRSV_REG272 0x9C8 >> +#define PCIE_PHY_TRSV_REG27C 0x9F0 >> +#define PCIE_PHY_TRSV_REG27D 0x9F4 >> +#define PCIE_PHY_TRSV_REG27E 0x9F8 >> +#define PCIE_PHY_TRSV_REG284 0xA10 >> +#define PCIE_PHY_TRSV_REG289 0xA24 >> +#define PCIE_PHY_TRSV_REG28A 0xA28 >> +#define PCIE_PHY_TRSV_REG28B 0xA2C >> +#define PCIE_PHY_TRSV_REG28C 0xA30 >> +#define PCIE_PHY_TRSV_REG28E 0xA38 >> +#define PCIE_PHY_TRSV_REG28F 0xA3C >> +#define PCIE_PHY_TRSV_REG290 0xA40 >> +#define PCIE_PHY_TRSV_REG291 0xA44 >> +#define PCIE_PHY_TRSV_REG292 0xA48 >> +#define PCIE_PHY_TRSV_REG294 0xA50 >> +#define PCIE_PHY_TRSV_REG295 0xA54 >> +#define PCIE_PHY_TRSV_REG296 0xA58 >> +#define PCIE_PHY_TRSV_REG297 0xA5C >> +#define PCIE_PHY_TRSV_REG298 0xA60 >> +#define PCIE_PHY_TRSV_REG29B 0xA6C >> +#define PCIE_PHY_TRSV_REG29C 0xA70 >> +#define PCIE_PHY_TRSV_REG29D 0xA74 >> +#define PCIE_PHY_TRSV_REG29E 0xA78 >> +#define PCIE_PHY_TRSV_REG2AA 0xAA8 >> +#define PCIE_PHY_TRSV_REG2AE 0xAB8 >> +#define PCIE_PHY_TRSV_REG2C2 0xB08 >> +#define PCIE_PHY_TRSV_REG2C6 0xB18 >> +#define PCIE_PHY_TRSV_REG2C7 0xB1C >> +#define PCIE_PHY_TRSV_REG2CB 0xB2C >> +#define PCIE_PHY_TRSV_REG2CC 0xB30 >> +#define PCIE_PHY_TRSV_REG2CD 0xB34 >> +#define PCIE_PHY_TRSV_REG2CE 0xB38 >> +#define PCIE_PHY_TRSV_REG2D0 0xB40 >> +#define PCIE_PHY_TRSV_REG2CF 0xB3C >> +#define PCIE_PHY_TRSV_REG2E0 0xB80 >> +#define PCIE_PHY_TRSV_REG2E9 0xBA4 >> +#define PCIE_PHY_TRSV_REG2EA 0xBA8 >> +#define PCIE_PHY_TRSV_REG2EB 0xBAC >> +#define PCIE_PHY_TRSV_REG315 0xC54 >> +#define PCIE_PHY_TRSV_REG317 0xC5C >> +#define PCIE_PHY_TRSV_REG319 0xC64 >> +#define PCIE_PHY_TRSV_REG364 0xD90 >> +#define PCIE_PHY_TRSV_REG36C 0xDB0 >> +#define PCIE_PHY_TRSV_REG36D 0xDB4 >> +#define PCIE_PHY_TRSV_REG37E 0xDF8 >> +#define PCIE_PHY_TRSV_REG37F 0xDFC >> +#define PCIE_PHY_TRSV_REG38F 0xE3C >> +#define PCIE_PHY_TRSV_REG391 0xE44 >> +#define PCIE_PHY_TRSV_REG39C 0xE70 >> +#define PCIE_PHY_TRSV_REG3A8 0xEA0 >> +#define PCIE_PHY_TRSV_REG3E0 0xF80 >> +#define PCIE_PHY_TRSV_REG3E1 0xF84 >> +#define PCIE_PHY_TRSV_REG3E7 0xF9C >> +#define PCIE_PHY_TRSV_REG3E9 0xFA4 >> +#define PCIE_PHY_TRSV_REG3EA 0xFA8 >> +#define PCIE_PHY_TRSV_REG3EE 0xFB8 >> +#define PCIE_PHY_TRSV_REG3EF 0xFBC >> +#define PCIE_PHY_TRSV_REG3F0 0xFC0 >> + >> +#define PCIE_PHY_TRSV_REG2C0 0xB00 >> +#define LN_EQ_CTRL_RX_DATA_HOLD BIT(5) >> + >> +/* RX Preset registers */ >> +#define PCIE_PHY_CMN_REG17E 0x5F8 >> +#define PCIE_PHY_CMN_REG180 0x600 >> +#define PCIE_PHY_CMN_REG181 0x604 >> +#define PCIE_PHY_CMN_REG182 0x608 >> +#define PCIE_PHY_CMN_REG183 0x60C >> +#define PCIE_PHY_CMN_REG184 0x610 >> +#define PCIE_PHY_CMN_REG185 0x614 >> +#define PCIE_PHY_CMN_REG186 0x618 >> +#define PCIE_PHY_CMN_REG187 0x61C >> + >> + >> +/* ARTPEC-8 PCIe PCS registers */ >> +#define PCIE_PCS_OUT_VEC_4 0x154 >> +#define B1_DYNAMIC BIT(3) >> + >> +/* ARTPEC-8 SYS REG registers */ >> +#define FSYS_PCIE_CON 0x424 >> +#define PCIE_PHY_LCPLL_REFCLK_SEL 0x3 >> +#define PCIE_PHY_ROPLL_REFCLK_SEL (0x3UL << 2) >> +#define ROPLL_REFCLK_NOT_AVAILABLE (0x2UL << 2) > > Pls use GENMASK for this > Ok, i will fix it. >> +#define PCIE_PHY_LN0_REFCLK_PAD_EN BIT(10) >> +#define PCIE_PHY_LN1_REFCLK_PAD_EN BIT(11) >> +#define PCIE_PHY_PWR_OFF BIT(7) >> + >> +/* ARTPEC-8 Sub Controller registers */ >> +#define SFR_INIT_RSTN 0x1404 >> +#define SFR_CMN_RSTN 0x1408 >> + >> +#define PCIE_PHY_LN0_REG_START 0x800 >> +#define PCIE_PHY_LN0_REG_END 0xFCC >> +#define OFFSET_PER_LANE 0x800 >> + >> +enum artpec8_pcie_phy_num_lanes { >> + LANE0 = 0, >> + LANE1, >> + LANE_MAX >> +}; >> + >> +struct artpec8_pcie_phy_data { >> + const struct phy_ops *ops; >> +}; >> + >> +struct artpec8_pcie_phy { >> + const struct artpec8_pcie_phy_data *drv_data; >> + void __iomem *phy_base; >> + void __iomem *pcs_base; >> + void __iomem *elbi_base; >> + struct clk *soc_pll_clk; >> + struct regmap *sysreg; >> + u32 lcpll_ref_clk; >> + const char *mode; >> + u32 num_lanes; >> +}; >> + >> +enum artpec8_pcie_ref_clk { >> + REF_CLK_FROM_XO = 0, >> + REF_CLK_FROM_IO, >> + REF_CLK_RESERVED, >> + REF_CLK_FROM_SOC_PLL, >> + REF_CLK_MAX >> +}; >> + >> +struct artpec8_pcie_phy_tune_reg { >> + u32 offset; >> + u32 val; >> +}; >> + >> +/* ARTPEC-8 PCIe Gen4 x2 PHY CMN register settings */ >> +static const struct artpec8_pcie_phy_tune_reg cmn_regs[] = { >> + {PCIE_PHY_CMN_REG004, 0x65}, >> + {PCIE_PHY_CMN_REG00B, 0x18}, >> + {PCIE_PHY_CMN_REG016, 0x0E}, >> + {PCIE_PHY_CMN_REG01C, 0x4F}, >> + {PCIE_PHY_CMN_REG021, 0x01}, >> + {PCIE_PHY_CMN_REG024, 0x58}, >> + {PCIE_PHY_CMN_REG025, 0x98}, >> + {PCIE_PHY_CMN_REG0E6, 0x00}, >> + {PCIE_PHY_CMN_REG0E7, 0x00}, >> + {PCIE_PHY_CMN_REG0E8, 0x3F}, >> + {PCIE_PHY_CMN_REG0E9, 0x3F}, >> + {PCIE_PHY_CMN_REG0EA, 0xFF}, >> + {PCIE_PHY_CMN_REG0EB, 0xFF}, >> + {PCIE_PHY_CMN_REG0EC, 0x42}, >> + {PCIE_PHY_CMN_REG0EE, 0x3F}, >> + {PCIE_PHY_CMN_REG0EF, 0x7F}, >> + {PCIE_PHY_CMN_REG0F1, 0x02}, >> + {PCIE_PHY_CMN_REG0F3, 0xFF}, >> + {PCIE_PHY_CMN_REG0F4, 0xFF}, >> + {PCIE_PHY_CMN_REG131, 0x01}, >> + {PCIE_PHY_CMN_REG17B, 0xC0}, >> + {PCIE_PHY_CMN_REG17D, 0xAF}, >> + {PCIE_PHY_CMN_REG190, 0x27}, >> + {PCIE_PHY_CMN_REG191, 0x0F}, >> + {PCIE_PHY_CMN_REG192, 0x3F}, >> + {PCIE_PHY_CMN_REG1C7, 0x05}, >> + {PCIE_PHY_CMN_REG1DF, 0x28}, >> + {PCIE_PHY_CMN_REG1E0, 0x28}, >> +}; >> + >> +/* ARTPEC-8 PCIe Gen4 x2 PHY lane register settings */ >> +static const struct artpec8_pcie_phy_tune_reg lane_regs[] = { >> + {PCIE_PHY_TRSV_REG22D, 0x00}, >> + {PCIE_PHY_TRSV_REG23E, 0x00}, >> + {PCIE_PHY_TRSV_REG2A5, 0x73}, >> + {PCIE_PHY_TRSV_REG3E3, 0x7B}, >> + {PCIE_PHY_TRSV_REG3ED, 0x4B}, >> + {PCIE_PHY_TRSV_REG20B, 0x02}, >> + {PCIE_PHY_TRSV_REG20C, 0xEA}, >> + {PCIE_PHY_TRSV_REG234, 0x7A}, >> + {PCIE_PHY_TRSV_REG235, 0x1C}, >> + {PCIE_PHY_TRSV_REG237, 0x10}, >> + {PCIE_PHY_TRSV_REG239, 0x68}, >> + {PCIE_PHY_TRSV_REG23A, 0xC0}, >> + {PCIE_PHY_TRSV_REG23B, 0x0B}, >> + {PCIE_PHY_TRSV_REG24B, 0x00}, >> + {PCIE_PHY_TRSV_REG25D, 0x07}, >> + {PCIE_PHY_TRSV_REG262, 0x07}, >> + {PCIE_PHY_TRSV_REG271, 0x23}, >> + {PCIE_PHY_TRSV_REG272, 0x5E}, >> + {PCIE_PHY_TRSV_REG27C, 0x8C}, >> + {PCIE_PHY_TRSV_REG27D, 0x5B}, >> + {PCIE_PHY_TRSV_REG27E, 0x2C}, >> + {PCIE_PHY_TRSV_REG284, 0x33}, >> + {PCIE_PHY_TRSV_REG289, 0xD4}, >> + {PCIE_PHY_TRSV_REG28A, 0xCC}, >> + {PCIE_PHY_TRSV_REG28B, 0xD9}, >> + {PCIE_PHY_TRSV_REG28C, 0xDC}, >> + {PCIE_PHY_TRSV_REG28E, 0xC6}, >> + {PCIE_PHY_TRSV_REG28F, 0x90}, >> + {PCIE_PHY_TRSV_REG290, 0x4D}, >> + {PCIE_PHY_TRSV_REG291, 0x19}, >> + {PCIE_PHY_TRSV_REG292, 0x1C}, >> + {PCIE_PHY_TRSV_REG294, 0x05}, >> + {PCIE_PHY_TRSV_REG295, 0x10}, >> + {PCIE_PHY_TRSV_REG296, 0x0C}, >> + {PCIE_PHY_TRSV_REG297, 0x19}, >> + {PCIE_PHY_TRSV_REG298, 0x04}, >> + {PCIE_PHY_TRSV_REG29B, 0x03}, >> + {PCIE_PHY_TRSV_REG29C, 0x1B}, >> + {PCIE_PHY_TRSV_REG29D, 0x1B}, >> + {PCIE_PHY_TRSV_REG29E, 0x1F}, >> + {PCIE_PHY_TRSV_REG2AA, 0x00}, >> + {PCIE_PHY_TRSV_REG2AE, 0x1F}, >> + {PCIE_PHY_TRSV_REG2C2, 0x25}, >> + {PCIE_PHY_TRSV_REG2C6, 0x10}, >> + {PCIE_PHY_TRSV_REG2C7, 0x06}, >> + {PCIE_PHY_TRSV_REG2CB, 0x10}, >> + {PCIE_PHY_TRSV_REG2CC, 0x06}, >> + {PCIE_PHY_TRSV_REG2CD, 0x20}, >> + {PCIE_PHY_TRSV_REG2CE, 0x27}, >> + {PCIE_PHY_TRSV_REG2D0, 0x10}, >> + {PCIE_PHY_TRSV_REG2CF, 0x0A}, >> + {PCIE_PHY_TRSV_REG2E0, 0x01}, >> + {PCIE_PHY_TRSV_REG2E9, 0x11}, >> + {PCIE_PHY_TRSV_REG2EA, 0x05}, >> + {PCIE_PHY_TRSV_REG2EB, 0x4C}, >> + {PCIE_PHY_TRSV_REG315, 0x18}, >> + {PCIE_PHY_TRSV_REG317, 0x86}, >> + {PCIE_PHY_TRSV_REG319, 0x8E}, >> + {PCIE_PHY_TRSV_REG364, 0x00}, >> + {PCIE_PHY_TRSV_REG36C, 0x03}, >> + {PCIE_PHY_TRSV_REG36D, 0x04}, >> + {PCIE_PHY_TRSV_REG37E, 0x06}, >> + {PCIE_PHY_TRSV_REG37F, 0x04}, >> + {PCIE_PHY_TRSV_REG38F, 0x40}, >> + {PCIE_PHY_TRSV_REG391, 0x8B}, >> + {PCIE_PHY_TRSV_REG39C, 0xFF}, >> + {PCIE_PHY_TRSV_REG3A8, 0x02}, >> + {PCIE_PHY_TRSV_REG3E0, 0x93}, >> + {PCIE_PHY_TRSV_REG3E1, 0x79}, >> + {PCIE_PHY_TRSV_REG3E7, 0xF5}, >> + {PCIE_PHY_TRSV_REG3E9, 0x75}, >> + {PCIE_PHY_TRSV_REG3EA, 0x0D}, >> + {PCIE_PHY_TRSV_REG3EE, 0xE2}, >> + {PCIE_PHY_TRSV_REG3EF, 0x6F}, >> + {PCIE_PHY_TRSV_REG3F0, 0x3D} >> +}; >> + >> +static const struct artpec8_pcie_phy_tune_reg rx_preset_regs[] = { >> + /* 0 */ >> + {PCIE_PHY_CMN_REG17E, 0x00}, >> + {PCIE_PHY_CMN_REG180, 0x23}, >> + {PCIE_PHY_CMN_REG181, 0x44}, >> + {PCIE_PHY_CMN_REG182, 0x61}, >> + {PCIE_PHY_CMN_REG183, 0x55}, >> + {PCIE_PHY_CMN_REG184, 0x14}, >> + {PCIE_PHY_CMN_REG185, 0x23}, >> + {PCIE_PHY_CMN_REG186, 0x1A}, >> + {PCIE_PHY_CMN_REG187, 0x04}, >> + {PCIE_PHY_CMN_REG17E, 0x04}, >> + {PCIE_PHY_CMN_REG17E, 0x00}, >> + /* 1 */ >> + {PCIE_PHY_CMN_REG17E, 0x08}, >> + {PCIE_PHY_CMN_REG181, 0x42}, >> + {PCIE_PHY_CMN_REG17E, 0x0C}, >> + {PCIE_PHY_CMN_REG17E, 0x08}, >> + /* 2 */ >> + {PCIE_PHY_CMN_REG17E, 0x10}, >> + {PCIE_PHY_CMN_REG181, 0x40}, >> + {PCIE_PHY_CMN_REG17E, 0x14}, >> + {PCIE_PHY_CMN_REG17E, 0x10}, >> + /* 3 */ >> + {PCIE_PHY_CMN_REG17E, 0x18}, >> + {PCIE_PHY_CMN_REG181, 0x45}, >> + {PCIE_PHY_CMN_REG17E, 0x1C}, >> + {PCIE_PHY_CMN_REG17E, 0x18}, >> + /* 4 */ >> + {PCIE_PHY_CMN_REG17E, 0x20}, >> + {PCIE_PHY_CMN_REG181, 0x46}, >> + {PCIE_PHY_CMN_REG17E, 0x24}, >> + {PCIE_PHY_CMN_REG17E, 0x20}, >> + /* 5 */ >> + {PCIE_PHY_CMN_REG17E, 0x28}, >> + {PCIE_PHY_CMN_REG181, 0x48}, >> + {PCIE_PHY_CMN_REG17E, 0x2C}, >> + {PCIE_PHY_CMN_REG17E, 0x28}, >> + /* 6 */ >> + {PCIE_PHY_CMN_REG17E, 0x30}, >> + {PCIE_PHY_CMN_REG181, 0x4A}, >> + {PCIE_PHY_CMN_REG17E, 0x34}, >> + {PCIE_PHY_CMN_REG17E, 0x30}, >> + /* 7 */ >> + {PCIE_PHY_CMN_REG17E, 0x38}, >> + {PCIE_PHY_CMN_REG181, 0x4C}, >> + {PCIE_PHY_CMN_REG17E, 0x3C}, >> + {PCIE_PHY_CMN_REG17E, 0x38}, >> + /* 8 */ >> + {PCIE_PHY_CMN_REG17E, 0x40}, >> + {PCIE_PHY_CMN_REG180, 0x20}, >> + {PCIE_PHY_CMN_REG181, 0x20}, >> + {PCIE_PHY_CMN_REG182, 0x01}, >> + {PCIE_PHY_CMN_REG17E, 0x44}, >> + {PCIE_PHY_CMN_REG17E, 0x40}, >> + /* 9 */ >> + {PCIE_PHY_CMN_REG17E, 0x48}, >> + {PCIE_PHY_CMN_REG180, 0x20}, >> + {PCIE_PHY_CMN_REG181, 0x21}, >> + {PCIE_PHY_CMN_REG182, 0x01}, >> + {PCIE_PHY_CMN_REG17E, 0x4C}, >> + {PCIE_PHY_CMN_REG17E, 0x48}, >> + /* 10 */ >> + {PCIE_PHY_CMN_REG17E, 0x50}, >> + {PCIE_PHY_CMN_REG180, 0x24}, >> + {PCIE_PHY_CMN_REG181, 0x80}, >> + {PCIE_PHY_CMN_REG182, 0x41}, >> + {PCIE_PHY_CMN_REG183, 0xAF}, >> + {PCIE_PHY_CMN_REG184, 0x26}, >> + {PCIE_PHY_CMN_REG185, 0x34}, >> + {PCIE_PHY_CMN_REG186, 0x24}, >> + {PCIE_PHY_CMN_REG187, 0x06}, >> + {PCIE_PHY_CMN_REG17E, 0x54}, >> + {PCIE_PHY_CMN_REG17E, 0x50}, >> + /* 11 */ >> + {PCIE_PHY_CMN_REG17E, 0x58}, >> + {PCIE_PHY_CMN_REG181, 0x81}, >> + {PCIE_PHY_CMN_REG17E, 0x5C}, >> + {PCIE_PHY_CMN_REG17E, 0x58}, >> + /* 12 */ >> + {PCIE_PHY_CMN_REG17E, 0x60}, >> + {PCIE_PHY_CMN_REG181, 0x82}, >> + {PCIE_PHY_CMN_REG17E, 0x64}, >> + {PCIE_PHY_CMN_REG17E, 0x60}, >> + /* 13 */ >> + {PCIE_PHY_CMN_REG17E, 0x68}, >> + {PCIE_PHY_CMN_REG181, 0x83}, >> + {PCIE_PHY_CMN_REG17E, 0x6C}, >> + {PCIE_PHY_CMN_REG17E, 0x68}, >> + /* 14 */ >> + {PCIE_PHY_CMN_REG17E, 0x70}, >> + {PCIE_PHY_CMN_REG181, 0x84}, >> + {PCIE_PHY_CMN_REG17E, 0x74}, >> + {PCIE_PHY_CMN_REG17E, 0x70}, >> + /* 15 */ >> + {PCIE_PHY_CMN_REG17E, 0x78}, >> + {PCIE_PHY_CMN_REG180, 0x24}, >> + {PCIE_PHY_CMN_REG181, 0x85}, >> + {PCIE_PHY_CMN_REG182, 0x80}, >> + {PCIE_PHY_CMN_REG183, 0x7F}, >> + {PCIE_PHY_CMN_REG184, 0x2D}, >> + {PCIE_PHY_CMN_REG185, 0x34}, >> + {PCIE_PHY_CMN_REG186, 0x24}, >> + {PCIE_PHY_CMN_REG187, 0x05}, >> + {PCIE_PHY_CMN_REG17E, 0x7C}, >> + {PCIE_PHY_CMN_REG17E, 0x78}, >> + /* 16 */ >> + {PCIE_PHY_CMN_REG17E, 0x80}, >> + {PCIE_PHY_CMN_REG181, 0x86}, >> + {PCIE_PHY_CMN_REG17E, 0x84}, >> + {PCIE_PHY_CMN_REG17E, 0x80}, >> + /* 17 */ >> + {PCIE_PHY_CMN_REG17E, 0x88}, >> + {PCIE_PHY_CMN_REG181, 0x87}, >> + {PCIE_PHY_CMN_REG17E, 0x8C}, >> + {PCIE_PHY_CMN_REG17E, 0x88}, >> + /* 18 */ >> + {PCIE_PHY_CMN_REG17E, 0x90}, >> + {PCIE_PHY_CMN_REG181, 0x88}, >> + {PCIE_PHY_CMN_REG17E, 0x94}, >> + {PCIE_PHY_CMN_REG17E, 0x90}, >> + /* 19 */ >> + {PCIE_PHY_CMN_REG17E, 0x98}, >> + {PCIE_PHY_CMN_REG181, 0x89}, >> + {PCIE_PHY_CMN_REG17E, 0x9C}, >> + {PCIE_PHY_CMN_REG17E, 0x98}, >> +}; >> + >> +static void artpec8_pcie_phy_reg_update(void __iomem *base, u32 mask, >> + u32 update, u32 reg) >> +{ >> + u32 val; >> + >> + val = readl(base + reg); >> + val &= ~(mask); >> + val |= update; >> + writel(val, base + reg); >> +}; >> + >> +static void artpec8_pcie_enable_ref_clk_from_xo(struct artpec8_pcie_phy >> + *pciephy) > > pls use consistent formatting for second lines, this and previous > function _do_not_ match. Hint, checkpatch recommends aligning to > previous line open brace (--strict option will check that for you) I will fix it, thank you for information. >> +{ >> + regmap_update_bits(pciephy->>sysreg, FSYS_PCIE_CON, >> + PCIE_PHY_LCPLL_REFCLK_SEL, >> + REF_CLK_FROM_XO); >> + regmap_update_bits(pciephy->>sysreg, FSYS_PCIE_CON, >> + PCIE_PHY_ROPLL_REFCLK_SEL, >> + ROPLL_REFCLK_NOT_AVAILABLE); >> +}; >> + >> +static void artpec8_pcie_enable_ref_clk_from_io(struct artpec8_pcie_phy >> + *pciephy) >> +{ >> + artpec8_pcie_phy_reg_update(pciephy->>phy_base, >> + PCIE_AUX_RX_MODE_EXTEND, 0, >> + PCIE_PHY_CMN_REG14D); >> + artpec8_pcie_phy_reg_update(pciephy->>phy_base, >> + ANA_AUX_EXT_REF_CLK_SEL, 0, >> + PCIE_PHY_CMN_REG0D9); >> + artpec8_pcie_phy_reg_update(pciephy->>phy_base, >> + AUX_PLL_EN_EXTEND, 0, >> + PCIE_PHY_CMN_REG10F); >> + artpec8_pcie_phy_reg_update(pciephy->>phy_base, >> + AUX2_PLL_EN_EXTEND, 0, >> + PCIE_PHY_CMN_REG11E); >> + artpec8_pcie_phy_reg_update(pciephy->>phy_base, >> + OV_S_ANA_AUX_EN, OV_S_ANA_AUX_EN, >> + PCIE_PHY_CMN_REG0D4); >> + artpec8_pcie_phy_reg_update(pciephy->>phy_base, >> + OV_I_ANA_AUX_EN, OV_I_ANA_AUX_EN, >> + PCIE_PHY_CMN_REG0D4); >> + >> + regmap_update_bits(pciephy->>sysreg, FSYS_PCIE_CON, >> + PCIE_PHY_LCPLL_REFCLK_SEL, >> + REF_CLK_FROM_IO); >> + regmap_update_bits(pciephy->>sysreg, FSYS_PCIE_CON, >> + PCIE_PHY_ROPLL_REFCLK_SEL, >> + ROPLL_REFCLK_NOT_AVAILABLE); >> + regmap_update_bits(pciephy->>sysreg, FSYS_PCIE_CON, >> + PCIE_PHY_LN0_REFCLK_PAD_EN, >> + PCIE_PHY_LN0_REFCLK_PAD_EN); >> + regmap_update_bits(pciephy->>sysreg, FSYS_PCIE_CON, >> + PCIE_PHY_LN1_REFCLK_PAD_EN, >> + PCIE_PHY_LN1_REFCLK_PAD_EN); >> +} >> + >> +static void artpec8_pcie_enable_ref_clk_from_soc_pll(struct artpec8_pcie_phy >> + *pciephy) >> +{ >> + regmap_update_bits(pciephy->>sysreg, FSYS_PCIE_CON, >> + PCIE_PHY_LCPLL_REFCLK_SEL, >> + REF_CLK_FROM_SOC_PLL); >> + regmap_update_bits(pciephy->>sysreg, FSYS_PCIE_CON, >> + PCIE_PHY_ROPLL_REFCLK_SEL, >> + ROPLL_REFCLK_NOT_AVAILABLE); >> +} >> + >> +static void artpec8_pcie_lane_control(struct phy *phy, u32 lane0_reg, u32 mask, >> + u32 val) >> +{ >> + struct artpec8_pcie_phy *pciephy = phy_get_drvdata(phy); >> + u32 lanex_reg = lane0_reg; >> + int i; >> + >> + if (lane0_reg < PCIE_PHY_LN0_REG_START || >> + lane0_reg >> PCIE_PHY_LN0_REG_END) { >> + return; >> + } >> + >> + for (i = 0; i < pciephy->>num_lanes; i++) { >> + lanex_reg += OFFSET_PER_LANE * i; >> + artpec8_pcie_phy_reg_update(pciephy->>phy_base, mask, val, >> + lanex_reg); >> + } >> +} >> + >> +static void artpec8_pcie_phy_tune(struct artpec8_pcie_phy *pciephy) >> +{ >> + int i, count; >> + >> + /* init cmn registers */ >> + count = ARRAY_SIZE(cmn_regs); >> + for (i = 0; i < count; i++) >> + writel(cmn_regs[i].val, pciephy->>phy_base + cmn_regs[i].offset); >> + >> + /* init lane registers */ >> + count = ARRAY_SIZE(lane_regs); >> + for (i = 0; i < count; i++) { >> + writel(lane_regs[i].val, pciephy->>phy_base + lane_regs[i].offset); >> + writel(lane_regs[i].val, pciephy->>phy_base + lane_regs[i].offset + >> + OFFSET_PER_LANE); >> + } >> + >> + /* rx preset registers */ >> + count = ARRAY_SIZE(rx_preset_regs); >> + for (i = 0; i < count; i++) >> + writel(rx_preset_regs[i].val, pciephy->>phy_base + rx_preset_regs[i].offset); >> +} >> + >> +static int artpec8_pcie_phy_init(struct phy *phy) >> +{ >> + struct artpec8_pcie_phy *pciephy = phy_get_drvdata(phy); >> + >> + /* reset init_rstn and cmn_rstn */ >> + artpec8_pcie_phy_reg_update(pciephy->>phy_base, >> + OV_I_CMN_RSTN | OV_I_INIT_RSTN, 0, PCIE_PHY_CMN_REG101); >> + >> + /* reference clock selection */ >> + switch (pciephy->>lcpll_ref_clk) { >> + case REF_CLK_FROM_XO: >> + artpec8_pcie_enable_ref_clk_from_xo(pciephy); >> + break; >> + case REF_CLK_FROM_IO: >> + artpec8_pcie_enable_ref_clk_from_io(pciephy); >> + break; >> + case REF_CLK_FROM_SOC_PLL: >> + artpec8_pcie_enable_ref_clk_from_soc_pll(pciephy); >> + break; >> + default: >> + break; >> + } >> + >> + /* release i_init_rstn */ >> + artpec8_pcie_phy_reg_update(pciephy->>phy_base, OV_I_INIT_RSTN, >> + OV_I_INIT_RSTN, PCIE_PHY_CMN_REG101); >> + >> + /* phy initial settings */ >> + artpec8_pcie_phy_tune(pciephy); >> + >> + /* pll_en should be set to off when PM_STATE is P1.CPM */ >> + if (!strncmp(pciephy->>mode, "pcie_ep", strlen("pcie_ep"))) { >> + artpec8_pcie_phy_reg_update(pciephy->>pcs_base, B1_DYNAMIC, >> + B1_DYNAMIC, PCIE_PCS_OUT_VEC_4); >> + } >> + >> + /* disable lane eq ctrl rx data hold */ >> + artpec8_pcie_lane_control(phy, PCIE_PHY_TRSV_REG2C0, >> + LN_EQ_CTRL_RX_DATA_HOLD, 0); >> + >> + return 0; >> +} >> + >> +static int artpec8_pcie_phy_exit(struct phy *phy) >> +{ >> + return 0; >> +} >> + >> +static int artpec8_pcie_phy_reset(struct phy *phy) >> +{ >> + struct artpec8_pcie_phy *pciephy = phy_get_drvdata(phy); >> + >> + artpec8_pcie_phy_reg_update(pciephy->>phy_base, OV_I_CMN_RSTN, >> + 0, PCIE_PHY_CMN_REG101); >> + udelay(10); >> + artpec8_pcie_phy_reg_update(pciephy->>phy_base, OV_I_CMN_RSTN, >> + OV_I_CMN_RSTN, PCIE_PHY_CMN_REG101); >> + >> + return 0; >> +} >> + >> +static int artpec8_pcie_phy_power_on(struct phy *phy) >> +{ >> + struct artpec8_pcie_phy *pciephy = phy_get_drvdata(phy); >> + >> + regmap_update_bits(pciephy->>sysreg, FSYS_PCIE_CON, >> + PCIE_PHY_PWR_OFF, 0); >> + >> + return 0; >> +} >> + >> +static int artpec8_pcie_phy_power_off(struct phy *phy) >> +{ >> + struct artpec8_pcie_phy *pciephy = phy_get_drvdata(phy); >> + >> + regmap_update_bits(pciephy->>sysreg, FSYS_PCIE_CON, >> + PCIE_PHY_PWR_OFF, PCIE_PHY_PWR_OFF); >> + >> + return 0; >> +} >> + >> +static int artpec8_pcie_phy_probe(struct platform_device *pdev) >> +{ >> + struct device *dev = &pdev->>dev; >> + struct artpec8_pcie_phy *artpec8_phy; >> + struct phy *generic_phy; >> + struct phy_provider *phy_provider; >> + const struct artpec8_pcie_phy_data *drv_data; >> + >> + drv_data = of_device_get_match_data(dev); >> + if (!drv_data) >> + return -ENODEV; >> + >> + artpec8_phy = devm_kzalloc(dev, sizeof(*artpec8_phy), GFP_KERNEL); >> + if (!artpec8_phy) >> + return -ENOMEM; >> + >> + /* reference clock */ >> + if (of_property_read_u32(dev->>of_node, "lcpll-ref-clk", >> + &artpec8_phy->>lcpll_ref_clk)) { >> + return -EINVAL; >> + } >> + /* PLL SOC reference clock */ >> + if (artpec8_phy->>lcpll_ref_clk == REF_CLK_FROM_SOC_PLL) { >> + artpec8_phy->>soc_pll_clk = devm_clk_get(dev, "ref_clk"); >> + if (IS_ERR(artpec8_phy->>soc_pll_clk)) >> + return -EINVAL; >> + clk_prepare_enable(artpec8_phy->>soc_pll_clk); >> + } >> + >> + /* link mode */ >> + if (of_property_read_string(dev->>of_node, "mode", &artpec8_phy->>mode)) >> + return -EINVAL; >> + >> + /* number of lanes */ >> + if (of_property_read_u32(dev->>of_node, "num-lanes", >> + &artpec8_phy->>num_lanes)) >> + return -EINVAL; >> + >> + if (artpec8_phy->>num_lanes >> LANE_MAX) >> + return -EINVAL; >> + >> + /* PHY base register */ >> + artpec8_phy->>phy_base = devm_platform_ioremap_resource_byname(pdev, "phy"); >> + if (IS_ERR(artpec8_phy->>phy_base)) >> + return PTR_ERR(artpec8_phy->>phy_base); >> + >> + /* PCS base register */ >> + artpec8_phy->>pcs_base = devm_platform_ioremap_resource_byname(pdev, "pcs"); >> + if (IS_ERR(artpec8_phy->>pcs_base)) >> + return PTR_ERR(artpec8_phy->>pcs_base); >> + >> + /* sysreg regmap handle, need to change using smc */ >> + artpec8_phy->>sysreg = >> + syscon_regmap_lookup_by_phandle(dev->>of_node, >> + "samsung,fsys-sysreg"); >> + if (IS_ERR(artpec8_phy->>sysreg)) >> + return PTR_ERR(artpec8_phy->>sysreg); >> + >> + artpec8_phy->>drv_data = drv_data; >> + >> + generic_phy = devm_phy_create(dev, dev->>of_node, drv_data->>ops); >> + if (IS_ERR(generic_phy)) >> + return PTR_ERR(generic_phy); >> + >> + phy_set_drvdata(generic_phy, artpec8_phy); >> + phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); >> + >> + if (IS_ERR(phy_provider)) >> + return PTR_ERR(phy_provider); >> + >> + return 0; >> +} >> + >> +static int __exit artpec8_pcie_remove(struct platform_device *pdev) >> +{ >> + struct artpec8_pcie_phy *artpec8_phy = platform_get_drvdata(pdev); >> + >> + if (artpec8_phy->>soc_pll_clk) >> + clk_disable_unprepare(artpec8_phy->>soc_pll_clk); >> + >> + return 0; >> +} >> + >> +static const struct phy_ops artpec8_phy_ops = { >> + .init = artpec8_pcie_phy_init, >> + .exit = artpec8_pcie_phy_exit, >> + .reset = artpec8_pcie_phy_reset, >> + .power_on = artpec8_pcie_phy_power_on, >> + .power_off = artpec8_pcie_phy_power_off, >> + .owner = THIS_MODULE, >> +}; >> + >> +static const struct artpec8_pcie_phy_data artpec8_pcie_phy_data = { >> + .ops = &artpec8_phy_ops, >> +}; > > you have only _one_ ops, so why add driver data for this? > Maybe i made it in case data is added in the future, but I will delete it. >> + >> +static const struct of_device_id artpec8_pcie_phy_match[] = { >> + { >> + .compatible = "axis,artpec8-pcie-phy", >> + .data = &artpec8_pcie_phy_data, >> + }, >> + {}, >> +}; >> +MODULE_DEVICE_TABLE(of, artpec8_pcie_phy_match); >> + >> +static struct platform_driver artpec8_pcie_phy_driver = { >> + .probe = artpec8_pcie_phy_probe, >> + .remove = __exit_p(artpec8_pcie_phy_remove), >> + .driver = { >> + .of_match_table = artpec8_pcie_phy_match, >> + .name = "artpec8_pcie_phy", >> + } >> +}; >> + >> +module_platform_driver(artpec8_pcie_phy_driver); >> + >> +MODULE_LICENSE("GPL"); >> +MODULE_AUTHOR("Jaeho Cho <jaeho79.cho@samsung.com>>"); >> -- >> 2.9.5 > > -- > ~Vinod Thank you for kindness reivew. Best regards, Wangseok Lee ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver 2022-07-06 8:10 ` [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver Wangseok Lee @ 2022-07-06 16:51 ` Vinod Koul 0 siblings, 0 replies; 30+ messages in thread From: Vinod Koul @ 2022-07-06 16:51 UTC (permalink / raw) To: Wangseok Lee Cc: robh+dt, krzk+dt, kishon, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel, Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 06-07-22, 17:10, Wangseok Lee wrote: > On 05-07-22, 15:30, Vinod Koul wrote: > > On 14-06-22, 10:34, Wangseok Lee wrote: > >> Add support Axis, ARTPEC-8 SoC. > >> ARTPEC-8 is the SoC platform of Axis Communications. > >> This is based on arm64 and support GEN4 & 2lane. > >> This driver provides PHY interface for ARTPEC-8 SoC PCIe controller, > >> based on Samsung PCIe PHY IP. > >> > >> Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> > >> Signed-off-by: Jaeho Cho <jaeho79.cho@samsung.com> > >> --- > >> v2->v3 : > >> -remove unnecessary indentation > >> -redefine local struct to statis const > >> -add static const to struct that requires static const definition > >> -remove wrappers on writel and readl > >> > >> v1->v2 : > >> -change folder name of phy driver to axis from artpec > >> --- > >> drivers/phy/Kconfig | 1 + > >> drivers/phy/Makefile | 1 + > >> drivers/phy/axis/Kconfig | 9 + > >> drivers/phy/axis/Makefile | 2 + > >> drivers/phy/axis/phy-artpec8-pcie.c | 776 ++++++++++++++++++++++++++++++++++++ > >> 5 files changed, 789 insertions(+) > >> create mode 100644 drivers/phy/axis/Kconfig > >> create mode 100644 drivers/phy/axis/Makefile > >> create mode 100644 drivers/phy/axis/phy-artpec8-pcie.c > >> > >> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > >> index 300b0f2..92b8232 100644 > >> --- a/drivers/phy/Kconfig > >> +++ b/drivers/phy/Kconfig > >> @@ -73,6 +73,7 @@ config PHY_CAN_TRANSCEIVER > >> > >> source "drivers/phy/allwinner/Kconfig" > >> source "drivers/phy/amlogic/Kconfig" > >> +source "drivers/phy/axis/Kconfig" > >> source "drivers/phy/broadcom/Kconfig" > >> source "drivers/phy/cadence/Kconfig" > >> source "drivers/phy/freescale/Kconfig" > >> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile > >> index 01e9eff..808c055e 100644 > >> --- a/drivers/phy/Makefile > >> +++ b/drivers/phy/Makefile > >> @@ -12,6 +12,7 @@ obj-$(CONFIG_PHY_PISTACHIO_USB) += phy-pistachio-usb.o > >> obj-$(CONFIG_USB_LGM_PHY) += phy-lgm-usb.o > >> obj-y += allwinner/ \ > >> amlogic/ \ > >> + axis/ \ > >> broadcom/ \ > >> cadence/ \ > >> freescale/ \ > >> diff --git a/drivers/phy/axis/Kconfig b/drivers/phy/axis/Kconfig > >> new file mode 100644 > >> index 0000000..7198b93 > >> --- /dev/null > >> +++ b/drivers/phy/axis/Kconfig > >> @@ -0,0 +1,9 @@ > >> +config PHY_ARTPEC8_PCIE > >> + bool "ARTPEC-8 PCIe PHY driver" > >> + depends on OF && (ARCH_ARTPEC8 || COMPILE_TEST) > >> + select GENERIC_PHY > >> + help > >> + Enable PCIe PHY support for ARTPEC-8 SoC. > >> + This driver provides PHY interface for ARTPEC-8 SoC > >> + PCIe controller. > >> + This is based on Samsung PCIe PHY IP. > > > > How different is it from SS IP and why should it not be under > > phy/samsung/ then? > > > > SoC platform is completely different from exynos platform and different > from exynos PCIe PHY. So the overall sysreg configuration is different > and register map is also different. The reset method and type of PHY for > initialization are different. This is not a driver that supports Samsung > SoC platform, but this PHY driver that supports only Axis, Artpec-8 > platforms, so it is not added to phy/samsung. SoC is a moot point. If the IP block is same then we should try to reuse the existing phy driver, modifications to current driver to support your changes should be fine... Is that feasible? -- ~Vinod ^ permalink raw reply [flat|nested] 30+ messages in thread
[parent not found: <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p5>]
* [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p5> @ 2022-06-14 1:29 ` Wangseok Lee 2022-06-16 22:58 ` Krzysztof Kozlowski 2022-06-20 8:38 ` Wangseok Lee ` (2 subsequent siblings) 3 siblings, 1 reply; 30+ messages in thread From: Wangseok Lee @ 2022-06-14 1:29 UTC (permalink / raw) To: robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim Add description to support Axis, ARTPEC-8 SoC. ARTPEC-8 is the SoC platform of Axis Communications and PCIe phy is designed based on SAMSUNG PHY. Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> --- v2->v3 : -modify version history to fit the linux commit rule -remove 'Device Tree Bindings' on title -remove clock-names entries -change node name to soc from artpec8 on excamples v1->v2 : -'make dt_binding_check' result improvement -Add the missing property list -Align the indentation of continued lines/entries --- .../bindings/phy/axis,artpec8-pcie-phy.yaml | 73 ++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml diff --git a/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml new file mode 100644 index 0000000..316b774 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml @@ -0,0 +1,73 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/axis,artpec8-pcie-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ARTPEC-8 SoC PCIe PHY + +maintainers: + - Jesper Nilsson <jesper.nilsson@axis.com> + +properties: + compatible: + const: axis,artpec8-pcie-phy + + reg: + items: + - description: PHY registers. + - description: PHY coding sublayer registers. + + reg-names: + items: + - const: phy + - const: pcs + + "#phy-cells": + const: 0 + + clocks: + items: + - description: PCIe PHY reference clock + + num-lanes: + const: 2 + + lcpll-ref-clk: + const: 1 + +required: + - compatible + - reg + - reg-names + - "#phy-cells" + - clocks + - clock-names + - samsung,fsys-sysreg + - num-lanes + - lcpll-ref-clk + +additionalProperties: true + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + pcie_phy: pcie-phy@16c80000 { + compatible = "axis,artpec8-pcie-phy"; + reg = <0x0 0x16c80000 0x0 0x2000>, + <0x0 0x16c90000 0x0 0x1000>; + reg-names = "phy", "pcs"; + #phy-cells = <0>; + clocks = <&clock_cmu_fsys 53>; + clock-names = "ref"; + samsung,fsys-sysreg = <&syscon_fsys>; + num-lanes = <2>; + lcpll-ref-clk = <1>; + }; + }; +... -- 2.9.5 ^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy 2022-06-14 1:29 ` [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy Wangseok Lee @ 2022-06-16 22:58 ` Krzysztof Kozlowski 0 siblings, 0 replies; 30+ messages in thread From: Krzysztof Kozlowski @ 2022-06-16 22:58 UTC (permalink / raw) To: wangseok.lee, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 13/06/2022 18:29, Wangseok Lee wrote: > Add description to support Axis, ARTPEC-8 SoC. > ARTPEC-8 is the SoC platform of Axis Communications > and PCIe phy is designed based on SAMSUNG PHY. No improvements here. On v2 I gave you link pointing to specific paragraph of our documentation which you need to apply - wrong wrapping. Is there something unclear here? Please do not wrap in different style. > > Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> > --- > v2->v3 : > -modify version history to fit the linux commit rule > -remove 'Device Tree Bindings' on title > -remove clock-names entries > -change node name to soc from artpec8 on excamples > > v1->v2 : > -'make dt_binding_check' result improvement > -Add the missing property list > -Align the indentation of continued lines/entries > --- > .../bindings/phy/axis,artpec8-pcie-phy.yaml | 73 ++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml > new file mode 100644 > index 0000000..316b774 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/axis,artpec8-pcie-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ARTPEC-8 SoC PCIe PHY > + > +maintainers: > + - Jesper Nilsson <jesper.nilsson@axis.com> > + > +properties: > + compatible: > + const: axis,artpec8-pcie-phy > + > + reg: > + items: > + - description: PHY registers. > + - description: PHY coding sublayer registers. > + > + reg-names: > + items: > + - const: phy > + - const: pcs > + > + "#phy-cells": > + const: 0 > + > + clocks: > + items: > + - description: PCIe PHY reference clock > + > + num-lanes: > + const: 2 > + > + lcpll-ref-clk: > + const: 1 Unknown field... custom properties need vendor (axis,), type (boolean) and description. > + > +required: > + - compatible > + - reg > + - reg-names > + - "#phy-cells" > + - clocks > + - clock-names > + - samsung,fsys-sysreg Same problem as in patch #1. > + - num-lanes > + - lcpll-ref-clk > + > +additionalProperties: true No, this must be false. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p5> 2022-06-14 1:29 ` [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy Wangseok Lee @ 2022-06-20 8:38 ` Wangseok Lee 2022-06-21 21:13 ` Bjorn Helgaas 2022-06-22 7:21 ` [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller Wangseok Lee 2022-07-14 9:59 ` [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver Wangseok Lee 3 siblings, 1 reply; 30+ messages in thread From: Wangseok Lee @ 2022-06-20 8:38 UTC (permalink / raw) To: Krzysztof Kozlowski, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 17/06/2022 07:59, Krzysztof Kozlowski wrote: > On 13/06/2022 18:29, Wangseok Lee wrote: >> Add description to support Axis, ARTPEC-8 SoC. >> ARTPEC-8 is the SoC platform of Axis Communications >> and PCIe phy is designed based on SAMSUNG PHY. > > No improvements here. On v2 I gave you link pointing to specific > paragraph of our documentation which you need to apply - wrong wrapping. > Is there something unclear here? > > Please > do > not > wrap > in > different > style. > > I think i misunderstood your review comment. I will modify it as below. s/SAMSUNG PHY/Samsung phy Please let me know if there is anything I missed. >> >> Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> >> --- >> v2->v3 : >> -modify version history to fit the linux commit rule >> -remove 'Device Tree Bindings' on title >> -remove clock-names entries >> -change node name to soc from artpec8 on excamples >> >> v1->v2 : >> -'make dt_binding_check' result improvement >> -Add the missing property list >> -Align the indentation of continued lines/entries >> --- >> .../bindings/phy/axis,artpec8-pcie-phy.yaml | 73 ++++++++++++++++++++++ >> 1 file changed, 73 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml >> >> diff --git a/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml >> new file mode 100644 >> index 0000000..316b774 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml >> @@ -0,0 +1,73 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: https://protect2.fireeye.com/v1/url?k=84f6a8c0-e57dbdd9-84f7238f-74fe485cbfec-e81bd79bfd1ff442&q=1&e=6739af06-730c-48db-aef8-026a9aaee1b4&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fphy%2Faxis%2Cartpec8-pcie-phy.yaml%23 >> +$schema: https://protect2.fireeye.com/v1/url?k=b4f1a4ba-d57ab1a3-b4f02ff5-74fe485cbfec-7f885cbe82dc7860&q=1&e=6739af06-730c-48db-aef8-026a9aaee1b4&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 >> + >> +title: ARTPEC-8 SoC PCIe PHY >> + >> +maintainers: >> + - Jesper Nilsson <jesper.nilsson@axis.com> >> + >> +properties: >> + compatible: >> + const: axis,artpec8-pcie-phy >> + >> + reg: >> + items: >> + - description: PHY registers. >> + - description: PHY coding sublayer registers. >> + >> + reg-names: >> + items: >> + - const: phy >> + - const: pcs >> + >> + "#phy-cells": >> + const: 0 >> + >> + clocks: >> + items: >> + - description: PCIe PHY reference clock refer to sample-schema.yaml, even if the clock item is single, it seems to be used as follows. clocks: maxItems: 1 clock-names: items: - const: ref If only "clocks:" are define and clock-names are not define, the following warning occurs. "'clock-names' does not match any of the regexes" >> + >> + num-lanes: >> + const: 2 >> + >> + lcpll-ref-clk: >> + const: 1 > > Unknown field... custom properties need vendor (axis,), type (boolean) > and description. > "lcpl-ref-clk" has an enum type value, so i will modify it as below. axis,lcpll-ref-clk: description: select the reference clock of phy and initialization is performed with the reference clock according to the selected value. $ref: /schemas/types.yaml#/definitions/uint32 enum: [ 0, 1, 2, 3, 4 ] >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - "#phy-cells" >> + - clocks >> + - clock-names >> + - samsung,fsys-sysreg > > Same problem as in patch #1. > I will add the following items to the property. samsung,fsys-sysreg: description: Phandle to system register of fsys block. $ref: /schemas/types.yaml#/definitions/phandle >> + - num-lanes >> + - lcpll-ref-clk >> + >> +additionalProperties: true > > No, this must be false. > yes, i miss it. I will fix this. > Best regards, > Krzysztof Thank you for kindness reivew. Best regards, Wangseok Lee ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy 2022-06-20 8:38 ` Wangseok Lee @ 2022-06-21 21:13 ` Bjorn Helgaas [not found] ` <CGME20220621212357epcas2p41ecf1ace5d207b154cc77dac79bc7e53@epcms2p2> 0 siblings, 1 reply; 30+ messages in thread From: Bjorn Helgaas @ 2022-06-21 21:13 UTC (permalink / raw) To: Wangseok Lee Cc: Krzysztof Kozlowski, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel, Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On Mon, Jun 20, 2022 at 05:38:21PM +0900, Wangseok Lee wrote: > On 17/06/2022 07:59, Krzysztof Kozlowski wrote: > > On 13/06/2022 18:29, Wangseok Lee wrote: > >> Add description to support Axis, ARTPEC-8 SoC. > >> ARTPEC-8 is the SoC platform of Axis Communications > >> and PCIe phy is designed based on SAMSUNG PHY. > > > > No improvements here. On v2 I gave you link pointing to specific > > paragraph of our documentation which you need to apply - wrong wrapping. > > Is there something unclear here? > > > > Please > > do > > not > > wrap > > in > > different > > style. > > I think i misunderstood your review comment. Krzysztof was pointing out that your commit log: Add description to support Axis, ARTPEC-8 SoC. ARTPEC-8 is the SoC platform of Axis Communications and PCIe phy is designed based on SAMSUNG PHY. only fills about 50 columns, and if you run "git log", most commit logs fill about 75 columns so that when git adds 4 spaces of indentation, they fit nicely in an 80-column terminal and take advantage of the whole width. It's easier to read when all the commit logs are roughly the same width. So please wrap yours to something like this: Add description to support Axis, ARTPEC-8 SoC. ARTPEC-8 is the SoC platform of Axis Communications and PCIe PHY is designed based on Samsung PHY. The PCI driver the commit log is: Add support Axis, ARTPEC-8 SoC. ARTPEC-8 is the SoC platform of Axis Communications. This is based on arm64 and support GEN4 & 2lane. This PCIe controller is based on DesignWare Hardware core and uses DesignWa re core functions to implement the driver. "pcie-artpec6. c" supports artpec6 and artpec7 H/W. artpec8 can not be expanded because H/W configuration is completely differe nt from artpec6/7. phy and sub controller are different. This should be similarly rewrapped to fill 75 columns. The short lines are a signal to the reader that "this is the last line of a paragraph, so expect a new paragraph to follow." But in commit logs, paragraphs are typically separated by blank lines, so a short line followed not by a blank line but by text that *could* fit on the previous short line is a confusing signal. This similar to the Wikipedia style: https://en.wikipedia.org/wiki/Wikipedia:Manual_of_Style/Layout#Paragraphs The PCI driver commit log should also join "DesignWare" and "different", which are currently split across lines. > I will modify it as below. > s/SAMSUNG PHY/Samsung phy "PHY" is typically all caps in English text, e.g., see examples here: https://en.wikipedia.org/wiki/Physical_layer#PHY Bjorn ^ permalink raw reply [flat|nested] 30+ messages in thread
[parent not found: <CGME20220621212357epcas2p41ecf1ace5d207b154cc77dac79bc7e53@epcms2p2>]
* Re: [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy [not found] ` <CGME20220621212357epcas2p41ecf1ace5d207b154cc77dac79bc7e53@epcms2p2> @ 2022-06-22 7:06 ` Wangseok Lee 0 siblings, 0 replies; 30+ messages in thread From: Wangseok Lee @ 2022-06-22 7:06 UTC (permalink / raw) To: Bjorn Helgaas Cc: Krzysztof Kozlowski, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel, Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 22/06/2022 06:23, Bjorn Helgaas wrote: > On Mon, Jun 20, 2022 at 05:38:21PM +0900, Wangseok Lee wrote: >> On 17/06/2022 07:59, Krzysztof Kozlowski wrote: >> > On 13/06/2022 18:29, Wangseok Lee wrote: >> >> Add description to support Axis, ARTPEC-8 SoC. >> >> ARTPEC-8 is the SoC platform of Axis Communications >> >> and PCIe phy is designed based on SAMSUNG PHY. >> > >> > No improvements here. On v2 I gave you link pointing to specific >> > paragraph of our documentation which you need to apply - wrong wrapping. >> > Is there something unclear here? >> > >> > Please >> > do >> > not >> > wrap >> > in >> > different >> > style. >> >> I think i misunderstood your review comment. > > Krzysztof was pointing out that your commit log: > > Add description to support Axis, ARTPEC-8 SoC. > ARTPEC-8 is the SoC platform of Axis Communications > and PCIe phy is designed based on SAMSUNG PHY. > > only fills about 50 columns, and if you run "git log", most commit logs > fill about 75 columns so that when git adds 4 spaces of indentation, they > fit nicely in an 80-column terminal and take advantage of the whole width. > > It's easier to read when all the commit logs are roughly the same > width. So please wrap yours to something like this: > > Add description to support Axis, ARTPEC-8 SoC. ARTPEC-8 is the SoC > platform of Axis Communications and PCIe PHY is designed based on Samsung > PHY. > > The PCI driver the commit log is: > > Add support Axis, ARTPEC-8 SoC. > ARTPEC-8 is the SoC platform of Axis Communications. > > This is based on arm64 and support GEN4 & 2lane. > This PCIe controller is based on DesignWare Hardware core and uses DesignWa > re core functions to implement the driver. > > "pcie-artpec6. c" supports artpec6 and artpec7 H/W. > artpec8 can not be expanded because H/W configuration is completely differe > nt from artpec6/7. > phy and sub controller are different. > > This should be similarly rewrapped to fill 75 columns. The short lines are > a signal to the reader that "this is the last line of a paragraph, so > expect a new paragraph to follow." > > But in commit logs, paragraphs are typically separated by blank lines, so a > short line followed not by a blank line but by text that *could* fit on the > previous short line is a confusing signal. > > This similar to the Wikipedia style: > https://en.wikipedia.org/wiki/Wikipedia:Manual_of_Style/Layout#Paragraphs > > The PCI driver commit log should also join "DesignWare" and "different", > which are currently split across lines. > >> I will modify it as below. >> s/SAMSUNG PHY/Samsung phy > > "PHY" is typically all caps in English text, e.g., see examples here: > https://en.wikipedia.org/wiki/Physical_layer#PHY > > Bjorn Thank you very much for your detailed review. I will fix the commit msgs as your description. Best regards, Wangseok Lee ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p5> 2022-06-14 1:29 ` [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy Wangseok Lee 2022-06-20 8:38 ` Wangseok Lee @ 2022-06-22 7:21 ` Wangseok Lee 2022-06-23 8:27 ` Krzysztof Kozlowski 2022-07-14 9:59 ` [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver Wangseok Lee 3 siblings, 1 reply; 30+ messages in thread From: Wangseok Lee @ 2022-06-22 7:21 UTC (permalink / raw) To: Krzysztof Kozlowski, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 21/06/2022 21:44, Krzysztof Kozlowski wrote: > On 21/06/2022 09:42, Wangseok Lee wrote: >>>> >>>> samsung,syscon-bus-s-fsys: >>>> description: >>>> Phandle to bus-s path of fsys block, this register >>>> are used for enabling bus-s. >>>> $ref: /schemas/types.yaml#/definitions/phandle >>>> >>>> samsung,syscon-bus-p-fsys: >>>> description: >>>> Phandle to bus-p path of fsys block, this register >>>> are used for enabling bus-p. >>>> $ref: /schemas/types.yaml#/definitions/phandle >>> >>> This two look unspecific and hacky workaround for missing drivers. Looks >>> like instead of implementing interconnect or clock driver, you decided >>> to poke some other registers. Why this cannot be an interconnect driver? >>> >>> >> >> bus-s, bus-p is a register that exists in the sysreg of the fsys block. >> It is the same block as "fsys-sysreg" but is separated separately in >> hardware. > > Two points here: > 1. If it is in FSYS, why it cannot be accessed with samsung,fsys-sysreg? > 2. If it is only register, shuld be described like this. You must > describe item: > https://protect2.fireeye.com/v1/url?k=0f529a57-50c9a332-0f531118-000babff32e3-50938d8198077d59&q=1&e=32284e69-bbed-4d09-b6d6-0a43428aebf5&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv5.18-rc1%2Fsource%2FDocumentation%2Fdevicetree%2Fbindings%2Fsoc%2Fsamsung%2Fexynos-usi.yaml%23L42 > It would be better to access with fsys-sysreg, but their h/w address are far from each other. The fsys block consists of a system register and an additional control system register. "bus-s-fsys" and "bus-p-fsys" are additional control system register. sysreg and additional control sysreg addresses are far from each other and there are h/w registers that perform different functions between them. >> So, get resource is performed separately from "fsys-sysreg". >> They set pcie slave, dbi related control settings, >> naming "bus-x" seems to be interconnect. >> I will add this description to property. >> I don't think it need to use the interconnect driver, >> so please let me know your opinion. > > Please document both in the bindings and in the driver usage of this > register. Writing there "0" or "1" is not enough. If the documentation > is good, I am fine with it. If the explanation is obfuscated/not > sufficient, it will look like avoiding to implement a driver, which I > don't want to accept. > I think i should add enough description. Is it sufficient to modify the name and description of property like this? samsung,fsys-bus-s: description: Phandle to bus-s of fsys block, this register is additional control sysreg in fsys block and this is used for pcie slave control setting. $ref: /schemas/types.yaml#/definitions/phandle samsung,fsys-bus-p: description: Phandle to bus-p of fsys block, this register is additional control sysreg in fsys block and this is used for pcie dbi control setting. $ref: /schemas/types.yaml#/definitions/phandle > Best regards, > Krzysztof Thank you for kindness reivew. Best regards, Wangseok Lee ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller 2022-06-22 7:21 ` [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller Wangseok Lee @ 2022-06-23 8:27 ` Krzysztof Kozlowski 0 siblings, 0 replies; 30+ messages in thread From: Krzysztof Kozlowski @ 2022-06-23 8:27 UTC (permalink / raw) To: wangseok.lee, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 22/06/2022 09:21, Wangseok Lee wrote: > On 21/06/2022 21:44, Krzysztof Kozlowski wrote: >> On 21/06/2022 09:42, Wangseok Lee wrote: >>>>> >>>>> samsung,syscon-bus-s-fsys: >>>>> description: >>>>> Phandle to bus-s path of fsys block, this register >>>>> are used for enabling bus-s. >>>>> $ref: /schemas/types.yaml#/definitions/phandle >>>>> >>>>> samsung,syscon-bus-p-fsys: >>>>> description: >>>>> Phandle to bus-p path of fsys block, this register >>>>> are used for enabling bus-p. >>>>> $ref: /schemas/types.yaml#/definitions/phandle >>>> >>>> This two look unspecific and hacky workaround for missing drivers. Looks >>>> like instead of implementing interconnect or clock driver, you decided >>>> to poke some other registers. Why this cannot be an interconnect driver? >>>> >>>> >>> >>> bus-s, bus-p is a register that exists in the sysreg of the fsys block. >>> It is the same block as "fsys-sysreg" but is separated separately in >>> hardware. >> >> Two points here: >> 1. If it is in FSYS, why it cannot be accessed with samsung,fsys-sysreg? >> 2. If it is only register, shuld be described like this. You must >> describe item: >> https://protect2.fireeye.com/v1/url?k=0f529a57-50c9a332-0f531118-000babff32e3-50938d8198077d59&q=1&e=32284e69-bbed-4d09-b6d6-0a43428aebf5&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv5.18-rc1%2Fsource%2FDocumentation%2Fdevicetree%2Fbindings%2Fsoc%2Fsamsung%2Fexynos-usi.yaml%23L42 >> > > It would be better to access with fsys-sysreg, but their h/w address are > far from each other. The fsys block consists of a system register and an > additional control system register. "bus-s-fsys" and "bus-p-fsys" are > additional control system register. sysreg and additional control sysreg > addresses are far from each other and there are h/w registers that perform > different functions between them. > >>> So, get resource is performed separately from "fsys-sysreg". >>> They set pcie slave, dbi related control settings, >>> naming "bus-x" seems to be interconnect. >>> I will add this description to property. >>> I don't think it need to use the interconnect driver, >>> so please let me know your opinion. >> >> Please document both in the bindings and in the driver usage of this >> register. Writing there "0" or "1" is not enough. If the documentation >> is good, I am fine with it. If the explanation is obfuscated/not >> sufficient, it will look like avoiding to implement a driver, which I >> don't want to accept. >> > > I think i should add enough description. Is it sufficient to modify > the name and description of property like this? > Looks ok. Thank you. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver [not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p5> ` (2 preceding siblings ...) 2022-06-22 7:21 ` [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller Wangseok Lee @ 2022-07-14 9:59 ` Wangseok Lee 2022-07-15 11:33 ` Vinod Koul 3 siblings, 1 reply; 30+ messages in thread From: Wangseok Lee @ 2022-07-14 9:59 UTC (permalink / raw) To: Vinod Koul Cc: robh+dt, krzk+dt, kishon, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel, Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 07-07-22, 01:52, Vinod Koul wrote: > On 06-07-22, 17:10, Wangseok Lee wrote: >> On 05-07-22, 15:30, Vinod Koul wrote: >> > On 14-06-22, 10:34, Wangseok Lee wrote: >> >> Add support Axis, ARTPEC-8 SoC. >> >> ARTPEC-8 is the SoC platform of Axis Communications. >> >> This is based on arm64 and support GEN4 & 2lane. >> >> This driver provides PHY interface for ARTPEC-8 SoC PCIe controller, >> >> based on Samsung PCIe PHY IP. >> >> >> >> Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com> >> >> Signed-off-by: Jaeho Cho <jaeho79.cho@samsung.com> >> >> --- >> >> v2->v3 : >> >> -remove unnecessary indentation >> >> -redefine local struct to statis const >> >> -add static const to struct that requires static const definition >> >> -remove wrappers on writel and readl >> >> >> >> v1->v2 : >> >> -change folder name of phy driver to axis from artpec >> >> --- >> >> drivers/phy/Kconfig | 1 + >> >> drivers/phy/Makefile | 1 + >> >> drivers/phy/axis/Kconfig | 9 + >> >> drivers/phy/axis/Makefile | 2 + >> >> drivers/phy/axis/phy-artpec8-pcie.c | 776 ++++++++++++++++++++++++++++++++++++ >> >> 5 files changed, 789 insertions(+) >> >> create mode 100644 drivers/phy/axis/Kconfig >> >> create mode 100644 drivers/phy/axis/Makefile >> >> create mode 100644 drivers/phy/axis/phy-artpec8-pcie.c >> >> >> >> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >> >> index 300b0f2..92b8232 100644 >> >> --- a/drivers/phy/Kconfig >> >> +++ b/drivers/phy/Kconfig >> >> @@ -73,6 +73,7 @@ config PHY_CAN_TRANSCEIVER >> >> >> >> source "drivers/phy/allwinner/Kconfig" >> >> source "drivers/phy/amlogic/Kconfig" >> >> +source "drivers/phy/axis/Kconfig" >> >> source "drivers/phy/broadcom/Kconfig" >> >> source "drivers/phy/cadence/Kconfig" >> >> source "drivers/phy/freescale/Kconfig" >> >> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile >> >> index 01e9eff..808c055e 100644 >> >> --- a/drivers/phy/Makefile >> >> +++ b/drivers/phy/Makefile >> >> @@ -12,6 +12,7 @@ obj-$(CONFIG_PHY_PISTACHIO_USB) += phy-pistachio-usb.o >> >> obj-$(CONFIG_USB_LGM_PHY) += phy-lgm-usb.o >> >> obj-y += allwinner/ \ >> >> amlogic/ \ >> >> + axis/ \ >> >> broadcom/ \ >> >> cadence/ \ >> >> freescale/ \ >> >> diff --git a/drivers/phy/axis/Kconfig b/drivers/phy/axis/Kconfig >> >> new file mode 100644 >> >> index 0000000..7198b93 >> >> --- /dev/null >> >> +++ b/drivers/phy/axis/Kconfig >> >> @@ -0,0 +1,9 @@ >> >> +config PHY_ARTPEC8_PCIE >> >> + bool "ARTPEC-8 PCIe PHY driver" >> >> + depends on OF && (ARCH_ARTPEC8 || COMPILE_TEST) >> >> + select GENERIC_PHY >> >> + help >> >> + Enable PCIe PHY support for ARTPEC-8 SoC. >> >> + This driver provides PHY interface for ARTPEC-8 SoC >> >> + PCIe controller. >> >> + This is based on Samsung PCIe PHY IP. >> > >> > How different is it from SS IP and why should it not be under >> > phy/samsung/ then? >> > >> >> SoC platform is completely different from exynos platform and different >> from exynos PCIe PHY. So the overall sysreg configuration is different >> and register map is also different. The reset method and type of PHY for >> initialization are different. This is not a driver that supports Samsung >> SoC platform, but this PHY driver that supports only Axis, Artpec-8 >> platforms, so it is not added to phy/samsung. > > SoC is a moot point. If the IP block is same then we should try to reuse > the existing phy driver, modifications to current driver to support your > changes should be fine... > > Is that feasible? > > -- > ~Vinod Sorry for late reply. Above all, the IP blocks of phy-exynos-pcie.c and artpec8's pcie phy are different. As a result, the H/W architecture and operation sequence is very different. So it is very difficult to merge into a exynos pcie file. If possible, we would like to proceed with a new file. Is that possible? Best regards, Wangseok Lee ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver 2022-07-14 9:59 ` [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver Wangseok Lee @ 2022-07-15 11:33 ` Vinod Koul 0 siblings, 0 replies; 30+ messages in thread From: Vinod Koul @ 2022-07-15 11:33 UTC (permalink / raw) To: Wangseok Lee Cc: robh+dt, krzk+dt, kishon, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel, Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 14-07-22, 18:59, Wangseok Lee wrote: > On 07-07-22, 01:52, Vinod Koul wrote: > > On 06-07-22, 17:10, Wangseok Lee wrote: > Sorry for late reply. > > Above all, the IP blocks of phy-exynos-pcie.c and artpec8's pcie phy are > different. As a result, the H/W architecture and operation sequence is > very different. So it is very difficult to merge into a exynos pcie file. > If possible, we would like to proceed with a new file. Is that possible? Okay lets try that -- ~Vinod ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 3/5] PCI: axis: Add ARTPEC-8 PCIe controller driver [not found] <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p7> 2022-06-14 1:16 ` [PATCH v3 0/5] Add support for Axis, ARTPEC-8 PCIe driver Wangseok Lee @ 2022-06-21 7:56 ` Wangseok Lee 2022-07-06 5:20 ` [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy Wangseok Lee 2 siblings, 0 replies; 30+ messages in thread From: Wangseok Lee @ 2022-06-21 7:56 UTC (permalink / raw) To: Krzysztof Kozlowski, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 20/06/2022 17:35, Krzysztof Kozlowski wrote: > On 14/06/2022 03:30, Wangseok Lee wrote: >> Add support Axis, ARTPEC-8 SoC. >> ARTPEC-8 is the SoC platform of Axis Communications. >> > > (...) > >> + >> +enum artpec8_pcie_isolation { >> + PCIE_CLEAR_ISOLATION = 0, >> + PCIE_SET_ISOLATION = 1 >> +}; >> + >> +enum artpec8_pcie_reg_bit { >> + PCIE_REG_BIT_LOW = 0, >> + PCIE_REG_BIT_HIGH = 1 >> +}; > > Remove this enum. This is redefinition of true/false or 1/0. > > Best regards, > Krzysztof ok, i will change the above enum types to boolean. Thank you for kindness reivew. Best regards, Wangseok Lee ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy [not found] <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p7> 2022-06-14 1:16 ` [PATCH v3 0/5] Add support for Axis, ARTPEC-8 PCIe driver Wangseok Lee 2022-06-21 7:56 ` [PATCH v3 3/5] PCI: axis: Add ARTPEC-8 PCIe controller driver Wangseok Lee @ 2022-07-06 5:20 ` Wangseok Lee 2 siblings, 0 replies; 30+ messages in thread From: Wangseok Lee @ 2022-07-06 5:20 UTC (permalink / raw) To: Krzysztof Kozlowski, robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson, lars.persson, bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi, kw, linux-arm-kernel, kernel Cc: Moon-Ki Jun, Sang Min Kim, Dongjin Yang, Yeeun Kim On 05/07/2022 19:59, Krzysztof Kozlowski wrote: > On 29/06/2022 09:18, Wangseok Lee wrote: >> Just a gentle ping for this patch, if any concern on this patch please let me know. >> > > You received comments to fix in this patch. Exactly four. Four important > points to fix. Therefore what is this ping about? > > Without fixing these items, your patch cannot be accepted. What is more > to ping here? > > Best regards, > Krzysztof I tried to receive your opinion about the fix point . I will request a review again after modifying it in the next patch. Thank you. >>> + >>> + clocks: >>> + items: >>> + - description: PCIe PHY reference clock > > refer to sample-schema.yaml, even if the clock item is single, > it seems to be used as follows. > > clocks: > maxItems: 1 > > clock-names: > items: > - const: ref > > If only "clocks:" are define and clock-names are not define, > the following warning occurs. > "'clock-names' does not match any of the regexes" > >>> + >>> + lcpll-ref-clk: >>> + const: 1 >> >> Unknown field... custom properties need vendor (axis,), type (boolean) >> and description. >> > > "lcpl-ref-clk" has an enum type value, so i will modify it as below. > > > axis,lcpll-ref-clk: > description: > select the reference clock of phy and initialization is performed > with the reference clock according to the selected value. > $ref: /schemas/types.yaml#/definitions/uint32 > enum: [ 0, 1, 2, 3, 4 ] > ^ permalink raw reply [flat|nested] 30+ messages in thread
end of thread, other threads:[~2022-07-15 11:33 UTC | newest]
Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p7>
2022-06-14 1:16 ` [PATCH v3 0/5] Add support for Axis, ARTPEC-8 PCIe driver Wangseok Lee
[not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p3>
2022-06-14 1:30 ` [PATCH v3 3/5] PCI: axis: Add ARTPEC-8 PCIe controller driver Wangseok Lee
2022-06-20 8:35 ` Krzysztof Kozlowski
[not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p8>
2022-06-14 1:27 ` [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller Wangseok Lee
2022-06-16 22:54 ` Krzysztof Kozlowski
2022-06-14 1:34 ` [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver Wangseok Lee
2022-07-05 6:21 ` Vinod Koul
[not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p6>
2022-06-14 1:36 ` [PATCH v3 5/5] MAINTAINERS: Add Axis ARTPEC-8 PCIe PHY maintainers Wangseok Lee
2022-06-20 7:55 ` [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller Wangseok Lee
2022-06-20 8:42 ` Krzysztof Kozlowski
[not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p2>
2022-06-21 7:42 ` Wangseok Lee
2022-06-21 12:44 ` Krzysztof Kozlowski
[not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p4>
2022-06-22 7:20 ` Wangseok Lee
2022-07-06 5:22 ` [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy Wangseok Lee
2022-07-06 6:28 ` Krzysztof Kozlowski
2022-06-29 7:18 ` Wangseok Lee
2022-07-05 10:56 ` Krzysztof Kozlowski
2022-07-06 8:10 ` [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver Wangseok Lee
2022-07-06 16:51 ` Vinod Koul
[not found] ` <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p5>
2022-06-14 1:29 ` [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy Wangseok Lee
2022-06-16 22:58 ` Krzysztof Kozlowski
2022-06-20 8:38 ` Wangseok Lee
2022-06-21 21:13 ` Bjorn Helgaas
[not found] ` <CGME20220621212357epcas2p41ecf1ace5d207b154cc77dac79bc7e53@epcms2p2>
2022-06-22 7:06 ` Wangseok Lee
2022-06-22 7:21 ` [PATCH v3 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller Wangseok Lee
2022-06-23 8:27 ` Krzysztof Kozlowski
2022-07-14 9:59 ` [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver Wangseok Lee
2022-07-15 11:33 ` Vinod Koul
2022-06-21 7:56 ` [PATCH v3 3/5] PCI: axis: Add ARTPEC-8 PCIe controller driver Wangseok Lee
2022-07-06 5:20 ` [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy Wangseok Lee
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).