RE: [PATCH v2 02/11] drivers: clk: renesas: r9a07g044-cpg: Rename divider table

[Biju Das <biju.das.jz@bp.renesas.com>]

Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH v2 02/11] drivers: clk: renesas: r9a07g044-cpg: Rename
> divider table
> 
> Hi Biju,
> 
> Thanks for your patch!
> 
> On Thu, Jun 24, 2021 at 3:02 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > As per RZ/G2L HW Manual (Rev.0.50), CPG_PL3A_DDIV,CPG_PL3B_DDIV and
> > CPG_PL2_DDIV(for P0) shares same divider table entries. Rename
> > clk_div_table dtable_3b to clk_div_table dtable_1_32 so that it
> 
> This does not match the actual variable name.
> I do like the shorter name, though ;-)

OK, will change actual variable name with dtable_1_32.

Regards,
Biju

> > can be reused.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Apart from that:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> > --- a/drivers/clk/renesas/r9a07g044-cpg.c
> > +++ b/drivers/clk/renesas/r9a07g044-cpg.c
> > @@ -42,12 +42,13 @@ enum clk_ids {
> >  };
> >
> >  /* Divider tables */
> > -static const struct clk_div_table dtable_3b[] = {
> > +static const struct clk_div_table dtable_common_1_32[] = {
> >         {0, 1},
> >         {1, 2},
> >         {2, 4},
> >         {3, 8},
> >         {4, 32},
> > +       {0, 0},
> >  };
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds