* [PATCH] iio: adc: sun4i-gpadc-iio: adaptation interrupt number @ 2022-08-25 11:47 fuyao 2022-08-25 20:18 ` Jernej Škrabec 2023-12-20 7:08 ` fuyao 0 siblings, 2 replies; 13+ messages in thread From: fuyao @ 2022-08-25 11:47 UTC (permalink / raw) To: Lee Jones, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-arm-kernel, linux-sunxi, linux-kernel Cc: Maxime Ripard, maijianzhang __platform_get_irq_byname determinies whether the interrupt number is 0 and returns EINVAL. Signed-off-by: fuyao <fuyao1697@cyg.com> --- include/linux/mfd/sun4i-gpadc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h index ea0ccf33a459..021f820f9d52 100644 --- a/include/linux/mfd/sun4i-gpadc.h +++ b/include/linux/mfd/sun4i-gpadc.h @@ -81,8 +81,8 @@ #define SUN4I_GPADC_TEMP_DATA 0x20 #define SUN4I_GPADC_DATA 0x24 -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 /* 10s delay before suspending the IP */ #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 -- 2.32.0 -- Technology is exciting ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] iio: adc: sun4i-gpadc-iio: adaptation interrupt number 2022-08-25 11:47 [PATCH] iio: adc: sun4i-gpadc-iio: adaptation interrupt number fuyao @ 2022-08-25 20:18 ` Jernej Škrabec 2022-09-08 6:55 ` Lee Jones 2023-12-20 7:08 ` fuyao 1 sibling, 1 reply; 13+ messages in thread From: Jernej Škrabec @ 2022-08-25 20:18 UTC (permalink / raw) To: Lee Jones, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-arm-kernel, linux-sunxi, linux-kernel, Maxime Ripard, maijianzhang Dne četrtek, 25. avgust 2022 ob 13:47:26 CEST je fuyao napisal(a): > __platform_get_irq_byname determinies whether the interrupt > number is 0 and returns EINVAL. > > Signed-off-by: fuyao <fuyao1697@cyg.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > --- > include/linux/mfd/sun4i-gpadc.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mfd/sun4i-gpadc.h > b/include/linux/mfd/sun4i-gpadc.h index ea0ccf33a459..021f820f9d52 100644 > --- a/include/linux/mfd/sun4i-gpadc.h > +++ b/include/linux/mfd/sun4i-gpadc.h > @@ -81,8 +81,8 @@ > #define SUN4I_GPADC_TEMP_DATA 0x20 > #define SUN4I_GPADC_DATA 0x24 > > -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 > -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 > +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 > +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 > > /* 10s delay before suspending the IP */ > #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 > -- > 2.32.0 > > > -- > Technology is exciting ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] iio: adc: sun4i-gpadc-iio: adaptation interrupt number 2022-08-25 20:18 ` Jernej Škrabec @ 2022-09-08 6:55 ` Lee Jones 2023-12-20 7:15 ` [PATCH RESEND] " fuyao 2023-12-20 7:23 ` fuyao 0 siblings, 2 replies; 13+ messages in thread From: Lee Jones @ 2022-09-08 6:55 UTC (permalink / raw) To: Jernej Škrabec Cc: Chen-Yu Tsai, Samuel Holland, linux-arm-kernel, linux-sunxi, linux-kernel, Maxime Ripard, maijianzhang On Thu, 25 Aug 2022, Jernej Škrabec wrote: > Dne četrtek, 25. avgust 2022 ob 13:47:26 CEST je fuyao napisal(a): > > __platform_get_irq_byname determinies whether the interrupt > > number is 0 and returns EINVAL. > > > > Signed-off-by: fuyao <fuyao1697@cyg.com> > > Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> This patch does not appear to be in my inbox. Please [RESEND], with Jernej's Ack applied, thanks. -- Lee Jones [李琼斯] ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number 2022-09-08 6:55 ` Lee Jones @ 2023-12-20 7:15 ` fuyao 2023-12-20 7:23 ` fuyao 1 sibling, 0 replies; 13+ messages in thread From: fuyao @ 2023-12-20 7:15 UTC (permalink / raw) To: Lee Jones, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-arm-kernel, linux-sunxi, linux-kernel Cc: Maxime Ripard, maijianzhang __platform_get_irq_byname determinies whether the interrupt number is 0 and returns EINVAL. Signed-off-by: fuyao <fuyao1697@cyg.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> --- include/linux/mfd/sun4i-gpadc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h index ea0ccf33a459..021f820f9d52 100644 --- a/include/linux/mfd/sun4i-gpadc.h +++ b/include/linux/mfd/sun4i-gpadc.h @@ -81,8 +81,8 @@ #define SUN4I_GPADC_TEMP_DATA 0x20 #define SUN4I_GPADC_DATA 0x24 -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 /* 10s delay before suspending the IP */ #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 -- 2.32.0 -- CYG Technology From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7BEFC04AA5 for <linux-arm-kernel@archiver.kernel.org>; Thu, 25 Aug 2022 11:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=43HWo/ZUnCasly+ZDH2iZ6YziJoEl7DGgRHVq1AWHGA=; b=N4HqsZY4E2SL6r coTCsOX2hRzQ7B0a1T00J2VkAPl7AipXosk76WMzyfIWnLKRkW8uqqBXKpQ2sHn25CKHP+ZW5UpiD 6l25/vh+YIPuTKjxd22dXb3QWpmIObDbHRRIOZSAWMBva+k42rsgsfgRyYKOI/+fBRoqDqFZHrjV1 LbiROW7b0SqMq6vAWAjGQvRON+qQDsqqpadEY+j508ViyVZdDIB2TY1zdy6uTAc4QqMRmzUH2NP7W eSzjr4Kd1dtJMmykNtjjlIm/7IPwpXbHb72IdX1lzo27891mjNCP6V6fToGXw+s5RFS1qHaRuZ+XB 8g9p7pCDPqH/9eUb74/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRBPm-00D1Ka-Ur; Thu, 25 Aug 2022 11:52:51 +0000 Received: from out20-123.mail.aliyun.com ([115.124.20.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRBPk-00D1FB-2p for linux-arm-kernel@lists.infradead.org; Thu, 25 Aug 2022 11:52:49 +0000 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.3045855|-1;BR=01201311R131S89rulernew998_84748_2000303;CH=blue;DM=|CONTINUE|false|;DS=CONTINUE|ham_system_inform|0.025949-0.00105542-0.972996;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047190;MF=fuyao@sjterm.com;NM=1;PH=DS;RN=9;RT=9;SR=0;TI=SMTPD_---.P.m81RD_1661428046; Received: from localhost(mailfrom:fuyao@sjterm.com fp:SMTPD_---.P.m81RD_1661428046) by smtp.aliyun-inc.com; Thu, 25 Aug 2022 19:47:26 +0800 Date: Thu, 25 Aug 2022 19:47:26 +0800 From: fuyao <fuyao1697@cyg.com> To: Lee Jones <lee@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Maxime Ripard <mripard@kernel.org>, maijianzhang <maijianzhang@allwinnertech.com> Subject: [PATCH] iio: adc: sun4i-gpadc-iio: adaptation interrupt number Message-ID: <YwdhTlk+7h+FMrwm@scg> Mail-Followup-To: Lee Jones <lee@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>, maijianzhang <maijianzhang@allwinnertech.com> MIME-Version: 1.0 Content-Disposition: inline Organization: work_work_work X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220825_045248_320501_10DAB7D1 X-CRM114-Status: UNSURE ( 9.15 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org __platform_get_irq_byname determinies whether the interrupt number is 0 and returns EINVAL. Signed-off-by: fuyao <fuyao1697@cyg.com> --- include/linux/mfd/sun4i-gpadc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h index ea0ccf33a459..021f820f9d52 100644 --- a/include/linux/mfd/sun4i-gpadc.h +++ b/include/linux/mfd/sun4i-gpadc.h @@ -81,8 +81,8 @@ #define SUN4I_GPADC_TEMP_DATA 0x20 #define SUN4I_GPADC_DATA 0x24 -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 /* 10s delay before suspending the IP */ #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 -- 2.32.0 -- Technology is exciting _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- CYG Technology. ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number 2022-09-08 6:55 ` Lee Jones 2023-12-20 7:15 ` [PATCH RESEND] " fuyao @ 2023-12-20 7:23 ` fuyao 2023-12-20 11:54 ` Andre Przywara 1 sibling, 1 reply; 13+ messages in thread From: fuyao @ 2023-12-20 7:23 UTC (permalink / raw) To: Lee Jones, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-arm-kernel, linux-sunxi, linux-kernel Cc: Maxime Ripard, maijianzhang __platform_get_irq_byname determinies whether the interrupt number is 0 and returns EINVAL. Signed-off-by: fuyao <fuyao1697@cyg.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> --- include/linux/mfd/sun4i-gpadc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h index ea0ccf33a459..021f820f9d52 100644 --- a/include/linux/mfd/sun4i-gpadc.h +++ b/include/linux/mfd/sun4i-gpadc.h @@ -81,8 +81,8 @@ #define SUN4I_GPADC_TEMP_DATA 0x20 #define SUN4I_GPADC_DATA 0x24 -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 /* 10s delay before suspending the IP */ #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 -- 2.32.0 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number 2023-12-20 7:23 ` fuyao @ 2023-12-20 11:54 ` Andre Przywara 2023-12-21 15:25 ` Lee Jones 2023-12-25 9:52 ` fuyao 0 siblings, 2 replies; 13+ messages in thread From: Andre Przywara @ 2023-12-20 11:54 UTC (permalink / raw) To: fuyao Cc: Lee Jones, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-arm-kernel, linux-sunxi, linux-kernel, Maxime Ripard, maijianzhang On Wed, 20 Dec 2023 15:23:17 +0800 fuyao <fuyao1697@cyg.com> wrote: Hi, > __platform_get_irq_byname determinies whether the interrupt > number is 0 and returns EINVAL. can you please say what this fixes, exactly? Is something not working at the moment? Can you please provide parts of the error message? And maybe expand the explanation a bit more? For instance mention that the identifiers are used as IRQ resource numbers, where 0 is treated specially. Cheers, Andre > > Signed-off-by: fuyao <fuyao1697@cyg.com> > Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> > --- > include/linux/mfd/sun4i-gpadc.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h > index ea0ccf33a459..021f820f9d52 100644 > --- a/include/linux/mfd/sun4i-gpadc.h > +++ b/include/linux/mfd/sun4i-gpadc.h > @@ -81,8 +81,8 @@ > #define SUN4I_GPADC_TEMP_DATA 0x20 > #define SUN4I_GPADC_DATA 0x24 > > -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 > -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 > +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 > +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 > > /* 10s delay before suspending the IP */ > #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number 2023-12-20 11:54 ` Andre Przywara @ 2023-12-21 15:25 ` Lee Jones 2023-12-21 15:26 ` Lee Jones 2023-12-22 17:54 ` Jernej Škrabec 2023-12-25 9:52 ` fuyao 1 sibling, 2 replies; 13+ messages in thread From: Lee Jones @ 2023-12-21 15:25 UTC (permalink / raw) To: Andre Przywara Cc: fuyao, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-arm-kernel, linux-sunxi, linux-kernel, Maxime Ripard, maijianzhang On Wed, 20 Dec 2023, Andre Przywara wrote: > On Wed, 20 Dec 2023 15:23:17 +0800 > fuyao <fuyao1697@cyg.com> wrote: > > Hi, > > > __platform_get_irq_byname determinies whether the interrupt > > number is 0 and returns EINVAL. > > can you please say what this fixes, exactly? Is something not working at > the moment? Can you please provide parts of the error message? > > And maybe expand the explanation a bit more? For instance mention that the > identifiers are used as IRQ resource numbers, where 0 is treated specially. > > Cheers, > Andre > > > > > Signed-off-by: fuyao <fuyao1697@cyg.com> You have to use your full real name as well. > > Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> > > --- > > include/linux/mfd/sun4i-gpadc.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h > > index ea0ccf33a459..021f820f9d52 100644 > > --- a/include/linux/mfd/sun4i-gpadc.h > > +++ b/include/linux/mfd/sun4i-gpadc.h > > @@ -81,8 +81,8 @@ > > #define SUN4I_GPADC_TEMP_DATA 0x20 > > #define SUN4I_GPADC_DATA 0x24 > > > > -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 > > -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 > > +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 > > +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 > > > > /* 10s delay before suspending the IP */ > > #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 > -- Lee Jones [李琼斯] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number 2023-12-21 15:25 ` Lee Jones @ 2023-12-21 15:26 ` Lee Jones 2023-12-22 17:54 ` Jernej Škrabec 1 sibling, 0 replies; 13+ messages in thread From: Lee Jones @ 2023-12-21 15:26 UTC (permalink / raw) To: Andre Przywara Cc: fuyao, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-arm-kernel, linux-sunxi, linux-kernel, Maxime Ripard, maijianzhang On Thu, 21 Dec 2023, Lee Jones wrote: > On Wed, 20 Dec 2023, Andre Przywara wrote: > > > On Wed, 20 Dec 2023 15:23:17 +0800 > > fuyao <fuyao1697@cyg.com> wrote: > > > > Hi, > > > > > __platform_get_irq_byname determinies whether the interrupt > > > number is 0 and returns EINVAL. > > > > can you please say what this fixes, exactly? Is something not working at > > the moment? Can you please provide parts of the error message? > > > > And maybe expand the explanation a bit more? For instance mention that the > > identifiers are used as IRQ resource numbers, where 0 is treated specially. > > > > Cheers, > > Andre > > > > > > > > Signed-off-by: fuyao <fuyao1697@cyg.com> > > You have to use your full real name as well. > > > > Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> > > > --- > > > include/linux/mfd/sun4i-gpadc.h | 4 ++-- Also the subject line is wrong. This doesn't have anything to do with IIO. > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h > > > index ea0ccf33a459..021f820f9d52 100644 > > > --- a/include/linux/mfd/sun4i-gpadc.h > > > +++ b/include/linux/mfd/sun4i-gpadc.h > > > @@ -81,8 +81,8 @@ > > > #define SUN4I_GPADC_TEMP_DATA 0x20 > > > #define SUN4I_GPADC_DATA 0x24 > > > > > > -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 > > > -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 > > > +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 > > > +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 > > > > > > /* 10s delay before suspending the IP */ > > > #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 > > > > -- > Lee Jones [李琼斯] -- Lee Jones [李琼斯] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number 2023-12-21 15:25 ` Lee Jones 2023-12-21 15:26 ` Lee Jones @ 2023-12-22 17:54 ` Jernej Škrabec 2023-12-25 9:54 ` fuyao 2024-01-09 8:55 ` Lee Jones 1 sibling, 2 replies; 13+ messages in thread From: Jernej Škrabec @ 2023-12-22 17:54 UTC (permalink / raw) To: Andre Przywara, Lee Jones Cc: fuyao, Chen-Yu Tsai, Samuel Holland, linux-arm-kernel, linux-sunxi, linux-kernel, Maxime Ripard, maijianzhang Dne četrtek, 21. december 2023 ob 16:25:53 CET je Lee Jones napisal(a): > On Wed, 20 Dec 2023, Andre Przywara wrote: > > > On Wed, 20 Dec 2023 15:23:17 +0800 > > fuyao <fuyao1697@cyg.com> wrote: > > > > Hi, > > > > > __platform_get_irq_byname determinies whether the interrupt > > > number is 0 and returns EINVAL. > > > > can you please say what this fixes, exactly? Is something not working at > > the moment? Can you please provide parts of the error message? > > > > And maybe expand the explanation a bit more? For instance mention that the > > identifiers are used as IRQ resource numbers, where 0 is treated specially. > > > > Cheers, > > Andre > > > > > > > > Signed-off-by: fuyao <fuyao1697@cyg.com> > > You have to use your full real name as well. Isn't that enough after https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d4563201f33a022fc0353033d9dfeb1606a88330 ? Best regards, Jernej > > > > Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> > > > --- > > > include/linux/mfd/sun4i-gpadc.h | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h > > > index ea0ccf33a459..021f820f9d52 100644 > > > --- a/include/linux/mfd/sun4i-gpadc.h > > > +++ b/include/linux/mfd/sun4i-gpadc.h > > > @@ -81,8 +81,8 @@ > > > #define SUN4I_GPADC_TEMP_DATA 0x20 > > > #define SUN4I_GPADC_DATA 0x24 > > > > > > -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 > > > -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 > > > +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 > > > +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 > > > > > > /* 10s delay before suspending the IP */ > > > #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number 2023-12-22 17:54 ` Jernej Škrabec @ 2023-12-25 9:54 ` fuyao 2024-01-09 8:55 ` Lee Jones 1 sibling, 0 replies; 13+ messages in thread From: fuyao @ 2023-12-25 9:54 UTC (permalink / raw) To: Jernej Škrabec, Lee Jones Cc: Andre Przywara, Lee Jones, fuyao, Chen-Yu Tsai, Samuel Holland, linux-arm-kernel, linux-sunxi, linux-kernel, Maxime Ripard, maijianzhang On Fri, Dec 22, 2023 at 06:54:53PM +0100, Jernej Škrabec wrote: > Dne četrtek, 21. december 2023 ob 16:25:53 CET je Lee Jones napisal(a): > > On Wed, 20 Dec 2023, Andre Przywara wrote: > > > > > On Wed, 20 Dec 2023 15:23:17 +0800 > > > fuyao <fuyao1697@cyg.com> wrote: > > > > > > Hi, > > > > > > > __platform_get_irq_byname determinies whether the interrupt > > > > number is 0 and returns EINVAL. > > > > > > can you please say what this fixes, exactly? Is something not working at > > > the moment? Can you please provide parts of the error message? > > > > > > And maybe expand the explanation a bit more? For instance mention that the > > > identifiers are used as IRQ resource numbers, where 0 is treated specially. > > > > > > Cheers, > > > Andre > > > > > > > > > > > Signed-off-by: fuyao <fuyao1697@cyg.com> > > > > You have to use your full real name as well. > > Isn't that enough after > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d4563201f33a022fc0353033d9dfeb1606a88330 ? Thanks > > Best regards, > Jernej > > > > > > > Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> > > > > --- > > > > include/linux/mfd/sun4i-gpadc.h | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h > > > > index ea0ccf33a459..021f820f9d52 100644 > > > > --- a/include/linux/mfd/sun4i-gpadc.h > > > > +++ b/include/linux/mfd/sun4i-gpadc.h > > > > @@ -81,8 +81,8 @@ > > > > #define SUN4I_GPADC_TEMP_DATA 0x20 > > > > #define SUN4I_GPADC_DATA 0x24 > > > > > > > > -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 > > > > -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 > > > > +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 > > > > +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 > > > > > > > > /* 10s delay before suspending the IP */ > > > > #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 > > > > > > > > > > > -- CYG Technology. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number 2023-12-22 17:54 ` Jernej Škrabec 2023-12-25 9:54 ` fuyao @ 2024-01-09 8:55 ` Lee Jones 1 sibling, 0 replies; 13+ messages in thread From: Lee Jones @ 2024-01-09 8:55 UTC (permalink / raw) To: Jernej Škrabec Cc: Andre Przywara, fuyao, Chen-Yu Tsai, Samuel Holland, linux-arm-kernel, linux-sunxi, linux-kernel, Maxime Ripard, maijianzhang On Fri, 22 Dec 2023, Jernej Škrabec wrote: > Dne četrtek, 21. december 2023 ob 16:25:53 CET je Lee Jones napisal(a): > > On Wed, 20 Dec 2023, Andre Przywara wrote: > > > > > On Wed, 20 Dec 2023 15:23:17 +0800 > > > fuyao <fuyao1697@cyg.com> wrote: > > > > > > Hi, > > > > > > > __platform_get_irq_byname determinies whether the interrupt > > > > number is 0 and returns EINVAL. > > > > > > can you please say what this fixes, exactly? Is something not working at > > > the moment? Can you please provide parts of the error message? > > > > > > And maybe expand the explanation a bit more? For instance mention that the > > > identifiers are used as IRQ resource numbers, where 0 is treated specially. > > > > > > Cheers, > > > Andre > > > > > > > > > > > Signed-off-by: fuyao <fuyao1697@cyg.com> > > > > You have to use your full real name as well. > > Isn't that enough after > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d4563201f33a022fc0353033d9dfeb1606a88330 ? I believe that change in stance is to be more accepting of people who are universally known by their pseudonyms, like Tixy, Wookey or Piglet, to name a few that I'm aware of. If fuyao is universally known by that name then sure, it's enough. It just doesn't look very name-like in its current guise, due to the shortness and lack of capitalisation. It looks to me more like a username, which is not as generally acceptable AFAIA. -- Lee Jones [李琼斯] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number 2023-12-20 11:54 ` Andre Przywara 2023-12-21 15:25 ` Lee Jones @ 2023-12-25 9:52 ` fuyao 1 sibling, 0 replies; 13+ messages in thread From: fuyao @ 2023-12-25 9:52 UTC (permalink / raw) To: Andre Przywara Cc: fuyao, Lee Jones, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-arm-kernel, linux-sunxi, linux-kernel, Maxime Ripard, maijianzhang On Wed, Dec 20, 2023 at 11:54:12AM +0000, Andre Przywara wrote: > On Wed, 20 Dec 2023 15:23:17 +0800 > fuyao <fuyao1697@cyg.com> wrote: > > Hi, > > > __platform_get_irq_byname determinies whether the interrupt > > number is 0 and returns EINVAL. > > can you please say what this fixes, exactly? Is something not working at > the moment? Can you please provide parts of the error message? > With open MFD_SUN4I_GPADC and SUN4I_GPADC, It happens: [ 0.185068] ------------[ cut here ]------------ [ 0.185093] WARNING: CPU: 3 PID: 1 at drivers/base/platform.c:451 __platform_get_irq_byname+0xb8/0xc4 [ 0.185131] 0 is an invalid IRQ number [ 0.185140] Modules linked in: [ 0.185160] CPU: 3 PID: 1 Comm: swapper/0 Not tainted 6.7.0-rc6 #9 [ 0.185179] Hardware name: Allwinner sun8i Family [ 0.185203] unwind_backtrace from show_stack+0x10/0x14 [ 0.185234] show_stack from dump_stack_lvl+0x48/0x54 [ 0.185262] dump_stack_lvl from __warn+0xcc/0x1ac [ 0.185285] __warn from warn_slowpath_fmt+0xb4/0x168 [ 0.185304] warn_slowpath_fmt from __platform_get_irq_byname+0xb8/0xc4 [ 0.185328] __platform_get_irq_byname from platform_get_irq_byname+0x10/0x38 [ 0.185354] platform_get_irq_byname from sun4i_irq_init+0x40/0xdc [ 0.185382] sun4i_irq_init from sun4i_gpadc_probe+0x1cc/0x310 [ 0.185403] sun4i_gpadc_probe from platform_probe+0x98/0xc0 [ 0.185426] platform_probe from really_probe+0x10c/0x374 [ 0.185450] really_probe from __driver_probe_device+0x90/0x188 [ 0.185473] __driver_probe_device from driver_probe_device+0x3c/0x198 [ 0.185496] driver_probe_device from __driver_attach+0x118/0x1b4 [ 0.185518] __driver_attach from bus_for_each_dev+0x104/0x148 [ 0.185540] bus_for_each_dev from bus_add_driver+0x164/0x25c [ 0.185560] bus_add_driver from driver_register+0x70/0x118 [ 0.185582] driver_register from do_one_initcall+0xcc/0x29c [ 0.185605] do_one_initcall from do_initcall_level+0x80/0x8c [ 0.185630] do_initcall_level from do_initcalls+0x50/0x80 [ 0.185653] do_initcalls from kernel_init_freeable+0xb0/0xfc [ 0.185675] kernel_init_freeable from kernel_init+0x14/0x1b4 [ 0.185698] kernel_init from ret_from_fork+0x14/0x28 [ 0.185720] Exception stack(0xf0825fb0 to 0xf0825ff8) [ 0.185737] 5fa0: 00000000 00000000 00000000 00000000 [ 0.185756] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 0.185775] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 0.185788] ---[ end trace 0000000000000000 ]--- [ 0.185804] sun4i-gpadc-iio sun6i-a31-gpadc-iio.0: error -EINVAL: IRQ FIFO_DATA_PENDING not found [ 0.185828] sun4i-gpadc-iio: probe of sun6i-a31-gpadc-iio.0 failed with error -22 The gpadc-iio can not request irq. > And maybe expand the explanation a bit more? For instance mention that the > identifiers are used as IRQ resource numbers, where 0 is treated specially. > thanks > Cheers, > Andre > > > > > Signed-off-by: fuyao <fuyao1697@cyg.com> > > Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> > > --- > > include/linux/mfd/sun4i-gpadc.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h > > index ea0ccf33a459..021f820f9d52 100644 > > --- a/include/linux/mfd/sun4i-gpadc.h > > +++ b/include/linux/mfd/sun4i-gpadc.h > > @@ -81,8 +81,8 @@ > > #define SUN4I_GPADC_TEMP_DATA 0x20 > > #define SUN4I_GPADC_DATA 0x24 > > > > -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 > > -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 > > +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 > > +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 > > > > /* 10s delay before suspending the IP */ > > #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 > -- CYG Technology. ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number 2022-08-25 11:47 [PATCH] iio: adc: sun4i-gpadc-iio: adaptation interrupt number fuyao 2022-08-25 20:18 ` Jernej Škrabec @ 2023-12-20 7:08 ` fuyao 1 sibling, 0 replies; 13+ messages in thread From: fuyao @ 2023-12-20 7:08 UTC (permalink / raw) To: Lee Jones, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-arm-kernel, linux-sunxi, linux-kernel Cc: Maxime Ripard, maijianzhang __platform_get_irq_byname determinies whether the interrupt number is 0 and returns EINVAL. Signed-off-by: fuyao <fuyao1697@cyg.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> --- include/linux/mfd/sun4i-gpadc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h index ea0ccf33a459..021f820f9d52 100644 --- a/include/linux/mfd/sun4i-gpadc.h +++ b/include/linux/mfd/sun4i-gpadc.h @@ -81,8 +81,8 @@ #define SUN4I_GPADC_TEMP_DATA 0x20 #define SUN4I_GPADC_DATA 0x24 -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 /* 10s delay before suspending the IP */ #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 -- 2.32.0 -- Technology is exciting From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7BEFC04AA5 for <linux-arm-kernel@archiver.kernel.org>; Thu, 25 Aug 2022 11:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=43HWo/ZUnCasly+ZDH2iZ6YziJoEl7DGgRHVq1AWHGA=; b=N4HqsZY4E2SL6r coTCsOX2hRzQ7B0a1T00J2VkAPl7AipXosk76WMzyfIWnLKRkW8uqqBXKpQ2sHn25CKHP+ZW5UpiD 6l25/vh+YIPuTKjxd22dXb3QWpmIObDbHRRIOZSAWMBva+k42rsgsfgRyYKOI/+fBRoqDqFZHrjV1 LbiROW7b0SqMq6vAWAjGQvRON+qQDsqqpadEY+j508ViyVZdDIB2TY1zdy6uTAc4QqMRmzUH2NP7W eSzjr4Kd1dtJMmykNtjjlIm/7IPwpXbHb72IdX1lzo27891mjNCP6V6fToGXw+s5RFS1qHaRuZ+XB 8g9p7pCDPqH/9eUb74/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRBPm-00D1Ka-Ur; Thu, 25 Aug 2022 11:52:51 +0000 Received: from out20-123.mail.aliyun.com ([115.124.20.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRBPk-00D1FB-2p for linux-arm-kernel@lists.infradead.org; Thu, 25 Aug 2022 11:52:49 +0000 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.3045855|-1;BR=01201311R131S89rulernew998_84748_2000303;CH=blue;DM=|CONTINUE|false|;DS=CONTINUE|ham_system_inform|0.025949-0.00105542-0.972996;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047190;MF=fuyao@sjterm.com;NM=1;PH=DS;RN=9;RT=9;SR=0;TI=SMTPD_---.P.m81RD_1661428046; Received: from localhost(mailfrom:fuyao@sjterm.com fp:SMTPD_---.P.m81RD_1661428046) by smtp.aliyun-inc.com; Thu, 25 Aug 2022 19:47:26 +0800 Date: Thu, 25 Aug 2022 19:47:26 +0800 From: fuyao <fuyao1697@cyg.com> To: Lee Jones <lee@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Maxime Ripard <mripard@kernel.org>, maijianzhang <maijianzhang@allwinnertech.com> Subject: [PATCH] iio: adc: sun4i-gpadc-iio: adaptation interrupt number Message-ID: <YwdhTlk+7h+FMrwm@scg> Mail-Followup-To: Lee Jones <lee@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>, maijianzhang <maijianzhang@allwinnertech.com> MIME-Version: 1.0 Content-Disposition: inline Organization: work_work_work X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220825_045248_320501_10DAB7D1 X-CRM114-Status: UNSURE ( 9.15 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org __platform_get_irq_byname determinies whether the interrupt number is 0 and returns EINVAL. Signed-off-by: fuyao <fuyao1697@cyg.com> --- include/linux/mfd/sun4i-gpadc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h index ea0ccf33a459..021f820f9d52 100644 --- a/include/linux/mfd/sun4i-gpadc.h +++ b/include/linux/mfd/sun4i-gpadc.h @@ -81,8 +81,8 @@ #define SUN4I_GPADC_TEMP_DATA 0x20 #define SUN4I_GPADC_DATA 0x24 -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 /* 10s delay before suspending the IP */ #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 -- 2.32.0 -- Technology is exciting _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- CYG Technology. ^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2024-01-09 8:56 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-08-25 11:47 [PATCH] iio: adc: sun4i-gpadc-iio: adaptation interrupt number fuyao 2022-08-25 20:18 ` Jernej Škrabec 2022-09-08 6:55 ` Lee Jones 2023-12-20 7:15 ` [PATCH RESEND] " fuyao 2023-12-20 7:23 ` fuyao 2023-12-20 11:54 ` Andre Przywara 2023-12-21 15:25 ` Lee Jones 2023-12-21 15:26 ` Lee Jones 2023-12-22 17:54 ` Jernej Škrabec 2023-12-25 9:54 ` fuyao 2024-01-09 8:55 ` Lee Jones 2023-12-25 9:52 ` fuyao 2023-12-20 7:08 ` fuyao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).